Page MenuHomePhabricator

Request for DiscussionTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Use this project to tag tasks and other stuff that should be discussed in the weekly MITK meeting.

Recent Activity

Yesterday

floca triaged T27649: [Segmentation] How should tools listen to time changes as Unbreak Now! priority.
Tue, Aug 4, 9:41 PM · Request for Discussion, MITK (2020)
thomass triaged T27646: [Data manager] Option to change color of segmentation disappeared in data manager as Normal priority.
Tue, Aug 4, 2:31 PM · Request for Discussion, MITK

Fri, Jul 31

floca triaged T27637: [Segmentation] Multilable label name dialoge on label creation is a UX problem as Normal priority.
Fri, Jul 31, 1:10 PM · Request for Discussion, MITK

Tue, Jul 28

kislinsk merged task T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit into T27613: Improve reinit behavior.
Tue, Jul 28, 9:57 AM · Request for Discussion, MITK (2020)

Fri, Jul 24

floca added a comment to T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images.

+1

Fri, Jul 24, 5:21 PM · Request for Discussion, Missing Info, MITK (2020)
kislinsk closed T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images as Resolved.

Yes.

Fri, Jul 24, 4:22 PM · Request for Discussion, Missing Info, MITK (2020)
floca added a comment to T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images.

@kislinsk/@kalali Is this bug also solved due to your fix of T27386?

Fri, Jul 24, 3:52 PM · Request for Discussion, Missing Info, MITK (2020)

Thu, Jul 23

floca added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

Ok. @kalali Thank you very much for the clarification.

Thu, Jul 23, 6:04 PM · Request for Discussion, MITK (2020)
kislinsk triaged T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit as High priority.
Thu, Jul 23, 2:15 PM · Request for Discussion, MITK (2020)
kislinsk added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

Do I really need to reinit to the segmentation image or am I able to use the segmentation tools if I reinit to the reference image?

Thu, Jul 23, 2:10 PM · Request for Discussion, MITK (2020)
kislinsk added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

Now I understand, thanks. The actual issue is not really related to segmentations in the first place but to the image navigator / world geometry. I guess the logic to limit the time slider (world geometry?) just counts the time steps of the selected data without taking other data into account that may have multiple time steps in the same time range. I do not know if this is easy to fix as both scenarios are valid. In terms of modifying segmentations it is pretty bad, but in case you want to focus on or inspect a certain data and reinit to it it would be very confusing to have a different number of timesteps in the slider than the data actually has.

Thu, Jul 23, 2:05 PM · Request for Discussion, MITK (2020)
kalali added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

Well, to be precise: It is not possible to have a static segmentation on a 4D image, reinit it and show another timestep than 0. Is this intended?
What is the workflow for inspecting a 4D image at timestep t != 0 in order to segment something? From what I experience, the user has to initialize the view to the 4D image (not the segmentation) and then change the timestep to the desired one.

Thu, Jul 23, 1:48 PM · Request for Discussion, MITK (2020)
kislinsk added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

Hm, is there a misunderstanding that @kalali thought a static segmentation of a dynamic image covers only a single timestep instead of the whole time range of the dynamic image with a single timestep? So my first guess is that this task is somewhat invalid. Disussing in general if a reinit should also reset the scene timestep to 0 is something we could address separately I guess.

Thu, Jul 23, 11:04 AM · Request for Discussion, MITK (2020)
floca added a comment to T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.

@kalali Could elaborate on the question? I am somewhat drawing a blank what the question or change proposal now is.

Thu, Jul 23, 10:56 AM · Request for Discussion, MITK (2020)
kalali created T27592: [Segmentation] Static mask (3D) of 4D image always shows the 4D image at timestep 0 after reinit.
Thu, Jul 23, 10:36 AM · Request for Discussion, MITK (2020)

Wed, Jul 22

floca moved T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images from Backlog to Segmentation on the MITK (2020) board.
Wed, Jul 22, 11:24 AM · MITK (2020), Request for Discussion
floca edited projects for T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images, added: MITK (2020); removed MITK.
Wed, Jul 22, 11:24 AM · MITK (2020), Request for Discussion
floca added a comment to T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images.

I would propose the following policy:

  1. All tools per default work only on the respective time step of the reference data and the segmentation, that are indicated by the currently selected time point (SliceNavigator). So this is general and independent from the fact if it is a 3D or a 4D segmentation. This is the same behavior like the interactive tools and does not break user expectations.
  2. It is up to the specific tool (must be discussed there) if for 4D reference images others then the current time step of the reference data step should be used. Per se, I would say no.
  3. It is up to the specific (3D) tool to allow the altering of more then the current segmentation time step (if the segmentation is 4D). If one wants such a feature I would add e.g. a check box to the tool like "confirm for all time steps".
Wed, Jul 22, 11:23 AM · MITK (2020), Request for Discussion

Mon, Jul 20

thomass added a comment to T27568: US 2D image cannot be read: invalid tilt information.

Just as a remark: I am getting the exact same error, if I want to load a dcm image from a folder that contains more than one image. Those images originate from a cadaver study which means that before acquisiton most of the patient input data is left blank (study,series etc). If I put the files into separate folders, they are loaded correctly.

Mon, Jul 20, 10:19 AM · Request for Discussion, Restricted Project, MITK
kleesiek added a comment to T27568: US 2D image cannot be read: invalid tilt information.

Thanks for the remarks and solution options.

Mon, Jul 20, 9:13 AM · Request for Discussion, Restricted Project, MITK

Sun, Jul 19

floca added a project to T24710: Check failing dicom data in MITK-Data: DICOM.
Sun, Jul 19, 3:36 PM · DICOM, Request for Discussion, Missing Info, Restricted Project, MITK
floca moved T24710: Check failing dicom data in MITK-Data from Backlog to MITK Meeting on the Request for Discussion board.
Sun, Jul 19, 3:36 PM · DICOM, Request for Discussion, Missing Info, Restricted Project, MITK
floca added a project to T24710: Check failing dicom data in MITK-Data: Request for Discussion.

Update: the root of many cases of this problem are the same as discussed in T27568: US 2D image cannot be read: invalid tilt information. In the mean while some cases (as OT-MONO2-8-colon) work now (due to fixes of T27321 and T27322) others (like CR-MONO1-10-chest-*) still do not work. The reasons and solutions are the same as described in T27568.

Sun, Jul 19, 3:36 PM · DICOM, Request for Discussion, Missing Info, Restricted Project, MITK
floca triaged T27568: US 2D image cannot be read: invalid tilt information as Normal priority.
Sun, Jul 19, 3:09 PM · Request for Discussion, Restricted Project, MITK
floca moved T27568: US 2D image cannot be read: invalid tilt information from Backlog to MITK Meeting on the Request for Discussion board.

Should discuss in the MITK meeting about the solutions.

Sun, Jul 19, 3:04 PM · Request for Discussion, Restricted Project, MITK
floca created T27568: US 2D image cannot be read: invalid tilt information.
Sun, Jul 19, 3:03 PM · Request for Discussion, Restricted Project, MITK

Wed, Jul 15

floca closed T27442: PlanarFigure uses unmanged/uncontrolled pointer for PlaneGeometry, a subtask of T27441: PlanarFigure clone is in invalid state due to copy of unmanged/uncontrolled pointer for PlaneGeometry, as Resolved.
Wed, Jul 15, 3:55 PM · Missing Info, Request for Discussion, MITK (2020)
kahl triaged T27561: Clients for building pyMITK Project as Normal priority.
Wed, Jul 15, 1:14 PM · Request for Discussion, MITK, CI

Fri, Jul 10

floca added a comment to T27548: QtWebEngine generates wrong temp directory.

I guessed so to. For me it is not clear where to query the correct current temp path?

Fri, Jul 10, 8:38 AM · Request for Discussion, MITK
kislinsk added a comment to T27548: QtWebEngine generates wrong temp directory.

Solution is probably QWebEngineProfile::SetCachePath() and SetPersistentStoragePath(): https://stackoverflow.com/questions/37774910/how-to-prevent-creating-strange-folders-while-using-qwebengineview

Fri, Jul 10, 12:05 AM · Request for Discussion, MITK

Thu, Jul 9

floca triaged T27548: QtWebEngine generates wrong temp directory as Normal priority.
Thu, Jul 9, 10:16 PM · Request for Discussion, MITK
kalali moved T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images from Backlog to MITK Meeting on the Request for Discussion board.
Thu, Jul 9, 11:22 AM · Request for Discussion, Missing Info, MITK (2020)
kalali updated subscribers of T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images.

The problem of different class types / image types is also the source for the bug mentioned in T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image.
@floca mentioned to completely remove the autocrop-action from the context menu (at least for the multilabel segmentation) because it is not clear what to expect. Multilabel segmentations offer different possibilities for cropping and this could be handled inside the multilabel segmentation view.
That's also an option I see for the issue mentioned in 2.

Thu, Jul 9, 11:21 AM · Request for Discussion, Missing Info, MITK (2020)
kalali added a project to T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images: Request for Discussion.

@kahl I can confirm your workflow for the ITK NrrdImageIO reader.
@kislinsk I can also confirm that autocrop does not alter the name if used on a binary segmentation.

Thu, Jul 9, 11:14 AM · Request for Discussion, Missing Info, MITK (2020)

Jul 3 2020

kalali updated subscribers of T27524: Should RenderingManager be used without singleton?.
Jul 3 2020, 1:00 PM · Request for Discussion, MITK
floca triaged T27489: Deprecate and correct QmitkSliceWidget? as Low priority.
Jul 3 2020, 11:12 AM · Request for Discussion
floca removed a project from T27489: Deprecate and correct QmitkSliceWidget?: MITK (2020).

@nolden: Do you have a clue? Was it missed when cleaning up or is it there on purpose and should be corrected?

Jul 3 2020, 11:10 AM · Request for Discussion
kalali triaged T27524: Should RenderingManager be used without singleton? as Normal priority.
Jul 3 2020, 10:37 AM · Request for Discussion, MITK

Jul 2 2020

floca moved T27489: Deprecate and correct QmitkSliceWidget? from Backlog to MITK Meeting on the Request for Discussion board.
Jul 2 2020, 8:59 PM · Request for Discussion

Jul 1 2020

floca claimed T27483: DICOM import of multi-channel data not working.
Jul 1 2020, 10:36 AM · MITK (2020), Restricted Project, DICOM

Jun 29 2020

floca added a comment to T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images.

I would propose the following policy:

  1. All tools per default work only on the respective time step of the reference data and the segmentation, that are indicated by the currently selected time point (SliceNavigator). So this is general and independent from the fact if it is a 3D or a 4D segmentation. This is the same behavior like the interactive tools and does not break user expectations.
  2. It is up to the specific tool (must be discussed there) if for 4D reference images others then the current time step of the reference data step should be used. Per se, I would say no.
  3. It is up to the specific (3D) tool to allow the altering of more then the current segmentation time step (if the segmentation is 4D). If one wants such a feature I would add e.g. a check box to the tool like "confirm for all time steps".
Jun 29 2020, 1:48 PM · MITK (2020), Request for Discussion
kalali triaged T27509: [Segmentation] How to handle 3D and 4D Segmentations on 4D images as Normal priority.
Jun 29 2020, 1:36 PM · MITK (2020), Request for Discussion

Jun 25 2020

floca placed T27483: DICOM import of multi-channel data not working up for grabs.

Looked into the topics. Following comments:

Jun 25 2020, 1:47 PM · MITK (2020), Restricted Project, DICOM
floca claimed T27483: DICOM import of multi-channel data not working.
Jun 25 2020, 12:58 PM · MITK (2020), Restricted Project, DICOM

Jun 23 2020

kalali moved T27498: [Selection widgets] Define default for auto selection / listening mechanism from Backlog to MITK Meeting on the Request for Discussion board.
Jun 23 2020, 5:17 PM · Restricted Project, MITK (2020)
kalali renamed T27498: [Selection widgets] Define default for auto selection / listening mechanism from [Selection widgetes] Define default for auto selection / listening mechanism to [Selection widgets] Define default for auto selection / listening mechanism.
Jun 23 2020, 5:17 PM · Restricted Project, MITK (2020)
kalali triaged T27498: [Selection widgets] Define default for auto selection / listening mechanism as Normal priority.
Jun 23 2020, 1:37 PM · Restricted Project, MITK (2020)

Jun 19 2020

floca added a subtask for T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0: T27490: Correct handling of time points selected by SliceNavigator.
Jun 19 2020, 4:03 PM · MITK (2020)
floca created T27489: Deprecate and correct QmitkSliceWidget?.
Jun 19 2020, 12:33 PM · Request for Discussion
nolden edited projects for T27483: DICOM import of multi-channel data not working, added: MITK (2020); removed MITK.
Jun 19 2020, 11:26 AM · MITK (2020), Restricted Project, DICOM