Page MenuHomePhabricator

Request for DiscussionTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Use this project to tag tasks and other stuff that should be discussed in the weekly MITK meeting.

Recent Activity

Today

gaoh added a parent task for T28127: Reopen segmentation in MITK: T28000: MITK v2021.01.
Wed, Jan 27, 11:11 AM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)

Sat, Jan 23

kislinsk added a comment to T27992: Release of MITK CLIs.

Deleted branch from rMITK MITK: feature/T27992-CmdLineAppsInWorkbenchReleaseConfig.

Sat, Jan 23, 8:54 PM · MITK (v2021.01), Request for Discussion
kislinsk closed T27992: Release of MITK CLIs as Resolved by committing rMITK74b4982fe7a7: Include CoreCmdApps in WorkbenchRelease configuration and add….
Sat, Jan 23, 8:53 PM · MITK (v2021.01), Request for Discussion
kislinsk added a revision to T27992: Release of MITK CLIs: Restricted Differential Revision.
Sat, Jan 23, 8:51 AM · MITK (v2021.01), Request for Discussion
kislinsk added a comment to T27992: Release of MITK CLIs.

Pushed new branch to rMITK MITK: feature/T27992-CmdLineAppsInWorkbenchReleaseConfig.

Sat, Jan 23, 8:47 AM · MITK (v2021.01), Request for Discussion
kislinsk claimed T27992: Release of MITK CLIs.

I asked in the general Slack channel for command-line apps in use. It boils down to the file converters in CoreCmdApps. Other mentions are too specific for the WorkbenchRelease configuration and are related to the Classification module. We should consider adding a phenotyping build configuration, though.

Sat, Jan 23, 8:29 AM · MITK (v2021.01), Request for Discussion

Thu, Jan 21

schererj moved T28127: Reopen segmentation in MITK from Discussion to Backlog on the Kaapana (internal) board.
Thu, Jan 21, 9:47 AM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
nolden renamed T28159: Officially support MITK using system Qt from Oficially support MITK using system Qt to Officially support MITK using system Qt.
Thu, Jan 21, 9:41 AM · CI, Kaapana (internal), Request for Discussion, MITK
s669m moved T28169: TFDA MVP v1 powered by Kaapana from Discussion to In Progress on the Kaapana (internal) board.
Thu, Jan 21, 9:40 AM · Request for Discussion, Kaapana (internal)
s669m updated the task description for T28169: TFDA MVP v1 powered by Kaapana.
Thu, Jan 21, 9:40 AM · Request for Discussion, Kaapana (internal)
s669m moved T28168: TFDA Code Repo Creation from Discussion to Resolved on the Kaapana (internal) board.
Thu, Jan 21, 9:39 AM · Kaapana (internal)
schererj moved T28159: Officially support MITK using system Qt from Discussion to Backlog on the Kaapana (internal) board.
Thu, Jan 21, 9:39 AM · CI, Kaapana (internal), Request for Discussion, MITK
nolden added a comment to T28159: Officially support MITK using system Qt.

@kislinsk anyone from the MITK CI team who could take over?

Thu, Jan 21, 9:38 AM · CI, Kaapana (internal), Request for Discussion, MITK
schererj moved T28159: Officially support MITK using system Qt from Backlog to Discussion on the Kaapana (internal) board.
Thu, Jan 21, 9:27 AM · CI, Kaapana (internal), Request for Discussion, MITK
schererj moved T28127: Reopen segmentation in MITK from Backlog to Discussion on the Kaapana (internal) board.
Thu, Jan 21, 9:27 AM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
s669m updated the task description for T28169: TFDA MVP v1 powered by Kaapana.
Thu, Jan 21, 9:19 AM · Request for Discussion, Kaapana (internal)
s669m renamed T28169: TFDA MVP v1 powered by Kaapana from TFDA MVP v1 to TFDA MVP v1 powered by Kaapana.
Thu, Jan 21, 9:19 AM · Request for Discussion, Kaapana (internal)

Wed, Jan 20

floca added a comment to T28127: Reopen segmentation in MITK.
In T28127#217604, @gaoh wrote:

@floca I might have found a dataset, where even the new number is not enough:
P:\Gao\mitk-testdata\

Wed, Jan 20, 9:46 PM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
gaoh reopened T28127: Reopen segmentation in MITK as "Open".

@floca I might have found a dataset, where even the new number is not enough:
P:\Gao\mitk-testdata\

Wed, Jan 20, 9:44 PM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
floca closed T27689: RTDose image can not be serialized and workbench crashes upon loading as Resolved by committing rMITKadb6d06ec088: Fixed T27689.
Wed, Jan 20, 5:27 PM · Request for Discussion, MITK
gaoh moved T28127: Reopen segmentation in MITK from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Jan 20, 10:32 AM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
neher added a comment to T28039: DICOM Seg loading error.

Sure. Could you point me to the nightly installers again?

Wed, Jan 20, 9:59 AM · MITK (v2021.01), Missing Info, Request for Discussion

Tue, Jan 19

fedorov added a comment to T28127: Reopen segmentation in MITK.

@floca thanks for the report! I added a comment to the dcmqi issue you created.

Tue, Jan 19, 4:27 PM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
kalali triaged T28181: [Segmentation] Should warning messages be passed on to the UI? as Normal priority.
Tue, Jan 19, 3:57 PM · Request for Discussion, Next Milestone, MITK
nolden added a comment to T28039: DICOM Seg loading error.

Changes have landed . @neher could you test again using a nightly build?

Tue, Jan 19, 3:25 PM · MITK (v2021.01), Missing Info, Request for Discussion
s669m renamed T28169: TFDA MVP v1 powered by Kaapana from TFDA MVP v2 to TFDA MVP v1.
Tue, Jan 19, 1:16 PM · Request for Discussion, Kaapana (internal)
s669m renamed T28169: TFDA MVP v1 powered by Kaapana from TFDA (Kaapana) Multi-Provider site version (a.k.a) Central Instance to TFDA MVP v2.
Tue, Jan 19, 1:02 PM · Request for Discussion, Kaapana (internal)
kalali updated the task description for T26399: Workbench crash on simple tree model update.
Tue, Jan 19, 11:27 AM · Request for Discussion, MITK
nolden claimed T28039: DICOM Seg loading error.
Tue, Jan 19, 10:44 AM · MITK (v2021.01), Missing Info, Request for Discussion
nolden added a comment to T28039: DICOM Seg loading error.

Just submitted a Differential

Tue, Jan 19, 10:23 AM · MITK (v2021.01), Missing Info, Request for Discussion
floca added a comment to T28039: DICOM Seg loading error.

I set the GIT_TAG of DCMQI locally to v1.2.3 and I can confirm that the data from above can be loaded.

OK, then increasing the DCMQI version to 1.2.3 before our next release seems to be the most sensible fix, doen't it?

Tue, Jan 19, 9:38 AM · MITK (v2021.01), Missing Info, Request for Discussion

Mon, Jan 18

floca closed T28127: Reopen segmentation in MITK as Resolved by committing rMITK5f64c29977dd: Made NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION less strict.
Mon, Jan 18, 11:14 PM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
floca added a revision to T28127: Reopen segmentation in MITK: Restricted Differential Revision.
Mon, Jan 18, 9:42 PM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
floca added a comment to T28127: Reopen segmentation in MITK.

It depends. NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION is only for checking in predicates;

As long as nobody has missused it so far, it is just used for that. ;) At least I have introduced it with this purpose and only used it there.

Mon, Jan 18, 4:01 PM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
kislinsk added a comment to T28127: Reopen segmentation in MITK.

It depends. NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION is only for checking in predicates; not for constant use throughout MITK while are there calculations after calculations after calculations and so the values may drift away from the actual truth, right? So for a temporary fix, I'm okay. But we should definitely check what is going on in DCMQI and fix on that side preferably.

Mon, Jan 18, 12:32 PM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
floca added a comment to T28127: Reopen segmentation in MITK.

1e-5 should still be conservative enough for the purpose of geometries.

Is your statement also valid for 5e-5? Beause 1e-5 would not be enough in that case.

Mon, Jan 18, 11:31 AM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)
s669m created T28169: TFDA MVP v1 powered by Kaapana.
Mon, Jan 18, 10:50 AM · Request for Discussion, Kaapana (internal)
s669m triaged T28168: TFDA Code Repo Creation as Normal priority.
Mon, Jan 18, 10:46 AM · Kaapana (internal)
kislinsk added a comment to T28127: Reopen segmentation in MITK.

Thanks for looking into this issue as well. :-) I think 1e-5 is okay. We/you already introduced NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION not long ago since we had similar issues and 1e-5 should still be conservative enough the purpose of geometries.

Mon, Jan 18, 5:01 AM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)

Sun, Jan 17

floca claimed T28127: Reopen segmentation in MITK.

The problem seems to be that DCMQI rounds the the orientation matrix values at the 5th decimal place when storing to DCM Seg.

Sun, Jan 17, 8:41 PM · Request for Discussion, MITK (v2021.01), Restricted Project, Kaapana (internal)

Fri, Jan 15

kislinsk added a comment to T28159: Officially support MITK using system Qt.

I understand. :-) Just wanted to give you more options to think about as it is probably only a temporal solution. Sooner or later (currently read "later"), our minimum version requirements won't match again with the OS-provided Qt version. So we cannot run away from it forever I guess. :D

Fri, Jan 15, 12:40 PM · CI, Kaapana (internal), Request for Discussion, MITK
gaoh added a comment to T28159: Officially support MITK using system Qt.

yes exactly, the problem with the scripted version, ist still, that it is necessary to provide credentials. That was fine, as long we were the only ones creating the containers.
The version of @nolden downloading the packages in ubuntu allows others to just build the container, without having to provide credentials at all.

Fri, Jan 15, 12:35 PM · CI, Kaapana (internal), Request for Discussion, MITK
nolden added a comment to T28159: Officially support MITK using system Qt.

Thank. New command-line interface looks nice, but the challenge is where to put the credentials, especially if you want to put the script open source like in the Kaapana dockerfiles.

Fri, Jan 15, 12:14 PM · CI, Kaapana (internal), Request for Discussion, MITK

Thu, Jan 14

kislinsk triaged T28159: Officially support MITK using system Qt as Normal priority.

As it already works (?) and we will stay at least another year with Qt 5 we can do this. But in general, do you know of the new Qt Installer Framework with command-line interface? It's much easier now to install Qt with a single command and there a a few possibilities to provide credentials if that's an issue. See here for examples: https://phabricator.mitk.org/T27960#214043

Thu, Jan 14, 5:22 PM · CI, Kaapana (internal), Request for Discussion, MITK
nolden added a project to T28159: Officially support MITK using system Qt: CI.
Thu, Jan 14, 3:51 PM · CI, Kaapana (internal), Request for Discussion, MITK
nolden updated the task description for T28159: Officially support MITK using system Qt.
Thu, Jan 14, 3:50 PM · CI, Kaapana (internal), Request for Discussion, MITK
nolden created T28159: Officially support MITK using system Qt.
Thu, Jan 14, 3:46 PM · CI, Kaapana (internal), Request for Discussion, MITK

Mon, Jan 11

floca added a comment to T27689: RTDose image can not be serialized and workbench crashes upon loading.

Ok. Found the problem. Should now be fixed with the new diff. At least it works on my PC now with the test files.

Mon, Jan 11, 7:12 PM · Request for Discussion, MITK
kislinsk added a comment to T28039: DICOM Seg loading error.

I set the GIT_TAG of DCMQI locally to v1.2.3 and I can confirm that the data from above can be loaded.

Mon, Jan 11, 5:01 PM · MITK (v2021.01), Missing Info, Request for Discussion
floca edited projects for T28039: DICOM Seg loading error, added: Request for Discussion, Missing Info, MITK (v2021.01); removed MITK.

@fedorov Happy new year and thanks for keeping us up to date!

Mon, Jan 11, 11:29 AM · MITK (v2021.01), Missing Info, Request for Discussion