Page MenuHomePhabricator

Request for DiscussionTag
ActivePublic

Members

  • This project does not have any members.
  • View All

Watchers

  • This project does not have any watchers.
  • View All

Details

Description

Use this project to tag tasks and other stuff that should be discussed in the weekly MITK meeting.

Recent Activity

Wed, May 22

s434n triaged T30451: [Segmentation] Tool icon persists on cursor as Low priority.
Wed, May 22, 11:08 AM · Request for Discussion, Checklist, MITK

Thu, May 16

kompan added a project to T30204: Improve visibility between help files for perfusion: Next Milestone.
Thu, May 16, 10:05 AM · Next Milestone, Request for Discussion, MITK (v2024.06)
kompan added a project to T30439: [Perfusion] Only a selection of debug parameter images generated as sub-nodes: Next Milestone.
Thu, May 16, 10:03 AM · Next Milestone, Request for Discussion, Checklist, MITK (v2024.06)

Wed, May 15

kompan added a comment to T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes.

In the MitkNodePredicateGeometry to precision is set to 1e-6. So this is at least one of the issues why the old masks are not found. It could be an option to relax the precision, but since the rotation matrix might have a large effect even for small inaccuracies, it needs to be thoroughly tested first how big the effect is if. e.g 1e-4 is accepted.
For now, the new segmentation masks are provided as test data instead of the old masks.

Wed, May 15, 11:41 AM · Next Milestone, MITK (v2024.06)
kompan moved T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes from Backlog to MITK Meeting on the Request for Discussion board.
Wed, May 15, 11:18 AM · Next Milestone, MITK (v2024.06)
kompan moved T30439: [Perfusion] Only a selection of debug parameter images generated as sub-nodes from Backlog to Cycle on the MITK (v2024.06) board.
Wed, May 15, 10:53 AM · Next Milestone, Request for Discussion, Checklist, MITK (v2024.06)
kompan moved T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes from Backlog to Cycle on the MITK (v2024.06) board.
Wed, May 15, 10:52 AM · Next Milestone, MITK (v2024.06)
floca moved T30447: [TotalSeg] Levelwindow effect from Backlog to MITK Meeting on the Request for Discussion board.
Wed, May 15, 9:52 AM · MITK
floca added a project to T30447: [TotalSeg] Levelwindow effect: Request for Discussion.
Wed, May 15, 9:52 AM · MITK
kislinsk moved T30446: Decouple Workbench plugin from optional views from Backlog to MITK Meeting on the Request for Discussion board.
Wed, May 15, 9:20 AM · Next Milestone, MITK

Tue, May 14

kompan added a project to T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes: Request for Discussion.
Tue, May 14, 11:36 AM · Next Milestone, MITK (v2024.06)
kislinsk triaged T30446: Decouple Workbench plugin from optional views as Normal priority.
Tue, May 14, 9:57 AM · Next Milestone, MITK
floca placed T30412: [Statistics] Planar figure cannot be set as ROI for askew images up for grabs.
Tue, May 14, 9:34 AM · MITK, Next Milestone

Fri, May 10

floca closed T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX as Resolved by committing rMITK27cad36203c2: Refactored QmitkMultiLabelInspector to use the highlight guard.
Fri, May 10, 2:19 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca edited projects for T30412: [Statistics] Planar figure cannot be set as ROI for askew images, added: Next Milestone, MITK, Request for Discussion; removed Missing Info, Checklist, MITK (v2024.06).

We should clarify how we handle the reinit or reinit warning in the Measurement view. Should be very simelar to the Segmentation view.

Fri, May 10, 10:39 AM · MITK, Next Milestone
kompan triaged T30439: [Perfusion] Only a selection of debug parameter images generated as sub-nodes as Normal priority.
Fri, May 10, 9:55 AM · Next Milestone, Request for Discussion, Checklist, MITK (v2024.06)

Thu, May 9

floca moved T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX from Backlog to Cycle on the MITK (v2024.06) board.
Thu, May 9, 10:53 AM · Request for Discussion, Checklist, MITK (v2024.06)
floca added a revision to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX: Restricted Differential Revision.
Thu, May 9, 10:47 AM · Request for Discussion, Checklist, MITK (v2024.06)
floca claimed T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.
Thu, May 9, 10:45 AM · Request for Discussion, Checklist, MITK (v2024.06)

Wed, May 8

kompan moved T18489: Help perspective cannot be closed from Backlog to Cycle on the MITK (v2024.06) board.
Wed, May 8, 9:57 AM · Request for Discussion, MITK (v2024.06)
kompan reopened T18489: Help perspective cannot be closed as "Open".
Wed, May 8, 9:41 AM · Request for Discussion, MITK (v2024.06)

Tue, May 7

kislinsk added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

This is a good idea.

Tue, May 7, 4:31 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

hm. I see.
May be:
B + if you press shift while hovering, then always highlight?

Tue, May 7, 4:08 PM · Request for Discussion, Checklist, MITK (v2024.06)
kislinsk added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

That you cannot tell. You don't know how testers would react to option A. May be it is equaly irritating to them. And may be they would missing the highlighting of invisible labels if the realy would work with it... 🤔

Tue, May 7, 3:57 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

but the disadvantages proved to outweigh.

That you cannot tell. You don't know how testers would react to option A. May be it is equaly irritating to them. And may be they would missing the highlighting of invisible labels if the realy would work with it... 🤔
If we want to base it on user feedback in such an unclear situation, one would need to offer/explain all options and let them choose/poll.

Tue, May 7, 3:51 PM · Request for Discussion, Checklist, MITK (v2024.06)
kislinsk added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

Yes, I agree. Well, not completely I guess, since I vote for B. The current state confused all testers (and me at first when I double-checked what's going on, and after I understood I still would consider it a bug in this state). I see the good intentions why you changed it from initial B to something else, but the disadvantages proved to outweigh.

Tue, May 7, 2:53 PM · Request for Discussion, Checklist, MITK (v2024.06)
kompan added a project to T30435: Rename "Time" to "Timestep" in Image Navigator?: Request for Discussion.
Tue, May 7, 10:40 AM · MITK, Next Milestone, Checklist

Mon, May 6

floca added a project to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX: Request for Discussion.

The first version had option B.
I changed it because I thought that UX is better if you have still the posibility to peek/see also the highlight of invisible labels. E.g. in order to pick the right one to make visible again.

Mon, May 6, 10:26 AM · Request for Discussion, Checklist, MITK (v2024.06)
floca triaged T30422: [SEG] Erase tool double click is irritating as Normal priority.
Mon, May 6, 9:31 AM · Checklist, MITK (v2024.06)

Apr 19 2024

floca closed T28675: Boolean Operations in Segmentation utilities are slow as Resolved.

The tools are not useing InitializeByLabeledImage anymore. If speed is still a problem, please reopen.

Apr 19 2024, 9:12 AM · MITK (v2024.06), Request for Discussion
floca added a comment to T29197: [Segmentation] Is the classificationsegmentation-plugin used / required?.

I would tend to remove it.

Apr 19 2024, 9:02 AM · MITK (v2024.06)
floca moved T29197: [Segmentation] Is the classificationsegmentation-plugin used / required? from Backlog to MITK Meeting on the Request for Discussion board.
Apr 19 2024, 9:02 AM · MITK (v2024.06)

Apr 2 2024

floca raised the priority of T29526: [Segmentation] Workbench crashes when closing render window part with active tool from Normal to Unbreak Now!.

Discussion: How important is that?

Apr 2 2024, 7:12 PM · MITK (v2024.06)

Mar 28 2024

kislinsk added a comment to T30386: VectorProperties are not getting modified by SetValue.

Yes, this is a bug. All ITK-based objects should call Modified() in their setter methods, if the values actually changed.

Mar 28 2024, 11:56 AM · Request for Discussion, MITK
floca triaged T30386: VectorProperties are not getting modified by SetValue as Low priority.
Mar 28 2024, 11:43 AM · Request for Discussion, MITK

Mar 20 2024

a178n assigned T30306: [Segmentation] Convertion from semantic segmentations to instance segmentations to floca.
Mar 20 2024, 11:53 AM · MITK
s434n added a parent task for T30241: [MxN] Rethink select-all logic in MxN data selection: T30360: [MxN] Add group synchronization.
Mar 20 2024, 11:36 AM · MITK (v2024.06)
kislinsk moved T30376: Reduce noise in terminal during startup from Backlog to MITK Meeting on the Request for Discussion board.
Mar 20 2024, 10:35 AM · MITK (v2024.06)
kislinsk added a project to T30376: Reduce noise in terminal during startup: Request for Discussion.
Mar 20 2024, 10:35 AM · MITK (v2024.06)
kislinsk moved T30377: Clean up/rewrite View Navigator from Backlog to MITK Meeting on the Request for Discussion board.
Mar 20 2024, 10:34 AM · MITK (v2024.06)
kislinsk added a project to T30377: Clean up/rewrite View Navigator: Request for Discussion.
Mar 20 2024, 10:34 AM · MITK (v2024.06)

Mar 19 2024

floca triaged T30375: [Statistics] Remove HotspotMaskGenerator or rework and fix tests as High priority.
Mar 19 2024, 8:50 AM · Next Milestone, MITK

Mar 14 2024

floca moved T29557: [Segmentation] "Delete group" button is inactive if there are multiple groups but no labels from Backlog to MITK Meeting on the Request for Discussion board.
Mar 14 2024, 12:18 PM · Next Milestone, MITK
floca added a project to T29557: [Segmentation] "Delete group" button is inactive if there are multiple groups but no labels: Request for Discussion.
Mar 14 2024, 12:18 PM · Next Milestone, MITK

Mar 11 2024

floca moved T29584: [Interpolation] Confirming 3D interpolation does not set mode to "disabled" from Backlog to MITK Meeting on the Request for Discussion board.
Mar 11 2024, 11:02 AM · MITK (v2024.06), Checklist
floca added a project to T29584: [Interpolation] Confirming 3D interpolation does not set mode to "disabled": Request for Discussion.

I would change the checklist. With the multilabel support it makes sense to keep it open, if you have confirmed an interpolation, because you might directly go to the next label and confirm there as well...

Mar 11 2024, 11:02 AM · MITK (v2024.06), Checklist

Mar 6 2024

a178n moved T30354: [MedSAM] Update SAM python daemon script for MedSAM from Backlog to Segmentation on the MITK (v2024.06) board.
Mar 6 2024, 9:52 AM · MITK (v2024.06)
kislinsk added a comment to T30337: Allow custom product name and further customizations.

More context:

  • There's already MITK_CUSTOM_REVISION_DESC, which allows to change the tag/commit hash that is displayed in the Workbench as version like "v2023.12" and I think also in the package names generated by CPack.
  • Exclusion/visibility of views, toolbars, and perspectives will be part of our customization efforts for the upcoming release and is scheduled to be implemented in March.
  • Toolbar visibility is already implemented (just recently) as preferences.
Mar 6 2024, 9:39 AM · MITK
a178n added a subtask for T30314: MedSAM in MITK: T30356: [MedSAM] Create Test user checklist.
Mar 6 2024, 9:28 AM · MITK (v2024.06)
a178n triaged T30354: [MedSAM] Update SAM python daemon script for MedSAM as Normal priority.
Mar 6 2024, 9:11 AM · MITK (v2024.06)