Page MenuHomePhabricator
Feed Advanced Search

Sep 23 2022

s434n closed T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool , a subtask of T29132: [MultiLabel Segmentation] Define desired behavior of fill / erase tool, as Resolved.
Sep 23 2022, 3:01 PM · MITK (v2022.10)
s434n closed T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool as Resolved.

I have updated the checklist according to the documented / actual function of the two tools.
However, I had to add a note regarding the "remove everything" functionality of the erase tool, which currently does not work correctly (?) when a segmented region touches the boundary of the image (see T29078 example 2).

Sep 23 2022, 3:01 PM · MITK (v2022.10)
s434n claimed T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool .
Sep 23 2022, 12:23 PM · MITK (v2022.10)

Sep 19 2022

s434n committed rMITK26df569787e2: Fix typos (authored by s434n).
Fix typos
Sep 19 2022, 11:05 AM
s434n committed rMITKb4c69945ef44: fix typos and remove misspelled unused code (authored by s434n).
fix typos and remove misspelled unused code
Sep 19 2022, 11:05 AM

Sep 16 2022

s434n closed T29287: Rework segmentation checklist for new modes of the picking tool as Resolved.
Sep 16 2022, 1:55 PM · MITK (v2022.10)
s434n claimed T29287: Rework segmentation checklist for new modes of the picking tool.
Sep 16 2022, 12:41 PM · MITK (v2022.10)

Sep 13 2022

s434n added a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized.
Sep 13 2022, 1:06 PM · MITK (v2023.04)
s434n added a parent task for T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Sep 13 2022, 1:06 PM · MITK (v2023.04)
s434n triaged T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized as Normal priority.
Sep 13 2022, 1:06 PM · MITK (v2023.04)
s434n added a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29298: [mxn multi widget] Add context menu to render window specific data inspector.
Sep 13 2022, 1:03 PM · MITK (v2023.04)
s434n added a parent task for T29298: [mxn multi widget] Add context menu to render window specific data inspector: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Sep 13 2022, 1:03 PM · Moved to git.dkfz.de, MITK
s434n triaged T29298: [mxn multi widget] Add context menu to render window specific data inspector as Normal priority.
Sep 13 2022, 1:02 PM · Moved to git.dkfz.de, MITK
s434n added a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Sep 13 2022, 12:46 PM · Moved to git.dkfz.de, MITK
s434n added a parent task for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Sep 13 2022, 12:46 PM · MITK (v2023.04)
s434n triaged T29297: [mxn multi widget] Optimize data accessibility inside render windows as Normal priority.
Sep 13 2022, 12:46 PM · MITK (v2023.04)

Aug 25 2022

s434n added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

Pushed new branch to rMITK MITK: feature/T28578-MxN-development.

Aug 25 2022, 7:18 PM · Moved to git.dkfz.de, MITK

Jul 7 2022

s434n closed T29213: [Levelwindow] Preset definition does not allow floating point numbers as Resolved.
Jul 7 2022, 11:49 AM · MITK (v2022.10)
s434n committed rMITK4d8943c91982: standardize setting of level window values (authored by s434n).
standardize setting of level window values
Jul 7 2022, 11:48 AM
s434n committed rMITKe6954ab13033: Standardize setting of level window values (authored by s434n).
Standardize setting of level window values
Jul 7 2022, 11:48 AM

Jun 29 2022

s434n claimed T29213: [Levelwindow] Preset definition does not allow floating point numbers.
Jun 29 2022, 1:58 PM · MITK (v2022.10)

Jun 24 2022

s434n reassigned T28464: [Segmentation] New Add/Remove tool from s434n to floca.
Jun 24 2022, 5:57 PM · MITK (v2022.10)

Jun 23 2022

s434n added a comment to T28464: [Segmentation] New Add/Remove tool.

@s434n Have claimed it for finding the error* (good job by the way). Then you can unclaim it now.
Or will you work on that issue further?

Jun 23 2022, 12:00 PM · MITK (v2022.10)

Jun 8 2022

s434n closed T28297: Add Stitching MiniApp to installer as Resolved.
Jun 8 2022, 9:48 AM · MITK (v2022.10), Restricted Project, Cleared

Jun 3 2022

s434n committed rMITK1ba516a4379a: Add Stitching MiniApp to installer (authored by s434n).
Add Stitching MiniApp to installer
Jun 3 2022, 3:33 PM
s434n committed rMITK9a85a34c7b92: add stitching miniapp to workbench release config (authored by s434n).
add stitching miniapp to workbench release config
Jun 3 2022, 3:33 PM
s434n added a revision to T28297: Add Stitching MiniApp to installer: Unknown Object (Differential Revision).
Jun 3 2022, 12:46 PM · MITK (v2022.10), Restricted Project, Cleared
s434n claimed T28297: Add Stitching MiniApp to installer.
Jun 3 2022, 12:12 PM · MITK (v2022.10), Restricted Project, Cleared

May 30 2022

s434n closed T29093: [Image Cropper] Warning of rotated geometry not removed after reinit as Resolved.
May 30 2022, 11:02 AM · MITK (v2022.10), Checklist
s434n committed rMITKa064dfe2cc72: Make rotated geometry warning in Image Cropper more consistent (authored by s434n).
Make rotated geometry warning in Image Cropper more consistent
May 30 2022, 10:45 AM
s434n committed rMITKf6981649b07a: Make image selection node predicate filter for images (authored by s434n).
Make image selection node predicate filter for images
May 30 2022, 10:45 AM
s434n committed rMITK369093860612: fix typo (authored by s434n).
fix typo
May 30 2022, 10:45 AM
s434n committed rMITK489a2cf76cb9: Improve rotated image warning (authored by s434n).
Improve rotated image warning
May 30 2022, 10:44 AM
s434n committed rMITK1f7fb3f693ca: only update rotated geometry warning when selected image changes (authored by s434n).
only update rotated geometry warning when selected image changes
May 30 2022, 10:44 AM

May 27 2022

s434n closed T28481: [Checklist] [Test data] Define publicly available user test data as Resolved.
May 27 2022, 1:55 PM · MITK, Next Milestone
s434n added a comment to T29093: [Image Cropper] Warning of rotated geometry not removed after reinit.

After looking into the code, it seems to me that the warning is just formulated wrongly. A simple reinit will not make the bounding box for a rotated image pixel-aligned. Implementing this would take some time and require a lot of reworking the bounding shape interaction. As this is not currently requested, we will keep things as they are and only update the warning text so it won't be misleading.

May 27 2022, 1:13 PM · MITK (v2022.10), Checklist

May 18 2022

s434n claimed T28464: [Segmentation] New Add/Remove tool.
May 18 2022, 11:37 AM · MITK (v2022.10)

May 17 2022

s434n claimed T29093: [Image Cropper] Warning of rotated geometry not removed after reinit.
May 17 2022, 11:23 AM · MITK (v2022.10), Checklist
s434n added a comment to T28808: [Properties] Some Pointset 2D shape selection not shown in the image views.

I expect a circle in the cross-hairs, akin to Shape: cross or vertex. But there is None. Is this expected behaviour?

May 17 2022, 11:10 AM · MITK (v2022.10)
s434n added a comment to T29141: [Segmentation] Color change not immediately applied.

Is this the same (T29110, see description point 3) and specifically T29110#235991?
If so, I have a fix for the > layer 0 problem which can be tested and reviewed in D632.

May 17 2022, 10:49 AM · MITK (v2022.10), Checklist

May 4 2022

s434n committed rRTTB050f114a5fe9: Upgrade RTTB to ITK 5 (authored by s434n).
Upgrade RTTB to ITK 5
May 4 2022, 10:37 AM

Apr 27 2022

s434n added a comment to T29143: [MultiLabel Segmentation] Creating a segmentation "as new segmentation" fails.

I was able to reproduce the problem on the snapshot from two days ago. This new version fixes the problem for me, although the behavior is the same as @kalali described it. The newly created segmentation is a complete copy of the current one (including layers, labels, and masked regions of the labels), except for the changed region that was just segmented. I'm not sure if this is the expected behavior, but if it is everything seems to work fine.

Apr 27 2022, 11:58 AM · MITK (v2022.04)

Apr 26 2022

s434n triaged T29142: [Segmentation] Previews stay invisible if label was hidden as Low priority.
Apr 26 2022, 3:34 PM · MITK (v2022.10), Checklist
s434n triaged T29141: [Segmentation] Color change not immediately applied as Low priority.
Apr 26 2022, 3:02 PM · MITK (v2022.10), Checklist

Apr 25 2022

s434n committed rMITK213a5ab297df: avoid repetition of node name if it is already in the bounding box name (authored by s434n).
avoid repetition of node name if it is already in the bounding box name
Apr 25 2022, 3:25 PM
s434n committed rMITK9ed35d686374: Fix repetition in masked/cropped node name (authored by s434n).
Fix repetition in masked/cropped node name
Apr 25 2022, 3:24 PM

Apr 14 2022

s434n added a comment to T28808: [Properties] Some Pointset 2D shape selection not shown in the image views.

Correction to my previous comment: all options are rendered. The only thing is, that the "Vertex" option is hardly visible because it is so small in the 2D views. Since the vertex does not change size with the scale property, I would assume this is by design.

Apr 14 2022, 1:59 PM · MITK (v2022.10)
s434n added a comment to T28808: [Properties] Some Pointset 2D shape selection not shown in the image views.

Trying with Windows 10 as well as Ubuntu 20.04, I can only reproduce the option "Vertex" making problems. Everything else seems to work, but this option is not shown in any of the 2D views, only in the 3D view. I used openMeAlone.mps and PointSetForPic3D.mps.

Apr 14 2022, 12:46 PM · MITK (v2022.10)
s434n merged Restricted Maniphest Task into T28781: Selected series and studies cannot be deleted from DICOM browser without deleting the whole patient.
Apr 14 2022, 12:05 PM · Moved to git.dkfz.de, MITK, Checklist

Apr 13 2022

s434n committed rMPe63dfdbb7ae3: update required itk version in readme (authored by s434n).
update required itk version in readme
Apr 13 2022, 9:29 AM

Apr 11 2022

s434n closed T28824: [Segmentation] UL Threshold range changes when draged towards borders of scale. as Wontfix.

I looked a bit into this. As far as I can tell, there is no such functionality available in the ctkRangeWidget we are using, or the QT classes it is based on. Achieving the proposed behavior would require a large rework. Since the demand for this is very low, it won't be done in the foreseeable future.

Apr 11 2022, 6:56 PM · Checklist, MITK

Apr 7 2022

s434n closed T29092: [Image Cropper] Image name repeated in created nodes as Resolved.
Apr 7 2022, 2:33 PM · MITK (v2022.04), Checklist

Apr 6 2022

s434n added a comment to T29079: [Segmentation] Test tools on different anatomical planes.

I was able to reproduce this on Windows 10, but the behavior seems to be very inconsistent. When testing with Pic3D.nrrd and brain.nrrd, I took the following steps:

  • load the image
  • create a new segmentation
  • draw with the Add- / Region growing - tool in one of the views
  • draw again with the same tool in a different view

The behavior then differs depending on which views were used. Generally, when first drawing in the axial view and then in either of the other two, the second addition is not drawn interactively but only shown when letting go of the mouse button. This sometimes also occurs when going coronal -> sagittal or sagittal -> coronal, but never when doing the axial view second.
This only happens when using the same tool in both views without deactivating. If I switch the tool or deactivate and re-activate it, the second drawing works perfectly fine.

Apr 6 2022, 4:18 PM · Checklist, MITK (v2022.04)
s434n added a comment to T29098: [3D Segmentation] UL Threshold Tool - 0 intensity value not include in slider range?.

I am not able to reproduce this problem on Windows 10 using brain.nrrd as test image

Apr 6 2022, 1:10 PM · MITK (v2024.12), Restricted Project, Checklist

Apr 5 2022

s434n merged T29030: [DICOM Browser] Deleting series always deletes whole patient into T28781: Selected series and studies cannot be deleted from DICOM browser without deleting the whole patient.
Apr 5 2022, 1:21 PM · Moved to git.dkfz.de, MITK, Checklist
s434n merged task T29030: [DICOM Browser] Deleting series always deletes whole patient into T28781: Selected series and studies cannot be deleted from DICOM browser without deleting the whole patient.
Apr 5 2022, 1:21 PM · MITK (v2022.04)
s434n committed rRTTBd51afa020875: remove outdated itk 5 warning from readme (authored by s434n).
remove outdated itk 5 warning from readme
Apr 5 2022, 12:20 PM
s434n committed rRTTBf6131edcd781: make ITK5 default version in cmake (authored by s434n).
make ITK5 default version in cmake
Apr 5 2022, 11:34 AM

Apr 4 2022

s434n added a comment to T29101: [3D Segmentation] Region Growing Tool - Generated Segmentation darkens the ambient image.

From what I can see, the level window is reset to its original state after pressing "Confirm Segmentation". The darkening / changed level window is only temporary to help adjusting the parameters of the region growing. To me this seems like a feature, not a bug. At least it is by design, anyway.

Apr 4 2022, 5:30 PM · MITK, Checklist

Apr 1 2022

s434n added a revision to T29092: [Image Cropper] Image name repeated in created nodes: Unknown Object (Differential Revision).
Apr 1 2022, 2:05 PM · MITK (v2022.04), Checklist
s434n claimed T29092: [Image Cropper] Image name repeated in created nodes.
Apr 1 2022, 1:48 PM · MITK (v2022.04), Checklist

Mar 31 2022

s434n merged task T27431: Error loading DCE-MRI DICOM image into T27432: Error loading DCE-MRI DICOM image.
Mar 31 2022, 1:16 PM
s434n merged T27431: Error loading DCE-MRI DICOM image into T27432: Error loading DCE-MRI DICOM image.
Mar 31 2022, 1:16 PM · MITK, DICOM, Cleared
s434n triaged T29106: [Segmentation Options] "show only selected nodes" is not immediately applied as Low priority.
Mar 31 2022, 12:55 PM · MITK (v2022.10), Checklist

Mar 30 2022

s434n triaged T29095: [Image Cropper] Moving of the bounding box can not be undone as Wishlist priority.
Mar 30 2022, 3:37 PM · Moved to git.dkfz.de, MITK, Checklist
s434n triaged T29094: Deleting a data node causes global reset as Normal priority.
Mar 30 2022, 3:37 PM · Moved to git.dkfz.de, MITK, Checklist
s434n triaged T29093: [Image Cropper] Warning of rotated geometry not removed after reinit as Low priority.
Mar 30 2022, 3:36 PM · MITK (v2022.10), Checklist
s434n triaged T29092: [Image Cropper] Image name repeated in created nodes as Low priority.
Mar 30 2022, 3:35 PM · MITK (v2022.04), Checklist

Mar 18 2022

s434n committed rRTTBa47b461edba0: fix build error of debug mode by using bigobj flag (authored by s434n).
fix build error of debug mode by using bigobj flag
Mar 18 2022, 2:56 PM
s434n committed rRTTBd60e221dc50b: replace deprecated names (authored by s434n).
replace deprecated names
Mar 18 2022, 2:56 PM

Mar 15 2022

s434n triaged T29030: [DICOM Browser] Deleting series always deletes whole patient as Low priority.
Mar 15 2022, 12:47 PM · MITK (v2022.04)

Mar 14 2022

s434n edited projects for T29024: [Core] Crash-inducing racing condition in TimeGeometry, added: MITK (v2022.04); removed MITK.
Mar 14 2022, 6:10 PM · Moved to git.dkfz.de, MITK
s434n triaged T29026: [File Loading] File reading options for surface files are not remembered as Low priority.
Mar 14 2022, 6:08 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n triaged T29024: [Core] Crash-inducing racing condition in TimeGeometry as Normal priority.
Mar 14 2022, 1:02 PM · Moved to git.dkfz.de, MITK

Mar 7 2022

s434n merged task T27747: New data selection concept for ModelFit Generic Data Fitting into T27814: Refactor ModelFit Generic Data Fitting view to use new selection concept.
Mar 7 2022, 11:07 AM · MITK (v2022.04)
s434n merged T27747: New data selection concept for ModelFit Generic Data Fitting into T27814: Refactor ModelFit Generic Data Fitting view to use new selection concept.
Mar 7 2022, 11:07 AM · MITK (v2024.06), Cleared

Mar 3 2022

s434n added a comment to T28827: [Segmentation][Interpolation] Color of 3D interpolated segmentations is red, not green.

I tested with MITK v2021.10 and the current state of develop and have the same behavior as @kalali: unconfirmed 3D interpolated surfaces (and contours) are drawn in green. To me this also looks like what is expected from the checklist.
I also get the <segmentation-name>_3D-interpolation node.

Mar 3 2022, 5:57 PM · Request for Discussion, Missing Info, MITK (v2022.04), Checklist
s434n added a comment to T28826: [Segmentation][Interpolation] Color of 2D interpolated slice is not yellow but segmentation color.

I tested with MITK v2021.10 and the current state of develop and also can't reproduce the described problem. In both cases unconfirmed interpolation slices are drawn in yellow.

Mar 3 2022, 5:40 PM · MITK (v2022.04), Checklist
s434n added a comment to T28829: [Segmentation][Interpolation] Interpolation area is still enabled, when segmentation node is hidden..

Amir and I took a look at this in the context of his current work on T28142 (see D601). Because of the unification with the MultiLabel Segmentation plugin, another check is needed for the interpolation area, as interpolation is currently not supported for segmentations with more than one label. So there is the general check, making sure the selected nodes exist and their geometries match up, as well as the check for the correct number of labels (exactly one).
Every time the second check is updated (e.g. when a new label is created) we have to either be certain the first one is currently true, or check the first one again. To avoid adding a new member variable and manipulating/checking it in various places, we decided to just redo all checks together in one place, as this doesn't take too long and is only triggered by user input.
This is captured in D604, which is based on D601 though

Mar 3 2022, 12:45 PM · MITK (v2022.04), Checklist

Mar 2 2022

s434n claimed T28829: [Segmentation][Interpolation] Interpolation area is still enabled, when segmentation node is hidden..
Mar 2 2022, 9:44 AM · MITK (v2022.04), Checklist

Feb 28 2022

s434n committed rMITKf82960bfb7d7: Add/extend exponential decay fit models (authored by s434n).
Add/extend exponential decay fit models
Feb 28 2022, 10:23 AM
s434n committed rMITK5414620759a9: make ModelType of ExpDecayOffsetModel Generic (authored by s434n).
make ModelType of ExpDecayOffsetModel Generic
Feb 28 2022, 10:23 AM
s434n committed rMITK3becee76cbb8: fix definition of new method in T2DecayModel (authored by s434n).
fix definition of new method in T2DecayModel
Feb 28 2022, 10:23 AM
s434n committed rMITK4c913ec110a9: Fix and extend T2DecayModel (authored by s434n).
Fix and extend T2DecayModel
Feb 28 2022, 10:23 AM
s434n committed rMITKca48a3fb6662: Add ExpDecayOffsetModel to ModelFit module (authored by s434n).
Add ExpDecayOffsetModel to ModelFit module
Feb 28 2022, 10:23 AM

Feb 23 2022

s434n removed a project from T28481: [Checklist] [Test data] Define publicly available user test data: Request for Discussion.
Feb 23 2022, 11:58 AM · MITK, Next Milestone

Feb 17 2022

s434n added a project to T28481: [Checklist] [Test data] Define publicly available user test data: Request for Discussion.
Feb 17 2022, 12:30 PM · MITK, Next Milestone

Jan 20 2022

s434n triaged T28937: [ModelFit] Rethink mitkT2DecayModel as Low priority.
Jan 20 2022, 11:54 AM · MITK (v2024.06)

Jan 12 2022

s434n closed T27263: Measurements and pointsets display no valuable information as Resolved.
Jan 12 2022, 1:04 PM · MITK (v2022.04)
s434n committed rMITK9c07a3264cac: Update Measurement info on the fly (authored by s434n).
Update Measurement info on the fly
Jan 12 2022, 1:03 PM
s434n committed rMITK89a485f9dab2: introduce PointMovedPlanarFigureEvent for text updating (authored by s434n).
introduce PointMovedPlanarFigureEvent for text updating
Jan 12 2022, 1:03 PM

Jan 7 2022

s434n added a comment to T28920: Add additional namespace introduced by boost 1.78.

This has also been adressed in D568 since the problem turned up there in the CI builds. Should we still solve it in D582 separately or just wait until D568 can be landed?

Jan 7 2022, 3:03 PM · Restricted Project

Dec 23 2021

s434n added a comment to T27270: Planar figures are inconsistently bound by reference image.

I think related to this task: it seems there is some more inconsistency depending on the shown region. When two images with different geometries are loaded and shown simultaneously after a global reset, planarfigures created on one of the images can extend into the whole shown region, outside the boundaries of the selected reference image (even after a reset on that specific image).
It seems in this case the boundaries for the planarfigure are set incorrectly on creation.

Dec 23 2021, 4:51 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n added a comment to T28217: [MatchPoint] Registrations generated with manipulator have no proper PropertyReleations.

I can't reproduce the problem mentioned for the mapper plugin on v2021.10 . The moving / target information appears in the properties, just as in a registration created via the Algorithm Control plugin.
Can somebody reproduce this (or a related) problem? Otherwise I guess the task was already solved somewhere else and can be closed

Dec 23 2021, 4:39 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n added a revision to T27263: Measurements and pointsets display no valuable information: Unknown Object (Differential Revision).
Dec 23 2021, 11:12 AM · MITK (v2022.04)

Dec 22 2021

s434n claimed T27263: Measurements and pointsets display no valuable information.
Dec 22 2021, 12:13 PM · MITK (v2022.04)

Dec 20 2021

s434n closed T28735: Relative paths in arguments for MitkFileConverter interpreted as root paths as Resolved.
Dec 20 2021, 12:25 PM · MITK (v2022.04)
s434n committed rMITK3dff89c3a9a9: Avoid relative paths being used as root paths (authored by s434n).
Avoid relative paths being used as root paths
Dec 20 2021, 12:16 PM
s434n committed rMITK91ed2c752a7a: undo useless Update call from D564 (authored by s434n).
undo useless Update call from D564
Dec 20 2021, 12:16 PM
s434n committed rMITK46fb237a912f: avoid leading slash in filepath when relative path was given (authored by s434n).
avoid leading slash in filepath when relative path was given
Dec 20 2021, 12:16 PM