Page MenuHomePhabricator
Feed Advanced Search

Nov 22 2023

s434n added a comment to T29454: Clarify the versions/editions we publish as installer.

MITK Workbench XL
MITK Workbench - extra

Nov 22 2023, 12:07 PM · MITK (v2024.06), Request for Discussion

Nov 21 2023

s434n added a comment to T30275: [Segmentation] 3D Interpolation Show-Position-Nodes not updating sometimes.

I don't see a good way to handle this differently. Discerning if a slice has become obsolete would be very hard, especially since it's in 3D and the slice could be intersected by a segmented slice of a different orientation. The position node remaining does not seem like a problem to me, so I would vote to close as Invalid or Wontfix.

Nov 21 2023, 12:52 PM · Checklist, MITK
s434n merged task T28800: [Segmentation] Threshold tool updates after each digit if typed in manually into Restricted Maniphest Task.
Nov 21 2023, 9:48 AM · MITK (v2023.12), Checklist, Request for Discussion

Nov 20 2023

s434n added a revision to T30258: [Statistics] Lines across different geometries can cause crash when analyzed with image: Unknown Object (Differential Revision).
Nov 20 2023, 5:19 PM · Checklist, MITK (v2023.12)
s434n claimed T30258: [Statistics] Lines across different geometries can cause crash when analyzed with image.
Nov 20 2023, 4:00 PM · Checklist, MITK (v2023.12)

Nov 17 2023

s434n triaged T30258: [Statistics] Lines across different geometries can cause crash when analyzed with image as High priority.
Nov 17 2023, 4:32 PM · Checklist, MITK (v2023.12)
s434n triaged T30257: Changing opacity messes up rendering order as Normal priority.
Nov 17 2023, 2:33 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist

Nov 16 2023

s434n published a new version of 2023 Week 46 (Mid November).
Nov 16 2023, 5:42 PM

Nov 15 2023

s434n added a comment to T30252: [Segmentation] Deleting an empty group causes Workbench crash.

Can reproduce. I agree with your explanation. When group 1 is empty, it can't actually be selected. There's the dotted line, but group 2 is still in focus (which is stated in the popup dialog). I guess after group 2 is deleted the "focus" is not set correctly.
I guess we could either ensure that the next available label is automatically selected, since usually there is always a label selected, or the "Delete group" should be respective to the dotted-line selection of a group.
I'm not sure if this contradicts previous discussions we had about the topic, but I would actually prefer the second option. Generally, it feels weird that one is able to kind of select a group and interact with its context menu, but the buttons above still refer to the group of the focused label. For example, it is impossible to add a label to an empty group with the buttons (except for the first one).

Nov 15 2023, 4:58 PM · MITK

Nov 14 2023

s434n triaged T30250: [MxN] Windows created by preset have no in-window menus as Normal priority.
Nov 14 2023, 12:20 PM · Moved to git.dkfz.de, MITK (v2024.12)

Nov 13 2023

s434n committed rMITKc61b76f04a10: write only image data from itk result directly to output image instead of… (authored by s434n).
write only image data from itk result directly to output image instead of…
Nov 13 2023, 9:39 PM
s434n closed T29608: [Segmentation Utils] Workbench crashes for Morphological operations as Resolved by committing rMITK9a17e7beb611: Correctly handle results of morphological operations.
Nov 13 2023, 9:39 PM · MITK (v2023.12)
s434n committed rMITK9a17e7beb611: Correctly handle results of morphological operations (authored by s434n).
Correctly handle results of morphological operations
Nov 13 2023, 9:39 PM

Nov 8 2023

s434n added a revision to T29608: [Segmentation Utils] Workbench crashes for Morphological operations: Unknown Object (Differential Revision).
Nov 8 2023, 4:41 PM · MITK (v2023.12)
s434n committed rMITK287a0803af1f: Keep track of synchronized MxN windows to avoid nodes being hidden (authored by s434n).
Keep track of synchronized MxN windows to avoid nodes being hidden
Nov 8 2023, 4:07 PM
s434n closed T30184: [MxN] Turning on data synchronizing hides newly added nodes as Resolved by committing rMITK287a0803af1f: Keep track of synchronized MxN windows to avoid nodes being hidden.
Nov 8 2023, 4:07 PM · MITK (v2023.12)
s434n committed rMITK43f51f83fa9e: keep track of synchronized windows to set correct initial selection (authored by s434n).
keep track of synchronized windows to set correct initial selection
Nov 8 2023, 4:07 PM
s434n claimed T29608: [Segmentation Utils] Workbench crashes for Morphological operations.
Nov 8 2023, 4:04 PM · MITK (v2023.12)
s434n triaged T30241: [MxN] Rethink select-all logic in MxN data selection as Normal priority.
Nov 8 2023, 11:30 AM · Moved to git.dkfz.de, MITK (v2024.12)

Nov 7 2023

s434n moved T29608: [Segmentation Utils] Workbench crashes for Morphological operations from Backlog to Cycle on the MITK (v2023.12) board.
Nov 7 2023, 5:40 PM · MITK (v2023.12)
s434n edited projects for T29608: [Segmentation Utils] Workbench crashes for Morphological operations, added: MITK (v2023.12); removed MITK.
Nov 7 2023, 5:39 PM · MITK (v2023.12)

Nov 2 2023

s434n added a revision to T30184: [MxN] Turning on data synchronizing hides newly added nodes: Unknown Object (Differential Revision).
Nov 2 2023, 7:06 PM · MITK (v2023.12)
s434n renamed T30184: [MxN] Turning on data synchronizing hides newly added nodes from [MxN] Turning on data synchronizing hides segmentation of non-visible nodes to [MxN] Turning on data synchronizing hides newly added nodes.
Nov 2 2023, 5:43 PM · MITK (v2023.12)
s434n triaged T30234: [MxN] Adding new render window turns on visibility of selected nodes as Low priority.
Nov 2 2023, 5:29 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n committed rMITKf21266a4176c: Reactivate / fix exponentiation in formula parser (authored by s434n).
Reactivate / fix exponentiation in formula parser
Nov 2 2023, 10:39 AM
s434n committed rMITKc5bc8ba32dfb: adjust whitespace (authored by s434n).
adjust whitespace
Nov 2 2023, 10:39 AM
s434n committed rMITK68832adcdf1d: reactivate / fix exponentiation in formula parser (authored by s434n).
reactivate / fix exponentiation in formula parser
Nov 2 2023, 10:39 AM

Oct 31 2023

s434n closed T28990: MITK crashes when displaying GenericParamModel maps in the ModelFit Inspector View as Resolved.
Oct 31 2023, 9:59 AM · MITK
s434n added a revision to T28990: MITK crashes when displaying GenericParamModel maps in the ModelFit Inspector View: Unknown Object (Differential Revision).
Oct 31 2023, 9:59 AM · MITK

Oct 30 2023

s434n committed rMITKa21ce061c2ff: set function string when creating generic param model parameterizer (authored by s434n).
set function string when creating generic param model parameterizer
Oct 30 2023, 8:40 AM
s434n committed rMITKef92759cdfe9: set function string when creating generic param model parameterizer (authored by s434n).
set function string when creating generic param model parameterizer
Oct 30 2023, 8:40 AM

Oct 26 2023

s434n committed rMITK0789330902a2: Fix MxN UI for MacOS (authored by s434n).
Fix MxN UI for MacOS
Oct 26 2023, 5:36 PM
s434n closed T30192: [MxN] UI elements not visible on Mac as Resolved by committing rMITK0789330902a2: Fix MxN UI for MacOS.
Oct 26 2023, 5:36 PM · MITK (v2023.12)
s434n committed rMITK5c084ac619e7: fix UI position and size for MacOS (authored by s434n).
fix UI position and size for MacOS
Oct 26 2023, 5:35 PM

Oct 20 2023

s434n added a revision to T30192: [MxN] UI elements not visible on Mac: Unknown Object (Differential Revision).
Oct 20 2023, 1:14 PM · MITK (v2023.12)

Oct 19 2023

s434n closed T30226: [MxN] Removing a node crashes workbench as Resolved.
Oct 19 2023, 1:16 PM · MITK (v2023.12)

Oct 18 2023

s434n committed rMITKbd73eba1caa9: Add safeguard to avoid MxN crashes when removing node (authored by s434n).
Add safeguard to avoid MxN crashes when removing node
Oct 18 2023, 3:45 PM
s434n committed rMITKc5478047dbac: add safeguard to setGeometry of RenderWindowUtilityWidget (authored by s434n).
add safeguard to setGeometry of RenderWindowUtilityWidget
Oct 18 2023, 3:45 PM

Oct 12 2023

s434n updated the task description for T30226: [MxN] Removing a node crashes workbench.
Oct 12 2023, 5:05 PM · MITK (v2023.12)
s434n triaged T30226: [MxN] Removing a node crashes workbench as High priority.
Oct 12 2023, 5:02 PM · MITK (v2023.12)
s434n moved T29302: Movie maker plugin does not work correctly with the new mxn multi widget from Cycle to Backlog on the MITK (v2023.12) board.
Oct 12 2023, 10:22 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n moved T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus from Cycle to Backlog on the MITK (v2023.12) board.
Oct 12 2023, 10:22 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n placed T29302: Movie maker plugin does not work correctly with the new mxn multi widget up for grabs.
Oct 12 2023, 10:21 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n placed T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus up for grabs.

I looked shortly into this, but couldn't find an easy way to solve it. The problem is that for the desired behavior, one needs to capture not only events of the utility widget itself, but also of all its child widgets.

Oct 12 2023, 10:21 AM · Moved to git.dkfz.de, MITK (v2024.12)

Oct 11 2023

s434n moved T30222: [Registration] Enable use of parameters for command line MiniApp from Backlog to Cycle on the MITK (v2023.12) board.
Oct 11 2023, 12:02 PM · MITK (v2023.12)
s434n triaged T30222: [Registration] Enable use of parameters for command line MiniApp as Normal priority.
Oct 11 2023, 11:05 AM · MITK (v2023.12)
s434n moved T30184: [MxN] Turning on data synchronizing hides newly added nodes from Backlog to Cycle on the MITK (v2023.12) board.
Oct 11 2023, 10:52 AM · MITK (v2023.12)
s434n moved T30192: [MxN] UI elements not visible on Mac from Backlog to Cycle on the MITK (v2023.12) board.
Oct 11 2023, 10:50 AM · MITK (v2023.12)
s434n claimed T30192: [MxN] UI elements not visible on Mac.
Oct 11 2023, 10:50 AM · MITK (v2023.12)

Sep 7 2023

s434n moved T29302: Movie maker plugin does not work correctly with the new mxn multi widget from Cycle to Backlog on the MITK (v2023.12) board.
Sep 7 2023, 10:33 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n removed a project from T29369: [Segmentation Utilities] Handle / select different labels independently: Request for Discussion.
Sep 7 2023, 10:31 AM · MITK (v2024.06)
s434n added a comment to T29369: [Segmentation Utilities] Handle / select different labels independently.
  • Boolean Operations
    • chosen: high effort
    • Can be used so that the other functions can do everything
    • Work only on one image, select two labels
  • Contour to Image & Surface to Image
    • chosen: low effort seems more senseful. The functionality can be achieved via other tools (e.g. boolean)
  • Image Masking
    • chosen: low effort
  • Morphological Operations
    • as proposed
    • Pick an image & pick a label
    • Include options like in picking tool, i.e. generate a new layer when doing an operation, lock labels (to make sure other labels are not overwritten e.g. for a dilution)
  • Add a new tool: Transfer Label could be used to transfer a label from one image to another (if the same image is selected twice, it's just a rename)
Sep 7 2023, 10:30 AM · MITK (v2024.06)
s434n removed a project from T30192: [MxN] UI elements not visible on Mac: Request for Discussion.
Sep 7 2023, 9:57 AM · MITK (v2023.12)
s434n moved T30192: [MxN] UI elements not visible on Mac from Backlog to MITK Meeting on the Request for Discussion board.
Sep 7 2023, 9:14 AM · MITK (v2023.12)
s434n added a project to T30192: [MxN] UI elements not visible on Mac: Request for Discussion.
Sep 7 2023, 9:14 AM · MITK (v2023.12)

Aug 31 2023

s434n triaged T30192: [MxN] UI elements not visible on Mac as High priority.
Aug 31 2023, 2:31 PM · MITK (v2023.12)

Aug 29 2023

s434n added a comment to T28491: [Segmentation] Slice interpolation 'confirm for all slices' sometimes crahes.

I tested this again with the current version of MITK (develop branch) and can see no problems. Interpolation works without problems on my laptop (Windows 10, 32GB RAM)

Aug 29 2023, 4:07 PM · MITK (v2023.12)

Aug 24 2023

s434n committed rMITK013da8c575c1: remove unused/outdated QmitkFFmpegWriter import (authored by s434n).
remove unused/outdated QmitkFFmpegWriter import
Aug 24 2023, 4:30 PM
s434n committed rMITK77eaee663ab1: Decouple TimeNavigation from SliceNavigationController (authored by s434n).
Decouple TimeNavigation from SliceNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITKf9cb09180c85: Use concrete variable type and const (authored by kalali).
Use concrete variable type and const
Aug 24 2023, 4:30 PM
s434n committed rMITKc8c7a75725c3: Update the time nc before the slice nc (authored by kalali).
Update the time nc before the slice nc
Aug 24 2023, 4:30 PM
s434n committed rMITK40b57ea76624: adapt new SNC occurences introduced since merging and fix remaining bugs (authored by s434n).
adapt new SNC occurences introduced since merging and fix remaining bugs
Aug 24 2023, 4:30 PM
s434n committed rMITK0dab5fe5f1ac: Refactor class to work with the new TimeNavigationController (authored by kalali).
Refactor class to work with the new TimeNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITK80bda9107823: Refactor class to work with the new TimeNavigationController (authored by kalali).
Refactor class to work with the new TimeNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITKf314ae99a2f5: Remove TimeNavigationController parameter / member (authored by kalali).
Remove TimeNavigationController parameter / member
Aug 24 2023, 4:30 PM
s434n committed rMITKfcd58f5173b5: Remove unnecessary controller / controller-connections (authored by kalali).
Remove unnecessary controller / controller-connections
Aug 24 2023, 4:30 PM
s434n committed rMITK5c3b7c799bf3: Refactor class to work with the new TimeNavigationController (authored by kalali).
Refactor class to work with the new TimeNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITKd58b817f6178: Replace SliceNavigationController with TimeNavigationController (authored by kalali).
Replace SliceNavigationController with TimeNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITKfe90eadd9150: Refactor class to work with the new TimeNavigationController (authored by kalali).
Refactor class to work with the new TimeNavigationController
Aug 24 2023, 4:30 PM
s434n committed rMITKcc1dda7884d6: Replace the SliceNavigationController inside the RenderingManager (authored by kalali).
Replace the SliceNavigationController inside the RenderingManager
Aug 24 2023, 4:30 PM
s434n committed rMITK0fd0318820f2: Modify BaseController to only hold a single stepper (authored by kalali).
Modify BaseController to only hold a single stepper
Aug 24 2023, 4:30 PM
s434n committed rMITK79829b658496: Modify the SliceNavigationController to remove time-related data (authored by kalali).
Modify the SliceNavigationController to remove time-related data
Aug 24 2023, 4:30 PM
s434n committed rMITKed8c3c8ee4a8: Remove unnecessary / unused functions / variable (authored by kalali).
Remove unnecessary / unused functions / variable
Aug 24 2023, 4:30 PM
s434n committed rMITK742c0a0f3e7e: Add TimeNavigationController (authored by kalali).
Add TimeNavigationController
Aug 24 2023, 4:29 PM

Aug 9 2023

s434n triaged T30184: [MxN] Turning on data synchronizing hides newly added nodes as Normal priority.
Aug 9 2023, 5:10 PM · MITK (v2023.12)
s434n removed a project from T30181: Add option for a "mean" line profile in statistics view: Request for Discussion.
Aug 9 2023, 12:14 PM · Moved to git.dkfz.de, Restricted Project, MITK
s434n merged task T29630: Command-line app for voxelizing contour sets / RTSTRUCTs in MITK into T30177: Add command-line app for converting contours like RTSTRUCT to masks.
Aug 9 2023, 11:52 AM · Request for Discussion, MITK
s434n merged T29630: Command-line app for voxelizing contour sets / RTSTRUCTs in MITK into T30177: Add command-line app for converting contours like RTSTRUCT to masks.
Aug 9 2023, 11:52 AM · MITK
s434n removed a project from T29454: Clarify the versions/editions we publish as installer: Request for Discussion.

We want to have:

  • a slick minimum Workbench version
  • a fuller / bigger version. Exact contents and name still need to be compiled (e.g. Perfusion, Fitting, ...)
Aug 9 2023, 11:46 AM · MITK (v2024.06), Request for Discussion

Aug 1 2023

s434n closed T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds as Resolved.
Aug 1 2023, 12:31 PM · MITK (v2023.12), Checklist
s434n committed rMITK2b0ed86731c2: Fix livewire crashing out of bounds (authored by s434n).
Fix livewire crashing out of bounds
Aug 1 2023, 12:31 PM
s434n committed rMITKfab339f94c12: make livewire drawing conditional on being in the correct plane (authored by s434n).
make livewire drawing conditional on being in the correct plane
Aug 1 2023, 12:31 PM

Jul 26 2023

s434n committed rRTTB882fec8538c7: Fix the fix of namespaces for ITK v5.3.0 (authored by s434n).
Fix the fix of namespaces for ITK v5.3.0
Jul 26 2023, 4:34 PM
s434n closed T28548: Allow Zooming during creation of Segmentation. as Resolved.

With the addition of the polygon tool, this is now possible.

Jul 26 2023, 12:05 PM · MITK (v2023.12), Request for Discussion
s434n triaged T30166: [Logging] Introduce filtering by level as Low priority.
Jul 26 2023, 12:03 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n moved T29369: [Segmentation Utilities] Handle / select different labels independently from Backlog to MITK Meeting on the Request for Discussion board.
Jul 26 2023, 10:32 AM · MITK (v2024.06)

Jul 25 2023

s434n claimed T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus.
Jul 25 2023, 9:14 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n closed T30162: [Interpolation] [Documentation] Update interpolation documentation regarding multilabel support as Resolved.
Jul 25 2023, 9:14 AM · MITK (v2023.12)
s434n committed rMITKe7a6ceb95e8d: Update interpolation documentation & fix some typos (authored by s434n).
Update interpolation documentation & fix some typos
Jul 25 2023, 9:14 AM
s434n committed rMITK059a81c9379b: remove outdated warning about multiple labels from interpolation docu & some… (authored by s434n).
remove outdated warning about multiple labels from interpolation docu & some…
Jul 25 2023, 9:14 AM

Jul 17 2023

s434n claimed T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds.
Jul 17 2023, 11:51 AM · MITK (v2023.12), Checklist

Jul 14 2023

s434n added a project to T29369: [Segmentation Utilities] Handle / select different labels independently: Request for Discussion.

I think the handling of multiple labels depends on each action and needs to be handled separately.

  • Boolean Operations: I see a few options here
    • low effort: only allow for segmentations with one label. If there is more than one label, show a message that this is not possible
    • higher effort: completely rework the selection. Let the user select two specific labels (from the same or different segmentations) and work on these, either replacing the first label or adding a new label (or instance) to that segmentation
  • Contour to Image & Surface to Image:
    • low effort: leave it as is, still works at the moment
    • higher effort: introduce the option to add the newly created segmentation as a new label / instance to an existing segmentation
  • Image Masking:
    • low effort: leave it as is, still works at the moment (using all labels of a segmentation)
    • higher effort: introduce the option to select which labels/instances should be considered for masking
  • Morphological Operations: Currently don't crash, but always use label 1
    • I think the most senseful solution would be to let the user select a specific label for the operation to work on. Multiple at the same time probably only get in each other's way and make it unnecessarily complicated.
Jul 14 2023, 4:44 PM · MITK (v2024.06)
s434n closed T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Invalid.
Jul 14 2023, 3:43 PM · MITK (v2022.10), Breaking Change
s434n closed T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty as Invalid.
Jul 14 2023, 3:43 PM · MITK (v2023.12), Request for Discussion
s434n added a revision to T30162: [Interpolation] [Documentation] Update interpolation documentation regarding multilabel support: Unknown Object (Differential Revision).
Jul 14 2023, 3:25 PM · MITK (v2023.12)
s434n triaged T30162: [Interpolation] [Documentation] Update interpolation documentation regarding multilabel support as Low priority.
Jul 14 2023, 2:40 PM · MITK (v2023.12)

Jul 12 2023

s434n committed rRTTB8907f1c6d32f: Fix namespaces for ITK v5.3.0 (authored by s434n).
Fix namespaces for ITK v5.3.0
Jul 12 2023, 3:03 PM

Jul 6 2023

s434n committed rRTTB9f4f5fd77d0e: Add gamma index to RTTB (authored by s434n).
Add gamma index to RTTB
Jul 6 2023, 11:27 AM

Jul 4 2023

s434n moved T27284: [Image Statistic] Histogram is only supported with one image and <=1 ROI from Backlog to Cycle on the MITK (v2023.12) board.
Jul 4 2023, 5:37 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n moved T29302: Movie maker plugin does not work correctly with the new mxn multi widget from Backlog to Cycle on the MITK (v2023.12) board.
Jul 4 2023, 5:27 PM · Moved to git.dkfz.de, MITK (v2024.12)