Page MenuHomePhabricator
Feed Advanced Search

Apr 14 2023

s434n edited projects for T29347: Measurement Checklist - Possible inconsistent recentering behavior when clicking on geometry node in Data Manager., added: Request for Discussion; removed MITK (v2023.04), Cleared.

After looking at the checklist again, I don't think there is a need to change anything. The checklist specifically only speaks of selecting the line-node once. When following the checklist instructions, everything should work as described.

Apr 14 2023, 11:23 AM · Request for Discussion, Checklist

Apr 13 2023

s434n added a comment to T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.
Apr 13 2023, 5:18 PM · MITK (v2023.04)
s434n updated the task description for T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.
Apr 13 2023, 5:15 PM · MITK (v2023.04)
s434n triaged T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label as High priority.
Apr 13 2023, 5:15 PM · MITK (v2023.04)

Apr 4 2023

s434n claimed T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.
Apr 4 2023, 3:33 PM · Request for Discussion, MITK (v2023.04)
s434n claimed T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers.
Apr 4 2023, 3:29 PM · Moved to git.dkfz.de, MITK (v2024.12)

Apr 3 2023

s434n committed rMITKfc6a61b982a3: Fix some bugs in MxN crosshairscorrectly enable/disable crosshairs and fix… (authored by s434n).
Fix some bugs in MxN crosshairscorrectly enable/disable crosshairs and fix…
Apr 3 2023, 10:30 AM
s434n committed rMITK382c8cfb7894: correctly enable/disable crosshairs and fix crosshair rendering on inverted… (authored by s434n).
correctly enable/disable crosshairs and fix crosshair rendering on inverted…
Apr 3 2023, 10:30 AM

Mar 31 2023

s434n closed T29297: [mxn multi widget] Optimize data accessibility inside render windows as Resolved.
Mar 31 2023, 11:47 AM · MITK (v2023.04)
s434n removed a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29298: [mxn multi widget] Add context menu to render window specific data inspector.
Mar 31 2023, 11:45 AM · MITK (v2023.04)
s434n removed a parent task for T29298: [mxn multi widget] Add context menu to render window specific data inspector: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Mar 31 2023, 11:45 AM · Moved to git.dkfz.de, MITK
s434n removed a parent task for T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Mar 31 2023, 11:45 AM · MITK (v2023.04)
s434n removed a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized.
Mar 31 2023, 11:45 AM · MITK (v2023.04)
s434n renamed T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized from [mxn multi widget] Allow drag 'n drop in render window specific data inspector to [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized.
Mar 31 2023, 11:44 AM · MITK (v2023.04)

Mar 30 2023

s434n added a comment to T26555: [mxn multi widget] Provide different default layouts.

This task is basically done with D778, which introduced a mechanism to save/load custom layouts, as well as select from provided presets. The only thing we could further add would be more presets, as there is only one at the moment (two rows with each view direction each).

Mar 30 2023, 11:07 AM · MITK
s434n committed rMITKff61541ae92d: Introduce saving and loading of custom and preset window layouts (authored by s434n).
Introduce saving and loading of custom and preset window layouts
Mar 30 2023, 11:05 AM
s434n committed rMITK51364988ffb6: Merge branch 'develop' into feature/T26555-mxn-default-layouts (authored by s434n).
Merge branch 'develop' into feature/T26555-mxn-default-layouts
Mar 30 2023, 11:05 AM
s434n committed rMITK08f94571dd80: correctly set view plane selection in utility widgets (authored by s434n).
correctly set view plane selection in utility widgets
Mar 30 2023, 11:05 AM
s434n committed rMITKcad68daa40c7: make required connection type clearer for save signal (authored by s434n).
make required connection type clearer for save signal
Mar 30 2023, 11:05 AM
s434n committed rMITKce36b832b6ad: replace filename in SaveLayout function with an ostream (authored by s434n).
replace filename in SaveLayout function with an ostream
Mar 30 2023, 11:05 AM
s434n committed rMITKdd4691c235ac: Add default name to custom window layouts (authored by s434n).
Add default name to custom window layouts
Mar 30 2023, 11:05 AM
s434n committed rMITK0b9302b9c098: improve error handling and slight restructuring for simplification (authored by s434n).
improve error handling and slight restructuring for simplification
Mar 30 2023, 11:05 AM
s434n committed rMITKf21434068e4e: make window layout presets more distinct by name prefix (authored by s434n).
make window layout presets more distinct by name prefix
Mar 30 2023, 11:05 AM
s434n committed rMITKa9657c01042c: unify CustomLayoutLoad and PresetLayoutLoad in general LoadLayout (authored by s434n).
unify CustomLayoutLoad and PresetLayoutLoad in general LoadLayout
Mar 30 2023, 11:05 AM
s434n committed rMITKa39d22d1d7d1: fix dependency and unusable QT ui parameter (authored by s434n).
fix dependency and unusable QT ui parameter
Mar 30 2023, 11:05 AM
s434n committed rMITK57bdb4e383f8: make integer counter unsigned to get rid of comparison warnings (authored by s434n).
make integer counter unsigned to get rid of comparison warnings
Mar 30 2023, 11:05 AM
s434n committed rMITK118762582cc7: introduce saving and loading of custom and preset window layouts (authored by s434n).
introduce saving and loading of custom and preset window layouts
Mar 30 2023, 11:05 AM

Mar 29 2023

s434n added a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus.
Mar 29 2023, 4:38 PM · Moved to git.dkfz.de, MITK
s434n added a parent task for T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Mar 29 2023, 4:38 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n triaged T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus as Low priority.
Mar 29 2023, 4:38 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n added a comment to T29492: [mxn multi widget] Update and extend checklist.

This was briefly touched upon in the group meeting today. An idea that came up was to include a section in some checklists to gather feedback on existing and suggestions for new features / UX in general.

Mar 29 2023, 11:26 AM · MITK (v2023.04)
s434n claimed T29492: [mxn multi widget] Update and extend checklist.
Mar 29 2023, 11:24 AM · MITK (v2023.04)

Feb 22 2023

s434n claimed T26555: [mxn multi widget] Provide different default layouts.
Feb 22 2023, 5:11 PM · MITK
s434n removed a project from T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View: Request for Discussion.
Feb 22 2023, 5:07 PM · MITK (v2023.04), Restricted Project

Feb 13 2023

s434n moved T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View from Backlog to MITK Meeting on the Request for Discussion board.
Feb 13 2023, 1:26 PM · MITK (v2023.04), Restricted Project
s434n added a project to T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View: Request for Discussion.
Feb 13 2023, 1:26 PM · MITK (v2023.04), Restricted Project

Feb 7 2023

s434n closed T29446: Create a citation file for MITK as Resolved.
Feb 7 2023, 1:44 PM · MITK (v2023.04)
s434n committed rMITK843460b12e3c: add further review suggestions (authored by s434n).
add further review suggestions
Feb 7 2023, 1:43 PM
s434n committed rMITKfe4dd45bdb9d: Add citation file (authored by s434n).
Add citation file
Feb 7 2023, 1:43 PM
s434n committed rMITKa1c59b23625a: add review suggestions (authored by s434n).
add review suggestions
Feb 7 2023, 1:43 PM
s434n committed rMITK5e0a85e5a994: add initial version of citation file (authored by s434n).
add initial version of citation file
Feb 7 2023, 1:43 PM

Feb 2 2023

s434n added a comment to T29347: Measurement Checklist - Possible inconsistent recentering behavior when clicking on geometry node in Data Manager..

I don't think it is necessarily a bug, but rather unintuitive how it works. The recentering is not triggered by the clicking of a node, but via changes in the selection. One can also do things like select multiple lines (on different slices), then deselect one, and the view recenters to one of the still selected nodes.
For me, it would feel more intuitive if the view just recenters every time a node is clicked, regardless of the selection. But there is no bug apparent to me here.

Feb 2 2023, 11:47 AM · Request for Discussion, Checklist

Jan 31 2023

s434n moved T29446: Create a citation file for MITK from Backlog to Cycle on the MITK (v2023.04) board.
Jan 31 2023, 10:29 AM · MITK (v2023.04)

Jan 27 2023

s434n added a revision to T29446: Create a citation file for MITK: Unknown Object (Differential Revision).
Jan 27 2023, 5:25 PM · MITK (v2023.04)

Jan 25 2023

s434n triaged T29446: Create a citation file for MITK as Normal priority.
Jan 25 2023, 11:52 AM · MITK (v2023.04)

Nov 29 2022

s434n moved T29392: [SEG] Add dedicated writer to store multi-label images in nifti from Backlog to In candidates on the MITK (v2023.04) board.
Nov 29 2022, 1:44 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n edited projects for T29392: [SEG] Add dedicated writer to store multi-label images in nifti, added: MITK (v2023.04); removed MITK.
Nov 29 2022, 1:44 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n moved T29415: [mxn multi widget] Allow mxn windows to show 3D view from Backlog to In candidates on the MITK (v2023.04) board.
Nov 29 2022, 1:41 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n edited projects for T29415: [mxn multi widget] Allow mxn windows to show 3D view, added: MITK (v2023.04); removed MITK.
Nov 29 2022, 1:41 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n moved T28800: [Segmentation] Threshold tool updates after each digit if typed in manually from In candidates to Segmentation on the MITK (v2023.04) board.
Nov 29 2022, 1:38 PM · MITK (v2023.12), Checklist, Request for Discussion
s434n moved T28800: [Segmentation] Threshold tool updates after each digit if typed in manually from Backlog to In candidates on the MITK (v2023.04) board.
Nov 29 2022, 1:38 PM · MITK (v2023.12), Checklist, Request for Discussion
s434n moved T16132: Allow segmentation with several images from Backlog to In candidates on the MITK (v2023.04) board.
Nov 29 2022, 1:34 PM · MITK (v2023.04), Request for Discussion, Bugzilla
s434n committed rMITK92cc8b65aa6a: Implement center of mass calculation when label is clicked (authored by s434n).
Implement center of mass calculation when label is clicked
Nov 29 2022, 1:22 PM
s434n committed rMITK75e3e8a413aa: switch calculation to itk LabelGeometryImageFilter (authored by s434n).
switch calculation to itk LabelGeometryImageFilter
Nov 29 2022, 1:22 PM
s434n closed T29354: Double-clicking a label jumps to the label but not its centroid as Resolved by committing rMITK92cc8b65aa6a: Implement center of mass calculation when label is clicked.
Nov 29 2022, 1:22 PM · MITK (v2023.04)
s434n committed rMITK7df0109a22ec: implement center of mass calculation (authored by s434n).
implement center of mass calculation
Nov 29 2022, 1:22 PM
s434n closed T29312: Add support for using layers other than layer 0 of the current LabelSetImage, a subtask of T29309: [GrowCut] Further remarks regarding GrowCut, as Resolved.
Nov 29 2022, 1:19 PM · MITK
s434n closed T29312: Add support for using layers other than layer 0 of the current LabelSetImage as Resolved.

I'm not sure where exactly this was introduced (maybe in D739), but seems to already be working now.

Nov 29 2022, 1:19 PM · MITK (v2023.04)

Nov 25 2022

s434n moved T29284: Refactor segmentation plugin user manual documentation from Backlog to Segmentation on the MITK (v2023.04) board.
Nov 25 2022, 12:04 PM · MITK (v2024.12)
s434n merged task T16153: [Segmentation] Jump to center of mass of segmentation on click into T29354: Double-clicking a label jumps to the label but not its centroid.
Nov 25 2022, 11:57 AM · MITK (v2023.04), Bugzilla
s434n merged T16153: [Segmentation] Jump to center of mass of segmentation on click into T29354: Double-clicking a label jumps to the label but not its centroid.
Nov 25 2022, 11:57 AM · MITK (v2023.04)

Nov 22 2022

s434n triaged T29415: [mxn multi widget] Allow mxn windows to show 3D view as Normal priority.
Nov 22 2022, 12:39 PM · Moved to git.dkfz.de, MITK (v2024.12)

Nov 16 2022

s434n removed a parent task for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Nov 16 2022, 1:21 PM · MITK (v2023.04)
s434n removed a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Nov 16 2022, 1:21 PM · Moved to git.dkfz.de, MITK
s434n added a parent task for T29392: [SEG] Add dedicated writer to store multi-label images in nifti: T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash.
Nov 16 2022, 11:43 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n added a subtask for T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash: T29392: [SEG] Add dedicated writer to store multi-label images in nifti.
Nov 16 2022, 11:43 AM · MITK
s434n triaged T29392: [SEG] Add dedicated writer to store multi-label images in nifti as Normal priority.
Nov 16 2022, 11:43 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n updated subscribers of T29391: [Segmentation] Prevent multi-label images to be saved as unsupported image formats.
Nov 16 2022, 11:38 AM · MITK
s434n added a parent task for T29391: [Segmentation] Prevent multi-label images to be saved as unsupported image formats: T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash.
Nov 16 2022, 11:38 AM · MITK
s434n added a subtask for T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash: T29391: [Segmentation] Prevent multi-label images to be saved as unsupported image formats.
Nov 16 2022, 11:38 AM · MITK
s434n triaged T29391: [Segmentation] Prevent multi-label images to be saved as unsupported image formats as Unbreak Now! priority.
Nov 16 2022, 11:37 AM · MITK

Nov 8 2022

s434n removed a project from T29098: [3D Segmentation] UL Threshold Tool - 0 intensity value not include in slider range?: Missing Info.

I just had another look at this. I was able to reproduce the bug this time. It seems that this problem only arises if the image holds floating point values, not when all values are integers.

Nov 8 2022, 6:05 PM · MITK (v2024.12), Restricted Project, Checklist

Nov 7 2022

s434n added a revision to T29354: Double-clicking a label jumps to the label but not its centroid: Unknown Object (Differential Revision).
Nov 7 2022, 3:44 PM · MITK (v2023.04)

Nov 3 2022

s434n claimed T29354: Double-clicking a label jumps to the label but not its centroid.
Nov 3 2022, 4:41 PM · MITK (v2023.04)
s434n closed T29286: Rework segmentation checklist for new live wire and lasso tool as Resolved.
Nov 3 2022, 12:13 PM · MITK (v2022.10)

Nov 2 2022

s434n added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

Deleted branch from rMITK MITK: feature/T28578-MxN-development.

Nov 2 2022, 10:56 AM · Moved to git.dkfz.de, MITK
s434n closed T29344: Image Rendering - No difference between "Jet" and "Jet Transparent" as Resolved.
Nov 2 2022, 10:32 AM · Cleared, Checklist, MITK (v2022.10)

Oct 25 2022

s434n added a comment to T29336: Changing theme in Preferences has no effect..

I also can't reproduce this on Windows 10, changing the theme works as expected. So probably really a Mac OS specific issue.

Oct 25 2022, 2:44 PM · MITK, Checklist
s434n closed T29343: Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading as Resolved.
Oct 25 2022, 2:35 PM · Cleared, Checklist, MITK (v2022.10)

Oct 24 2022

s434n renamed T29343: Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading from Image Rendering - Loaded image is zoomed into in one view and normal in the other views to Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading.
Oct 24 2022, 12:53 PM · Cleared, Checklist, MITK (v2022.10)
s434n claimed T29343: Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading.
Oct 24 2022, 9:21 AM · Cleared, Checklist, MITK (v2022.10)

Oct 21 2022

s434n committed rMITKbed03667f06b: Avoid crashes at extreme level window ranges (authored by s434n).
Avoid crashes at extreme level window ranges
Oct 21 2022, 11:40 AM
s434n committed rMITK29d874a94745: mention hardcoded level window bounds in documentation (authored by s434n).
mention hardcoded level window bounds in documentation
Oct 21 2022, 11:40 AM
s434n closed T29341: Moving the LevelWindow slider too many times at extreme ranges makes MITK crash. as Resolved by committing rMITKbed03667f06b: Avoid crashes at extreme level window ranges.
Oct 21 2022, 11:40 AM · Cleared, Checklist, MITK (v2022.10)
s434n committed rMITK60cbc66d92d1: switch to ScalarType and update casts (authored by s434n).
switch to ScalarType and update casts
Oct 21 2022, 11:40 AM
s434n committed rMITK374a30152be0: avoid crashes at extreme level window ranges (authored by s434n).
avoid crashes at extreme level window ranges
Oct 21 2022, 11:40 AM

Oct 20 2022

s434n added a comment to T29344: Image Rendering - No difference between "Jet" and "Jet Transparent".

From testing, it seems to work correctly in one direction. Everything below the level window is transparent (i.e. black) while everything above the level window is dark red, as the maximum end of the colormap. If this is the desired behavior, it works for me. If we want the upper part to also be transparent, then it is not quite right yet.

Oct 20 2022, 1:04 PM · Cleared, Checklist, MITK (v2022.10)
s434n committed rMITKc13753a00f9f: fix wrong call by timestep instead of timepoint (authored by s434n).
fix wrong call by timestep instead of timepoint
Oct 20 2022, 12:14 PM
s434n closed T29330: Picking Tool shows peculiar behaviour in relabel mode for dynamic Segmentations. as Resolved by committing rMITKc13753a00f9f: fix wrong call by timestep instead of timepoint.
Oct 20 2022, 12:14 PM · Cleared, Checklist, MITK (v2022.10)
s434n committed rMITK90431e83523d: fix wrong call by timestep instead of timepoint (authored by s434n).
fix wrong call by timestep instead of timepoint
Oct 20 2022, 12:14 PM
s434n added a revision to T29330: Picking Tool shows peculiar behaviour in relabel mode for dynamic Segmentations.: Unknown Object (Differential Revision).
Oct 20 2022, 11:13 AM · Cleared, Checklist, MITK (v2022.10)

Oct 19 2022

s434n added a comment to T29343: Image Rendering Checklist - Unclear/Wrong instructions regarding pixel alignment after loading.

I think there may have been a misunderstanding in this task. With the current description, I am not able to reproduce the problem (zoomed in image when loading).
From the mentioned checklist, I understand it that the tester zoomed in himself, as the checklist recommends, to see if the crosshair is aligned with the pixels. The comment only says "Problem with the brain image. The other are working. Attachment 1", so I assume the image is only to illustrate this.
So the only problem is that brain.nrrd is not pixel-aligned automatically when loaded, only after doing a reinit. I think this step in the checklist is worded a bit unclear anyway, so it's probably best to just improve that instruction and I think that's it.

Oct 19 2022, 12:16 PM · Cleared, Checklist, MITK (v2022.10)

Oct 17 2022

s434n added a project to T29340: Colored pixels remain unchanged, even when sliding the Level Window slider to low numbers: Request for Discussion.
Oct 17 2022, 4:43 PM · Next Milestone, Missing Info, Checklist

Oct 14 2022

s434n added a revision to T29341: Moving the LevelWindow slider too many times at extreme ranges makes MITK crash.: Unknown Object (Differential Revision).
Oct 14 2022, 6:02 PM · Cleared, Checklist, MITK (v2022.10)

Oct 13 2022

s434n added a comment to T29340: Colored pixels remain unchanged, even when sliding the Level Window slider to low numbers.

As far as I can tell, this is the expected behavior. Any voxel that has a (greyscale) value above the level-window range is shown completely white. The colors only extend this to multiple channels, but the behavior is still the same. So with very low level-window, the colors are expected to stay visible very strongly

Oct 13 2022, 10:51 AM · Next Milestone, Missing Info, Checklist
s434n claimed T29341: Moving the LevelWindow slider too many times at extreme ranges makes MITK crash..
Oct 13 2022, 10:42 AM · Cleared, Checklist, MITK (v2022.10)
s434n added a comment to T29341: Moving the LevelWindow slider too many times at extreme ranges makes MITK crash..

I recreated the problem by loading any image (the described ones work, as well as just Pic3D.nrrd) and moving the level windows really far (either by dragging the bar to one direction, or moving it back and forth to the upper and lower bounds), to values around the scale of 4e+38. At that point, the workbench just freezes and stops responding.

Oct 13 2022, 10:41 AM · Cleared, Checklist, MITK (v2022.10)
s434n removed a project from T29346: Level Window Checklist - Level Window slider inconsistent upper/lower bound behavior on mouse clicks.: Checklist.

Since this cannot be reproduced right now, we assume this was caused by user error, maybe clicking at the wrong location. For the upcoming release there won't be anything done about this.
In the long-term, we will have to think about if we want to try and improve level window UX, especially in regard to the MxN multi-widget view (T28578) which may need fundamental changes.

Oct 13 2022, 10:25 AM · MITK (v2023.04), Cleared

Oct 5 2022

s434n committed rMITKf6b7afa5f4a1: Remove output from changing livewire points (authored by s434n).
Remove output from changing livewire points
Oct 5 2022, 2:50 PM
s434n committed rMITK9564fecd9f40: remove output from changing livewire points (authored by s434n).
remove output from changing livewire points
Oct 5 2022, 2:50 PM