Page MenuHomePhabricator
Feed Advanced Search

May 9 2023

floca moved T29566: TotalSegmentator GUI bug: Install button not Activated correctly from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 9:29 AM · Checklist, MITK (v2023.04)
floca moved T29567: TotalSeg: inferencing issue on MacOS from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 9:29 AM · MITK (v2023.12)
floca moved T29571: [Segmentation] Changing groups on loaded multi-group segmentations crash from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 9:29 AM · Checklist, MITK (v2023.04)
floca moved T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 9:29 AM · MITK (v2023.12), Checklist
kislinsk claimed T29589: [Segmentation] [Lasso] Add/subtract not in sync with radio buttons in GUI.
May 9 2023, 8:47 AM · Checklist, MITK (v2023.04)
kislinsk closed T29592: [Segmentation] 3D Region Growing still mentioned in user guide as Resolved.
May 9 2023, 8:47 AM · Checklist, MITK (v2023.04)
kislinsk added a comment to T29592: [Segmentation] 3D Region Growing still mentioned in user guide.

Deleted branch from rMITK MITK: bugfix/T29592-Remove3DRegionGrowingFromUserGUide.

May 9 2023, 8:47 AM · Checklist, MITK (v2023.04)
kislinsk added a comment to T29592: [Segmentation] 3D Region Growing still mentioned in user guide.

Pushed new branch to rMITK MITK: bugfix/T29592-Remove3DRegionGrowingFromUserGUide.

May 9 2023, 8:46 AM · Checklist, MITK (v2023.04)
kislinsk claimed T29592: [Segmentation] 3D Region Growing still mentioned in user guide.
May 9 2023, 8:44 AM · Checklist, MITK (v2023.04)
floca added a comment to T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds.

I have the feeling it is an race condition/timing problem.
I was able to recreate the problem also in release after rapidly clicking arround (at least 50 times, machine gun style). In debug I clicked for minutes without anything appening.

May 9 2023, 8:23 AM · MITK (v2023.12), Checklist
kislinsk closed T29593: [View Navigator] Use themed font as Resolved.
May 9 2023, 8:07 AM · Checklist, MITK (v2023.04)
kislinsk added a comment to T29593: [View Navigator] Use themed font.

Deleted branch from rMITK MITK: bugfix/T29593-FixViewNavigatorFont.

May 9 2023, 8:07 AM · Checklist, MITK (v2023.04)
kislinsk added a comment to T29593: [View Navigator] Use themed font.

Pushed new branch to rMITK MITK: bugfix/T29593-FixViewNavigatorFont.

May 9 2023, 8:06 AM · Checklist, MITK (v2023.04)
kislinsk triaged T29593: [View Navigator] Use themed font as Normal priority.
May 9 2023, 7:42 AM · Checklist, MITK (v2023.04)
kislinsk triaged T29592: [Segmentation] 3D Region Growing still mentioned in user guide as Normal priority.
May 9 2023, 7:28 AM · Checklist, MITK (v2023.04)
kislinsk triaged T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds as Unbreak Now! priority.
May 9 2023, 7:24 AM · MITK (v2023.12), Checklist
kislinsk triaged T29590: [Segmentation] [Erase] Erasing everything of the selected label when clicking on background is surprising as Low priority.
May 9 2023, 7:15 AM · MITK (v2024.06), Checklist
kislinsk triaged T29589: [Segmentation] [Lasso] Add/subtract not in sync with radio buttons in GUI as High priority.
May 9 2023, 7:04 AM · Checklist, MITK (v2023.04)
kislinsk created T29588: [MxN] Lock icon is unintuitive.
May 9 2023, 6:48 AM · MITK (v2024.06), Checklist
kislinsk created T29587: [MxN] Resetting render window to specific image always fills visible area with highest image in Data Manager.
May 9 2023, 6:47 AM · Checklist, MITK (v2023.04)
kislinsk created T29585: [MxN] Loading layout needs .json file ending.
May 9 2023, 6:42 AM · Checklist, MITK (v2023.04)

May 8 2023

kislinsk closed T29576: [Segmentation] First label explicitly added to empty group is invisible (collapse and expand parent to make it visible) as Resolved by committing rMITK21d64291924c: First label explicitly added to empty group is invisible (collapse and expand….
May 8 2023, 4:03 PM · MITK (v2023.04)
floca closed T29375: Cursor offset in 2D tools with Qt 5.15 on macOS as Resolved.
May 8 2023, 2:42 PM · MITK (v2023.04)
s434n triaged T29584: [Interpolation] Confirming 3D interpolation does not set mode to "disabled" as Low priority.
May 8 2023, 2:27 PM · MITK (v2024.06), Checklist
s434n triaged T29583: [Interpolation] Interpolation is not triggered correctly as Low priority.
May 8 2023, 1:48 PM · MITK (v2024.06), Checklist
s434n triaged T29582: [Segmentation] Error when pressing "Undo" after undoing all fill changes as Normal priority.
May 8 2023, 1:22 PM · Missing Info, MITK (v2024.06), Checklist
s434n triaged T29581: [Segmentation] Switch tool icon next to cursor when inverting via Ctrl as Wishlist priority.
May 8 2023, 12:47 PM · MITK (v2024.06), Checklist
s434n triaged T29580: [Measurement] Unclear how to end drawing with some tools as Wishlist priority.
May 8 2023, 12:13 PM · MITK (v2024.06), Checklist
s434n triaged T29579: [Documentation] Help page of Pointset Interaction has no table of contents as Low priority.
May 8 2023, 11:43 AM · MITK (v2024.06), Checklist
floca added a comment to T29567: TotalSeg: inferencing issue on MacOS.

Is @wasserth active here? Or we goto GitHub and make an issue over there?

I would also open an issue at GitHub. As you already analyzed the current versions, we could also think of providing a pull request (and have the fork with that changes as back up plan for the release).

May 8 2023, 11:42 AM · MITK (v2023.12)
s434n triaged T29578: [Segmentation] Removing last selected region in picking tool does not update preview as Low priority.
May 8 2023, 11:31 AM · MITK (v2024.06), Checklist
s434n triaged T29577: [Segmentation] Otsu tool does not create and transfer label names correctly in added groups as Normal priority.
May 8 2023, 11:24 AM · Checklist, MITK (v2023.04)
kislinsk added a revision to T29576: [Segmentation] First label explicitly added to empty group is invisible (collapse and expand parent to make it visible): Restricted Differential Revision.
May 8 2023, 10:25 AM · MITK (v2023.04)
kislinsk triaged T29576: [Segmentation] First label explicitly added to empty group is invisible (collapse and expand parent to make it visible) as Normal priority.
May 8 2023, 10:21 AM · MITK (v2023.04)
s434n triaged T29575: [Segmentation] Threshold tool crashes when new label is created during preview as High priority.
May 8 2023, 9:58 AM · Request for Discussion, Checklist, MITK (v2023.04)
s434n closed T29568: [MxN] Add MxN MultiWidget to workbench release configuration as Resolved.
May 8 2023, 9:35 AM · MITK (v2023.04)

May 7 2023

floca added a parent task for T29572: [SEG] Tool interaction does not work on multi montor setup with different dpi: T29375: Cursor offset in 2D tools with Qt 5.15 on macOS.
May 7 2023, 1:18 PM · MITK (v2023.04)
floca added a revision to T29572: [SEG] Tool interaction does not work on multi montor setup with different dpi: Restricted Differential Revision.
May 7 2023, 1:16 PM · MITK (v2023.04)
floca moved T29573: [Segmentation] Segmentation without label (only empty Group 0) cannot be saved from Backlog to Cycle on the MITK (v2023.04) board.
May 7 2023, 10:31 AM · Checklist, MITK (v2023.04)
floca claimed T29573: [Segmentation] Segmentation without label (only empty Group 0) cannot be saved.
May 7 2023, 10:30 AM · Checklist, MITK (v2023.04)

May 6 2023

kislinsk created T29573: [Segmentation] Segmentation without label (only empty Group 0) cannot be saved.
May 6 2023, 10:26 PM · Checklist, MITK (v2023.04)
floca moved T29572: [SEG] Tool interaction does not work on multi montor setup with different dpi from Backlog to Cycle on the MITK (v2023.04) board.
May 6 2023, 12:27 PM · MITK (v2023.04)
floca triaged T29572: [SEG] Tool interaction does not work on multi montor setup with different dpi as Unbreak Now! priority.
May 6 2023, 12:27 PM · MITK (v2023.04)
kislinsk added a revision to T29571: [Segmentation] Changing groups on loaded multi-group segmentations crash: Restricted Differential Revision.
May 6 2023, 9:49 AM · Checklist, MITK (v2023.04)
kislinsk added a comment to T29571: [Segmentation] Changing groups on loaded multi-group segmentations crash.

I can do it, if you want.

May 6 2023, 9:41 AM · Checklist, MITK (v2023.04)
kislinsk added a comment to T29571: [Segmentation] Changing groups on loaded multi-group segmentations crash.

It's not an IO error but again the interpolation.

May 6 2023, 9:39 AM · Checklist, MITK (v2023.04)
floca added a comment to T29571: [Segmentation] Changing groups on loaded multi-group segmentations crash.

I can do it, if you want.

May 6 2023, 9:34 AM · Checklist, MITK (v2023.04)
kislinsk triaged T29571: [Segmentation] Changing groups on loaded multi-group segmentations crash as Unbreak Now! priority.
May 6 2023, 9:25 AM · Checklist, MITK (v2023.04)

May 5 2023

a178n renamed T29541: nnUNet tool Update documentation from Update documentation to nnUNet tool Update documentation.
May 5 2023, 11:36 PM · Checklist, MITK (v2023.04)
a178n added a comment to T29567: TotalSeg: inferencing issue on MacOS.

Is @wasserth active here? Or we goto GitHub and make an issue over there?

May 5 2023, 6:33 PM · MITK (v2023.12)
floca updated subscribers of T29567: TotalSeg: inferencing issue on MacOS.
May 5 2023, 6:31 PM · MITK (v2023.12)
a178n added a comment to T29567: TotalSeg: inferencing issue on MacOS.
May 5 2023, 6:31 PM · MITK (v2023.12)
floca added a comment to T29567: TotalSeg: inferencing issue on MacOS.

I think it would be more efficient /sufficient to advise @wasserth to use explicitly defined versions for total segmentator dependencies. That is something all projects should regard for productive versions to have a better control on their supply chain.

May 5 2023, 6:29 PM · MITK (v2023.12)
a178n added a comment to T29567: TotalSeg: inferencing issue on MacOS.

It seems urllib3 package, a dependency of Totalsegmentator had a version bump yesterday rendering it unusable on MacOS. Its error message clearly shows it as a known issue.
The only solution is to downgrade the version.
This is not an MITK problem, until now we had let TotalSegmentator (implicitly, PyPI) handle the dependency resolution. From this experience, I think we cannot let it happen and take things into our own hands and install the main dependencies ourselves, Currently, we only explicitly handle Pytorch and scipy installation. This should be extended to more packages like urllib3, an HTTP client for Python.
Otherwise, we are always at the risk of TotalSegmentator breaking down in production by no mistake of our own.

May 5 2023, 6:20 PM · MITK (v2023.12)
s434n added a revision to T29568: [MxN] Add MxN MultiWidget to workbench release configuration: Restricted Differential Revision.
May 5 2023, 3:49 PM · MITK (v2023.04)
s434n triaged T29570: [Preferences] Render window decoration color not immediately updated in Image Navigator as Low priority.
May 5 2023, 2:58 PM · MITK (v2024.06), Checklist
a178n raised the priority of T29566: TotalSegmentator GUI bug: Install button not Activated correctly from Normal to Unbreak Now!.
May 5 2023, 1:59 PM · Checklist, MITK (v2023.04)
a178n raised the priority of T29567: TotalSeg: inferencing issue on MacOS from Normal to Unbreak Now!.
May 5 2023, 1:32 PM · MITK (v2023.12)
s434n triaged T29568: [MxN] Add MxN MultiWidget to workbench release configuration as Unbreak Now! priority.
May 5 2023, 11:43 AM · MITK (v2023.04)
a178n renamed T29567: TotalSeg: inferencing issue on MacOS from TotalSeg: Install issue on MacOS to TotalSeg: inferencing issue on MacOS.
May 5 2023, 11:26 AM · MITK (v2023.12)
a178n added a comment to T29567: TotalSeg: inferencing issue on MacOS.

Log shows:
TotalSegmentator -i /tmpmitk-AQVb2K/totalseg-in-QOuAM7/EkysIV_000_0000.nii.gz -o /tmpmitk-AQVb2K/totalseg-out-2CpWaL/EkysIV_000.nii.gz --ml --fast /Users/ashis/Library/Application Support/DKFZ/.totalsegmentator/bin

May 5 2023, 11:16 AM · MITK (v2023.12)
a178n triaged T29567: TotalSeg: inferencing issue on MacOS as Normal priority.
May 5 2023, 11:03 AM · MITK (v2023.12)
a178n triaged T29566: TotalSegmentator GUI bug: Install button not Activated correctly as Normal priority.
May 5 2023, 10:14 AM · Checklist, MITK (v2023.04)

May 4 2023

kislinsk closed T29563: [Segmentation] Update segmentation user guide as Resolved.
May 4 2023, 2:47 PM · MITK (v2023.04)
kislinsk added a comment to T29563: [Segmentation] Update segmentation user guide.

Deleted branch from rMITK MITK: bugfix/T29563-UpdateSegmentationViewUserGuide.

May 4 2023, 2:46 PM · MITK (v2023.04)
kislinsk added a comment to T29563: [Segmentation] Update segmentation user guide.

Pushed new branch to rMITK MITK: bugfix/T29563-UpdateSegmentationViewUserGuide.

May 4 2023, 2:46 PM · MITK (v2023.04)
kislinsk triaged T29563: [Segmentation] Update segmentation user guide as Normal priority.
May 4 2023, 2:44 PM · MITK (v2023.04)
kislinsk closed T29476: [Segmentation] [Interpolation] Unknown exception when creating new segmentation while interpolation is active on current segmentation at layer != 0 as Resolved.

Fixed in T29561: [Segmentation] Creating a new group while 3-d interpolation is active crashes.

May 4 2023, 10:17 AM · MITK (v2023.04)
kislinsk closed T29561: [Segmentation] Creating a new group while 3-d interpolation is active crashes, a subtask of T29476: [Segmentation] [Interpolation] Unknown exception when creating new segmentation while interpolation is active on current segmentation at layer != 0, as Resolved.
May 4 2023, 10:16 AM · MITK (v2023.04)
kislinsk closed T29561: [Segmentation] Creating a new group while 3-d interpolation is active crashes as Resolved.
May 4 2023, 10:16 AM · MITK (v2023.04)
kislinsk added a comment to T29561: [Segmentation] Creating a new group while 3-d interpolation is active crashes.

Deleted branch from rMITK MITK: bugfix/T29561-FixCrashesIn3DInterpolation.

May 4 2023, 10:15 AM · MITK (v2023.04)
kislinsk added a comment to T29561: [Segmentation] Creating a new group while 3-d interpolation is active crashes.

Pushed new branch to rMITK MITK: bugfix/T29561-FixCrashesIn3DInterpolation.

May 4 2023, 10:14 AM · MITK (v2023.04)
kislinsk updated the task description for T29561: [Segmentation] Creating a new group while 3-d interpolation is active crashes.
May 4 2023, 10:00 AM · MITK (v2023.04)
kislinsk triaged T29561: [Segmentation] Creating a new group while 3-d interpolation is active crashes as High priority.
May 4 2023, 9:59 AM · MITK (v2023.04)
a178n closed T29558: TotalSegmentator: Modify as per new Segmentation changes, a subtask of T29437: [SEG] Add TotalSegmentator, as Resolved.
May 4 2023, 8:12 AM · MITK
a178n closed T29558: TotalSegmentator: Modify as per new Segmentation changes as Resolved.
May 4 2023, 8:12 AM · MITK (v2023.04)

May 3 2023

kislinsk closed T29559: Replace Poco::Process with itksys_Process in VideoRecorder as Resolved.
May 3 2023, 11:01 PM · MITK (v2023.04)
kislinsk added a comment to T29559: Replace Poco::Process with itksys_Process in VideoRecorder.

Deleted branch from rMITK MITK: bugfix/T29559-itksysProcessVideoRecoder.

May 3 2023, 11:00 PM · MITK (v2023.04)
kislinsk added a comment to T29559: Replace Poco::Process with itksys_Process in VideoRecorder.

Pushed new branch to rMITK MITK: bugfix/T29559-itksysProcessVideoRecoder.

May 3 2023, 10:59 PM · MITK (v2023.04)
a178n triaged T29560: TotalSegmentator Label naming scheme as High priority.
May 3 2023, 6:29 PM · MITK (v2023.12)
a178n added a revision to T29558: TotalSegmentator: Modify as per new Segmentation changes: Restricted Differential Revision.
May 3 2023, 6:19 PM · MITK (v2023.04)
s434n closed T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash as Resolved.
May 3 2023, 6:02 PM · MITK (v2023.04)
kislinsk triaged T29559: Replace Poco::Process with itksys_Process in VideoRecorder as Normal priority.
May 3 2023, 5:44 PM · MITK (v2023.04)
a178n added a comment to T29558: TotalSegmentator: Modify as per new Segmentation changes.

Pushed new branch to rMITK MITK: feature/T29558-totalseg-update.

May 3 2023, 5:43 PM · MITK (v2023.04)
kislinsk closed T29556: [Segmentation] "Delete" in label instance context menu deletes the whole label as Resolved.
May 3 2023, 5:40 PM · MITK (v2023.04)
s434n added a revision to T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash: Restricted Differential Revision.
May 3 2023, 5:40 PM · MITK (v2023.04)
kislinsk added a comment to T29556: [Segmentation] "Delete" in label instance context menu deletes the whole label.

Deleted branch from rMITK MITK: bugfix/T29556-AddDeleteLabelInstanceToContextMenu.

May 3 2023, 5:40 PM · MITK (v2023.04)
s434n added a revision to T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash: Restricted Differential Revision.
May 3 2023, 5:26 PM · MITK (v2023.04)
a178n added a parent task for T29558: TotalSegmentator: Modify as per new Segmentation changes: T29437: [SEG] Add TotalSegmentator.
May 3 2023, 4:52 PM · MITK (v2023.04)
a178n added a subtask for T29437: [SEG] Add TotalSegmentator: T29558: TotalSegmentator: Modify as per new Segmentation changes.
May 3 2023, 4:52 PM · MITK
floca added a comment to T29558: TotalSegmentator: Modify as per new Segmentation changes.

You should do a compbination (to keep the 4D support).

May 3 2023, 3:45 PM · MITK (v2023.04)
a178n added a comment to T29558: TotalSegmentator: Modify as per new Segmentation changes.

Hi @floca
The code in UpdatePrepare function for TotalSegmentator has a problem. Not a bug. The labelSet that you modify for the preview preemptively contains all possible labels, not just the ones that are predicted.

void mitk::TotalSegmentatorTool::UpdatePrepare()
{
  Superclass::UpdatePrepare();
  auto preview = this->GetPreviewSegmentation();
  auto labelset = preview->GetLabelSet(preview->GetActiveLayer());
  labelset->RemoveAllLabels();
  if (m_LabelMapTotal.empty())
  {
    this->ParseLabelNames(this->GetLabelMapPath());
  }
  auto labelMap = m_LabelMapTotal;
  const bool isSubTask = (this->GetSubTask() != DEFAULT_TOTAL_TASK);
  if (isSubTask)
  {
    std::vector<std::string> files = SUBTASKS_MAP.at(this->GetSubTask());
    labelMap.clear();
    mitk::Label::PixelType labelId = 1;
    for (auto const& file : files)
    {
      std::string labelName = file.substr(0, file.find('.'));
      labelMap[labelId] = labelName;
      labelId++;
    }
  }
  auto lookupTable = mitk::LookupTable::New();
  lookupTable->SetType(mitk::LookupTable::LookupTableType::MULTILABEL);
  for (auto const& [key, val] : labelMap)
  {
    Label::Pointer label = Label::New(key, val);
    std::array<double, 3> lookupTableColor;
    lookupTable->GetColor(key, lookupTableColor.data());
    Color color;
    color.SetRed(lookupTableColor[0]);
    color.SetGreen(lookupTableColor[1]);
    color.SetBlue(lookupTableColor[2]);
    label->SetColor(color);
    labelset->AddLabel(label, false);
  }
}

So, once the segmentation operation is completed and labels are shown in the List widget, all the possible labels are listed out for Confirmation instead of just what was really predicted. This is undesirable.
I think we should only show what label was predicted. For that, I believe, the labelset of the preview segmentation should be set only after its predicted, inside the DoUpdatePreview.
Basically, the lookup table and color setting done should be done lazily & not in UpdatePrepare method.

May 3 2023, 3:35 PM · MITK (v2023.04)
a178n updated subscribers of T29558: TotalSegmentator: Modify as per new Segmentation changes.
May 3 2023, 3:17 PM · MITK (v2023.04)
s434n closed T29554: [Segmentation] Creating a new group while interpolating causes crash as Resolved.
May 3 2023, 3:01 PM · MITK (v2023.04)
kislinsk added a revision to T29556: [Segmentation] "Delete" in label instance context menu deletes the whole label: Restricted Differential Revision.
May 3 2023, 3:01 PM · MITK (v2023.04)
s434n added a revision to T29554: [Segmentation] Creating a new group while interpolating causes crash: Restricted Differential Revision.
May 3 2023, 3:01 PM · MITK (v2023.04)
kislinsk added a comment to T29556: [Segmentation] "Delete" in label instance context menu deletes the whole label.

Pushed new branch to rMITK MITK: bugfix/T29556-AddDeleteLabelInstanceToContextMenu.

May 3 2023, 2:58 PM · MITK (v2023.04)
a178n triaged T29558: TotalSegmentator: Modify as per new Segmentation changes as High priority.
May 3 2023, 2:49 PM · MITK (v2023.04)
kislinsk claimed T29556: [Segmentation] "Delete" in label instance context menu deletes the whole label.
May 3 2023, 2:37 PM · MITK (v2023.04)
kislinsk updated the task description for T29556: [Segmentation] "Delete" in label instance context menu deletes the whole label.
May 3 2023, 12:32 PM · MITK (v2023.04)