Oh, I think I might have found the issue. Ignore the comment above and in CMake/Findlz4.cmake please add lib64 to the PATH_SUFFIXES of the two calls to find_library() in lines 11 and 18 like PATH_SUFFIXES lib lib64. Does it work?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Sep 24 2021
Thanks for the comprehensive report. Can you do me a favor and add message(FATAL_ERROR "include dirs: ${lz4_INCLUDE_DIR} libraries: ${lz4_LIBRARIES}") as last line to CMake/PackageDepends/MITK_lz4_Config.cmake and configure MITK (not superbuild) to get the output?
Sep 17 2021
Sep 15 2021
This could be connected to the undo/redo implementation of MITK and the creation of difference images for the undo stack. I do not know your version of MITK but the use of LZ4 compression for difference images in the latest versions could already be the or part of the solution. I agree that the operations should be much faster but they might be already as fast as the python implementation so whoever is working on this task should clock the different parts of the operation first to see what is actually taking so long and as said, if it is still the case in the latest version of MITK.
If it only affects the legacy segmentation type (not displayed as multilabel segmentation), it should be soon resolved with the segmentation refactoring anyway. I think a workaround for now could be to convert the legacy segmentation to a multilabel segmentation in MITK (Data Manager context menu?). This task is also potentially connected to T28521: multilabel segmentation add switch to disable contour.
This is already possible in the Properties view but I guess it is a good candidate to be more accessible from within the segmentation view or preference page.
I think I once looked into this specific issue and it turned out that your label values had quite some gaps between there values resulting in similar neighboring colors "by accident". Consecutive label values would be quite distinguishable. I am not sure if at least the first x colors follow a certain standard or not. This should be checked first before changing the colors.
@kleina already tried to add int64 as supported image type but it didn't work out of the box AFAIK. In theory it should be enough to add the type to the MITK_ACCESSBYITK_INTEGRAL_PIXEL_TYPES CMake variable. If we would be able to make this work, compilation time and binary size would increase noticeably, though, because of the templated nature of ITK.
Sep 6 2021
Sep 1 2021
Aug 11 2021
Aug 4 2021
Deleted branch from rMITK MITK: bugfix/T28657-FixMSVCv16.11WarningsAsErrors.
Pushed new branch to rMITK MITK: bugfix/T28657-FixMSVCv16.11WarningsAsErrors.
Jul 26 2021
Jul 21 2021
When deprecated classes are still around for a long time it is a valid base assumption that the reason is just that they were either forgotten since they weren't used or seen for a long time, or that it is surprisingly difficult to actually get rid of them since there's no real replacement for example but they are still in heavy use. The latter reason is something seen rather often in the core unfortunately.
Jul 20 2021
Deleted branch from rMITK MITK: feature/T28616-FixedSizeVisualizationForPointSets.
Jul 14 2021
Jul 13 2021
I continued migrating MITK. Without explicitly switching on any plugins, the Workbench already compiles and run. Switching on the WorkbenchRelease configuration (without MatchPoint, since I cannot currently compile it because of a compiler bug) compiles as well except for the following two classes which need a rewrite of their multi-threaded implementation, since the ITK base class changed its implementation in that regard:
Jul 10 2021
Deleted branch from rMITK MITK: bugfix/T28614-Revert.
Pushed new branch to rMITK MITK: bugfix/T28614-Revert.
Jul 9 2021
Deleted branch from rMITK MITK: bugfix/T28614-Simplify2DInterpolationFilterPipeline.
Pushed new branch to rMITK MITK: feature/T28616-FixedSizeVisualizationForPointSets.
Thanks!
Deleted branch from rMITK MITK: bugfix/T28385-AddNullptrCheck.
Pushed new branch to rMITK MITK: bugfix/T28385-AddNullptrCheck.
Deleted branch from rMITK MITK: bugfix/T28606-StoreImageDimension.
Pushed new branch to rMITK MITK: bugfix/T28606-StoreImageDimension.
Thanks for the suggestion and patch! 👍
Deleted branch from rMITK MITK: bugfix/T28606-UseLZ4InCompressedImageContainerClass.
Deleted branch from rMITK MITK: bugfix/T28385-InterpolationCrashOnMorphologicalOperations.
Jul 8 2021
Pushed new branch to rMITK MITK: bugfix/T28614-Simplify2DInterpolationFilterPipeline.
Jul 7 2021
Pushed new branch to rMITK MITK: bugfix/T28385-InterpolationCrashOnMorphologicalOperations.
We can fix it in the SegmentationInterpolationController by explicitly handling the situation that the modified image is not initialized (IsInitialized() == false).