Page MenuHomePhabricator
Feed Advanced Search

Oct 18 2022

kalali claimed T28793: [Segmentation][Multilabel][Options] Changing only decimation rate has no visible effect in "Create smoothed polygon model".
Oct 18 2022, 5:45 PM · Cleared, MITK (v2022.10), Checklist
kalali added a comment to T28793: [Segmentation][Multilabel][Options] Changing only decimation rate has no visible effect in "Create smoothed polygon model".

I looked into this and can verify that there is no visible effect when changing the decimation rate. The property "Decimation rate" is correctly used inside ShowSegmentationAsSurface::ConvertBinaryImageToSurface as reductionRate. It is then used as an argument for ImageToSurfaceFilter::SetTargetReduction. The brief description of this parameter is:

Oct 18 2022, 5:45 PM · Cleared, MITK (v2022.10), Checklist
kalali added a comment to T29352: Segmentation Options Checklist - "Create Smoothed Polygon" Seems Not to Work.

I tested this and the smoothing works but as stated in the description it should be made more obvious what to do.
As @kislinsk wrote we will not tackle this issue here but instead remove the options from the preferences. However, this is more about the context menu action "Create smoothed polygon model". Should the whole action be removed? Or are we only talking about the additional preferences for "Smoothed surface creation"? If only the preferences should be removed we still need to adapt the checklist to make it more clear how a smoothed polygon should be created.

Oct 18 2022, 5:33 PM · MITK (v2024.06), Cleared, Checklist

Oct 17 2022

kalali added a comment to T29348: Improve Welcome page with basic navigation hints.

A short but clear description of the interaction types is given in the MITK StdMultiWidget Editor help page (F1 on "StandardDisplay"):

Oct 17 2022, 7:10 PM · Cleared, Checklist, MITK (v2022.10)
kalali moved T29349: [SEG] Improve/correct button names of live wire/lasso tool. from Segmentation to Cycle on the MITK (v2022.10) board.
Oct 17 2022, 6:59 PM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kalali added a comment to T29349: [SEG] Improve/correct button names of live wire/lasso tool..

I changed the strings according to the suggestions in this task.
However, your last comment only stated to rename the "Clear Segmentation" button.

Oct 17 2022, 6:58 PM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kalali added a revision to T29349: [SEG] Improve/correct button names of live wire/lasso tool.: Unknown Object (Differential Revision).
Oct 17 2022, 6:56 PM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kalali claimed T29349: [SEG] Improve/correct button names of live wire/lasso tool..
Oct 17 2022, 6:53 PM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kalali closed T29355: Update 3D Segmentation Checklist to reflect current 3D Segmentation tools status as Resolved.
Oct 17 2022, 6:00 PM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kalali moved T29355: Update 3D Segmentation Checklist to reflect current 3D Segmentation tools status from Backlog to Cycle on the MITK (v2022.10) board.

I updated the "Checklist Segmentation – 3D Segmentation_EN":

  • updated tool-image (no region growing, new icon for Picking and GrowCut)
  • removed region growing test section, changed order of tool sections
  • updated Otsu-tool GUI image
  • added description of "Transfer ..." checkboxes
  • modified description of "GrowCut"-tool
Oct 17 2022, 6:00 PM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kalali claimed T29355: Update 3D Segmentation Checklist to reflect current 3D Segmentation tools status.
Oct 17 2022, 5:22 PM · Cleared, Restricted Project, Checklist, MITK (v2022.10)
kalali renamed T29333: [mxn multi widget] Measurements / planar figure not working from [mxn multi widet] Measurements / planar figure not working to [mxn multi widget] Measurements / planar figure not working.
Oct 17 2022, 4:44 PM · MITK (v2024.06)
kalali renamed T29365: [mxn multi widget] Pointset interaction not working from [mxn multi widet] Pointset interaction not working to [mxn multi widget] Pointset interaction not working.
Oct 17 2022, 4:44 PM · MITK (v2024.06)
kalali updated the task description for T25595: [Multi widget] Make classes work with the new render window access.
Oct 17 2022, 4:43 PM · MITK (v2024.06)
kalali edited projects for T29333: [mxn multi widget] Measurements / planar figure not working, added: MITK, Next Milestone; removed MITK (v2022.10).
Oct 17 2022, 4:39 PM · MITK (v2024.06)
kalali triaged T29365: [mxn multi widget] Pointset interaction not working as Normal priority.
Oct 17 2022, 4:39 PM · MITK (v2024.06)
kalali added a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29364: [mxn multi widget] Image navigator cannot be used.
Oct 17 2022, 4:37 PM · MITK
kalali added a parent task for T29364: [mxn multi widget] Image navigator cannot be used: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Oct 17 2022, 4:37 PM · MITK (v2024.06)
kalali renamed T29333: [mxn multi widget] Measurements / planar figure not working from Measurements / planar figure not working with MxNMultiWidget to [mxn multi widet] Measurements / planar figure not working.
Oct 17 2022, 4:36 PM · MITK (v2024.06)
kalali triaged T29364: [mxn multi widget] Image navigator cannot be used as Normal priority.
Oct 17 2022, 4:29 PM · MITK (v2024.06)
kalali updated the task description for T25595: [Multi widget] Make classes work with the new render window access.
Oct 17 2022, 3:49 PM · MITK (v2024.06)
kalali updated the task description for T29303: IGT classes do not work correctly with the new mxn multi widget.
Oct 17 2022, 3:17 PM · MITK (v2024.06)
kalali closed T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor), a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 17 2022, 3:16 PM · MITK
kalali closed T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor) as Resolved.
Oct 17 2022, 3:16 PM · MITK (v2022.10)
kalali updated the task description for T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor).
Oct 17 2022, 3:15 PM · MITK (v2022.10)
kalali updated the task description for T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor).
Oct 17 2022, 3:10 PM · MITK (v2022.10)
kalali closed T26376: Segmentation plugin does not work correctly with the new mxn multi widget as Resolved.
Oct 17 2022, 2:42 PM · MITK (v2022.10)
kalali closed T26376: Segmentation plugin does not work correctly with the new mxn multi widget, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 17 2022, 2:42 PM · MITK
kalali updated the task description for T26376: Segmentation plugin does not work correctly with the new mxn multi widget.
Oct 17 2022, 2:42 PM · MITK (v2022.10)
kalali added a project to T29335: [Segmentation] Show interactive warning for uninitialized render window geometry: Next Milestone.
Oct 17 2022, 2:42 PM · MITK (v2023.04)
kalali edited projects for T29240: [mxn multi widget] Allow different time navigation controller for each individual render window, added: MITK, Next Milestone; removed MITK (v2022.10).
Oct 17 2022, 2:40 PM · MITK (v2024.06)
kalali closed T29328: Fix different issues with re-initialization, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 17 2022, 2:19 PM · MITK
kalali closed T29328: Fix different issues with re-initialization as Resolved.
Oct 17 2022, 2:19 PM · MITK (v2022.10)
kalali committed rMITK09007650bd19: Fix wrong view initialization when creating a new segmentation node (authored by kalali).
Fix wrong view initialization when creating a new segmentation node
Oct 17 2022, 2:19 PM
kalali committed rMITK0511fb6554b0: Add virtual function for subclass (authored by kalali).
Add virtual function for subclass
Oct 17 2022, 2:19 PM
kalali committed rMITK96b562bb993a: Set correct slice when resetting the geometry (authored by kalali).
Set correct slice when resetting the geometry
Oct 17 2022, 2:19 PM
kalali committed rMITKd8230d497e9d: Provide function for setting the reference geometry (authored by kalali).
Provide function for setting the reference geometry
Oct 17 2022, 2:19 PM
kalali committed rMITK08d0678d07b3: Provide function for setting the reference geometry (authored by kalali).
Provide function for setting the reference geometry
Oct 17 2022, 2:19 PM
kalali committed rMITK3a8f3b251750: Provide function to re-initialize the views of a render window part (authored by kalali).
Provide function to re-initialize the views of a render window part
Oct 17 2022, 2:19 PM
kalali committed rMITKde0ac9d49846: Remove re-initialization from QmitkAbstractView (authored by kalali).
Remove re-initialization from QmitkAbstractView
Oct 17 2022, 2:19 PM
kalali updated the task description for T29328: Fix different issues with re-initialization.
Oct 17 2022, 1:28 PM · MITK (v2022.10)

Oct 14 2022

kalali removed a parent task for T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations: T25595: [Multi widget] Make classes work with the new render window access.
Oct 14 2022, 1:10 PM · Breaking Change, Noteworthy, MITK
kalali removed a subtask for T25595: [Multi widget] Make classes work with the new render window access: T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations.
Oct 14 2022, 1:10 PM · MITK (v2024.06)
kalali closed T29360: [Storage inspector] Node predicate not used correctly as Resolved.
Oct 14 2022, 10:50 AM · MITK (v2022.10)
kalali committed rMITKbced527a2d6b: Use node predicate correctly (authored by kalali).
Use node predicate correctly
Oct 14 2022, 10:50 AM
kalali committed rMITK03fc617fe874: Check node predicate before adding a node (authored by kalali).
Check node predicate before adding a node
Oct 14 2022, 10:50 AM
kalali moved T29360: [Storage inspector] Node predicate not used correctly from Backlog to Cycle on the MITK (v2022.10) board.
Oct 14 2022, 10:49 AM · MITK (v2022.10)
kalali closed T29203: [Multi widget] Make classes work with the new render window names, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 14 2022, 10:48 AM · MITK
kalali closed T29203: [Multi widget] Make classes work with the new render window names as Resolved.
Oct 14 2022, 10:48 AM · MITK (v2022.10)
kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Oct 14 2022, 10:48 AM · MITK (v2022.10)
kalali committed rMITK3c4cdf84f1e7: Remove render window names (authored by kalali).
Remove render window names
Oct 14 2022, 10:47 AM
kalali committed rMITKf9ac67cfdb45: Perform view rotation for all 3D render windows (authored by kalali).
Perform view rotation for all 3D render windows
Oct 14 2022, 10:47 AM
kalali committed rMITK4e785394bcb5: Remove commented hard-coded render window name (authored by kalali).
Remove commented hard-coded render window name
Oct 14 2022, 10:47 AM
kalali committed rMITKe4d8a0826fa2: Remove hard-coded render window names (authored by kalali).
Remove hard-coded render window names
Oct 14 2022, 10:47 AM
kalali committed rMITK5edcdde69eba: Remove hard-coded render window names (authored by kalali).
Remove hard-coded render window names
Oct 14 2022, 10:47 AM

Oct 13 2022

kalali triaged T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly as Normal priority.
Oct 13 2022, 3:58 PM · Request for Discussion, MITK (v2023.04)
kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Oct 13 2022, 3:44 PM · MITK (v2022.10)
kalali committed rMITKcf5bda653f11: Fix the block sign that was not removed correctly (authored by kalali).
Fix the block sign that was not removed correctly
Oct 13 2022, 3:19 PM
kalali committed rMITKde9837aa3ebd: Use a text overlay widget on top of the QmitkRenderWindow (authored by kalali).
Use a text overlay widget on top of the QmitkRenderWindow
Oct 13 2022, 3:19 PM
kalali committed rMITK7e3ef135919c: Remove the annotation and simply show / hide the overlay widget (authored by kalali).
Remove the annotation and simply show / hide the overlay widget
Oct 13 2022, 3:19 PM
kalali added a revision to T29360: [Storage inspector] Node predicate not used correctly: Unknown Object (Differential Revision).
Oct 13 2022, 3:10 PM · MITK (v2022.10)
kalali closed T29331: Use NodePredicates for the render window data node selector, a subtask of T29297: [mxn multi widget] Optimize data accessibility inside render windows, as Resolved.
Oct 13 2022, 2:02 PM · MITK (v2023.04)
kalali closed T29331: Use NodePredicates for the render window data node selector as Resolved.
Oct 13 2022, 2:02 PM · MITK (v2022.10)
kalali triaged T29360: [Storage inspector] Node predicate not used correctly as Normal priority.
Oct 13 2022, 2:02 PM · MITK (v2022.10)
kalali committed rMITKfee6851a4b20: Correctly use the node predicates for the render window data storage inspector (authored by kalali).
Correctly use the node predicates for the render window data storage inspector
Oct 13 2022, 1:41 PM
kalali committed rMITKad189cd92af8: Remove custom function and rely on base class function (authored by kalali).
Remove custom function and rely on base class function
Oct 13 2022, 1:41 PM
kalali committed rMITK474c7a662bc8: Set a custom node predicate to filter out helper nodes (authored by kalali).
Set a custom node predicate to filter out helper nodes
Oct 13 2022, 1:41 PM
kalali committed rMITK1d58c11df634: Combine the node predicates for node filtering (authored by kalali).
Combine the node predicates for node filtering
Oct 13 2022, 1:41 PM
kalali committed rMITK7aa4e29633e6: Simplify the utilities-nodepredicate (authored by kalali).
Simplify the utilities-nodepredicate
Oct 13 2022, 1:41 PM
kalali updated the task description for T29328: Fix different issues with re-initialization.
Oct 13 2022, 12:44 PM · MITK (v2022.10)

Oct 12 2022

kalali updated the task description for T29328: Fix different issues with re-initialization.
Oct 12 2022, 7:14 PM · MITK (v2022.10)

Oct 7 2022

kalali added a revision to T29331: Use NodePredicates for the render window data node selector: Unknown Object (Differential Revision).
Oct 7 2022, 5:47 PM · MITK (v2022.10)
kalali renamed T29331: Use NodePredicates for the render window data node selector from Use NodePreidcates for the render window data node selector to Use NodePredicates for the render window data node selector.
Oct 7 2022, 5:33 PM · MITK (v2022.10)
kalali added a comment to T29331: Use NodePredicates for the render window data node selector.

I looked into this and I was confused: the used QmitkRenderWindowDataStorageTreeModel already contains a node predicate for filtering out the helper nodes. When creating the mxnmultiwidget (or a new render window) there are no plane geometries (the crosshair) being added to the storage model.

Oct 7 2022, 5:33 PM · MITK (v2022.10)
kalali triaged T29335: [Segmentation] Show interactive warning for uninitialized render window geometry as Normal priority.
Oct 7 2022, 3:11 PM · MITK (v2023.04)
kalali triaged T29333: [mxn multi widget] Measurements / planar figure not working as Normal priority.
Oct 7 2022, 11:17 AM · MITK (v2024.06)
kalali triaged T29331: Use NodePredicates for the render window data node selector as Normal priority.
Oct 7 2022, 10:48 AM · MITK (v2022.10)
kalali added a comment to T29298: [mxn multi widget] Add context menu to render window specific data inspector.

A simple context-menu was added in {D726}. Needs to be reworked to allow more actions.

Oct 7 2022, 10:47 AM · MITK

Oct 6 2022

kalali added a revision to T26376: Segmentation plugin does not work correctly with the new mxn multi widget: Unknown Object (Differential Revision).
Oct 6 2022, 8:05 PM · MITK (v2022.10)
kalali updated the task description for T29328: Fix different issues with re-initialization.
Oct 6 2022, 6:27 PM · MITK (v2022.10)
kalali added a revision to T29328: Fix different issues with re-initialization: Unknown Object (Differential Revision).
Oct 6 2022, 5:16 PM · MITK (v2022.10)
kalali committed rMITK9aaeac124c08: Render window specific geometry comparison fixes (authored by kalali).
Render window specific geometry comparison fixes
Oct 6 2022, 5:07 PM
kalali committed rMITKc59fca092441: Throw and catch exception for invalid timepoint (authored by kalali).
Throw and catch exception for invalid timepoint
Oct 6 2022, 5:07 PM
kalali committed rMITKd9305def4d07: Remove 3D-render-window geometry comparison (authored by kalali).
Remove 3D-render-window geometry comparison
Oct 6 2022, 5:07 PM
kalali triaged T29328: Fix different issues with re-initialization as Normal priority.
Oct 6 2022, 5:04 PM · MITK (v2022.10)
kalali added a revision to T26376: Segmentation plugin does not work correctly with the new mxn multi widget: Unknown Object (Differential Revision).
Oct 6 2022, 10:30 AM · MITK (v2022.10)
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

{D727} was opened in addition to {D722} to fix some bugs, make the code cleaner.

Oct 6 2022, 10:30 AM · MITK (v2022.10)
kalali added inline comments to rMITK5526efb9500a: Optimization of the mxnmultiwidget.
Oct 6 2022, 7:52 AM
kalali added inline comments to rMITK5526efb9500a: Optimization of the mxnmultiwidget.
Oct 6 2022, 7:40 AM
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

The geometry-comparison has been fixed. Slice interpolation needs to be tested and probably tackled as well.

Oct 6 2022, 7:37 AM · MITK (v2022.10)
kalali updated the task description for T26376: Segmentation plugin does not work correctly with the new mxn multi widget.
Oct 6 2022, 7:37 AM · MITK (v2022.10)

Oct 5 2022

kalali closed T25105: UpdateStatusBar duplicates business logic as Resolved.
Oct 5 2022, 10:08 PM · MITK (v2022.10)
kalali added a comment to T25043: Remove pixel informations from the statusbar and put it into views.

Pixel information has been removed. To add a specific view for pixel information, see T29324: Create view for pixel information.

Oct 5 2022, 10:07 PM · Cleared, MITK
kalali committed rMITK7b8c4c8af97d: Remove duplicated UpdateStatusBar logic (authored by kalali).
Remove duplicated UpdateStatusBar logic
Oct 5 2022, 10:05 PM
kalali committed rMITKdced93baf4c9: Use time-specific data type (authored by kalali).
Use time-specific data type
Oct 5 2022, 10:05 PM
kalali committed rMITKb309cff2567b: Perform simple statusbar update on mouse move / wheel event (authored by kalali).
Perform simple statusbar update on mouse move / wheel event
Oct 5 2022, 10:05 PM
kalali closed T25043: Remove pixel informations from the statusbar and put it into views, a subtask of T25042: How to handle update informations in heterogeneous time geometries and out of bound situations , as Resolved.
Oct 5 2022, 10:05 PM · MITK
kalali committed rMITKd527ccc37170: Add function to simply display the world position and time (authored by kalali).
Add function to simply display the world position and time
Oct 5 2022, 10:05 PM
kalali closed T25043: Remove pixel informations from the statusbar and put it into views as Resolved by committing rMITKb309cff2567b: Perform simple statusbar update on mouse move / wheel event.
Oct 5 2022, 10:05 PM · Cleared, MITK
kalali closed T25043: Remove pixel informations from the statusbar and put it into views, a subtask of T25105: UpdateStatusBar duplicates business logic, as Resolved.
Oct 5 2022, 10:05 PM · MITK (v2022.10)