Page MenuHomePhabricator
Feed Advanced Search

Wed, Jan 18

kalali added a comment to T29297: [mxn multi widget] Optimize data accessibility inside render windows.

@s434n I added my draft with a custom multi node selection widget and several action buttons. There are some things missing and going wrong but this should give you a better overview of the current status.
Things that are not working correctly / are missing:

  • thumbnail / pixmap for the data node
  • currently the widget is not reacting on node changes (name change or later, thumbnail change)
  • moving an item in the list does not change the layer order
  • currently the length of the list widget / item is defined by the string and thus the push buttons are not aligned
    • also the whole widget is not extended if a name is too long
Wed, Jan 18, 6:29 PM · MITK (v2023.04)
kalali added a revision to T29297: [mxn multi widget] Optimize data accessibility inside render windows: Unknown Object (Differential Revision).
Wed, Jan 18, 6:24 PM · MITK (v2023.04)
kalali moved T24738: [Selection concept] Thumbnail preview of images for datastorage inspectors from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Wed, Jan 18, 4:54 PM · MITK (v2023.04), Restricted Project
kalali edited projects for T24738: [Selection concept] Thumbnail preview of images for datastorage inspectors, added: MITK (v2023.04); removed MITK, Next Milestone.
Wed, Jan 18, 4:54 PM · MITK (v2023.04), Restricted Project

Tue, Jan 10

kalali added a comment to T29297: [mxn multi widget] Optimize data accessibility inside render windows.

Pushed new branch to rMITK MITK: feature/T29297-Use-selection-widgets-in-render-window-utility.

Tue, Jan 10, 3:15 PM · MITK (v2023.04)
kalali closed T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Tue, Jan 10, 2:57 PM · MITK (v2022.10), Breaking Change
kalali closed T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module as Resolved.
Tue, Jan 10, 2:57 PM · MITK (v2023.04)
kalali committed rMITK12e940a97f08: Move utilities widgets to module (authored by kalali).
Move utilities widgets to module
Tue, Jan 10, 2:56 PM
kalali committed rMITKedc932665302: Fix wrong icon reference after moving the selection widgets (authored by kalali).
Fix wrong icon reference after moving the selection widgets
Tue, Jan 10, 2:56 PM
kalali committed rMITK3274299dbde3: Provide getter/setter for data storage and add contructor parameter (authored by kalali).
Provide getter/setter for data storage and add contructor parameter
Tue, Jan 10, 2:56 PM
kalali committed rMITK162230469962: Move controls include to .cpp-file (authored by kalali).
Move controls include to .cpp-file
Tue, Jan 10, 2:56 PM
kalali committed rMITKfc363dd5f9e2: Fix includes for ui-files (authored by kalali).
Fix includes for ui-files
Tue, Jan 10, 2:56 PM
kalali committed rMITKf0a3da3acbe2: Move DataSelectionWidget to the SegmentationUI module (authored by kalali).
Move DataSelectionWidget to the SegmentationUI module
Tue, Jan 10, 2:56 PM
kalali committed rMITK49949baef127: Remove the "SegmentationUtilities" subdirectory (authored by kalali).
Remove the "SegmentationUtilities" subdirectory
Tue, Jan 10, 2:56 PM
kalali committed rMITK195b495c9533: Add utility tools to the segmentation ui module (authored by kalali).
Add utility tools to the segmentation ui module
Tue, Jan 10, 2:56 PM
kalali committed rMITK63c5bab4c89e: Remove utility tools from the segmentation plugin (authored by kalali).
Remove utility tools from the segmentation plugin
Tue, Jan 10, 2:56 PM

Mon, Jan 9

kalali closed T29027: Move NodeSelectionWidgets to QtWidgets module, a subtask of T29130: [WorkBench] Segmentation fault when "Close Project" is invoked and QmitkDataStorageComboBox widget is in UI, as Resolved.
Mon, Jan 9, 1:32 PM · MITK (v2023.04)
kalali closed T29027: Move NodeSelectionWidgets to QtWidgets module as Resolved.
Mon, Jan 9, 1:32 PM · MITK (v2023.04)
kalali committed rMITK3991d268266b: Move selection widgets to module (authored by kalali).
Move selection widgets to module
Mon, Jan 9, 12:48 PM
kalali committed rMITKa69ec5fd4f4e: Move selection widget and related classes to module (authored by kalali).
Move selection widget and related classes to module
Mon, Jan 9, 12:48 PM
kalali committed rMITK050d60110c49: Remove selection widget and related classes from plugin (authored by kalali).
Remove selection widget and related classes from plugin
Mon, Jan 9, 12:48 PM

Fri, Jan 6

kalali closed T29438: org.mitk.gui.common plugin is not initializing the CppMicroService as Resolved.
Fri, Jan 6, 9:15 AM · MITK
kalali committed rMITKc82c8ebf64bd: Initialize CppMicroService in gui.common plugin (authored by kalali).
Initialize CppMicroService in gui.common plugin
Fri, Jan 6, 9:14 AM
kalali committed rMITK58ccd21018c6: Clean up the gui.qt.application plugin (authored by kalali).
Clean up the gui.qt.application plugin
Fri, Jan 6, 9:14 AM
kalali committed rMITKf7e8412f739f: Initialize CppMicroService inside the plugin activator class (authored by kalali).
Initialize CppMicroService inside the plugin activator class
Fri, Jan 6, 9:14 AM

Thu, Jan 5

kalali added a revision to T29438: org.mitk.gui.common plugin is not initializing the CppMicroService: Unknown Object (Differential Revision).
Thu, Jan 5, 1:34 PM · MITK
kalali renamed T29438: org.mitk.gui.common plugin is not initializing the CppMicroService from org.mitk.gui.common plugin is not initializing the the CppMicroService to org.mitk.gui.common plugin is not initializing the CppMicroService.
Thu, Jan 5, 12:47 PM · MITK
kalali created T29438: org.mitk.gui.common plugin is not initializing the CppMicroService.
Thu, Jan 5, 12:45 PM · MITK
kalali edited parent tasks for T24216: Synchronization of individual render windows: camera position, added: T29393: [mxn multi widget] Concept for individual render window synchronization; removed: T23758: Introduction of custom multi widget editor.
Thu, Jan 5, 9:37 AM · MITK (v2023.04)
kalali removed a subtask for T23758: Introduction of custom multi widget editor: T24216: Synchronization of individual render windows: camera position.
Thu, Jan 5, 9:37 AM · Restricted Project, MITK
kalali added a subtask for T29393: [mxn multi widget] Concept for individual render window synchronization: T24216: Synchronization of individual render windows: camera position.
Thu, Jan 5, 9:37 AM · MITK
kalali added a comment to T29393: [mxn multi widget] Concept for individual render window synchronization.

Somehow related:

Thu, Jan 5, 9:37 AM · MITK
kalali moved T24216: Synchronization of individual render windows: camera position from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Thu, Jan 5, 9:37 AM · MITK (v2023.04)
kalali reopened T24216: Synchronization of individual render windows: camera position, a subtask of T23758: Introduction of custom multi widget editor, as Open.
Thu, Jan 5, 9:37 AM · Restricted Project, MITK
kalali reopened T24216: Synchronization of individual render windows: camera position as "Open".
Thu, Jan 5, 9:37 AM · MITK (v2023.04)
kalali moved T29297: [mxn multi widget] Optimize data accessibility inside render windows from mxn MultiWidget to Cycle on the MITK (v2023.04) board.
Thu, Jan 5, 9:29 AM · MITK (v2023.04)
kalali claimed T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Thu, Jan 5, 9:29 AM · MITK (v2023.04)
kalali added a comment to T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D.

Related: T13465: Two 3D RenderWindows at the same time interfere with each other.

Thu, Jan 5, 9:26 AM · MITK, Pull Request

Jan 4 2023

kalali claimed T29027: Move NodeSelectionWidgets to QtWidgets module.
Jan 4 2023, 10:03 AM · MITK (v2023.04)
kalali claimed T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module.
Jan 4 2023, 10:03 AM · MITK (v2023.04)
kalali moved T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module from Segmentation to Cycle on the MITK (v2023.04) board.
Jan 4 2023, 10:02 AM · MITK (v2023.04)
kalali moved T29027: Move NodeSelectionWidgets to QtWidgets module from Backlog to Cycle on the MITK (v2023.04) board.
Jan 4 2023, 10:02 AM · MITK (v2023.04)

Jan 3 2023

kalali added a comment to T29415: [mxn multi widget] Allow mxn windows to show 3D view.

I may have found the problem but unfortunately for me that looks like it cannot be easily fixed:
During PlaneGeometryDataVtkMapper3D::ProcessNode, when the plane node to be rendered is processed (called from PlaneGeometryDataVtkMapper3D::GenerateDataForRenderer), imageMapper->Update(planeRenderer) is called. Here the imageMapper is the 2D mapper from the plane node.
Inside ImageVtkMapper2D::Update the mapper is updated by calling ImageVtkMapper2D::GenerateDataForRenderer. This in turn leads to the following line: const PlaneGeometry *worldGeometry = renderer->GetCurrentWorldPlaneGeometry(). I think this is problematic since here the current world plane geometry is used, which is the sliced geometry from the base renderer. However, for the 3D render window the sliced geometry is still either the axial, sagittal or coronal plane. It doesn't matter if we created three different planes from the world time geometry for the base renderer, the world plane geomertry will always be a specific sliced geometry.
Since these steps are performed for all three plane nodes to be rendered, all three plane nodes render the same world plane geometry.

Jan 3 2023, 9:11 PM · MITK (v2023.04)
kalali claimed T29415: [mxn multi widget] Allow mxn windows to show 3D view.
Jan 3 2023, 3:41 PM · MITK (v2023.04)
kalali added a comment to T29415: [mxn multi widget] Allow mxn windows to show 3D view.

It seems as if there is a general problem with the current crosshair: The crosshair manager provides three planes / plane geometries for each render window such that changing the view direction / anatomical plane will just switch to the corresponding geometry and render the information based on that geometry.
Having done some test with the visiblity of the planes, rendering inside the StdMultiWidget shows that all three planes (axial, sagittal, coronal) of a render window show the same image information / anatomical plane. Changing the view diretion inside the render window will change the anatomical plane, but then all three planes show the same image information of the newly selected anatomical plane.

Jan 3 2023, 3:39 PM · MITK (v2023.04)
kalali added a comment to T29415: [mxn multi widget] Allow mxn windows to show 3D view.

I managed to fix the rendering of the 3D data even more and now the image information / pixel are shown.
But now the data seems to be inverted on some planes such that the three 2D planes do not match and form a 3D object.

Jan 3 2023, 10:19 AM · MITK (v2023.04)

Jan 2 2023

kalali added a comment to T29415: [mxn multi widget] Allow mxn windows to show 3D view.

So I fixed part of it by setting a PlaneGeometryDataVtkMapper3D explicitly as done in {D759} for the 2D mapper. Then I was able to immediately set a valid data storage and the crash is fixed.
The three planes are rendered inside the 3D render window but only the frame is visible - no image information / pixel is shown.

Jan 2 2023, 4:43 PM · MITK (v2023.04)
kalali added a comment to T29415: [mxn multi widget] Allow mxn windows to show 3D view.

So it seems as if the PlaneGeometryDataVtkMapper3D is newly created (automatically) when a render window is changed to a 3D render window (mapper changed to Standard3D).
In that case, the m_DataStorage is empty and the following functions crash (e.g. mitk::DataStorage::SetOfObjects::ConstPointer all = m_DataStorage.Lock()->GetSubset(predicateAllImages);) inside PlaneGeometryDataVtkMapper3D::GenerateDataForRenderer.

Jan 2 2023, 11:41 AM · MITK (v2023.04)
kalali added a comment to T29415: [mxn multi widget] Allow mxn windows to show 3D view.

I found out that the 3D render window of the StdMultiWidget does not render the data if the widget-plane helper-nodes are removed from the data storage.
If the widget-plane helper-nodes are available but hidden only from the 3D render window (set visibility for that render window to false using properties), the 3D render window does not render the data.
If e.g. one widget-plane helper-node is visible that 2D plane allows to render the data inside the 3D render window, but only the specific 2D plane is visible and not all three view directions.

Jan 2 2023, 10:36 AM · MITK (v2023.04)
kalali added a comment to T29415: [mxn multi widget] Allow mxn windows to show 3D view.

We discovered that it is currently not possible to use RenderWindowViewDirectionController::SetViewDirectionOfRenderer to change the view direction / rendering of a render window to 3D.
@s434n found out that in order to show the 3D rendering other render windows need to provide the three 2D views for the object in order to have data available to render.

Jan 2 2023, 8:48 AM · MITK (v2023.04)

Dec 7 2022

kalali added a revision to T29027: Move NodeSelectionWidgets to QtWidgets module: Unknown Object (Differential Revision).
Dec 7 2022, 3:30 PM · MITK (v2023.04)

Nov 30 2022

kalali awarded MITK v2022.10 a Yellow Medal token.
Nov 30 2022, 4:20 PM
kalali moved T29420: [Segmentation] SegWithPreviewTool does not work with vector / multi channel images from Backlog to Segmentation on the MITK (v2023.04) board.
Nov 30 2022, 3:35 PM · MITK (v2023.04)
kalali triaged T29420: [Segmentation] SegWithPreviewTool does not work with vector / multi channel images as Normal priority.
Nov 30 2022, 3:35 PM · MITK (v2023.04)
kalali renamed T29396: [Segmentation] Newly created labelset image has wrong image type from Growcut error to [Segmentation] Newly created labelset image has wrong image type.
Nov 30 2022, 3:30 PM · MITK (v2023.04)
kalali added a subtask for T29369: [Segmentation Utilities] Handle / select different labels independently: T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns.
Nov 30 2022, 2:11 PM · MITK (v2023.04)
kalali added a parent task for T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns: T29369: [Segmentation Utilities] Handle / select different labels independently.
Nov 30 2022, 2:11 PM · MITK (v2023.04), Checklist
kalali added a comment to T29369: [Segmentation Utilities] Handle / select different labels independently.

Should be tackled as soon as T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns is done.

Nov 30 2022, 2:10 PM · MITK (v2023.04)
kalali removed a subtask for T27613: Improve reinit behavior: Unknown Object (Maniphest Task).
Nov 30 2022, 2:08 PM · Request for Discussion, MITK (v2023.04)
kalali removed a subtask for T27613: Improve reinit behavior: T29094: Deleting a data node causes global reset.
Nov 30 2022, 2:08 PM · Request for Discussion, MITK (v2023.04)
kalali removed a parent task for T29094: Deleting a data node causes global reset: T27613: Improve reinit behavior.
Nov 30 2022, 2:08 PM · MITK, Checklist
kalali closed T27613: Improve reinit behavior as Resolved.

Adding a data node reset-geometry-action was a first step and enough to tackle this issue. If there are more requirements for some "intelligence", new tasks need to be opened.

Nov 30 2022, 2:07 PM · Request for Discussion, MITK (v2023.04)
kalali closed T29385: [mxn multi widget] Pixel value view does not change on crosshair selection as Resolved.

Render window specific visibility has to be covered, as mentioned in D756#26848. This will be done in T29403: [mxn multi widget] Concept for crosshair data type.

Nov 30 2022, 2:04 PM · MITK (v2023.04)
kalali updated the task description for T29403: [mxn multi widget] Concept for crosshair data type.
Nov 30 2022, 2:04 PM · MITK (v2023.04), Request for Discussion
kalali closed T26394: [Render window manager] Provide tree view / model, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Wontfix.
Nov 30 2022, 2:02 PM · MITK
kalali closed T26394: [Render window manager] Provide tree view / model as Wontfix.

This task is invalid; related work will be continued in T29297: [mxn multi widget] Optimize data accessibility inside render windows.

Nov 30 2022, 2:02 PM · MITK (v2023.04), Restricted Project
kalali moved T29297: [mxn multi widget] Optimize data accessibility inside render windows from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Nov 30 2022, 2:01 PM · MITK (v2023.04)
kalali edited projects for T29297: [mxn multi widget] Optimize data accessibility inside render windows, added: MITK (v2023.04); removed MITK.
Nov 30 2022, 2:01 PM · MITK (v2023.04)
kalali moved T25057: Check IContextMenuActions and extension points from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 10:30 AM · MITK (v2023.04)
kalali edited projects for T25057: Check IContextMenuActions and extension points, added: MITK (v2023.04); removed MITK.
Nov 30 2022, 10:30 AM · MITK (v2023.04)
kalali moved T29385: [mxn multi widget] Pixel value view does not change on crosshair selection from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:54 AM · MITK (v2023.04)
kalali edited projects for T29385: [mxn multi widget] Pixel value view does not change on crosshair selection, added: MITK (v2023.04); removed MITK.
Nov 30 2022, 9:54 AM · MITK (v2023.04)
kalali moved T29386: [mxn multi widget] StdDisplay unnecessarily uses the crosshair manager from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Nov 30 2022, 9:53 AM · MITK (v2023.04)
kalali edited projects for T29386: [mxn multi widget] StdDisplay unnecessarily uses the crosshair manager, added: MITK (v2023.04); removed MITK.
Nov 30 2022, 9:53 AM · MITK (v2023.04)
kalali moved T29403: [mxn multi widget] Concept for crosshair data type from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Nov 30 2022, 9:53 AM · MITK (v2023.04), Request for Discussion
kalali edited projects for T29403: [mxn multi widget] Concept for crosshair data type, added: MITK (v2023.04); removed MITK.
Nov 30 2022, 9:53 AM · MITK (v2023.04), Request for Discussion
kalali moved T29130: [WorkBench] Segmentation fault when "Close Project" is invoked and QmitkDataStorageComboBox widget is in UI from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:51 AM · MITK (v2023.04)
kalali edited projects for T29130: [WorkBench] Segmentation fault when "Close Project" is invoked and QmitkDataStorageComboBox widget is in UI, added: MITK (v2023.04); removed MITK.
Nov 30 2022, 9:51 AM · MITK (v2023.04)
kalali moved T29163: [XNAT] Opening XNAT session fails from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:50 AM · MITK (v2023.04)
kalali edited projects for T29163: [XNAT] Opening XNAT session fails, added: MITK (v2023.04); removed MITK.
Nov 30 2022, 9:50 AM · MITK (v2023.04)
kalali moved T27090: Provide standard NodePredicates from Backlog to In candidates on the MITK (v2023.04) board.

This is also related to T29381: Move Multilabel classes to Core module.

Nov 30 2022, 9:49 AM · MITK (v2023.04), Request for Discussion
kalali added a comment to T29381: Move Multilabel classes to Core module.

consider rMITKa73e482c0387: moved labelset-related classes out from core

Nov 30 2022, 9:48 AM · MITK, Request for Discussion
kalali edited projects for T27090: Provide standard NodePredicates, added: MITK (v2023.04); removed MITK, Next Milestone, Restricted Project.
Nov 30 2022, 9:47 AM · MITK (v2023.04), Request for Discussion
kalali removed a project from T29090: [3D Segmentation] Threshold tool preview draws contours in green and not in the active label color. : Next Milestone.
Nov 30 2022, 9:46 AM · MITK (v2023.04), Request for Discussion, Checklist
kalali moved T27613: Improve reinit behavior from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:40 AM · Request for Discussion, MITK (v2023.04)
kalali edited projects for T27613: Improve reinit behavior, added: MITK (v2023.04), Request for Discussion; removed Next Milestone, MITK.
Nov 30 2022, 9:40 AM · Request for Discussion, MITK (v2023.04)
kalali moved T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:39 AM · MITK (v2023.04)
kalali edited projects for T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction, added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:39 AM · MITK (v2023.04)
kalali removed a project from T28108: [Release Checklists] Prepare release checklists: Next Milestone.
Nov 30 2022, 9:38 AM · MITK
kalali closed T28108: [Release Checklists] Prepare release checklists as Resolved.
Nov 30 2022, 9:37 AM · MITK
kalali removed a subtask for T28108: [Release Checklists] Prepare release checklists: Unknown Object (Maniphest Task).
Nov 30 2022, 9:37 AM · MITK
kalali removed a subtask for T28108: [Release Checklists] Prepare release checklists: Unknown Object (Maniphest Task).
Nov 30 2022, 9:37 AM · MITK
kalali removed a subtask for T28108: [Release Checklists] Prepare release checklists: T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification .
Nov 30 2022, 9:36 AM · MITK
kalali removed a parent task for T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification : T28108: [Release Checklists] Prepare release checklists.
Nov 30 2022, 9:36 AM · MITK (v2023.04)
kalali moved T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:36 AM · MITK (v2023.04)
kalali edited projects for T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification , added: MITK (v2023.04); removed MITK, Next Milestone.
Nov 30 2022, 9:36 AM · MITK (v2023.04)
kalali moved T29027: Move NodeSelectionWidgets to QtWidgets module from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:35 AM · MITK (v2023.04)
kalali edited projects for T29027: Move NodeSelectionWidgets to QtWidgets module, added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:35 AM · MITK (v2023.04)
kalali moved T29140: [Selection widget] Optional selection can not be removed if a fitting node is always found from Backlog to In candidates on the MITK (v2023.04) board.
Nov 30 2022, 9:34 AM · MITK (v2023.04), Request for Discussion
kalali edited projects for T29140: [Selection widget] Optional selection can not be removed if a fitting node is always found, added: MITK (v2023.04); removed Next Milestone, MITK.
Nov 30 2022, 9:34 AM · MITK (v2023.04), Request for Discussion