🤞

Let's see if the Nightly installers tomorrow morning are able to load Sarah's DICOM files. 🤞

Deleted branch bugfix/T26164-AlwaysUseDCMTKBuiltInDICOMDictionaries.

Pushed new branch bugfix/T26164-AlwaysUseDCMTKBuiltInDICOMDictionaries.

Everything you need to know about the DICOM dictionaries and how DCMTK is handling them is described here: https://github.com/InsightSoftwareConsortium/DCMTK/blob/master/dcmdata/docs/datadict.txt

Verified on macOS. I downloaded the dictionary and exported DCMDICTPATH. The MITK Workbench was able to load the DICOM files correctly afterwards. 🎉

Deleted branch bugfix/T27608-DocumentationRefurbish-DeveloperManual.

Deleted branch feature/T27247-ShowConsoleWindow.

Pushed new branch feature/T27247-ShowConsoleWindow.

Deleted branch bugfix/T27908-UpdateMultilabelSegmentationDoc.

Pushed new branch bugfix/T27908-UpdateMultilabelSegmentationDoc.

I updated the document and added content to explicitly test

• utilities / tools / operations on a 3D image
• combination of 3D images with dynamic segmentation / surface
• combination of 4D images with static segmentation / surface
• combination of dynamic and static segmentation

I'm all in for that. We already discussed that we will focus again on this task {T26754} and its subtasks. This also includes

Automatic GUI testing

and

move as much tests as possible to Unit-Tests

OK. But I tend/think more and more that we should strive for a unit test testbed that tests all that on the tool class level (either the respective base classes or the tools itself where it is easily possible (e.g. because the have no interaction (but even thous shouldn't be a show stopper).

The checklist don't say anything about multilabel segmentation. This should be addressed with a special focus on creating and combining multiple labels / layers.
I couldn't find any other checklist with a focus on the multilabel functionality.

I updated the document and added content to explicitly tests

Similar to T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung" I updated the document and added content to explicitly tests different image types / segmentation types.
Additionally I tried to make both checklists more consistent.

I looked again at the tests we have inside the checklist and I think it is still very long and many steps are redundant - because only the clicked tool-button changes and the underlying segmentation algorithm produces different results.
I think it is clearer and even better for testing a specific tool / algorithm, if we somehow separate the tests for different tools.
Also,

In T27507#211660, @thomass wrote:

If necessary, I might need a helping hand because static/dynamic*single/double*2DTools/3DTools = many test cases

I removed T27060: [Segmentation] Rework InterpolationWidget to not depend on data manager view directly as subtask and now this can be closed!

I'm was able to land the differential. I simply merged the branch, after I updated D255 with it. Everything seems fine but I'm not sure if old changes of the documentation have also been re-added. Please check (hint could be the removed "The" in front of the documentation page names).

Pushed new branch bugfix/T27744-ReviseModelFitDemo.

Pushed new branch bugfix/T27196-RewritePackaging.

I think the things you changed are all reasonable, the things I would add (I can not do it atm because I don't have access to the document)

I agree :)

We discussed the open todos concerning Checklists (storage, format, language) and decided that this topic should be prioritized higher but not for the milestone of the new release / current documentation refactoring.
I think this would be a good option for the phase after the release but if you have a strong point to do it now, please state here.

just started to have a look.

@thomass, @gaoh Can someone please proofread?

I updated the document and added content to explicitly test

• segmentation on a 3D image
• 3D segmentation (static) on a 4D image
• 4D segmentation (dynamic) on a 4D image

What exactly? I copied the checklists to my local machine and I'm working on T27716: Extend "Checkliste Segmentierung – Manuelle Segmentierung / 2D Segmentierung".

Damn I have forgotten to copy the checklist to a reachable share. @kalali Is it already done now or obsolete?

All tools have to check for the following usage scenario:

• All this with an image which time geometry does not start at 0 ms (e.g. MITK-Data/3D+t-ITKIO-TestData/LinearModel_4D_arbitrary_time_geometry.nrrd)