Pushed new branch release/T27486-2020-06-19.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Jun 22 2020
Jun 19 2020
I can confirm that autocrop in the DataManager context menu is broken and that it probably was never adapted to the LabelSetImage data type: when someone autocrops a segmentation (which is a LabelSetImage since years now even for "binary" segmentations created by the old segmention view), the cropped image should also be a cropped LabelSetImage containing all labels and layers. Other crop strategies like crop to a certain label is subject of the Multilabel Segmentation View context menu, but not of the general DataManager context menu.
Jun 18 2020
Placeholder for external project updates, minimum CMake version, and Qt version
I went through all Noteworthy tasks of the list above and summarized the ones were I was assigned (we should split it later into API changes and other noteworthy features):
Jun 17 2020
I think I found a nice solution. Depth peeling is set per renderer, not for the whole application. So it makes sense to activate it only for 3d renders. Side effect: probably speeds up rendering a little bit.
Blocked by the fact that e071-jenkins is not yet reachable from outside.
Jun 16 2020
Jun 15 2020
This is also already on the TODO list of the packaging rewrite.
It's depth peeling and it is not solved with VTK 9. I tried to narrow down the issue in a minimum VTK application but I wasn't able to reproduce it. As quite a significant amount of time already was spent here, I will probably reintroduce preferences to disable/enable depth peeling and declare this issue as a known issue.
Fixed a bug where images appeared brighter as they should as soon as the 3d renderer rendered its first image. Only thing missing now is ACVD I guess.
Jun 10 2020
Jun 5 2020
Jun 4 2020
Status: Workbench with WorkbenchRelease configuration excluding ACVD/Remeshing starts on Windows. Does not solve T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed. :/
Pushed new branch feature/T27461-VTK9.
Jun 3 2020
VTK 9 changed core components like vtkCellArray that require a thorough adaption of existing code (including external projects like ACVD).
Jun 2 2020
May 31 2020
Poor man's backup of the settings: 😄
Note that it's only on Linux as it is the only client where I activated tests. I will disable them for now again and we can decide on Wednesday how we want to proceed.
May 29 2020
Seems to work, but mitkPluginGeneratorBuildTest-Release fails.
http://e071-jenkins:8080/job/MITK/job/Differential/job/Linux/220/consoleFull
Activated tests on Linux Differential clients. Buildable is currently running. If it works as expected, I will also activate the tests for macOS and Windows.
{B605}
As it is not @maleike's patch, it must have been the upgrade from VTK 8.0 to 8.1 or the depth peeling reactivation in general. Checking with the latest version of VTK...
Oof, was able to boil it down to a VTK bug when depth peeling is enabled. Evaluating different options, like if it has something to do with @maleike's VTK patch, or if it is already fixed in a newer version...
Only segmentations are affected. There is no relevant change in the mapper code between the last release and now, though. I found out, that it has something to do with opacity. In particular when setting the opacity of the top segmentation to 1, it works, but masks the segmentation below with its own extent. When setting both opacities to 1, everything looks like it should.
Works in v2018.04.2. Parent image has layer 4, first segmentation 5, second 6, just as one would expect it to be. Drag & dropping the lower segmentation above the upper one, interchanges the layer.
During (and only during) drawing on any segmentation (after first mouse move), both segmentations are also visible.
Pushed new branch bugfix/T27436-HideInterpWidgetsInMultilabelSegView.
May 28 2020
May 27 2020
Sigh, CTK with Qt 5.12.6 fails with the same linker error (definitely worked in the past). I guess it is VS 2019 16.6.0 then.
Our current version of VTK does not work with Qt 5.15. I'm just going back to 5.12.6 for now, as I didn't plan to pump so much time into this issue.
Qt 5.15 is not working with qwt 6.1, though.
I wasn't able to build CTK with Qt 5.12.8 on Windows with Visual Studio 2019 16.6.0 and CMake 3.17.1 because of linker errors related to QLinkedList. I just tried the latest Qt 5.15 and at least CTK builds successfully. @neher told me some days ago that Qt 5.13 and/or 5.14 worked as well for him, so we should probably remove the hard check against Qt versions greater or equal to 5.13.
I agree that we should have debug clients but not as Continuous, as at least on Windows Clients Debug builds are not faster but at least quite some time slower because of very long execution of tests with lots of image pixel access. Nightly clients in debug mode should make sure not to execute package tests as long as we only support release mode installers.
May 26 2020
First auto-close bulk edit completed successfully. Hope it wasn't too much of an email notification tsunami. 🙈