Page MenuHomePhabricator
Feed Advanced Search

Jun 22 2020

kislinsk changed the visibility for T26942: Crash on DICOM loading.
Jun 22 2020, 1:38 PM · DICOM, Kaapana (internal), MITK
kislinsk closed T26721: Prepare Qt 5.13 compatibility as Resolved.
Jun 22 2020, 9:50 AM · MITK
kislinsk closed T25154: MITK ITK fix for future compilers as Resolved.
Jun 22 2020, 7:10 AM · MITK
kislinsk added a subtask for T27437: Migrate MITK to use ITK 5.x : T26413: Nifti2 support.
Jun 22 2020, 7:09 AM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk added a parent task for T26413: Nifti2 support: T27437: Migrate MITK to use ITK 5.x .
Jun 22 2020, 7:09 AM · Auto-closed, Missing Info, MITK
kislinsk merged T26456: Update ITK to v5 into T27437: Migrate MITK to use ITK 5.x .
Jun 22 2020, 7:09 AM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk merged task T26456: Update ITK to v5 into T27437: Migrate MITK to use ITK 5.x .
Jun 22 2020, 7:09 AM · MITK
kislinsk closed T26311: Beamforming GPU memory allocation unstable as Resolved.
Jun 22 2020, 7:06 AM · MITK, Photoacoustics
kislinsk added a parent task for T25798: Saving segmentations as .dcm (DICOM SEG) does not work: T25801: DICOM Seg writer doesn't support 4d DICOM images.
Jun 22 2020, 7:06 AM · MITK
kislinsk added a subtask for T25801: DICOM Seg writer doesn't support 4d DICOM images: T25798: Saving segmentations as .dcm (DICOM SEG) does not work.
Jun 22 2020, 7:06 AM · Auto-closed, MITK
kislinsk removed a parent task for T25801: DICOM Seg writer doesn't support 4d DICOM images: T25798: Saving segmentations as .dcm (DICOM SEG) does not work.
Jun 22 2020, 7:06 AM · Auto-closed, MITK
kislinsk removed a subtask for T25798: Saving segmentations as .dcm (DICOM SEG) does not work: T25801: DICOM Seg writer doesn't support 4d DICOM images.
Jun 22 2020, 7:06 AM · MITK
kislinsk closed T25798: Saving segmentations as .dcm (DICOM SEG) does not work as Resolved.
Jun 22 2020, 7:05 AM · MITK
kislinsk closed T25697: Optimization of MitkImageStatisticsCalculatorTest as Resolved.
Jun 22 2020, 7:01 AM · Restricted Project, MITK
kislinsk closed T25522: Fiducial based CT registration as Resolved.
Jun 22 2020, 7:00 AM · Restricted Project, MITK, IGT
kislinsk closed T24973: Add bias fields as Resolved.
Jun 22 2020, 6:59 AM · MITK Diffusion

Jun 19 2020

kislinsk added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

Pushed new branch release/T27486-2020-06-19.

Jun 19 2020, 5:05 PM · MITK (v2021.02)
kislinsk added a comment to T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images.

I can confirm that autocrop in the DataManager context menu is broken and that it probably was never adapted to the LabelSetImage data type: when someone autocrops a segmentation (which is a LabelSetImage since years now even for "binary" segmentations created by the old segmention view), the cropped image should also be a cropped LabelSetImage containing all labels and layers. Other crop strategies like crop to a certain label is subject of the Multilabel Segmentation View context menu, but not of the general DataManager context menu.

Jun 19 2020, 2:45 PM · Request for Discussion, Missing Info, MITK (v2021.02)

Jun 18 2020

kislinsk added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

Placeholder for external project updates, minimum CMake version, and Qt version

Jun 18 2020, 11:16 PM · MITK (v2021.02)
kislinsk added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

I went through all Noteworthy tasks of the list above and summarized the ones were I was assigned (we should split it later into API changes and other noteworthy features):

Jun 18 2020, 11:10 PM · MITK (v2021.02)
kislinsk updated the task description for T27486: Prepare changelog and migration guide for upcoming master merge.
Jun 18 2020, 11:07 PM · MITK (v2021.02)
kislinsk triaged T27486: Prepare changelog and migration guide for upcoming master merge as High priority.
Jun 18 2020, 11:07 PM · MITK (v2021.02)
kislinsk triaged T27377: Suppress or fix all build warnings as Normal priority.
Jun 18 2020, 11:04 PM · MITK (v2024.06), Restricted Project
kislinsk removed a project from T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed: Noteworthy.
Jun 18 2020, 11:03 PM · Cleared, MITK (v2021.02)

Jun 17 2020

kislinsk committed rMITK85c89861cb84: Enable depth peeling only for 3d renderers (authored by kislinsk).
Enable depth peeling only for 3d renderers
Jun 17 2020, 11:24 PM
kislinsk committed rMITK3ad9deb24f36: Disable depth peeling if renderer type changes to 2D (authored by kislinsk).
Disable depth peeling if renderer type changes to 2D
Jun 17 2020, 11:24 PM
kislinsk closed T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed as Resolved by committing rMITK85c89861cb84: Enable depth peeling only for 3d renderers.
Jun 17 2020, 11:24 PM · Cleared, MITK (v2021.02)
kislinsk committed rMITK44982e574823: Enable depth peeling only for 3d renderers (authored by kislinsk).
Enable depth peeling only for 3d renderers
Jun 17 2020, 11:24 PM
kislinsk added a revision to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed: Unknown Object (Differential Revision).
Jun 17 2020, 4:33 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed.

I think I found a nice solution. Depth peeling is set per renderer, not for the whole application. So it makes sense to activate it only for 3d renders. Side effect: probably speeds up rendering a little bit.

Jun 17 2020, 4:29 PM · Cleared, MITK (v2021.02)
kislinsk edited projects for T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion , added: Cleared; removed Missing Info.
Jun 17 2020, 10:38 AM · Cleared, MITK (v2021.02)
kislinsk updated the task description for T27462: Workbench crashes when loading multiple 3D+t datasets.
Jun 17 2020, 10:30 AM · MITK (v2021.02)
kislinsk added a comment to T27460: Badge support for our CDash/CI infrastructure.

Blocked by the fact that e071-jenkins is not yet reachable from outside.

Jun 17 2020, 9:42 AM · CI, MITK
kislinsk closed T27482: New Warnings/errors with Visual Studio 2019 version 16.6 as Resolved.
Jun 17 2020, 9:38 AM · MITK (v2021.02)
kislinsk committed rMITK517a7de4e260: Fix Visual Studio 2019 v16.6 compiler warnings/errors (authored by kislinsk).
Fix Visual Studio 2019 v16.6 compiler warnings/errors
Jun 17 2020, 9:37 AM
kislinsk committed rMITK5e75dcd741cf: Fix Visual Studio 2019 v16.6 compiler warnings/errors (authored by kislinsk).
Fix Visual Studio 2019 v16.6 compiler warnings/errors
Jun 17 2020, 9:37 AM

Jun 16 2020

kislinsk added a revision to T27482: New Warnings/errors with Visual Studio 2019 version 16.6: Unknown Object (Differential Revision).
Jun 16 2020, 4:59 PM · MITK (v2021.02)
kislinsk renamed T27482: New Warnings/errors with Visual Studio 2019 version 16.6 from PythonQt cannot be used without warnings in Visual Studio 2019 version 16.6 to New Warnings/errors with Visual Studio 2019 version 16.6.
Jun 16 2020, 4:38 PM · MITK (v2021.02)
kislinsk renamed T27482: New Warnings/errors with Visual Studio 2019 version 16.6 from PythonQt cannot be used without warnings with Visual Studio 2019 version 16.6 to PythonQt cannot be used without warnings in Visual Studio 2019 version 16.6.
Jun 16 2020, 4:22 PM · MITK (v2021.02)
kislinsk updated the task description for T27482: New Warnings/errors with Visual Studio 2019 version 16.6.
Jun 16 2020, 4:22 PM · MITK (v2021.02)
kislinsk triaged T27482: New Warnings/errors with Visual Studio 2019 version 16.6 as Normal priority.
Jun 16 2020, 4:17 PM · MITK (v2021.02)

Jun 15 2020

kislinsk closed T27425: Add more configurations to .arcconfig as Resolved.
Jun 15 2020, 5:11 PM · MITK
kislinsk added a comment to T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services.

This is also already on the TODO list of the packaging rewrite.

Jun 15 2020, 12:23 PM · Restricted Project, CSI-HD, MITK
kislinsk added a parent task for T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services: T27196: Rewrite packaging of MITK.
Jun 15 2020, 12:23 PM · Restricted Project, CSI-HD, MITK
kislinsk added a subtask for T27196: Rewrite packaging of MITK: T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services.
Jun 15 2020, 12:23 PM · MITK (v2024.06), Cleared
kislinsk added a comment to T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services.

@nolden https://github.com/NVIDIA/ai-assisted-annotation-client/issues/57

Jun 15 2020, 12:22 PM · Restricted Project, CSI-HD, MITK
kislinsk added a project to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed: Noteworthy.

It's depth peeling and it is not solved with VTK 9. I tried to narrow down the issue in a minimum VTK application but I wasn't able to reproduce it. As quite a significant amount of time already was spent here, I will probably reintroduce preferences to disable/enable depth peeling and declare this issue as a known issue.

Jun 15 2020, 10:26 AM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27461: Update MITK to use VTK 9.

Fixed a bug where images appeared brighter as they should as soon as the 3d renderer rendered its first image. Only thing missing now is ACVD I guess.

Jun 15 2020, 10:23 AM · Noteworthy, MITK (v2021.02)

Jun 10 2020

kislinsk changed the Default View Policy policy for application Diffusion from All Users to Custom Policy.
Jun 10 2020, 8:30 PM
kislinsk moved T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0 from Backlog to Segmentation on the MITK (v2021.02) board.
Jun 10 2020, 9:54 AM · MITK (v2021.02)

Jun 5 2020

kislinsk committed rMD84729632176a: Add VTK 9 compatible reference screenshot (authored by kislinsk).
Add VTK 9 compatible reference screenshot
Jun 5 2020, 11:09 AM

Jun 4 2020

kislinsk closed T27046: Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsistency) as Resolved.
Jun 4 2020, 7:26 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27461: Update MITK to use VTK 9.

Status: Workbench with WorkbenchRelease configuration excluding ACVD/Remeshing starts on Windows. Does not solve T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed. :/

Jun 4 2020, 7:25 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27461: Update MITK to use VTK 9.

Pushed new branch feature/T27461-VTK9.

Jun 4 2020, 7:03 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITK6a3ea89dafb4: Allow parallel use of segmentation and multilabel segmentation (authored by kislinsk).
Allow parallel use of segmentation and multilabel segmentation
Jun 4 2020, 3:42 PM
kislinsk committed rMITKc9a6e52b46a1: Allow parallel use of segmentation and multilabel segmentation (authored by kislinsk).
Allow parallel use of segmentation and multilabel segmentation
Jun 4 2020, 3:42 PM

Jun 3 2020

kislinsk claimed T27461: Update MITK to use VTK 9.

VTK 9 changed core components like vtkCellArray that require a thorough adaption of existing code (including external projects like ACVD).

Jun 3 2020, 6:24 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITKc7ee88da8242: Hide interpolation widgets (authored by kislinsk).
Hide interpolation widgets
Jun 3 2020, 11:51 AM
kislinsk committed rMITK4d62dc9820f4: Hide interpolation widgets (authored by kislinsk).
Hide interpolation widgets
Jun 3 2020, 11:51 AM
kislinsk closed T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported as Resolved.
Jun 3 2020, 10:20 AM · Restricted Project, Cleared, MITK (v2021.02)
kislinsk closed T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported, a subtask of T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View, as Resolved.
Jun 3 2020, 10:20 AM · MITK (v2023.04), Restricted Project

Jun 2 2020

kislinsk committed rMITK827181f9372d: Add more configuration values to .arcconfig for convenience (authored by kislinsk).
Add more configuration values to .arcconfig for convenience
Jun 2 2020, 2:44 PM
kislinsk committed rMITK988886adccae: Add more configuration values to .arcconfig for convenience (authored by kislinsk).
Add more configuration values to .arcconfig for convenience
Jun 2 2020, 2:44 PM

May 31 2020

kislinsk added a comment to T27458: Activate Test also for arc diff builds to avoid missed unit test errors.

Poor man's backup of the settings: 😄

May 31 2020, 9:01 PM · MITK (v2024.06), CI
kislinsk added a comment to T27458: Activate Test also for arc diff builds to avoid missed unit test errors.

Note that it's only on Linux as it is the only client where I activated tests. I will disable them for now again and we can decide on Wednesday how we want to proceed.

May 31 2020, 8:58 PM · MITK (v2024.06), CI

May 29 2020

kislinsk added a comment to T27458: Activate Test also for arc diff builds to avoid missed unit test errors.

Seems to work, but mitkPluginGeneratorBuildTest-Release fails.
http://e071-jenkins:8080/job/MITK/job/Differential/job/Linux/220/consoleFull

May 29 2020, 11:19 PM · MITK (v2024.06), CI
kislinsk claimed T27458: Activate Test also for arc diff builds to avoid missed unit test errors.

Activated tests on Linux Differential clients. Buildable is currently running. If it works as expected, I will also activate the tests for macOS and Windows.
{B605}

May 29 2020, 10:17 PM · MITK (v2024.06), CI
kislinsk added a comment to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed.

As it is not @maleike's patch, it must have been the upgrade from VTK 8.0 to 8.1 or the depth peeling reactivation in general. Checking with the latest version of VTK...

May 29 2020, 2:52 PM · Cleared, MITK (v2021.02)
kislinsk updated subscribers of T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed.

Oof, was able to boil it down to a VTK bug when depth peeling is enabled. Evaluating different options, like if it has something to do with @maleike's VTK patch, or if it is already fixed in a newer version...

May 29 2020, 2:24 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed.

Only segmentations are affected. There is no relevant change in the mapper code between the last release and now, though. I found out, that it has something to do with opacity. In particular when setting the opacity of the top segmentation to 1, it works, but masks the segmentation below with its own extent. When setting both opacities to 1, everything looks like it should.

May 29 2020, 12:51 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed.

Works in v2018.04.2. Parent image has layer 4, first segmentation 5, second 6, just as one would expect it to be. Drag & dropping the lower segmentation above the upper one, interchanges the layer.

May 29 2020, 10:51 AM · Cleared, MITK (v2021.02)
kislinsk added a comment to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed.

During (and only during) drawing on any segmentation (after first mouse move), both segmentations are also visible.

May 29 2020, 10:41 AM · Cleared, MITK (v2021.02)
kislinsk claimed T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed.
May 29 2020, 10:36 AM · Cleared, MITK (v2021.02)
kislinsk added a revision to T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported: Unknown Object (Differential Revision).
May 29 2020, 10:26 AM · Restricted Project, Cleared, MITK (v2021.02)
kislinsk added a comment to T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported.

Pushed new branch bugfix/T27436-HideInterpWidgetsInMultilabelSegView.

May 29 2020, 10:24 AM · Restricted Project, Cleared, MITK (v2021.02)
kislinsk claimed T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported.
May 29 2020, 10:23 AM · Restricted Project, Cleared, MITK (v2021.02)

May 28 2020

kislinsk added a revision to T27046: Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsistency): Unknown Object (Differential Revision).
May 28 2020, 5:22 PM · Cleared, MITK (v2021.02)
kislinsk claimed T27046: Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsistency).
May 28 2020, 2:42 PM · Cleared, MITK (v2021.02)
kislinsk added a project to T27455: Go through pull requests: Cleared.
May 28 2020, 2:32 PM · MITK (v2024.06), Cleared
kislinsk triaged T27455: Go through pull requests as Normal priority.
May 28 2020, 2:32 PM · MITK (v2024.06), Cleared
kislinsk placed T26721: Prepare Qt 5.13 compatibility up for grabs.
May 28 2020, 2:25 PM · MITK
kislinsk removed a member for MITK: tsvetkov.
May 28 2020, 10:23 AM

May 27 2020

kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

Sigh, CTK with Qt 5.12.6 fails with the same linker error (definitely worked in the past). I guess it is VS 2019 16.6.0 then.

May 27 2020, 11:59 PM · MITK
kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

Our current version of VTK does not work with Qt 5.15. I'm just going back to 5.12.6 for now, as I didn't plan to pump so much time into this issue.

May 27 2020, 11:42 PM · MITK
kislinsk added a comment to T26721: Prepare Qt 5.13 compatibility.

Qt 5.15 is not working with qwt 6.1, though.

May 27 2020, 10:46 PM · MITK
kislinsk claimed T26721: Prepare Qt 5.13 compatibility.

I wasn't able to build CTK with Qt 5.12.8 on Windows with Visual Studio 2019 16.6.0 and CMake 3.17.1 because of linker errors related to QLinkedList. I just tried the latest Qt 5.15 and at least CTK builds successfully. @neher told me some days ago that Qt 5.13 and/or 5.14 worked as well for him, so we should probably remove the hard check against Qt versions greater or equal to 5.13.

May 27 2020, 10:30 PM · MITK
kislinsk added a comment to T24265: MITK Extension mechanism: how to change settings in required third party projects..

FYI, there's also https://github.com/MITK/MITK-ProjectTemplate/blob/master/CMakeExternals/Customization/ITK.cmake.

May 27 2020, 1:45 PM · Auto-closed, MITK
kislinsk added a comment to T27443: Enable debug configurations for CI.

I agree that we should have debug clients but not as Continuous, as at least on Windows Clients Debug builds are not faster but at least quite some time slower because of very long execution of tests with lots of image pixel access. Nightly clients in debug mode should make sure not to execute package tests as long as we only support release mode installers.

May 27 2020, 1:37 PM · Auto-closed, CI, Restricted Project, MITK
kislinsk added a project to T27443: Enable debug configurations for CI: CI.
May 27 2020, 10:47 AM · Auto-closed, CI, Restricted Project, MITK
kislinsk edited the content of Development.
May 27 2020, 7:08 AM · MITK

May 26 2020

kislinsk edited the content of Development.
May 26 2020, 1:31 PM · MITK
kislinsk edited the content of Development.
May 26 2020, 1:25 PM · MITK
kislinsk created an object: Git Branching Model.
May 26 2020, 1:20 PM · MITK
kislinsk edited the content of Task Lifecycle Management.
May 26 2020, 12:38 PM · MITK
kislinsk edited the content of Task Lifecycle Management.
May 26 2020, 12:37 PM · MITK
kislinsk placed T24686: CESTCustomTagParser uses non-thread safe locale up for grabs.
May 26 2020, 12:09 PM · Auto-closed, Restricted Project, MITK
kislinsk placed T11900: ExtApp fails to load DICOM files if filename starts with a dot up for grabs.
May 26 2020, 12:09 PM · Auto-closed, Missing Info, MITK, Bugzilla
kislinsk placed T22072: Unittest for DICOMTagPath class is missing up for grabs.
May 26 2020, 12:08 PM · Auto-closed, Restricted Project, Restricted Project, MITK
kislinsk closed T27409: Specifiy and implement cleaning policies for MITK tasks as Resolved.

First auto-close bulk edit completed successfully. Hope it wasn't too much of an email notification tsunami. 🙈

May 26 2020, 11:25 AM · Cleared, Restricted Project, MITK (v2021.02)
kislinsk edited the content of Task Lifecycle Management.
May 26 2020, 11:22 AM · MITK