Wrong "auto close". Must be landed first.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Feb 10 2020
Pushed new branch T26903-DICOM_Seg_writing_broken_due_to_DICOMSEGIOMimeType.
@norajitr also opts for a fix as he encountered several ocasions where this bug was annoying.
The problem should be mitigated in the master as we do not use the ID but the descriptions of series and study. Further as soon as T27034: Refactor Segmentation plugin to use new selection concept and T27035: Refactor Multi Label Segmentation plugin to use new selection concept are merged into the master we also have new widget, that do not have that extension problem any more.
In D241#5497, @kalali wrote:I still get the error but it's currently hard to reproduce it. It happened when I changed the selection (listener mode) to a label set image when opening a context menu on the segmentation after the parent node was selected.
But, you are right. This is a case I haven't thought of. And it is really a problem. I do not see any possiblity to detect this situation properly.
Pushed new branch T26960-MapperTest.
- I would like to see the plugin generator loosing complexity by removing its project template capabilities
- The current approach is https://github.com/MITK/MITK-ProjectTemplate
- The project template is based on the last release, resp. releases/2018-04
- The project template is an MITK extension
- MITK extensions can be easily set in a recent version of our CDash script
- To test the project template, we need separate build clients based on the last release instead of master, no specific test has to be executed (see bullet point above)
- A few tests are currently not executed because I removed CTest subproject labels for testing purposes and I forgot to reintroduce them
- Instead of simply adding them again, I vote for a better label than "MITK" or "MITK-Plugins" like "MITK-Packaging"
In T27049#194090, @floca wrote:What planar figures are currently shown. After this task. All? All child figures? Only one?
Depending on that, the new task would have a different priority. The last option would be an obvious regression so the priority to fix it before a releas would become certaintly higher.
Pushed new branch T27049-Measurement-view-with-single-node-selection-widget.
Pushed new branch T24402-clang-format-improvements.
Pushed new branch T27084-fix-plugin-generator-tests.
Pushed new branch T27072-TrackDicom2.
Just tested this, works for me. If this is still an issue please re-open.
Pushed new branch T27082-RectifyImageApp.
It's an experimental app that already helped us to load some images that otherwise were flipped or oriented the wrong way. Probably does not work with oblique images. I'll move the app to the BasicImageProcessing module.
Gab's nicht in der Zwischenzeit noch das ein oder andere neue Wikigespräch mit nicht umgesetzten Beschlüssen? Weiß nicht was der Stand ist. Wie viele Wikis gibt's denn gerade?
Feb 7 2020
In T27049#194029, @kalali wrote:For the filtering / highlighting, list view on planar figures I will open task to keep things cleanly separated. Here we will only fix the selection widget.
In T27036#193983, @kalali wrote:What exactly is the logic here? I have the following case:
If autoselect is on and nothing is selected, the first node retrurned by the datastorage when calling GetNodes() with the predicate will be chosen.
So the history of selections is irrelevant. It only depends on the storage and how it returns the request. So it might be "arbitrary" at first glance. But it is the same way the storage combobox worked.
Yup. And it is remarked as a regression in the review. I wrote this task while reviewing, before I chacked the baseline. Sorry for that.
Even if the regression test is fixed. I think a nullptr check and a reasonable error reaction or throw, wouldn't hurt ;)
Peter, Du warst der letzte Aktive ;)
This was resolved by T25983
All spectral data (reference: https://omlc.org/spectra/hemoglobin/) can be found on E130-Projekte/Photoacoustics/AbsorptionSpectra
Ok, so I updated the diff to include the suggestions (which includes your point 1 here).
For the filtering / highlighting, list view on planar figures I will open task to keep things cleanly separated. Here we will only fix the selection widget.
Pushed new branch T27076-ChangeDesignerBuildFlagToDefault.
What exactly is the logic here? I have the following case:
- single node selection widget with auto mode and
- two images (e.g. Pic3D and US4D
- I select US4D in the data manager, image is selected in the selection widget
- I select Pic3D in the data manager, image is selected in the selection widget
- I deselect everything, US4D is automatically selected -> why not Pic3D (the last valid selection)?
Pushed new branch T27073-StartCrash.
Pushed new branch T27072-TrackDicom.
Pushed new branch T27071-Subproject.