Page MenuHomePhabricator
Feed All Stories

Feb 10 2020

floca removed a project from T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType: Request for Discussion.
Feb 10 2020, 10:29 PM · MITK
floca reopened T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType as "Open".

Wrong "auto close". Must be landed first.

Feb 10 2020, 10:28 PM · MITK
floca committed rMITKbb86cca52356: removed obsolete comments (authored by floca).
removed obsolete comments
Feb 10 2020, 10:26 PM
floca committed rMITK07dd0a9ed38e: Fixed T26903 in order to allow storing of DICOM seg again. (authored by floca).
Fixed T26903 in order to allow storing of DICOM seg again.
Feb 10 2020, 10:26 PM
floca closed T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType as Resolved by committing rMITK07dd0a9ed38e: Fixed T26903 in order to allow storing of DICOM seg again..
Feb 10 2020, 10:26 PM · MITK
floca added a comment to T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType.

Pushed new branch T26903-DICOM_Seg_writing_broken_due_to_DICOMSEGIOMimeType.

Feb 10 2020, 10:26 PM · MITK
floca claimed T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType.
Feb 10 2020, 10:22 PM · MITK
floca added a revision to T26903: DICOM Seg writing is broken due to changes in DICOMSEGIOMimeType: Unknown Object (Differential Revision).
Feb 10 2020, 10:22 PM · MITK
floca created T27087: Remove Autoload-Modul-Workarround in the FixMacOS script.
Feb 10 2020, 10:01 PM · MITK
floca updated subscribers of T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary".

@norajitr also opts for a fix as he encountered several ocasions where this bug was annoying.

Feb 10 2020, 9:03 PM · MITK (v2024.06), Checklist, Request for Discussion
floca closed T27086: Long file names force segmentation plugin to expand in order to be usable. as Resolved.

The problem should be mitigated in the master as we do not use the ID but the descriptions of series and study. Further as soon as T27034: Refactor Segmentation plugin to use new selection concept and T27035: Refactor Multi Label Segmentation plugin to use new selection concept are merged into the master we also have new widget, that do not have that extension problem any more.

Feb 10 2020, 9:01 PM · MITK (v2021.02)
norajitr triaged T27086: Long file names force segmentation plugin to expand in order to be usable. as High priority.
Feb 10 2020, 6:12 PM · MITK (v2021.02)
norajitr triaged T27085: 2D region growing tool fails for low intensity regions as High priority.
Feb 10 2020, 4:53 PM · Cleared, MITK (v2021.02)
floca updated subscribers of T27083: Workarround for the OpenGL context menu crash.
In D241#5497, @kalali wrote:

I still get the error but it's currently hard to reproduce it. It happened when I changed the selection (listener mode) to a label set image when opening a context menu on the segmentation after the parent node was selected.

But, you are right. This is a case I haven't thought of. And it is really a problem. I do not see any possiblity to detect this situation properly.

Feb 10 2020, 4:35 PM · Request for Discussion, MITK
neher committed rMITKDIFF8f3444422f1c: Merge branch 'T26960-MapperTest' (authored by neher).
Merge branch 'T26960-MapperTest'
Feb 10 2020, 3:56 PM
neher committed rMITKDIFFec2bb6749481: Enable rendering tests on ubuntu (authored by neher).
Enable rendering tests on ubuntu
Feb 10 2020, 3:55 PM
neher added a comment to T26960: Fiber mapper test fails.

Pushed new branch T26960-MapperTest.

Feb 10 2020, 3:55 PM · MITK Diffusion
kislinsk added a comment to T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism.
  • I would like to see the plugin generator loosing complexity by removing its project template capabilities
  • The current approach is https://github.com/MITK/MITK-ProjectTemplate
  • The project template is based on the last release, resp. releases/2018-04
  • The project template is an MITK extension
  • MITK extensions can be easily set in a recent version of our CDash script
  • To test the project template, we need separate build clients based on the last release instead of master, no specific test has to be executed (see bullet point above)
  • A few tests are currently not executed because I removed CTest subproject labels for testing purposes and I forgot to reintroduce them
  • Instead of simply adding them again, I vote for a better label than "MITK" or "MITK-Plugins" like "MITK-Packaging"
Feb 10 2020, 1:15 PM · Request for Discussion, MITK
kalali added a comment to T27049: Refactor Measurement plugin to use the new node selection widgets.

What planar figures are currently shown. After this task. All? All child figures? Only one?
Depending on that, the new task would have a different priority. The last option would be an obvious regression so the priority to fix it before a releas would become certaintly higher.

Feb 10 2020, 12:28 PM · MITK
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Feb 10 2020, 12:21 PM · MITK, Restricted Project, Cleared
kalali closed T27049: Refactor Measurement plugin to use the new node selection widgets, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Feb 10 2020, 12:20 PM · MITK, Restricted Project, Cleared
kalali closed T27049: Refactor Measurement plugin to use the new node selection widgets as Resolved.
Feb 10 2020, 12:20 PM · MITK
kalali committed rMITKb818ca572609: Merge branch 'T27049-Measurement-view-with-single-node-selection-widget' (authored by kalali).
Merge branch 'T27049-Measurement-view-with-single-node-selection-widget'
Feb 10 2020, 12:20 PM
kalali committed rMITK218faa8d9a39: Disconnect selection service from the selection widget (authored by kalali).
Disconnect selection service from the selection widget
Feb 10 2020, 12:00 PM
kalali committed rMITKc7befa8af7f0: Use node predicate to only allow images for the selection widget (authored by kalali).
Use node predicate to only allow images for the selection widget
Feb 10 2020, 12:00 PM
kalali committed rMITK35ec40bc8042: Change selection widget strings (authored by kalali).
Change selection widget strings
Feb 10 2020, 11:59 AM
kalali committed rMITK9165f83688a2: Only enable measurement actions if an image node is selected (authored by kalali).
Only enable measurement actions if an image node is selected
Feb 10 2020, 11:59 AM
kalali committed rMITKf54787724cf0: Modernize functions (authored by kalali).
Modernize functions
Feb 10 2020, 11:59 AM
kalali committed rMITKc9287f9bcd43: Add single node selection widget (authored by kalali).
Add single node selection widget
Feb 10 2020, 11:59 AM
kalali committed rMITKd0e24fd4c2c6: Clean class (authored by kalali).
Clean class
Feb 10 2020, 11:59 AM
kalali committed rMITK41e89c6f59cb: Remove functions to automatically retrieve / select a data node (authored by kalali).
Remove functions to automatically retrieve / select a data node
Feb 10 2020, 11:59 AM
kalali added a comment to T27049: Refactor Measurement plugin to use the new node selection widgets.

Pushed new branch T27049-Measurement-view-with-single-node-selection-widget.

Feb 10 2020, 11:59 AM · MITK
nolden committed rMITKc55b6aae65cd: Don't reorder includes during clang-format (authored by nolden).
Don't reorder includes during clang-format
Feb 10 2020, 11:55 AM
nolden committed rMITK28a1559a42c5: Don't format anything in the PluginGenerator and templates (authored by nolden).
Don't format anything in the PluginGenerator and templates
Feb 10 2020, 11:55 AM
nolden committed rMITKea713e14c00a: Change inner namespace indentation (authored by nolden).
Change inner namespace indentation
Feb 10 2020, 11:55 AM
nolden committed rMITK2739cf55c171: Fix missing include for MitkIpPicDescriptor (authored by nolden).
Fix missing include for MitkIpPicDescriptor
Feb 10 2020, 11:54 AM
nolden added a comment to T24402: Improve clang-format support.

Pushed new branch T24402-clang-format-improvements.

Feb 10 2020, 11:54 AM · MITK
nolden committed rMITKa41a8d973980: Fix PluginGenerator tests (authored by nolden).
Fix PluginGenerator tests
Feb 10 2020, 11:53 AM
nolden added a comment to T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism.

Pushed new branch T27084-fix-plugin-generator-tests.

Feb 10 2020, 11:52 AM · Request for Discussion, MITK
neher committed rMITKDIFF4a9b87ceb7a9: Merge branch 'T27072-TrackDicom2' (authored by neher).
Merge branch 'T27072-TrackDicom2'
Feb 10 2020, 11:52 AM
neher committed rMITKDIFFbc9a21a92ec6: Adapt readme (authored by neher).
Adapt readme
Feb 10 2020, 11:52 AM
neher committed rMITKDIFFc5df42004018: Merge branch 'T27072-TrackDicom2' (authored by neher).
Merge branch 'T27072-TrackDicom2'
Feb 10 2020, 11:48 AM
neher committed rMITKDIFF399b74f1feb5: Default value fix (authored by neher).
Default value fix
Feb 10 2020, 11:47 AM
nolden updated subscribers of T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism.
Feb 10 2020, 11:40 AM · Request for Discussion, MITK
nolden triaged T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism as Normal priority.
Feb 10 2020, 11:40 AM · Request for Discussion, MITK
neher closed T27073: Startup crash as Resolved.
Feb 10 2020, 11:39 AM · MITK Diffusion
neher closed T27072: Fix tractography dicom reader/writer as Resolved.
Feb 10 2020, 11:39 AM · MITK Diffusion
neher committed rMITKDIFF3d21637c7498: Merge branch 'T27072-TrackDicom2' (authored by neher).
Merge branch 'T27072-TrackDicom2'
Feb 10 2020, 11:37 AM
neher committed rMITKDIFF4a9820758899: Fix reader/writer and store dicom tags in data derived from the original DICOM (authored by neher).
Fix reader/writer and store dicom tags in data derived from the original DICOM
Feb 10 2020, 11:34 AM
neher added a comment to T27072: Fix tractography dicom reader/writer.

Pushed new branch T27072-TrackDicom2.

Feb 10 2020, 11:34 AM · MITK Diffusion
nolden closed T23040: PluginGenerator doesn't work as Resolved.

Just tested this, works for me. If this is still an issue please re-open.

Feb 10 2020, 11:26 AM · MITK
kislinsk closed T27082: Merge RectifyImage app as Resolved.
Feb 10 2020, 10:57 AM · MITK
kislinsk committed rMITKe953353b75e1: Merge branch 'T27082-RectifyImageApp' (authored by kislinsk).
Merge branch 'T27082-RectifyImageApp'
Feb 10 2020, 10:57 AM
kislinsk committed rMITK52b13dde4b88: Move RectifyImage app to BasicImageProcessing (authored by kislinsk).
Move RectifyImage app to BasicImageProcessing
Feb 10 2020, 10:57 AM
kislinsk committed rMITKbedf7d7a68a3: Merge remote-tracking branch 'origin/personal/kislinsk/RectifyImage' into… (authored by kislinsk).
Merge remote-tracking branch 'origin/personal/kislinsk/RectifyImage' into…
Feb 10 2020, 10:57 AM
kislinsk added a comment to T27082: Merge RectifyImage app.

Pushed new branch T27082-RectifyImageApp.

Feb 10 2020, 10:57 AM · MITK
kislinsk added a comment to T27082: Merge RectifyImage app.

It's an experimental app that already helped us to load some images that otherwise were flipped or oriented the wrong way. Probably does not work with oblique images. I'll move the app to the BasicImageProcessing module.

Feb 10 2020, 9:46 AM · MITK
floca added a revision to T27083: Workarround for the OpenGL context menu crash: Unknown Object (Differential Revision).
Feb 10 2020, 9:15 AM · Request for Discussion, MITK
neher added a comment to T23163: MBI Wiki inventory.

Gab's nicht in der Zwischenzeit noch das ein oder andere neue Wikigespräch mit nicht umgesetzten Beschlüssen? Weiß nicht was der Stand ist. Wie viele Wikis gibt's denn gerade?

Feb 10 2020, 9:09 AM · Restricted Project
floca claimed T27083: Workarround for the OpenGL context menu crash.
Feb 10 2020, 9:06 AM · Request for Discussion, MITK
floca added a subtask for T23751: Introduction of new selection concept: T27083: Workarround for the OpenGL context menu crash.
Feb 10 2020, 9:05 AM · Noteworthy, MITK
floca added a parent task for T27083: Workarround for the OpenGL context menu crash: T23751: Introduction of new selection concept.
Feb 10 2020, 9:05 AM · Request for Discussion, MITK
floca triaged T27083: Workarround for the OpenGL context menu crash as Unbreak Now! priority.
Feb 10 2020, 9:05 AM · Request for Discussion, MITK
kislinsk triaged T27082: Merge RectifyImage app as Wishlist priority.
Feb 10 2020, 7:27 AM · MITK
kislinsk closed T22289: Optionally allow to clone as many external dependencies as possible instead of downloading their tarballs as Wontfix.
Feb 10 2020, 6:48 AM · MITK
kislinsk closed T24080: Write visual debugging utilitiy for inspecting geometries as Wontfix.
Feb 10 2020, 6:42 AM · MITK
kislinsk closed T24080: Write visual debugging utilitiy for inspecting geometries, a subtask of T24071: Revisit 2-d image rendering, as Wontfix.
Feb 10 2020, 6:42 AM · Auto-closed, MITK

Feb 7 2020

floca added a comment to T27049: Refactor Measurement plugin to use the new node selection widgets.

For the filtering / highlighting, list view on planar figures I will open task to keep things cleanly separated. Here we will only fix the selection widget.

Feb 7 2020, 10:23 PM · MITK
floca added a comment to T27036: Add AutoSelectNewNodes mode to SingleNodeSelectionWidget.

What exactly is the logic here? I have the following case:

If autoselect is on and nothing is selected, the first node retrurned by the datastorage when calling GetNodes() with the predicate will be chosen.
So the history of selections is irrelevant. It only depends on the storage and how it returns the request. So it might be "arbitrary" at first glance. But it is the same way the storage combobox worked.

Feb 7 2020, 10:06 PM · MITK
floca added a comment to T27061: Planar figures crash if drawn with empty data storage.

Yup. And it is remarked as a regression in the review. I wrote this task while reviewing, before I chacked the baseline. Sorry for that.
Even if the regression test is fixed. I think a nullptr check and a reasonable error reaction or throw, wouldn't hurt ;)

Feb 7 2020, 9:41 PM · Restricted Project, MITK
nolden reassigned T23163: MBI Wiki inventory from nolden to neher.

Peter, Du warst der letzte Aktive ;)

Feb 7 2020, 5:35 PM · Restricted Project
nolden committed rMITKb1587c557765: Fix DICOM SEG read error by updating DCMQI (authored by nolden).
Fix DICOM SEG read error by updating DCMQI
Feb 7 2020, 5:30 PM
nolden closed T25745: Integrate new DICOM browser widget from CTK as Resolved.

This was resolved by T25983

Feb 7 2020, 5:10 PM · MITK
nolden committed rMITKba4a121c0bbc: Use a more recent version of ITK for GCC 9 compatibility (authored by nolden).
Use a more recent version of ITK for GCC 9 compatibility
Feb 7 2020, 5:06 PM
schellem added a comment to T27080: AbsorptionSpectra.

All spectral data (reference: https://omlc.org/spectra/hemoglobin/) can be found on E130-Projekte/Photoacoustics/AbsorptionSpectra

Feb 7 2020, 4:20 PM · Photoacoustics, IMSY
schellem triaged T27080: AbsorptionSpectra as Normal priority.
Feb 7 2020, 4:14 PM · Photoacoustics, IMSY
kalali triaged T27079: Measurement plugin should show referenced planar figures as Wishlist priority.
Feb 7 2020, 3:11 PM · Auto-closed, MITK
kislinsk lowered the priority of T27077: Planar figure reader not available anymore before opening a Quantification view from High to Normal.
Feb 7 2020, 2:59 PM · MITK
kalali added a comment to T27049: Refactor Measurement plugin to use the new node selection widgets.

Ok, so I updated the diff to include the suggestions (which includes your point 1 here).
For the filtering / highlighting, list view on planar figures I will open task to keep things cleanly separated. Here we will only fix the selection widget.

Feb 7 2020, 2:50 PM · MITK
kislinsk triaged T27078: Workbench crashes if statistics are computed with a double ellipse with equal diameter as High priority.
Feb 7 2020, 2:46 PM · MITK
kislinsk triaged T27077: Planar figure reader not available anymore before opening a Quantification view as High priority.
Feb 7 2020, 2:41 PM · MITK
thomass committed rMITKcddd8da72039: Enable build of QT designer plugin by default (authored by thomass).
Enable build of QT designer plugin by default
Feb 7 2020, 2:33 PM
thomass added a comment to T27076: [CTK] QT designer plugins are not built anymore and cause problems in command line module.

Pushed new branch T27076-ChangeDesignerBuildFlagToDefault.

Feb 7 2020, 2:33 PM · MITK
thomass triaged T27076: [CTK] QT designer plugins are not built anymore and cause problems in command line module as Normal priority.
Feb 7 2020, 2:22 PM · MITK
kalali added a comment to T27036: Add AutoSelectNewNodes mode to SingleNodeSelectionWidget.

What exactly is the logic here? I have the following case:

  • single node selection widget with auto mode and
  • two images (e.g. Pic3D and US4D
  • I select US4D in the data manager, image is selected in the selection widget
  • I select Pic3D in the data manager, image is selected in the selection widget
  • I deselect everything, US4D is automatically selected -> why not Pic3D (the last valid selection)?
Feb 7 2020, 12:05 PM · MITK
neher committed rMITKDIFFd84a75508cad: Merge branch 'T27073-StartCrash' (authored by neher).
Merge branch 'T27073-StartCrash'
Feb 7 2020, 11:53 AM
neher committed rMITKDIFFba8be24fd34c: Same fix as for workbench (authored by neher).
Same fix as for workbench
Feb 7 2020, 11:52 AM
neher added a comment to T27073: Startup crash.

Pushed new branch T27073-StartCrash.

Feb 7 2020, 11:52 AM · MITK Diffusion
neher triaged T27073: Startup crash as Normal priority.
Feb 7 2020, 11:51 AM · MITK Diffusion
neher committed rMITKDIFFf91909f4f0ad: Merge branch 'T27072-TrackDicom' (authored by neher).
Merge branch 'T27072-TrackDicom'
Feb 7 2020, 11:26 AM
neher committed rMITKDIFF6e5a39cb9516: Use AlgorithmIdentificationMacro instead of CodeSequenceMacro (authored by neher).
Use AlgorithmIdentificationMacro instead of CodeSequenceMacro
Feb 7 2020, 11:25 AM
neher added a comment to T27072: Fix tractography dicom reader/writer.

Pushed new branch T27072-TrackDicom.

Feb 7 2020, 11:25 AM · MITK Diffusion
neher triaged T27072: Fix tractography dicom reader/writer as Normal priority.
Feb 7 2020, 11:18 AM · MITK Diffusion
neher closed T27071: Add subproject list as Resolved.
Feb 7 2020, 11:18 AM · MITK Diffusion
neher closed T27038: Allow CTest subprojects definition in MITK extensions as Resolved.
Feb 7 2020, 10:30 AM · Noteworthy, MITK
neher committed rMITKDIFF71f265a2b708: Merge branch 'T27071-Subproject' (authored by neher).
Merge branch 'T27071-Subproject'
Feb 7 2020, 10:25 AM
neher committed rMITKDIFF4174d1732302: Added list. Update readme. (authored by neher).
Added list. Update readme.
Feb 7 2020, 10:24 AM
neher added a comment to T27071: Add subproject list.

Pushed new branch T27071-Subproject.

Feb 7 2020, 10:24 AM · MITK Diffusion
neher committed rMITKbdceb643100c: Correct path (authored by neher).
Correct path
Feb 7 2020, 10:23 AM
neher committed rMITKe25b5025fd42: Use loop variable (authored by neher).
Use loop variable
Feb 7 2020, 10:16 AM