Page MenuHomePhabricator
Feed All Stories

Feb 7 2020

kislinsk accepted rMITKf72f4d871b1e: Correct path.

Oops, meant to comment on the Differential, not on this commit. See D240 instead.

Feb 7 2020, 10:05 AM
kislinsk awarded T27038: Allow CTest subprojects definition in MITK extensions a Hungry Hippo token.
Feb 7 2020, 10:02 AM · Noteworthy, MITK
kislinsk raised a concern with rMITKf72f4d871b1e: Correct path.
Feb 7 2020, 10:01 AM
neher triaged T27071: Add subproject list as High priority.
Feb 7 2020, 9:51 AM · MITK Diffusion
neher triaged T27070: Planar figure to image fails as Normal priority.
Feb 7 2020, 9:35 AM · MITK Diffusion
kalali added a comment to T27061: Planar figures crash if drawn with empty data storage.

I guess @floca mentioned this because it was introduced by refactoring the Measurement plugin. Still working on this.

Feb 7 2020, 9:33 AM · Restricted Project, MITK
neher added a revision to T27038: Allow CTest subprojects definition in MITK extensions: Unknown Object (Differential Revision).
Feb 7 2020, 9:22 AM · Noteworthy, MITK
neher committed rMITKf72f4d871b1e: Correct path (authored by neher).
Correct path
Feb 7 2020, 9:20 AM
neher added a comment to T27038: Allow CTest subprojects definition in MITK extensions.

Pushed new branch T27038-ExtensionProjects.

Feb 7 2020, 9:20 AM · Noteworthy, MITK
neher reopened T27038: Allow CTest subprojects definition in MITK extensions as "Open".
Feb 7 2020, 9:18 AM · Noteworthy, MITK
kislinsk added a comment to T27061: Planar figures crash if drawn with empty data storage.

Here's a screenshot from the last release. All the tools are deactivated as long as there isn't any visible object.

Feb 7 2020, 9:05 AM · Restricted Project, MITK
kislinsk triaged T27061: Planar figures crash if drawn with empty data storage as Normal priority.

While there should be a nullptr check I guess, this is another regression in the first place as it wasn't possible with the Measurement view to draw with an empty storage until recently. Is this possibly related to your work on selections?

Feb 7 2020, 9:03 AM · Restricted Project, MITK
kislinsk triaged T27050: Crash with planar figures and stastics/measurement as High priority.
Feb 7 2020, 8:52 AM · Restricted Project, MITK
kislinsk triaged T27003: Extend representation object handling in NavigationDataObjectVisualizationFilter as Wishlist priority.
Feb 7 2020, 8:44 AM · IGT, MITK, Restricted Project

Feb 6 2020

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

We are currently looking into it. In this process we realized that we are not able to reproduce the proplems with the current master.

Feb 6 2020, 9:25 PM · MITK
kleina committed rOBSHYPPOPY230451b1ac37: Add mpi support for RandomsearchSolver (authored by kleina).
Add mpi support for RandomsearchSolver
Feb 6 2020, 5:00 PM
kleina committed rOBSHYPPOPY828762fd0573: added mpi_comm to documentation (2) (authored by kleina).
added mpi_comm to documentation (2)
Feb 6 2020, 5:00 PM
kleina committed rOBSHYPPOPY31e9f9b0e858: added mpi_comm to documentation (authored by kleina).
added mpi_comm to documentation
Feb 6 2020, 5:00 PM
floca triaged T27069: OpenGL error / crash when opening context menu as High priority.
Feb 6 2020, 4:21 PM · MITK
kalali added a revision to T27056: Refactor ImageCropper plugin to use the new node selection widgets: Unknown Object (Differential Revision).
Feb 6 2020, 4:03 PM · MITK
kalali triaged T27067: ImageCropper cannot crop some images (4d?) as Normal priority.
Feb 6 2020, 4:01 PM · MITK

Feb 5 2020

floca triaged T27064: NodeSelectionWidgets have to listen to changes of nodes and check if there selection is still valid. as Normal priority.
Feb 5 2020, 7:00 PM · MITK
floca added a parent task for T27061: Planar figures crash if drawn with empty data storage: T27049: Refactor Measurement plugin to use the new node selection widgets.
Feb 5 2020, 5:49 PM · Restricted Project, MITK
floca added a subtask for T27049: Refactor Measurement plugin to use the new node selection widgets: T27061: Planar figures crash if drawn with empty data storage.
Feb 5 2020, 5:49 PM · MITK
floca added a comment to T27049: Refactor Measurement plugin to use the new node selection widgets.

I would handle it that way (and close to your assumption):

Feb 5 2020, 5:47 PM · MITK
floca created T27061: Planar figures crash if drawn with empty data storage.
Feb 5 2020, 5:26 PM · Restricted Project, MITK
floca triaged T27060: [Segmentation] Rework InterpolationWidget to not depend on data manager view directly as Normal priority.
Feb 5 2020, 5:00 PM · MITK (v2024.06)
kahl committed rMITK360ad74ae787: first version of segmentation plugin using C/Python API (authored by kahl).
first version of segmentation plugin using C/Python API
Feb 5 2020, 9:19 AM

Feb 4 2020

nolden added a comment to T24402: Improve clang-format support.

For the transition process, these bits from the git merge manpage could be useful as well:

Feb 4 2020, 4:28 PM · MITK
kalali triaged T27056: Refactor ImageCropper plugin to use the new node selection widgets as Normal priority.
Feb 4 2020, 3:29 PM · MITK
nolden added a comment to T24402: Improve clang-format support.

I just picked this up in a small experiment:

Feb 4 2020, 3:12 PM · MITK
floca committed rMP647a51975144: Added Rigid3D algorithm with bounding box (authored by floca).
Added Rigid3D algorithm with bounding box
Feb 4 2020, 2:47 PM
floca committed rMPab8768ec3f10: Added support of bool parameter in matchR (authored by floca).
Added support of bool parameter in matchR
Feb 4 2020, 2:47 PM
floca committed rMP7f2c484c4b30: Added support of 2nd stage parameter file for… (authored by floca).
Added support of 2nd stage parameter file for…
Feb 4 2020, 2:47 PM
kalali committed rMITKb615c3a394ff: Remove unused parameter (authored by kalali).
Remove unused parameter
Feb 4 2020, 1:07 PM
kalali added a revision to T27049: Refactor Measurement plugin to use the new node selection widgets: Unknown Object (Differential Revision).
Feb 4 2020, 1:00 PM · MITK

Feb 3 2020

kislinsk added a comment to T27022: CTest returns error code if subproject does not have tests.

Merged! 🎉 Will be available in CMake 3.17.

Feb 3 2020, 9:14 PM · Restricted Project, Restricted Project, CI, MITK
floca added a comment to T27050: Crash with planar figures and stastics/measurement.

Asked for more details and information.

Feb 3 2020, 8:43 PM · Restricted Project, MITK
floca created T27050: Crash with planar figures and stastics/measurement.
Feb 3 2020, 8:42 PM · Restricted Project, MITK
kalali added a comment to T27049: Refactor Measurement plugin to use the new node selection widgets.

The QmitkMeasurementView is able to show multiple selections of PlanarFigures (lines, polygons) along with their geometric information. Currently our selection widgets do not support a nice way to group geometric information with selected nodes.

Feb 3 2020, 6:37 PM · MITK
kalali triaged T27049: Refactor Measurement plugin to use the new node selection widgets as Normal priority.
Feb 3 2020, 6:09 PM · MITK
floca added a project to T26451: DICOM plugin cannot parse DICOM directories in macOS installer: Request for Discussion.
Feb 3 2020, 5:49 PM · MITK
floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

I can confirm the access. Will look into it this week.

Feb 3 2020, 5:41 PM · MITK
kalali updated the task description for T26741: Finishing new node selection concept.
Feb 3 2020, 5:29 PM · Restricted Project
kalali updated the task description for T26741: Finishing new node selection concept.
Feb 3 2020, 5:29 PM · Restricted Project
kalali updated the task description for T24775: Refactor plugins to use the new node selection widgets.
Feb 3 2020, 5:28 PM · MITK, Restricted Project, Cleared
jsolislemus added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Hi, just to let you know I uploaded the data to the ftp with the instructions sent. I sent the full information about the location of the file to Ralf. Could you please confirm you are able to access it? Many thanks.

Feb 3 2020, 2:13 PM · MITK
neher updated subscribers of T25067: Python crashes on destruction of ctkAbstractPythonManager.

Not to my knowledge.

Feb 3 2020, 12:35 PM · Auto-closed, MITK
kompan triaged T27047: Perfusion- Conversion from signal to concentration: Rename Using T1-map as Normal priority.
Feb 3 2020, 10:01 AM · Cleared, MITK (v2021.02)

Feb 2 2020

nolden closed T25983: Update DICOM related toolkits as Resolved.

Nightly CI looks good as well.

Feb 2 2020, 9:08 AM · MITK, DICOM

Feb 1 2020

kislinsk renamed T27024: Fix PhotoacousticsLib mitkSpectralUnmixingTest and mitkPhotoacousticVolumeTest from Fix PhotoacousticsLib mitkSpectralUnmixingTest to Fix PhotoacousticsLib mitkSpectralUnmixingTest and mitkPhotoacousticVolumeTest.
Feb 1 2020, 3:08 PM · MITK
kislinsk committed rMITK88ba8587edc7: Merge branch 'T27024-FixVolumeTest' (authored by kislinsk).
Merge branch 'T27024-FixVolumeTest'
Feb 1 2020, 3:06 PM
kislinsk committed rMITK5c734ceabe81: Disable randomly failing test (authored by kislinsk).
Disable randomly failing test
Feb 1 2020, 3:06 PM
kislinsk added a comment to T27024: Fix PhotoacousticsLib mitkSpectralUnmixingTest and mitkPhotoacousticVolumeTest.

Pushed new branch T27024-FixVolumeTest.

Feb 1 2020, 3:05 PM · MITK
nolden committed rMITKd530fc949cb2: Updated CTK and DICOM related toolkits (authored by nolden).
Updated CTK and DICOM related toolkits
Feb 1 2020, 10:52 AM
nolden committed rMITK24d31e394802: Updated CTK and DICOM related toolkits (authored by nolden).
Updated CTK and DICOM related toolkits
Feb 1 2020, 10:52 AM
nolden committed rMITKeedccf5124d6: Fixed CTK URL (authored by nolden).
Fixed CTK URL
Feb 1 2020, 10:52 AM

Jan 31 2020

floca triaged T27046: Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsistency) as High priority.
Jan 31 2020, 8:13 PM · Cleared, MITK (v2021.02)
floca committed rMITK3066f137d98e: First draft of the refactoring (authored by floca).
First draft of the refactoring
Jan 31 2020, 5:42 PM
floca added a comment to T27034: Refactor Segmentation plugin to use new selection concept.

Pushed new branch T27034-Refactor_segmentation_to_new_selection_concept.

Jan 31 2020, 5:42 PM · MITK
floca added a revision to T27034: Refactor Segmentation plugin to use new selection concept: Unknown Object (Differential Revision).
Jan 31 2020, 5:42 PM · MITK
nolden added a revision to T25983: Update DICOM related toolkits: Unknown Object (Differential Revision).
Jan 31 2020, 5:21 PM · MITK, DICOM
kislinsk closed T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild as Resolved.
Jan 31 2020, 3:15 PM · Noteworthy, Restricted Project, CI, MITK
floca committed rMITKdf3e664d83fb: Fixed T27036 - AutoSelectNewNode_mode_for_singleNodeSelectionWidget (authored by floca).
Fixed T27036 - AutoSelectNewNode_mode_for_singleNodeSelectionWidget
Jan 31 2020, 2:41 PM
floca committed rMITK1c819b9483c5: fixed review remarks (authored by floca).
fixed review remarks
Jan 31 2020, 2:41 PM
floca committed rMITKce80e0605a95: Fixed review remarks (authored by floca).
Fixed review remarks
Jan 31 2020, 2:41 PM
floca committed rMITK5e875f1a60ae: fixed gcc compile errors (authored by floca).
fixed gcc compile errors
Jan 31 2020, 2:40 PM
floca committed rMITK41bdd16b22f3: Fixed T27036 (authored by floca).
Fixed T27036
Jan 31 2020, 2:40 PM
floca closed T27036: Add AutoSelectNewNodes mode to SingleNodeSelectionWidget, a subtask of T23751: Introduction of new selection concept, as Resolved.
Jan 31 2020, 2:40 PM · Noteworthy, MITK
floca closed T27036: Add AutoSelectNewNodes mode to SingleNodeSelectionWidget as Resolved by committing rMITK41bdd16b22f3: Fixed T27036.
Jan 31 2020, 2:40 PM · MITK
floca added a comment to T27016: Use OpenStack for our CI system.

Windows is now also possible. You have to file a ticket and specify how many Cores/RAM you want to run with windows.

Jan 31 2020, 2:17 PM · Restricted Project, CI
kislinsk committed rMITK96923a079f6f: Merge branch 'T27042-AutocleanExternalProjects' (authored by kislinsk).
Merge branch 'T27042-AutocleanExternalProjects'
Jan 31 2020, 1:59 PM
kislinsk committed rMITKca3c891e09b4: Glob Unix binaries with lib prefix (authored by kislinsk).
Glob Unix binaries with lib prefix
Jan 31 2020, 1:59 PM
kislinsk added a project to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild: Noteworthy.
Jan 31 2020, 1:33 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk added a comment to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.

I activated MITK_AUTOCLEAN_EXTERNAL_PROJECTS on Differential and Continuous jobs. Fingers crossed.

Jan 31 2020, 1:27 PM · Noteworthy, Restricted Project, CI, MITK
kislinsk committed rMITK08c4886e4d4d: Merge branch 'T27042-AutocleanExternalProjects' (authored by kislinsk).
Merge branch 'T27042-AutocleanExternalProjects'
Jan 31 2020, 12:50 PM
kislinsk committed rMITKea003216477e: Create install manifest for Boost (authored by kislinsk).
Create install manifest for Boost
Jan 31 2020, 12:44 PM
kislinsk committed rMITK253abe403cee: Introduce experimental auto-cleaning of updated external projects (authored by kislinsk).
Introduce experimental auto-cleaning of updated external projects
Jan 31 2020, 8:12 AM
kislinsk added a comment to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.

Pushed new branch T27042-AutocleanExternalProjects.

Jan 31 2020, 8:11 AM · Noteworthy, Restricted Project, CI, MITK

Jan 30 2020

kleina committed rOBSHYPPOPYba147fa770ad: Add possibility to pass comm to MPI classes. (authored by kleina).
Add possibility to pass comm to MPI classes.
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPY818af7645bd2: testing out different loss_functions in MPI context. (authored by kleina).
testing out different loss_functions in MPI context.
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPYb3b1fc6637cb: removed prototyping code... (authored by kleina).
removed prototyping code...
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPY4dca75afb591: make sure to call loss_func_cand_preprocess and loss_func_postprocess correctly… (authored by kleina).
make sure to call loss_func_cand_preprocess and loss_func_postprocess correctly…
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPYbfa1d6355844: Try both, calling blackbox_function with kwargs and by directly passing… (authored by kleina).
Try both, calling blackbox_function with kwargs and by directly passing…
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPYceeb9ccaa9a8: Implemented loss_func_cand_preprocess and loss_func_postprocess for… (authored by kleina).
Implemented loss_func_cand_preprocess and loss_func_postprocess for…
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPYb19055317a61: MPIBlackboxFunction now inherits from BlackBoxFunction and just adds the… (authored by kleina).
MPIBlackboxFunction now inherits from BlackBoxFunction and just adds the…
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPY7d5a08925371: See T26868: Don't need this anymore. (authored by kleina).
See T26868: Don't need this anymore.
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPY5c224fb8945b: See T26868. Introduced loss_func_cand_preprocess and loss_func_postprocess. (authored by kleina).
See T26868. Introduced loss_func_cand_preprocess and loss_func_postprocess.
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPYa153ed802dc6: Fix for T26870 (authored by kleina).
Fix for T26870
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPY18d366ef41ad: code cleanup... (authored by kleina).
code cleanup...
Jan 30 2020, 3:24 PM
kleina committed rOBSHYPPOPY9f38c4e495a4: Added print in worker to see if it is actually doing things... (authored by kleina).
Added print in worker to see if it is actually doing things...
Jan 30 2020, 3:24 PM
Sara added a comment to T27006: [Perfusion] - Problems selecting T1 map.

Hi Ralf,
please find enclosed the T1 map obtained from ROCKETSHIP.
Kind regards,
Sara and Daisy

Jan 30 2020, 2:33 PM · MITK
floca added a comment to T27006: [Perfusion] - Problems selecting T1 map.
In T27006#193592, @Sara wrote:

We would like to highlight that the fa*.dcm files are the Variable Flip Angle simulated acquisitions that one has to fit in order to compute the T1 map.

Ah ok. Thanks for the clarification.

Jan 30 2020, 1:25 PM · MITK
Sara added a comment to T27006: [Perfusion] - Problems selecting T1 map.

Hi Ralf,

Jan 30 2020, 12:39 PM · MITK
kislinsk added a comment to T27042: Short-range plan to prevent Differentials from unnecessarily building the superbuild.

I just thought about it could be a good idea to actually do this in our CMake script right in MITK. We can check all sorts of things there before and after external project processing.

Jan 30 2020, 9:30 AM · Noteworthy, Restricted Project, CI, MITK
kislinsk added a comment to T26980: MITK_CREATE_MACRO should prohibit dependencies against autoload modules.

@kislinsk You mentioned that we should do something as soon as the (wrong) autload dependencies are gone. I cannot remember what, do you? May be some work arround in our packaging code due to the autoload modules?

Jan 30 2020, 9:26 AM · MITK, Noteworthy
floca claimed T27035: Refactor Multi Label Segmentation plugin to use new selection concept.
Jan 30 2020, 8:59 AM · MITK
floca claimed T27034: Refactor Segmentation plugin to use new selection concept.
Jan 30 2020, 8:59 AM · MITK
floca closed T26980: MITK_CREATE_MACRO should prohibit dependencies against autoload modules as Resolved.

@kislinsk You mentioned that we should do something as soon as the (wrong) autload dependencies are gone. I cannot remember what, do you? May be some work arround in our packaging code due to the autoload modules?

Jan 30 2020, 8:50 AM · MITK, Noteworthy
floca committed rMITK8a85321d889c: First draft for fix of T26980 (authored by floca).
First draft for fix of T26980
Jan 30 2020, 8:46 AM