Page MenuHomePhabricator
Feed All Stories

Oct 23 2020

kislinsk removed a project from T27904: Feature request: Colorbars to interpret data in MITK: Request for Discussion.
Oct 23 2020, 11:23 AM · Moved to git.dkfz.de, Request for Discussion, MITK
aguilera added a comment to T23624: Connection to Epiphan frame grabber via OpenCV is buggy.

Two options in order to integrate Epiphan were discussed:

Oct 23 2020, 11:15 AM · Auto-closed, IMSY, IGT, Restricted Project, MITK
eisenman updated the task description for T27905: [shiny] Investigate download failure.
Oct 23 2020, 11:00 AM · webChallengeR
eisenman triaged T27905: [shiny] Investigate download failure as High priority.
Oct 23 2020, 10:56 AM · webChallengeR
kislinsk added a comment to T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation.

Deleted branch feature/T27789-ClippingPlanePlugin.

Oct 23 2020, 9:19 AM · MITK (v2021.02)
kislinsk committed rMITK26bde1c5b441: Move Clipping Plane view into separate plugin (authored by kislinsk).
Move Clipping Plane view into separate plugin
Oct 23 2020, 9:19 AM
kislinsk closed T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation as Resolved by committing rMITK26bde1c5b441: Move Clipping Plane view into separate plugin.
Oct 23 2020, 9:18 AM · MITK (v2021.02)
kislinsk added a comment to T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation.

Pushed new branch feature/T27789-ClippingPlanePlugin.

Oct 23 2020, 9:18 AM · MITK (v2021.02)
floca committed rRTTB0dcba40a9869: T26357 Fixed RTTB Install rules (authored by floca).
T26357 Fixed RTTB Install rules
Oct 23 2020, 9:17 AM

Oct 22 2020

thomass added a comment to T27904: Feature request: Colorbars to interpret data in MITK.

In T26382 the recent developments are summarized.

Oct 22 2020, 3:04 PM · Moved to git.dkfz.de, Request for Discussion, MITK
s669m updated s669m.
Oct 22 2020, 2:03 PM
thomass triaged T27904: Feature request: Colorbars to interpret data in MITK as Normal priority.
Oct 22 2020, 12:59 PM · Moved to git.dkfz.de, Request for Discussion, MITK

Oct 21 2020

e148c moved T27828: [shiny] Error message when wrong type in text field from Backlog to In Progress on the webChallengeR board.
Oct 21 2020, 3:03 PM · webChallengeR
aguilera moved T27827: [shiny] Disabling button "Next" when checkbox "configure" is checked but nothing has been picked from Backlog to In Progress on the webChallengeR board.

Flags to check whether the "Next" button has being activated have been added. Needs to be adapted due to a bug:

Oct 21 2020, 9:46 AM · webChallengeR
e148c moved T27782: [shiny] Success notification may be hidden from Backlog to In Progress on the webChallengeR board.
Oct 21 2020, 9:31 AM · webChallengeR

Oct 20 2020

dreherk closed T27005: Domain adaptation of simulation with real PA images as Wontfix.
Oct 20 2020, 4:19 PM · IMSY, Photoacoustics
makr added a comment to CEST User Manual.

I got this error message on SS FSE CEST, ERROR: Image(0000027E06632400): A spacing of 0 is not allowed: Spacing is [0.31, 0.31, 0]

Oct 20 2020, 3:01 PM · MITK
nolden added a comment to T27902: Handle slashes in installer names.

Ups ;) Replace with - or _?

Oct 20 2020, 2:10 PM · MITK (v2021.02)
aguilera claimed T27835: [shiny] Change order of ranking configuration.
Oct 20 2020, 2:05 PM · webChallengeR
kislinsk added a comment to T27902: Handle slashes in installer names.

Also, in the zip folder for example, we suddenly have nested folders: MITK-snapshots/2020-09-25-123-gabcdefab-windows-x86_64.

Oct 20 2020, 1:46 PM · MITK (v2021.02)
kislinsk updated the task description for T27902: Handle slashes in installer names.
Oct 20 2020, 1:43 PM · MITK (v2021.02)
kislinsk triaged T27902: Handle slashes in installer names as High priority.
Oct 20 2020, 1:42 PM · MITK (v2021.02)
aguilera moved T27891: [shiny] fix bootstrapping choice in new report from In Progress to Done on the webChallengeR board.
Oct 20 2020, 1:40 PM · webChallengeR
kislinsk closed T27900: Reference typo in mitkPlanarEllipse.cpp as Resolved.
Oct 20 2020, 12:04 PM · MITK
kislinsk added a comment to T27900: Reference typo in mitkPlanarEllipse.cpp.

Deleted branch bugfix/T27900-TypoInReference.

Oct 20 2020, 12:03 PM · MITK
kislinsk committed rMITKe10d0aee8877: Merge branch 'bugfix/T27900-TypoInReference' into develop (authored by kislinsk).
Merge branch 'bugfix/T27900-TypoInReference' into develop
Oct 20 2020, 12:03 PM
kislinsk added a comment to T27900: Reference typo in mitkPlanarEllipse.cpp.

Pushed new branch bugfix/T27900-TypoInReference.

Oct 20 2020, 12:02 PM · MITK
kislinsk triaged T27900: Reference typo in mitkPlanarEllipse.cpp as Low priority.
Oct 20 2020, 11:59 AM · MITK
aguilera assigned T27828: [shiny] Error message when wrong type in text field to e148c.
Oct 20 2020, 10:19 AM · webChallengeR
aguilera assigned T27782: [shiny] Success notification may be hidden to e148c.
Oct 20 2020, 10:19 AM · webChallengeR
aguilera claimed T27891: [shiny] fix bootstrapping choice in new report.
Oct 20 2020, 9:26 AM · webChallengeR
kislinsk merged task T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism into T27701: Overhaul or remove PluginGenerator.
Oct 20 2020, 9:11 AM · Request for Discussion, MITK
kislinsk merged T27084: Clean up, improve and test PluginGenerator, ProjectTemplate and MITK_EXTENSION_DIRS mechanism into T27701: Overhaul or remove PluginGenerator.
Oct 20 2020, 9:11 AM · MITK, Next Milestone

Oct 19 2020

aguilera added a comment to T27782: [shiny] Success notification may be hidden.

This notification can be omitted, since there is already a "generating report" notification on the background.

Oct 19 2020, 4:54 PM · webChallengeR
e148c renamed T27889: [shiny] display error notification when trying generating already opened report from Error when trying to generate a report with an already existing name to display error notification when trying generating already opened report.
Oct 19 2020, 3:03 PM · webChallengeR
aguilera triaged T27891: [shiny] fix bootstrapping choice in new report as High priority.
Oct 19 2020, 2:22 PM · webChallengeR
aguilera triaged T27889: [shiny] display error notification when trying generating already opened report as Normal priority.
Oct 19 2020, 2:22 PM · webChallengeR
kislinsk added a comment to T27894: Linux nightly installer doesn't start on Fedora.

Agree, but we should definitely package Python instead of relying on system python in any case as there are more strings attached. Even between minor Python updates there are imcompatibilities especially when SWIG is involved. Also we rely on certain Python packages like numpy or SimpleITK. So the plan is:

Oct 19 2020, 1:44 PM · MITK (v2021.02)
nolden added a comment to T27894: Linux nightly installer doesn't start on Fedora.

I was just about to add a note that there is the general question how to handle python in installers. I guess for just having the basic runtime available it would be ok to just load libpython3.so or libpython3.8.so and let the system take the right one from the right path. But on Windows I guess most people don't install Python in system locations. Anyway I think this could be fixed even with the current packaging if we need it for 2020, but I'm just reporting, no pressure from my side ;)

Oct 19 2020, 1:25 PM · MITK (v2021.02)
kislinsk added a parent task for T27894: Linux nightly installer doesn't start on Fedora: T27196: Rewrite packaging of MITK.
Oct 19 2020, 1:19 PM · MITK (v2021.02)
kislinsk added a subtask for T27196: Rewrite packaging of MITK: T27894: Linux nightly installer doesn't start on Fedora.
Oct 19 2020, 1:19 PM · Moved to git.dkfz.de, MITK, Cleared
kislinsk triaged T27894: Linux nightly installer doesn't start on Fedora as Normal priority.
Oct 19 2020, 1:18 PM · MITK (v2021.02)
kislinsk merged T26258: MITK and python only works with the specific python version the installer was created with into T27894: Linux nightly installer doesn't start on Fedora.
Oct 19 2020, 1:18 PM · MITK (v2021.02)
kislinsk merged task T26258: MITK and python only works with the specific python version the installer was created with into T27894: Linux nightly installer doesn't start on Fedora.
Oct 19 2020, 1:18 PM · MITK
kislinsk added a comment to T27894: Linux nightly installer doesn't start on Fedora.

I guess this is not specific to Fedora (not even to Linux) as we do not yet package python into the installer as far as I know. As this task is a bit moe vorbose than T26258: MITK and python only works with the specific python version the installer was created with, I will close the other one as duplicate.

Oct 19 2020, 1:18 PM · MITK (v2021.02)
kislinsk added a subtask for T27196: Rewrite packaging of MITK: T26258: MITK and python only works with the specific python version the installer was created with.
Oct 19 2020, 1:16 PM · Moved to git.dkfz.de, MITK, Cleared
kislinsk added a parent task for T26258: MITK and python only works with the specific python version the installer was created with: T27196: Rewrite packaging of MITK.
Oct 19 2020, 1:16 PM · MITK
kislinsk added a revision to T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation: Restricted Differential Revision.
Oct 19 2020, 1:13 PM · MITK (v2021.02)
nolden edited projects for T27894: Linux nightly installer doesn't start on Fedora, added: MITK (v2021.02); removed MITK.
Oct 19 2020, 1:08 PM · MITK (v2021.02)
nolden created T27894: Linux nightly installer doesn't start on Fedora.
Oct 19 2020, 1:07 PM · MITK (v2021.02)
kislinsk claimed T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation.
Oct 19 2020, 12:51 PM · MITK (v2021.02)

Oct 16 2020

e148c created T27891: [shiny] fix bootstrapping choice in new report.
Oct 16 2020, 3:00 PM · webChallengeR
e148c created T27889: [shiny] display error notification when trying generating already opened report.
Oct 16 2020, 2:53 PM · webChallengeR
kislinsk added a comment to T27851: Unhide label presets.
  • I renamed the context menu entries to Load/Save LabelSet Preset
  • I made these actions also available as tool buttons in the Multilabel Segmentation View
  • I fixed quite a few bugs in the loading mechanism
    • Existing label properties are now overridden by a preset
    • Layers/labels in other layers work now
    • The state of the Multilabel Segmentation View is now updated after a preset was loaded
Oct 16 2020, 10:23 AM · MITK (v2021.02)
kislinsk added a comment to T27851: Unhide label presets.

Pushed new branch bugfix/T27851-FixLabelSetPresetsAndMakeThemMoreAccessible.

Oct 16 2020, 8:27 AM · MITK (v2021.02)

Oct 15 2020

kislinsk committed rMITK663e373e312f: Fix loop and data type in LevelWindow::SetAuto() (authored by kislinsk).
Fix loop and data type in LevelWindow::SetAuto()
Oct 15 2020, 6:57 PM
kislinsk closed T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto as Resolved by committing rMITK663e373e312f: Fix loop and data type in LevelWindow::SetAuto().
Oct 15 2020, 6:57 PM · MITK
kislinsk committed rMITKb04e68dba7f1: Fix loop and data type (authored by kislinsk).
Fix loop and data type
Oct 15 2020, 6:57 PM
kislinsk added a revision to T27851: Unhide label presets: Unknown Object (Differential Revision).
Oct 15 2020, 6:53 PM · MITK (v2021.02)
kislinsk closed T27887: Make package fails when using system Qt packages on Ubuntu 20.04 as Resolved.
Oct 15 2020, 4:24 PM · MITK
kislinsk added a comment to T27887: Make package fails when using system Qt packages on Ubuntu 20.04.

Deleted branch hotfix/T27887-fix-packaging-with-system-qt.

Oct 15 2020, 4:24 PM · MITK
kislinsk committed rMITKc25989b3eaa9: Merge remote-tracking branch 'origin/hotfix/T27887-fix-packaging-with-system… (authored by kislinsk).
Merge remote-tracking branch 'origin/hotfix/T27887-fix-packaging-with-system…
Oct 15 2020, 4:22 PM
kislinsk committed rMITK0f33cec9e310: Merge remote-tracking branch 'origin/hotfix/T27887-fix-packaging-with-system-qt' (authored by kislinsk).
Merge remote-tracking branch 'origin/hotfix/T27887-fix-packaging-with-system-qt'
Oct 15 2020, 4:22 PM
nolden added a comment to T27887: Make package fails when using system Qt packages on Ubuntu 20.04.

Pushed new branch hotfix/T27887-fix-packaging-with-system-qt.

Oct 15 2020, 4:14 PM · MITK
nolden triaged T27887: Make package fails when using system Qt packages on Ubuntu 20.04 as Unbreak Now! priority.
Oct 15 2020, 3:58 PM · MITK
wiesenfa added a comment to T27794: Stacked frequency plots should switch to single page layout.

stabilityByAlgorithmStacked is now replaced by stabilityByAlgorithm(....., stacked=TRUE)

Oct 15 2020, 2:43 PM · challengeR (v1.0)
wiesenfa moved T27794: Stacked frequency plots should switch to single page layout from In Progress to Done on the challengeR (v1.0) board.
Oct 15 2020, 2:40 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER2fd21713233a: Merge branch 'develop' of https://phabricator.mitk.org/source/challenger into… (authored by wiesenfa).
Merge branch 'develop' of https://phabricator.mitk.org/source/challenger into…
Oct 15 2020, 2:40 PM
wiesenfa committed rCHALLENGER6a7e604bf5f8: Merge branch 'feature/T27794-stackedFrequencies' into develop (authored by wiesenfa).
Merge branch 'feature/T27794-stackedFrequencies' into develop
Oct 15 2020, 2:40 PM
wiesenfa committed rCHALLENGER75ee76a039c2: use print.ggList (authored by wiesenfa).
use print.ggList
Oct 15 2020, 2:40 PM
wiesenfa committed rCHALLENGERd6b7074d84e7: replace stabilityByAlgorithmStacked by stabilityByAlgorithm(...,stacked=T) (authored by wiesenfa).
replace stabilityByAlgorithmStacked by stabilityByAlgorithm(...,stacked=T)
Oct 15 2020, 2:40 PM
kislinsk claimed T27851: Unhide label presets.

The functionality is already in a separate class LabelSetIOHelper so it is not restricted to DataManager actions per se. The code in these actions is of pretty bad quality, though. The first step will be to clean up these actions. I will also rename the actions in the context menu to Load LabelSet Preset and Save LabelSet Preset to make them more distinguishable. Then I will look into the view to see if the functionality is already there somewhere or if we must add it. I also already noticed that while the preset files contain information about layers as well, only the labels of the first layer are loaded.

Oct 15 2020, 11:58 AM · MITK (v2021.02)
wiesenfa moved T27794: Stacked frequency plots should switch to single page layout from Backlog to In Progress on the challengeR (v1.0) board.
Oct 15 2020, 11:27 AM · challengeR (v1.0)
wiesenfa claimed T27794: Stacked frequency plots should switch to single page layout.
Oct 15 2020, 11:27 AM · challengeR (v1.0)
kalali added a comment to T27506: Extend checklists for segmentation view.

I'm all in for that. We already discussed that we will focus again on this task {T26754} and its subtasks. This also includes

Automatic GUI testing

and

move as much tests as possible to Unit-Tests

Oct 15 2020, 9:56 AM · MITK (v2022.04), Cleared
kislinsk added a revision to T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto: Unknown Object (Differential Revision).
Oct 15 2020, 9:49 AM · MITK
kislinsk added a comment to T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto.

Thanks for reporting. The whole method seems to be dubious. The lines of code you mentioned are plain wrong, the loop should start with k=1 and the data type of numPixelsInDataset should be more appropriate.

Oct 15 2020, 9:30 AM · MITK
kislinsk claimed T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto.
Oct 15 2020, 9:27 AM · MITK
CptMo updated CptMo.
Oct 15 2020, 8:47 AM
CptMo updated the task description for T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto.
Oct 15 2020, 8:45 AM · MITK
CptMo triaged T27885: numPixelsInDataset calc may not currect in mitkLevelWindow::SetAuto as Normal priority.
Oct 15 2020, 7:24 AM · MITK

Oct 14 2020

floca added a comment to T27506: Extend checklists for segmentation view.

OK. But I tend/think more and more that we should strive for a unit test testbed that tests all that on the tool class level (either the respective base classes or the tools itself where it is easily possible (e.g. because the have no interaction (but even thous shouldn't be a show stopper).

Oct 14 2020, 8:21 PM · MITK (v2022.04), Cleared
kalali added a comment to T27506: Extend checklists for segmentation view.

The checklist don't say anything about multilabel segmentation. This should be addressed with a special focus on creating and combining multiple labels / layers.
I couldn't find any other checklist with a focus on the multilabel functionality.

Oct 14 2020, 3:42 PM · MITK (v2022.04), Cleared
kalali added a comment to T27873: Extend "Checkliste Segmentierung – Interpolation".

I updated the document and added content to explicitly tests

Oct 14 2020, 3:38 PM · MITK (v2022.04), Cleared
kalali triaged T27883: [Segmentation] Crash and interpolation issues in static segmentation on reference image with strange arbitrary time geometry (3d+t heart) as Normal priority.
Oct 14 2020, 2:55 PM · MITK (v2021.02)
kalali renamed T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden from Segmentation: interpolation nodes are not removed from data manager to [Segmentation] Interpolation nodes / position nodes are not correctly hidden.
Oct 14 2020, 2:27 PM · MITK (v2024.12)
kalali added a comment to T27149: [Segmentation] Interpolation nodes / position nodes are not correctly hidden.

I can verify this behavior. Also, if you close the segmentation view while the position nodes are shown, they stay visible.
If you open the segmentation view again and select the 3-Dimensional interpolation, the position nods are still shown, although the checkbox is not checked.
Checking it and unchecking it will hide the position nodes again.

Oct 14 2020, 2:26 PM · MITK (v2024.12)
kalali renamed T20110: [Multilabel Segmentation] Contour broken for 3D and 2D interpolation from Contour broken for 3D and 2D interpolation in multilabel segmentation plugin to [Multilabel Segmentation] Contour broken for 3D and 2D interpolation.
Oct 14 2020, 2:21 PM · Next Milestone, MITK
schererj edited projects for T27706: Refactor kaapana radiomics workflow to output xml files, added: Kaapana (internal); removed Request for Discussion, Kaapana (internal) (Open Source Rocketplant).

Alright -> removed the task from release-workboard

Oct 14 2020, 2:20 PM · Kaapana (internal)
floca added a comment to T27706: Refactor kaapana radiomics workflow to output xml files.

@floca do you know something about the status of the "new" radiomics container?

No.

Oct 14 2020, 1:52 PM · Kaapana (internal)
kislinsk edited projects for T27817: [Multilabel] Live Wire tool always assigns first label when being used with multiple labels, added: Cleared; removed Request for Discussion.
Oct 14 2020, 10:29 AM · Cleared, MITK (v2021.02)
kislinsk raised the priority of T27789: [Segmentation] Disentangle Clipping Plane plugin from segmentation from Normal to High.
Oct 14 2020, 10:24 AM · MITK (v2021.02)
kalali claimed T27873: Extend "Checkliste Segmentierung – Interpolation".
Oct 14 2020, 10:23 AM · MITK (v2022.04), Cleared
schererj updated subscribers of T27706: Refactor kaapana radiomics workflow to output xml files.

@floca do you know something about the status of the "new" radiomics container?
Since we don't have the new container yet, we will keep the old radiomics pipepline for this release if that's ok.

Oct 14 2020, 9:53 AM · Kaapana (internal)
kislinsk closed T27879: [CDash] CTEST_BUILD_NAME suffix feature as Resolved.
Oct 14 2020, 9:36 AM · MITK
kislinsk added a comment to T27879: [CDash] CTEST_BUILD_NAME suffix feature.

Deleted branch feature/T27879-MITK_BUILD_NAME_SUFFIX.

Oct 14 2020, 9:36 AM · MITK
kislinsk committed rMITK0a52c695f724: Merge branch 'feature/T27879-MITK_BUILD_NAME_SUFFIX' into develop (authored by kislinsk).
Merge branch 'feature/T27879-MITK_BUILD_NAME_SUFFIX' into develop
Oct 14 2020, 9:36 AM
kislinsk added a comment to T27879: [CDash] CTEST_BUILD_NAME suffix feature.

Pushed new branch feature/T27879-MITK_BUILD_NAME_SUFFIX.

Oct 14 2020, 9:35 AM · MITK
kislinsk triaged T27879: [CDash] CTEST_BUILD_NAME suffix feature as Wishlist priority.
Oct 14 2020, 9:34 AM · MITK
kompan added a comment to T27340: [ModelFit] Request for Mac Workbench installer.

No, not yet. I've sent an email and asked for a more detailed description of the problems and will post it in this task when I hear back from Jerome.

Oct 14 2020, 9:01 AM · Auto-closed, Restricted Project, MITK