Page MenuHomePhabricator
Feed All Stories

Mar 24 2023

neher closed T29441: Remove tractometry as Resolved.
Mar 24 2023, 9:31 AM · MITK Diffusion
kalali added a comment to T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.

Updated task description since the class has been refactored. However, the issue still exists, but now it is - as far as I can see - only abut getting the visibility etc. which can easily be refactored.

Mar 24 2023, 9:07 AM · Request for Discussion, MITK (v2023.04)
kalali updated the task description for T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.
Mar 24 2023, 9:06 AM · Request for Discussion, MITK (v2023.04)
kalali removed a parent task for T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Mar 24 2023, 9:04 AM · Request for Discussion, MITK (v2023.04)
kalali removed a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.
Mar 24 2023, 9:04 AM · MITK
kalali renamed T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly from [Multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly to [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.
Mar 24 2023, 9:03 AM · Request for Discussion, MITK (v2023.04)
kalali triaged T29499: [mxn multi widget] Test inverted slice navgation widget for 4D data as Normal priority.
Mar 24 2023, 8:58 AM · MITK (v2024.06)
neher committed rMITKDIFF161c453a09c8: flipx und fiber coloring (authored by neher).
flipx und fiber coloring
Mar 24 2023, 7:57 AM

Mar 23 2023

kalali added a revision to T29491: [mxn multi widget] Provide F1-Help page: Unknown Object (Differential Revision).
Mar 23 2023, 5:50 PM · MITK (v2023.04)
kislinsk added a comment to T29390: How to ease the handling of external generated segmentations.

Really used.

Mar 23 2023, 2:25 PM · MITK (v2024.06)
floca added a comment to T29390: How to ease the handling of external generated segmentations.

Is it realy used or just still supported?

Mar 23 2023, 12:30 PM · MITK (v2024.06)
kislinsk added a comment to T29390: How to ease the handling of external generated segmentations.

Turned out it is not straight forward to remove the "binary" feature since it is still used in quite a few crucial places like the segmentation paintbrush tool preview.

Mar 23 2023, 11:23 AM · MITK (v2024.06)

Mar 22 2023

kalali updated the task description for T29493: RenderWindow management classes need to be revised / cleaned.
Mar 22 2023, 8:41 PM · MITK (v2024.06)
kalali triaged T29498: [mxn multi widget] Restructure QmitkSynchronizedNodeSelectionWidget and QmitkAbstractNodeSelectionWidget as Normal priority.
Mar 22 2023, 7:11 PM · MITK (v2024.06)
a178n closed T29461: TotalSegmentator output label names conundrum as Resolved.
Mar 22 2023, 3:10 PM · MITK
a178n closed T29461: TotalSegmentator output label names conundrum, a subtask of T29437: [SEG] Add TotalSegmentator, as Resolved.
Mar 22 2023, 3:10 PM · MITK
a178n added a comment to T29461: TotalSegmentator output label names conundrum.

This task may be deemed fully discussed. Hence, will be marked as resolved.
Another task, T29497, is created for tracking the full subtask support in the future.

Mar 22 2023, 3:10 PM · MITK
a178n removed a project from T29461: TotalSegmentator output label names conundrum: Request for Discussion.
Mar 22 2023, 2:04 PM · MITK
a178n triaged T29497: Full support for all subtasks as Normal priority.
Mar 22 2023, 1:59 PM · MITK
kalali closed T29496: [Workbench] Core dumped when mouse moved! as Resolved.
Mar 22 2023, 11:42 AM · MITK
kalali added a revision to T29496: [Workbench] Core dumped when mouse moved!: Unknown Object (Differential Revision).
Mar 22 2023, 11:42 AM · MITK
kalali committed rMITKeeb2f471b188: Initialize reference geometry variables correctly (authored by kalali).
Initialize reference geometry variables correctly
Mar 22 2023, 11:42 AM
kalali committed rMITK7d4b19a25c78: Correctly initialize reference geometry variables (authored by kalali).
Correctly initialize reference geometry variables
Mar 22 2023, 11:42 AM
a178n updated the task description for T29496: [Workbench] Core dumped when mouse moved!.
Mar 22 2023, 11:34 AM · MITK
floca closed T29475: QmitkMultiLabelInspector: Should right click change selection? , a subtask of T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns, as Resolved.
Mar 22 2023, 10:18 AM · MITK (v2023.04), Checklist
floca closed T29475: QmitkMultiLabelInspector: Should right click change selection? as Resolved.

Discussion result: we keep the old style.

Mar 22 2023, 10:18 AM · MITK (v2023.04), Checklist
r948e committed rMITKDIFF70595422fb80: Initial shuffling changed. Some improvements of usability. (authored by r948e).
Initial shuffling changed. Some improvements of usability.
Mar 22 2023, 10:17 AM
kislinsk removed a project from T29390: How to ease the handling of external generated segmentations: Request for Discussion.

Request for Discussion Discussion result:

Mar 22 2023, 10:15 AM · MITK (v2024.06)
a178n added a comment to T29453: Unreachable catch block in OTSU?.

A pop up appears with whatever error message was thrown from OtsuTool3D::DoUpdatePreview.

Mar 22 2023, 9:52 AM · MITK
floca triaged T29453: Unreachable catch block in OTSU? as Normal priority.
Mar 22 2023, 9:21 AM · MITK
a178n removed a project from T29496: [Workbench] Core dumped when mouse moved!: Request for Discussion.
Mar 22 2023, 9:08 AM · MITK
floca triaged T23973: Improve MITK HiDPI support as Normal priority.
Mar 22 2023, 9:04 AM · MITK (v2023.04), Request for Discussion
floca moved T23973: Improve MITK HiDPI support from Backlog to MITK Meeting on the Request for Discussion board.
Mar 22 2023, 9:04 AM · MITK (v2023.04), Request for Discussion
floca moved T29453: Unreachable catch block in OTSU? from Backlog to MITK Meeting on the Request for Discussion board.
Mar 22 2023, 9:03 AM · MITK
floca moved T29461: TotalSegmentator output label names conundrum from Backlog to MITK Meeting on the Request for Discussion board.
Mar 22 2023, 9:03 AM · MITK
floca moved T29487: Tool Icon for TotalSegmentator from Backlog to MITK Meeting on the Request for Discussion board.
Mar 22 2023, 9:03 AM · MITK (v2024.06)
kislinsk added a comment to T29445: Make Segmentation Tasks Lists fully available in the MITK Workbench.

Pushed new branch to rMITK MITK: feature/T29445-SegmentationTaskListView.

Mar 22 2023, 1:04 AM · MITK (v2023.04)

Mar 21 2023

kalali added a comment to T29496: [Workbench] Core dumped when mouse moved!.

I uploaded a fix in D783. Let's see if this will solve the issue also for Ubuntu.

Mar 21 2023, 7:46 PM · MITK
kalali added a revision to T29335: [Segmentation] Show interactive warning for uninitialized render window geometry: Unknown Object (Differential Revision).
Mar 21 2023, 7:45 PM · MITK (v2023.04)
floca accepted rMITK65af279906d1: Merge branch 'bugfix/T29494-RegressionInPreferencesChangedEvent' into develop.
Mar 21 2023, 7:14 PM
kislinsk closed T25316: ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins as Resolved.
Mar 21 2023, 6:28 PM · MITK
kislinsk added a comment to T25316: ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins.

Deleted branch from rMITK MITK: bugfix/T25316-EnableThemedIconsInEagerPlugins.

Mar 21 2023, 6:28 PM · MITK
kislinsk committed rMITK12d357c0862c: Enable themed icons in eager plugins (authored by kislinsk).
Enable themed icons in eager plugins
Mar 21 2023, 6:28 PM
kislinsk committed rMITK7326bc741cba: Merge branch 'bugfix/T25316-EnableThemedIconsInEagerPlugins' into develop (authored by kislinsk).
Merge branch 'bugfix/T25316-EnableThemedIconsInEagerPlugins' into develop
Mar 21 2023, 6:28 PM
kislinsk added inline comments to rMITK65af279906d1: Merge branch 'bugfix/T29494-RegressionInPreferencesChangedEvent' into develop.
Mar 21 2023, 6:24 PM
floca raised a concern with rMITK65af279906d1: Merge branch 'bugfix/T29494-RegressionInPreferencesChangedEvent' into develop.
Mar 21 2023, 6:11 PM
kalali added a comment to T29496: [Workbench] Core dumped when mouse moved!.

I tested this on Windows with 4974a335ada8a85d7fba8d313e2efc20acc84b48, which was the latest develop I had, since I recently merged something into develop and couldn't reproduce the error.
Used StdMultiWidget, no other plugins open, no data loaded, only the widget planes available in the data storage.
I tested this with the commit given in the task description and couldn't reproduce the error there as well.

Mar 21 2023, 6:05 PM · MITK
a178n updated the task description for T29496: [Workbench] Core dumped when mouse moved!.
Mar 21 2023, 5:18 PM · MITK
a178n triaged T29496: [Workbench] Core dumped when mouse moved! as Unbreak Now! priority.
Mar 21 2023, 5:17 PM · MITK
kislinsk added a revision to T25316: ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins: Unknown Object (Differential Revision).
Mar 21 2023, 1:24 PM · MITK
kislinsk added a comment to T25316: ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins.

Pushed new branch to rMITK MITK: bugfix/T25316-EnableThemedIconsInEagerPlugins.

Mar 21 2023, 1:21 PM · MITK
kislinsk claimed T25316: ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins.
Mar 21 2023, 1:15 PM · MITK
floca added subtasks for T29495: [SEG] Rework segmentation view UX: T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns, T29392: [SEG] Add dedicated writer to store multi-label images in nifti, T29449: [SEG] Allow predefined label list and optional label list to indicate if multiple instances of a label are allowed..
Mar 21 2023, 8:52 AM · MITK (v2023.12)
floca added a parent task for T29392: [SEG] Add dedicated writer to store multi-label images in nifti: T29495: [SEG] Rework segmentation view UX.
Mar 21 2023, 8:52 AM · MITK (v2024.06)
floca added a parent task for T29449: [SEG] Allow predefined label list and optional label list to indicate if multiple instances of a label are allowed.: T29495: [SEG] Rework segmentation view UX.
Mar 21 2023, 8:52 AM · MITK
floca added a parent task for T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns: T29495: [SEG] Rework segmentation view UX.
Mar 21 2023, 8:52 AM · MITK (v2023.04), Checklist
floca triaged T29495: [SEG] Rework segmentation view UX as Normal priority.
Mar 21 2023, 8:51 AM · MITK (v2023.12)

Mar 20 2023

r948e committed rMITKDIFFd20c2783641f: Update mitkSphereInteractor.cpp, mitkSphereInteractor.h, and 2 more files... (authored by r948e).
Update mitkSphereInteractor.cpp, mitkSphereInteractor.h, and 2 more files...
Mar 20 2023, 1:35 PM
r948e committed rMITKDIFF904605a75b4a: Import Fiber Bundle in interactor. Extract relevant Fibers tbd (authored by r948e).
Import Fiber Bundle in interactor. Extract relevant Fibers tbd
Mar 20 2023, 1:35 PM
r948e committed rMITKDIFF98ace3ca3147: Interactor implemented and working (authored by r948e).
Interactor implemented and working
Mar 20 2023, 1:35 PM
kalali updated the task description for T29493: RenderWindow management classes need to be revised / cleaned.
Mar 20 2023, 1:33 PM · MITK (v2024.06)
kislinsk closed T29432: [worklist] mitk-flow preload first task as Wontfix.

While the original issue is rather easy to resolve by exchanging the class to data->Modified() with a RequestRenderWindowAll() (which is the actual intent anyway according to the comments), more hurdles start to appear that are not as easy to resolve.

The data loading that is now happening immediately, is happening even before the rendering manager has any registered render windows. Any geometry validation of the data against render window geometries is a no-op, and it is kind of okay as it just works. However, when now adding another label in the GUI for example, the Segmentation View again does its data validation and now there ARE render windows with geometries and these do not match the segmentation geometry, resulting in the Segmentation View complaining about a necessary reinit (that is not necessary, yet is technically correct). There are many strategies to resolve this issue, none of them seem easy. The most straight-forward concept at least would be to defer loading of any data until the application is done with initializing its plugins and editors. That would probably require some kind of "ready" event triggered which could be used to load data specificied on the command-line.

Mar 20 2023, 11:38 AM · MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Deleted branch from rMITK MITK: feature/T29432-PreloadFirstTask2.

Mar 20 2023, 11:36 AM · MITK
kislinsk added a revision to T29463: Doxygen documentation for TotalSegmentator: Unknown Object (Differential Revision).
Mar 20 2023, 11:02 AM · MITK (v2023.04)
kislinsk closed T29482: [Segmentation] Opened segmentation plugin and two binary mask in data manager lead to problems / crash as Resolved.
Mar 20 2023, 10:07 AM · MITK (v2023.04)

Mar 19 2023

kislinsk closed T29494: Notify Views on Preference changes when the Preferences dialog is closed as Resolved.
Mar 19 2023, 5:26 PM · MITK (v2023.04)
kislinsk added a comment to T29494: Notify Views on Preference changes when the Preferences dialog is closed.

Deleted branch from rMITK MITK: bugfix/T29494-RegressionInPreferencesChangedEvent.

Mar 19 2023, 5:25 PM · MITK (v2023.04)
kislinsk committed rMITKf50eaee22362: Fix a regression in Preference change events (authored by kislinsk).
Fix a regression in Preference change events
Mar 19 2023, 5:18 PM
kislinsk committed rMITK65af279906d1: Merge branch 'bugfix/T29494-RegressionInPreferencesChangedEvent' into develop (authored by kislinsk).
Merge branch 'bugfix/T29494-RegressionInPreferencesChangedEvent' into develop
Mar 19 2023, 5:18 PM
kislinsk added a comment to T29494: Notify Views on Preference changes when the Preferences dialog is closed.

Pushed new branch to rMITK MITK: bugfix/T29494-RegressionInPreferencesChangedEvent.

Mar 19 2023, 5:17 PM · MITK (v2023.04)
kislinsk triaged T29494: Notify Views on Preference changes when the Preferences dialog is closed as Normal priority.
Mar 19 2023, 5:15 PM · MITK (v2023.04)

Mar 18 2023

a178n added a comment to T29461: TotalSegmentator output label names conundrum.

After meeting it is decided that:

  1. Label names/classes & their pixel values that are hardcoded in the python codebase will be parsed directly and shown in MITK for 2023.04 release (Ref: https://github.com/wasserth/TotalSegmentator/blob/master/totalsegmentator/map_to_binary.py)
  2. Certain subtasks which need multiple nifti file agglomeration (eg. "Body") will not be included in the 2023.04 release.
Mar 18 2023, 7:15 PM · MITK

Mar 17 2023

kalali closed T29402: [mxn multi widget] Concept for blocking individual render windows as Resolved.

With the child task T29335: [Segmentation] Show interactive warning for uninitialized render window geometry being closed, I will close this task as well. If more plugins should be able to enable blocked render windows, this should now be easily doable.

Mar 17 2023, 4:58 PM · MITK (v2023.04)
kalali closed T29335: [Segmentation] Show interactive warning for uninitialized render window geometry, a subtask of T29402: [mxn multi widget] Concept for blocking individual render windows, as Resolved.
Mar 17 2023, 4:57 PM · MITK (v2023.04)
kalali closed T29335: [Segmentation] Show interactive warning for uninitialized render window geometry as Resolved.
Mar 17 2023, 4:57 PM · MITK (v2023.04)
kalali committed rMITK4974a335ada8: Show warning for interaction reference geometry (authored by kalali).
Show warning for interaction reference geometry
Mar 17 2023, 4:57 PM
kalali committed rMITKc48fce2c31ca: Provide button overlay and use it to reset geometry (authored by kalali).
Provide button overlay and use it to reset geometry
Mar 17 2023, 4:57 PM
kalali committed rMITK1783751c9175: Clean base renderer (authored by kalali).
Clean base renderer
Mar 17 2023, 4:57 PM
kalali committed rMITKcf2f057add3c: Remove segmentation interactor and use new approach (authored by kalali).
Remove segmentation interactor and use new approach
Mar 17 2023, 4:57 PM
kalali committed rMITK077f4342b0e5: Provide functions to enable overlay warnings for not-aligned geometries (authored by kalali).
Provide functions to enable overlay warnings for not-aligned geometries
Mar 17 2023, 4:57 PM
kalali triaged T29493: RenderWindow management classes need to be revised / cleaned as Normal priority.
Mar 17 2023, 4:49 PM · MITK (v2024.06)
kalali added a revision to T26555: [mxn multi widget] Provide different default layouts: Unknown Object (Differential Revision).
Mar 17 2023, 3:32 PM · MITK
kalali triaged T29492: [mxn multi widget] Update and extend checklist as Normal priority.
Mar 17 2023, 3:31 PM · MITK (v2023.04)
kalali created T29492: [mxn multi widget] Update and extend checklist.
Mar 17 2023, 3:30 PM · MITK (v2023.04)
kalali moved T29491: [mxn multi widget] Provide F1-Help page from Backlog to Cycle on the MITK (v2023.04) board.
Mar 17 2023, 3:27 PM · MITK (v2023.04)
kalali triaged T29491: [mxn multi widget] Provide F1-Help page as Normal priority.
Mar 17 2023, 3:27 PM · MITK (v2023.04)
floca added a comment to T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns.

Pushed new branch to rMITK MITK: feature/T29206-MVC_for_labelset_v3.

Mar 17 2023, 9:02 AM · MITK (v2023.04), Checklist

Mar 16 2023

kalali triaged T29490: [StdMultiWidget] Block multi widget like it is done for the MxNMultiWidget as Normal priority.
Mar 16 2023, 6:54 PM · MITK (v2024.06)
kislinsk renamed T29489: Empty dialog may pop up when opening DICOM Browser on macOS from Empty dialog may pop up when opening DICOM Broswer on macOS to Empty dialog may pop up when opening DICOM Browser on macOS.
Mar 16 2023, 6:26 PM · MITK (v2023.04)
kislinsk closed T29489: Empty dialog may pop up when opening DICOM Browser on macOS as Resolved.
Mar 16 2023, 6:26 PM · MITK (v2023.04)
kislinsk added a comment to T29489: Empty dialog may pop up when opening DICOM Browser on macOS.

Deleted branch from rMITK MITK: bugfix/T29489-CreateProgressDialogOnTheFly.

Mar 16 2023, 6:26 PM · MITK (v2023.04)
kislinsk committed rMITK3cb98543eec0: Create progress dialog on the fly as it is shown immediately on creation (authored by kislinsk).
Create progress dialog on the fly as it is shown immediately on creation
Mar 16 2023, 6:26 PM
kislinsk committed rMITK751ab6fee6d8: Merge branch 'bugfix/T29489-CreateProgressDialogOnTheFly' into develop (authored by kislinsk).
Merge branch 'bugfix/T29489-CreateProgressDialogOnTheFly' into develop
Mar 16 2023, 6:25 PM
kislinsk added a comment to T29489: Empty dialog may pop up when opening DICOM Browser on macOS.

Pushed new branch to rMITK MITK: bugfix/T29489-CreateProgressDialogOnTheFly.

Mar 16 2023, 4:26 PM · MITK (v2023.04)
kislinsk triaged T29489: Empty dialog may pop up when opening DICOM Browser on macOS as High priority.
Mar 16 2023, 4:24 PM · MITK (v2023.04)
kislinsk added a comment to T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS.

@kislinsk Thank you, I will test it.

First thing I noticed: An empty Window opens when I open the DICOM browser. I can change the focus to the main window, but I cannot close the empty one:

Screen Shot 2023-03-16 at 7.41.45 AM.png (996×1 px, 574 KB)

Mar 16 2023, 3:23 PM · MITK (v2023.04)
kalali added a revision to T29403: [mxn multi widget] Concept for crosshair data type: Restricted Differential Revision.
Mar 16 2023, 2:07 PM · MITK (v2023.04)
aklein added a comment to T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS.

@kislinsk Thank you, I will test it.

Mar 16 2023, 12:43 PM · MITK (v2023.04)
kislinsk added a comment to T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS.

@aklein Here's the latest snapshot installer for macOS: https://www.mitk.org/download/ci/snapshots/macOS%20Catalina/MITK-snapshots_2023-03-16-macos-x86_64.dmg

Mar 16 2023, 10:33 AM · MITK (v2023.04)
kislinsk closed T29488: 2023 Week 11 (Mid March) as Resolved.
Mar 16 2023, 8:05 AM · MITK