Updated task description since the class has been refactored. However, the issue still exists, but now it is - as far as I can see - only abut getting the visibility etc. which can easily be refactored.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Mar 24 2023
Mar 23 2023
Really used.
Is it realy used or just still supported?
Turned out it is not straight forward to remove the "binary" feature since it is still used in quite a few crucial places like the segmentation paintbrush tool preview.
Mar 22 2023
This task may be deemed fully discussed. Hence, will be marked as resolved.
Another task, T29497, is created for tracking the full subtask support in the future.
Discussion result: we keep the old style.
Request for Discussion Discussion result:
A pop up appears with whatever error message was thrown from OtsuTool3D::DoUpdatePreview.
Pushed new branch to rMITK MITK: feature/T29445-SegmentationTaskListView.
Mar 21 2023
I uploaded a fix in D783. Let's see if this will solve the issue also for Ubuntu.
Deleted branch from rMITK MITK: bugfix/T25316-EnableThemedIconsInEagerPlugins.
I tested this on Windows with 4974a335ada8a85d7fba8d313e2efc20acc84b48, which was the latest develop I had, since I recently merged something into develop and couldn't reproduce the error.
Used StdMultiWidget, no other plugins open, no data loaded, only the widget planes available in the data storage.
I tested this with the commit given in the task description and couldn't reproduce the error there as well.
Pushed new branch to rMITK MITK: bugfix/T25316-EnableThemedIconsInEagerPlugins.
Mar 20 2023
In T29432#244945, @kislinsk wrote:While the original issue is rather easy to resolve by exchanging the class to data->Modified() with a RequestRenderWindowAll() (which is the actual intent anyway according to the comments), more hurdles start to appear that are not as easy to resolve.
The data loading that is now happening immediately, is happening even before the rendering manager has any registered render windows. Any geometry validation of the data against render window geometries is a no-op, and it is kind of okay as it just works. However, when now adding another label in the GUI for example, the Segmentation View again does its data validation and now there ARE render windows with geometries and these do not match the segmentation geometry, resulting in the Segmentation View complaining about a necessary reinit (that is not necessary, yet is technically correct). There are many strategies to resolve this issue, none of them seem easy. The most straight-forward concept at least would be to defer loading of any data until the application is done with initializing its plugins and editors. That would probably require some kind of "ready" event triggered which could be used to load data specificied on the command-line.
Deleted branch from rMITK MITK: feature/T29432-PreloadFirstTask2.
Mar 19 2023
Deleted branch from rMITK MITK: bugfix/T29494-RegressionInPreferencesChangedEvent.
Pushed new branch to rMITK MITK: bugfix/T29494-RegressionInPreferencesChangedEvent.
Mar 18 2023
After meeting it is decided that:
- Label names/classes & their pixel values that are hardcoded in the python codebase will be parsed directly and shown in MITK for 2023.04 release (Ref: https://github.com/wasserth/TotalSegmentator/blob/master/totalsegmentator/map_to_binary.py)
- Certain subtasks which need multiple nifti file agglomeration (eg. "Body") will not be included in the 2023.04 release.
Mar 17 2023
With the child task T29335: [Segmentation] Show interactive warning for uninitialized render window geometry being closed, I will close this task as well. If more plugins should be able to enable blocked render windows, this should now be easily doable.
Pushed new branch to rMITK MITK: feature/T29206-MVC_for_labelset_v3.
Mar 16 2023
Deleted branch from rMITK MITK: bugfix/T29489-CreateProgressDialogOnTheFly.
Pushed new branch to rMITK MITK: bugfix/T29489-CreateProgressDialogOnTheFly.
In T29469#245696, @aklein wrote:@kislinsk Thank you, I will test it.
First thing I noticed: An empty Window opens when I open the DICOM browser. I can change the focus to the main window, but I cannot close the empty one:
@kislinsk Thank you, I will test it.
@aklein Here's the latest snapshot installer for macOS: https://www.mitk.org/download/ci/snapshots/macOS%20Catalina/MITK-snapshots_2023-03-16-macos-x86_64.dmg