Page MenuHomePhabricator
Feed All Stories

Jul 17 2023

kislinsk triaged T30163: MITK v2023.04.2 as Normal priority.
Jul 17 2023, 10:40 AM · MITK
kislinsk created an object: MITK v2023.04.2.
Jul 17 2023, 10:38 AM

Jul 14 2023

s434n added a project to T29369: [Segmentation Utilities] Handle / select different labels independently: Request for Discussion.

I think the handling of multiple labels depends on each action and needs to be handled separately.

  • Boolean Operations: I see a few options here
    • low effort: only allow for segmentations with one label. If there is more than one label, show a message that this is not possible
    • higher effort: completely rework the selection. Let the user select two specific labels (from the same or different segmentations) and work on these, either replacing the first label or adding a new label (or instance) to that segmentation
  • Contour to Image & Surface to Image:
    • low effort: leave it as is, still works at the moment
    • higher effort: introduce the option to add the newly created segmentation as a new label / instance to an existing segmentation
  • Image Masking:
    • low effort: leave it as is, still works at the moment (using all labels of a segmentation)
    • higher effort: introduce the option to select which labels/instances should be considered for masking
  • Morphological Operations: Currently don't crash, but always use label 1
    • I think the most senseful solution would be to let the user select a specific label for the operation to work on. Multiple at the same time probably only get in each other's way and make it unnecessarily complicated.
Jul 14 2023, 4:44 PM · MITK (v2024.06)
s434n closed T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Invalid.
Jul 14 2023, 3:43 PM · MITK (v2022.10), Breaking Change
s434n closed T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty as Invalid.
Jul 14 2023, 3:43 PM · MITK (v2023.12), Request for Discussion
s434n added a revision to T30162: [Interpolation] [Documentation] Update interpolation documentation regarding multilabel support: Restricted Differential Revision.
Jul 14 2023, 3:25 PM · MITK (v2023.12)
s434n triaged T30162: [Interpolation] [Documentation] Update interpolation documentation regarding multilabel support as Low priority.
Jul 14 2023, 2:40 PM · MITK (v2023.12)

Jul 13 2023

floca triaged T30161: [DCM][SEG] First label data gets lost if multilables are stored as DCM Seg as Unbreak Now! priority.
Jul 13 2023, 3:37 PM · Missing Info, MITK (v2023.12)
a178n added a comment to T29645: Test Plan for SAM.

First draft available here: https://hub.dkfz.de/f/55114850

Jul 13 2023, 3:20 PM · MITK (v2023.12)
a178n closed T30153: SAM tool: Add caching support for Cross-hair rotated image views, a subtask of T29524: SAM in MITK, as Resolved.
Jul 13 2023, 11:57 AM · Moved to git.dkfz.de, MITK
a178n closed T30153: SAM tool: Add caching support for Cross-hair rotated image views as Resolved.
Jul 13 2023, 11:57 AM · MITK (v2023.12)
a178n added a comment to T30153: SAM tool: Add caching support for Cross-hair rotated image views.

Updated logic to use only Normal and center to generate unique hash for a plane. Updated D847

Jul 13 2023, 11:57 AM · MITK (v2023.12)
a178n edited projects for T29437: [SEG] Add TotalSegmentator, added: MITK; removed MITK (v2023.12).
Jul 13 2023, 10:35 AM · MITK
a178n closed T30150: Decommission current nnUNet(v1) tool? as Wontfix.

nnUNet(v1) won't be removed until nnUnet v2 is introduced.

Jul 13 2023, 10:35 AM · Request for Discussion, MITK (v2023.12)
floca lowered the priority of T29396: [Segmentation] Newly created labelset image has wrong image type from High to Normal.
Jul 13 2023, 10:15 AM · MITK (v2024.12)
floca lowered the priority of T29535: Reinit of scene with planar figure while the Display is closed leads to crash from High to Normal.
Jul 13 2023, 10:14 AM · Moved to git.dkfz.de, MITK (v2024.12), Known Issue
kislinsk removed a project from T30148: MITK FlowBench v2023.04 - crashes on "Accept segmentation": Request for Discussion.

I can reproduce the crash.

Jul 13 2023, 9:18 AM · MITK (v2023.12)
kislinsk triaged T29616: [DICOM] Add option to save images as DICOM as Wishlist priority.

It is technically possible but it would require about a person month to complete, so we decided for now we do not want start implementation as it is as important as other tasks that we have to accomplish.

Jul 13 2023, 9:14 AM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk moved T30160: Move MITK to our GitLab instance from Backlog to Cycle on the MITK (v2023.12) board.
Jul 13 2023, 8:51 AM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk triaged T30160: Move MITK to our GitLab instance as Normal priority.
Jul 13 2023, 8:51 AM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk moved T29406: Make MITK compatible with Qt 6 from Backlog to Cycle on the MITK (v2023.12) board.
Jul 13 2023, 8:48 AM · MITK (v2024.06)
kislinsk edited projects for T29406: Make MITK compatible with Qt 6, added: MITK (v2023.12); removed MITK.
Jul 13 2023, 8:47 AM · MITK (v2024.06)
kislinsk moved T30155: Bounding boxes / ROIs in MITK from Backlog to Cycle on the MITK (v2023.12) board.
Jul 13 2023, 8:47 AM · MITK (v2024.06)
kislinsk triaged T30148: MITK FlowBench v2023.04 - crashes on "Accept segmentation" as High priority.
Jul 13 2023, 8:47 AM · MITK (v2023.12)
kislinsk moved T30148: MITK FlowBench v2023.04 - crashes on "Accept segmentation" from Backlog to MITK Meeting on the Request for Discussion board.
Jul 13 2023, 8:46 AM · MITK (v2023.12)
kislinsk moved T30148: MITK FlowBench v2023.04 - crashes on "Accept segmentation" from Backlog to Cycle on the MITK (v2023.12) board.
Jul 13 2023, 8:46 AM · MITK (v2023.12)
kislinsk edited projects for T30148: MITK FlowBench v2023.04 - crashes on "Accept segmentation", added: Request for Discussion, MITK (v2023.12); removed MITK.
Jul 13 2023, 8:46 AM · MITK (v2023.12)

Jul 12 2023

kislinsk closed T30159: Disable ITK path length checks as Resolved.
Jul 12 2023, 3:39 PM · MITK
kislinsk added a comment to T30159: Disable ITK path length checks.

Deleted branch from rMITK MITK: bugfix/T30159-DisableITKPathLengthCheckOnWindows.

Jul 12 2023, 3:39 PM · MITK
kislinsk committed rMITK8031eb847f66: Skip ITK's path length check on Windows (authored by kislinsk).
Skip ITK's path length check on Windows
Jul 12 2023, 3:39 PM
kislinsk committed rMITK93cad3033b15: Merge branch 'bugfix/T30159-DisableITKPathLengthCheckOnWindows' into develop (authored by kislinsk).
Merge branch 'bugfix/T30159-DisableITKPathLengthCheckOnWindows' into develop
Jul 12 2023, 3:39 PM
kislinsk added a comment to T30159: Disable ITK path length checks.

Pushed new branch to rMITK MITK: bugfix/T30159-DisableITKPathLengthCheckOnWindows.

Jul 12 2023, 3:38 PM · MITK
kislinsk triaged T30159: Disable ITK path length checks as High priority.
Jul 12 2023, 3:35 PM · MITK
s434n committed rRTTB8907f1c6d32f: Fix namespaces for ITK v5.3.0 (authored by s434n).
Fix namespaces for ITK v5.3.0
Jul 12 2023, 3:03 PM
kislinsk changed the status of T29622: How to Download Instagram Videos Easily and Quickly Using instafinstaHD from Invalid to Spite.
Jul 12 2023, 2:56 PM
a178n added a revision to T30153: SAM tool: Add caching support for Cross-hair rotated image views: Unknown Object (Differential Revision).
Jul 12 2023, 2:56 PM · MITK (v2023.12)
a178n added a revision to T29604: SAM as 2D Tool in MITK- iteration 2: Unknown Object (Differential Revision).
Jul 12 2023, 2:55 PM · MITK (v2024.06)
kislinsk claimed T30148: MITK FlowBench v2023.04 - crashes on "Accept segmentation".

@floca Is this something we are already aware of (saving as .dcm crashes)?

Jul 12 2023, 2:51 PM · MITK (v2023.12)
nolden closed T29622: How to Download Instagram Videos Easily and Quickly Using instafinstaHD as Invalid.
Jul 12 2023, 2:20 PM

Jul 11 2023

fedorov added a comment to T30157: [DCM][SEG] potential in compliance to DICOM segmentation: clarify correct use of pixel value/segment number.

Sounds good Ralf - happy to help!

Jul 11 2023, 8:18 PM · Moved to git.dkfz.de, MITK (v2024.12), Missing Info, Request for Discussion
floca triaged T30158: [DCM][SEG] Check why unittests did not detect breaking support of DCM Seg and fix the (unit) test as Unbreak Now! priority.
Jul 11 2023, 7:54 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca raised the priority of T30157: [DCM][SEG] potential in compliance to DICOM segmentation: clarify correct use of pixel value/segment number from High to Unbreak Now!.

@fedorov Thank you for your quick reply and verification for my assumption (I hoped, that I might have overlooked some broader interpretablility...)

Jul 11 2023, 7:51 PM · Moved to git.dkfz.de, MITK (v2024.12), Missing Info, Request for Discussion
fedorov added a comment to T30157: [DCM][SEG] potential in compliance to DICOM segmentation: clarify correct use of pixel value/segment number.

" increase monotonically by 1" could be interpreted as "no holes allowed". We should clarify if this is the case.

Jul 11 2023, 5:37 PM · Moved to git.dkfz.de, MITK (v2024.12), Missing Info, Request for Discussion
floca added a comment to T30157: [DCM][SEG] potential in compliance to DICOM segmentation: clarify correct use of pixel value/segment number.
Jul 11 2023, 10:53 AM · Moved to git.dkfz.de, MITK (v2024.12), Missing Info, Request for Discussion
floca added a comment to T30155: Bounding boxes / ROIs in MITK.

👍
I would propose to also standardizeand align some of the properties for the frames to be either in sync with MITK terminology or with DICOM.

Jul 11 2023, 9:14 AM · MITK (v2024.06)
floca triaged T30157: [DCM][SEG] potential in compliance to DICOM segmentation: clarify correct use of pixel value/segment number as High priority.
Jul 11 2023, 9:06 AM · Moved to git.dkfz.de, MITK (v2024.12), Missing Info, Request for Discussion

Jul 10 2023

a178n renamed T30153: SAM tool: Add caching support for Cross-hair rotated image views from SAM tool support Cross-hair rotated images to SAM tool: Add caching support for Cross-hair rotated image views.
Jul 10 2023, 11:29 PM · MITK (v2023.12)
a178n added a project to T30156: Level Window contrast effect in SAM tool: Request for Discussion.
Jul 10 2023, 5:22 PM · MITK (v2023.12)
a178n added a comment to T30156: Level Window contrast effect in SAM tool.

I tried to implement this feature using the below snippet in DoUpdatePreview method.
The image get written successfully however there is no level window effect in the output image. Looks normal. What's going on?

mitk::LevelWindow levelWindow;
this->GetToolManager()->GetReferenceData(0)->GetLevelWindow(levelWindow);
MITK_INFO << "levelWindow.GetLowerWindowBound(): " << levelWindow.GetLowerWindowBound();
MITK_INFO << "levelWindow.GetUpperWindowBound(): " << levelWindow.GetUpperWindowBound();
MITK_INFO << "levelWindow.GetWindow(): " << levelWindow.GetWindow();
MITK_INFO << "levelWindow.GetLevel(): " << levelWindow.GetLevel();
Jul 10 2023, 5:22 PM · MITK (v2023.12)
a178n triaged T30156: Level Window contrast effect in SAM tool as Normal priority.
Jul 10 2023, 5:19 PM · MITK (v2023.12)
kislinsk updated the task description for T30155: Bounding boxes / ROIs in MITK.
Jul 10 2023, 1:04 PM · MITK (v2024.06)
kompan committed rMITK2955366622dd: Manually add contents of D605. (authored by kompan).
Manually add contents of D605.
Jul 10 2023, 11:46 AM
kompan committed rMITK5139ab4540c0: Put ExponentialSaturationModel back in. (authored by kompan).
Put ExponentialSaturationModel back in.
Jul 10 2023, 11:46 AM
kompan committed rMITK5734eb1e9177: UpdateGUIControls when initial values are changed. (authored by kompan).
UpdateGUIControls when initial values are changed.
Jul 10 2023, 11:46 AM
kompan committed rMITKe07c96105b4f: Remove empty line. (authored by kompan).
Remove empty line.
Jul 10 2023, 11:46 AM
kompan committed rMITK67d2adff2997: Manually add contents of D605. (authored by kompan).
Manually add contents of D605.
Jul 10 2023, 11:46 AM
kislinsk added a comment to T30155: Bounding boxes / ROIs in MITK.
  1. Done
  2. If the geometry is to be defined right in the file itself, I vote against a ReferenceGeometry type of "Geometry" but rather actually a "Geometry" JSON object. So it is either having a reference to something else that defines the geometry or specifying the geometry right in the file without any redirections.
  3. Done, also added "Type" to "Frames", which is "Box" for, well... boxes.
Jul 10 2023, 10:48 AM · MITK (v2024.06)
kislinsk updated the task description for T30155: Bounding boxes / ROIs in MITK.
Jul 10 2023, 10:43 AM · MITK (v2024.06)

Jul 9 2023

floca added a comment to T30155: Bounding boxes / ROIs in MITK.

@kislinsk thank you for the explanations. They do make sense.

Jul 9 2023, 4:49 PM · MITK (v2024.06)

Jul 8 2023

kislinsk awarded T30152: Create an MITK extension for IGT&co and move code a Love token.
Jul 8 2023, 8:35 AM · MITK (v2024.06)
kislinsk awarded T29649: Classification Module clean up a Love token.
Jul 8 2023, 8:35 AM · MITK (v2023.12), Request for Discussion
kislinsk added a comment to T30155: Bounding boxes / ROIs in MITK.

Thanks for the feedback. 🙏

Jul 8 2023, 8:33 AM · MITK (v2024.06)
kislinsk updated the task description for T30155: Bounding boxes / ROIs in MITK.
Jul 8 2023, 8:21 AM · MITK (v2024.06)

Jul 7 2023

floca added a comment to T30155: Bounding boxes / ROIs in MITK.

Thank you for the first draft. I had the following first thoughts:

Jul 7 2023, 3:36 PM · MITK (v2024.06)
kislinsk triaged T30155: Bounding boxes / ROIs in MITK as High priority.
Jul 7 2023, 12:48 PM · MITK (v2024.06)
floca updated subscribers of T29649: Classification Module clean up.

from @neher : clscreenshot sounds like something that might be useful, but i never used it

Jul 7 2023, 11:53 AM · MITK (v2023.12), Request for Discussion
a178n added a comment to T30154: MONAI Label server usage issues.

Multistage Vertebra Segmentation
Multistage Vertebra Segmentation is an auto segmentation workflow involving multiple models namely, localization_spine, localization_vertebra & segmentation_vertebra (unexposed).
There could be several issues in this:

  1. localization_spine: In practice, this gives me binary mask even though there is a whole of labels exposed in the API. This is in compliance with the documentation. But then the labels it claims to segment in the API don't make sense.
Jul 7 2023, 10:59 AM · Moved to git.dkfz.de, MITK

Jul 6 2023

a178n added a comment to T30154: MONAI Label server usage issues.

CUDA memory not cleared when out-of-memory exception occurs
Not all models have the same VRAM requirement.
When a model cannot run inferencing due to torch.cuda.OutOfMemoryError, exception occurs at server side clogging the GPU. Even if another model which could have potentially ran on the GPU, this clogging blocks it. Ideally TORCH.CUDA.EMPTY_CACHE should have been called to make room for next inferencing calls.

Jul 6 2023, 5:28 PM · Moved to git.dkfz.de, MITK
a178n triaged T30154: MONAI Label server usage issues as Normal priority.
Jul 6 2023, 5:23 PM · Moved to git.dkfz.de, MITK
kompan committed rMITK366f714a91eb: Manually add content of D618. (authored by kompan).
Manually add content of D618.
Jul 6 2023, 1:12 PM
kompan committed rMITKe370d87ea650: Manually add content of D618. (authored by kompan).
Manually add content of D618.
Jul 6 2023, 1:12 PM
floca moved T29649: Classification Module clean up from Backlog to Cycle on the MITK (v2023.12) board.
Jul 6 2023, 1:07 PM · MITK (v2023.12), Request for Discussion
floca edited projects for T29649: Classification Module clean up, added: MITK (v2023.12); removed MITK.
Jul 6 2023, 1:07 PM · MITK (v2023.12), Request for Discussion
a178n triaged T30153: SAM tool: Add caching support for Cross-hair rotated image views as Normal priority.
Jul 6 2023, 11:50 AM · MITK (v2023.12)
s434n committed rRTTB9f4f5fd77d0e: Add gamma index to RTTB (authored by s434n).
Add gamma index to RTTB
Jul 6 2023, 11:27 AM
floca added a comment to T29649: Classification Module clean up.

So far only CLGlobalImageFeatures is claimed to be needed.

Jul 6 2023, 10:16 AM · MITK (v2023.12), Request for Discussion
floca updated the task description for T29649: Classification Module clean up.
Jul 6 2023, 10:16 AM · MITK (v2023.12), Request for Discussion
floca updated subscribers of T30152: Create an MITK extension for IGT&co and move code.
Jul 6 2023, 8:47 AM · MITK (v2024.06)
floca triaged T30152: Create an MITK extension for IGT&co and move code as High priority.
Jul 6 2023, 8:47 AM · MITK (v2024.06)

Jul 5 2023

a178n added a comment to T29644: Doxygen documentation for SAM.

Pushed new branch to rMITK MITK: feature/T29644-sam-doku.

Jul 5 2023, 5:04 PM · MITK (v2023.12)

Jul 4 2023

a178n reopened T29539: SAM Python wrapper for MITK as "Open".
Jul 4 2023, 11:32 PM · MITK (v2024.06)
a178n reopened T29539: SAM Python wrapper for MITK, a subtask of T29524: SAM in MITK, as Open.
Jul 4 2023, 11:32 PM · Moved to git.dkfz.de, MITK
a178n closed T29539: SAM Python wrapper for MITK, a subtask of T29524: SAM in MITK, as Resolved.
Jul 4 2023, 11:32 PM · Moved to git.dkfz.de, MITK
a178n closed T29539: SAM Python wrapper for MITK as Resolved.

Update: Wrapper exists now at https://github.com/ASHISRAVINDRAN/sam-mitk

Jul 4 2023, 11:32 PM · MITK (v2024.06)
a178n triaged T30151: MONAI Label tool support CLICK interaction patterns as Normal priority.
Jul 4 2023, 11:27 PM · Moved to git.dkfz.de, MITK (v2024.12)
a178n closed T30146: SAMtool: Problem while downloading pretrained models as Resolved.

Python wrapper now automatically downloads model type. The feature lifted off from MITK c++ code base

Jul 4 2023, 11:23 PM · MITK (v2023.12)
a178n closed T30146: SAMtool: Problem while downloading pretrained models, a subtask of T29524: SAM in MITK, as Resolved.
Jul 4 2023, 11:23 PM · Moved to git.dkfz.de, MITK
a178n claimed T30146: SAMtool: Problem while downloading pretrained models.
Jul 4 2023, 11:23 PM · MITK (v2023.12)
a178n updated the task description for T30150: Decommission current nnUNet(v1) tool?.
Jul 4 2023, 11:20 PM · Request for Discussion, MITK (v2023.12)
a178n triaged T30150: Decommission current nnUNet(v1) tool? as Normal priority.
Jul 4 2023, 11:07 PM · Request for Discussion, MITK (v2023.12)
a178n closed T29294: Extend &/or Test nnUnet(v2) on Windows as Resolved.

Fabian has reported than nnUNet(v2) python codebase can run to Windows.

Jul 4 2023, 11:00 PM · MITK (v2023.12), Request for Discussion
a178n closed T29294: Extend &/or Test nnUnet(v2) on Windows , a subtask of T29275: Test new nnUNet(v2) python codebase with MITK, as Resolved.
Jul 4 2023, 11:00 PM · Moved to git.dkfz.de, MITK (v2024.12)
a178n triaged T30149: nnUNet(v2) in MITK as Normal priority.
Jul 4 2023, 10:57 PM · Moved to git.dkfz.de, MITK (v2024.12)
a178n added a comment to T29130: [WorkBench] Segmentation fault when "Close Project" is invoked and QmitkDataStorageComboBox widget is in UI.

yes, issue exists the last time I tested.

Jul 4 2023, 9:54 PM · Moved to git.dkfz.de, MITK
s434n moved T27284: [Image Statistic] Histogram is only supported with one image and <=1 ROI from Backlog to Cycle on the MITK (v2023.12) board.
Jul 4 2023, 5:37 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n moved T29302: Movie maker plugin does not work correctly with the new mxn multi widget from Backlog to Cycle on the MITK (v2023.12) board.
Jul 4 2023, 5:27 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n moved T29579: [Documentation] Help page of Pointset Interaction has no table of contents from Backlog to Cycle on the MITK (v2023.12) board.
Jul 4 2023, 5:26 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
s434n moved T29580: [Measurement] Unclear how to end drawing with some tools from Backlog to Cycle on the MITK (v2023.12) board.
Jul 4 2023, 5:26 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
floca closed T28139: [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage, a subtask of T28525: Design refactoring of LabelSetImage and associated classes, as Resolved.
Jul 4 2023, 5:22 PM · Next Milestone
floca closed T28139: [LabelSetImage] Ambigious meaning of "layer" in LabelSetImage as Resolved.

Valid. Will be /is regarded in the refactoring.

Jul 4 2023, 5:22 PM · MITK (v2023.12), Request for Discussion