Page MenuHomePhabricator
Feed All Stories

Aug 1 2023

gaoh added a comment to T30148: MITK FlowBench v2023.04 - crashes on "Accept segmentation".

Ok, since this issue made it impossible to use v2023.04 in Kaapaana mitk-flow, I am still on the previous release, where it kind of works?
So I would stay on this previous release until there is a new MITK version addressing these DICOM issues.
For now we are highly dependent on dicoms, so we don't have the option to just store the files in another file format...

Aug 1 2023, 5:10 PM · MITK (v2023.12)
kislinsk added a comment to T30176: [Segmentation Task List] Improve task selection for long task lists.

Pushed new branch to rMITK MITK: feature/T30176-FindTask.

Aug 1 2023, 4:50 PM · MITK
kislinsk added a comment to T29650: mitk-flow " Please reinitialize the selected segmentation image!" problem.

I just did the Pic3D/brain test mentioned above and it works with v2023.04.

Aug 1 2023, 3:36 PM · Next Milestone, Request for Discussion, MITK
kislinsk closed T30148: MITK FlowBench v2023.04 - crashes on "Accept segmentation" as Wontfix.

@gaoh Since we released MITK v2023.04.2 yesterday specifically addressing a DICOM-SEG issue I kind of got an overview of the overall situation in MITK regarding saving DICOM-SEGs.

Aug 1 2023, 3:29 PM · MITK (v2023.12)
kislinsk triaged T30176: [Segmentation Task List] Improve task selection for long task lists as High priority.
Aug 1 2023, 3:15 PM · MITK
kislinsk triaged T29650: mitk-flow " Please reinitialize the selected segmentation image!" problem as Normal priority.
Aug 1 2023, 3:11 PM · Next Milestone, Request for Discussion, MITK
kislinsk added a comment to T29650: mitk-flow " Please reinitialize the selected segmentation image!" problem.

We could set up a test case to check if it is still an issue in the context of segmentation task lists. A segmentation task list with two tasks, one task referencing Pic3D.nrrd, the other task referencing the tilted brain.nrrd image. If this is working with the latest release it should be a proof that is not an issue anymore.

Aug 1 2023, 3:11 PM · Next Milestone, Request for Discussion, MITK
kislinsk closed T30167: Volumetric feature calculation limited to voxels with label == 1 in MITK Radiomics as Wontfix.

Thanks for the report. We recently removed this functionality from MITK so I would like to close this task as Wontfix if you are fine with the workaround you mentioned?

Aug 1 2023, 3:04 PM · MITK
kislinsk triaged T30169: Hot keys for iterating through slices (while segmenting) as Wishlist priority.
Aug 1 2023, 3:02 PM · Moved to git.dkfz.de, Request for Discussion, MITK
s434n closed T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds as Resolved.
Aug 1 2023, 12:31 PM · MITK (v2023.12), Checklist
s434n committed rMITK2b0ed86731c2: Fix livewire crashing out of bounds (authored by s434n).
Fix livewire crashing out of bounds
Aug 1 2023, 12:31 PM
s434n committed rMITKfab339f94c12: make livewire drawing conditional on being in the correct plane (authored by s434n).
make livewire drawing conditional on being in the correct plane
Aug 1 2023, 12:31 PM
floca added a project to T29640: Verboseness in MatchPoint Algorithm Control: Missing Info.
Aug 1 2023, 12:09 PM · MITK (v2024.12), Missing Info
kislinsk added a comment to T29649: Classification Module clean up.

Deleted branch from rMITK MITK: bugfix/T29649-ClassificationModuleCleanUp.

Aug 1 2023, 11:49 AM · MITK (v2023.12), Request for Discussion
kislinsk committed rMITKe77010059eea: Remove unused stubs and files (authored by kislinsk).
Remove unused stubs and files
Aug 1 2023, 11:44 AM
kislinsk committed rMITKfd7b28e57261: Remove classification plugins (authored by kislinsk).
Remove classification plugins
Aug 1 2023, 11:44 AM
kislinsk committed rMITKf91d514bd007: Remove abandoned command-line apps (authored by kislinsk).
Remove abandoned command-line apps
Aug 1 2023, 11:44 AM
kislinsk committed rMITK9ed9e1dd2da0: Remove abandoned modules (authored by kislinsk).
Remove abandoned modules
Aug 1 2023, 11:44 AM
kislinsk committed rMITK897ce8f134c5: Remove Vigra as third-party dependency (authored by kislinsk).
Remove Vigra as third-party dependency
Aug 1 2023, 11:44 AM
kislinsk committed rMITK9211eb4366e7: Remove broken build configurations and whitelists (authored by kislinsk).
Remove broken build configurations and whitelists
Aug 1 2023, 11:44 AM
kislinsk committed rMITKfbcfd9071d9c: Remove dangling references from documentation (authored by kislinsk).
Remove dangling references from documentation
Aug 1 2023, 11:44 AM
kislinsk committed rMITKe42874b1722a: Clean up Classification module and plugins (authored by kislinsk).
Clean up Classification module and plugins
Aug 1 2023, 11:44 AM
kislinsk closed T29649: Classification Module clean up as Resolved by committing rMITKe42874b1722a: Clean up Classification module and plugins.
Aug 1 2023, 11:44 AM · MITK (v2023.12), Request for Discussion

Jul 31 2023

floca added a comment to T29640: Verboseness in MatchPoint Algorithm Control.

@holzwart Which version of MITK and which plugin do you use?

Jul 31 2023, 8:11 PM · MITK (v2024.12), Missing Info
floca renamed T30175: [Py] UC1.4 - All images in data storage that are visible are set opacity 50% in a specific render window from [Py] UC2 - All images in data storage that are visible are set opacity 50% in a specific render window to [Py] UC4 - All images in data storage that are visible are set opacity 50% in a specific render window.
Jul 31 2023, 8:04 PM · Moved to git.dkfz.de, MITK
floca renamed T30175: [Py] UC1.4 - All images in data storage that are visible are set opacity 50% in a specific render window from [Py] UC2 - All images in data storage that are visible are stored to [Py] UC2 - All images in data storage that are visible are set opacity 50% in a specific render window.
Jul 31 2023, 8:04 PM · Moved to git.dkfz.de, MITK
floca created T30175: [Py] UC1.4 - All images in data storage that are visible are set opacity 50% in a specific render window.
Jul 31 2023, 7:56 PM · Moved to git.dkfz.de, MITK
floca updated the task description for T30173: [Py] UC1.2 - Selected image are stored.
Jul 31 2023, 7:55 PM · Moved to git.dkfz.de, MITK
floca renamed T30173: [Py] UC1.2 - Selected image are stored from [Py] Selected image are stored to [Py] UC2 - Selected image are stored.
Jul 31 2023, 7:47 PM · Moved to git.dkfz.de, MITK
floca created T30174: [Py] UC1.3 - Selected image can be manipulated with simpleITK and added to data storage.
Jul 31 2023, 7:46 PM · Moved to git.dkfz.de, MITK
floca renamed T30172: [Py] UC1.1 - Selected image can be manipulated with simpleITK and updated from [Py] Selected image can be manipulated with simpleITK and updated to [Py] UC1 - Selected image can be manipulated with simpleITK and updated.
Jul 31 2023, 7:44 PM · Moved to git.dkfz.de, MITK
floca renamed T30173: [Py] UC1.2 - Selected image are stored from [Py] Selected image and stored. to [Py] Selected image are stored.
Jul 31 2023, 7:34 PM · Moved to git.dkfz.de, MITK
floca created T30173: [Py] UC1.2 - Selected image are stored.
Jul 31 2023, 7:34 PM · Moved to git.dkfz.de, MITK
floca created T30172: [Py] UC1.1 - Selected image can be manipulated with simpleITK and updated.
Jul 31 2023, 7:30 PM · Moved to git.dkfz.de, MITK
floca created T30171: [Py] View to execute scripts that interact with the rest of the workbench.
Jul 31 2023, 7:09 PM · Moved to git.dkfz.de, MITK
floca updated the task description for T30170: [Py] Python in MITK.
Jul 31 2023, 7:03 PM · Moved to git.dkfz.de, MITK
floca added a parent task for T27923: Integrate possibility to execute Python Code in MITK : T30170: [Py] Python in MITK.
Jul 31 2023, 7:02 PM · MITK
floca added a subtask for T30170: [Py] Python in MITK: T27923: Integrate possibility to execute Python Code in MITK .
Jul 31 2023, 7:02 PM · Moved to git.dkfz.de, MITK
floca created T30170: [Py] Python in MITK.
Jul 31 2023, 7:02 PM · Moved to git.dkfz.de, MITK
floca created T30169: Hot keys for iterating through slices (while segmenting).
Jul 31 2023, 4:17 PM · Moved to git.dkfz.de, Request for Discussion, MITK
kislinsk updated subscribers of T29640: Verboseness in MatchPoint Algorithm Control.
Jul 31 2023, 2:41 PM · MITK (v2024.12), Missing Info
kislinsk added a comment to T30163: MITK v2023.04.2.

The tag v2023.04.2 was created on the branch hotfix/T30163-v2023.04.2, which should not be deleted.

Jul 31 2023, 12:28 PM · MITK
kislinsk closed T30163: MITK v2023.04.2 as Resolved.
Jul 31 2023, 12:26 PM · MITK
kislinsk edited the content of Changelog.
Jul 31 2023, 12:16 PM · MITK
kislinsk edited the content of MITK v2023.04.2.
Jul 31 2023, 12:14 PM
kislinsk edited the content of MITK v2023.04.
Jul 31 2023, 11:14 AM
kislinsk deleted MITK v2023.04.2.
Jul 31 2023, 10:26 AM
kislinsk created an object: MITK v2023.04.2.
Jul 31 2023, 10:24 AM

Jul 28 2023

floca triaged T30168: Fail to load NIFTI images due to error "itk only supports orthonormal direction cosines" as Normal priority.
Jul 28 2023, 4:57 PM · Moved to git.dkfz.de, MITK

Jul 27 2023

j824d created T30167: Volumetric feature calculation limited to voxels with label == 1 in MITK Radiomics .
Jul 27 2023, 2:19 PM · MITK

Jul 26 2023

s434n committed rRTTB882fec8538c7: Fix the fix of namespaces for ITK v5.3.0 (authored by s434n).
Fix the fix of namespaces for ITK v5.3.0
Jul 26 2023, 4:34 PM
kislinsk added a revision to T29649: Classification Module clean up: Unknown Object (Differential Revision).
Jul 26 2023, 3:42 PM · MITK (v2023.12), Request for Discussion
kislinsk added a comment to T29649: Classification Module clean up.

Pushed new branch to rMITK MITK: bugfix/T29649-ClassificationModuleCleanUp.

Jul 26 2023, 3:38 PM · MITK (v2023.12), Request for Discussion
kislinsk claimed T29649: Classification Module clean up.
Jul 26 2023, 1:29 PM · MITK (v2023.12), Request for Discussion
a178n added a comment to T28181: [Segmentation] Should warning messages be passed on to the UI?.

It's agreed in the meeting that the status quo is inconsistent.

Jul 26 2023, 12:17 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n closed T28548: Allow Zooming during creation of Segmentation. as Resolved.

With the addition of the polygon tool, this is now possible.

Jul 26 2023, 12:05 PM · MITK (v2023.12), Request for Discussion
s434n triaged T30166: [Logging] Introduce filtering by level as Low priority.
Jul 26 2023, 12:03 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca added a comment to T29631: Integration of an updated Feature Branch.

@goetzm Thank you for the patch. We will look into it and merge it for parts that we keep (see T29649). If change your mind and want to maintain the rest of the classification code base in an extension, we can revisit it and see how we can help with merging the rest. Best Ralf

Jul 26 2023, 12:01 PM · MITK
a178n lowered the priority of T28181: [Segmentation] Should warning messages be passed on to the UI? from Normal to Low.
Jul 26 2023, 12:00 PM · Moved to git.dkfz.de, MITK (v2024.12)
a178n added a subtask for T29649: Classification Module clean up: T29631: Integration of an updated Feature Branch.
Jul 26 2023, 11:50 AM · MITK (v2023.12), Request for Discussion
a178n added a parent task for T29631: Integration of an updated Feature Branch: T29649: Classification Module clean up.
Jul 26 2023, 11:50 AM · MITK
a178n removed a project from T29631: Integration of an updated Feature Branch: Request for Discussion.
Jul 26 2023, 11:50 AM · MITK
a178n updated the task description for T29649: Classification Module clean up.
Jul 26 2023, 11:44 AM · MITK (v2023.12), Request for Discussion
a178n updated the task description for T29649: Classification Module clean up.
Jul 26 2023, 11:42 AM · MITK (v2023.12), Request for Discussion
s434n moved T29369: [Segmentation Utilities] Handle / select different labels independently from Backlog to MITK Meeting on the Request for Discussion board.
Jul 26 2023, 10:32 AM · MITK (v2024.06)

Jul 25 2023

a178n added a comment to T30164: [Segmentation] [Bug] 2D RGB image not correctly handled by SegPreviewTool API tool.

Yes, after commenting the 4 lines in the mitkExtractSliceFilter I am getting 3 component image.
Also, found out that the following works instead of commenting the snippet out:
Comment vectorComponentExtractor->SetComponents(m_Component); and pass on exact component needed to vectorComponentExtractor->SetComponents(0,1,2);.

Jul 25 2023, 3:26 PM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion
floca added a comment to T30164: [Segmentation] [Bug] 2D RGB image not correctly handled by SegPreviewTool API tool.

Your "solution" is not a real fix. It just exploits a bug/undefined behavior. So do not do it

Jul 25 2023, 1:59 PM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion
a178n edited projects for T29485: TotalSegmentator User Testing , added: MITK; removed MITK (v2023.12).
Jul 25 2023, 11:53 AM · Moved to git.dkfz.de, MITK
a178n lowered the priority of T29485: TotalSegmentator User Testing from High to Normal.
Jul 25 2023, 11:53 AM · Moved to git.dkfz.de, MITK
a178n closed T29569: [Checklist] Update TotalSegmentator & nnUNet checklist, a subtask of T29437: [SEG] Add TotalSegmentator, as Resolved.
Jul 25 2023, 11:46 AM · MITK
a178n closed T29569: [Checklist] Update TotalSegmentator & nnUNet checklist as Resolved.

Checklists updated

Jul 25 2023, 11:46 AM · MITK (v2023.12), Checklist
kompan committed rMD4f5120fc1b12: Add Two Tissue Compartment Model test JSON files. (authored by kompan).
Add Two Tissue Compartment Model test JSON files.
Jul 25 2023, 10:54 AM
kompan committed rMDeb9f74fddea0: Add Two Tissue Compartment FDG Model test JSON files. (authored by kompan).
Add Two Tissue Compartment FDG Model test JSON files.
Jul 25 2023, 10:54 AM
kompan committed rMD9e585717f17d: Add One Tissue Compartment Model test JSON files. (authored by kompan).
Add One Tissue Compartment Model test JSON files.
Jul 25 2023, 10:54 AM
kompan committed rMD9fb48d04a148: Add Extended One Tissue Compartment Model test JSON files. (authored by kompan).
Add Extended One Tissue Compartment Model test JSON files.
Jul 25 2023, 10:54 AM
a178n added a comment to T30164: [Segmentation] [Bug] 2D RGB image not correctly handled by SegPreviewTool API tool.

Oh ok. Yes, I can the see the pixel type "rgb". Also, when I save the mitk::Image object using IOUtils::Save, I can see (in python) that the written image is 3 channel.
But the issue still occurs, channel is information is ultimately lost here in mitk::SegWithPreviewTool::UpdatePreview:

Jul 25 2023, 10:20 AM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion
s434n claimed T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus.
Jul 25 2023, 9:14 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n closed T30162: [Interpolation] [Documentation] Update interpolation documentation regarding multilabel support as Resolved.
Jul 25 2023, 9:14 AM · MITK (v2023.12)
s434n committed rMITKe7a6ceb95e8d: Update interpolation documentation & fix some typos (authored by s434n).
Update interpolation documentation & fix some typos
Jul 25 2023, 9:14 AM
s434n committed rMITK059a81c9379b: remove outdated warning about multiple labels from interpolation docu & some… (authored by s434n).
remove outdated warning about multiple labels from interpolation docu & some…
Jul 25 2023, 9:14 AM

Jul 24 2023

floca added a comment to T30164: [Segmentation] [Bug] 2D RGB image not correctly handled by SegPreviewTool API tool.

Be carefull. RGB channels of an RGB image are not stored in different mitk::Image channels currently. Every thing is stored in one channel. But the channel has the pixel type "rgba". So the channels are encoded in each pixel.

Jul 24 2023, 2:24 PM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion
a178n added a comment to T30164: [Segmentation] [Bug] 2D RGB image not correctly handled by SegPreviewTool API tool.

After a little debugging, I see that even DataNode::GetData() returns single channel Image.
eg. dynamic_cast<const Image *>(m_SegmentationInputNode->GetData())
SegPreviewTool class uses this image for further processing.

Jul 24 2023, 2:08 PM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion

Jul 22 2023

a178n claimed T30153: SAM tool: Add caching support for Cross-hair rotated image views.
Jul 22 2023, 12:47 AM · MITK (v2023.12)
a178n claimed T30156: Level Window contrast effect in SAM tool.
Jul 22 2023, 12:47 AM · MITK (v2023.12)

Jul 20 2023

a178n closed T30156: Level Window contrast effect in SAM tool as Resolved.
Jul 20 2023, 1:04 PM · MITK (v2023.12)
a178n closed T30156: Level Window contrast effect in SAM tool, a subtask of T29524: SAM in MITK, as Resolved.
Jul 20 2023, 1:04 PM · Moved to git.dkfz.de, MITK
a178n added a comment to T30156: Level Window contrast effect in SAM tool.

Anyway after discussing with Ralf, the problem at hand - implementing levelwindow effect of input images to SAM, is solved using itk::IntensityWindowingImageFilter.

Jul 20 2023, 1:04 PM · MITK (v2023.12)
a178n created T30164: [Segmentation] [Bug] 2D RGB image not correctly handled by SegPreviewTool API tool.
Jul 20 2023, 10:43 AM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion

Jul 19 2023

a178n moved T29645: Test Plan for SAM from Backlog to Cycle on the MITK (v2023.12) board.
Jul 19 2023, 11:43 AM · MITK (v2023.12)
a178n edited projects for T29645: Test Plan for SAM, added: MITK (v2023.12); removed MITK.
Jul 19 2023, 11:40 AM · MITK (v2023.12)
a178n added a comment to T29645: Test Plan for SAM.

Updated document: https://hub.dkfz.de/f/55254009

Jul 19 2023, 11:39 AM · MITK (v2023.12)
a178n added a project to T29596: Move out FAST checkbox from Advanced: Request for Discussion.
Jul 19 2023, 11:36 AM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion, Checklist
a178n moved T29540: SAM as 2D tool in MITK from Cycle to Segmentation on the MITK (v2023.12) board.
Jul 19 2023, 10:34 AM · MITK (v2024.06)
a178n moved T29604: SAM as 2D Tool in MITK- iteration 2 from Segmentation to Cycle on the MITK (v2023.12) board.
Jul 19 2023, 10:34 AM · MITK (v2024.06)
a178n moved T29644: Doxygen documentation for SAM from Backlog to Cycle on the MITK (v2023.12) board.
Jul 19 2023, 10:31 AM · MITK (v2023.12)

Jul 18 2023

a178n added a comment to T30156: Level Window contrast effect in SAM tool.
  1. I am seeing the array in python after writing it out IOUtil::Save(mitkImage, imagePath);. That's 4 channel image. ie. 32x32x4.
  2. I use vtkMitkLevelWindowFilter because you recommended(?) and also its used by MITK for its levelwindow processing and at few other occasions. So this data type change is widely affecting MITK. But whether its compensated somewhere else or not is not clear for me.

But for SAM tool- Thanks for the tip, I will try out vtkImageMapToColors and see.

Jul 18 2023, 4:26 PM · MITK (v2023.12)
kislinsk added a comment to T30156: Level Window contrast effect in SAM tool.

You seem to mix a few things here.

Jul 18 2023, 4:05 PM · MITK (v2023.12)
a178n added a comment to T30156: Level Window contrast effect in SAM tool.

Hi,
I finally could apply levelwindow Filter on image successfully for SAM tool.
But that seems to opened up another can of worms 😅 (?)
The vtkMitkLevelWindowFilter gives me 2D 4 channel image. But the channels are duplicate. I verified using numpy/python. Presumably. I can just take out one channel slice and that should be it.
But I observe somethings not correct:

  1. I convert vtk image to mitk image using the following syntax:
Jul 18 2023, 3:10 PM · MITK (v2023.12)

Jul 17 2023

s434n claimed T29591: [Segmentation] [Live Wire] Multiple reports of a crash due to image access out of bounds.
Jul 17 2023, 11:51 AM · MITK (v2023.12), Checklist
kislinsk added a comment to T30163: MITK v2023.04.2.

Pushed new branch to rMITK MITK: hotfix/T30163-v2023.04.2.

Jul 17 2023, 10:44 AM · MITK