Page MenuHomePhabricator
Feed All Stories

Jun 19 2020

nolden edited projects for T27483: DICOM import of multi-channel data not working, added: MITK (v2021.02); removed MITK.
Jun 19 2020, 11:26 AM · MITK (v2021.02), Restricted Project, DICOM
kalali moved T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0 from Backlog to MITK Meeting on the Request for Discussion board.
Jun 19 2020, 11:01 AM · MITK (v2021.02)
thomass claimed T26974: [Segmentation] Region Growing 3D with 4D dataset not working.
Jun 19 2020, 9:49 AM · MITK (v2021.02)
neher triaged T27487: Multi-slice screenshots as Wishlist priority.
Jun 19 2020, 8:46 AM · Auto-closed, MITK

Jun 18 2020

kislinsk added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

Placeholder for external project updates, minimum CMake version, and Qt version

Jun 18 2020, 11:16 PM · MITK (v2021.02)
kislinsk added a comment to T27486: Prepare changelog and migration guide for upcoming master merge.

I went through all Noteworthy tasks of the list above and summarized the ones were I was assigned (we should split it later into API changes and other noteworthy features):

Jun 18 2020, 11:10 PM · MITK (v2021.02)
kislinsk updated the task description for T27486: Prepare changelog and migration guide for upcoming master merge.
Jun 18 2020, 11:07 PM · MITK (v2021.02)
kislinsk triaged T27486: Prepare changelog and migration guide for upcoming master merge as High priority.
Jun 18 2020, 11:07 PM · MITK (v2021.02)
kislinsk triaged T27377: Suppress or fix all build warnings as Normal priority.
Jun 18 2020, 11:04 PM · MITK (v2024.06), Restricted Project
kislinsk removed a project from T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed: Noteworthy.
Jun 18 2020, 11:03 PM · Cleared, MITK (v2021.02)
floca closed T27468: Allow selection of cropped segmentations in the statistics view as Resolved.
Jun 18 2020, 7:38 PM · MITK (v2021.02)
floca closed T27468: Allow selection of cropped segmentations in the statistics view, a subtask of T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid, as Resolved.
Jun 18 2020, 7:38 PM · Auto-closed, MITK
kalali triaged T27485: Refactor PointSet Interaction plugin to use the new node selection widgets as High priority.
Jun 18 2020, 3:11 PM · MITK (v2021.02)
floca committed rMITK1cf33a463ff7: Segmentation views and statistic views support sub geometries for masks (again) (authored by floca).
Segmentation views and statistic views support sub geometries for masks (again)
Jun 18 2020, 3:07 PM
floca committed rMITK7a9970c3d819: Fixed reviewer remarks (authored by floca).
Fixed reviewer remarks
Jun 18 2020, 3:07 PM
floca committed rMITKcdaeb282cfa4: Fixed gcc error unused variable (authored by floca).
Fixed gcc error unused variable
Jun 18 2020, 3:07 PM
floca committed rMITK5dcbe97689cf: Fixed gcc error and added test for NodePredicateSubGeometry (authored by floca).
Fixed gcc error and added test for NodePredicateSubGeometry
Jun 18 2020, 3:07 PM
floca committed rMITK662e45c18578: Fixed T27488 (authored by floca).
Fixed T27488
Jun 18 2020, 3:07 PM
floca committed rMITKb57719b8a6a2: Fixed errors/warnings in statistics view (authored by floca).
Fixed errors/warnings in statistics view
Jun 18 2020, 3:07 PM
floca committed rMITK213a7ccfdcb0: Fixed T27467 (authored by floca).
Fixed T27467
Jun 18 2020, 3:07 PM
floca committed rMITKf0b1443d965b: Fixed T27466 (authored by floca).
Fixed T27466
Jun 18 2020, 3:07 PM
floca closed T27467: Allow selection of cropped segmentations in the segmentation views, a subtask of T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid, as Resolved.
Jun 18 2020, 3:07 PM · Auto-closed, MITK
floca closed T27467: Allow selection of cropped segmentations in the segmentation views as Resolved by committing rMITK213a7ccfdcb0: Fixed T27467.
Jun 18 2020, 3:07 PM · MITK (v2021.02)
floca closed T27466: Subgeometry NodePredicate, a subtask of T27468: Allow selection of cropped segmentations in the statistics view, as Resolved.
Jun 18 2020, 3:07 PM · MITK (v2021.02)
floca closed T27466: Subgeometry NodePredicate, a subtask of T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid, as Resolved.
Jun 18 2020, 3:07 PM · Auto-closed, MITK
floca closed T27466: Subgeometry NodePredicate, a subtask of T27467: Allow selection of cropped segmentations in the segmentation views, as Resolved.
Jun 18 2020, 3:07 PM · MITK (v2021.02)
floca closed T27466: Subgeometry NodePredicate as Resolved by committing rMITKf0b1443d965b: Fixed T27466.
Jun 18 2020, 3:07 PM · MITK (v2021.02)
kalali added a revision to T25753: Some refactoring of the selection classes: Restricted Differential Revision.
Jun 18 2020, 2:52 PM · MITK
neher added a revision to T26721: Prepare Qt 5.13 compatibility: Restricted Differential Revision.
Jun 18 2020, 9:38 AM · MITK
neher added a comment to T26721: Prepare Qt 5.13 compatibility.

Pushed new branch T26721-UpgradeQtVersion.

Jun 18 2020, 9:35 AM · MITK

Jun 17 2020

kislinsk committed rMITK85c89861cb84: Enable depth peeling only for 3d renderers (authored by kislinsk).
Enable depth peeling only for 3d renderers
Jun 17 2020, 11:24 PM
kislinsk committed rMITK3ad9deb24f36: Disable depth peeling if renderer type changes to 2D (authored by kislinsk).
Disable depth peeling if renderer type changes to 2D
Jun 17 2020, 11:24 PM
kislinsk closed T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed as Resolved by committing rMITK85c89861cb84: Enable depth peeling only for 3d renderers.
Jun 17 2020, 11:24 PM · Cleared, MITK (v2021.02)
kislinsk committed rMITK44982e574823: Enable depth peeling only for 3d renderers (authored by kislinsk).
Enable depth peeling only for 3d renderers
Jun 17 2020, 11:24 PM
floca added a project to T27459: [Perfusion] Use PropertyReleationRules for referencing between input image and parameter maps: Noteworthy.

Noteworthy as it containes BREAKING CHANGES for some ModelFit dependent modules and plugins.

Jun 17 2020, 11:03 PM · Breaking Change, MITK (v2021.02)
floca added a revision to T26142: Property persistence for property relation instance identifing (RII) properties: Restricted Differential Revision.
Jun 17 2020, 11:01 PM · Cleared, MITK (v2021.02)
floca added a revision to T27459: [Perfusion] Use PropertyReleationRules for referencing between input image and parameter maps: Restricted Differential Revision.
Jun 17 2020, 11:01 PM · Breaking Change, MITK (v2021.02)
nolden added projects to T27483: DICOM import of multi-channel data not working: DICOM, Restricted Project.
Jun 17 2020, 8:18 PM · MITK (v2021.02), Restricted Project, DICOM
norajitr added a project to T27483: DICOM import of multi-channel data not working: Request for Discussion.
Jun 17 2020, 8:00 PM · MITK (v2021.02), Restricted Project, DICOM
norajitr added a comment to T27483: DICOM import of multi-channel data not working.

A current blocker for use of NAKO data, therefore set as high priority.

Jun 17 2020, 7:50 PM · MITK (v2021.02), Restricted Project, DICOM
norajitr added a comment to T27483: DICOM import of multi-channel data not working.

DICOM_import_problem_2.png (1×1 px, 1 MB)
Issue as shown in the attachment

Jun 17 2020, 7:49 PM · MITK (v2021.02), Restricted Project, DICOM
norajitr triaged T27483: DICOM import of multi-channel data not working as High priority.
Jun 17 2020, 7:46 PM · MITK (v2021.02), Restricted Project, DICOM
floca claimed T26142: Property persistence for property relation instance identifing (RII) properties.
Jun 17 2020, 6:30 PM · Cleared, MITK (v2021.02)
floca added a comment to T24775: Refactor plugins to use the new node selection widgets.

Priority high for all plugins that are part of the release (see table above).

Jun 17 2020, 6:29 PM · MITK, Restricted Project, Cleared
floca raised the priority of T24775: Refactor plugins to use the new node selection widgets from Normal to High.
Jun 17 2020, 6:28 PM · MITK, Restricted Project, Cleared
kislinsk added a revision to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed: Unknown Object (Differential Revision).
Jun 17 2020, 4:33 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed.

I think I found a nice solution. Depth peeling is set per renderer, not for the whole application. So it makes sense to activate it only for 3d renders. Side effect: probably speeds up rendering a little bit.

Jun 17 2020, 4:29 PM · Cleared, MITK (v2021.02)
floca moved T27464: [CEST] Generic CEST data reader from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jun 17 2020, 11:01 AM · Restricted Project, MITK (v2021.02)
floca edited projects for T24775: Refactor plugins to use the new node selection widgets, added: MITK (v2021.02); removed MITK.
Jun 17 2020, 10:59 AM · MITK, Restricted Project, Cleared
floca claimed T27459: [Perfusion] Use PropertyReleationRules for referencing between input image and parameter maps.
Jun 17 2020, 10:45 AM · Breaking Change, MITK (v2021.02)
kislinsk edited projects for T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion , added: Cleared; removed Missing Info.
Jun 17 2020, 10:38 AM · Cleared, MITK (v2021.02)
kislinsk updated the task description for T27462: Workbench crashes when loading multiple 3D+t datasets.
Jun 17 2020, 10:30 AM · MITK (v2021.02)
kislinsk added a comment to T27460: Badge support for our CDash/CI infrastructure.

Blocked by the fact that e071-jenkins is not yet reachable from outside.

Jun 17 2020, 9:42 AM · CI, MITK
kislinsk closed T27482: New Warnings/errors with Visual Studio 2019 version 16.6 as Resolved.
Jun 17 2020, 9:38 AM · MITK (v2021.02)
kislinsk committed rMITK517a7de4e260: Fix Visual Studio 2019 v16.6 compiler warnings/errors (authored by kislinsk).
Fix Visual Studio 2019 v16.6 compiler warnings/errors
Jun 17 2020, 9:37 AM
kislinsk committed rMITK5e75dcd741cf: Fix Visual Studio 2019 v16.6 compiler warnings/errors (authored by kislinsk).
Fix Visual Studio 2019 v16.6 compiler warnings/errors
Jun 17 2020, 9:37 AM

Jun 16 2020

kislinsk added a revision to T27482: New Warnings/errors with Visual Studio 2019 version 16.6: Unknown Object (Differential Revision).
Jun 16 2020, 4:59 PM · MITK (v2021.02)
kislinsk renamed T27482: New Warnings/errors with Visual Studio 2019 version 16.6 from PythonQt cannot be used without warnings in Visual Studio 2019 version 16.6 to New Warnings/errors with Visual Studio 2019 version 16.6.
Jun 16 2020, 4:38 PM · MITK (v2021.02)
kislinsk renamed T27482: New Warnings/errors with Visual Studio 2019 version 16.6 from PythonQt cannot be used without warnings with Visual Studio 2019 version 16.6 to PythonQt cannot be used without warnings in Visual Studio 2019 version 16.6.
Jun 16 2020, 4:22 PM · MITK (v2021.02)
kislinsk updated the task description for T27482: New Warnings/errors with Visual Studio 2019 version 16.6.
Jun 16 2020, 4:22 PM · MITK (v2021.02)
kislinsk triaged T27482: New Warnings/errors with Visual Studio 2019 version 16.6 as Normal priority.
Jun 16 2020, 4:17 PM · MITK (v2021.02)
sharonYu added a comment to T27432: Error loading DCE-MRI DICOM image.

I am sorry for being late reply.

Jun 16 2020, 3:47 PM · MITK, DICOM, Cleared
floca added a comment to T27464: [CEST] Generic CEST data reader.

Testing is postponed/moved into T27481. Waiting for test data that can be put into mitk-data.git.

Jun 16 2020, 3:07 PM · Restricted Project, MITK (v2021.02)
floca triaged T27481: [CEST] Add unit test for CESTGenericReader service as Normal priority.
Jun 16 2020, 3:04 PM · Auto-closed, Restricted Project, Restricted Project, MITK
kalali claimed T27389: Running tutorial's Step8 gives Segmentation Fault!.

I can reproduce the error. There was a change in the StdMultiWidget so we have to adapt the tutorial. A specific initialization-method was added, so we need to call InitializeMultiWidget before accessing the render windows (which does some things for us so we can remove some lines from the tutorial).
The level window slider was removed from the StdMultiWidget and needs to be added additionally.

Jun 16 2020, 1:23 PM · MITK (2018-04)
kalali moved T22838: Provide Jenkinsfile for CI from Backlog to Done on the CI board.
Jun 16 2020, 12:12 PM · CI, Restricted Project, MITK
kalali moved T27188: [ImageStatistics] mitkImageStatisticsCalculatorTest fails on some platforms from Backlog to Done on the CI board.
Jun 16 2020, 12:10 PM · Cleared, MITK (v2021.02), Restricted Project, CI
floca added a comment to T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion .

I used a master that was three weeks old, I will double check on the current develop

Jun 16 2020, 11:10 AM · Cleared, MITK (v2021.02)
thomass added a comment to T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion .

I used a master that was three weeks old, I will double check on the current develop

Jun 16 2020, 10:17 AM · Cleared, MITK (v2021.02)

Jun 15 2020

floca added a project to T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion : Missing Info.

@thomass Have you used a current build of develop. Currently, if not set by the user in the preferences, it always selects the first tab. "Favorite node list" is never the first tab in the dialog, because the special dialogs (favorite and history) are always added last.

Jun 15 2020, 9:39 PM · Cleared, MITK (v2021.02)
kislinsk closed T27425: Add more configurations to .arcconfig as Resolved.
Jun 15 2020, 5:11 PM · MITK
m167k added a member for Deep Learning: sxiao.
Jun 15 2020, 3:54 PM
m167k added a member for MIC: sxiao.
Jun 15 2020, 3:53 PM
floca committed rMITK7a9446c8d4e2: T24302 - persist ID of Identifiable (authored by floca).
T24302 - persist ID of Identifiable
Jun 15 2020, 1:23 PM
floca committed rMITK6f77474e0780: BREAKING. Fixed review remarks. (authored by floca).
BREAKING. Fixed review remarks.
Jun 15 2020, 1:23 PM
floca committed rMITKbf3c553ec3c4: Added support for Identifiable UID in MAPRegistrationWrapper(IO) (authored by floca).
Added support for Identifiable UID in MAPRegistrationWrapper(IO)
Jun 15 2020, 1:23 PM
floca committed rMITK88d7f656e5c1: Added UID serialization support for scene serialization (authored by floca).
Added UID serialization support for scene serialization
Jun 15 2020, 1:23 PM
floca committed rMITKb2fa1a668385: Added UID serialization support for LabelSetImageIO (authored by floca).
Added UID serialization support for LabelSetImageIO
Jun 15 2020, 1:23 PM
floca closed T24302: Should we persiste the ID of Identifiable when loading/saving BaseDatas? as Resolved by committing rMITKbf3c553ec3c4: Added support for Identifiable UID in MAPRegistrationWrapper(IO).
Jun 15 2020, 1:23 PM · Noteworthy, MITK (v2021.02)
floca closed T24302: Should we persiste the ID of Identifiable when loading/saving BaseDatas?, a subtask of T23721: Project "Astonishing Angelfish", as Resolved.
Jun 15 2020, 1:23 PM · Request for Discussion, MITK (v2022.10)
floca closed T24302: Should we persiste the ID of Identifiable when loading/saving BaseDatas?, a subtask of T27459: [Perfusion] Use PropertyReleationRules for referencing between input image and parameter maps, as Resolved.
Jun 15 2020, 1:23 PM · Breaking Change, MITK (v2021.02)
floca committed rMITK3a0148329867: Added UID serialization support for ItkImageIO (authored by floca).
Added UID serialization support for ItkImageIO
Jun 15 2020, 1:23 PM
floca committed rMITK54790aa7c230: Added more information according the persistance of mitk::Identifiable UIDs. (authored by floca).
Added more information according the persistance of mitk::Identifiable UIDs.
Jun 15 2020, 1:23 PM
kislinsk added a comment to T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services.

This is also already on the TODO list of the packaging rewrite.

Jun 15 2020, 12:23 PM · Restricted Project, CSI-HD, MITK
kislinsk added a parent task for T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services: T27196: Rewrite packaging of MITK.
Jun 15 2020, 12:23 PM · Restricted Project, CSI-HD, MITK
kislinsk added a subtask for T27196: Rewrite packaging of MITK: T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services.
Jun 15 2020, 12:23 PM · MITK (v2024.06), Cleared
kislinsk added a comment to T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services.

@nolden https://github.com/NVIDIA/ai-assisted-annotation-client/issues/57

Jun 15 2020, 12:22 PM · Restricted Project, CSI-HD, MITK
kalali added a project to T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0: Request for Discussion.
Jun 15 2020, 11:52 AM · MITK (v2021.02)
nolden removed a project from T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services: Auto-closed.
Jun 15 2020, 11:12 AM · Restricted Project, CSI-HD, MITK
nolden renamed T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services from Xnat Plugin: How to deal with openSSL dependency to Ensure openSSL availability for MITK installers using XNAT plugin or other REST services.
Jun 15 2020, 11:06 AM · Restricted Project, CSI-HD, MITK
nolden reopened T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services, a subtask of T23301: XNAT improvements, as Open.
Jun 15 2020, 11:05 AM · Auto-closed, MITK
nolden reopened T23249: Ensure openSSL availability for MITK installers using XNAT plugin or other REST services as "Open".

I am re-opening this since I think this will also become more relevant with the foreseeable use of other REST APIs from MITK , e.g. how did the nvidia segmentation tool resolve this issue for the windows installer? @kislinsk could you comment?

Jun 15 2020, 11:05 AM · Restricted Project, CSI-HD, MITK
floca closed T14333: Improve mitk::UIDGenerator as Resolved.

T23741 introduced the useage of boost::uuid as internal implementation of UIDGenerator.

Jun 15 2020, 10:42 AM · Bugzilla, MITK
floca added a comment to T23741: Specify default UID generation method.
Jun 15 2020, 10:42 AM · MITK (v2021.02), Noteworthy
kislinsk added a project to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed: Noteworthy.

It's depth peeling and it is not solved with VTK 9. I tried to narrow down the issue in a minimum VTK application but I wasn't able to reproduce it. As quite a significant amount of time already was spent here, I will probably reintroduce preferences to disable/enable depth peeling and declare this issue as a known issue.

Jun 15 2020, 10:26 AM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27461: Update MITK to use VTK 9.

Fixed a bug where images appeared brighter as they should as soon as the 3d renderer rendered its first image. Only thing missing now is ACVD I guess.

Jun 15 2020, 10:23 AM · Noteworthy, MITK (v2021.02)

Jun 12 2020

kalali added a comment to T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0.

We could add a check in QmitkSlicesInterpolator::SetCurrentContourListID()

Jun 12 2020, 2:36 PM · MITK (v2021.02)
kalali added a comment to T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0.

A static mask is generated in QmitkSegmentationView::CreateNewSegmentation() with

const auto refTimeGeometry = image->GetTimeGeometry();
auto newTimeGeometry = mitk::ProportionalTimeGeometry::New();
newTimeGeometry->SetFirstTimePoint(refTimeGeometry->GetMinimumTimePoint());
newTimeGeometry->SetStepDuration(refTimeGeometry->GetMaximumTimePoint() - refTimeGeometry->GetMinimumTimePoint());
Jun 12 2020, 2:15 PM · MITK (v2021.02)
kalali added a comment to T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0.

mitk::ProportionalTimeGeometry::GetGeometryForTimeStep returns nullptr during
mitk::Vector3D spacing = workingNode->GetData()->GetGeometry(time_position)->GetSpacing() inside QmitkSlicesInterpolator::SetCurrentContourListID().
Obviously because IsValidTimeStep(timeStep)) for e.g. timestep = 2 is false.

Jun 12 2020, 12:57 PM · MITK (v2021.02)
kalali renamed T25825: [Segmentation] Crash using Watershed on different time steps from [Segmentation]Crash using Watershed on different time steps to [Segmentation] Crash using Watershed on different time steps.
Jun 12 2020, 12:14 PM · MITK (v2021.02)