Page MenuHomePhabricator
Feed All Stories

Jun 12 2020

kalali added a comment to T23741: Specify default UID generation method.

Can T14333: Improve mitk::UIDGenerator be closed?

Jun 12 2020, 10:44 AM · MITK (v2021.02), Noteworthy

Jun 10 2020

floca updated subscribers of T27440: [ModelFit] More efficient pixel based fitting when masks are used.

After rethinking the problem, I have come to the conclusion that there is a simplier straight forward solution that does not need to wait for ITK v5 and maybe new features.

Jun 10 2020, 10:13 PM · Auto-closed, Restricted Project, MITK
kislinsk changed the Default View Policy policy for application Diffusion from All Users to Custom Policy.
Jun 10 2020, 8:30 PM
thomass moved T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion from Backlog to Segmentation on the MITK (v2021.02) board.
Jun 10 2020, 10:52 AM · Cleared, MITK (v2021.02)
kalali updated subscribers of T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion .
Jun 10 2020, 10:48 AM · Cleared, MITK (v2021.02)
thomass triaged T27477: [Segmentation] Selection concept displays 'Favorite node list' by default leading to user confusion as High priority.
Jun 10 2020, 10:47 AM · Cleared, MITK (v2021.02)
kislinsk moved T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0 from Backlog to Segmentation on the MITK (v2021.02) board.
Jun 10 2020, 9:54 AM · MITK (v2021.02)
thomass added a comment to T25825: [Segmentation] Crash using Watershed on different time steps.
  • Works for dynamic (4D) segmentations but creates the same segmentation for all timesteps
  • Could not be reproduced for static segmentations since the workbench crashes during the creation of a static segmentation (related to T27476)
Jun 10 2020, 9:45 AM · MITK (v2021.02)
thomass added a comment to T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0.
  1. Works for timestep 0
  2. Independent from segmentation tool so might be a problem of the selection concept not the segmentation
Jun 10 2020, 9:40 AM · MITK (v2021.02)
thomass updated the task description for T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0.
Jun 10 2020, 9:36 AM · MITK (v2021.02)
thomass triaged T27476: [Segmentation] Crash if new segmentation is created with timestep different than 0 as High priority.
Jun 10 2020, 9:34 AM · MITK (v2021.02)

Jun 9 2020

eisenman committed rCHALLENGER49e1418ef12f: Show explanation of algorithm ordering only for multi-task data set (authored by eisenman).
Show explanation of algorithm ordering only for multi-task data set
Jun 9 2020, 6:14 PM
eisenman committed rCHALLENGERc4e1f3546b4f: Show title of podium plot only for multi-task data sets (authored by eisenman).
Show title of podium plot only for multi-task data sets
Jun 9 2020, 6:14 PM
eisenman committed rCHALLENGERd9becaa36315: Migrate reporting of top performing algorithms (authored by eisenman).
Migrate reporting of top performing algorithms
Jun 9 2020, 5:53 PM
eisenman committed rCHALLENGERe687c165c83d: Show task name in front of ranking list only for multi-task data sets (authored by eisenman).
Show task name in front of ranking list only for multi-task data sets
Jun 9 2020, 4:58 PM
eisenman triaged T27475: Legend of blob plot has missing legend title and algorithms as High priority.
Jun 9 2020, 3:43 PM · challengeR (v1.0)
eisenman triaged T27474: Legend of line plot has missing legend title and algorithm as High priority.
Jun 9 2020, 3:18 PM · challengeR (v1.0)
neher committed rMITKDIFF7e4105a7626b: Merge branch 'T27472-FiberStatistics' (authored by neher).
Merge branch 'T27472-FiberStatistics'
Jun 9 2020, 2:01 PM
neher committed rMITKDIFFa304c33c6e87: Updated cmdapp description (authored by neher).
Updated cmdapp description
Jun 9 2020, 2:00 PM
aguilera added a comment to T27420: report text.
  1. The spacing of the record makes that sometimes plots are shown in the following page, the formatting and the spacing should be revised.
Jun 9 2020, 1:22 PM · challengeR (v1.0)
neher closed T27472: Implement print fiber statistics cmdapp as Resolved.
Jun 9 2020, 11:30 AM · MITK Diffusion
neher committed rMITKDIFF8d2461f66b98: Merge branch 'T27472-FiberStatistics' (authored by neher).
Merge branch 'T27472-FiberStatistics'
Jun 9 2020, 10:59 AM
neher committed rMITKDIFF271ea12347d0: Add fiber statistics cmdapp (authored by neher).
Add fiber statistics cmdapp
Jun 9 2020, 10:58 AM
neher added a comment to T27472: Implement print fiber statistics cmdapp.

Pushed new branch T27472-FiberStatistics.

Jun 9 2020, 10:58 AM · MITK Diffusion
neher triaged T27472: Implement print fiber statistics cmdapp as Wishlist priority.
Jun 9 2020, 10:57 AM · MITK Diffusion
kompan added a comment to T27043: Refactor ModelFit and Pharmacokinetics plugins to use new selection concept.

@floca OK, then I will work on the Pharmacokinetics Plugins.

Jun 9 2020, 10:00 AM · Cleared, MITK (v2021.02)
floca added a comment to T27043: Refactor ModelFit and Pharmacokinetics plugins to use new selection concept.

@kompan I have some fixes for the model fit inspector view already in my stash that where done while working on other stuff. So if you do the task, best focus on the generation plugins. Thanks.

Jun 9 2020, 9:54 AM · Cleared, MITK (v2021.02)
kompan claimed T27043: Refactor ModelFit and Pharmacokinetics plugins to use new selection concept.
Jun 9 2020, 9:09 AM · Cleared, MITK (v2021.02)
kompan closed T27047: Perfusion- Conversion from signal to concentration: Rename Using T1-map as Resolved.
Jun 9 2020, 9:07 AM · Cleared, MITK (v2021.02)
kompan committed rMITK3cf5a6d0162b: Rename "Using T1 map"-related UI entries to more specific variable flip angle… (authored by kompan).
Rename "Using T1 map"-related UI entries to more specific variable flip angle…
Jun 9 2020, 8:56 AM
kompan committed rMITK258d5a9048e1: Rename "Using T1 map"-related UI entries to more specific variable flip angle… (authored by kompan).
Rename "Using T1 map"-related UI entries to more specific variable flip angle…
Jun 9 2020, 8:56 AM

Jun 8 2020

floca assigned T27047: Perfusion- Conversion from signal to concentration: Rename Using T1-map to kompan.

@kompan You forgot to claim the task. ;) Thanks for taking care.

Jun 8 2020, 8:21 PM · Cleared, MITK (v2021.02)
floca added a revision to T27468: Allow selection of cropped segmentations in the statistics view: Unknown Object (Differential Revision).
Jun 8 2020, 6:11 PM · MITK (v2021.02)
eisenman committed rCHALLENGER8c4351c0aa88: Use task name as title for blob plot when it's not added by facet wrap (authored by eisenman).
Use task name as title for blob plot when it's not added by facet wrap
Jun 8 2020, 5:29 PM
gaoh added a comment to T26974: [Segmentation] Region Growing 3D with 4D dataset not working.

@gaoh: Can you tell what you mean by dynamic mask?

Jun 8 2020, 2:55 PM · MITK (v2021.02)
thomass added a project to T26974: [Segmentation] Region Growing 3D with 4D dataset not working: Missing Info.

@gaoh: Can you tell what you mean by dynamic mask?

Jun 8 2020, 2:29 PM · MITK (v2021.02)
thomass lowered the priority of T27067: ImageCropper cannot crop some images (4d?) from High to Normal.

I will leave the task open since the handling in the respective class might need further refactoring to fully understand the behavior (as also mentioned by @kalali in the D279 review).
I remove the MITK2020 tag for now since the mentioned bug is resolved by the fix in D279.

Jun 8 2020, 2:14 PM · MITK
thomass committed rMITKae05e678acfd: <<Allow 4D image handling in Boundingshapecropper> (authored by thomass).
<<Allow 4D image handling in Boundingshapecropper>
Jun 8 2020, 2:05 PM
floca added a comment to T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid.

Task T26596 is mentioned but does not correlate with the Topic asaik...maybe transposed digits in the task number?

Jun 8 2020, 12:13 PM · Auto-closed, MITK
floca added a parent task for T27466: Subgeometry NodePredicate: T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid.
Jun 8 2020, 12:12 PM · MITK (v2021.02)
floca added subtasks for T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid: T27466: Subgeometry NodePredicate, T27467: Allow selection of cropped segmentations in the segmentation views, T27468: Allow selection of cropped segmentations in the statistics view.
Jun 8 2020, 12:12 PM · Auto-closed, MITK
floca added a parent task for T27467: Allow selection of cropped segmentations in the segmentation views: T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid.
Jun 8 2020, 12:12 PM · MITK (v2021.02)
floca added a parent task for T27468: Allow selection of cropped segmentations in the statistics view: T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid.
Jun 8 2020, 12:12 PM · MITK (v2021.02)
floca updated the task description for T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid.
Jun 8 2020, 12:11 PM · Auto-closed, MITK
thomass added a comment to T27439: [Segmentation] Support of Mask/Segmentations that are cropped / do not cover the whole image grid.

Task T26596 is mentioned but does not correlate with the Topic asaik...maybe transposed digits in the task number?

Jun 8 2020, 11:52 AM · Auto-closed, MITK

Jun 7 2020

floca added a revision to T27466: Subgeometry NodePredicate: Restricted Differential Revision.
Jun 7 2020, 7:30 PM · MITK (v2021.02)
floca added a revision to T27467: Allow selection of cropped segmentations in the segmentation views: Restricted Differential Revision.
Jun 7 2020, 7:30 PM · MITK (v2021.02)

Jun 6 2020

floca claimed T27468: Allow selection of cropped segmentations in the statistics view.
Jun 6 2020, 11:00 PM · MITK (v2021.02)
floca claimed T27466: Subgeometry NodePredicate.
Jun 6 2020, 11:00 PM · MITK (v2021.02)
floca claimed T27467: Allow selection of cropped segmentations in the segmentation views.
Jun 6 2020, 10:59 PM · MITK (v2021.02)

Jun 5 2020

floca added a comment to T27464: [CEST] Generic CEST data reader.

TODOs:

  • Testing of generic CEST reader
  • Add some sanity checks (e.g. does offset values equal the loaded image time steps)
  • Introduce 2 new CEST mime types (one high priorty that only triggers if cest_meta.json is there (because then we assume we should load like this), on norm priority mime type that only is responsible for dicoms if no cest_meta.json is there)
Jun 5 2020, 8:48 PM · Restricted Project, MITK (v2021.02)
floca claimed T27464: [CEST] Generic CEST data reader.
Jun 5 2020, 8:05 PM · Restricted Project, MITK (v2021.02)
scholzpa added a member for IMSY: dmichael.
Jun 5 2020, 2:16 PM
kompan committed rMITKb585543dbe5f: Remove errorMessageLabel and label_4. (authored by kompan).
Remove errorMessageLabel and label_4.
Jun 5 2020, 1:47 PM
kompan committed rMITKc615c144ad47: Merge branch 'T27023-MRPerfusion-ChangeTitleOfModelSelection' into develop (authored by kompan).
Merge branch 'T27023-MRPerfusion-ChangeTitleOfModelSelection' into develop
Jun 5 2020, 1:47 PM
floca added a subtask for T27468: Allow selection of cropped segmentations in the statistics view: T27466: Subgeometry NodePredicate.
Jun 5 2020, 12:34 PM · MITK (v2021.02)
floca added a parent task for T27466: Subgeometry NodePredicate: T27468: Allow selection of cropped segmentations in the statistics view.
Jun 5 2020, 12:34 PM · MITK (v2021.02)
floca moved T27468: Allow selection of cropped segmentations in the statistics view from Backlog to MaaS on the MITK (v2021.02) board.
Jun 5 2020, 12:34 PM · MITK (v2021.02)
floca triaged T27468: Allow selection of cropped segmentations in the statistics view as High priority.
Jun 5 2020, 12:34 PM · MITK (v2021.02)
floca moved T27467: Allow selection of cropped segmentations in the segmentation views from Backlog to Segmentation on the MITK (v2021.02) board.
Jun 5 2020, 12:32 PM · MITK (v2021.02)
floca added a parent task for T27466: Subgeometry NodePredicate: T27467: Allow selection of cropped segmentations in the segmentation views.
Jun 5 2020, 12:32 PM · MITK (v2021.02)
floca added a subtask for T27467: Allow selection of cropped segmentations in the segmentation views: T27466: Subgeometry NodePredicate.
Jun 5 2020, 12:32 PM · MITK (v2021.02)
floca triaged T27467: Allow selection of cropped segmentations in the segmentation views as High priority.
Jun 5 2020, 12:32 PM · MITK (v2021.02)
floca triaged T27466: Subgeometry NodePredicate as High priority.
Jun 5 2020, 12:29 PM · MITK (v2021.02)
floca removed projects from T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image: Restricted Project, Request for Discussion.

Discussion result: Stefan will have a look if he might find an easy solution ;) Otherwise skipp it.

Jun 5 2020, 12:26 PM · Cleared, MITK (v2021.02)
floca edited projects for T27442: PlanarFigure uses unmanged/uncontrolled pointer for PlaneGeometry, added: Cleared; removed Missing Info, Request for Discussion.

Discussion result: We deem it premature optimization and the unmanaged raw pointer should be removed. Get the geometry from base data and cast it where needed. If the cust does not work. Throw an exception, because it is an exceptional state.

Jun 5 2020, 12:24 PM · Cleared, MITK (v2021.02)
kislinsk committed rMD84729632176a: Add VTK 9 compatible reference screenshot (authored by kislinsk).
Add VTK 9 compatible reference screenshot
Jun 5 2020, 11:09 AM

Jun 4 2020

kislinsk closed T27046: Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsistency) as Resolved.
Jun 4 2020, 7:26 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27461: Update MITK to use VTK 9.

Status: Workbench with WorkbenchRelease configuration excluding ACVD/Remeshing starts on Windows. Does not solve T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed. :/

Jun 4 2020, 7:25 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27461: Update MITK to use VTK 9.

Pushed new branch feature/T27461-VTK9.

Jun 4 2020, 7:03 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITK6a3ea89dafb4: Allow parallel use of segmentation and multilabel segmentation (authored by kislinsk).
Allow parallel use of segmentation and multilabel segmentation
Jun 4 2020, 3:42 PM
kislinsk committed rMITKc9a6e52b46a1: Allow parallel use of segmentation and multilabel segmentation (authored by kislinsk).
Allow parallel use of segmentation and multilabel segmentation
Jun 4 2020, 3:42 PM

Jun 3 2020

floca moved T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image from Backlog to MITK Meeting on the Request for Discussion board.
Jun 3 2020, 11:17 PM · Cleared, MITK (v2021.02)
floca moved T27442: PlanarFigure uses unmanged/uncontrolled pointer for PlaneGeometry from Backlog to MITK Meeting on the Request for Discussion board.
Jun 3 2020, 11:17 PM · Cleared, MITK (v2021.02)
floca raised the priority of T25445: MultiLabel segmentation mapper is very slow from Low to High.

As discussed we bump the priority as it has serious impact onthe UX.

Jun 3 2020, 11:16 PM · MITK (v2024.06), Request for Discussion
floca moved T27464: [CEST] Generic CEST data reader from Backlog to Perfusion on the MITK (v2021.02) board.
Jun 3 2020, 10:15 PM · Restricted Project, MITK (v2021.02)
floca triaged T27464: [CEST] Generic CEST data reader as High priority.
Jun 3 2020, 10:15 PM · Restricted Project, MITK (v2021.02)
floca edited projects for T27432: Error loading DCE-MRI DICOM image, added: Cleared, DICOM; removed Missing Info.

@sharonYu Thanks for the data. That helped to identify the problem.

Jun 3 2020, 10:05 PM · MITK, DICOM, Cleared
kislinsk claimed T27461: Update MITK to use VTK 9.

VTK 9 changed core components like vtkCellArray that require a thorough adaption of existing code (including external projects like ACVD).

Jun 3 2020, 6:24 PM · Noteworthy, MITK (v2021.02)
nolden added a comment to T27437: Migrate MITK to use ITK 5.x .

@floca : thanks. Not the whole trick but helped a lot. I will follow up with more geometry questions later ;)

Jun 3 2020, 3:07 PM · MITK-ProjectTemplate, MITK (v2022.04)
sharonYu added a comment to T27432: Error loading DCE-MRI DICOM image.

The zip file below is the DCE-MR image.

Jun 3 2020, 1:37 PM · MITK, DICOM, Cleared
nolden edited projects for T27085: 2D region growing tool fails for low intensity regions, added: Cleared; removed Missing Info.

I put a _non-shareable_ dataset in /ad/fs/E132-Projekte/Share/MarcoToMitkTeam .

Jun 3 2020, 12:55 PM · Cleared, MITK (v2021.02)
floca updated subscribers of T27462: Workbench crashes when loading multiple 3D+t datasets.

@kislinsk May be you have further ideas. If you could tell how to property configure the vtk part of the mapper to "just do nothing", I would test it in conjunction with observation 4.
In this case this task would be highly correlated with T25098, as it means to ensure that all data only renders, if the current time step is in their time bound.

Jun 3 2020, 11:58 AM · MITK (v2021.02)
floca updated the task description for T27462: Workbench crashes when loading multiple 3D+t datasets.
Jun 3 2020, 11:55 AM · MITK (v2021.02)
kislinsk committed rMITKc7ee88da8242: Hide interpolation widgets (authored by kislinsk).
Hide interpolation widgets
Jun 3 2020, 11:51 AM
kislinsk committed rMITK4d62dc9820f4: Hide interpolation widgets (authored by kislinsk).
Hide interpolation widgets
Jun 3 2020, 11:51 AM
kislinsk closed T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported as Resolved.
Jun 3 2020, 10:20 AM · Restricted Project, Cleared, MITK (v2021.02)
kislinsk closed T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported, a subtask of T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View, as Resolved.
Jun 3 2020, 10:20 AM · MITK (v2023.04), Restricted Project
kompan closed T27351: Can start parameters be provided as an image of starting values in the DCE Perfusion DataFit View? as Resolved.
Jun 3 2020, 10:18 AM · Cleared, MITK (v2021.02)
floca triaged T27462: Workbench crashes when loading multiple 3D+t datasets as High priority.
Jun 3 2020, 10:10 AM · MITK (v2021.02)

Jun 2 2020

floca committed rMITKa3d2e8fb0144: Fixed T23741 (authored by floca).
Fixed T23741
Jun 2 2020, 9:26 PM
floca committed rMITK6e66c957ba95: Fixed review remarks (authored by floca).
Fixed review remarks
Jun 2 2020, 9:26 PM
floca committed rMITKf3fa7f7ca0b9: Fixed T23741 (authored by floca).
Fixed T23741
Jun 2 2020, 9:26 PM
floca committed rMITK9947847e72e7: Addapt usages of UIDGenerator to changed GetUID interface. (authored by floca).
Addapt usages of UIDGenerator to changed GetUID interface.
Jun 2 2020, 9:26 PM
floca closed T23741: Specify default UID generation method, a subtask of T23744: Implement specific UID strategy for mitk::Image, as Resolved.
Jun 2 2020, 9:26 PM · MITK
floca closed T23741: Specify default UID generation method, a subtask of T24302: Should we persiste the ID of Identifiable when loading/saving BaseDatas?, as Resolved.
Jun 2 2020, 9:26 PM · Noteworthy, MITK (v2021.02)
floca closed T23741: Specify default UID generation method, a subtask of T23740: Introduce IDs to BaseData, as Resolved.
Jun 2 2020, 9:26 PM · MITK
floca closed T23741: Specify default UID generation method, a subtask of T23750: Implement IIdentifiable for mitk::DataNode , as Resolved.
Jun 2 2020, 9:26 PM · MITK
floca closed T23741: Specify default UID generation method as Resolved by committing rMITKf3fa7f7ca0b9: Fixed T23741.
Jun 2 2020, 9:26 PM · MITK (v2021.02), Noteworthy
floca closed T23741: Specify default UID generation method, a subtask of T27459: [Perfusion] Use PropertyReleationRules for referencing between input image and parameter maps, as Resolved.
Jun 2 2020, 9:26 PM · Breaking Change, MITK (v2021.02)