Page MenuHomePhabricator
Feed Advanced Search

May 15 2024

a178n closed T29197: [Segmentation] Is the classificationsegmentation-plugin used / required? as Resolved.

Already removed

May 15 2024, 11:29 AM · MITK (v2024.06)
kompan moved T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes from Backlog to MITK Meeting on the Request for Discussion board.
May 15 2024, 11:18 AM · Moved to git.dkfz.de, MITK (v2024.12)
kompan moved T30439: [Perfusion] Only a selection of debug parameter images generated as sub-nodes from Backlog to Cycle on the MITK (v2024.06) board.
May 15 2024, 10:53 AM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion, Checklist
kompan moved T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes from Backlog to Cycle on the MITK (v2024.06) board.
May 15 2024, 10:52 AM · Moved to git.dkfz.de, MITK (v2024.12)
floca moved T30447: [TotalSeg] Levelwindow effect from Backlog to MITK Meeting on the Request for Discussion board.
May 15 2024, 9:52 AM · MITK
floca added a project to T30447: [TotalSeg] Levelwindow effect: Request for Discussion.
May 15 2024, 9:52 AM · MITK

May 14 2024

a178n added a comment to T30447: [TotalSeg] Levelwindow effect.

Pushed new branch to rMITK MITK: feature/T30447-totalseg-levelwindow.

May 14 2024, 5:49 PM · MITK
a178n triaged T30447: [TotalSeg] Levelwindow effect as Normal priority.
May 14 2024, 5:38 PM · MITK
a178n claimed T30430: [TotalSeg] Add check if python venv exists before installation.
May 14 2024, 5:33 PM · MITK (v2024.06)
a178n added a comment to T30430: [TotalSeg] Add check if python venv exists before installation.

Pushed new branch to rMITK MITK: feature/T30430-python-venv-check.

May 14 2024, 5:21 PM · MITK (v2024.06)
kompan added a project to T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes: Request for Discussion.
May 14 2024, 11:36 AM · Moved to git.dkfz.de, MITK (v2024.12)
kompan added a comment to T30428: DCE MR Perfusion DataFit View: Selected Mask widget can't find DICOM segmentation nodes.

I compared the geometry of the dynamic image, the old mask (which could not be found anymore) and a new mask (is found), using the Details info box in MITK. I found small differences in the geometries between the old mask and the dynamic image, but not between the new mask and the dynamic image. Namely:
Spacing:
dynamic image: [1.0156, 1.0156, 5.99998]
old mask: [1.0156, 1.0156, 5.99997]
new mask: [1.0156, 1.0156, 5.99998]

May 14 2024, 11:36 AM · Moved to git.dkfz.de, MITK (v2024.12)
a178n claimed T30426: [SEG] Highlight importance of level window in Segment Anything.
May 14 2024, 10:10 AM · Checklist, MITK (v2024.06)
a178n added a revision to T30426: [SEG] Highlight importance of level window in Segment Anything: Restricted Differential Revision.
May 14 2024, 10:07 AM · Checklist, MITK (v2024.06)
floca closed T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported as Wontfix.

Undo/redo is a known problem, covered by other tickets.
The crash propblem I was not able to reproduce.

May 14 2024, 9:31 AM · Missing Info, Checklist, MITK (v2024.06)

May 13 2024

floca closed T30442: [SEG] Clear content on one label does not directly refresh the render windows as Resolved by committing rMITK9345a199763e: Fixed T30442.
May 13 2024, 1:39 PM · MITK (v2024.06)
kislinsk added a revision to T30444: [SEG] Crash when working a lot with labels on label delete : Restricted Differential Revision.
May 13 2024, 12:05 PM · MITK (v2024.06)
floca added a revision to T30442: [SEG] Clear content on one label does not directly refresh the render windows: Restricted Differential Revision.
May 13 2024, 11:55 AM · MITK (v2024.06)
floca moved T30444: [SEG] Crash when working a lot with labels on label delete from Backlog to Cycle on the MITK (v2024.06) board.
May 13 2024, 11:29 AM · MITK (v2024.06)
kislinsk closed T30443: Tab button of 2nd view is not correctly rendered as Resolved.

Could also verify with Ubuntu and macOS installers that it only seems to happen on the Windows installers with Qt 6.6.1. Close as resolved.

May 13 2024, 9:54 AM · MITK (v2024.06)
kislinsk added a comment to T30443: Tab button of 2nd view is not correctly rendered.

Qt 6.6.3 is the latest version of the Qt 6.6 range. I upgraded e230-nuc03. e230-nuc01 is not accessible via Remote Desktop because of expired credentials, have to upgrade later in office. Ubuntu 20.04 and 22.04 clients already build with Qt 6.6.2.

May 13 2024, 9:33 AM · MITK (v2024.06)
kislinsk added a comment to T30443: Tab button of 2nd view is not correctly rendered.

I was surprised not being able to reproduce this issue anymore with my local build. I then tested the snapshot installer and I was able to reproduce. The only difference I see is Qt 6.6.1 (installer) vs. Qt 6.6.2 (local). I will upgrade Qt on our Windows CI clients and check again...

May 13 2024, 9:00 AM · MITK (v2024.06)
kislinsk triaged T30443: Tab button of 2nd view is not correctly rendered as Normal priority.
May 13 2024, 8:43 AM · MITK (v2024.06)
kislinsk claimed T30443: Tab button of 2nd view is not correctly rendered.
May 13 2024, 8:43 AM · MITK (v2024.06)

May 11 2024

floca added a comment to T30444: [SEG] Crash when working a lot with labels on label delete .

After monkey testing in RelWDebugInfo, I think I found a lead. It can happen due to different processing of the Qt event queue that GetLabel is queried in a widget on a label that does not exist anymore. But it is not checked if GetLabel returns nullptr. Which in this case can happen. I hope this will fix the problem..,

May 11 2024, 12:24 PM · MITK (v2024.06)
floca triaged T30444: [SEG] Crash when working a lot with labels on label delete as Unbreak Now! priority.
May 11 2024, 12:21 PM · MITK (v2024.06)
floca created T30443: Tab button of 2nd view is not correctly rendered.
May 11 2024, 12:17 PM · MITK (v2024.06)

May 10 2024

floca triaged T30442: [SEG] Clear content on one label does not directly refresh the render windows as Low priority.
May 10 2024, 3:04 PM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Deleted branch from rMITK MITK: bugfix/T26934-FixLogoAnnotation.

May 10 2024, 2:57 PM · MITK (v2024.06)
kislinsk closed T26934: Multiple logos in screenshot when using screenshot maker plugin as Resolved by committing rMITK208cf8597f01: Remove multi widget decoration manager duplicate.
May 10 2024, 2:56 PM · MITK (v2024.06)
floca closed T30422: [SEG] Erase tool double click is irritating as Resolved.
May 10 2024, 2:20 PM · Checklist, MITK (v2024.06)
floca closed T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX as Resolved by committing rMITK27cad36203c2: Refactored QmitkMultiLabelInspector to use the highlight guard.
May 10 2024, 2:19 PM · Request for Discussion, Checklist, MITK (v2024.06)
kompan triaged T30441: [Perfusion] Baseline range bug for variable flip angle conversion as Normal priority.
May 10 2024, 10:55 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kislinsk added a revision to T26934: Multiple logos in screenshot when using screenshot maker plugin: Restricted Differential Revision.
May 10 2024, 10:25 AM · MITK (v2024.06)
kompan triaged T30440: [Perfusion] Error when loading AIF from csv file in DCE MR Perfusion DataFit View as Normal priority.
May 10 2024, 10:24 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Pushed new branch to rMITK MITK: bugfix/T26934-FixLogoAnnotation.

May 10 2024, 10:23 AM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Deleted branch from rMITK MITK: bugfix/T26934-FixHighResScreenshots.

May 10 2024, 10:18 AM · MITK (v2024.06)
kompan triaged T30439: [Perfusion] Only a selection of debug parameter images generated as sub-nodes as Normal priority.
May 10 2024, 9:55 AM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion, Checklist
kislinsk added a revision to T26934: Multiple logos in screenshot when using screenshot maker plugin: Restricted Differential Revision.
May 10 2024, 1:14 AM · MITK (v2024.06)
kislinsk added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

Pushed new branch to rMITK MITK: bugfix/T26934-FixHighResScreenshots.

May 10 2024, 1:08 AM · MITK (v2024.06)
kislinsk edited projects for T26934: Multiple logos in screenshot when using screenshot maker plugin, added: MITK (v2024.06); removed Auto-closed, MITK.
May 10 2024, 1:06 AM · MITK (v2024.06)

May 9 2024

floca moved T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX from Backlog to Cycle on the MITK (v2024.06) board.
May 9 2024, 10:53 AM · Request for Discussion, Checklist, MITK (v2024.06)
floca moved T30422: [SEG] Erase tool double click is irritating from Backlog to Cycle on the MITK (v2024.06) board.
May 9 2024, 10:53 AM · Checklist, MITK (v2024.06)
floca moved T30432: [Perfusion] Possible to write text into info box from Backlog to Cycle on the MITK (v2024.06) board.
May 9 2024, 10:53 AM · Moved to git.dkfz.de, MITK (v2024.12)
floca moved T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported from Backlog to Cycle on the MITK (v2024.06) board.
May 9 2024, 10:53 AM · Missing Info, Checklist, MITK (v2024.06)
floca added a comment to T30422: [SEG] Erase tool double click is irritating.

How to adapt: Use the "clear label" option in the context menue of the label inspector.

May 9 2024, 10:52 AM · Checklist, MITK (v2024.06)
floca claimed T30422: [SEG] Erase tool double click is irritating.
May 9 2024, 10:48 AM · Checklist, MITK (v2024.06)
floca added a revision to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX: Restricted Differential Revision.
May 9 2024, 10:47 AM · Request for Discussion, Checklist, MITK (v2024.06)
floca claimed T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.
May 9 2024, 10:45 AM · Request for Discussion, Checklist, MITK (v2024.06)

May 8 2024

kislinsk closed T30414: [Documentation] Help contents have wrong titles and root pages as Resolved.
May 8 2024, 3:11 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30414: [Documentation] Help contents have wrong titles and root pages.

Deleted branch from rMITK MITK: bugfix/T30414-MakeIndexDefaultPage.

May 8 2024, 3:10 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30414: [Documentation] Help contents have wrong titles and root pages.

Pushed new branch to rMITK MITK: bugfix/T30414-MakeIndexDefaultPage.

May 8 2024, 3:08 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30414: [Documentation] Help contents have wrong titles and root pages.

In the past we used the XLST functionalities from Qt 5 to remove certain parts for the help files. Since Qt 6 we removed the transformation as it is not easy to set up a feasible alternative with libxml for example. The downside now is to have a little bit more clutter in the Help Contents. Since the Help Index still looks like the Help Contents before, I think we should simply change the default view of the Help Perspective to Help Index and live with the Help Contents as-is.

May 8 2024, 2:53 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious.

Deleted branch from rMITK MITK: bugfix/T30416-AddUsageHintsToMeasurementView.

May 8 2024, 1:49 PM · MITK (v2024.06), Checklist
kislinsk added a comment to T30413: [Documentation] Help pages are blank in certain situations.

Deleted branch from rMITK MITK: bugfix/T30413-FixBlankHelpPages.

May 8 2024, 1:49 PM · Checklist, MITK (v2024.06)
kislinsk closed T30413: [Documentation] Help pages are blank in certain situations as Resolved by committing rMITK262b488cf8fa: Fix blank help pages.
May 8 2024, 1:47 PM · Checklist, MITK (v2024.06)
kislinsk closed T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious as Resolved by committing rMITKb723e24abc7e: Show usage hint when drawing planar figures.
May 8 2024, 1:46 PM · MITK (v2024.06), Checklist
kislinsk added a revision to T30413: [Documentation] Help pages are blank in certain situations: Restricted Differential Revision.
May 8 2024, 12:19 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30413: [Documentation] Help pages are blank in certain situations.

Pushed new branch to rMITK MITK: bugfix/T30413-FixBlankHelpPages.

May 8 2024, 12:17 PM · Checklist, MITK (v2024.06)
kislinsk claimed T30413: [Documentation] Help pages are blank in certain situations.
May 8 2024, 12:10 PM · Checklist, MITK (v2024.06)
a178n added a project to T30429: Bounding box Corner control: Next Milestone.
May 8 2024, 11:33 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n added a comment to T30431: [TotalSeg] Installation status for user.

The task will be addressed after migrating the install options into Preferences. Then the status update for installation will be implemented for all "AI" tools.

May 8 2024, 11:32 AM · Moved to git.dkfz.de, MITK (v2024.12)
a178n removed a project from T30422: [SEG] Erase tool double click is irritating: Request for Discussion.

RFD result: Remove the functionality

May 8 2024, 11:16 AM · Checklist, MITK (v2024.06)
a178n added a project to T30431: [TotalSeg] Installation status for user: Next Milestone.
May 8 2024, 11:05 AM · Moved to git.dkfz.de, MITK (v2024.12)
kompan added projects to T30425: [SEG] Segment Anything - Loading errors occur when opening the preferences: MITK (v2024.06), Checklist.
May 8 2024, 11:03 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
a178n assigned T30432: [Perfusion] Possible to write text into info box to kompan.
May 8 2024, 10:59 AM · Moved to git.dkfz.de, MITK (v2024.12)
a178n added a project to T30434: [Perfusion] Concentration curve converter VFA box tab key skips flip angles: Next Milestone.
May 8 2024, 10:57 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kompan moved T18489: Help perspective cannot be closed from Backlog to Cycle on the MITK (v2024.06) board.
May 8 2024, 9:57 AM · MITK (v2024.12), Request for Discussion
kompan reopened T18489: Help perspective cannot be closed as "Open".
May 8 2024, 9:41 AM · MITK (v2024.12), Request for Discussion
kislinsk claimed T30414: [Documentation] Help contents have wrong titles and root pages.
May 8 2024, 9:04 AM · Checklist, MITK (v2024.06)

May 7 2024

kislinsk assigned T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported to floca.
May 7 2024, 9:58 PM · Missing Info, Checklist, MITK (v2024.06)
floca closed T29526: [Segmentation] Workbench crashes when closing render window part with active tool as Resolved by committing rMITK88164071fbca: Fixed T29526.
May 7 2024, 6:28 PM · MITK (v2024.06)
kislinsk added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

This is a good idea.

May 7 2024, 4:31 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

hm. I see.
May be:
B + if you press shift while hovering, then always highlight?

May 7 2024, 4:08 PM · Request for Discussion, Checklist, MITK (v2024.06)
kislinsk added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

That you cannot tell. You don't know how testers would react to option A. May be it is equaly irritating to them. And may be they would missing the highlighting of invisible labels if the realy would work with it... 🤔

May 7 2024, 3:57 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

but the disadvantages proved to outweigh.

That you cannot tell. You don't know how testers would react to option A. May be it is equaly irritating to them. And may be they would missing the highlighting of invisible labels if the realy would work with it... 🤔
If we want to base it on user feedback in such an unclear situation, one would need to offer/explain all options and let them choose/poll.

May 7 2024, 3:51 PM · Request for Discussion, Checklist, MITK (v2024.06)
a178n added a comment to T30426: [SEG] Highlight importance of level window in Segment Anything.

Pushed new branch to rMITK MITK: feature/T30426-doc-updates.

May 7 2024, 3:50 PM · Checklist, MITK (v2024.06)
floca added a comment to T30412: [Statistics] Planar figure cannot be set as ROI for askew images.

Hm, yes, As we also define a reference image like in the segmentation view. I think it is the most pragmatic and consistent approach to introduce the same/simelar behavior:
warn users if the rendering is not alligned with the reference image and only allow making planar figures if the geometry was reinit.
I am not sure if reinit as soon as the click on a planar figure button wouldn't be irritating.

May 7 2024, 3:45 PM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk added a revision to T29526: [Segmentation] Workbench crashes when closing render window part with active tool: Restricted Differential Revision.
May 7 2024, 3:36 PM · MITK (v2024.06)
floca closed T30411: [SEG] Label color is off unitl first refresh when instances are used as Resolved by committing rMITK36f6b8c0d855: Fixed T30411.
May 7 2024, 3:20 PM · Checklist, MITK (v2024.06)
floca closed T30420: [SEG] Fill/Erase tool does not work due to geometry error, a subtask of T30421: [SEG] Undo/Redo problems with Fill/Erase tool reported, as Resolved.
May 7 2024, 3:19 PM · Missing Info, Checklist, MITK (v2024.06)
floca closed T30420: [SEG] Fill/Erase tool does not work due to geometry error as Resolved by committing rMITKd52112aa4083: Fixed T30420.
May 7 2024, 3:19 PM · Checklist, MITK (v2024.06)
floca closed T30419: [Segmentation] "Preview" button of GrowCut tools needs to be clicked twice before "Confirm segmentation" button gets active as Resolved by committing rMITK551e8c93dbfc: Fixed T30419.
May 7 2024, 3:18 PM · Checklist, MITK (v2024.06)
kislinsk added a revision to T30420: [SEG] Fill/Erase tool does not work due to geometry error: Restricted Differential Revision.
May 7 2024, 3:03 PM · Checklist, MITK (v2024.06)
kislinsk added a comment to T30412: [Statistics] Planar figure cannot be set as ROI for askew images.

With a reinit it works but boy is this unintuitive for users. Like when starting the Workbench and opening brain.nrrd, there's no indication that a reinit is necessary (and what a reinit is and where to find it is another story). You can draw a planar figure on it just fine.

May 7 2024, 3:00 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca claimed T29526: [Segmentation] Workbench crashes when closing render window part with active tool.
May 7 2024, 2:59 PM · MITK (v2024.06)
kislinsk added a comment to T30417: [Segmentation] Invisible labels are highlighted leading to confusing UX.

Yes, I agree. Well, not completely I guess, since I vote for B. The current state confused all testers (and me at first when I double-checked what's going on, and after I understood I still would consider it a bug in this state). I see the good intentions why you changed it from initial B to something else, but the disadvantages proved to outweigh.

May 7 2024, 2:53 PM · Request for Discussion, Checklist, MITK (v2024.06)
floca moved T30412: [Statistics] Planar figure cannot be set as ROI for askew images from Backlog to Cycle on the MITK (v2024.06) board.
May 7 2024, 2:50 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca added a project to T30412: [Statistics] Planar figure cannot be set as ROI for askew images: Missing Info.

I cannot reproduce the "bug".
But it is not realy a bug but correct. If you do not reinit on brain.nrrd before making the planar figure, it is tilted. Therefore no statistics can be computed.

May 7 2024, 2:49 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca claimed T30412: [Statistics] Planar figure cannot be set as ROI for askew images.
May 7 2024, 2:37 PM · Moved to git.dkfz.de, MITK (v2024.12)
floca merged task T30418: [Segmentation / Pixel Value] Pixel values only shown for active group into T29525: Pixel Value View should be aware of label set images.
May 7 2024, 2:36 PM · Checklist, MITK (v2024.06)
floca added a revision to T30419: [Segmentation] "Preview" button of GrowCut tools needs to be clicked twice before "Confirm segmentation" button gets active: Restricted Differential Revision.
May 7 2024, 2:30 PM · Checklist, MITK (v2024.06)
kislinsk added a revision to T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious: Restricted Differential Revision.
May 7 2024, 12:00 PM · MITK (v2024.06), Checklist
kislinsk added a comment to T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious.

Pushed new branch to rMITK MITK: bugfix/T30416-AddUsageHintsToMeasurementView.

May 7 2024, 11:58 AM · MITK (v2024.06), Checklist
kislinsk added a comment to T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious.

The Measurement view is quite a historically grown abomination that would greatly benefit from a complete overhaul. Hence, to keep complexity down to a minimum for the upcoming release, I suggest to not implement canceling but instead to add a hint to the GUI on how to finish continuous planar figures.

May 7 2024, 11:08 AM · MITK (v2024.06), Checklist
kislinsk claimed T30416: [Measurement] Selecting a shape enforces drawing it / finishing a path not obvious.
May 7 2024, 11:05 AM · MITK (v2024.06), Checklist
kompan triaged T30437: [Perfusion] Provide example start parameter image for checklists as Low priority.
May 7 2024, 10:49 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kompan triaged T30436: [Perfusion] Checkbox for Start Parameters instead of radio button as Low priority.
May 7 2024, 10:43 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kompan added a project to T30435: Rename "Time" to "Timestep" in Image Navigator?: Request for Discussion.
May 7 2024, 10:40 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
kompan triaged T30435: Rename "Time" to "Timestep" in Image Navigator? as Normal priority.
May 7 2024, 9:48 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist