Page MenuHomePhabricator
Feed Advanced Search

Mar 17 2022

kislinsk closed T27437: Migrate MITK to use ITK 5.x , a subtask of T28247: [Segmentation] Watershed tool freezes when slider and threshold are set to a low value, as Resolved.
Mar 17 2022, 1:17 AM · MITK, Next Milestone, Missing Info, Request for Discussion
kislinsk closed T27437: Migrate MITK to use ITK 5.x , a subtask of T28244: [Segmentation] Fast Marching Tool not really responsive for large images, as Resolved.
Mar 17 2022, 1:17 AM · MITK, Next Milestone
kislinsk closed T27437: Migrate MITK to use ITK 5.x , a subtask of T28275: [Segmentation] AdaptiveRegionGrowingTool must be refactored / 4D Segmentation returns error message when point is not on the correct timestep, as Resolved.
Mar 17 2022, 1:17 AM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk closed T27437: Migrate MITK to use ITK 5.x , a subtask of T28851: [SEG] Add ITK GrowCut as segmentation tool, as Resolved.
Mar 17 2022, 1:17 AM · MITK (v2022.10)
kislinsk closed T27437: Migrate MITK to use ITK 5.x , a subtask of T28499: Refactor/rewrite RegionGrowing3D tool, as Resolved.
Mar 17 2022, 1:17 AM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk closed T27437: Migrate MITK to use ITK 5.x as Resolved.
Mar 17 2022, 1:17 AM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .

Deleted branch from rMITK MITK: feature/T27437-ITK-v5.

Mar 17 2022, 1:16 AM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk moved T29038: Make MITK compatible to GCC 11 and raise C++ standard to 17 from Backlog to Cycle on the MITK (v2022.04) board.
Mar 17 2022, 12:03 AM · MITK (v2022.04)
kislinsk edited projects for T29038: Make MITK compatible to GCC 11 and raise C++ standard to 17, added: MITK (v2022.04); removed MITK.
Mar 17 2022, 12:03 AM · MITK (v2022.04)
kislinsk triaged T29038: Make MITK compatible to GCC 11 and raise C++ standard to 17 as Normal priority.
Mar 17 2022, 12:03 AM · MITK (v2022.04)

Mar 16 2022

kislinsk committed rMITK4821db9bb0eb: Upgrade ITK from v4.13.3 to v5.1.2 (authored by kislinsk).
Upgrade ITK from v4.13.3 to v5.1.2
Mar 16 2022, 4:24 PM
kislinsk committed rMITKacfdc4c2ec85: Upgrade MatchPoint to an ITK v5.1 compatible version (authored by kislinsk).
Upgrade MatchPoint to an ITK v5.1 compatible version
Mar 16 2022, 4:24 PM
kislinsk committed rMITK33923500841b: Migrate MitkCore to ITK v5.1 (authored by kislinsk).
Migrate MitkCore to ITK v5.1
Mar 16 2022, 4:24 PM
kislinsk committed rMITKfcced6049579: Migrate Core test driver to ITK v5.2 (authored by kislinsk).
Migrate Core test driver to ITK v5.2
Mar 16 2022, 4:24 PM
kislinsk committed rMITK4adb48420c73: Refactor UTF-8 conversion from IOUtil into Utf8Util (authored by kislinsk).
Refactor UTF-8 conversion from IOUtil into Utf8Util
Mar 16 2022, 4:24 PM
kislinsk committed rMITKdc3eca87a619: Fix error introduced during ITK 5 migration (authored by kislinsk).
Fix error introduced during ITK 5 migration
Mar 16 2022, 4:24 PM
kislinsk committed rMITKfe38878b4287: Continue ITK v5 migration (authored by kislinsk).
Continue ITK v5 migration
Mar 16 2022, 4:24 PM
kislinsk committed rMITK23673504a7f8: Migrate MinMax(Label)ImageFilterWithIndex to ITK v5 (authored by kislinsk).
Migrate MinMax(Label)ImageFilterWithIndex to ITK v5
Mar 16 2022, 4:24 PM
kislinsk committed rMITK3c0d1f86e6ec: Use ITK v5.2.1 instead of v5.2.0 (authored by kislinsk).
Use ITK v5.2.1 instead of v5.2.0
Mar 16 2022, 4:24 PM
kislinsk committed rMITKb6e62ec542f3: (WIP) (authored by kislinsk).
(WIP)
Mar 16 2022, 4:24 PM
kislinsk committed rMITK5e4d293dcb00: Merge remote-tracking branch 'origin/develop' into feature/T27437-ITK-v5 (authored by kislinsk).
Merge remote-tracking branch 'origin/develop' into feature/T27437-ITK-v5
Mar 16 2022, 4:24 PM
kislinsk committed rMITK9fb10920eb93: Fix errors reported by Visual Studio 2022 (authored by kislinsk).
Fix errors reported by Visual Studio 2022
Mar 16 2022, 4:24 PM
kislinsk committed rMITKd77534c0d5c9: Continue migration to ITK v5 (authored by kislinsk).
Continue migration to ITK v5
Mar 16 2022, 4:24 PM
kislinsk committed rMITKebf2dd93c606: Complete first version of migrated image statistics filter (authored by kislinsk).
Complete first version of migrated image statistics filter
Mar 16 2022, 4:24 PM
kislinsk committed rMITKeda086f57ca5: Fix missing dependency (authored by kislinsk).
Fix missing dependency
Mar 16 2022, 4:24 PM
kislinsk committed rMITK02421d1d454c: Fix event definition (authored by kislinsk).
Fix event definition
Mar 16 2022, 4:24 PM
kislinsk committed rMITK2a0fcea4b162: Set measurement vector size of histogram before its initialization (authored by kislinsk).
Set measurement vector size of histogram before its initialization
Mar 16 2022, 4:24 PM
kislinsk committed rMITK4f9393b8d58b: Migrate label statistics image filter to ITK v5 (authored by kislinsk).
Migrate label statistics image filter to ITK v5
Mar 16 2022, 4:24 PM
kislinsk committed rMITKd6ce982bae98: Merge remote-tracking branch 'origin/develop' into feature/T27437-ITK-v5 (authored by kislinsk).
Merge remote-tracking branch 'origin/develop' into feature/T27437-ITK-v5
Mar 16 2022, 4:24 PM
kislinsk committed rMITKca68c1b2076b: Migrate more classes to ITK v5 (authored by kislinsk).
Migrate more classes to ITK v5
Mar 16 2022, 4:24 PM
kislinsk committed rMITK10ab0455a2f5: Add patch to make ITK 5 compatible to itself (authored by kislinsk).
Add patch to make ITK 5 compatible to itself
Mar 16 2022, 4:24 PM
kislinsk committed rMITK661bb3ef5fe3: Migrate legacy ITK threading to C++ standard library threading (authored by kislinsk).
Migrate legacy ITK threading to C++ standard library threading
Mar 16 2022, 4:24 PM
kislinsk committed rMITK6b00d5092414: Fix Unix compile errors (authored by kislinsk).
Fix Unix compile errors
Mar 16 2022, 4:24 PM
kislinsk committed rMITK4c318cea0fd5: Complete compile-time ITK v5 migration in All configuration (authored by kislinsk).
Complete compile-time ITK v5 migration in All configuration
Mar 16 2022, 4:24 PM
kislinsk committed rMITK35981ef32e5d: Fix Doxygen warnings (authored by kislinsk).
Fix Doxygen warnings
Mar 16 2022, 4:24 PM
kislinsk committed rMITK95c6aefeb0c1: Fix more compiler errors (authored by kislinsk).
Fix more compiler errors
Mar 16 2022, 4:24 PM
kislinsk committed rMITK34f90004f1c8: Merge branch 'develop' into feature/T27437-ITK-v5 (authored by kislinsk).
Merge branch 'develop' into feature/T27437-ITK-v5
Mar 16 2022, 4:24 PM
kislinsk committed rMITKb73b185b2e7d: Silence a few warnings for now (authored by kislinsk).
Silence a few warnings for now
Mar 16 2022, 4:24 PM
kislinsk committed rMITKc7ce86dbf0cc: Fix vnl deprecation warnings (authored by kislinsk).
Fix vnl deprecation warnings
Mar 16 2022, 4:24 PM
kislinsk committed rMITKd95293ad3e36: Fix warnings about unnecessary sign checks (authored by kislinsk).
Fix warnings about unnecessary sign checks
Mar 16 2022, 4:24 PM
kislinsk committed rMITK1ceaddf5947a: Remove unused variables and local typedefs (authored by kislinsk).
Remove unused variables and local typedefs
Mar 16 2022, 4:24 PM
kislinsk committed rMITKc301ce440f2a: Fix incomplete switch block (authored by kislinsk).
Fix incomplete switch block
Mar 16 2022, 4:24 PM
kislinsk committed rMITK0fa2f6793e71: Fix name lookup for ITK macros (authored by kislinsk).
Fix name lookup for ITK macros
Mar 16 2022, 4:24 PM
kislinsk committed rMITK634c27c82eeb: Add missing includes (authored by kislinsk).
Add missing includes
Mar 16 2022, 4:24 PM
kislinsk committed rMITK0bce5e8b9e3d: Replace std::thread swaps with assignments (authored by kislinsk).
Replace std::thread swaps with assignments
Mar 16 2022, 4:24 PM
kislinsk committed rMITK0d953e9a89fd: Fix vnl vector references (authored by kislinsk).
Fix vnl vector references
Mar 16 2022, 4:23 PM
kislinsk committed rMITK6b742b8214a2: Merge remote-tracking branch 'origin/develop' into feature/T27437-ITK-v5 (authored by kislinsk).
Merge remote-tracking branch 'origin/develop' into feature/T27437-ITK-v5
Mar 16 2022, 4:23 PM
kislinsk committed rMITKf2240cff5811: Fix maybe-uninitialized warning (authored by kislinsk).
Fix maybe-uninitialized warning
Mar 16 2022, 4:23 PM
kislinsk committed rMITKa7109ae78a8e: Fix maybe-uninitialized warning (authored by kislinsk).
Fix maybe-uninitialized warning
Mar 16 2022, 4:23 PM
kislinsk committed rMITK64f01a5b459f: Remove unused member variable (authored by kislinsk).
Remove unused member variable
Mar 16 2022, 4:23 PM
kislinsk committed rMITK0797a3e204de: Fix maybe-uninitialized warning (authored by kislinsk).
Fix maybe-uninitialized warning
Mar 16 2022, 4:23 PM
kislinsk committed rMITK1abc7cf8b142: Fix maybe-uninitialized warning (authored by kislinsk).
Fix maybe-uninitialized warning
Mar 16 2022, 4:23 PM
kislinsk committed rMITK4c81a1f1da8e: Fix maybe-uninitialized warning (authored by kislinsk).
Fix maybe-uninitialized warning
Mar 16 2022, 4:23 PM
kislinsk committed rMITK1955e2590bdf: Fix maybe-uninitialized warning (authored by kislinsk).
Fix maybe-uninitialized warning
Mar 16 2022, 4:23 PM
kislinsk committed rMITK3ace077af1fa: Switch off dynamic multi-threading (authored by kislinsk).
Switch off dynamic multi-threading
Mar 16 2022, 4:23 PM
kislinsk committed rMITK56fa90967754: Disable maybe-uninitialized warning (authored by kislinsk).
Disable maybe-uninitialized warning
Mar 16 2022, 4:23 PM
kislinsk committed rMITK392adcd548c8: Fix itkTotalVariationDenoisingImageFilterTest (authored by kislinsk).
Fix itkTotalVariationDenoisingImageFilterTest
Mar 16 2022, 4:23 PM
kislinsk committed rMITK4b381f4e9b5b: Fix mitkImageStatisticsTextureAnalysisTest (authored by kislinsk).
Fix mitkImageStatisticsTextureAnalysisTest
Mar 16 2022, 4:23 PM
kislinsk committed rMITKcc0179da40bb: Correct expected variance values (authored by kislinsk).
Correct expected variance values
Mar 16 2022, 4:23 PM
kislinsk committed rMITK4449cbb2a35f: Switch off dynamic multi-threading in several classes (authored by kislinsk).
Switch off dynamic multi-threading in several classes
Mar 16 2022, 4:23 PM
kislinsk committed rMITK145223cf223f: Migrate from ITK v4.13.3 to v5.2.1 (authored by kislinsk).
Migrate from ITK v4.13.3 to v5.2.1
Mar 16 2022, 4:23 PM

Mar 12 2022

kislinsk updated the task description for T27437: Migrate MITK to use ITK 5.x .
Mar 12 2022, 1:24 AM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .

I found the issue: In our old image statistics filters variance was computed as follows:

Mar 12 2022, 12:19 AM · MITK-ProjectTemplate, MITK (v2022.04)

Mar 11 2022

kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .

I checked the mitkImageStatisticsCalculatorTest and all tests that fail seem to be related to variance or the standard deviation = sqrt(variance). I double-checked the calculation of variance and it seems to be correct. SInce I get rather big differences to the hard-coded expected values even with a masked image as small as 4 pixels (1x0 + 3x255), I assume for now maybe it is the mask that is different after the migration. The mask is generated from a manually specified planar polygon. I need to write the generated mask to disk from before the migration and compare it with the current mask.

Mar 11 2022, 11:58 PM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .
Progress on fixed unit tests
Mar 11 2022, 10:51 PM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .
  • For the Differential build clients to continue working for both Diffs with and without the ITK v5 migration I had to add a few #if/#else blocks to the MITK-ProjectTemplate to distinguish between ITK v4 and v5. After the migration is merged in MITK, they can be removed again in favor of the ITK v5 adaptions.
Mar 11 2022, 9:53 AM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .

Deleted branch from rMPT MITK-ProjectTemplate: feature/T27437-ITK-v5.

Mar 11 2022, 9:50 AM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk committed rMPT2bc39b606f61: Make project template compatible to both ITK v4 and v5 (authored by kislinsk).
Make project template compatible to both ITK v4 and v5
Mar 11 2022, 12:54 AM
kislinsk committed rMPTfa22d63c8766: Merge branch 'feature/T27437-ITK-v5' into develop (authored by kislinsk).
Merge branch 'feature/T27437-ITK-v5' into develop
Mar 11 2022, 12:54 AM
kislinsk added a comment to T27437: Migrate MITK to use ITK 5.x .

Pushed new branch to rMPT MITK-ProjectTemplate: feature/T27437-ITK-v5.

Mar 11 2022, 12:54 AM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk added a project to T27437: Migrate MITK to use ITK 5.x : MITK-ProjectTemplate.
Mar 11 2022, 12:54 AM · MITK-ProjectTemplate, MITK (v2022.04)

Mar 8 2022

kislinsk added a comment to T28984: [MultiLabel Segmentation] Paint tool does not show the correct contour color.

I added a fix, which still shows a red / green circle as a brush, but uses the active label color for the outline of the "area-to-be-masked" /"area-to-be-removed".

Mar 8 2022, 1:20 PM · MITK

Feb 18 2022

kislinsk closed T28985: 2022 Week 07 (Mid February) as Resolved.
Feb 18 2022, 1:58 PM · MITK
kislinsk edited the content of Changelog.
Feb 18 2022, 1:57 PM · MITK
kislinsk edited the content of 2021 Week 48 (Very Early December).
Feb 18 2022, 1:56 PM
kislinsk added a comment to T28985: 2022 Week 07 (Mid February).

Deleted branch from rMITK MITK: release/T28985-2022-Week-07.

Feb 18 2022, 1:56 PM · MITK
kislinsk committed rMITK3916ade16042: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Feb 18 2022, 1:55 PM
kislinsk committed rMITK2cc1a0c64880: 2022 Week 07 (Mid February) (authored by kislinsk).
2022 Week 07 (Mid February)
Feb 18 2022, 1:54 PM
kislinsk edited the content of 2022 Week 07 (Mid February).
Feb 18 2022, 1:50 PM
kislinsk added a revision to T27437: Migrate MITK to use ITK 5.x : Unknown Object (Differential Revision).
Feb 18 2022, 11:52 AM · MITK-ProjectTemplate, MITK (v2022.04)
kislinsk added a comment to T28985: 2022 Week 07 (Mid February).

Pushed new branch to rMITK MITK: release/T28985-2022-Week-07.

Feb 18 2022, 9:28 AM · MITK
kislinsk triaged T28985: 2022 Week 07 (Mid February) as Normal priority.
Feb 18 2022, 9:26 AM · MITK
kislinsk created an object: 2022 Week 07 (Mid February).
Feb 18 2022, 9:25 AM

Feb 16 2022

kislinsk triaged T28493: Multilabel color map colors are not very nice as Normal priority.
Feb 16 2022, 5:40 PM · Checklist, Request for Discussion, MITK (v2022.04)
kislinsk triaged T28942: Ensure default properties for data nodes as Normal priority.
Feb 16 2022, 5:39 PM · Moved to git.dkfz.de, MITK
kislinsk closed T28979: 3D rendering of surfaces behaving strangely as Invalid.

This is a bug that slipped into - and only into - v2021.10. Should work on any other version like v2021.02 or any snapshot before/after v2021.10.

Feb 16 2022, 5:34 PM · MITK

Feb 11 2022

kislinsk added a member for Repository Admins: ahmadqasim.
Feb 11 2022, 10:26 AM
kislinsk added a member for Repository Admins: t391x.
Feb 11 2022, 10:26 AM

Feb 9 2022

kislinsk moved T27437: Migrate MITK to use ITK 5.x from Backlog to Cycle on the MITK (v2022.04) board.
Feb 9 2022, 11:51 AM · MITK-ProjectTemplate, MITK (v2022.04)

Jan 31 2022

kislinsk set the color for SDS-Meta to Green.
Jan 31 2022, 1:38 PM
kislinsk created SDS-Meta.
Jan 31 2022, 1:37 PM

Jan 28 2022

kislinsk closed T28941: Some 2D and 3D tools for segmentation are not available as Invalid.
Jan 28 2022, 9:10 AM · MITK

Jan 26 2022

kislinsk added a subtask for T25105: UpdateStatusBar duplicates business logic: T25043: Remove pixel informations from the statusbar and put it into views.
Jan 26 2022, 11:40 AM · MITK (v2022.10)
kislinsk added a parent task for T25043: Remove pixel informations from the statusbar and put it into views: T25105: UpdateStatusBar duplicates business logic.
Jan 26 2022, 11:40 AM · Cleared, MITK
kislinsk removed a project from T25105: UpdateStatusBar duplicates business logic: Request for Discussion.
Jan 26 2022, 11:39 AM · MITK (v2022.10)
kislinsk edited projects for T25043: Remove pixel informations from the statusbar and put it into views, added: Cleared; removed Request for Discussion.

We again concluded that this information + some optional extra features should be shown by a view instead of the task bar. The idea is to have a kind of "core" view like the slice navigator that is usually shown in all perspectives but in the end is configurable.

Jan 26 2022, 11:37 AM · Cleared, MITK
kislinsk moved T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation from MITK Meeting to Backlog on the Request for Discussion board.
Jan 26 2022, 11:29 AM · MITK (v2022.04), Breaking Change
kislinsk moved T27913: [Segmentation] Warnings in utilities view are inconsistent from MITK Meeting to Backlog on the Request for Discussion board.
Jan 26 2022, 11:28 AM · MITK (v2024.06)
kislinsk moved T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem from MITK Meeting to Backlog on the Request for Discussion board.
Jan 26 2022, 11:28 AM · MITK (v2022.04), Cleared
kislinsk moved T28946: MITK Flow - Save Segmentation - Error/Exception Handling from Backlog to MITK Meeting on the Request for Discussion board.
Jan 26 2022, 11:01 AM · Auto-closed, Kaapana (internal), MITK