Page MenuHomePhabricator
Feed Advanced Search

Oct 8 2019

kislinsk triaged T26728: Fix macOS 10.15 compiler errors as Normal priority.
Oct 8 2019, 5:08 PM · MITK

Oct 4 2019

floca added a comment to T26463: MatchPoint Registration Manipulator Segmentation Fault.

@isensee

  1. Does it work if you select two normal images (not segmentations)?
  2. Does the seg fault also happens if you use the Registration Evaluator plugin with the image and the segmentation?
  3. Could you provied example data, please?
Oct 4 2019, 3:34 PM · MITK
kalali added a project to T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry: Restricted Project.

Also if checking validity, consider T24766.

Oct 4 2019, 11:07 AM · MITK, Restricted Project

Sep 30 2019

nolden added a revision to T26431: Fix gcc 9 and clang 8 compilation: Restricted Differential Revision.
Sep 30 2019, 4:34 PM · MITK

Sep 25 2019

kalali closed T26276: Segmentation created for multiple timepoints on 3D+t images as Resolved.
Sep 25 2019, 3:46 PM · MITK

Sep 20 2019

jsolislemus added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

On computer A our own built (and packaged) work well.

Sep 20 2019, 4:34 PM · MITK
kislinsk added a parent task for T26276: Segmentation created for multiple timepoints on 3D+t images: T24766: Last time step of 3D+t data with arbitrary time geometry not selectable by image navigator spinbox.
Sep 20 2019, 4:21 AM · MITK

Sep 12 2019

kislinsk added a comment to T26427: Support software rendering.

Side note: https://fdossena.com does provide 64-bit builds now.

Sep 12 2019, 1:00 PM · Auto-closed, MITK

Sep 9 2019

kislinsk added a comment to T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling).

Cool! 👍🏻
Will look into this on Community Day.

Sep 9 2019, 12:03 PM · MITK, Noteworthy, Pull Request
kislinsk triaged T26653: Github pull request 263 (Forward vtkInformation objects to MITK mappers - allow for VTK depth peeling) as Normal priority.
Sep 9 2019, 11:58 AM · MITK, Noteworthy, Pull Request
kislinsk triaged T26654: Github pull request 239 (Check filename for invalid characters before saving e.g. "a:b.obj") as Normal priority.

Requested code changes in pull request.

Sep 9 2019, 11:56 AM · MITK, Pull Request
kislinsk placed T26427: Support software rendering up for grabs.
Sep 9 2019, 11:39 AM · Auto-closed, MITK
kislinsk closed T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) as Resolved.

Merged into releases/2018-04.

Sep 9 2019, 11:38 AM · MITK, Pull Request
kislinsk added a comment to T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal).

Pushed new branch T26655-GizmoFix.

Sep 9 2019, 11:37 AM · MITK, Pull Request
kislinsk triaged T26655: Github pull request 237 (Gizmo fix: avoid double emission of Modified() signal) as Low priority.
Sep 9 2019, 11:37 AM · MITK, Pull Request
kislinsk triaged T26656: Gitlab pull request 238 (Avoid collapsing 'Properties' view when editing child-properties (e.g. "material.something")) as Low priority.

Not yet working. Tree doesn't collapse only the first time.

Sep 9 2019, 11:34 AM · MITK, Pull Request

Sep 6 2019

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Apologies, but I am not sure I understand your first questions, but given your last statement:

No problem. A now fixed typo made it hard to understand.

Sep 6 2019, 9:26 PM · MITK

Aug 30 2019

kalali added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

Will be solved if D214 is accepted and merged.

Aug 30 2019, 2:44 PM · MITK

Aug 29 2019

jsolislemus added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Apologies for the delay in response..

Aug 29 2019, 3:23 PM · MITK

Aug 16 2019

kalali added a comment to T25930: [Segmentation] Fill/Erase crashes at non-zero timestep / Issue with ArbitraryTimeGeometry.

Is this still valid? I looked at it but couldn't reproduce the bug.
If you can reproduce it, could you try to reproduce it with Pic2DplusT and MITK-Data/3D+t-ITKIO-TestData as well?

Aug 16 2019, 12:36 PM · MITK, Restricted Project
kalali added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

I created such a segmentation on the 3D+t-heart dataset and stored the segmentation as *.nrrd. The I loaded the *.nrrd-segmentation again and I now I can only see the segmentation on the first timestep.
Important: The timesteps of the *.nrrd-segmentation are now from 0 - 3 and with a duration of 1ms. The original 3D+t-Heart was [0,103] [103,160] [160, 160]. This was also true for the original segmentation. If I store the 3D+t-Heart image as *.nrrd and reopen it again the original timesteps are preserved.

Aug 16 2019, 12:19 PM · MITK
kalali added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

I also tried it with MITK-Data/3D+t-ITKIO-TestData and everything works fine (segmentation and time-slider). However, a difference between all these time-images and the 3D+t-Heart// image is, that the Heart-image does not actually have a third timepoint, as the third timepoint is of length 0ms.
So maybe there is a problem with the matching of time points and the segmentation is displayed for the last time point, as the lats time point is actually non-existent and wraps around to the time point 0.

Aug 16 2019, 11:49 AM · MITK
kalali added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

I just tried this and I can reproduce it with MITK-Data/3D+t-Heart. But when I used Pic2DplusT the segmentation was only created on a single timestep.
Additionally, when I clicked on the arrows of the time-slider of the image navigation plugin the time slider sometimes wraps around the last time step and returns to timestep 0. This was already mentioned here T25030. However, this does not happen If I use the Pic2DplusT image so maybe the 3D+t-Heart image is corrupt?

Aug 16 2019, 11:40 AM · MITK

Aug 2 2019

floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Hm, ok. Then the log output is somehow inconsistent, with what is loaded into the workbench.
@kislinsk How do one enforces the more detailed log? The logging console is capable to show more information then given in the attached log.

Aug 2 2019, 4:40 PM · MITK

Aug 1 2019

jsolislemus added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Only one file in the stack was chosen on both cases.

Aug 1 2019, 1:41 PM · MITK
floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

(1) Using the Open File button -> Selected the (autoselect) -> NOT clicking on "apply the same to the remaining files" (file MitkWorkbench_MRIreadeAutoselect.log and looking as in the screenshot attached). The images were loaded individually, and not as a single dicom.

Regarding this workflow: I have another question. How many files did you select in the dialoge? One file of the stack as selection would be sufficient.

Aug 1 2019, 11:40 AM · MITK

Jul 31 2019

jsolislemus added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

Hello, sure. Please let me know if you need clarification, I am writing this with some haste, so I might not be as thorough or clear in my explanations.

Jul 31 2019, 3:45 PM · MITK
floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

@jsolislemus Thanks for the info. If I understood it correctly also the official installer shows this problem. Could you please do me a favor and check with the official installer if you have the same loading problem, if you do not use the DICOM browser, but instead the normal file open dialog or dragNdrop. With this information we can narrow it down a bit more.
Thanks.

Jul 31 2019, 3:27 PM · MITK
jsolislemus added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

I tried using the Logging as @floca suggested, however I am not familiar with what I should be looking for (attached MitkWorkbench_.log file). I tried downloading the MITK Workbench binaries corresponding to v2018.04.2 and got the same error, attaching the screenshot.

Jul 31 2019, 2:10 PM · MITK
kislinsk moved T25882: Rewrite dashboard script for CDash 2.6 from Backlog to Postpone on the MITK (2018-04-4) board.
Jul 31 2019, 1:29 PM · CI, MITK (v2021.02), Restricted Project
kislinsk moved T26237: Improve performance for interactions in 2d widgets from Backlog to Postpone on the MITK (2018-04-4) board.
Jul 31 2019, 1:28 PM · MITK
kislinsk moved T26427: Support software rendering from Backlog to Postpone on the MITK (2018-04-4) board.
Jul 31 2019, 1:28 PM · Auto-closed, MITK
floca added a comment to T26451: DICOM plugin cannot parse DICOM directories in macOS installer.

It would be helpfull to see the log output in order to see if a different reader configuration was choosen and which. Please activate the log window and check the out put of the read process.

Jul 31 2019, 9:55 AM · MITK

Jul 19 2019

kislinsk triaged T26472: CMAKE_INSTALL_PREFIX is not set for external projects of extenstions as Normal priority.
Jul 19 2019, 9:35 AM · Auto-closed, MITK

Jul 9 2019

kislinsk added a comment to T26472: CMAKE_INSTALL_PREFIX is not set for external projects of extenstions.

This is some output of the GuidelinesSupportLibrary.cmake external project file in the MITK-ProjectTemplate:

Jul 9 2019, 2:50 PM · Auto-closed, MITK
floca created T26472: CMAKE_INSTALL_PREFIX is not set for external projects of extenstions.
Jul 9 2019, 1:14 PM · Auto-closed, MITK

Jul 8 2019

kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

Pushed new branch T25882-RewriteCTestScript.

Jul 8 2019, 12:57 PM · CI, MITK (v2021.02), Restricted Project
kislinsk triaged T26463: MatchPoint Registration Manipulator Segmentation Fault as High priority.
Jul 8 2019, 12:27 AM · MITK

Jul 4 2019

kislinsk updated the task description for T26451: DICOM plugin cannot parse DICOM directories in macOS installer.
Jul 4 2019, 12:23 PM · MITK
kislinsk added a comment to T26427: Support software rendering.

Built Mesa. Same result. Mesa keeps reporting OpenGL 3.1 with GLSL 1.40. If we figure out how to squeeze the correct OpenGL context out of Mesa, it could be the breakthough.

Jul 4 2019, 8:58 AM · Auto-closed, MITK
kislinsk triaged T26451: DICOM plugin cannot parse DICOM directories in macOS installer as High priority.
Jul 4 2019, 8:55 AM · MITK

Jul 3 2019

kislinsk added a comment to T26427: Support software rendering.

According to https://mesamatrix.net/, Mesa (llvmpipe) should be able to 100% support OpenGL 3.3 with GLSL 3.30 and hence OpenGL 3.2 with GLSL 1.50. Next test: build Mesa by myself.

Jul 3 2019, 10:49 AM · Auto-closed, MITK
kislinsk added a comment to T26427: Support software rendering.

I did the same for the Qt contextinfo example. When creating a 2.1 context Mesa is reporting:

Jul 3 2019, 10:45 AM · Auto-closed, MITK
kislinsk added a comment to T26427: Support software rendering.

Wrote my own minimal Qt application with QVTKOpenGLNativeWidget and it basially has the same problems.

Jul 3 2019, 10:34 AM · Auto-closed, MITK

Jul 2 2019

kislinsk reopened T26431: Fix gcc 9 and clang 8 compilation as "Open".
Jul 2 2019, 9:07 AM · MITK

Jul 1 2019

nolden added a revision to T26431: Fix gcc 9 and clang 8 compilation: Restricted Differential Revision.
Jul 1 2019, 5:26 PM · MITK
kislinsk closed T26431: Fix gcc 9 and clang 8 compilation as Resolved.

Cherry-picked into releases/2018-04. Peter's fixes do not affect code available there.

Jul 1 2019, 9:59 AM · MITK

Jun 28 2019

kislinsk added a comment to T26427: Support software rendering.

Built MITK in 32bit and tried again just in case the 64bit binaries of Mes3D for Windows would have a problem. Same error, though. Next step would probably be a stand-alone VTK app with geometry shaders and if it works a stand-alone app based on VTK's Qt render window.

Jun 28 2019, 1:10 PM · Auto-closed, MITK
kislinsk added a comment to T26431: Fix gcc 9 and clang 8 compilation.

Dashboard is red. Many errors related to missing overload of operator <<. I guess this is related to changing many ref types of catch blocks without adapting the code in the catch blocks.

Jun 28 2019, 9:28 AM · MITK

Jun 27 2019

kislinsk edited projects for T26431: Fix gcc 9 and clang 8 compilation, added: MITK (2018-04-4); removed MITK.

May be worth cherry-picking these commits into releases/2018-04 as well.

Jun 27 2019, 3:25 PM · MITK
kislinsk added a comment to T26427: Support software rendering.

VTK has a little bug in vtkShader.cxx around line 76: GLuint handle = glCreateShader(type);. The handle is not tested against 0 which leads into a misleading error message like above. The actual problem is that vertex and fragment shaders can be created (and compiled successfully) but not geometry shaders.

Jun 27 2019, 11:47 AM · Auto-closed, MITK
kislinsk added a comment to T26427: Support software rendering.

Our example steps do not work, they start however. Render window is just black.

Jun 27 2019, 11:17 AM · Auto-closed, MITK
kislinsk added a comment to T26427: Support software rendering.

Also experimented with environment variable QT_OPENGL=software and QT_OPENGL=angle. VTK's GLEW is already unable to initialize with these settings.

Jun 27 2019, 11:04 AM · Auto-closed, MITK
kislinsk added a comment to T26427: Support software rendering.

Our example steps do not work, they start however. Render window is just black.

Jun 27 2019, 10:43 AM · Auto-closed, MITK
neher added a comment to T26413: Nifti2 support.

Pushed new branch T26413-Nifti2.

Jun 27 2019, 9:14 AM · Auto-closed, Missing Info, MITK

Jun 26 2019

kislinsk added a comment to T26427: Support software rendering.

Potential conflicts: Multiple render windws, Qt resp. shared OpenGL context with Qt.

Jun 26 2019, 4:47 PM · Auto-closed, MITK
kislinsk added a comment to T26427: Support software rendering.

I tried the VTK MarbleShader example and it works.

Jun 26 2019, 3:13 PM · Auto-closed, MITK
kislinsk added a parent task for T26427: Support software rendering: Restricted Maniphest Task.
Jun 26 2019, 2:08 PM · Auto-closed, MITK
kislinsk added a comment to T26427: Support software rendering.

Tried every combination of options but it's always the same error:

Jun 26 2019, 1:56 PM · Auto-closed, MITK
kalali added a comment to T26427: Support software rendering.

Important for T26144 (and also open office virtual desktops).

Jun 26 2019, 1:45 PM · Auto-closed, MITK
kislinsk added a comment to T26427: Support software rendering.

64bit builds of Mesa 3D for Windows: https://github.com/pal1000/mesa-dist-win/releases

Jun 26 2019, 1:38 PM · Auto-closed, MITK
kislinsk triaged T26427: Support software rendering as High priority.
Jun 26 2019, 1:24 PM · Auto-closed, MITK
kislinsk closed T26426: Allow customization of MITK's external projects in MITK extensions as Resolved.

Added ITK example to project template.

Jun 26 2019, 12:37 PM · MITK
kislinsk added a comment to T26426: Allow customization of MITK's external projects in MITK extensions.

Pushed new branch T26426-EPCustomization.

Jun 26 2019, 12:33 PM · MITK
kislinsk triaged T26426: Allow customization of MITK's external projects in MITK extensions as Wishlist priority.
Jun 26 2019, 12:31 PM · MITK

Jun 25 2019

kislinsk closed T26422: Start menu shortcut to MITK Workbench missing in Windows installer as Invalid.
Jun 25 2019, 3:28 PM · MITK
kislinsk added a comment to T26422: Start menu shortcut to MITK Workbench missing in Windows installer.

Works with NSIS 2.51.

Jun 25 2019, 3:11 PM · MITK
kislinsk triaged T26422: Start menu shortcut to MITK Workbench missing in Windows installer as Unbreak Now! priority.
Jun 25 2019, 12:44 PM · MITK

Jun 24 2019

kislinsk triaged T26413: Nifti2 support as High priority.

@neher Please base the fix on the releases/2018-04 branch.

Jun 24 2019, 1:44 PM · Auto-closed, Missing Info, MITK
kislinsk triaged T26397: Multilabel Segmentation file cannot be converted to multilabel segmentation in MITK as Normal priority.
Jun 24 2019, 1:43 PM · MITK

Jun 17 2019

full added a comment to T26397: Multilabel Segmentation file cannot be converted to multilabel segmentation in MITK.

It turned out that if I load the file holding the segmentation alone and the right click -> convert to segmentation, everything works as expected. Only if I load the raw image plus the corresponding segmentation simultaneously (which is my usual workflow), the bug above arises.

Jun 17 2019, 3:56 PM · MITK
full added a comment to T26397: Multilabel Segmentation file cannot be converted to multilabel segmentation in MITK.

Alright, thanks!

Jun 17 2019, 10:26 AM · MITK
kislinsk edited projects for T26397: Multilabel Segmentation file cannot be converted to multilabel segmentation in MITK, added: MITK (2018-04-4); removed MITK (2018-04).

HI Peter, MITK (2018-04-4) the the current milestone. I nearly missed this task as you put it in the already archived milestone MITK (2018-04). The safest way to raise awareness is to just set the task priority to Needs Triage and stick with the MITK tag. ❤

Jun 17 2019, 10:00 AM · MITK
kislinsk added a hashtag to MITK (2018-04-4): #mitk-2018-04-4.
Jun 17 2019, 9:57 AM

Jun 6 2019

maleike added a comment to T26356: Colored render window frames misaligned.

@kislinsk Thanks for your quick fix. I had a look into your changes, this looks very much like an overdue cleanup. Thanks again!

Jun 6 2019, 1:29 PM · MITK

May 29 2019

kislinsk claimed T24555: HDF5 library: superbuild fails in Install phase of RelWithDebInfo.
May 29 2019, 2:20 PM · Auto-closed, MITK
kislinsk closed T26356: Colored render window frames misaligned as Resolved.

Capture.JPG (106×135 px, 9 KB)

May 29 2019, 12:34 PM · MITK
kislinsk added a comment to T26356: Colored render window frames misaligned.

Pushed new branch T26356-MisalignedRenderWindowFrames.

May 29 2019, 12:30 PM · MITK
kislinsk claimed T26356: Colored render window frames misaligned.

Frame is encapsuled by vtkMitkRectangleProp class.

May 29 2019, 11:33 AM · MITK
kislinsk closed T24860: MitkCore seems not to apply a default level/window property ("levelwindow") as Resolved.

Thank you! 👍

May 29 2019, 10:18 AM · MITK
kislinsk added a comment to T24860: MitkCore seems not to apply a default level/window property ("levelwindow").

Pushed new branch T24860-LevelWindowInitLocation.

May 29 2019, 9:54 AM · MITK
kislinsk claimed T24860: MitkCore seems not to apply a default level/window property ("levelwindow").
May 29 2019, 9:52 AM · MITK

May 28 2019

kislinsk triaged T26356: Colored render window frames misaligned as Low priority.
May 28 2019, 9:45 AM · MITK

May 15 2019

full added a comment to T26331: Offer screenshot from "working plane" (axial, sagittal, coronar) by **default**.

I think @kislinsk suggestion would cover most use cases since the plane you work in is usually the one that is maximized. In this cases the working window will be the one that was clicked the last time.

May 15 2019, 10:52 AM · Auto-closed, MITK
kislinsk edited projects for T26331: Offer screenshot from "working plane" (axial, sagittal, coronar) by **default**, added: MITK (2018-04-4); removed MITK.
May 15 2019, 10:45 AM · Auto-closed, MITK

May 14 2019

kleina added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

Ok, I tested it on my current developing build, which is branched off of master from 2019-04-29 (a0ba9d263118bc2df2aa922c124c3db57acbd2dc). I can reproduce the error as described in the description. So I guess to answer your question @kislinsk: The status is "still open".

May 14 2019, 10:39 AM · MITK

May 13 2019

kleina added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

I forgot to enable the segmentation plugin... I'll test it tomorrow.

May 13 2019, 4:49 PM · MITK
kleina added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

I can reproduce it. I did exactly the steps in the task description. I used MITK.2018.4.0 installer. I'll check on a (more or less) current master.

May 13 2019, 4:33 PM · MITK
kleina added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

Wait for it...

May 13 2019, 4:30 PM · MITK
kausch added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

I couldn't reproduce it. @kleina Can you? (maybe it occurred only due to missing reinit?)

May 13 2019, 4:12 PM · MITK
kislinsk added a comment to T26276: Segmentation created for multiple timepoints on 3D+t images.

@kausch What's the status on this task?

May 13 2019, 3:12 PM · MITK
kislinsk closed T26252: Boost install error as Resolved.
May 13 2019, 2:26 PM · MITK
kislinsk added a comment to T26252: Boost install error.

Pushed new branch T26252-BoostInstallError.

May 13 2019, 2:26 PM · MITK
kislinsk lowered the priority of T26187: Create polygon model works only once from High to Low.

I really tried but I was not able to reproduce this issue. For example, I created a segmentation and clicked multiple times on "Create smoothed polygon model" and "Create polygon model". Worked every time. I then created another segmentation in the same scene and did the same there with the same results.

May 13 2019, 2:17 PM
kislinsk edited projects for T24555: HDF5 library: superbuild fails in Install phase of RelWithDebInfo, added: MITK (2018-04-4); removed MITK.
May 13 2019, 2:03 PM · Auto-closed, MITK
kislinsk triaged T26327: Deleting points is cumbersome as Low priority.
May 13 2019, 10:37 AM · Auto-closed, MITK

May 10 2019

kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

To get an overview of MITK subprojects:

May 10 2019, 11:01 AM · CI, MITK (v2021.02), Restricted Project

May 9 2019

kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

Pushed new branch T25882-CDash-v2.6.

May 9 2019, 9:04 AM · CI, MITK (v2021.02), Restricted Project
kislinsk renamed T25882: Rewrite dashboard script for CDash 2.6 from Figure out why the MITK CDash submission to e071-jenkins/cdash is not browsable to Figure out why CDash submissions to CDash 2.6 servers are not browsable.
May 9 2019, 9:01 AM · CI, MITK (v2021.02), Restricted Project
kislinsk added a project to T25882: Rewrite dashboard script for CDash 2.6: MITK (2018-04-4).
May 9 2019, 8:59 AM · CI, MITK (v2021.02), Restricted Project