Page MenuHomePhabricator
Feed Advanced Search

Mar 22 2023

floca moved T29461: TotalSegmentator output label names conundrum from Backlog to MITK Meeting on the Request for Discussion board.
Mar 22 2023, 9:03 AM · MITK

Mar 21 2023

kalali added a comment to T29496: [Workbench] Core dumped when mouse moved!.

I uploaded a fix in D783. Let's see if this will solve the issue also for Ubuntu.

Mar 21 2023, 7:46 PM · MITK
kislinsk closed T25316: ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins as Resolved.
Mar 21 2023, 6:28 PM · MITK
kislinsk added a comment to T25316: ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins.

Deleted branch from rMITK MITK: bugfix/T25316-EnableThemedIconsInEagerPlugins.

Mar 21 2023, 6:28 PM · MITK
kalali added a comment to T29496: [Workbench] Core dumped when mouse moved!.

I tested this on Windows with 4974a335ada8a85d7fba8d313e2efc20acc84b48, which was the latest develop I had, since I recently merged something into develop and couldn't reproduce the error.
Used StdMultiWidget, no other plugins open, no data loaded, only the widget planes available in the data storage.
I tested this with the commit given in the task description and couldn't reproduce the error there as well.

Mar 21 2023, 6:05 PM · MITK
a178n updated the task description for T29496: [Workbench] Core dumped when mouse moved!.
Mar 21 2023, 5:18 PM · MITK
a178n triaged T29496: [Workbench] Core dumped when mouse moved! as Unbreak Now! priority.
Mar 21 2023, 5:17 PM · MITK
kislinsk added a revision to T25316: ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins: Restricted Differential Revision.
Mar 21 2023, 1:24 PM · MITK
kislinsk added a comment to T25316: ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins.

Pushed new branch to rMITK MITK: bugfix/T25316-EnableThemedIconsInEagerPlugins.

Mar 21 2023, 1:21 PM · MITK
kislinsk claimed T25316: ThemeIcon() of QmitkStyleManager and berryQtStyleManager does not work with eager plugins.
Mar 21 2023, 1:15 PM · MITK
floca added a parent task for T29449: [SEG] Allow predefined label list and optional label list to indicate if multiple instances of a label are allowed.: T29495: [SEG] Rework segmentation view UX.
Mar 21 2023, 8:52 AM · MITK

Mar 20 2023

kalali updated the task description for T29493: RenderWindow management classes need to be revised / cleaned.
Mar 20 2023, 1:33 PM · MITK (v2024.06)
kislinsk closed T29432: [worklist] mitk-flow preload first task as Wontfix.

While the original issue is rather easy to resolve by exchanging the class to data->Modified() with a RequestRenderWindowAll() (which is the actual intent anyway according to the comments), more hurdles start to appear that are not as easy to resolve.

The data loading that is now happening immediately, is happening even before the rendering manager has any registered render windows. Any geometry validation of the data against render window geometries is a no-op, and it is kind of okay as it just works. However, when now adding another label in the GUI for example, the Segmentation View again does its data validation and now there ARE render windows with geometries and these do not match the segmentation geometry, resulting in the Segmentation View complaining about a necessary reinit (that is not necessary, yet is technically correct). There are many strategies to resolve this issue, none of them seem easy. The most straight-forward concept at least would be to defer loading of any data until the application is done with initializing its plugins and editors. That would probably require some kind of "ready" event triggered which could be used to load data specificied on the command-line.

Mar 20 2023, 11:38 AM · MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Deleted branch from rMITK MITK: feature/T29432-PreloadFirstTask2.

Mar 20 2023, 11:36 AM · MITK

Mar 18 2023

a178n added a comment to T29461: TotalSegmentator output label names conundrum.

After meeting it is decided that:

  1. Label names/classes & their pixel values that are hardcoded in the python codebase will be parsed directly and shown in MITK for 2023.04 release (Ref: https://github.com/wasserth/TotalSegmentator/blob/master/totalsegmentator/map_to_binary.py)
  2. Certain subtasks which need multiple nifti file agglomeration (eg. "Body") will not be included in the 2023.04 release.
Mar 18 2023, 7:15 PM · MITK

Mar 17 2023

kalali triaged T29493: RenderWindow management classes need to be revised / cleaned as Normal priority.
Mar 17 2023, 4:49 PM · MITK (v2024.06)
kalali added a revision to T26555: [mxn multi widget] Provide different default layouts: Restricted Differential Revision.
Mar 17 2023, 3:32 PM · MITK

Mar 16 2023

kislinsk closed T29488: 2023 Week 11 (Mid March) as Resolved.
Mar 16 2023, 8:05 AM · MITK
kislinsk edited the content of Changelog.
Mar 16 2023, 8:05 AM · MITK
kislinsk added a comment to T29488: 2023 Week 11 (Mid March).

Deleted branch from rMITK MITK: release/T29488-2023-Week-11.

Mar 16 2023, 8:03 AM · MITK
kislinsk added a comment to T29488: 2023 Week 11 (Mid March).

Pushed new branch to rMITK MITK: release/T29488-2023-Week-11.

Mar 16 2023, 6:45 AM · MITK
kislinsk triaged T29488: 2023 Week 11 (Mid March) as Normal priority.
Mar 16 2023, 6:38 AM · MITK

Mar 15 2023

kislinsk closed T29481: Fix and unify include guards as Resolved.
Mar 15 2023, 1:31 PM · MITK
kislinsk added a comment to T29481: Fix and unify include guards.

Deleted branch from rMITK MITK: bugfix/T29481-FixOddIncludeGuard.

Mar 15 2023, 1:31 PM · MITK
kislinsk added a comment to T29481: Fix and unify include guards.

Pushed new branch to rMITK MITK: bugfix/T29481-FixOddIncludeGuard.

Mar 15 2023, 1:30 PM · MITK
kislinsk reopened T29481: Fix and unify include guards as "Open".
Mar 15 2023, 1:28 PM · MITK

Mar 10 2023

kislinsk added a comment to T29482: [Segmentation] Opened segmentation plugin and two binary mask in data manager lead to problems / crash.

I noticed that it only happens in v2022.10 but not in the latest develop so chances are high that it is already fixed but it should be double-checked with the upcoming snapshot installer.

Mar 10 2023, 1:09 PM · MITK (v2023.04)
kahl triaged T29482: [Segmentation] Opened segmentation plugin and two binary mask in data manager lead to problems / crash as High priority.
Mar 10 2023, 12:19 PM · MITK (v2023.04)

Mar 9 2023

kislinsk closed T29481: Fix and unify include guards as Resolved.
Mar 9 2023, 2:50 PM · MITK
kislinsk added a comment to T29481: Fix and unify include guards.

Deleted branch from rMITK MITK: bugfix/T29481-FixAndUnifyIncludeGuards.

Mar 9 2023, 2:50 PM · MITK
kislinsk added a comment to T29481: Fix and unify include guards.

Pushed new branch to rMITK MITK: bugfix/T29481-FixAndUnifyIncludeGuards.

Mar 9 2023, 1:55 PM · MITK
kislinsk triaged T29481: Fix and unify include guards as Normal priority.
Mar 9 2023, 1:13 PM · MITK
kislinsk closed T29480: [Segmentation] Remove unused classes and icons as Resolved.
Mar 9 2023, 9:47 AM · MITK
kislinsk added a comment to T29480: [Segmentation] Remove unused classes and icons.

Deleted branch from rMITK MITK: bugfix/T29480-RemoveUnusedFiles.

Mar 9 2023, 9:46 AM · MITK
kislinsk added a comment to T29480: [Segmentation] Remove unused classes and icons.

Pushed new branch to rMITK MITK: bugfix/T29480-RemoveUnusedFiles.

Mar 9 2023, 9:45 AM · MITK
kislinsk triaged T29480: [Segmentation] Remove unused classes and icons as Low priority.
Mar 9 2023, 9:44 AM · MITK

Mar 8 2023

a178n placed T29459: Docker support for TotalSegmentator up for grabs.
Mar 8 2023, 2:44 PM · MITK

Mar 3 2023

kalali added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

Pushed new branch to rMITK MITK: feature/T28578-Test-MxN-installer.

Mar 3 2023, 2:11 PM · MITK
a178n added a comment to T29468: Let MITK handle TotalSegmentator setup.

Pushed new branch to rMITK MITK: feature/T29468-totalsegmentator-install.

Mar 3 2023, 9:46 AM · MITK (v2023.04)
a178n added a comment to T29468: Let MITK handle TotalSegmentator setup.

Deleted branch from rMITK MITK: feature/T29468-total-segmentator-install.

Mar 3 2023, 9:43 AM · MITK (v2023.04)
a178n added a comment to T29468: Let MITK handle TotalSegmentator setup.

Pushed new branch to rMITK MITK: feature/T29468-total-segmentator-install.

Mar 3 2023, 9:24 AM · MITK (v2023.04)

Feb 28 2023

kislinsk added a comment to T29317: Clean up DICOM Browser plugin.

From a first glimpse it really needs to be continued before merging. Can't make much sense right now out of mitk::StoreSCPLauncherBuilder in parallel to QmitkStoreSCPLauncher::Params. Have to take a closer look.

Feb 28 2023, 10:00 AM · MITK (v2024.06)
floca added a comment to T29317: Clean up DICOM Browser plugin.

Should we integrate that in develop? Or any reason to wait?

Feb 28 2023, 8:47 AM · MITK (v2024.06)

Feb 27 2023

kislinsk closed T29471: Update text of MITK Workbench About dialog as Resolved.
Feb 27 2023, 1:55 PM · MITK
kislinsk added a comment to T29471: Update text of MITK Workbench About dialog.

Deleted branch from rMITK MITK: bugfix/T29471-UpdateAboutDialog.

Feb 27 2023, 1:55 PM · MITK
kislinsk added a comment to T29471: Update text of MITK Workbench About dialog.

Pushed new branch to rMITK MITK: bugfix/T29471-UpdateAboutDialog.

Feb 27 2023, 1:54 PM · MITK
kislinsk triaged T29471: Update text of MITK Workbench About dialog as Wishlist priority.
Feb 27 2023, 1:51 PM · MITK
kislinsk placed T29412: List of MITK publications on web page is not up to date up for grabs.
Feb 27 2023, 11:00 AM · MITK

Feb 23 2023

a178n added a comment to T29461: TotalSegmentator output label names conundrum.

for "ii" the developments of T29392 could be of help (if we also implement a reader of this kind). But we would still need to generate the meta info file

Feb 23 2023, 6:38 PM · MITK
kislinsk closed T29470: Fix stray plugin manuals as Resolved.
Feb 23 2023, 6:41 AM · MITK
kislinsk added a comment to T29470: Fix stray plugin manuals.

Deleted branch from rMITK MITK: bugfix/T29470-FixPluginManuals.

Feb 23 2023, 6:40 AM · MITK
kislinsk added a comment to T29470: Fix stray plugin manuals.

Pushed new branch to rMITK MITK: bugfix/T29470-FixPluginManuals.

Feb 23 2023, 6:38 AM · MITK
kislinsk triaged T29470: Fix stray plugin manuals as Normal priority.
Feb 23 2023, 6:27 AM · MITK

Feb 22 2023

s434n claimed T26555: [mxn multi widget] Provide different default layouts.
Feb 22 2023, 5:11 PM · MITK
aklein triaged T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS as Normal priority.
Feb 22 2023, 5:04 PM · MITK (v2023.04)
a178n triaged T29468: Let MITK handle TotalSegmentator setup as Normal priority.
Feb 22 2023, 4:04 PM · MITK (v2023.04)
a178n removed a project from T29465: How to display available statistics of segmentation: Request for Discussion.
Feb 22 2023, 1:59 PM · MITK
floca triaged T29465: How to display available statistics of segmentation as Wishlist priority.

I see no value currently, as we have our own statistic backend/view.

Feb 22 2023, 1:40 PM · MITK
a178n added a comment to T29466: [SEG][Bug] Manually modified label name not reflected accordingly in Preview labels.

Discussion result:
A pragmatic solution would be to get the label names from the qTable as late as possible i.e when the results are returned for the Preview.

Feb 22 2023, 12:10 PM · MITK
a178n triaged T29466: [SEG][Bug] Manually modified label name not reflected accordingly in Preview labels as Low priority.
Feb 22 2023, 12:08 PM · MITK

Feb 21 2023

a178n created T29466: [SEG][Bug] Manually modified label name not reflected accordingly in Preview labels.
Feb 21 2023, 10:50 PM · MITK
a178n added a comment to T29465: How to display available statistics of segmentation.

How about something like this but in the Preview labels list? Once confirmed, this tail end info will can be pruned and only Label names are transferred.

Feb 21 2023, 12:53 PM · MITK
a178n created T29465: How to display available statistics of segmentation.
Feb 21 2023, 12:47 PM · MITK

Feb 20 2023

a178n updated subscribers of T29462: TotalSegmentator (Python) issues.
Feb 20 2023, 11:23 PM · MITK
a178n added a comment to T29462: TotalSegmentator (Python) issues.
  1. The install instruction pip install TotalSegmentator installed Pytorch CPU version on Windows eventhough there is Nvidia GPU and Cuda drivers available. Not sure this is problem of TotalSegmentator dependency specification or a general pip on Windows issue. Anyway, I had to manually uninstall pytorch cpu version and install again with the cuda supported package.
Feb 20 2023, 11:22 PM · MITK
a178n added a comment to T29462: TotalSegmentator (Python) issues.
  1. No explicit CPU only inferencing possible. Currently, whether or not the inferencing would run on cpu or gpu is decided by the installation of pytorch in the virtual environment. This might not be enough for MITK tool stability guarantee across all user machines.
Feb 20 2023, 11:20 PM · MITK
a178n added a comment to T29462: TotalSegmentator (Python) issues.
  1. The installation and run command documentation is not working exactly as per documentation on Windows.

The run command TotalSegmentator -i ct.nii.gz -o segmentations doesn't seem to work because the install instruction pip install TotalSegmentator is not creating TotalSegmentator.exe file inside the ~\venv\Scirpts\ location.
Instead, the pip installation merely keeps a python file. Hence, the correct invocation command would then be python ~\venv\Scirpts\TotalSegmentator -i ct.nii.gz -o segmentations.

Feb 20 2023, 11:17 PM · MITK
a178n added a comment to T29462: TotalSegmentator (Python) issues.
  1. Output segmentation nifti file comes without any label-pixel metadata eg. in json format , eventhough its known until the last moment before writing it out. Ref. T29461
Feb 20 2023, 11:10 PM · MITK
a178n triaged T29462: TotalSegmentator (Python) issues as Low priority.
Feb 20 2023, 11:07 PM · MITK
a178n added a comment to T29461: TotalSegmentator output label names conundrum.

Hi Ralf,
I did some digging into the TotalSegmentator python code.
So yes, (I believe) label names/classes & their pixel values are hardcoded in the python codebase. Ref: https://github.com/wasserth/TotalSegmentator/blob/master/totalsegmentator/map_to_binary.py
I couldn't find any documentational guarantee for it. Maybe we can double check on it. But the statistics generation (--statistics flag) uses this map to calculate volume & intensity of each label. So it's a safe assumption.

Feb 20 2023, 4:44 PM · MITK
floca changed the status of T27569: US DICOM images are displayed turquoise and LUT cannot be changed, a subtask of T27554: Handling of 2D and 2D+t sonographic (US) images, from Wontfix to Resolved.
Feb 20 2023, 9:51 AM · Restricted Project, MITK
floca changed the status of T27569: US DICOM images are displayed turquoise and LUT cannot be changed from Wontfix to Resolved.
Feb 20 2023, 9:51 AM · Restricted Project, MITK
floca closed T27569: US DICOM images are displayed turquoise and LUT cannot be changed as Wontfix.

GDCM 3.0.11 introduced a quickfic/hack to handle that correctly. (At least for the test data it works now.)

Feb 20 2023, 9:51 AM · Restricted Project, MITK
floca closed T27569: US DICOM images are displayed turquoise and LUT cannot be changed, a subtask of T27554: Handling of 2D and 2D+t sonographic (US) images, as Wontfix.
Feb 20 2023, 9:51 AM · Restricted Project, MITK
floca added a comment to T29461: TotalSegmentator output label names conundrum.

for "ii" the developments of T29392 could be of help (if we also implement a reader of this kind). But we would still need to generate the meta info file

Feb 20 2023, 9:14 AM · MITK

Feb 19 2023

a178n created T29461: TotalSegmentator output label names conundrum.
Feb 19 2023, 8:35 PM · MITK

Feb 15 2023

floca added a comment to T29456: Datastore access facility in MONAILabel tool.

I think we should post pone that for now. And revisit if we have a concrete use case /user request

Feb 15 2023, 11:12 AM · MITK
a178n updated subscribers of T29456: Datastore access facility in MONAILabel tool.
Feb 15 2023, 10:36 AM · MITK
floca placed T29456: Datastore access facility in MONAILabel tool up for grabs.
Feb 15 2023, 10:34 AM · MITK
a178n updated the task description for T29456: Datastore access facility in MONAILabel tool.
Feb 15 2023, 9:11 AM · MITK
kislinsk lowered the priority of T29412: List of MITK publications on web page is not up to date from High to Normal.
Feb 15 2023, 8:40 AM · MITK

Feb 14 2023

a178n triaged T29456: Datastore access facility in MONAILabel tool as Normal priority.
Feb 14 2023, 10:51 PM · MITK

Feb 13 2023

kislinsk added a comment to T29381: Move Multilabel classes to Core module.

I tried today to move everything from MitkMultilabel into MitkSegmentation but it generates some dependency cycles issues like for modules that sit in between MitkMultilabel and MitkSegmentation.

Feb 13 2023, 12:04 PM · MITK, Request for Discussion
kislinsk triaged T29452: Setting arbitrary label names to a LabelSetImage can be more straightforward as Wishlist priority.
Feb 13 2023, 10:35 AM · MITK, Request for Discussion
kislinsk placed T29432: [worklist] mitk-flow preload first task up for grabs.
Feb 13 2023, 10:34 AM · MITK
a178n triaged T29455: Avoid image R/W to disk for MonaiLabel REST transactions as Normal priority.
Feb 13 2023, 10:19 AM · MITK

Feb 8 2023

a178n added a comment to T29451: [SEG] Response labels all not displayed on Workbench.

In the meeting it was decided that a decision regarding whether or not to replace or add labels will be still in RFD.
Decision will be later on after further discussion with the group, in conjunction with Ralf's planned changes in the tool API classes.

Feb 8 2023, 12:12 PM · Cleared, MITK (v2023.04)
kislinsk added a project to T29451: [SEG] Response labels all not displayed on Workbench: MITK.
Feb 8 2023, 11:25 AM · Cleared, MITK (v2023.04)
kislinsk removed a project from T29432: [worklist] mitk-flow preload first task: Request for Discussion.
Feb 8 2023, 11:19 AM · MITK
kislinsk removed a project from T29449: [SEG] Allow predefined label list and optional label list to indicate if multiple instances of a label are allowed.: Request for Discussion.
Feb 8 2023, 11:00 AM · MITK
kislinsk triaged T29449: [SEG] Allow predefined label list and optional label list to indicate if multiple instances of a label are allowed. as Normal priority.

We decided that it is a nice and maybe necessary feature so we want to encode it somehow.

Feb 8 2023, 11:00 AM · MITK

Feb 7 2023

floca renamed T29454: Clarify the versions/editions we publish as installer from Clarify the versions/edtions we publish as installer to Clarify the versions/editions we publish as installer.
Feb 7 2023, 7:44 PM · MITK (v2024.06), Request for Discussion
floca moved T29454: Clarify the versions/editions we publish as installer from Backlog to MITK Meeting on the Request for Discussion board.
Feb 7 2023, 7:44 PM · MITK (v2024.06), Request for Discussion
floca triaged T29454: Clarify the versions/editions we publish as installer as High priority.
Feb 7 2023, 7:44 PM · MITK (v2024.06), Request for Discussion

Feb 6 2023

a178n updated the task description for T29453: Unreachable catch block in OTSU?.
Feb 6 2023, 4:30 PM · MITK
a178n created T29453: Unreachable catch block in OTSU?.
Feb 6 2023, 3:52 PM · MITK

Feb 3 2023

a178n updated subscribers of T29452: Setting arbitrary label names to a LabelSetImage can be more straightforward.
Feb 3 2023, 2:09 PM · MITK, Request for Discussion
a178n updated subscribers of T29452: Setting arbitrary label names to a LabelSetImage can be more straightforward.
Feb 3 2023, 2:08 PM · MITK, Request for Discussion
a178n created T29452: Setting arbitrary label names to a LabelSetImage can be more straightforward.
Feb 3 2023, 2:08 PM · MITK, Request for Discussion
a178n added a comment to T29379: MONAI Label REST Response JSON issues, allegedly.

Hi Ralf,

Feb 3 2023, 1:52 PM · MITK