Page MenuHomePhabricator
Feed Advanced Search

Oct 29 2021

kislinsk added a project to T28802: 2021 Week 45 (Early November): MITK-ProjectTemplate.
Oct 29 2021, 4:12 PM · MITK (v2021.10)
kislinsk added a comment to T28802: 2021 Week 45 (Early November).
Oct 29 2021, 4:11 PM · MITK (v2021.10)
kislinsk triaged T28802: 2021 Week 45 (Early November) as Normal priority.
Oct 29 2021, 4:10 PM · MITK (v2021.10)
kislinsk renamed MITK v2021.10 from Release-v2021.10 to MITK v2021.10.
Oct 29 2021, 4:09 PM
kislinsk created an object: MITK v2021.10.
Oct 29 2021, 4:08 PM
kislinsk updated the task description for T28798: [Segmentation][MultiLabel][Utilities] UI is inconsistent / unstable.
Oct 29 2021, 3:38 PM · MITK (v2024.06), Checklist
kislinsk updated the task description for T28794: [Image Statistics] Crash when dynamic segmentation does not have a segmentation in the current time step.
Oct 29 2021, 2:52 PM · MITK (v2021.10)
kislinsk triaged T28794: [Image Statistics] Crash when dynamic segmentation does not have a segmentation in the current time step as High priority.
Oct 29 2021, 2:51 PM · MITK (v2021.10)
kislinsk triaged T28788: [Image Statistics] "Ignore zero-valued voxels" checkbox active when no data selected as Low priority.
Oct 29 2021, 1:02 PM · Checklist, MITK
kislinsk triaged T28787: Support outlines of binary images in 3-d render windows as Wishlist priority.
Oct 29 2021, 12:50 PM · Request for Discussion, MITK
kislinsk added a comment to T28207: MITK DicomBrowser q/r Retrieve part crash.

Just a ping because it was triggered by a checklist for the upcoming release.

Oct 29 2021, 11:50 AM · MITK, Checklist
kislinsk triaged T28782: Scanning directories in DICOM Browser -> Import only works once as Normal priority.
Oct 29 2021, 11:49 AM · MITK, Checklist
kislinsk triaged T28781: Selected series and studies cannot be deleted from DICOM browser without deleting the whole patient as Normal priority.
Oct 29 2021, 11:46 AM · MITK, Checklist
kislinsk updated subscribers of T28778: "Use constraint zooming and panning" is only applied after reinit/restart.
Oct 29 2021, 11:35 AM · MITK, Checklist
kislinsk triaged T28779: Saving projects with Umlauts uses wrong encoding for file name as Normal priority.
Oct 29 2021, 11:35 AM · MITK (v2022.10), Checklist
kislinsk triaged T28778: "Use constraint zooming and panning" is only applied after reinit/restart as Low priority.
Oct 29 2021, 11:26 AM · MITK, Checklist
kislinsk triaged T28777: Resetting Standard Multi Widget preferences leads to other colors than the default ones as Low priority.
Oct 29 2021, 11:16 AM · MITK (v2022.04), Checklist
kislinsk added a comment to T28769: Crash when loading two images with very different spacings.
  • recon_+300_00163.tif has 72 pixels/inch (which is a common default value for strange early-day web reasons)
  • Grey Channel321 UBYTE0010.tif has 2540 pixels/inch or 1000 pixels/cm (which seems to be either the original value or something a program or programmer completely made up as default)
Oct 29 2021, 10:01 AM · MITK
kislinsk renamed T28769: Crash when loading two images with very different spacings from Crash when loading an image while another one is already loaded to Crash when loading two images with very different spacings.
Oct 29 2021, 9:50 AM · MITK
kislinsk closed T28769: Crash when loading two images with very different spacings as Wontfix.
Oct 29 2021, 9:50 AM · MITK
kislinsk added a comment to T28769: Crash when loading two images with very different spacings.

142700 happens to be exactly the original image dimension times 100. Looking at the geometry of Grey Channel321 UBYTE0010.tif I noticed that the spacing is 0.01 in all directions. As long as it is loaded as single image, our 2-d image mapper just creates a texture with the original extent but as soon as there is the other image with the same extents but a spacing of 1 in all directions the least common multiple size for a common texture is 142700x142700.

Oct 29 2021, 9:49 AM · MITK
kislinsk claimed T28769: Crash when loading two images with very different spacings.

Somewhere deep in the VTK rendering pipeline the extent of an image is suddenly set to 142700x142700 which is the 20 GB of memory that can be observed.

Oct 29 2021, 9:26 AM · MITK
kislinsk added a comment to T28769: Crash when loading two images with very different spacings.
  • It works when any other 3-d data like Pic3D.nrrd or ball.stl is already opened.
  • The problematic image is Grey Channel321 UBYTE0010.tif which initiates the condition
    • Loading recon_+300_00163.tif image twice works
    • Loading recon_+300_00163.tif and Png2D-bw.png works
    • Loading Grey Channel321 UBYTE0010.tif twice works
    • Loading Grey Channel321 UBYTE0010.tif and any other 2-d images crashes
Oct 29 2021, 8:51 AM · MITK
kislinsk renamed T28769: Crash when loading two images with very different spacings from Crash when loading two images at the same time to Crash when loading an image while another one is already loaded.
Oct 29 2021, 8:38 AM · MITK
kislinsk renamed T28769: Crash when loading two images with very different spacings from Trying to load these two images? You won't believe what happens next...! to Crash when loading two images at the same time.
Oct 29 2021, 8:34 AM · MITK

Oct 27 2021

kislinsk closed T28771: Serialized 3-d interpolation surfaces of static images are invisible after reloading of project file as Resolved.
Oct 27 2021, 12:24 PM · MITK (v2021.10)
kislinsk added a comment to T28771: Serialized 3-d interpolation surfaces of static images are invisible after reloading of project file.

Deleted branch from rMITK MITK: bugfix/T28771-FixNegInfInSerializedGeometryProps.

Oct 27 2021, 12:23 PM · MITK (v2021.10)
kislinsk committed rMITKbab4bd9ca8cb: Change negative infinity values to lowest possible values (authored by kislinsk).
Change negative infinity values to lowest possible values
Oct 27 2021, 12:23 PM
kislinsk committed rMITK190498356f77: Merge branch 'bugfix/T28771-FixNegInfInSerializedGeometryProps' into develop (authored by kislinsk).
Merge branch 'bugfix/T28771-FixNegInfInSerializedGeometryProps' into develop
Oct 27 2021, 12:23 PM
kislinsk added a comment to T28771: Serialized 3-d interpolation surfaces of static images are invisible after reloading of project file.

Pushed new branch to rMITK MITK: bugfix/T28771-FixNegInfInSerializedGeometryProps.

Oct 27 2021, 12:23 PM · MITK (v2021.10)
kislinsk triaged T28771: Serialized 3-d interpolation surfaces of static images are invisible after reloading of project file as Normal priority.
Oct 27 2021, 12:20 PM · MITK (v2021.10)
kislinsk triaged T28761: Github Pull Request #252 SurfaceToImageFilter Bug as Normal priority.
Oct 27 2021, 6:19 AM · Pull Request, MITK

Oct 26 2021

kislinsk updated the task description for T28761: Github Pull Request #252 SurfaceToImageFilter Bug.
Oct 26 2021, 9:19 AM · Pull Request, MITK

Oct 25 2021

kislinsk committed rMD2e8be6da8fa3: Remove/convert last .pic files (authored by kislinsk).
Remove/convert last .pic files
Oct 25 2021, 2:15 PM

Oct 21 2021

kislinsk added a comment to T28756: [Segmentation] 3-d picking tool crashes with dynamic segmentations.

Found the problem. It is not a error in the picking tool.

It is in

void mitk::LabelSetImage::ClearBuffer()

Because AccessByItk (which is used there) by default only supports 2D and 3D. -> Exception when trying to reset dynamic LabelSetImages.

So far I see the following solutions:

  1. Add 4D as a CMake default (but would impact a lot of code...)
  2. Add in clear buffer a check if instance is 4D and if so explizitly call it for 4D (in other cases use AccessByItk as we did so far.

@kislinsk Do you see an other option? Which one would you choose?

Oct 21 2021, 10:46 AM · MITK (v2021.10)

Oct 20 2021

kislinsk edited the content of 2021 Week 42 (Late October).
Oct 20 2021, 8:14 AM
kislinsk moved T28756: [Segmentation] 3-d picking tool crashes with dynamic segmentations from Backlog to Cycle on the MITK (v2021.10) board.
Oct 20 2021, 7:48 AM · MITK (v2021.10)
kislinsk triaged T28756: [Segmentation] 3-d picking tool crashes with dynamic segmentations as Unbreak Now! priority.
Oct 20 2021, 7:48 AM · MITK (v2021.10)
kislinsk triaged T28755: [Segmentation] Labels can only be Confirmed once in Segmentation tools after Preview as Wishlist priority.
Oct 20 2021, 7:01 AM · Auto-closed, Request for Discussion, MITK

Oct 18 2021

kislinsk closed T28750: 2021 Week 42 (Late October) as Resolved.
Oct 18 2021, 11:57 AM · MITK
kislinsk edited the content of Changelog.
Oct 18 2021, 11:56 AM · MITK
kislinsk added a comment to T28750: 2021 Week 42 (Late October).

Deleted branch from rMITK MITK: release/T28750-2021-Week-42.

Oct 18 2021, 11:56 AM · MITK
kislinsk committed rMITK9e0e53e22e44: Merge branch 'master' into develop (authored by kislinsk).
Merge branch 'master' into develop
Oct 18 2021, 11:55 AM
kislinsk committed rMITK7e60e56bab60: 2021 Week 42 (Late October) (authored by kislinsk).
2021 Week 42 (Late October)
Oct 18 2021, 11:54 AM
kislinsk edited the content of 2021 Week 42 (Late October).
Oct 18 2021, 11:49 AM
kislinsk edited the content of 2021 Week 39 (Very Early October).
Oct 18 2021, 10:56 AM
kislinsk added a comment to T28750: 2021 Week 42 (Late October).

Pushed new branch to rMITK MITK: release/T28750-2021-Week-42.

Oct 18 2021, 9:47 AM · MITK
kislinsk triaged T28750: 2021 Week 42 (Late October) as Normal priority.
Oct 18 2021, 9:46 AM · MITK
kislinsk renamed 2021 Week 42 (Late October) from 2021.42 to 2021 Week 42 (Late October).
Oct 18 2021, 9:45 AM
kislinsk created an object: 2021 Week 42 (Late October).
Oct 18 2021, 9:45 AM
kislinsk closed T28749: libxdamage can be a runtime dependence on Ubuntu 20.04 as Resolved.
Oct 18 2021, 9:40 AM · MITK (v2021.10)
kislinsk added a comment to T28749: libxdamage can be a runtime dependence on Ubuntu 20.04.

Deleted branch from rMITK MITK: bugfix/T28749-libxdamage.

Oct 18 2021, 9:40 AM · MITK (v2021.10)
kislinsk committed rMITK3ffe860e1173: Add libxdamage-dev to prerequisites (authored by kislinsk).
Add libxdamage-dev to prerequisites
Oct 18 2021, 9:39 AM
kislinsk committed rMITK272b664745e2: Merge branch 'bugfix/T28749-libxdamage' into develop (authored by kislinsk).
Merge branch 'bugfix/T28749-libxdamage' into develop
Oct 18 2021, 9:39 AM
kislinsk added a comment to T28749: libxdamage can be a runtime dependence on Ubuntu 20.04.

Pushed new branch to rMITK MITK: bugfix/T28749-libxdamage.

Oct 18 2021, 9:39 AM · MITK (v2021.10)
kislinsk triaged T28749: libxdamage can be a runtime dependence on Ubuntu 20.04 as Normal priority.
Oct 18 2021, 9:35 AM · MITK (v2021.10)

Oct 17 2021

kislinsk lowered the priority of T28726: [Segmentation] Temporal interpolation from Normal to Wishlist.
Oct 17 2021, 10:50 AM · Auto-closed, MITK

Oct 15 2021

kislinsk committed rMITKc051ab3b0b7a: First refactoring of both the QmitkSegmentationView and the… (authored by kalali).
First refactoring of both the QmitkSegmentationView and the…
Oct 15 2021, 1:48 PM
kislinsk committed rMITKdc6e037fc738: First refactoring of both the QmitkSegmentationView and the… (authored by kalali).
First refactoring of both the QmitkSegmentationView and the…
Oct 15 2021, 1:48 PM
kislinsk committed rMITK2721496a782c: Use override specifier (authored by kalali).
Use override specifier
Oct 15 2021, 1:34 PM
kislinsk committed rMITKe6c8e07c53e1: Use override specifier (authored by kalali).
Use override specifier
Oct 15 2021, 1:34 PM
kislinsk committed rMITKf5a5be1edde0: Prevent auto repeat mode from infinite loop (authored by kalali).
Prevent auto repeat mode from infinite loop
Oct 15 2021, 1:33 PM
kislinsk committed rMITKeb214f06addb: Prevent auto repeat mode from infinite loop (authored by kalali).
Prevent auto repeat mode from infinite loop
Oct 15 2021, 1:33 PM
kislinsk committed rMITK15955aa5ec8f: Send active render window (authored by kalali).
Send active render window
Oct 15 2021, 1:32 PM
kislinsk committed rMITK7033b69669d2: Send active render window (authored by kalali).
Send active render window
Oct 15 2021, 1:32 PM
kislinsk claimed T28736: Preferences for segmentation '2D display' are not properly utilized.

I already implemented something but it is not yet finished.

Oct 15 2021, 1:01 PM · MITK (v2022.04)
kislinsk committed rMITK8770978862e2: Use semantically correct minimum for value range in region growing preview (authored by kislinsk).
Use semantically correct minimum for value range in region growing preview
Oct 15 2021, 10:11 AM
kislinsk closed T28732: [Segmentation] 3d region growing does not work with low seed point values as Resolved by committing rMITK8770978862e2: Use semantically correct minimum for value range in region growing preview.
Oct 15 2021, 10:11 AM · MITK (v2021.10)
kislinsk committed rMITK5445435a0d3b: Use semantically correct minimum for value range (authored by kislinsk).
Use semantically correct minimum for value range
Oct 15 2021, 10:11 AM
kislinsk closed T24358: Rework QmitkMouseModeSwitcher, a subtask of T24356: Rework mouse mode switcher, as Resolved.
Oct 15 2021, 9:16 AM · MITK
kislinsk closed T24358: Rework QmitkMouseModeSwitcher as Resolved.

Thanks!

Oct 15 2021, 9:16 AM · MITK
kislinsk reopened T24358: Rework QmitkMouseModeSwitcher as "Open".

This is a good candidate for some XML parsing errors that we see in the latest develop version of the MitkWorkbench, For example, activate any 3D segmentation tool and look at the console output:

Oct 15 2021, 7:20 AM · MITK
kislinsk reopened T24358: Rework QmitkMouseModeSwitcher, a subtask of T24356: Rework mouse mode switcher, as Open.
Oct 15 2021, 7:20 AM · MITK
kislinsk added a revision to T28732: [Segmentation] 3d region growing does not work with low seed point values: Unknown Object (Differential Revision).
Oct 15 2021, 7:01 AM · MITK (v2021.10)
kislinsk added a comment to T28732: [Segmentation] 3d region growing does not work with low seed point values.

BTW I recommend to test always with the latest snapshot installer instead of the last release.

Oct 15 2021, 6:53 AM · MITK (v2021.10)
kislinsk added a comment to T28732: [Segmentation] 3d region growing does not work with low seed point values.

Found the bug. The lower threshold for the region growing preview is set to itk::NumericTraits<TPixel>::min() when the region growing direction is downwards. However, itk::NumericTraits<TPixel>::min() is the wrong method as it has a different meaning for floating point values than the author obviously expected (compare to min() vs. lowest() in std::numeric_limits<>). The correct method is itk::NumericTraits<TPixel>::NonpositiveMin(), which works for all cases and is the right semantic minimum of a range of values.

Oct 15 2021, 6:51 AM · MITK (v2021.10)
kislinsk placed T27701: Overhaul or remove PluginGenerator up for grabs.
Oct 15 2021, 5:21 AM · MITK, Next Milestone

Oct 14 2021

kislinsk moved T28736: Preferences for segmentation '2D display' are not properly utilized from Backlog to Segmentation on the MITK (v2021.10) board.
Oct 14 2021, 9:21 PM · MITK (v2022.04)
kislinsk triaged T28736: Preferences for segmentation '2D display' are not properly utilized as Normal priority.

Workaround: (Re)open the MultiLabel Segmentation view after you converted the segmentation to make it work.

Oct 14 2021, 9:21 PM · MITK (v2022.04)
kislinsk closed T13958: Replace all *.pic and *.pic.gz files in MITK by *.nrrd, a subtask of T28737: Remove last remains of .pic support, as Resolved.
Oct 14 2021, 4:40 PM · Breaking Change, MITK (v2021.10)
kislinsk closed T13958: Replace all *.pic and *.pic.gz files in MITK by *.nrrd as Resolved.
Oct 14 2021, 4:40 PM · Auto-closed, Bugzilla, MITK
kislinsk committed rMD5a4c6a33cafc: Remove old and unused .pic files (authored by kislinsk).
Remove old and unused .pic files
Oct 14 2021, 4:40 PM
kislinsk committed rMITKb5ac3f575d59: Delete obsolete build files (authored by kislinsk).
Delete obsolete build files
Oct 14 2021, 4:39 PM
kislinsk committed rMITKfc88e9296dae: Remove or replace mentions of .pic with .nrrd in documentation (authored by kislinsk).
Remove or replace mentions of .pic with .nrrd in documentation
Oct 14 2021, 4:39 PM
kislinsk committed rMITK6c750e82f278: Remove deprecated IpPicSupportIO module (authored by kislinsk).
Remove deprecated IpPicSupportIO module
Oct 14 2021, 4:39 PM
kislinsk committed rMITK67e1c5c22c35: Remove dangling test cpp file (authored by kislinsk).
Remove dangling test cpp file
Oct 14 2021, 4:39 PM
kislinsk committed rMITK1fb6ee787609: Remove all references to .pic from code and use .nrrd files instead (authored by kislinsk).
Remove all references to .pic from code and use .nrrd files instead
Oct 14 2021, 4:39 PM
kislinsk committed rMITK2742996b13b5: Remove unused IpFunc and IpSegmentation libraries (authored by kislinsk).
Remove unused IpFunc and IpSegmentation libraries
Oct 14 2021, 4:39 PM
kislinsk committed rMITKd0d4142becfe: Remove unused parameters (authored by kislinsk).
Remove unused parameters
Oct 14 2021, 4:39 PM
kislinsk closed T28737: Remove last remains of .pic support as Resolved by committing rMITK8b0f5727d844: Remove last remains of .pic support.
Oct 14 2021, 4:39 PM · Breaking Change, MITK (v2021.10)
kislinsk committed rMITK8b0f5727d844: Remove last remains of .pic support (authored by kislinsk).
Remove last remains of .pic support
Oct 14 2021, 4:39 PM
kislinsk closed T28740: Update CI build status badges in README on GitHub as Resolved.
Oct 14 2021, 4:15 PM · MITK (v2021.10)
kislinsk added a comment to T28740: Update CI build status badges in README on GitHub.

Deleted branch from rMITK MITK: bugfix/T28740-CIBuildStatusBadges.

Oct 14 2021, 4:15 PM · MITK (v2021.10)
kislinsk committed rMITKdceeff50623c: Update CI build status badges (authored by kislinsk).
Update CI build status badges
Oct 14 2021, 4:14 PM
kislinsk committed rMITK20777f8400b8: Merge branch 'bugfix/T28740-CIBuildStatusBadges' into develop (authored by kislinsk).
Merge branch 'bugfix/T28740-CIBuildStatusBadges' into develop
Oct 14 2021, 4:14 PM
kislinsk added a comment to T28740: Update CI build status badges in README on GitHub.

Pushed new branch to rMITK MITK: bugfix/T28740-CIBuildStatusBadges.

Oct 14 2021, 4:14 PM · MITK (v2021.10)
kislinsk triaged T28740: Update CI build status badges in README on GitHub as Normal priority.
Oct 14 2021, 4:13 PM · MITK (v2021.10)
kislinsk closed T28739: Update supported platforms in Tier 1 as Resolved.
Oct 14 2021, 2:33 PM · MITK (v2021.10)
kislinsk added a comment to T28739: Update supported platforms in Tier 1.

Deleted branch from rMITK MITK: bugfix/T28739-UpdateSupportedTier1Platforms.

Oct 14 2021, 2:32 PM · MITK (v2021.10)
kislinsk committed rMITKef7421529ecd: Update supported platforms (authored by kislinsk).
Update supported platforms
Oct 14 2021, 2:32 PM