Page MenuHomePhabricator
Feed Advanced Search

Sep 10 2020

kislinsk added a comment to T24085: MITK make PACKAGE does not work on windows if Python is enabled.

Deleted branch T24085-mitk-python-installer-fix.

Sep 10 2020, 9:46 AM · MITK
kislinsk added a comment to T23343: Dicom editor can not load dicom segmentation objects.

Deleted branch T23343-enable-microservice-based-reading-for-dicom-editor.

Sep 10 2020, 9:46 AM · MICO (Demo MICCAI 2018), MITK (2018-04)
kislinsk added a comment to T23756: Investigate use of precompiled headers.

Deleted branch T23756-cotire.

Sep 10 2020, 9:46 AM · MITK
kislinsk added a comment to T24085: MITK make PACKAGE does not work on windows if Python is enabled.

Deleted branch T24085-correctly-install-SimpleITK-to-bin.

Sep 10 2020, 9:46 AM · MITK
kislinsk added a comment to T23342: Create demo for MICCAI .

Deleted branch T23342-MICCAI_2017_Tutorial.

Sep 10 2020, 9:46 AM · MICO (Demo_MICCAI_2017)
kislinsk added a comment to T22830: Build errors due to different pixel types.

Deleted branch T22830-fix-image-conversion-build-errors.

Sep 10 2020, 9:46 AM · MITK
kislinsk added a comment to T23339: Change default: Open DICOM data with new dicom reader .

Deleted branch T23339-change-dicom-reader-default.

Sep 10 2020, 9:46 AM · MITK, MICO (Demo_MICCAI_2017)
kislinsk added a comment to T22118: Use Qt's windeployqt.exe to deploy Qt instead of our current install rules.

Deleted branch T22118-create-Qt-installer.

Sep 10 2020, 9:46 AM · MITK
kislinsk added a comment to T22654: Extending the Segmentation plugin with a multi-region threshold-based tool.

Deleted branch T22654-threshold-components-tool.

Sep 10 2020, 9:46 AM · Pull Request, MITK
kislinsk added a comment to T22801: Update DicomToNRRD cmdApp to new reader system.

Deleted branch T22801-update-dicom2nrrd.

Sep 10 2020, 9:46 AM · Restricted Project, MITK
kislinsk added a comment to T22810: Add a tolerance parameter to SurfaceToImageFilter.

Deleted branch T22810-Add-tolerance-to-surfacetoimagefilter.

Sep 10 2020, 9:46 AM · Pull Request, MITK
kislinsk added a comment to T20223: MITK does not load RGB and RGBA test images.

Deleted branch T20223-RGBAImageFix.

Sep 10 2020, 9:46 AM · MITK (2016-11)
kislinsk added a comment to T19360: Compatibility with old scene files broken (Surface line width redefined from int to float).

Deleted branch T19360-legacy-scene-surface-line-width-incompatible.

Sep 10 2020, 9:46 AM · Pull Request, Bugzilla, MITK
kislinsk added a comment to T19801: MITK crashes when deleting planar figure with "Delete" key.

Deleted branch T19801-planar-figure-interactor-crash.

Sep 10 2020, 9:46 AM · MITK (2016-11), Bugzilla

Sep 9 2020

kislinsk added a revision to T27624: Fix Doxygen errors: Unknown Object (Differential Revision).
Sep 9 2020, 9:50 AM · MITK (v2021.02)
kislinsk added a comment to T27624: Fix Doxygen errors.

Pushed new branch bugfix/T27624-FixDoxygenErrors.

Sep 9 2020, 9:27 AM · MITK (v2021.02)
kislinsk closed T27670: [Documentation] invalid link in MITK Style Guide as Resolved.

Thanks!

Sep 9 2020, 3:28 AM · MITK (v2021.02)
kislinsk added a comment to T27670: [Documentation] invalid link in MITK Style Guide.

Deleted branch bugfix/T27670-InvalidLinkInStyleGuide.

Sep 9 2020, 3:27 AM · MITK (v2021.02)
kislinsk committed rMITK428b689257c2: Merge branch 'bugfix/T27670-InvalidLinkInStyleGuide' into develop (authored by kislinsk).
Merge branch 'bugfix/T27670-InvalidLinkInStyleGuide' into develop
Sep 9 2020, 3:26 AM
kislinsk added a comment to T27670: [Documentation] invalid link in MITK Style Guide.

Pushed new branch bugfix/T27670-InvalidLinkInStyleGuide.

Sep 9 2020, 3:26 AM · MITK (v2021.02)
kislinsk added a revision to T27697: Documentation feedback received from testers : Unknown Object (Differential Revision).
Sep 9 2020, 3:19 AM · Auto-closed, MITK
kislinsk closed T27661: [Documentation] Update "How to create a new MITK Module" as Resolved.
Sep 9 2020, 3:15 AM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27661: [Documentation] Update "How to create a new MITK Module".

Deleted branch bugfix/T27661-NewModuleDoc.

Sep 9 2020, 3:13 AM · Cleared, MITK (v2021.02)
kislinsk committed rMITKf502f8a50ebf: Merge branch 'bugfix/T27661-NewModuleDoc' into develop (authored by kislinsk).
Merge branch 'bugfix/T27661-NewModuleDoc' into develop
Sep 9 2020, 3:12 AM
kislinsk added a comment to T27661: [Documentation] Update "How to create a new MITK Module".

Pushed new branch bugfix/T27661-NewModuleDoc.

Sep 9 2020, 3:11 AM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27695: 2020 Week 36 (Very Early September).
Sep 9 2020, 2:58 AM · MITK
kislinsk committed rMITK46a8bcfc8862: Merge branch 'release/T27695-2020-Week-36' into develop (authored by kislinsk).
Merge branch 'release/T27695-2020-Week-36' into develop
Sep 9 2020, 2:49 AM
kislinsk added a comment to T27695: 2020 Week 36 (Very Early September).
Sep 9 2020, 2:46 AM · MITK
kislinsk committed rMITKc41827f2584d: Received feedback from tutorial testers (authored by thomass).
Received feedback from tutorial testers
Sep 9 2020, 2:28 AM
kislinsk committed rMITKb8cd14e19625: Received feedback from tutorial testers (authored by thomass).
Received feedback from tutorial testers
Sep 9 2020, 2:28 AM
kislinsk committed rMITK09cf4bd1c505: T27095 - Rework Multi-label segmentation documentation (authored by thomass).
T27095 - Rework Multi-label segmentation documentation
Sep 9 2020, 2:27 AM
kislinsk committed rMITK566d05687843: T27095 - Rework Multi-label segmentation documentation (authored by thomass).
T27095 - Rework Multi-label segmentation documentation
Sep 9 2020, 2:27 AM
kislinsk closed T27095: [MITKDoc] Revise MultiLabel Segmentation Plugin Documentation as Resolved by committing rMITK566d05687843: T27095 - Rework Multi-label segmentation documentation.
Sep 9 2020, 2:27 AM · MITK (v2021.02)

Sep 8 2020

kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

macOS MatchPoint errors that are actually just warnings should be fixed now as well. It's a bug in CMake/CTest and the workaround is to use launchers: https://gitlab.kitware.com/cmake/cmake/-/issues/20832

Sep 8 2020, 1:54 PM · CI, MITK (v2021.02), Restricted Project
kislinsk committed rMITK923677a343b7: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 8 2020, 1:08 PM
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

I finally found the source of the documentation errors by accident. It was a dot digraph with invalid flat edges between record shapes. I changed the shapes to boxes and it should work now.

Sep 8 2020, 10:49 AM · CI, MITK (v2021.02), Restricted Project
kislinsk committed rMITK2661a3470aff: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 8 2020, 10:45 AM
kislinsk triaged T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics) as Wishlist priority.
Sep 8 2020, 10:14 AM · HiGHmed, Kaapana (internal), MITK
kislinsk reassigned T27608: [MITKDoc] Documentation Refurbish - Developer Manual from kislinsk to kompan.
Sep 8 2020, 10:07 AM · MITK (v2024.06), Cleared
kislinsk added a comment to T27608: [MITKDoc] Documentation Refurbish - Developer Manual.

I re-created the branch above, branching off from the latest develop branch.

Sep 8 2020, 9:34 AM · MITK (v2024.06), Cleared
kislinsk added a comment to T27608: [MITKDoc] Documentation Refurbish - Developer Manual.

Pushed new branch bugfix/T27608-DocumentationRefurbish-DeveloperManual.

Sep 8 2020, 9:34 AM · MITK (v2024.06), Cleared
kislinsk added a comment to T27608: [MITKDoc] Documentation Refurbish - Developer Manual.

Deleted branch bugfix/T27608-DocumentationRefurbish-DeveloperManual.

Sep 8 2020, 9:33 AM · MITK (v2024.06), Cleared
kislinsk claimed T27661: [Documentation] Update "How to create a new MITK Module".
Sep 8 2020, 9:25 AM · Cleared, MITK (v2021.02)
kislinsk claimed T27608: [MITKDoc] Documentation Refurbish - Developer Manual.
Sep 8 2020, 9:25 AM · MITK (v2024.06), Cleared
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

I think I fixed the OpenCV Ant issue by updating the volume snapshot for our Ubuntu 20.04 cloud instances to include the environment variable ANT_HOME=/usr/share/ant.

Sep 8 2020, 9:25 AM · CI, MITK (v2021.02), Restricted Project

Sep 7 2020

kislinsk committed rMITKac0bf7f5dce1: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 7 2020, 11:11 AM

Sep 5 2020

kislinsk committed rMITK94c50addf1ed: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 5 2020, 10:17 PM
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

Pushed new branch bugfix/T25882-RewriteDashboardScript.

Sep 5 2020, 8:21 AM · CI, MITK (v2021.02), Restricted Project
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

Deleted branch bugfix/T25882-RewriteDashboardScript.

Sep 5 2020, 8:10 AM · CI, MITK (v2021.02), Restricted Project

Sep 4 2020

kislinsk added a comment to T27571: Multilabel segmentation does not work with US DICOM images.

Yes, they are in the workspace of the Nightlies but I hesitate to provide them externally as they have a bunch of problems. Besides the DICOM-loading problem that we currently have with the installers in general, the macOS MITK Workbench from the installer is not executable by clicking on the MitkWorkbench.app. One have to use the terminal, cd into the package and execute the actual MitkWorkbench executable.

Sep 4 2020, 3:46 PM · MITK (v2021.10), Missing Info, Restricted Project

Sep 3 2020

kislinsk added a comment to T27569: US DICOM images are displayed turquoise and LUT cannot be changed.

The Photometric Interpretation tag (0028,0004) of the Philips US image is set to YBR_FULL_422 and my first guess is that we do not take this tag fully into account, leading to a misinterpetation as RGB values while reading the data.

Sep 3 2020, 11:39 PM · Restricted Project, MITK
kislinsk added a comment to T27669: Dicom import issue with MITK binaries (package) and Ubuntu.

@kislinsk As a linux noob please pardon my question. Can we directly debug the nightly bild by the CI on e.g. Jonas system? I would like to see some of the parts of volume generation process running to see whats happening. My be it helps us getting a lead. At least we now a setup directly on site that makes the problems.

Sep 3 2020, 10:48 PM · Missing Info, DICOM, MITK
kislinsk closed T27700: Toolmanager multi instance support is not correctly integrated... as Resolved.
Sep 3 2020, 10:11 AM · MITK (v2021.02)
kislinsk committed rMITKf1533e373758: Add missing tool manager context in ML segmentation (authored by kislinsk).
Add missing tool manager context in ML segmentation
Sep 3 2020, 10:11 AM
kislinsk committed rMITKe1a806155657: Add notes to class documentations regarding ToolManager context (authored by kislinsk).
Add notes to class documentations regarding ToolManager context
Sep 3 2020, 10:11 AM
kislinsk committed rMITKef6df59d006c: Add missing tool manager context (authored by kislinsk).
Add missing tool manager context
Sep 3 2020, 10:11 AM
kislinsk renamed T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction from [Segmentation] Region Growing 2D now tends to oversegmentation to [Segmentation] Improve Region Growing 2D algorithm and interaction.
Sep 3 2020, 7:58 AM · MITK (v2024.06)
kislinsk added a comment to T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction.

We talked about this task in the group-5 meeting. It turned out that no more foreground pixels are added after the mouse button was released but that it is just a little slow on the test computer and the latest feedback contour wasn't yet calculated when the mouse button was released. So, not really a bug in my opinion. At least nothing new, since the algorithm of the tool did not change.

Sep 3 2020, 7:56 AM · MITK (v2024.06)
kislinsk triaged T27701: Overhaul or remove PluginGenerator as High priority.
Sep 3 2020, 7:28 AM · MITK, Next Milestone
kislinsk committed rMITKa3ba7555dc9b: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 3 2020, 7:24 AM
kislinsk committed rMITKfc5d8c5491d1: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 3 2020, 6:29 AM

Sep 2 2020

kislinsk added a revision to T27700: Toolmanager multi instance support is not correctly integrated...: Unknown Object (Differential Revision).
Sep 2 2020, 9:18 PM · MITK (v2021.02)
kislinsk updated subscribers of T27700: Toolmanager multi instance support is not correctly integrated....

Oh... @thomass just told me that there is also T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view where it is already resolved... nvm.

Sep 2 2020, 9:12 PM · MITK (v2021.02)
kislinsk added a comment to T27700: Toolmanager multi instance support is not correctly integrated....

Happens only the first time. When I delete all segmentations and then create another new segmentation, the tool widgets in both views are enabled. Might explain why I didn't notice it when doing D312, as I was sure that I tested this before.

Sep 2 2020, 8:17 PM · MITK (v2021.02)
kislinsk added a comment to T27700: Toolmanager multi instance support is not correctly integrated....
  • SegmentationInteractor is only used in ML Segmentation. I added the ML context.
  • I also added the ML context to the second call of GetToolManager() QmitkSurfaceStampWidget, it was simply forgotten
Sep 2 2020, 8:15 PM · MITK (v2021.02)
kislinsk claimed T27700: Toolmanager multi instance support is not correctly integrated....
Sep 2 2020, 7:58 PM · MITK (v2021.02)
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.
  • MITK_BUILD_OPTIONS for MITK cache vars
  • Check why there are documentation errors "lost edge a b" but when I manually "make doc" on the client, it works
  • OpenCV somehow seems to trigger Ant errors on Ubuntu only during the first build (problem in Nightlies)
  • First time build of MatchPoint triggers many warnings as errors on macOS
Sep 2 2020, 7:57 PM · CI, MITK (v2021.02), Restricted Project
kislinsk renamed T25882: Rewrite dashboard script for CDash 2.6 from Figure out why CDash submissions to CDash 2.6 servers are not browsable to Rewrite dashboard script for CDash 2.6.
Sep 2 2020, 7:54 PM · CI, MITK (v2021.02), Restricted Project
kislinsk committed rMITK8be1a44b0d0d: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 2 2020, 7:07 PM
kislinsk committed rMITKf83f03607806: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 2 2020, 2:19 PM
kislinsk committed rMITK9973ea6ada29: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 2 2020, 1:33 PM
kislinsk added a comment to T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported.

Deleted branch bugfix/T27436-HideInterpWidgetsInMultilabelSegView.

Sep 2 2020, 10:55 AM · Restricted Project, Cleared, MITK (v2021.02)
kislinsk added a comment to T27095: [MITKDoc] Revise MultiLabel Segmentation Plugin Documentation.

Notes for the Region Growing 2D tool:

  • The tool operates based on the current level window, so changing the level window to optimize the contrast for the ROI should be encouraged
  • Moving the mouse up/down is different from left/right. One direction is for level window width, the other direction moves the level window
Sep 2 2020, 10:43 AM · MITK (v2021.02)
kislinsk committed rMITKaf09e331a755: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 2 2020, 9:31 AM
kislinsk added a comment to T27697: Documentation feedback received from testers .

The "url" downloads do not work for me. Slack is telling me that "there is a glitch".

Sep 2 2020, 8:56 AM · Auto-closed, MITK

Sep 1 2020

kislinsk closed T19011: DICOM Browser: Scanning empty directory causes Import dialog to stay open forever as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · Auto-closed, MITK, Bugzilla
kislinsk closed T23148: OnSelectionChanged event is sent twice sometimes as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · Auto-closed, MITK
kislinsk closed T24210: No error message displayed when incorrectly using Polhemus tracker as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · Auto-closed, MITK, IGT
kislinsk closed T25027: Unhandled exception thrown from ctkPluginContextPrivate::isPluginContextValid() when closing the workbench as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · Auto-closed, MITK (2016-11)
kislinsk closed T25125: QmitkNodeSelectionButton text color does not work with dark theme as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · MITK
kislinsk closed T25296: diffusion kurtosis maps as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · Auto-closed, MITK
kislinsk closed T27695: 2020 Week 36 (Very Early September) as Resolved.
Sep 1 2020, 4:42 PM · MITK
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

Deleted branch hotfix/T25882-CDash-v2.6.

Sep 1 2020, 4:41 PM · CI, MITK (v2021.02), Restricted Project
kislinsk added a comment to T27695: 2020 Week 36 (Very Early September).

Deleted branch release/T27695-2020-Week-36.

Sep 1 2020, 4:40 PM · MITK
kislinsk committed rMITK4abd657cba75: Merge branch 'release/T27695-2020-Week-36' into develop (authored by kislinsk).
Merge branch 'release/T27695-2020-Week-36' into develop
Sep 1 2020, 4:39 PM
kislinsk committed rMITK96eff29e7367: 2020 Week 36 (Very Early September) (authored by kislinsk).
2020 Week 36 (Very Early September)
Sep 1 2020, 4:37 PM
kislinsk edited the content of Changelog.
Sep 1 2020, 4:35 PM · MITK
kislinsk edited the content of 2020 Week 36 (Very Early September).
Sep 1 2020, 4:34 PM
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

This is part of this issue (actually the main reason). It is already working in my local version but I have to make a few adaptions to get a stable minimum working version for production.

Sep 1 2020, 4:02 PM · CI, MITK (v2021.02), Restricted Project
kislinsk updated the task description for T27695: 2020 Week 36 (Very Early September).
Sep 1 2020, 3:50 PM · MITK
kislinsk added a comment to T27695: 2020 Week 36 (Very Early September).

Pushed new branch release/T27695-2020-Week-36.

Sep 1 2020, 3:34 PM · MITK
kislinsk triaged T27695: 2020 Week 36 (Very Early September) as Normal priority.
Sep 1 2020, 3:31 PM · MITK
kislinsk created an object: 2020 Week 36 (Very Early September).
Sep 1 2020, 3:30 PM
kislinsk added a comment to T27669: Dicom import issue with MITK binaries (package) and Ubuntu.

I agree to @floca and I am quite sure this is related to installer vs. starting from build directory.

Sep 1 2020, 11:19 AM · Missing Info, DICOM, MITK

Aug 14 2020

kislinsk closed T27668: Fix Visual Studio 2017 warnings/errors as Resolved.
Aug 14 2020, 9:20 PM · MITK (v2021.02)
kislinsk committed rMITKdcb22cd781bb: Fix Visual Studio 2017 warnings (errors) in RegionGrowingTool (authored by kislinsk).
Fix Visual Studio 2017 warnings (errors) in RegionGrowingTool
Aug 14 2020, 9:19 PM
kislinsk committed rMITKaad6f78d84ee: Fix Visual Studio 2017 warnings (errors) in RegionGrowingTool (authored by kislinsk).
Fix Visual Studio 2017 warnings (errors) in RegionGrowingTool
Aug 14 2020, 9:19 PM
kislinsk added a comment to T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem.

Layers don't have names. The plugin is only asking for label names which are important of course. For a new segmentation there are two dialogs: for the segmentation name, and for the fist label name + color. I think it evolved from the UI pattern of the old segmentation plugin and I agree that the label dialog should be omitted. A "New label <i>" could be added to the label widget instead and we should probably improve this widget so a double click on the name opens an in-place editor for the name string instead of requiring the user to right click -> Rename... -> Dialog. Color editor already works this way.

Aug 14 2020, 9:15 PM · MITK (v2022.04), Cleared
kislinsk lowered the priority of T27646: [Data manager] Option to change color of segmentation disappeared in data manager from Normal to Wishlist.
Aug 14 2020, 9:04 PM · Auto-closed, Request for Discussion, MITK
kislinsk added a comment to T27524: Should RenderingManager be used without singleton?.

I cannot see any declaration of GetRenderingManager() in BaseRenderer (even before rMITK5e0e87c3)? In the second example I even cannot see anything related to RenderingManager? :-)

Aug 14 2020, 9:03 PM · Request for Discussion, MITK