Page MenuHomePhabricator
Feed Advanced Search

Apr 20 2023

kalali moved T29529: [Segmentation] Warning should not be shown for the MxN Display from Backlog to Cycle on the MITK (v2023.04) board.
Apr 20 2023, 1:02 PM · MITK (v2023.04)
kalali triaged T29529: [Segmentation] Warning should not be shown for the MxN Display as Normal priority.
Apr 20 2023, 1:02 PM · MITK (v2023.04)
kalali moved T29526: [Segmentation] Workbench crashes when closing render window part with active tool from Backlog to Cycle on the MITK (v2023.04) board.
Apr 20 2023, 11:00 AM · MITK (v2024.06)
kalali claimed T29526: [Segmentation] Workbench crashes when closing render window part with active tool.
Apr 20 2023, 11:00 AM · MITK (v2024.06)
kalali added a comment to T29526: [Segmentation] Workbench crashes when closing render window part with active tool.

In general this might be a problem also for other views because closing the workbench removes the render window part listener: m_RenderWindowListeners.remove(renderWindowListener) in QmitkViewCoordinator::PartClosed. This leads to the issue that the Segmentation view does not listen to the render window part being closed anymore.
Thus in the current scenario the render window part is NOT set to nullptr in the Segmentation view and in turn an invalid access is made when destroying the Segmentation view.

Apr 20 2023, 11:00 AM · MITK (v2024.06)
kalali updated the task description for T29528: [Segmentation] nnUNet provokes error when closing MITK / Segmentation view.
Apr 20 2023, 10:32 AM · MITK (v2023.04)
kalali renamed T29528: [Segmentation] nnUNet provokes error when closing MITK / Segmentation view from [Segmentation] nnUNet when closing to [Segmentation] nnUNet provokes error when closing MITK / Segmentation view.
Apr 20 2023, 10:32 AM · MITK (v2023.04)
kalali triaged T29528: [Segmentation] nnUNet provokes error when closing MITK / Segmentation view as Unbreak Now! priority.
Apr 20 2023, 10:31 AM · MITK (v2023.04)

Apr 19 2023

kalali updated the task description for T29526: [Segmentation] Workbench crashes when closing render window part with active tool.
Apr 19 2023, 7:30 PM · MITK (v2024.06)
kalali triaged T29526: [Segmentation] Workbench crashes when closing render window part with active tool as Normal priority.
Apr 19 2023, 6:45 PM · MITK (v2024.06)

Apr 17 2023

kalali placed T25057: Check IContextMenuActions and extension points up for grabs.

{D743} has been abandoned. Future work can use the the pushed branch as a baseline for a new context menu actions interface.
This was all started in the context of creating a new context menu that can be used elsewhere (not only in the datamanager). Now that T29025: Preference service (access) based on cpp microservices has been resolved we can start working on the parent task as well.

Apr 17 2023, 5:56 PM · MITK (v2024.06)
kalali removed a subtask for T25056: Refactor data manager context menu: Unknown Object (Maniphest Task).
Apr 17 2023, 5:52 PM · MITK (v2024.06), Noteworthy
kalali added a comment to T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers.

This is not solved with {D795}, right? I can still see slicer->GetRenderer() in line 926, so the render window is still retrieved from the slice navigation controller, which requires the getter to be available in the slice navigation controller.

Apr 17 2023, 5:38 PM · MITK (v2024.06)

Apr 5 2023

kalali closed T29515: [mxn multi widget] Crosshair not centered initially as Resolved.
Apr 5 2023, 2:48 PM · MITK (v2023.04)
kalali committed rMITKec1cfd81eac9: Center crosshair initially (authored by kalali).
Center crosshair initially
Apr 5 2023, 2:48 PM
kalali committed rMITK24869cd46ad2: Use current plane geomety to center crosshair (authored by kalali).
Use current plane geomety to center crosshair
Apr 5 2023, 2:47 PM
kalali moved T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Apr 5 2023, 9:59 AM · MITK (v2024.06)
kalali moved T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification from Backlog to Tests/Checklists on the MITK (v2023.04) board.
Apr 5 2023, 9:58 AM · MITK (v2024.06)
kalali placed T29163: [XNAT] Opening XNAT session fails up for grabs.
Apr 5 2023, 9:56 AM · MITK (v2024.06)
kalali moved T29498: [mxn multi widget] Restructure QmitkSynchronizedNodeSelectionWidget and QmitkAbstractNodeSelectionWidget from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Apr 5 2023, 9:56 AM · MITK (v2024.06)
kalali moved T29499: [mxn multi widget] Test inverted slice navgation widget for 4D data from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Apr 5 2023, 9:55 AM · MITK (v2024.06)
kalali moved T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers from Backlog to Cycle on the MITK (v2023.04) board.
Apr 5 2023, 9:55 AM · MITK (v2024.06)
kalali moved T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly from mxn MultiWidget to Cycle on the MITK (v2023.04) board.
Apr 5 2023, 9:50 AM · Request for Discussion, MITK (v2023.04)

Apr 4 2023

kalali added a revision to T29515: [mxn multi widget] Crosshair not centered initially: Unknown Object (Differential Revision).
Apr 4 2023, 6:09 PM · MITK (v2023.04)
kalali renamed T29515: [mxn multi widget] Crosshair not centered initially from [mxn multi widget] Center crosshair initially to [mxn multi widget] Crosshair not centered initially.
Apr 4 2023, 5:48 PM · MITK (v2023.04)
kalali moved T29515: [mxn multi widget] Crosshair not centered initially from Backlog to Cycle on the MITK (v2023.04) board.
Apr 4 2023, 5:48 PM · MITK (v2023.04)
kalali triaged T29515: [mxn multi widget] Crosshair not centered initially as Normal priority.
Apr 4 2023, 5:48 PM · MITK (v2023.04)
kalali committed rMITK86f8109e2783: Fix crosshair visibility (authored by kalali).
Fix crosshair visibility
Apr 4 2023, 5:37 PM
kalali committed rMITK39291f3d1052: Keep renderer-specific property of helper nodes (authored by kalali).
Keep renderer-specific property of helper nodes
Apr 4 2023, 5:37 PM
kalali closed T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized as Resolved.
Apr 4 2023, 5:36 PM · MITK (v2023.04)
kalali committed rMITK47958f163436: Allow layer change in synch render window mode (authored by kalali).
Allow layer change in synch render window mode
Apr 4 2023, 5:36 PM
kalali committed rMITKe327c70e2404: Allow data dropping if the base renderer is null (authored by kalali).
Allow data dropping if the base renderer is null
Apr 4 2023, 5:36 PM
kalali triaged T29514: [mxn multi widget] Render windows are not correctly initialized as Normal priority.
Apr 4 2023, 10:04 AM · MITK (v2024.06)

Apr 3 2023

kalali added a revision to T29403: [mxn multi widget] Concept for crosshair data type: Unknown Object (Differential Revision).
Apr 3 2023, 12:40 PM · MITK (v2023.04)
kalali added a revision to T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized: Restricted Differential Revision.
Apr 3 2023, 11:33 AM · MITK (v2023.04)

Mar 30 2023

kalali added a comment to T25057: Check IContextMenuActions and extension points.

I rebased this to the latest develop and pushed new branch to rMITK MITK: feature/T25057-Clean-IContextMenuActions for someone else to take over.

Mar 30 2023, 7:20 PM · MITK (v2024.06)
kalali closed T29403: [mxn multi widget] Concept for crosshair data type as Resolved.
Mar 30 2023, 5:02 PM · MITK (v2023.04)
kalali triaged T29512: [mxn multi widget] Share crosshairs between individual render windows as Normal priority.
Mar 30 2023, 5:01 PM · MITK (v2024.06)
kalali triaged T29511: [mxn multi widget] Provide more information with crosshair data as Normal priority.
Mar 30 2023, 4:53 PM · MITK (v2024.06)
kalali removed a subtask for T29403: [mxn multi widget] Concept for crosshair data type: T29386: [mxn multi widget] StdDisplay unnecessarily uses the crosshair manager.
Mar 30 2023, 4:23 PM · MITK (v2023.04)
kalali removed a parent task for T29386: [mxn multi widget] StdDisplay unnecessarily uses the crosshair manager: T29403: [mxn multi widget] Concept for crosshair data type.
Mar 30 2023, 4:23 PM · MITK (v2024.06)
kalali added a comment to T29403: [mxn multi widget] Concept for crosshair data type.

@floca Part of this task is done with landing the related diff, introducing the new crosshair-data.

Mar 30 2023, 1:00 PM · MITK (v2023.04)
kalali updated the task description for T29403: [mxn multi widget] Concept for crosshair data type.
Mar 30 2023, 12:59 PM · MITK (v2023.04)
kalali committed rMITK184f3f8c6929: New crosshair data type (authored by kalali).
New crosshair data type
Mar 30 2023, 12:57 PM
kalali committed rMITK84bb066ffd84: Fix bug such that the menu is not connected multiple times (authored by kalali).
Fix bug such that the menu is not connected multiple times
Mar 30 2023, 12:57 PM
kalali committed rMITK451fb28b14e9: Clean code to not store smart pointers unnecessarily (authored by kalali).
Clean code to not store smart pointers unnecessarily
Mar 30 2023, 12:57 PM
kalali committed rMITK71a88fbbb1a3: Clean plane geometry data mapper (authored by kalali).
Clean plane geometry data mapper
Mar 30 2023, 12:57 PM
kalali committed rMITK971711f21d22: Adapt depending classes to use the new crosshair data (authored by kalali).
Adapt depending classes to use the new crosshair data
Mar 30 2023, 12:57 PM
kalali committed rMITKcd75ba971e46: Add crosshair data and new vtk mapper (authored by kalali).
Add crosshair data and new vtk mapper
Mar 30 2023, 12:57 PM

Mar 27 2023

kalali committed rMITKc744ead52c26: Optimize data accessibility using a new data node model (authored by kalali).
Optimize data accessibility using a new data node model
Mar 27 2023, 6:14 PM
kalali committed rMITKf581179e09e3: Extend layer utilities to delete / transfer property values (authored by kalali).
Extend layer utilities to delete / transfer property values
Mar 27 2023, 6:14 PM
kalali committed rMITK4071c66b46c1: Clean render window layer utilities (authored by kalali).
Clean render window layer utilities
Mar 27 2023, 6:14 PM
kalali committed rMITKa8287902cd00: Clean render window layer controller class (authored by kalali).
Clean render window layer controller class
Mar 27 2023, 6:14 PM
kalali committed rMITK89dbd59ad284: Use the new table model / selection widget (authored by kalali).
Use the new table model / selection widget
Mar 27 2023, 6:14 PM
kalali committed rMITK2965dc193fb5: Add table model / selection widget for render window data management (authored by kalali).
Add table model / selection widget for render window data management
Mar 27 2023, 6:14 PM
kalali triaged T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers as Normal priority.
Mar 27 2023, 4:58 PM · MITK (v2024.06)

Mar 24 2023

kalali triaged T29501: mitk::Mapper needs to be explicitly set as Normal priority.
Mar 24 2023, 6:29 PM · MITK (v2024.06)
kalali added a comment to T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.

Updated task description since the class has been refactored. However, the issue still exists, but now it is - as far as I can see - only abut getting the visibility etc. which can easily be refactored.

Mar 24 2023, 9:07 AM · Request for Discussion, MITK (v2023.04)
kalali updated the task description for T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.
Mar 24 2023, 9:06 AM · Request for Discussion, MITK (v2023.04)
kalali removed a parent task for T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Mar 24 2023, 9:04 AM · Request for Discussion, MITK (v2023.04)
kalali removed a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.
Mar 24 2023, 9:04 AM · MITK
kalali renamed T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly from [Multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly to [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.
Mar 24 2023, 9:03 AM · Request for Discussion, MITK (v2023.04)
kalali triaged T29499: [mxn multi widget] Test inverted slice navgation widget for 4D data as Normal priority.
Mar 24 2023, 8:58 AM · MITK (v2024.06)

Mar 23 2023

kalali added a revision to T29491: [mxn multi widget] Provide F1-Help page: Unknown Object (Differential Revision).
Mar 23 2023, 5:50 PM · MITK (v2023.04)

Mar 22 2023

kalali updated the task description for T29493: RenderWindow management classes need to be revised / cleaned.
Mar 22 2023, 8:41 PM · MITK (v2024.06)
kalali triaged T29498: [mxn multi widget] Restructure QmitkSynchronizedNodeSelectionWidget and QmitkAbstractNodeSelectionWidget as Normal priority.
Mar 22 2023, 7:11 PM · MITK (v2024.06)
kalali closed T29496: [Workbench] Core dumped when mouse moved! as Resolved.
Mar 22 2023, 11:42 AM · MITK
kalali added a revision to T29496: [Workbench] Core dumped when mouse moved!: Unknown Object (Differential Revision).
Mar 22 2023, 11:42 AM · MITK
kalali committed rMITKeeb2f471b188: Initialize reference geometry variables correctly (authored by kalali).
Initialize reference geometry variables correctly
Mar 22 2023, 11:42 AM
kalali committed rMITK7d4b19a25c78: Correctly initialize reference geometry variables (authored by kalali).
Correctly initialize reference geometry variables
Mar 22 2023, 11:42 AM

Mar 21 2023

kalali added a comment to T29496: [Workbench] Core dumped when mouse moved!.

I uploaded a fix in D783. Let's see if this will solve the issue also for Ubuntu.

Mar 21 2023, 7:46 PM · MITK
kalali added a revision to T29335: [Segmentation] Show interactive warning for uninitialized render window geometry: Unknown Object (Differential Revision).
Mar 21 2023, 7:45 PM · MITK (v2023.04)
kalali added a comment to T29496: [Workbench] Core dumped when mouse moved!.

I tested this on Windows with 4974a335ada8a85d7fba8d313e2efc20acc84b48, which was the latest develop I had, since I recently merged something into develop and couldn't reproduce the error.
Used StdMultiWidget, no other plugins open, no data loaded, only the widget planes available in the data storage.
I tested this with the commit given in the task description and couldn't reproduce the error there as well.

Mar 21 2023, 6:05 PM · MITK

Mar 20 2023

kalali updated the task description for T29493: RenderWindow management classes need to be revised / cleaned.
Mar 20 2023, 1:33 PM · MITK (v2024.06)

Mar 17 2023

kalali closed T29402: [mxn multi widget] Concept for blocking individual render windows as Resolved.

With the child task T29335: [Segmentation] Show interactive warning for uninitialized render window geometry being closed, I will close this task as well. If more plugins should be able to enable blocked render windows, this should now be easily doable.

Mar 17 2023, 4:58 PM · MITK (v2023.04)
kalali closed T29335: [Segmentation] Show interactive warning for uninitialized render window geometry, a subtask of T29402: [mxn multi widget] Concept for blocking individual render windows, as Resolved.
Mar 17 2023, 4:57 PM · MITK (v2023.04)
kalali closed T29335: [Segmentation] Show interactive warning for uninitialized render window geometry as Resolved.
Mar 17 2023, 4:57 PM · MITK (v2023.04)
kalali committed rMITK4974a335ada8: Show warning for interaction reference geometry (authored by kalali).
Show warning for interaction reference geometry
Mar 17 2023, 4:57 PM
kalali committed rMITKc48fce2c31ca: Provide button overlay and use it to reset geometry (authored by kalali).
Provide button overlay and use it to reset geometry
Mar 17 2023, 4:57 PM
kalali committed rMITK1783751c9175: Clean base renderer (authored by kalali).
Clean base renderer
Mar 17 2023, 4:57 PM
kalali committed rMITKcf2f057add3c: Remove segmentation interactor and use new approach (authored by kalali).
Remove segmentation interactor and use new approach
Mar 17 2023, 4:57 PM
kalali committed rMITK077f4342b0e5: Provide functions to enable overlay warnings for not-aligned geometries (authored by kalali).
Provide functions to enable overlay warnings for not-aligned geometries
Mar 17 2023, 4:57 PM
kalali triaged T29493: RenderWindow management classes need to be revised / cleaned as Normal priority.
Mar 17 2023, 4:49 PM · MITK (v2024.06)
kalali added a revision to T26555: [mxn multi widget] Provide different default layouts: Unknown Object (Differential Revision).
Mar 17 2023, 3:32 PM · MITK
kalali triaged T29492: [mxn multi widget] Update and extend checklist as Normal priority.
Mar 17 2023, 3:31 PM · MITK (v2023.04)
kalali created T29492: [mxn multi widget] Update and extend checklist.
Mar 17 2023, 3:30 PM · MITK (v2023.04)
kalali moved T29491: [mxn multi widget] Provide F1-Help page from Backlog to Cycle on the MITK (v2023.04) board.
Mar 17 2023, 3:27 PM · MITK (v2023.04)
kalali triaged T29491: [mxn multi widget] Provide F1-Help page as Normal priority.
Mar 17 2023, 3:27 PM · MITK (v2023.04)

Mar 16 2023

kalali triaged T29490: [StdMultiWidget] Block multi widget like it is done for the MxNMultiWidget as Normal priority.
Mar 16 2023, 6:54 PM · MITK (v2024.06)
kalali added a revision to T29403: [mxn multi widget] Concept for crosshair data type: Unknown Object (Differential Revision).
Mar 16 2023, 2:07 PM · MITK (v2023.04)

Mar 8 2023

kalali updated subscribers of T29469: "Scan directory" in MITK DICOM Browser freezes application on MacOS.
Mar 8 2023, 12:27 PM · MITK (v2023.04)
kalali moved T29403: [mxn multi widget] Concept for crosshair data type from mxn MultiWidget to Cycle on the MITK (v2023.04) board.
Mar 8 2023, 12:09 PM · MITK (v2023.04)

Mar 3 2023

kalali claimed T29403: [mxn multi widget] Concept for crosshair data type.
Mar 3 2023, 4:43 PM · MITK (v2023.04)
kalali added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

Pushed new branch to rMITK MITK: feature/T28578-Test-MxN-installer.

Mar 3 2023, 2:11 PM · MITK

Mar 1 2023

kalali added a revision to T29335: [Segmentation] Show interactive warning for uninitialized render window geometry: Unknown Object (Differential Revision).
Mar 1 2023, 4:36 PM · MITK (v2023.04)
kalali removed a revision from T29402: [mxn multi widget] Concept for blocking individual render windows: Unknown Object (Differential Revision).
Mar 1 2023, 4:36 PM · MITK (v2023.04)

Feb 27 2023

kalali added a revision to T29402: [mxn multi widget] Concept for blocking individual render windows: Unknown Object (Differential Revision).
Feb 27 2023, 5:43 PM · MITK (v2023.04)

Feb 22 2023

kalali added a comment to T29297: [mxn multi widget] Optimize data accessibility inside render windows.

Deleted branch from rMITK MITK: feature/T29297-Use-selection-widgets-in-render-window-utility.

Feb 22 2023, 5:33 PM · MITK (v2023.04)
kalali removed a project from T29403: [mxn multi widget] Concept for crosshair data type: Request for Discussion.
Feb 22 2023, 12:00 PM · MITK (v2023.04)

Feb 7 2023

kalali added a revision to T29297: [mxn multi widget] Optimize data accessibility inside render windows: Unknown Object (Differential Revision).
Feb 7 2023, 10:42 AM · MITK (v2023.04)