Page MenuHomePhabricator
Feed All Stories

Sep 3 2020

gaoh committed rMITK6564d6922115: Revise Logging Plugin Documentation (authored by gaoh).
Revise Logging Plugin Documentation
Sep 3 2020, 12:46 PM
gaoh committed rMITKd306ce97c808: Merge branch 'develop' of https://phabricator.mitk.org/source/mitk into develop (authored by gaoh).
Merge branch 'develop' of https://phabricator.mitk.org/source/mitk into develop
Sep 3 2020, 12:46 PM
gaoh committed rMITKa7b1d2d96181: Merge Revise Logging Plugin Documentation of https://phabricator.mitk. (authored by gaoh).
Merge Revise Logging Plugin Documentation of https://phabricator.mitk.
Sep 3 2020, 12:46 PM
gaoh committed rMITK2e2c276e7534: applied review comments (authored by gaoh).
applied review comments
Sep 3 2020, 12:46 PM
gaoh committed rMITK5a6a54a73544: Revise Logging Plugin Documentation (authored by gaoh).
Revise Logging Plugin Documentation
Sep 3 2020, 12:46 PM
gaoh closed T27097: [MITKDoc] Revise Statistics Plugin Documentation as Resolved.
Sep 3 2020, 12:18 PM · Cleared, MITK (v2021.02)
schererj created T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics).
Sep 3 2020, 12:16 PM · HiGHmed, Kaapana (internal), MITK
gaoh committed rMITK40190a2ba6f6: Changed Documentation for Image Statitics: T27097 (authored by gaoh).
Changed Documentation for Image Statitics: T27097
Sep 3 2020, 12:16 PM
gaoh committed rMITK742ea8951545: removed wrong image (authored by gaoh).
removed wrong image
Sep 3 2020, 12:16 PM
gaoh committed rMITKf172a50c61ea: update image statistics plugin. (authored by gaoh).
update image statistics plugin.
Sep 3 2020, 12:16 PM
gaoh committed rMITKadb072ea0dfe: addid additonal subsections (authored by gaoh).
addid additonal subsections
Sep 3 2020, 12:16 PM
gaoh committed rMITKbbfeae7e7d7f: Merge branch 'develop' of ssh://phabricator.mitk.org:2222/source/mitk into… (authored by gaoh).
Merge branch 'develop' of ssh://phabricator.mitk.org:2222/source/mitk into…
Sep 3 2020, 12:16 PM
gaoh committed rMITK2acff4f1a6f6: Changed Documentation for Image Statitics: T27097 (authored by gaoh).
Changed Documentation for Image Statitics: T27097
Sep 3 2020, 12:16 PM
kalali updated subscribers of T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets.

@kislinsk mentioned that I might use some feature that is not working with Clang. Actually the only special feature I'm using is qOverload (afaict).

Sep 3 2020, 12:10 PM · MITK, Cleared
kalali added a comment to T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets.

MacOS still fails building MITK (see https://ci.mitk.org/job/MITK/job/Differential/job/macOS%20Mojave/431/console).

Sep 3 2020, 12:09 PM · MITK, Cleared
floca placed T25960: Evaluate UseCase C (radiomics) up for grabs.
Sep 3 2020, 11:29 AM · Hyppopy
floca placed T25959: Evaluate UseCase B (registration) up for grabs.
Sep 3 2020, 11:29 AM · Hyppopy
floca placed T25958: Evaluate UseCase A (hippocampus data) up for grabs.
Sep 3 2020, 11:29 AM · Hyppopy
kalali added a comment to T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets.

Updated D381

Sep 3 2020, 11:21 AM · MITK, Cleared
thomass updated subscribers of T27093: [MITKDoc] Revise Segmentation Plugin.

Pointed out by @kislinsk in T27095 but as stated before, it belongs to this documentation task not the multi-label one ;)

Sep 3 2020, 10:41 AM · MITK (v2021.02)
floca added a subtask for T27196: Rewrite packaging of MITK: T27693: Packaging Python does not work/is not implemented.
Sep 3 2020, 10:19 AM · MITK (v2024.06), Cleared
floca added a parent task for T27693: Packaging Python does not work/is not implemented: T27196: Rewrite packaging of MITK.
Sep 3 2020, 10:19 AM · MITK
floca edited projects for T27693: Packaging Python does not work/is not implemented, added: MITK; removed MITK (v2021.02).

No issue for 2020, because it is currently not a part of the workbench release.
The problem will be covered by T27196: Rewrite packaging of MITK

Sep 3 2020, 10:19 AM · MITK
kislinsk closed T27700: Toolmanager multi instance support is not correctly integrated... as Resolved.
Sep 3 2020, 10:11 AM · MITK (v2021.02)
kislinsk committed rMITKf1533e373758: Add missing tool manager context in ML segmentation (authored by kislinsk).
Add missing tool manager context in ML segmentation
Sep 3 2020, 10:11 AM
kislinsk committed rMITKe1a806155657: Add notes to class documentations regarding ToolManager context (authored by kislinsk).
Add notes to class documentations regarding ToolManager context
Sep 3 2020, 10:11 AM
kislinsk committed rMITKef6df59d006c: Add missing tool manager context (authored by kislinsk).
Add missing tool manager context
Sep 3 2020, 10:11 AM
kompan committed rMITK0412930fa4f8: Define isNoModelFitNodePredicate using model fit result relation rules. (authored by kompan).
Define isNoModelFitNodePredicate using model fit result relation rules.
Sep 3 2020, 10:03 AM
kompan committed rMITKd2b28fea92d6: Define isNoModelFitNodePredicate using model fit result relation rules. (authored by kompan).
Define isNoModelFitNodePredicate using model fit result relation rules.
Sep 3 2020, 10:03 AM
kompan closed T27619: MR Perfusion: Use model fit result relation rules for predicate definition as Resolved by committing rMITKd2b28fea92d6: Define isNoModelFitNodePredicate using model fit result relation rules..
Sep 3 2020, 10:03 AM · Cleared, MITK (v2021.02)
floca added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.

@kalali It seems that you work at this task and already have some branch. But the task is not claimed by you. Is it on purpose?

Sep 3 2020, 9:57 AM · Restricted Project, MITK (v2021.02)
floca committed rMITKaa8f1cc2c749: Fixed T27698 - Segmentation toolbox is never enabled in multi-label… (authored by floca).
Fixed T27698 - Segmentation toolbox is never enabled in multi-label…
Sep 3 2020, 9:15 AM
floca committed rMITKc328963104cc: removed dead code (authored by floca).
removed dead code
Sep 3 2020, 9:15 AM
floca committed rMITKa31307b35a9c: Fixed T27698 (authored by floca).
Fixed T27698
Sep 3 2020, 9:15 AM
floca closed T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view as Resolved by committing rMITKa31307b35a9c: Fixed T27698.
Sep 3 2020, 9:15 AM · MITK (v2021.02)
kislinsk renamed T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction from [Segmentation] Region Growing 2D now tends to oversegmentation to [Segmentation] Improve Region Growing 2D algorithm and interaction.
Sep 3 2020, 7:58 AM · MITK (v2024.06)
kislinsk added a comment to T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction.

We talked about this task in the group-5 meeting. It turned out that no more foreground pixels are added after the mouse button was released but that it is just a little slow on the test computer and the latest feedback contour wasn't yet calculated when the mouse button was released. So, not really a bug in my opinion. At least nothing new, since the algorithm of the tool did not change.

Sep 3 2020, 7:56 AM · MITK (v2024.06)
kislinsk triaged T27701: Overhaul or remove PluginGenerator as High priority.
Sep 3 2020, 7:28 AM · MITK, Next Milestone
kislinsk committed rMITKa3ba7555dc9b: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 3 2020, 7:24 AM
kislinsk committed rMITKfc5d8c5491d1: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 3 2020, 6:29 AM

Sep 2 2020

floca added a comment to T27700: Toolmanager multi instance support is not correctly integrated....

Oh... @thomass just told me that there is also T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view where it is already resolved... nvm.

Sep 2 2020, 9:23 PM · MITK (v2021.02)
kislinsk added a revision to T27700: Toolmanager multi instance support is not correctly integrated...: Unknown Object (Differential Revision).
Sep 2 2020, 9:18 PM · MITK (v2021.02)
kislinsk updated subscribers of T27700: Toolmanager multi instance support is not correctly integrated....

Oh... @thomass just told me that there is also T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view where it is already resolved... nvm.

Sep 2 2020, 9:12 PM · MITK (v2021.02)
kislinsk added a comment to T27700: Toolmanager multi instance support is not correctly integrated....

Happens only the first time. When I delete all segmentations and then create another new segmentation, the tool widgets in both views are enabled. Might explain why I didn't notice it when doing D312, as I was sure that I tested this before.

Sep 2 2020, 8:17 PM · MITK (v2021.02)
kislinsk added a comment to T27700: Toolmanager multi instance support is not correctly integrated....
  • SegmentationInteractor is only used in ML Segmentation. I added the ML context.
  • I also added the ML context to the second call of GetToolManager() QmitkSurfaceStampWidget, it was simply forgotten
Sep 2 2020, 8:15 PM · MITK (v2021.02)
kislinsk claimed T27700: Toolmanager multi instance support is not correctly integrated....
Sep 2 2020, 7:58 PM · MITK (v2021.02)
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.
  • MITK_BUILD_OPTIONS for MITK cache vars
  • Check why there are documentation errors "lost edge a b" but when I manually "make doc" on the client, it works
  • OpenCV somehow seems to trigger Ant errors on Ubuntu only during the first build (problem in Nightlies)
  • First time build of MatchPoint triggers many warnings as errors on macOS
Sep 2 2020, 7:57 PM · CI, MITK (v2021.02), Unknown Object (Project)
kislinsk renamed T25882: Rewrite dashboard script for CDash 2.6 from Figure out why CDash submissions to CDash 2.6 servers are not browsable to Rewrite dashboard script for CDash 2.6.
Sep 2 2020, 7:54 PM · CI, MITK (v2021.02), Unknown Object (Project)
kislinsk committed rMITK8be1a44b0d0d: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 2 2020, 7:07 PM
floca moved T27700: Toolmanager multi instance support is not correctly integrated... from Backlog to Segmentation on the MITK (v2021.02) board.
Sep 2 2020, 5:17 PM · MITK (v2021.02)
floca triaged T27700: Toolmanager multi instance support is not correctly integrated... as Unbreak Now! priority.
Sep 2 2020, 5:17 PM · MITK (v2021.02)
floca added a comment to T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view.

Don't ask me what the reason is, that the problem appeared now! But the enabled state was only set at view construction for the ML view. Which lead to disabled tools if you opened it the first time (afterwards a reference image was set in the toolmanager and everything was fine).
Normal segmentation worked arround it by recreating the buttons as soon as data was changed. But I think it is cleaner to let the toolbox widget update the states whenever the toolmanager data has changed.

Sep 2 2020, 5:13 PM · MITK (v2021.02)
floca claimed T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view.
Sep 2 2020, 5:09 PM · MITK (v2021.02)
floca added a revision to T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view: Unknown Object (Differential Revision).
Sep 2 2020, 5:09 PM · MITK (v2021.02)
floca added a comment to T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view.

@thomass : Small workaround until it is fixed: Close the view and open it again. The image and segmentation are autoselected and the tools are active.

Sep 2 2020, 2:30 PM · MITK (v2021.02)
kislinsk committed rMITKf83f03607806: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 2 2020, 2:19 PM
kislinsk committed rMITK9973ea6ada29: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 2 2020, 1:33 PM
floca added a comment to T27659: Refactor BasicImageProcessing plugin to use the new node selection widgets.

@kalali Can you try to retrigger D381? Currently it cannot be reviewed as it is in draft mode.

Sep 2 2020, 1:15 PM · MITK, Cleared
floca lowered the priority of T26741: Finishing new node selection concept from High to Normal.
Sep 2 2020, 1:13 PM · Restricted Project
thomass added a revision to T27095: [MITKDoc] Revise MultiLabel Segmentation Plugin Documentation: Unknown Object (Differential Revision).
Sep 2 2020, 1:10 PM · MITK (v2021.02)
neher triaged T27699: mitkCommandLineParser should allow arbitrary types with input/output flag as Normal priority.
Sep 2 2020, 11:32 AM · MITK
kislinsk added a comment to T27436: Deactivate interpolation widget in Multilabel Segmentation View till it interpolation is correctly supported.

Deleted branch bugfix/T27436-HideInterpWidgetsInMultilabelSegView.

Sep 2 2020, 10:55 AM · Restricted Project, Cleared, MITK (v2021.02)
kislinsk added a comment to T27095: [MITKDoc] Revise MultiLabel Segmentation Plugin Documentation.

Notes for the Region Growing 2D tool:

  • The tool operates based on the current level window, so changing the level window to optimize the contrast for the ROI should be encouraged
  • Moving the mouse up/down is different from left/right. One direction is for level window width, the other direction moves the level window
Sep 2 2020, 10:43 AM · MITK (v2021.02)
floca moved T27684: [Segmentation] Improve Region Growing 2D algorithm and interaction from Backlog to Segmentation on the MITK (v2021.02) board.
Sep 2 2020, 10:41 AM · MITK (v2024.06)
floca moved T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view from Backlog to Segmentation on the MITK (v2021.02) board.
Sep 2 2020, 10:26 AM · MITK (v2021.02)
thomass updated the task description for T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view.
Sep 2 2020, 10:24 AM · MITK (v2021.02)
thomass triaged T27698: [Segmentation] Segmentation toolbox is never enabled in multi-label segmentation view as High priority.
Sep 2 2020, 10:24 AM · MITK (v2021.02)
thomass added a comment to T27697: Documentation feedback received from testers .

should work now

Sep 2 2020, 10:22 AM · Auto-closed, MITK
thomass updated the task description for T27697: Documentation feedback received from testers .
Sep 2 2020, 10:21 AM · Auto-closed, MITK
thomass added a comment to T27696: Dicom loading does not work for some 4D data with the latest installer.

I just received an E-Mail that the problem could be related to the data source (some server or network drive) so maybe no MITK issue after all :)

Sep 2 2020, 10:04 AM · DICOM, Missing Info, MITK
floca added projects to T27696: Dicom loading does not work for some 4D data with the latest installer: Missing Info, DICOM.

Some additional questions:

  • Was your laptop used to build the binaries? If yes, could you check, if yuo can produce the error behavior if you pick a non-mitk-developer maschine and try to load the data there?
  • How many frames does the 4D Dicom have? What is its resolution?
Sep 2 2020, 9:59 AM · DICOM, Missing Info, MITK
floca committed rMITKa4417d673c8d: Fixed T27112 Revised MatchPoint Evaluator documentation (authored by floca).
Fixed T27112 Revised MatchPoint Evaluator documentation
Sep 2 2020, 9:54 AM
floca committed rMITK1dc75a0c126b: Fixed review remarks (authored by floca).
Fixed review remarks
Sep 2 2020, 9:54 AM
floca committed rMITK2226f9ac904e: Revised MatchPoint Evaluator documentation (authored by floca).
Revised MatchPoint Evaluator documentation
Sep 2 2020, 9:54 AM
floca closed T27112: [MITKDoc] Revise Matchpoint Registration Evaluator Plugin Documentation as Resolved by committing rMITK2226f9ac904e: Revised MatchPoint Evaluator documentation.
Sep 2 2020, 9:53 AM · Cleared, MITK (v2021.02)
kislinsk committed rMITKaf09e331a755: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 2 2020, 9:31 AM
kalali claimed T27674: [Selection widgets] Enabling auto selection emits a signal that might not yet be connected.

Thank you, I wanted to post the discussion result here as well. I will fix this.

Sep 2 2020, 9:01 AM · Cleared, MITK
kislinsk added a comment to T27697: Documentation feedback received from testers .

The "url" downloads do not work for me. Slack is telling me that "there is a glitch".

Sep 2 2020, 8:56 AM · Auto-closed, MITK
thomass added a comment to T27697: Documentation feedback received from testers .

I would suggest that at least the plugin feedback in the GoogleDocs and the toplevel-> main page /MITKUserManual should be corrected before the Release. The rest should be corrected soon after.

Sep 2 2020, 8:36 AM · Auto-closed, MITK
thomass updated subscribers of T27697: Documentation feedback received from testers .
Sep 2 2020, 8:34 AM · Auto-closed, MITK
thomass updated the task description for T27697: Documentation feedback received from testers .
Sep 2 2020, 8:33 AM · Auto-closed, MITK
thomass triaged T27697: Documentation feedback received from testers as Normal priority.
Sep 2 2020, 8:33 AM · Auto-closed, MITK
thomass added a comment to T26934: Multiple logos in screenshot when using screenshot maker plugin.

@kislinsk: should we further investigate this or have a known issue section in the documentation?

Sep 2 2020, 8:12 AM · MITK (v2024.06)
thomass triaged T27696: Dicom loading does not work for some 4D data with the latest installer as Normal priority.
Sep 2 2020, 7:47 AM · DICOM, Missing Info, MITK

Sep 1 2020

floca added a comment to T27669: Dicom import issue with MITK binaries (package) and Ubuntu.

The log information in the console which Jonas reported doesn't turn up. So the console doesn't show any new information after the reader is selected.
I will ask about the HDD / IO.

Sep 1 2020, 6:19 PM · Missing Info, DICOM, MITK
thomass added a comment to T27669: Dicom import issue with MITK binaries (package) and Ubuntu.

The log information in the console which Jonas reported doesn't turn up. So the console doesn't show any new information after the reader is selected.
I will ask about the HDD / IO.

Sep 1 2020, 6:12 PM · Missing Info, DICOM, MITK
floca added a comment to T27669: Dicom import issue with MITK binaries (package) and Ubuntu.

she doesn't even get to the logging point. It doesn't show anything, it just stops (She closed the workbench after 10 Minutes).

What do you mean with logging point?

Sep 1 2020, 6:01 PM · Missing Info, DICOM, MITK
thomass added a comment to T27669: Dicom import issue with MITK binaries (package) and Ubuntu.

I am not sure if that is related but today one of my cooperation partners reported that she couldn't open an 4D image in MITK (Latest develop installer).
On my laptop it just works fine. On her laptop, however, she doesn't even get to the logging point. It doesn't show anything, it just stops (She closed the workbench after 10 Minutes).
I asked her whether it was an ancient laptop, but no ;)

Sep 1 2020, 5:56 PM · Missing Info, DICOM, MITK
floca edited projects for T27674: [Selection widgets] Enabling auto selection emits a signal that might not yet be connected, added: Cleared, Restricted Project; removed Request for Discussion.

Discussion result:
As you cannot hook into the Qt connect mechanism, I see no "simple" chance to automatically manage that under the hood. The most pragmatic solution is to simply add a remark to the class (QmitkSingleNodeSelectionWidget) and method (SetAutoSelectNewNodes()) that on should activate this feature *after* connecting the events to ensure already the first autoselect has an effect.

Sep 1 2020, 5:53 PM · Cleared, MITK
floca moved T27524: Should RenderingManager be used without singleton? from Backlog to MITK Meeting on the Request for Discussion board.
Sep 1 2020, 5:48 PM · Request for Discussion, MITK
floca added a comment to T27669: Dicom import issue with MITK binaries (package) and Ubuntu.

It is pretty weird since it even:

suggests 1 3D blocks

Sep 1 2020, 5:31 PM · Missing Info, DICOM, MITK
floca changed the status of T25125: QmitkNodeSelectionButton text color does not work with dark theme from Wontfix to Resolved.

Is fixed. but please don't ask when it happened ;).

Sep 1 2020, 5:22 PM · MITK
kislinsk closed T19011: DICOM Browser: Scanning empty directory causes Import dialog to stay open forever as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · Auto-closed, MITK, Bugzilla
kislinsk closed T23148: OnSelectionChanged event is sent twice sometimes as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · Auto-closed, MITK
kislinsk closed T24210: No error message displayed when incorrectly using Polhemus tracker as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · Auto-closed, MITK, IGT
kislinsk closed T25027: Unhandled exception thrown from ctkPluginContextPrivate::isPluginContextValid() when closing the workbench as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · Auto-closed, MITK (2016-11)
kislinsk closed T25125: QmitkNodeSelectionButton text color does not work with dark theme as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · MITK
kislinsk closed T25296: diffusion kurtosis maps as Wontfix.

Hi there! 🙂

Sep 1 2020, 4:46 PM · Auto-closed, MITK
kislinsk closed T27695: 2020 Week 36 (Very Early September) as Resolved.
Sep 1 2020, 4:42 PM · MITK
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

Deleted branch hotfix/T25882-CDash-v2.6.

Sep 1 2020, 4:41 PM · CI, MITK (v2021.02), Restricted Project