In T24398#241998, @floca wrote:Our side or also the CTK part.
Hm, lets put it as known issue and discuss its priority when we plan the spring release.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Sep 28 2022
Sep 28 2022
• s349i updated the task description for T28798: [Segmentation][MultiLabel][Utilities] UI is inconsistent / unstable.
floca added a revision to T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures.: Restricted Differential Revision.
floca added a revision to T29078: [Segmentation] Erase tool has unclear edge cases: Restricted Differential Revision.
floca added a revision to T29132: [MultiLabel Segmentation] Define desired behavior of fill / erase tool: Restricted Differential Revision.
floca added a revision to T28763: [Multilabel Segmentation] Fill / Erase tool does not fully respect multiple labels: Restricted Differential Revision.
Sep 27 2022
Sep 27 2022
thank you for looking into that matter.
floca edited projects for T24398: Dicom plugin: Retrieve does not work, added: MITK, Next Milestone; removed MITK (v2022.10).
In T24398#241991, @kislinsk wrote:I noticed that the whole plugin is a complete mess BTW and urgently needs at least some clean up to see all the potentials for improvements and bug fixes. :/
Our side or also the CTK part.
kalali updated the task description for T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
kalali updated the task description for T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
I looked into the dicombrowser plugin and found out that the directory on Windows is something like %APPDATA%/../Local/Temp/TmpDicomFolder.************. However I didn't see pop up any files after retrieve.
kalali triaged T29316: Rename QmitkSliderNavigatorWidget and clean variable names as Normal priority.
Sep 26 2022
Sep 26 2022
• s349i updated the task description for T28798: [Segmentation][MultiLabel][Utilities] UI is inconsistent / unstable.
• s349i updated the task description for T28798: [Segmentation][MultiLabel][Utilities] UI is inconsistent / unstable.
Sep 23 2022
Sep 23 2022
Pushed new branch to rMITK MITK: feature/T28851-AddITKGrowCutTool.
j762e added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.
In T29313#241891, @floca wrote:What do you mean with removed? Is the code still somewhere? If it was functional it would make no sense if someone has to write a new test from scratch.
Tests work again. So if the DLL-Exception/failing tests was the reason for removing it, you can add it again.
This is your job @amiiney :)
Sep 23 2022, 4:14 PM · Restricted Project
Please move this Task to the IMSY Community Day Issue Board in GitLab:
Sep 23 2022, 3:15 PM · Restricted Project
s434n closed T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool as Resolved.
I have updated the checklist according to the documented / actual function of the two tools.
However, I had to add a note regarding the "remove everything" functionality of the erase tool, which currently does not work correctly (?) when a segmented region touches the boundary of the image (see T29078 example 2).
kislinsk moved T24398: Dicom plugin: Retrieve does not work from Backlog to MITK Meeting on the Request for Discussion board.
I just tried to retrieve data from dicomserver.co.uk and I am able to query and kind of retrieve data. A repeated retrieve even tells me that existing files are overriden. At least that is what the console output tells me. But where are the retrieved images supposed to be stored? And shouldn't the retrieved images appear somewhere in the DICOM editor?
Sep 22 2022
Sep 22 2022
kalali added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.
The idea was to provide an additional differential here for this task that adds the test so yes, the code is there and will be visible in the differential.
floca added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.
What do you mean with removed? Is the code still somewhere? If it was functional it would make no sense if someone has to write a new test from scratch.
I have added a checklist for growcut into Checklist Segmentation – 3D Segmentation_EN.docx in Nextcloud.
There are no specific test cases (checklists) for other tools on 4D images as far as I know/have seen.
I think this Task should just kept in mind because the growcut tool is new.
j762e added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.
I already wrote a test, but removed it for now so I could create the Diff (D712).
Now the Diff needs to be accepted and the T28851-AddImagesForGrowCutSegmentationTest Branch needs to be merged into the mitkdata repository:
Update the status bar correctly
kalali committed rMITK2eee153e5804: Merge remote-tracking branch 'maleike/fix-status-bar-updates' into develop (authored by kalali).
Merge remote-tracking branch 'maleike/fix-status-bar-updates' into develop
maleike committed rMITK125b15152e2e: Force a rendering update before updating the status bar. (authored by maleike).
Force a rendering update before updating the status bar.
Remove unused QmitkSelectableGLWidget
kalali committed rMITK3edfcc488dc7: Remove QmitkSelectableGLWidget and unnecessary includes (authored by kalali).
Remove QmitkSelectableGLWidget and unnecessary includes
Sep 21 2022
Sep 21 2022
kalali added a revision to T29265: QmitkSelectableGLWidget is not used anymore and can be removed: Restricted Differential Revision.
k688h removed a project from T28357: Running Isolated container in Kaapana ( Instead of Default Docker): Request for Discussion.
k688h removed a project from T28043: TFDA MVP1-Tasks:Tools and Technologies: Request for Discussion.
Sep 21 2022, 2:57 PM · Restricted Project
k688h removed a parent task for T29016: TFDA MVP - Airflow 2 Migration + Latest Kaapana Dev Branch Integration: Unknown Object (Maniphest Task).
Sep 21 2022, 2:41 PM · Restricted Project
Do we have a checklist for growcut? I guess that would be the place to add additional cases, wouldn't it?
floca added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.
Haven't you added a test alread? Or are you thinking about other test cases?
If this is the case, could you give a bit more input regarding your thoughts.
j762e triaged T29313: Add a Test to check if the GrowCut algorithm produces a different output as Normal priority.
j762e renamed T28851: [SEG] Add ITK GrowCut as segmentation tool from [SEG] Add ITK Growcut as segmentation tool to [SEG] Add ITK GrowCut as segmentation tool.
j762e renamed T28851: [SEG] Add ITK GrowCut as segmentation tool from [SEG] Evaluate if we should add itkGrowCut as a tool to [SEG] Add ITK Growcut as segmentation tool.
j762e triaged T29312: Add support for using layers other than layer 0 of the current LabelSetImage as Wishlist priority.
j762e triaged T29311: Further observation of the GrowCut segmentation tool on 4D images as Normal priority.
j762e triaged T29310: [ITK] Check if ITK 5.3 adds the GrowCut remote module by default as Normal priority.
floca moved T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool from Backlog to Tests/Checklists on the MITK (v2022.10) board.
floca triaged T29308: [Segmentation] Check/revise check list of the fill tool and the erase tool as High priority.
floca triaged T29307: [Segmentation] Add a fill tool like e.g. GIMP or Photoshop has as Normal priority.
floca triaged T29306: [Segmentation] Provide Close tool (behavior of old Fill tool) as Normal priority.
floca removed a project from T29132: [MultiLabel Segmentation] Define desired behavior of fill / erase tool: Request for Discussion.
Discussion results:
We discussed on it.
floca edited projects for T29078: [Segmentation] Erase tool has unclear edge cases, added: Next Milestone; removed MITK (v2022.10), Request for Discussion.
To make our live a bit easier. I would say it is a data problem ;).
oh so I forgot to send it: But this is, what my browser had cashed: "Yes, so I recently tested it, with the current release."
But also, if I remember correctly, this was due to the Phantom dataset we have as the default dataset:
I removed a few slices at the end, and now it is working.
@gaoh Ping
floca added a comment to T28798: [Segmentation][MultiLabel][Utilities] UI is inconsistent / unstable.
@s349i Are those checked now? If not please do this ASAP and verify. Thanks.
Sep 20 2022
Sep 20 2022
Some further remarks as I am leaving DKFZ:
kalali added a revision to T28851: [SEG] Add ITK GrowCut as segmentation tool: Restricted Differential Revision.
Deleted branch from rMITK MITK: bugfix/T29305-FixGDCMIssues.
kislinsk committed rMITK41939fd2a5d4: Revert "Use ITK's GDCM instead of separate GDCM" (authored by kislinsk).
Revert "Use ITK's GDCM instead of separate GDCM"
kislinsk committed rMITK7ea583973b1e: Upgrade GDCM from version 3.0.10 to 3.0.18 (authored by kislinsk).
Upgrade GDCM from version 3.0.10 to 3.0.18
kislinsk committed rMITK54fc88f462dd: Downgrade GDCM from version 3.0.18 to 3.0.17 (authored by kislinsk).
Downgrade GDCM from version 3.0.18 to 3.0.17
Downgrade GDCM to version 3.0.14
kislinsk committed rMITKea18963576a0: Merge branch 'bugfix/T29305-FixGDCMIssues' into develop (authored by kislinsk).
Merge branch 'bugfix/T29305-FixGDCMIssues' into develop
Sep 19 2022
Sep 19 2022
kislinsk added a revision to T29305: Fix GDCM Globals issue with many MITK binaries: Unknown Object (Differential Revision).
kislinsk added a reverting change for rMITK7b40015a2c73: Use ITK's GDCM instead of separate GDCM: Unknown Object (Differential Revision).
Pushed new branch to rMITK MITK: bugfix/T29305-FixGDCMIssues.
I added the PR (https://github.com/MITK/MITK/pull/262/) as a differential.
kalali added a revision to T29219: StatusBar / mouse scrolling is broken: Unknown Object (Differential Revision).
fix typos and remove misspelled unused code
Sep 18 2022
Sep 18 2022
Pushed new branch to rMITK MITK: feature/T29206-MVC_pattern_for_labelsets.
Sep 16 2022
Sep 16 2022
Remove unused interaction files
kalali committed rMITKdd6756610999: Remove unused segmentation interaction files (authored by kalali).
Remove unused segmentation interaction files
kalali committed rMITKb18f5343112e: Remove legacy state machine / display configuration (authored by kalali).
Remove legacy state machine / display configuration
Remove unused DisplayConfig.xml-file
Sep 15 2022
Sep 15 2022
kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
kalali triaged T29303: IGT classes do not work correctly with the new mxn multi widget as Low priority.
kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.