Page MenuHomePhabricator
Feed All Stories

Jul 30 2020

kahl placed T27107: [MITKDoc] Revise Screenshot Maker Plugin Documentation up for grabs.
Jul 30 2020, 11:26 AM · Cleared, MITK (v2021.02)
kahl placed T27101: [MITKDoc] Revise Logging Plugin Documentation up for grabs.
Jul 30 2020, 11:25 AM · Cleared, MITK (v2021.02)
floca added a comment to T27324: Investigate MITK <--> python image transfer.

hm, strange. Ad hoc I cannot give a hint. Good you found a workarround. For further investigation, may be mitk::Image has special wrapping instruction, that interferes with your approach.

Jul 30 2020, 11:17 AM · Auto-closed, MITK
thomass added a revision to T27105: [MITKDoc] Revise Measurement Plugin Documentation: Unknown Object (Differential Revision).
Jul 30 2020, 10:52 AM · Cleared, MITK (v2021.02)
floca edited projects for T27498: [Selection widgets] Define default for auto selection / listening mechanism, added: MITK (v2021.02), Restricted Project; removed MITK.

To finish this task, one should check/verify that all release relevant plugins follow the discussion result.

Jul 30 2020, 10:47 AM · Restricted Project, MITK (v2021.02)
nolden added a comment to T27612: Fix build errors with clang 10.x .

I'm setting up a clang 10 dart client right now. If that is submitting successfully I would close the task

Jul 30 2020, 9:35 AM · Breaking Change, MITK (v2021.02)
thomass added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

I can reproduce the behavior for the US4DCyl but not for the heart 3D+t. But it looks exactly like the error for static segmentation and t=2 (that I showed during the telco).

Jul 30 2020, 9:34 AM · MITK (v2021.10), Missing Info, Restricted Project
floca committed rMITKc5e3da10dab6: T27692 Fixed mitk::IsSubGeometry for oblique geometries. (authored by floca).
T27692 Fixed mitk::IsSubGeometry for oblique geometries.
Jul 30 2020, 8:21 AM
floca committed rMITKdac974bc335d: Fixed mitk::IsSubGeometry for oblique geometries. (authored by floca).
Fixed mitk::IsSubGeometry for oblique geometries.
Jul 30 2020, 8:21 AM
kislinsk triaged T27624: Fix Doxygen errors as High priority.
Jul 30 2020, 6:03 AM · MITK (v2021.02)

Jul 29 2020

kislinsk added a project to T27612: Fix build errors with clang 10.x : Breaking Change.

Is this task resolved with the landing of {D360}?

Jul 29 2020, 11:19 PM · Breaking Change, MITK (v2021.02)
kislinsk added a revision to T27612: Fix build errors with clang 10.x : Unknown Object (Differential Revision).
Jul 29 2020, 11:18 PM · Breaking Change, MITK (v2021.02)
floca committed rMITKc72fa5e21c97: T25805 Cleaned up naming of DICOM related modules (authored by floca).
T25805 Cleaned up naming of DICOM related modules
Jul 29 2020, 9:38 PM
floca committed rMITKec3a2c5a9588: Merge branch 'develop' into feature/T25805-merged (authored by floca).
Merge branch 'develop' into feature/T25805-merged
Jul 29 2020, 9:38 PM
floca committed rMITK9b8c2ef3cbc2: Fixed missed case sensitive naming change (authored by floca).
Fixed missed case sensitive naming change
Jul 29 2020, 9:37 PM
floca committed rMITK738dae120e75: Fixed review remarks (authored by floca).
Fixed review remarks
Jul 29 2020, 9:37 PM
floca committed rMITK61b852be152c: Commit missed changes of one renamed directory (authored by floca).
Commit missed changes of one renamed directory
Jul 29 2020, 9:37 PM
floca committed rMITKfb6195ff763a: Cleaned up naming of DICOM related modules (authored by floca).
Cleaned up naming of DICOM related modules
Jul 29 2020, 9:37 PM
floca closed T25805: Standardize/Rework DICOM module naming as Resolved by committing rMITKfb6195ff763a: Cleaned up naming of DICOM related modules.
Jul 29 2020, 9:37 PM · Noteworthy, Breaking Change, MITK (v2021.02), DICOM
floca committed rMITKe72944cdcf37: Renamed plugin org.mitk.gui.qt.dicom into org.mitk.gui.qt.dicombrowser (authored by floca).
Renamed plugin org.mitk.gui.qt.dicom into org.mitk.gui.qt.dicombrowser
Jul 29 2020, 9:37 PM
floca closed T27001: Rename org.mitk.gui.qt.dicom to org.mitk.gui.qt.dicombrowser as Resolved by committing rMITKe72944cdcf37: Renamed plugin org.mitk.gui.qt.dicom into org.mitk.gui.qt.dicombrowser.
Jul 29 2020, 9:37 PM · Breaking Change, MITK (v2021.02), Cleared
kislinsk added a comment to T27085: 2D region growing tool fails for low intensity regions.

Deleted branch bugfix/T27085-2DRegionGrowing.

Jul 29 2020, 9:33 PM · Cleared, MITK (v2021.02)
kislinsk committed rMITK99e147b96882: Keep region grower thresholds within the pixel type extrema of the reference… (authored by kislinsk).
Keep region grower thresholds within the pixel type extrema of the reference…
Jul 29 2020, 9:33 PM
kislinsk committed rMITKaf6ba9b47f82: Keep region grower thresholds within the pixel type extrema of the reference… (authored by kislinsk).
Keep region grower thresholds within the pixel type extrema of the reference…
Jul 29 2020, 9:33 PM
kislinsk closed T27085: 2D region growing tool fails for low intensity regions as Resolved by committing rMITKaf6ba9b47f82: Keep region grower thresholds within the pixel type extrema of the reference….
Jul 29 2020, 9:33 PM · Cleared, MITK (v2021.02)
kahl added a comment to T27324: Investigate MITK <--> python image transfer.

Seems like I figured it out. What I had to do was to change SWIG_TypeQuery("_p_mitk__Image") to SWIG_TypeQuery("_p_itk__SmartPointerT_mitk__Image_t") and change the type of image to mitk::Image::Pointer *image. When passing Pic3D now and printing the number of dimensions, 3 is printed as one would expect. I will further investigate how to interact with other libraries like SimpleITK.

Jul 29 2020, 4:56 PM · Auto-closed, MITK
floca added a revision to T27001: Rename org.mitk.gui.qt.dicom to org.mitk.gui.qt.dicombrowser: Restricted Differential Revision.
Jul 29 2020, 4:40 PM · Breaking Change, MITK (v2021.02), Cleared
floca committed rMITK65691bb2f0df: Fixed PerfusionMiniApp to also support 2 step linear model (authored by floca).
Fixed PerfusionMiniApp to also support 2 step linear model
Jul 29 2020, 4:10 PM
floca committed rMITKb0e2beec1246: T27581 Fixed PerfusionMiniApp to also support 2 step linear model (authored by floca).
T27581 Fixed PerfusionMiniApp to also support 2 step linear model
Jul 29 2020, 4:10 PM
floca closed T27581: MRPerfusionMiniApp does not support 2-Step-Linear-Model as Resolved by committing rMITK65691bb2f0df: Fixed PerfusionMiniApp to also support 2 step linear model.
Jul 29 2020, 4:10 PM · MITK
kahl added a comment to T27324: Investigate MITK <--> python image transfer.

I tried an approach like @floca suggested with the SWIG wrapping that is already available in MITK. Here is my code to transfer a MITK image from C++ to Python:

Jul 29 2020, 3:59 PM · Auto-closed, MITK
kleina added a member for Deep Learning: t006d.
Jul 29 2020, 3:13 PM
neher closed T27618: Update Readme as Resolved.
Jul 29 2020, 2:46 PM · MITK Diffusion
kalali added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

@thomass I checked Fast Marching 3D and re-opened T18436: [Segmentation] Fast Marching 3D Tool only supported for first time step in 4D images for the static mask cases.
Could you re-check the dynamic case? I tested it and with t = 0 I got a dynamic mask (4D) with a segmentation only on the first (0) timestep but with t != 0 I have the same problem as described in the mentioned task (green contour nowhere near the seed point).

Jul 29 2020, 2:15 PM · MITK (v2021.10), Missing Info, Restricted Project
kalali renamed T18436: [Segmentation] Fast Marching 3D Tool only supported for first time step in 4D images from Fast Marching 3D Tool only supported for first time step in 4D images to [Segmentation] Fast Marching 3D Tool only supported for first time step in 4D images.
Jul 29 2020, 2:09 PM · MITK (v2021.02), Bugzilla
kalali reopened T18436: [Segmentation] Fast Marching 3D Tool only supported for first time step in 4D images, a subtask of T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation, as Open.
Jul 29 2020, 2:09 PM · MITK (v2021.10), Missing Info, Restricted Project
kalali reopened T18436: [Segmentation] Fast Marching 3D Tool only supported for first time step in 4D images as "Open".
Jul 29 2020, 2:09 PM · MITK (v2021.02), Bugzilla
kalali added a parent task for T18436: [Segmentation] Fast Marching 3D Tool only supported for first time step in 4D images: T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.
Jul 29 2020, 2:05 PM · MITK (v2021.02), Bugzilla
kalali added a subtask for T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation: T18436: [Segmentation] Fast Marching 3D Tool only supported for first time step in 4D images.
Jul 29 2020, 2:05 PM · MITK (v2021.10), Missing Info, Restricted Project
kalali claimed T24771: [MITKDoc] Add a concept documentation for the data storage inspectors and the overhaul of the selection concept.
Jul 29 2020, 1:54 PM · MITK (v2021.02)
kalali added a comment to T27507: Check the current behavior of the segmentation tools according static and dynamic 4D segmentation.

So Region Growing 3D seems to work and could probably be used for reference for other algorithms.

Jul 29 2020, 1:53 PM · MITK (v2021.10), Missing Info, Restricted Project
kalali renamed T27621: [Segmentation] 3D Threshold / UL Threshold does not use a timestep != 0 for static masks from [Segmentation] 3D Threshold does not use a timestep != 0 for static masks to [Segmentation] 3D Threshold / UL Threshold does not use a timestep != 0 for static masks.
Jul 29 2020, 1:49 PM · Restricted Project, Cleared, MITK (v2021.02)
kalali renamed T27622: [Segmentation] Make 3D Threshold / UL Threshold only for on a single timestep for a dynamic mask from [Segmentation] Make 3D Threshold only for on a single timestep for a dynamic mask to [Segmentation] Make 3D Threshold / UL Threshold only for on a single timestep for a dynamic mask.
Jul 29 2020, 1:48 PM · Restricted Project, Cleared, MITK (v2021.02)
thomass closed T27615: [Segmentation] Threshold and UL threshold show unwanted behavior on static and dynamic segmentations as Invalid.

duplicate of T27621

Jul 29 2020, 1:03 PM · MITK (v2021.02)
thomass raised the priority of T27616: [Segmentation] Otsu creates static 3D segmentation regardless of segmentation choice from Normal to High.
Jul 29 2020, 1:02 PM · Breaking Change, MITK (v2021.02)
kalali moved T27622: [Segmentation] Make 3D Threshold / UL Threshold only for on a single timestep for a dynamic mask from Backlog to Segmentation on the MITK (v2021.02) board.
Jul 29 2020, 12:58 PM · Restricted Project, Cleared, MITK (v2021.02)
kalali moved T27621: [Segmentation] 3D Threshold / UL Threshold does not use a timestep != 0 for static masks from Backlog to Segmentation on the MITK (v2021.02) board.
Jul 29 2020, 12:58 PM · Restricted Project, Cleared, MITK (v2021.02)
kalali triaged T27622: [Segmentation] Make 3D Threshold / UL Threshold only for on a single timestep for a dynamic mask as High priority.
Jul 29 2020, 12:58 PM · Restricted Project, Cleared, MITK (v2021.02)
kalali triaged T27621: [Segmentation] 3D Threshold / UL Threshold does not use a timestep != 0 for static masks as High priority.
Jul 29 2020, 12:49 PM · Restricted Project, Cleared, MITK (v2021.02)
thomass closed T27617: [ImageCropper] Workbench crashes when the plugin is opened as Resolved.

Resolved with D369

Jul 29 2020, 11:55 AM · MITK (v2021.02)
nolden committed rMITK64c4c822e255: Fix ImageCropper startup crash (authored by nolden).
Fix ImageCropper startup crash
Jul 29 2020, 11:47 AM
nolden committed rMITKbe8970e7a285: Fix ImageCropper startup crash (authored by nolden).
Fix ImageCropper startup crash
Jul 29 2020, 11:47 AM
kompan claimed T27093: [MITKDoc] Revise Segmentation Plugin.
Jul 29 2020, 11:20 AM · MITK (v2021.02)
kompan moved T27619: MR Perfusion: Use model fit result relation rules for predicate definition from Backlog to Perfusion on the MITK (v2021.02) board.
Jul 29 2020, 11:03 AM · Cleared, MITK (v2021.02)
kompan triaged T27619: MR Perfusion: Use model fit result relation rules for predicate definition as Normal priority.
Jul 29 2020, 11:02 AM · Cleared, MITK (v2021.02)
thomass added a comment to T27097: [MITKDoc] Revise Statistics Plugin Documentation.

that was misleading since the statistics view is in the measurement toolkit view (actually it is quite confusing, maybe we can change that in general)

Jul 29 2020, 10:58 AM · Cleared, MITK (v2021.02)
neher committed rMITKDIFF05a9a10bca71: Merge branch 'T27618-UpdateReadme' (authored by neher).
Merge branch 'T27618-UpdateReadme'
Jul 29 2020, 10:47 AM
neher committed rMITKDIFFc80f89d4a5e1: added ubuntu 20.04 (authored by neher).
added ubuntu 20.04
Jul 29 2020, 10:46 AM
neher added a comment to T27618: Update Readme.

Pushed new branch T27618-UpdateReadme.

Jul 29 2020, 10:46 AM · MITK Diffusion
neher created T27618: Update Readme.
Jul 29 2020, 10:46 AM · MITK Diffusion
koehlerg added a member for trixi: f818k.
Jul 29 2020, 10:43 AM
koehlerg added a member for MIC: f818k.
Jul 29 2020, 10:43 AM
koehlerg added a member for Deep Learning: f818k.
Jul 29 2020, 10:43 AM
kompan committed rMITK24158ffb55c1: Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox. (authored by kompan).
Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox.
Jul 29 2020, 10:37 AM
kompan committed rMITKe8c6a0a2ad5a: Case sensitive spelling of QmitkSingelNodeSelectionWidget. (authored by kompan).
Case sensitive spelling of QmitkSingelNodeSelectionWidget.
Jul 29 2020, 10:37 AM
kompan committed rMITK4c2473dc50f8: Remove unrequired include file. (authored by kompan).
Remove unrequired include file.
Jul 29 2020, 10:37 AM
kompan closed T27043: Refactor ModelFit and Pharmacokinetics plugins to use new selection concept as Resolved by committing rMITK24158ffb55c1: Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox..
Jul 29 2020, 10:37 AM · Cleared, MITK (v2021.02)
kompan closed T27043: Refactor ModelFit and Pharmacokinetics plugins to use new selection concept, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Jul 29 2020, 10:37 AM · MITK, Restricted Project, Cleared
kompan committed rMITK8d63af91b336: Update GUI controls, when AIF mask and image selection has changed. (authored by kompan).
Update GUI controls, when AIF mask and image selection has changed.
Jul 29 2020, 10:37 AM
kompan committed rMITK1b93ec66c172: Enable auto select for AIF mask. (authored by kompan).
Enable auto select for AIF mask.
Jul 29 2020, 10:37 AM
kompan committed rMITK28cfe9a3e4fd: Replace AIF mask and image combo boxes with single node selection widgets. (authored by kompan).
Replace AIF mask and image combo boxes with single node selection widgets.
Jul 29 2020, 10:37 AM
kompan committed rMITK1b6ec1748f4f: Rename OnSelectionChanged to OnNodeSelectionChanged. (authored by kompan).
Rename OnSelectionChanged to OnNodeSelectionChanged.
Jul 29 2020, 10:37 AM
kompan committed rMITK850fbac79fb5: Change size policies. (authored by kompan).
Change size policies.
Jul 29 2020, 10:37 AM
kompan committed rMITKafa09efbeea1: Refactor AIF mask and AIF image selection using new selection concept. (authored by kompan).
Refactor AIF mask and AIF image selection using new selection concept.
Jul 29 2020, 10:37 AM
kompan committed rMITKf8f8c8e47519: Change mask selection to be optional. (authored by kompan).
Change mask selection to be optional.
Jul 29 2020, 10:37 AM
kompan committed rMITK1e641f1b87ae: Activate auto select for time series selection. (authored by kompan).
Activate auto select for time series selection.
Jul 29 2020, 10:37 AM
kompan committed rMITK73f49980871d: Merge branch 'feature/T27043-RefactorModelFitAndPharmacokineticsPluginToUseNewS… (authored by kompan).
Merge branch 'feature/T27043-RefactorModelFitAndPharmacokineticsPluginToUseNewS…
Jul 29 2020, 10:37 AM
kompan committed rMITKeab41537a7bf: Narrow predicates for time series, mask and PDW image selection. (authored by kompan).
Narrow predicates for time series, mask and PDW image selection.
Jul 29 2020, 10:37 AM
kompan committed rMITKcaf612b04010: Replace DataStorageComboBoxes with SingleNodeSelectionWidgets for timeseries… (authored by kompan).
Replace DataStorageComboBoxes with SingleNodeSelectionWidgets for timeseries…
Jul 29 2020, 10:37 AM
thomass added a revision to T27103: [MITKDoc] Revise Point Set Interaction Plugin Documentation: Restricted Differential Revision.
Jul 29 2020, 10:37 AM · Cleared, MITK (v2021.02)
kompan committed rMITK234bec8db139: Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox. (authored by kompan).
Use mitkSingleNodeSelectionWidget instead of QmitkDataStorageComboBox.
Jul 29 2020, 10:36 AM
floca committed rMITK978e3fbf6328: Introduced ModelFitResultRelationRule (authored by floca).
Introduced ModelFitResultRelationRule
Jul 29 2020, 10:26 AM
floca committed rMITKb9af16068179: Fixed review remarks (authored by floca).
Fixed review remarks
Jul 29 2020, 10:26 AM
floca committed rMITK1b57565cf609: Fixed gcc compile errors (authored by floca).
Fixed gcc compile errors
Jul 29 2020, 10:26 AM
floca committed rMITK154cd9ee0f1c: Improved test coverage of SourceImageRelationRule and ModelFitResultRelationRule (authored by floca).
Improved test coverage of SourceImageRelationRule and ModelFitResultRelationRule
Jul 29 2020, 10:26 AM
floca committed rMITKa1f71ea0ee6f: Fixed business logic in the ModelFitInspectorView (authored by floca).
Fixed business logic in the ModelFitInspectorView
Jul 29 2020, 10:26 AM
floca committed rMITK58e8ee2b8bd9: Fixed T26142 by adding persistency for needed PropertyRule properties. (authored by floca).
Fixed T26142 by adding persistency for needed PropertyRule properties.
Jul 29 2020, 10:26 AM
floca committed rMITK98394bbae559: Deprecated old modelfit UID scheme (now uses property rule) (authored by floca).
Deprecated old modelfit UID scheme (now uses property rule)
Jul 29 2020, 10:26 AM
floca closed T27459: [Perfusion] Use PropertyReleationRules for referencing between input image and parameter maps as Resolved by committing rMITKa1f71ea0ee6f: Fixed business logic in the ModelFitInspectorView.
Jul 29 2020, 10:26 AM · Breaking Change, MITK (v2021.02)
floca committed rMITK826398b541aa: Added ModelFitResultRelationRule (authored by floca).
Added ModelFitResultRelationRule
Jul 29 2020, 10:26 AM
floca closed T26142: Property persistence for property relation instance identifing (RII) properties as Resolved by committing rMITK58e8ee2b8bd9: Fixed T26142 by adding persistency for needed PropertyRule properties..
Jul 29 2020, 10:26 AM · Cleared, MITK (v2021.02)
floca closed T26142: Property persistence for property relation instance identifing (RII) properties, a subtask of T23754: DataStorage/Relationship clean up/refactoring, as Resolved.
Jul 29 2020, 10:26 AM · MITK
floca committed rMITKbf292f6e9d09: Corrected ModelFit property description (authored by floca).
Corrected ModelFit property description
Jul 29 2020, 10:26 AM
floca committed rMITK7648cacdc58c: Corrected include guard (authored by floca).
Corrected include guard
Jul 29 2020, 10:26 AM
thomass added a comment to T27617: [ImageCropper] Workbench crashes when the plugin is opened.

Eventually related to changes in D360

Jul 29 2020, 10:02 AM · MITK (v2021.02)
thomass triaged T27617: [ImageCropper] Workbench crashes when the plugin is opened as High priority.
Jul 29 2020, 9:00 AM · MITK (v2021.02)
thomass moved T27608: [MITKDoc] Documentation Refurbish - Developer Manual from Backlog to Documentation on the MITK (v2021.02) board.
Jul 29 2020, 8:09 AM · MITK (v2024.06), Cleared
thomass moved T27616: [Segmentation] Otsu creates static 3D segmentation regardless of segmentation choice from Backlog to Segmentation on the MITK (v2021.02) board.
Jul 29 2020, 8:09 AM · Breaking Change, MITK (v2021.02)
thomass moved T27615: [Segmentation] Threshold and UL threshold show unwanted behavior on static and dynamic segmentations from Backlog to Segmentation on the MITK (v2021.02) board.
Jul 29 2020, 8:09 AM · MITK (v2021.02)

Jul 28 2020

kahl added a comment to T27600: [SWIG] building pyMITK leads to access violation.

If you use Python 3.7/3.8, you need to install SWIG version 4.0.2. This solves the problem. Currently, SWIG version 3.0.2. is installed in the Superbuild.

Jul 28 2020, 5:17 PM · Auto-closed, MITK