Page MenuHomePhabricator
Feed Advanced Search

Jan 17 2023

kislinsk removed a member for MIC: forche.
Jan 17 2023, 7:24 AM
kislinsk removed a member for MIC: s349i.
Jan 17 2023, 7:23 AM
kislinsk removed a member for MIC: o280o.
Jan 17 2023, 7:23 AM

Jan 13 2023

kislinsk added a member for MITK-MBI: a564y.
Jan 13 2023, 4:13 PM
kislinsk claimed T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

Thanks Ralf!

Jan 13 2023, 12:42 AM · MITK

Jan 11 2023

kislinsk closed T29292: Unsupported pixel types as Wontfix.

We see and feel you. Considering the circumstances that Ralf mentioned (it's basically an ITK issue/contribution) I would anyway go for a Won't Fix here on our MITK side for now, until ITK provides the functionalities for such data types. Okay? :)

Jan 11 2023, 1:01 PM · Request for Discussion, MITK
kislinsk moved T29294: Extend &/or Test nnUnet(v2) on Windows from MITK Meeting to Backlog on the Request for Discussion board.
Jan 11 2023, 12:18 PM · MITK (v2023.12), Request for Discussion
kislinsk claimed T29412: List of MITK publications on web page is not up to date.
Jan 11 2023, 12:12 PM · MITK
kislinsk triaged T29437: [SEG] Add TotalSegmentator as High priority.

As it is a really nice user-friendly feature, we have a high interest in getting TotalSegmenter integrated soon into MITK.

Jan 11 2023, 11:49 AM · MITK
kislinsk added a comment to T29130: [WorkBench] Segmentation fault when "Close Project" is invoked and QmitkDataStorageComboBox widget is in UI.

We talked about this task in our meeting today and concluded that we will migrate the DataStorageComboBox in our code to the SingleSelectionWidget and even deprecate the DataStorageComboBox.

Jan 11 2023, 10:15 AM · Moved to git.dkfz.de, MITK

Dec 22 2022

kislinsk added a comment to T24398: Dicom plugin: Retrieve does not work.

Have you pushed your clean ups? Not that your efforts get lost. 😉

Dec 22 2022, 12:17 PM · MITK (v2024.12)

Dec 16 2022

kislinsk added a comment to T29433: MITK Workbench Persistent Crash.

Without a data sample we are not able to reproduce this issue. Can you upload one of these nrrd files? Please make sure that the data does not contain any personal information. You can also restrict access to uploaded files to certain users like me.

Dec 16 2022, 11:05 AM · Auto-closed, Missing Info, MITK

Dec 13 2022

kislinsk moved T29432: [worklist] mitk-flow preload first task from Backlog to MITK Meeting on the Request for Discussion board.
Dec 13 2022, 8:55 PM · MITK
kislinsk added a project to T29432: [worklist] mitk-flow preload first task: Request for Discussion.
Dec 13 2022, 8:54 PM · MITK
kislinsk added a comment to T29432: [worklist] mitk-flow preload first task.

Without any extra preferences, it's as easy as adding the line this->LoadNextUnfinishedTask(); at the end of the OnTaskListChanged() method.

Dec 13 2022, 8:54 PM · MITK
kislinsk closed T29434: Clean up preference pointer anti pattern as Resolved.
Dec 13 2022, 2:46 PM · MITK
kislinsk added a comment to T29434: Clean up preference pointer anti pattern.

Deleted branch from rMITK MITK: bugfix/T29434-CleanUpPrefPtrAntiPattern.

Dec 13 2022, 2:46 PM · MITK
kislinsk committed rMITKcbf2e888a72c: Clean up preferences pointer anti pattern (authored by kislinsk).
Clean up preferences pointer anti pattern
Dec 13 2022, 2:45 PM
kislinsk committed rMITKe3f615b43c0b: Remove old preferences pointer from ctor init list (authored by kislinsk).
Remove old preferences pointer from ctor init list
Dec 13 2022, 2:45 PM
kislinsk committed rMITKc2904532ff3f: Merge branch 'bugfix/T29434-CleanUpPrefPtrAntiPattern' into develop (authored by kislinsk).
Merge branch 'bugfix/T29434-CleanUpPrefPtrAntiPattern' into develop
Dec 13 2022, 2:45 PM
kislinsk triaged T29433: MITK Workbench Persistent Crash as Normal priority.

Thanks for reporting. We are not aware of any crash like this with valid nrrd files. Since ITK snap crashes as well it could be a strong indicator that the crash is happening in the ITK reader that we use as well. It could be probably related to a corrupt nrrd file, or, in case it is a huge file, it could be simply related to running out of memory. Anyway, without the data we are not able to reproduce this issue.

Dec 13 2022, 1:19 PM · Auto-closed, Missing Info, MITK
kislinsk added a revision to T29434: Clean up preference pointer anti pattern: Unknown Object (Differential Revision).
Dec 13 2022, 12:30 PM · MITK
kislinsk added a comment to T29434: Clean up preference pointer anti pattern.

Pushed new branch to rMITK MITK: bugfix/T29434-CleanUpPrefPtrAntiPattern.

Dec 13 2022, 12:23 PM · MITK
kislinsk added a comment to T29025: Preference service (access) based on cpp microservices.

Deleted branch from rMITK MITK: feature/T29025-PreferencesCoreService.

Dec 13 2022, 10:32 AM · MITK (v2023.04), Breaking Change
kislinsk triaged T29434: Clean up preference pointer anti pattern as Normal priority.
Dec 13 2022, 10:31 AM · MITK
kislinsk committed rMITK207ecdb75531: Move BlueBerry preferences to MITK Core services (authored by kislinsk).
Move BlueBerry preferences to MITK Core services
Dec 13 2022, 10:22 AM
kislinsk committed rMITK952b9648480a: Move BlueBerry preferences to MITK Core services (authored by kislinsk).
Move BlueBerry preferences to MITK Core services
Dec 13 2022, 10:22 AM
kislinsk closed T29025: Preference service (access) based on cpp microservices as Resolved by committing rMITK952b9648480a: Move BlueBerry preferences to MITK Core services.
Dec 13 2022, 10:22 AM · MITK (v2023.04), Breaking Change
kislinsk closed T29025: Preference service (access) based on cpp microservices, a subtask of T29027: Move NodeSelectionWidgets to QtWidgets module, as Resolved.
Dec 13 2022, 10:22 AM · MITK (v2023.04)

Dec 12 2022

kislinsk triaged T29381: Move Multilabel classes to Core module as Low priority.

The hash above doesn't seem to be auto-linked. So here it is: rMITKa73e482c0387: moved labelset-related classes out from core

Dec 12 2022, 11:27 AM · MITK, Request for Discussion
kislinsk triaged T29389: Python utility module as Normal priority.

A big leap into the Python direction would be to finally resolve T27923: Integrate possibility to execute Python Code in MITK , which is complete for a while now but we weren't able to figure out why it fails on Ubuntu build clients. Since the ITK v5 upgrade, we also need to adjust a little more I guess.

Dec 12 2022, 11:25 AM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk updated subscribers of T29431: [worklist] mitk-flow: save changed dicom segmentation not possible.

Task lists don't do anything special regarding saving/loading data. So in theory, this bug should be reproducible by regular loading and saving via the menu in the Workbench?
However, task lists are prone to expose existing bugs related to repeated saving/loading of data. We indeed noticed another bug in this direction with .nrrd files, which were erroneous when loaded a second time in certain situations. The reason was faulty handling of properties: T29274: Label Loss on repeatedly loaded and saved segmentations.

Dec 12 2022, 11:21 AM · MITK

Dec 7 2022

kislinsk added a comment to T29428: Creating scene file with image properties can result in missing LevelWindowbar.

Reading your other task regarding mitkscene files I wonder if it has something to to with attaching the level window property to the BaseData property list instead of the DataNode property list. In principle, the level window should be attached to the latter one as it is an "appearance" property and not something instrinsic to the data. A few years ago we changed the way properties are queried and when a property is not present in a DataNode property list, the Base Data property list is queried as fallback. Maybe it is not fully functional for level windows as it could be that the code somehow relies on / assumes that the properties are located in the DataNode property list.

Dec 7 2022, 10:00 AM · MITK
kislinsk added a comment to T29427: FlowBench mitkscene structure has changed..

Not sure if I fully understand what is going on here but the difference is that in your first example you have DataNode properties and in your second example you have BaseData properties, right? Let's talk about it in our group 5 meeting today. :)

Dec 7 2022, 9:56 AM · MITK

Dec 1 2022

kislinsk updated subscribers of T29421: Finding CppRestSDK library alternative.

@a178n I added cpp-httplib as dependency to MITK in the branch mentioned above so you can easily experiment with it. For details, see rMITKf88e3d05aeb0: Add cpp-httplib as optional dependency.

Dec 1 2022, 1:51 PM · MITK (v2024.12)
kislinsk added a comment to T29421: Finding CppRestSDK library alternative.

Pushed new branch to rMITK MITK: feature/T29421-httplib.

Dec 1 2022, 1:49 PM · MITK (v2024.12)

Nov 30 2022

kislinsk moved T29337: Global Reinit HotKey functionality not there in Mac OSX from Others to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2024.12), Cleared, Checklist
kislinsk moved T28262: TimeGeometry inconsistent documentation and implementation of time bounds and checks from Others to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk moved T27189: REST API for data storage from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12), Restricted Project, Request for Discussion
kislinsk moved T27718: Miniapp for basic DICOM testing from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.12), Kaapana (internal)
kislinsk moved T29027: Move NodeSelectionWidgets to QtWidgets module from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04)
kislinsk moved T29140: [Selection widget] Optional selection can not be removed if a fitting node is always found from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion
kislinsk moved T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk moved T27613: Improve reinit behavior from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Request for Discussion, MITK (v2023.04)
kislinsk moved T27090: Provide standard NodePredicates from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion
kislinsk moved T29163: [XNAT] Opening XNAT session fails from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk moved T29236: Check for prerequisites and give meaningful hints for missing packages from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk moved T29242: Revamp nnUNet tool GUI from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk moved T26394: [Render window manager] Provide tree view / model from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04), Restricted Project
kislinsk moved T29385: [mxn multi widget] Pixel value view does not change on crosshair selection from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · MITK (v2023.04)
kislinsk moved T25057: Check IContextMenuActions and extension points from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12)
kislinsk moved T29210: Clarify / remove axis-labeling for anatomical planes from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12), Request for Discussion
kislinsk moved T29243: nnUNet in MITK: Downloading pre-trained models in Kaapana context from In candidates to Backlog on the MITK (v2023.04) board.
Nov 30 2022, 12:23 PM · Moved to git.dkfz.de, MITK (v2024.12), Kaapana (internal)
kislinsk edited projects for T29095: [Image Cropper] Moving of the bounding box can not be undone, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · Moved to git.dkfz.de, MITK, Checklist
kislinsk edited projects for T29211: Remove "Scaling" from QmitkRegistrationManipulationWidget.ui, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · Moved to git.dkfz.de, MITK
kislinsk edited projects for T28778: "Use constraint zooming and panning" is only applied after reinit/restart, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · Moved to git.dkfz.de, MITK, Checklist
kislinsk edited projects for T28803: [Properties] Fine-tune selection widget, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · Moved to git.dkfz.de, MITK, Checklist
kislinsk edited projects for T29101: [3D Segmentation] Region Growing Tool - Generated Segmentation darkens the ambient image, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK, Checklist
kislinsk edited projects for T29336: Changing theme in Preferences has no effect., added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK, Checklist
kislinsk edited projects for T29309: [GrowCut] Further remarks regarding GrowCut, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK
kislinsk edited projects for T27142: Unit test for average baseline signal, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:22 PM · MITK, Restricted Project
kislinsk edited projects for T28557: Cannot load segmentations from KITS challenge due to unknown pixel type, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:21 PM · Moved to git.dkfz.de, MITK, Request for Discussion
kislinsk edited projects for T28782: Scanning directories in DICOM Browser -> Import only works once, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:21 PM · Moved to git.dkfz.de, MITK, Checklist
kislinsk edited projects for T28781: Selected series and studies cannot be deleted from DICOM browser without deleting the whole patient, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:21 PM · Moved to git.dkfz.de, MITK, Checklist
kislinsk edited projects for T28207: MITK DicomBrowser q/r Retrieve part crash, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:21 PM · MITK, Checklist
kislinsk edited projects for T29381: Move Multilabel classes to Core module, added: MITK; removed MITK (v2023.04).
Nov 30 2022, 12:21 PM · MITK, Request for Discussion
kislinsk added a comment to T28585: The MITK-Tutorial Step 9 missing inheritence.

The plugin generator has been removed for now. Step 9 should be redesigned if the plugin generator was the blocker.

Nov 30 2022, 10:06 AM · MITK (v2024.12)
kislinsk closed T27701: Overhaul or remove PluginGenerator as Resolved.

Removed the last remnants of the plugin generator.

Nov 30 2022, 2:04 AM · MITK, Next Milestone
kislinsk added a comment to T27701: Overhaul or remove PluginGenerator.

Deleted branch from rMITK MITK: bugfix/T27701-RemovePluginGenerator.

Nov 30 2022, 2:03 AM · MITK, Next Milestone
kislinsk committed rMITK6f1eaa7585da: Remove plugin generator (authored by kislinsk).
Remove plugin generator
Nov 30 2022, 2:01 AM
kislinsk committed rMITKbfef8ac7a2a2: Merge branch 'bugfix/T27701-RemovePluginGenerator' into develop (authored by kislinsk).
Merge branch 'bugfix/T27701-RemovePluginGenerator' into develop
Nov 30 2022, 2:01 AM
kislinsk added a comment to T27701: Overhaul or remove PluginGenerator.

Pushed new branch to rMITK MITK: bugfix/T27701-RemovePluginGenerator.

Nov 30 2022, 2:00 AM · MITK, Next Milestone
kislinsk added a comment to T27701: Overhaul or remove PluginGenerator.

Deleted branch from rMITK MITK: bugfix/T27701-RemovePluginGenerator.

Nov 30 2022, 1:08 AM · MITK, Next Milestone

Nov 29 2022

kislinsk added a comment to T27701: Overhaul or remove PluginGenerator.

Pushed new branch to rMITK MITK: bugfix/T27701-RemovePluginGenerator.

Nov 29 2022, 10:10 PM · MITK, Next Milestone

Nov 25 2022

kislinsk moved T29025: Preference service (access) based on cpp microservices from Backlog to Cycle on the MITK (v2023.04) board.
Nov 25 2022, 10:45 PM · MITK (v2023.04), Breaking Change
kislinsk edited projects for T29025: Preference service (access) based on cpp microservices, added: Breaking Change, MITK (v2023.04); removed Request for Discussion, MITK.

Migration guide and a ton of examples can be found in {D763}.

Nov 25 2022, 10:45 PM · MITK (v2023.04), Breaking Change
kislinsk added a revision to T29025: Preference service (access) based on cpp microservices: Unknown Object (Differential Revision).
Nov 25 2022, 10:44 PM · MITK (v2023.04), Breaking Change

Nov 24 2022

kislinsk added a comment to T29025: Preference service (access) based on cpp microservices.

Pushed new branch to rMITK MITK: feature/T29025-PreferencesCoreService.

Nov 24 2022, 4:55 PM · MITK (v2023.04), Breaking Change

Nov 23 2022

kislinsk created MITK (v2023.04).
Nov 23 2022, 2:39 PM
kislinsk added a comment to T27923: Integrate possibility to execute Python Code in MITK .

I created a new integration branch and Differential based on the latest develop.

Nov 23 2022, 11:31 AM · MITK
kislinsk added a revision to T27923: Integrate possibility to execute Python Code in MITK : Restricted Differential Revision.
Nov 23 2022, 11:30 AM · MITK
kislinsk added a comment to T27923: Integrate possibility to execute Python Code in MITK .

Deleted branch from rMITK MITK: feature/T27923-python-dev.

Nov 23 2022, 11:24 AM · MITK
kislinsk added a comment to T27923: Integrate possibility to execute Python Code in MITK .

Deleted branch from rMITK MITK: feature/T27923-execute-python-code-in-mitk.

Nov 23 2022, 11:24 AM · MITK
kislinsk added a comment to T27923: Integrate possibility to execute Python Code in MITK .

Pushed new branch to rMITK MITK: feature/T27923-ExecPythonCodeInMITK.

Nov 23 2022, 11:23 AM · MITK

Nov 22 2022

kislinsk updated the task description for T29406: Make MITK compatible with Qt 6.
Nov 22 2022, 9:44 AM · MITK (v2024.06)
kislinsk updated the task description for T29406: Make MITK compatible with Qt 6.
Nov 22 2022, 8:57 AM · MITK (v2024.06)
kislinsk triaged T29406: Make MITK compatible with Qt 6 as Normal priority.
Nov 22 2022, 8:56 AM · MITK (v2024.06)

Nov 21 2022

kislinsk claimed T27701: Overhaul or remove PluginGenerator.
Nov 21 2022, 2:02 AM · MITK, Next Milestone

Nov 8 2022

kislinsk committed rMITK51ababc09f67: Uninitialize slices interpolator when render window part is deactivated (authored by kislinsk).
Uninitialize slices interpolator when render window part is deactivated
Nov 8 2022, 5:04 PM
kislinsk committed rMITKb2928e2b2dc5: Uninitialize slices interpolator when render window part is deactivated (authored by kislinsk).
Uninitialize slices interpolator when render window part is deactivated
Nov 8 2022, 5:04 PM
kislinsk closed T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash as Resolved by committing rMITKb2928e2b2dc5: Uninitialize slices interpolator when render window part is deactivated.
Nov 8 2022, 5:04 PM · MITK
kislinsk added a revision to T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash: Unknown Object (Differential Revision).
Nov 8 2022, 5:27 AM · MITK
kislinsk added a comment to T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash.

Shortcut to reproduce the crash:

  • Start the Workbench
  • If not already opened, open the Segmentation View
  • Close the project or close the Standard Display
  • Load any segmentation
Nov 8 2022, 5:15 AM · MITK

Nov 7 2022

kislinsk added a comment to T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash.

The interesting part here is that m_Time of mitk::BaseController is not supposed to be nullptr in particular as m_Slice is a valid stepper. My first guess is that a partly deconstructed controller is triggered here.

Nov 7 2022, 12:32 PM · MITK
kislinsk added a comment to T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash.

The crash happens in mitk::SliceNavigationController::GetSelectedTimeStep() as m_Time (mitk::Stepper::Pointer) is accessed while it is a nullptr. The events that lead to this situation are that the mitk::ToolManager notifies QmitkSlicesInterpolator via OnToolManagerWorkingDataModified(). This method calls SetCurrentContourListID() in turn, which executes the crashing line of code:

Nov 7 2022, 12:29 PM · MITK
kislinsk triaged T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash as High priority.
Nov 7 2022, 12:08 PM · MITK

Nov 6 2022

kislinsk claimed T29025: Preference service (access) based on cpp microservices.

I stumbled upon this while working on T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module. I would like to tackle this issue and already started looking into this. Do you already have an idea how to approach it or do we want to discuss it next week?

Nov 6 2022, 2:25 PM · MITK (v2023.04), Breaking Change

Oct 29 2022

kislinsk closed T29378: MITK v2022.10 as Resolved.
Oct 29 2022, 10:20 AM · MITK-ProjectTemplate, MITK (v2022.10)
kislinsk added a comment to T29378: MITK v2022.10.

Deleted branch from rMITK MITK: release/T29378-v2022.10.

Oct 29 2022, 10:19 AM · MITK-ProjectTemplate, MITK (v2022.10)
kislinsk committed rMITKa3784a36cec0: Bump version to v2022.10.99 (authored by kislinsk).
Bump version to v2022.10.99
Oct 29 2022, 10:18 AM