Page MenuHomePhabricator
Feed Advanced Search

Jul 4 2023

s434n moved T29579: [Documentation] Help page of Pointset Interaction has no table of contents from Backlog to Cycle on the MITK (v2023.12) board.
Jul 4 2023, 5:26 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
s434n moved T29580: [Measurement] Unclear how to end drawing with some tools from Backlog to Cycle on the MITK (v2023.12) board.
Jul 4 2023, 5:26 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
s434n moved T29641: [Movie Maker] Allow rotation around different axes from Backlog to Cycle on the MITK (v2023.12) board.
Jul 4 2023, 4:59 PM · Moved to git.dkfz.de, MITK (v2024.12)

Jun 20 2023

s434n triaged T29641: [Movie Maker] Allow rotation around different axes as Normal priority.
Jun 20 2023, 10:46 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n triaged T29639: [Registration] Mapping crashes when super-sampling is activated as Normal priority.
Jun 20 2023, 10:44 AM · Moved to git.dkfz.de, MITK (v2024.12), Missing Info

Jun 2 2023

s434n committed rRTTB2b478446abcb: align test result matrices for better overview (authored by s434n).
align test result matrices for better overview
Jun 2 2023, 10:57 AM

May 25 2023

s434n closed T26555: [mxn multi widget] Provide different default layouts, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
May 25 2023, 4:33 PM · Moved to git.dkfz.de, MITK
s434n closed T26555: [mxn multi widget] Provide different default layouts as Resolved.

During our testing event there were no suggestions for new layouts people would like, so this task will be closed and any layouts that are requested in the future can be added on demand.

May 25 2023, 4:33 PM · MITK

May 24 2023

s434n added a comment to T29620: Check if GenericFitMiniApp supports the needed model.

What exactly was the model again? Just an exponential decay?

May 24 2023, 5:54 PM · Missing Info, MITK, Restricted Project, Restricted Project
s434n created T29616: [DICOM] Add option to save images as DICOM.
May 24 2023, 4:45 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n added a comment to T29608: [Segmentation Utils] Workbench crashes for Morphological operations.

This is more of the stack trace:

MitkCore.dll!mitk::ImageDataItem::GetData() Zeile 131
MitkCore.dll!mitk::Image::Image(const mitk::Image & other) Zeile 83
MitkMultilabel.dll!mitk::LabelSetImage::LabelSetImage(const mitk::LabelSetImage & other) Zeile 75
MitkMultilabel.dll!mitk::LabelSetImage::InternalClone() Zeile 494
MitkMultilabel.dll!mitk::LabelSetImage::Clone() Zeile 33
MitkSegmentationUI.dll!ModifyLabelProcessing<3>(mitk::LabelSetImage * labelSetImage, itk::SmartPointer<mitk::SurfaceInterpolationController> surfaceInterpolator, unsigned int timePoint) Zeile 203
MitkSegmentationUI.dll!QmitkSlicesInterpolator::OnModifyLabelChanged(const itk::Object * caller, const itk::EventObject & __formal) Zeile 1915
May 24 2023, 10:35 AM · MITK (v2023.12)

May 22 2023

s434n added a comment to T29608: [Segmentation Utils] Workbench crashes for Morphological operations.

Can reproduce. When debugging, the error is caused while trying to clone a LabelSetImage. While creating a new mitk::Image from a reference, it tries to get:

ImageDataItemPointer volume = other.GetVolumeData(0);
this->SetVolume(volume->GetData(), 0);

but volume is nullptr.
I'm not sure if this just needs a nullptr safeguard (and eventually an additional default initialization?) or if this should not be able to happen in the first place.

May 22 2023, 10:26 AM · MITK (v2023.12)

May 12 2023

s434n committed rMITKd9f6ca2f596d: Automatically set .json file ending for MxN layout files (authored by s434n).
Automatically set .json file ending for MxN layout files
May 12 2023, 11:08 AM
s434n committed rMITKd544cde8c955: automatically set MxN layout file ending when missing (authored by s434n).
automatically set MxN layout file ending when missing
May 12 2023, 11:08 AM

May 11 2023

s434n closed T29492: [mxn multi widget] Update and extend checklist as Resolved.
May 11 2023, 3:17 PM · MITK (v2023.04)
s434n added a revision to T29585: [MxN] Loading layout needs .json file ending: Unknown Object (Differential Revision).
May 11 2023, 11:03 AM · Checklist, MITK (v2023.04)

May 9 2023

s434n triaged T29585: [MxN] Loading layout needs .json file ending as Normal priority.
May 9 2023, 4:27 PM · Checklist, MITK (v2023.04)
s434n moved T29585: [MxN] Loading layout needs .json file ending from Backlog to Cycle on the MITK (v2023.04) board.
May 9 2023, 4:27 PM · Checklist, MITK (v2023.04)
s434n claimed T29585: [MxN] Loading layout needs .json file ending.
May 9 2023, 3:46 PM · Checklist, MITK (v2023.04)
s434n closed T29587: [MxN] Resetting render window to specific image always fills visible area with highest image in Data Manager as Invalid.

This is behavior as intended. The "reset" is basically a reinit to the specified image. When there is an image higher in the list, it is rendered on top, just as in the standard display and the data manager.
I have added a hint in the checklist to make it clear this is how it is supposed to work.

May 9 2023, 3:46 PM · Checklist, MITK (v2023.04)

May 8 2023

s434n triaged T29584: [Interpolation] Confirming 3D interpolation does not set mode to "disabled" as Low priority.
May 8 2023, 2:27 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
s434n triaged T29583: [Interpolation] Interpolation is not triggered correctly as Low priority.
May 8 2023, 1:48 PM · MITK (v2024.06), Checklist
s434n triaged T29582: [Segmentation] Error when pressing "Undo" after undoing all fill changes as Normal priority.
May 8 2023, 1:22 PM · Moved to git.dkfz.de, MITK (v2024.12), Missing Info, Checklist
s434n triaged T29581: [Segmentation] Switch tool icon next to cursor when inverting via Ctrl as Wishlist priority.
May 8 2023, 12:47 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
s434n triaged T29580: [Measurement] Unclear how to end drawing with some tools as Wishlist priority.
May 8 2023, 12:13 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
s434n triaged T29579: [Documentation] Help page of Pointset Interaction has no table of contents as Low priority.
May 8 2023, 11:43 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
s434n triaged T29578: [Segmentation] Removing last selected region in picking tool does not update preview as Low priority.
May 8 2023, 11:31 AM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
s434n triaged T29577: [Segmentation] Otsu tool does not create and transfer label names correctly in added groups as Normal priority.
May 8 2023, 11:24 AM · Checklist, MITK (v2023.04)
s434n triaged T29575: [Segmentation] Threshold tool crashes when new label is created during preview as High priority.
May 8 2023, 9:58 AM · Request for Discussion, Checklist, MITK (v2023.04)
s434n closed T29568: [MxN] Add MxN MultiWidget to workbench release configuration as Resolved.
May 8 2023, 9:35 AM · MITK (v2023.04)
s434n committed rMITK161d55102438: add MxN to Default build configuration (authored by s434n).
add MxN to Default build configuration
May 8 2023, 9:28 AM
s434n committed rMITK0e2d28a3f276: Add MxN to Default build configuration (authored by s434n).
Add MxN to Default build configuration
May 8 2023, 9:28 AM

May 5 2023

s434n added a revision to T29568: [MxN] Add MxN MultiWidget to workbench release configuration: Unknown Object (Differential Revision).
May 5 2023, 3:49 PM · MITK (v2023.04)
s434n triaged T29570: [Preferences] Render window decoration color not immediately updated in Image Navigator as Low priority.
May 5 2023, 2:58 PM · Moved to git.dkfz.de, MITK (v2024.12), Checklist
s434n triaged T29568: [MxN] Add MxN MultiWidget to workbench release configuration as Unbreak Now! priority.
May 5 2023, 11:43 AM · MITK (v2023.04)

May 4 2023

s434n added a subtask for T29309: [GrowCut] Further remarks regarding GrowCut: T29562: [GrowCut] "Undo" only changes slices with seed images.
May 4 2023, 1:46 PM · MITK
s434n added a parent task for T29562: [GrowCut] "Undo" only changes slices with seed images: T29309: [GrowCut] Further remarks regarding GrowCut.
May 4 2023, 1:46 PM · Moved to git.dkfz.de, Request for Discussion, MITK
s434n triaged T29562: [GrowCut] "Undo" only changes slices with seed images as Normal priority.
May 4 2023, 1:46 PM · Moved to git.dkfz.de, Request for Discussion, MITK

May 3 2023

s434n closed T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash as Resolved.
May 3 2023, 6:02 PM · MITK (v2023.04)
s434n committed rMITKd951ff141fda: Correctly handle segmentation observers in interpolation (authored by s434n).
Correctly handle segmentation observers in interpolation
May 3 2023, 5:57 PM
s434n committed rMITK51d604bd8dfc: remove observers when working data is changed or deleted (authored by s434n).
remove observers when working data is changed or deleted
May 3 2023, 5:57 PM
s434n added a revision to T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash: Unknown Object (Differential Revision).
May 3 2023, 5:40 PM · MITK (v2023.04)
s434n committed rMITK0a303fed6cd3: Fix segmentation serialization by changing serializer name back (authored by s434n).
Fix segmentation serialization by changing serializer name back
May 3 2023, 5:34 PM
s434n committed rMITK074e26fd7843: rename MultiLabelSegmentationSerializer back to LabelSetImageSerializer (authored by s434n).
rename MultiLabelSegmentationSerializer back to LabelSetImageSerializer
May 3 2023, 5:34 PM
s434n added a revision to T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash: Unknown Object (Differential Revision).
May 3 2023, 5:26 PM · MITK (v2023.04)
s434n closed T29554: [Segmentation] Creating a new group while interpolating causes crash as Resolved.
May 3 2023, 3:01 PM · MITK (v2023.04)
s434n added a revision to T29554: [Segmentation] Creating a new group while interpolating causes crash: Unknown Object (Differential Revision).
May 3 2023, 3:01 PM · MITK (v2023.04)
s434n committed rMITK9b949db68c3b: Fix crashes when adding group while interpolating (authored by s434n).
Fix crashes when adding group while interpolating
May 3 2023, 3:00 PM
s434n committed rMITK107fe1951b25: remove unnecessary nullptr initialization (authored by s434n).
remove unnecessary nullptr initialization
May 3 2023, 3:00 PM
s434n committed rMITKbcd26584c9cf: check if active label is nullptr to avoid crashes (authored by s434n).
check if active label is nullptr to avoid crashes
May 3 2023, 3:00 PM
s434n closed T29285: [Checklist] Revise Remeshing checklist as Resolved.
May 3 2023, 11:19 AM · MITK (v2023.04), Checklist
s434n placed T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers up for grabs.

This task should be revised / kept in mind when reworking the interpolation in general

May 3 2023, 11:15 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n edited projects for T29295: MONAI Label App as auto-segmentation tool in MITK, added: Next Milestone, MITK; removed MITK (v2023.04).
May 3 2023, 11:14 AM · Moved to git.dkfz.de, MITK (v2024.12)
s434n placed T28491: [Segmentation] Slice interpolation 'confirm for all slices' sometimes crahes up for grabs.

This task should be revised / checked if the problem still exists when the interpolation controller has been reworked.

May 3 2023, 11:12 AM · MITK (v2023.12)
s434n placed T29105: [3D Surface Interpolation] 3D+t Interpolation Preview Crashes When Going Through Different Time Steps up for grabs.
May 3 2023, 11:07 AM · Breaking Change, MITK (v2024.06), Checklist
s434n claimed T29547: [Segmentation] Segmentations cannot be serialized into project files and related crash.
May 3 2023, 11:02 AM · MITK (v2023.04)
s434n moved T29451: [SEG] Response labels all not displayed on Workbench from Backlog to Cycle on the MITK (v2023.04) board.
May 3 2023, 11:01 AM · Cleared, MITK (v2023.04)
s434n moved T29548: [Segmentation] Missing I- button from Backlog to Cycle on the MITK (v2023.04) board.
May 3 2023, 11:00 AM · MITK (v2023.04)
s434n moved T29554: [Segmentation] Creating a new group while interpolating causes crash from Backlog to Cycle on the MITK (v2023.04) board.
May 3 2023, 11:00 AM · MITK (v2023.04)
s434n committed rMITK73e2653f20ac: update names in MultiLabelTreeModelTest to [x] format (authored by s434n).
update names in MultiLabelTreeModelTest to [x] format
May 3 2023, 9:47 AM
s434n committed rMITKb0ecf2e828ed: Fix QmitkMultiLabelTreeModelTest (authored by s434n).
Fix QmitkMultiLabelTreeModelTest
May 3 2023, 9:47 AM

May 2 2023

s434n committed rMITK153c651cd278: Fix single slice confirmation using first label (authored by s434n).
Fix single slice confirmation using first label
May 2 2023, 3:12 PM
s434n closed T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label as Resolved by committing rMITK153c651cd278: Fix single slice confirmation using first label.
May 2 2023, 3:12 PM · MITK (v2023.04)
s434n committed rMITKd60fee688b89: add newline at end of file (authored by s434n).
add newline at end of file
May 2 2023, 3:12 PM
s434n committed rMITK6a3ba774a438: consider existing segmentation when transfering interpolated content to avoid… (authored by s434n).
consider existing segmentation when transfering interpolated content to avoid…
May 2 2023, 3:12 PM
s434n committed rMITK608eedaad204: transfer preview to correct label value in single slice confirmation (authored by s434n).
transfer preview to correct label value in single slice confirmation
May 2 2023, 3:12 PM
s434n added a comment to T29554: [Segmentation] Creating a new group while interpolating causes crash.

I think this is caused because the interpolator gets notified of a new group being added as soon as that happens, but before a new label has been added to the group. When trying to update the interpolation, it tries to get the value of the active label inside QmitkSlicesInterpolator::OnInterpolationActivated(), which causes the error because there is no active label set.

May 2 2023, 2:56 PM · MITK (v2023.04)
s434n triaged T29554: [Segmentation] Creating a new group while interpolating causes crash as High priority.
May 2 2023, 2:54 PM · MITK (v2023.04)

Apr 28 2023

s434n committed rMITKbf040ef50daa: Adapt screenshot maker to support MxN MultiWidget (authored by s434n).
Adapt screenshot maker to support MxN MultiWidget
Apr 28 2023, 4:49 PM
s434n committed rMITKa0125d7eead9: fix missing capitalization in Qt header names (authored by s434n).
fix missing capitalization in Qt header names
Apr 28 2023, 4:49 PM
s434n committed rMITKf299aefc4da2: use QDir::separator and correct Qt header name style (authored by s434n).
use QDir::separator and correct Qt header name style
Apr 28 2023, 4:49 PM
s434n committed rMITK20e10ab5b4e9: adapt screenshot maker to support MxN MultiWidget (authored by s434n).
adapt screenshot maker to support MxN MultiWidget
Apr 28 2023, 4:49 PM
s434n added a comment to T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.

I have added a fix for this in D810. It only includes a fix to OnAcceptInterpolationClicked and does not refactor AcceptAllInterpolations, which is still quite clunky. But this should at least solve the buggy behavior.

Apr 28 2023, 4:48 PM · MITK (v2023.04)
s434n added a revision to T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label: Unknown Object (Differential Revision).
Apr 28 2023, 4:46 PM · MITK (v2023.04)

Apr 27 2023

s434n committed rMITK9438e02ecc03: Disable movie maker view when MxN display is active (authored by s434n).
Disable movie maker view when MxN display is active
Apr 27 2023, 1:36 PM
s434n committed rMITK9aa6cd55c343: disable movie maker view when MxN display is active (authored by s434n).
disable movie maker view when MxN display is active
Apr 27 2023, 1:36 PM
s434n committed rMITK875a72d47d23: save parent as member in movie maker (authored by s434n).
save parent as member in movie maker
Apr 27 2023, 1:36 PM

Apr 25 2023

s434n committed rMITK9fd32f3856d8: add MxN documentation to plugin manuals list (authored by s434n).
add MxN documentation to plugin manuals list
Apr 25 2023, 2:54 PM
s434n committed rMITK870a2877df48: Fix the temporary fix for planar figures in MxN (authored by s434n).
Fix the temporary fix for planar figures in MxN
Apr 25 2023, 2:54 PM
s434n committed rMITKf12d9f2983dc: block only MxN windows instead of everything but std in planar figure temp fix (authored by s434n).
block only MxN windows instead of everything but std in planar figure temp fix
Apr 25 2023, 2:54 PM

Apr 24 2023

s434n claimed T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.
Apr 24 2023, 1:48 PM · MITK (v2023.04)
s434n committed rMITKd4252972b8b3: Temporary fix concerning planar figures and MxN (authored by s434n).
Temporary fix concerning planar figures and MxN
Apr 24 2023, 1:48 PM
s434n committed rMITK626bd28d6979: do not filter out 3d std render window in temporary fix (authored by s434n).
do not filter out 3d std render window in temporary fix
Apr 24 2023, 1:48 PM
s434n committed rMITK4de72c04025d: skip rendering of planar figures in windows that are not from StdMultiWidget (authored by s434n).
skip rendering of planar figures in windows that are not from StdMultiWidget
Apr 24 2023, 1:47 PM

Apr 21 2023

s434n added a comment to T29333: [mxn multi widget] Measurements / planar figure not working.

Since this is probably not going to be fixed until this release, I have added a safeguard in PlanarFigureMapper2D::MitkRender() that completely skips rendering of planar figures in all windows that don't belong to the StdMultiWidget, to avoid unexpected behavior and crashes.
When this task is tackled, that needs to be removed!

Apr 21 2023, 3:34 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n claimed T29302: Movie maker plugin does not work correctly with the new mxn multi widget.
Apr 21 2023, 1:46 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n closed T29531: [Properties][MxN] Properties view can crash when windows are changed as Resolved.
Apr 21 2023, 11:32 AM · MITK (v2023.04)
s434n committed rMITKf32a54c1ca37: Make selection in Properties view update on changes (authored by s434n).
Make selection in Properties view update on changes
Apr 21 2023, 11:31 AM
s434n committed rMITKd40cec3d36b3: remove hardcoded number in check before resetting combobox (authored by s434n).
remove hardcoded number in check before resetting combobox
Apr 21 2023, 11:31 AM
s434n committed rMITKae843d11ccfa: update combobox of render window names when IRenderWindowPart changes or is… (authored by s434n).
update combobox of render window names when IRenderWindowPart changes or is…
Apr 21 2023, 11:31 AM

Apr 20 2023

s434n added a revision to T29531: [Properties][MxN] Properties view can crash when windows are changed: Unknown Object (Differential Revision).
Apr 20 2023, 2:49 PM · MITK (v2023.04)
s434n triaged T29531: [Properties][MxN] Properties view can crash when windows are changed as Normal priority.
Apr 20 2023, 2:01 PM · MITK (v2023.04)

Apr 19 2023

s434n closed T29347: Measurement Checklist - Possible inconsistent recentering behavior when clicking on geometry node in Data Manager. as Invalid.

It was discussed and agreed upon, that it does not make sense to adapt this behavior in the Data Manager. If we want a clean implementation of the "set focus on planar figure"-feature, it should belong in the corresponding view (i.e. Measurement) instead of the Data Manager.
As this is not currently a specifically requested feature, this task will be closed.

Apr 19 2023, 12:00 PM · Request for Discussion, Checklist

Apr 17 2023

s434n added a comment to T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers.

This is not solved with {D795}, right? I can still see slicer->GetRenderer() in line 926, so the render window is still retrieved from the slice navigation controller, which requires the getter to be available in the slice navigation controller.

Apr 17 2023, 6:00 PM · Moved to git.dkfz.de, MITK (v2024.12)
s434n closed T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly as Resolved.
Apr 17 2023, 1:02 PM · Request for Discussion, MITK (v2023.04)
s434n committed rMITKcb3252d138eb: Make interpolation work with arbitrary windows (authored by s434n).
Make interpolation work with arbitrary windows
Apr 17 2023, 1:02 PM
s434n committed rMITKdb669006e1b4: remove unused parameter (authored by s434n).
remove unused parameter
Apr 17 2023, 1:02 PM
s434n committed rMITKf54d96a9d628: use corner annotation text and update code style (authored by s434n).
use corner annotation text and update code style
Apr 17 2023, 1:02 PM
s434n committed rMITK3633565343ee: make interpolation work with arbitrary windows instead of hardcoded std windows (authored by s434n).
make interpolation work with arbitrary windows instead of hardcoded std windows
Apr 17 2023, 1:02 PM

Apr 14 2023

s434n added a revision to T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly: Unknown Object (Differential Revision).
Apr 14 2023, 11:51 AM · Request for Discussion, MITK (v2023.04)