Page MenuHomePhabricator
Feed All Stories

Sep 9 2020

eisenman committed rCHALLENGER833f3c352f41: Fix expectations of value_FUN (authored by eisenman).
Fix expectations of value_FUN
Sep 9 2020, 10:41 PM
eisenman committed rCHALLENGER71b760c11fe6: Let object returned from boxplot function inherit from ggplot again instead of… (authored by eisenman).
Let object returned from boxplot function inherit from ggplot again instead of…
Sep 9 2020, 10:06 PM
eisenman committed rCHALLENGERbf8a099952d6: Fix expectations of rank_FUN (authored by eisenman).
Fix expectations of rank_FUN
Sep 9 2020, 9:13 PM
eisenman updated subscribers of T27694: Fix failing unit tests.
Sep 9 2020, 9:07 PM · challengeR (v1.0)
eisenman claimed T27694: Fix failing unit tests.
Sep 9 2020, 9:06 PM · challengeR (v1.0)
eisenman added a comment to T27385: Variables holding the aggregated value are named differently for single- and multi-task challenges.

The tests in test-rankThenAggregate.R are failing because the expectation is "rank_FUN" but should be "rank_mean" or "rank_median" respectively after the changes. This will be fixed in T27694.

Sep 9 2020, 9:04 PM · challengeR (v1.0)
eisenman moved T27694: Fix failing unit tests from Backlog to In Progress on the challengeR (v1.0) board.
Sep 9 2020, 9:03 PM · challengeR (v1.0)
schererj added a comment to T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics).

@floca I tried to build this configuration - but I cant find the executable.

Sep 9 2020, 6:12 PM · HiGHmed, Kaapana (internal), MITK
kalali added a revision to T27096: [MITKDoc] Revise MultiLabel Segmentation Utilities Plugin Documentation: Unknown Object (Differential Revision).
Sep 9 2020, 4:36 PM · MITK (v2021.02)
kalali added a comment to T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation.

Another utility Contour to image was added so I had to add a screenshot. For visual consistency I changed all screenshots.

Sep 9 2020, 3:43 PM · Cleared, MITK (v2021.02)
kalali added a revision to T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation: Unknown Object (Differential Revision).
Sep 9 2020, 3:41 PM · Cleared, MITK (v2021.02)
kislinsk added a revision to T27624: Fix Doxygen errors: Unknown Object (Differential Revision).
Sep 9 2020, 9:50 AM · MITK (v2021.02)
floca committed rMITKd145b937dd99: T27702 - Configuration to build classification cmd apps (authored by floca).
T27702 - Configuration to build classification cmd apps
Sep 9 2020, 9:38 AM
floca committed rMITK8e55b04ebcd5: Configuration to build classification cmd apps (authored by floca).
Configuration to build classification cmd apps
Sep 9 2020, 9:38 AM
floca closed T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics) as Resolved by committing rMITK8e55b04ebcd5: Configuration to build classification cmd apps.
Sep 9 2020, 9:38 AM · HiGHmed, Kaapana (internal), MITK
kislinsk added a comment to T27624: Fix Doxygen errors.

Pushed new branch bugfix/T27624-FixDoxygenErrors.

Sep 9 2020, 9:27 AM · MITK (v2021.02)
kislinsk closed T27670: [Documentation] invalid link in MITK Style Guide as Resolved.

Thanks!

Sep 9 2020, 3:28 AM · MITK (v2021.02)
kislinsk added a comment to T27670: [Documentation] invalid link in MITK Style Guide.

Deleted branch bugfix/T27670-InvalidLinkInStyleGuide.

Sep 9 2020, 3:27 AM · MITK (v2021.02)
kislinsk committed rMITK428b689257c2: Merge branch 'bugfix/T27670-InvalidLinkInStyleGuide' into develop (authored by kislinsk).
Merge branch 'bugfix/T27670-InvalidLinkInStyleGuide' into develop
Sep 9 2020, 3:26 AM
kislinsk added a comment to T27670: [Documentation] invalid link in MITK Style Guide.

Pushed new branch bugfix/T27670-InvalidLinkInStyleGuide.

Sep 9 2020, 3:26 AM · MITK (v2021.02)
kislinsk added a revision to T27697: Documentation feedback received from testers : Unknown Object (Differential Revision).
Sep 9 2020, 3:19 AM · Auto-closed, MITK
kislinsk closed T27661: [Documentation] Update "How to create a new MITK Module" as Resolved.
Sep 9 2020, 3:15 AM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27661: [Documentation] Update "How to create a new MITK Module".

Deleted branch bugfix/T27661-NewModuleDoc.

Sep 9 2020, 3:13 AM · Cleared, MITK (v2021.02)
kislinsk committed rMITKf502f8a50ebf: Merge branch 'bugfix/T27661-NewModuleDoc' into develop (authored by kislinsk).
Merge branch 'bugfix/T27661-NewModuleDoc' into develop
Sep 9 2020, 3:12 AM
kislinsk added a comment to T27661: [Documentation] Update "How to create a new MITK Module".

Pushed new branch bugfix/T27661-NewModuleDoc.

Sep 9 2020, 3:11 AM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27695: 2020 Week 36 (Very Early September).
Sep 9 2020, 2:58 AM · MITK
kislinsk committed rMITK46a8bcfc8862: Merge branch 'release/T27695-2020-Week-36' into develop (authored by kislinsk).
Merge branch 'release/T27695-2020-Week-36' into develop
Sep 9 2020, 2:49 AM
kislinsk added a comment to T27695: 2020 Week 36 (Very Early September).
Sep 9 2020, 2:46 AM · MITK
kislinsk committed rMITKc41827f2584d: Received feedback from tutorial testers (authored by thomass).
Received feedback from tutorial testers
Sep 9 2020, 2:28 AM
kislinsk committed rMITKb8cd14e19625: Received feedback from tutorial testers (authored by thomass).
Received feedback from tutorial testers
Sep 9 2020, 2:28 AM
kislinsk committed rMITK09cf4bd1c505: T27095 - Rework Multi-label segmentation documentation (authored by thomass).
T27095 - Rework Multi-label segmentation documentation
Sep 9 2020, 2:27 AM
kislinsk committed rMITK566d05687843: T27095 - Rework Multi-label segmentation documentation (authored by thomass).
T27095 - Rework Multi-label segmentation documentation
Sep 9 2020, 2:27 AM
kislinsk closed T27095: [MITKDoc] Revise MultiLabel Segmentation Plugin Documentation as Resolved by committing rMITK566d05687843: T27095 - Rework Multi-label segmentation documentation.
Sep 9 2020, 2:27 AM · MITK (v2021.02)

Sep 8 2020

floca added a comment to T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics).

Ok, for the beginning, to have a configuration as fast as possible for the kaapana release, I have kept Qt on board as dependency and not started to mess arround in code.

Sep 8 2020, 3:56 PM · HiGHmed, Kaapana (internal), MITK
floca added a revision to T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics): Unknown Object (Differential Revision).
Sep 8 2020, 3:47 PM · HiGHmed, Kaapana (internal), MITK
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

macOS MatchPoint errors that are actually just warnings should be fixed now as well. It's a bug in CMake/CTest and the workaround is to use launchers: https://gitlab.kitware.com/cmake/cmake/-/issues/20832

Sep 8 2020, 1:54 PM · CI, MITK (v2021.02), Restricted Project
kislinsk committed rMITK923677a343b7: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 8 2020, 1:08 PM
schererj added a comment to T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics).

@schererj Do you mean the XML result export?

Sep 8 2020, 12:18 PM · HiGHmed, Kaapana (internal), MITK
e249r added a comment to T27189: REST API for data storage.

Pushed new branch feature/T27189-RestApiForDataStorage.

Sep 8 2020, 12:01 PM · MITK (v2024.06), Restricted Project, Request for Discussion
kalali claimed T27096: [MITKDoc] Revise MultiLabel Segmentation Utilities Plugin Documentation.
Sep 8 2020, 11:33 AM · MITK (v2021.02)
kalali claimed T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation.
Sep 8 2020, 11:32 AM · Cleared, MITK (v2021.02)
floca raised the priority of T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics) from Wishlist to High.

@goetzm Thanks for the feedback. I will have a look, if take that road or life with Qt dependency for now. Have to evaluate the impact in practice...

Sep 8 2020, 11:15 AM · HiGHmed, Kaapana (internal), MITK
floca added a comment to T25882: Rewrite dashboard script for CDash 2.6.

OMG. how should one find this...

Sep 8 2020, 11:12 AM · CI, MITK (v2021.02), Restricted Project
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

I finally found the source of the documentation errors by accident. It was a dot digraph with invalid flat edges between record shapes. I changed the shapes to boxes and it should work now.

Sep 8 2020, 10:49 AM · CI, MITK (v2021.02), Restricted Project
kislinsk committed rMITK2661a3470aff: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 8 2020, 10:45 AM
kislinsk triaged T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics) as Wishlist priority.
Sep 8 2020, 10:14 AM · HiGHmed, Kaapana (internal), MITK
kislinsk reassigned T27608: [MITKDoc] Documentation Refurbish - Developer Manual from kislinsk to kompan.
Sep 8 2020, 10:07 AM · MITK (v2024.06), Cleared
kompan added a comment to T27608: [MITKDoc] Documentation Refurbish - Developer Manual.

So far, Sarina and I changed the \section,\subsection to headings <h1>, <h2,>..., such that the table of contents doesn't have too much depth (which is confusing to navigate through). However, the more sensible way would be to keep the \section structure and instead adjust the depth of the doxygen TOC_INCLUDE_HEADINGS. The default depths is 5.

Sep 8 2020, 9:46 AM · MITK (v2024.06), Cleared
kislinsk added a comment to T27608: [MITKDoc] Documentation Refurbish - Developer Manual.

I re-created the branch above, branching off from the latest develop branch.

Sep 8 2020, 9:34 AM · MITK (v2024.06), Cleared
kislinsk added a comment to T27608: [MITKDoc] Documentation Refurbish - Developer Manual.

Pushed new branch bugfix/T27608-DocumentationRefurbish-DeveloperManual.

Sep 8 2020, 9:34 AM · MITK (v2024.06), Cleared
kislinsk added a comment to T27608: [MITKDoc] Documentation Refurbish - Developer Manual.

Deleted branch bugfix/T27608-DocumentationRefurbish-DeveloperManual.

Sep 8 2020, 9:33 AM · MITK (v2024.06), Cleared
goetzm added a comment to T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics).

It really depends. I totally agree that it is not necessary for routine jobs, however it comes in really handy for controlling the data on remote locations were executing MITK is not possible/forbidden. That's why it had been build in.

Sep 8 2020, 9:31 AM · HiGHmed, Kaapana (internal), MITK
kislinsk claimed T27661: [Documentation] Update "How to create a new MITK Module".
Sep 8 2020, 9:25 AM · Cleared, MITK (v2021.02)
kislinsk claimed T27608: [MITKDoc] Documentation Refurbish - Developer Manual.
Sep 8 2020, 9:25 AM · MITK (v2024.06), Cleared
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

I think I fixed the OpenCV Ant issue by updating the volume snapshot for our Ubuntu 20.04 cloud instances to include the environment variable ANT_HOME=/usr/share/ant.

Sep 8 2020, 9:25 AM · CI, MITK (v2021.02), Restricted Project
kleina committed rOBSHYPPOPY2ffecdc1e877: If maximum iterations is reached, self.best contains Wrapped results. We now… (authored by kleina).
If maximum iterations is reached, self.best contains Wrapped results. We now…
Sep 8 2020, 4:29 AM

Sep 7 2020

kleina committed rOBSHYPPOPY1358b14d22f9: Merge branch 'T26755_mpi4hyppopy' of https://github.com/MIC-DKFZ/Hyppopy into… (authored by kleina).
Merge branch 'T26755_mpi4hyppopy' of https://github.com/MIC-DKFZ/Hyppopy into…
Sep 7 2020, 11:09 PM
kleina committed rOBSHYPPOPYea489f818b8b: Differentiate between "not implemented" and "not started via MPI". (authored by kleina).
Differentiate between "not implemented" and "not started via MPI".
Sep 7 2020, 11:09 PM
kleina committed rOBSHYPPOPY1b19f1049760: Handle errors if workers. If error occurs, we send np.nan to the master. (authored by kleina).
Handle errors if workers. If error occurs, we send np.nan to the master.
Sep 7 2020, 11:09 PM
kleina committed rOBSHYPPOPY7b1d6048c077: Code cleanup to improve readability. (authored by kleina).
Code cleanup to improve readability.
Sep 7 2020, 11:09 PM
floca added a revision to T27111: [MITKDoc] Revise Matchpoint Registration Visualizer Plugin Documentation: Unknown Object (Differential Revision).
Sep 7 2020, 10:08 PM · Cleared, MITK (v2021.02)
kleina removed a parent task for T26805: Make the MPI master work as well: Unknown Object (Maniphest Task).
Sep 7 2020, 9:52 PM · Hyppopy
wiesenfa moved T27287: is warning given if na.treat unspecified in rank-first and obligatory otherwise from Backlog to Done on the challengeR (v1.0) board.
Sep 7 2020, 7:06 PM · challengeR (v1.0)
wiesenfa added a comment to T27456: Extraction of task subset from (bootstrap) ranking does not raise an error for invalid task name.

@eisenman I dont understand this task, could you give an example?

Sep 7 2020, 7:05 PM · challengeR (v1.0)
wiesenfa added a comment to T27287: is warning given if na.treat unspecified in rank-first and obligatory otherwise.

solved in T27338

Sep 7 2020, 7:03 PM · challengeR (v1.0)
wiesenfa created T27708: ggplot2 dendrogram .
Sep 7 2020, 7:01 PM · challengeR
wiesenfa added a comment to T27326: autolayout networks in multi task report ugly.

networks should be replaced by some ggplot2 implementation, see
https://journal.r-project.org/archive/2017/RJ-2017-023/RJ-2017-023.pdf

Sep 7 2020, 6:57 PM · challengeR
wiesenfa moved T27449: Consistent handling of plots created for multi-task data sets from In Progress to Done on the challengeR (v1.0) board.
Sep 7 2020, 6:55 PM · challengeR (v1.0)
wiesenfa added a comment to T27449: Consistent handling of plots created for multi-task data sets.

lists of ggplot objects can now be handled like single ggplot objects, e.g. boxbplot(...) + xlab(...) will apply xlab() to every ggplot object

Sep 7 2020, 6:54 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGERffd45a0c13bb: layouting of lists of ggplot objects (authored by wiesenfa).
layouting of lists of ggplot objects
Sep 7 2020, 6:49 PM
wiesenfa added a comment to T27447: significanceMap function raises warning about deprecated function call.

comes from significanceMap.data.frame

Sep 7 2020, 6:34 PM · challengeR (v1.0)
wiesenfa moved T27449: Consistent handling of plots created for multi-task data sets from Backlog to In Progress on the challengeR (v1.0) board.
Sep 7 2020, 6:21 PM · challengeR (v1.0)
wiesenfa added a comment to T27338: Report contains misleading information on missing values.

now as.challenge() as well as report contain extended information on missings and automatically inserted test cases.
@eisenman this changes the tests for as.challenge. Could you please 1. check whether the messages are well phrased and then 2. adapt tests, then 3. close task. Thanks!

Sep 7 2020, 2:40 PM · challengeR (v1.0)
wiesenfa moved T27338: Report contains misleading information on missing values from Backlog to In Progress on the challengeR (v1.0) board.
Sep 7 2020, 2:37 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGERc8b0952b6941: extend na.treat messages (authored by wiesenfa).
extend na.treat messages
Sep 7 2020, 2:37 PM
wiesenfa created T27707: na.treat obligatory for report .
Sep 7 2020, 2:24 PM · challengeR (v1.0)
floca committed rMITKe269e5930aef: T27113 - Revised documentation of MatchPoint Manipulator (authored by floca).
T27113 - Revised documentation of MatchPoint Manipulator
Sep 7 2020, 12:44 PM
floca committed rMITK921ed6752145: Revised documentation of MatchPoint Manipulator (authored by floca).
Revised documentation of MatchPoint Manipulator
Sep 7 2020, 12:44 PM
floca committed rMITK5c25fa6386a2: Fixed review comments (authored by floca).
Fixed review comments
Sep 7 2020, 12:44 PM
floca closed T27113: [MITKDoc] Revise Matchpoint Registration Manipulator Plugin Documentation as Resolved by committing rMITK921ed6752145: Revised documentation of MatchPoint Manipulator.
Sep 7 2020, 12:44 PM · Cleared, MITK (v2021.02)
floca claimed T27655: [statistics] Logic of DataGeneratorBase blocks the UI thread .

I have checked with a prototyp to just move also the core of the generator to an own thread. It helps to make the UI more responsive. BUT it is not enough because the UI (workbench) thread and all other threads must kept seperated, using Qt mechanisms, we need to use a lot of signal/slot and this seems to keep the UI thread (event loop) very bussy.

Sep 7 2020, 12:05 PM · MITK (v2024.06)
kislinsk committed rMITKac0bf7f5dce1: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 7 2020, 11:11 AM

Sep 5 2020

kislinsk committed rMITK94c50addf1ed: Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop (authored by kislinsk).
Merge branch 'bugfix/T25882-RewriteDashboardScript' into develop
Sep 5 2020, 10:17 PM
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

Pushed new branch bugfix/T25882-RewriteDashboardScript.

Sep 5 2020, 8:21 AM · CI, MITK (v2021.02), Restricted Project
kislinsk added a comment to T25882: Rewrite dashboard script for CDash 2.6.

Deleted branch bugfix/T25882-RewriteDashboardScript.

Sep 5 2020, 8:10 AM · CI, MITK (v2021.02), Restricted Project

Sep 4 2020

thomass committed rMITK0ec8c07ca152: T27691 changed subpages in Phenotyping doc to refs to fix linkingproblems (authored by thomass).
T27691 changed subpages in Phenotyping doc to refs to fix linkingproblems
Sep 4 2020, 8:58 PM
thomass closed T27691: [MITKDoc] Documentation links reference "The Phenotyping" subpages as Resolved by committing rMITK0ec8c07ca152: T27691 changed subpages in Phenotyping doc to refs to fix linkingproblems.
Sep 4 2020, 8:58 PM · MITK (v2021.02)
floca added a comment to T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics).

@goetzm Does the GIF mini app realy need the screenshot feature within the app (there is also a CLScreenshot app)?
Reason for the question is, that this feature is the only reason why Qt becomes dragged into the app and it bloats the container/deployment. Just wanted to now if we can the keep the configuration as slim as possible.

Sep 4 2020, 5:30 PM · HiGHmed, Kaapana (internal), MITK
floca added projects to T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics): Kaapana (internal), HiGHmed.
Sep 4 2020, 5:25 PM · HiGHmed, Kaapana (internal), MITK
floca claimed T27702: Create build-configuration for the MitkCLGlobalImageFeatures Miniapp (radiomics).

@schererj Do you mean the XML result export?

Sep 4 2020, 5:24 PM · HiGHmed, Kaapana (internal), MITK
floca moved T27569: US DICOM images are displayed turquoise and LUT cannot be changed from Backlog to MITK Meeting on the Request for Discussion board.
Sep 4 2020, 4:25 PM · Restricted Project, MITK
kislinsk added a comment to T27571: Multilabel segmentation does not work with US DICOM images.

Yes, they are in the workspace of the Nightlies but I hesitate to provide them externally as they have a bunch of problems. Besides the DICOM-loading problem that we currently have with the installers in general, the macOS MITK Workbench from the installer is not executable by clicking on the MitkWorkbench.app. One have to use the terminal, cd into the package and execute the actual MitkWorkbench executable.

Sep 4 2020, 3:46 PM · MITK (v2021.10), Missing Info, Restricted Project
neher triaged T27706: Refactor kaapana radiomics workflow to output xml files as Normal priority.
Sep 4 2020, 3:21 PM · Kaapana (internal)
wiesenfa committed rCHALLENGER24782c58e8e3: fix column names (authored by wiesenfa).
fix column names
Sep 4 2020, 2:38 PM
wiesenfa added a comment to T27385: Variables holding the aggregated value are named differently for single- and multi-task challenges.

now
e.g. if FUN="mean" (i.e. a character) or if FUN=mean (i.e. a function)
the column name will be "value_mean"

Sep 4 2020, 2:32 PM · challengeR (v1.0)
wiesenfa moved T27385: Variables holding the aggregated value are named differently for single- and multi-task challenges from Backlog to In Progress on the challengeR (v1.0) board.
Sep 4 2020, 2:10 PM · challengeR (v1.0)
kompan committed rMITK99efaa26c3c8: Revise and update the concentration curve converter view documentation. (authored by kompan).
Revise and update the concentration curve converter view documentation.
Sep 4 2020, 2:01 PM
kompan committed rMITK4c8fc13639d6: Add section on T2-weighted conversion. (authored by kompan).
Add section on T2-weighted conversion.
Sep 4 2020, 2:00 PM
kompan committed rMITK4a0a481d9b94: Minor corrections in overview and T1-weighted conversion. (authored by kompan).
Minor corrections in overview and T1-weighted conversion.
Sep 4 2020, 2:00 PM
kompan committed rMITKe339686ff18f: Update name to DCE Concentration Curve Converter View. (authored by kompan).
Update name to DCE Concentration Curve Converter View.
Sep 4 2020, 2:00 PM