Page MenuHomePhabricator
Feed All Stories

Jul 27 2022

kislinsk committed rMITKfdd0b0926156: Merge branch 'feature/T29159-SegmentationTasks' into develop (authored by kislinsk).
Merge branch 'feature/T29159-SegmentationTasks' into develop
Jul 27 2022, 9:24 AM
kislinsk closed T29161: [Segmentation] Extend flow bench control view to support worklists, a subtask of T29159: [Segmentation] Flow bench worklist feature , as Resolved.
Jul 27 2022, 9:21 AM · MITK (v2022.10)
kislinsk closed T29161: [Segmentation] Extend flow bench control view to support worklists as Resolved.
Jul 27 2022, 9:21 AM · MITK (v2022.10)
kislinsk closed T29160: [Segmentation] Worklist specification, data structure and io functions, a subtask of T29159: [Segmentation] Flow bench worklist feature , as Resolved.
Jul 27 2022, 9:21 AM · MITK (v2022.10)
kislinsk closed T29160: [Segmentation] Worklist specification, data structure and io functions as Resolved.
Jul 27 2022, 9:21 AM · MITK (v2022.10)
kislinsk closed T29244: Reintroduce ACVD as Resolved.
Jul 27 2022, 9:12 AM · Breaking Change, MITK (v2022.10)
kislinsk added a comment to T29244: Reintroduce ACVD.

Deleted branch from rMITK MITK: feature/T29244-ReintroduceACVD.

Jul 27 2022, 9:11 AM · Breaking Change, MITK (v2022.10)
kislinsk committed rMITK4eb189074193: Replace OpenMesh with ACVD again (authored by kislinsk).
Replace OpenMesh with ACVD again
Jul 27 2022, 9:11 AM
kislinsk committed rMITKaa52b9eae6c1: Prevent warnings as errors in ACVD (authored by kislinsk).
Prevent warnings as errors in ACVD
Jul 27 2022, 9:10 AM
kislinsk committed rMITK064a29176063: Modernize remeshing code (authored by kislinsk).
Modernize remeshing code
Jul 27 2022, 9:10 AM
kislinsk committed rMITK6897b6276b38: Merge branch 'feature/T29244-ReintroduceACVD' into develop (authored by kislinsk).
Merge branch 'feature/T29244-ReintroduceACVD' into develop
Jul 27 2022, 9:10 AM

Jul 26 2022

a178n added a comment to T29239: Download models to new Results_Folder.

Pushed new branch to rMITK MITK: feature/T29239-nnunet-download-without-resultsfolder.

Jul 26 2022, 3:46 PM · MITK (v2022.10)
kislinsk added a revision to T29244: Reintroduce ACVD: Restricted Differential Revision.
Jul 26 2022, 10:19 AM · Breaking Change, MITK (v2022.10)
kislinsk added a comment to T29244: Reintroduce ACVD.

Pushed new branch to rMITK MITK: feature/T29244-ReintroduceACVD.

Jul 26 2022, 10:17 AM · Breaking Change, MITK (v2022.10)
kislinsk triaged T29244: Reintroduce ACVD as Normal priority.
Jul 26 2022, 7:44 AM · Breaking Change, MITK (v2022.10)

Jul 25 2022

c306h added a member for Deep Learning: c162h.
Jul 25 2022, 4:04 PM
c306h added a member for MIC: c162h.
Jul 25 2022, 4:03 PM

Jul 22 2022

gaoh added a comment to T29243: nnUNet in MITK: Downloading pre-trained models in Kaapana context.

ok, but then the GPU problem is also feasible! If it is for a pre-known time-limited usage, like in an interactive session, I don't see a problem assigning a GPU to the container.

Jul 22 2022, 2:26 PM · MITK (v2024.06), Kaapana (internal)
floca added a comment to T29243: nnUNet in MITK: Downloading pre-trained models in Kaapana context.
In T29243#240152, @gaoh wrote:

What is the advantage of running nnunet in MITK in kaapana, over directly running nnunet in kaapana?

If you have a bunch of data, then the airflow workflow is the way to go.

Jul 22 2022, 2:15 PM · MITK (v2024.06), Kaapana (internal)
gaoh added a comment to T29243: nnUNet in MITK: Downloading pre-trained models in Kaapana context.

To point 1, in Kubernetes you can mount any path/volume to the desired mounting point. So I could just mount the directory in the MITK container in e.g. /models

Jul 22 2022, 1:49 PM · MITK (v2024.06), Kaapana (internal)
a178n triaged T29243: nnUNet in MITK: Downloading pre-trained models in Kaapana context as Low priority.
Jul 22 2022, 12:49 PM · MITK (v2024.06), Kaapana (internal)
a178n triaged T29242: Revamp nnUNet tool GUI as Low priority.
Jul 22 2022, 11:28 AM · MITK (v2024.06)
kislinsk updated the task description for T29241: Officially support Ubuntu 22.04 and dismiss Ubuntu 18.04.
Jul 22 2022, 10:41 AM · MITK (v2022.10)
kislinsk triaged T29241: Officially support Ubuntu 22.04 and dismiss Ubuntu 18.04 as Normal priority.
Jul 22 2022, 10:40 AM · MITK (v2022.10)
kislinsk updated subscribers of T29236: Check for prerequisites and give meaningful hints for missing packages.

I had a nice talk with @nolden about this topic and we concluded that dpkg is a good solution for checking for certain packages. The more I think about it, though, I think that we should stick at least partially to the file checking approach. The main reason is that we are not restricted to the Ubuntu package names or have to maintain additional alternatives. In particular, think of the OpenGL mess. Quite a few packages provide required header files and libraries, overriding each other. For example think of someone with proprietary nvidia dev packages who very likely does not want to be "forced" or wrongly advised to install overlapping mesa packages or similar.

Jul 22 2022, 10:31 AM · MITK (v2024.06)

Jul 21 2022

kalali added a revision to T29240: [mxn multi widget] Allow different time navigation controller for each individual render window: Unknown Object (Differential Revision).
Jul 21 2022, 5:30 PM · MITK (v2024.06)
kalali added a comment to T29240: [mxn multi widget] Allow different time navigation controller for each individual render window.

As a quick fix I added D692, but this just fixes a crash. It is not enough to have multiple time navigation controllers.

Jul 21 2022, 5:30 PM · MITK (v2024.06)
kalali moved T29240: [mxn multi widget] Allow different time navigation controller for each individual render window from Backlog to mxn MultiWidget on the MITK (v2022.10) board.
Jul 21 2022, 4:53 PM · MITK (v2024.06)
kalali triaged T29240: [mxn multi widget] Allow different time navigation controller for each individual render window as Normal priority.
Jul 21 2022, 4:52 PM · MITK (v2024.06)
a178n added a comment to T29238: Improve validation for Results_Folder structure.

Pushed new branch to rMITK MITK: feature/T29238-nnunet-improve-validation.

Jul 21 2022, 9:34 AM · MITK (v2022.10)

Jul 20 2022

kalali added a comment to T29234: Remove DisplayInteractor.

Some more references to mitkDisplayInteractor have already been removed in T27663 / D689.

Jul 20 2022, 11:58 AM · Breaking Change, MITK
kalali added a revision to T29234: Remove DisplayInteractor: Unknown Object (Differential Revision).
Jul 20 2022, 11:56 AM · Breaking Change, MITK
kahl added a comment to T27923: Integrate possibility to execute Python Code in MITK .

The feature/T27923-execute-python-code-in-mitk branch should be outdated as the last commit was in 2020. Everything from this work should be integrated in this commit where I pushed all the work from my bachelor thesis on the python-dev branch and based on this, implemented some more features.
The main problems of getting green builds were on the Ubuntu clients where some errors occurred during the build that we were not able to reproduce locally.

Jul 20 2022, 9:04 AM · MITK
kislinsk added a comment to T29236: Check for prerequisites and give meaningful hints for missing packages.

In Ubuntu 20.04+, system Qt can be used instead of the online installer, greatly reducing the hassle of creating a Qt account and so on:

Jul 20 2022, 8:53 AM · MITK (v2024.06)

Jul 19 2022

kalali added a revision to T27663: Crosshair navigation not disabled in QmitkMeasurementView : Unknown Object (Differential Revision).
Jul 19 2022, 7:53 PM · Breaking Change, MITK
kalali reopened T27663: Crosshair navigation not disabled in QmitkMeasurementView as "Open".

Just found this while working on T29234.
When @s434n and I were working on the interactions https://phabricator.mitk.org/D550?vs=on&id=2579 (and earlier the DisplayInteractor was replaced with DisplayInteractionEventBroadcast here https://phabricator.mitk.org/source/mitk/browse/develop/Modules/QtWidgets/src/QmitkAbstractMultiWidget.cpp$51-52) it seems as if this part of the code was forgotten.
The DisplayInteractor is not used anymore and that's why the retrieved object is a nullptr.

Jul 19 2022, 7:52 PM · Breaking Change, MITK
a178n triaged T29239: Download models to new Results_Folder as Normal priority.
Jul 19 2022, 11:41 AM · MITK (v2022.10)
a178n triaged T29238: Improve validation for Results_Folder structure as Normal priority.
Jul 19 2022, 10:02 AM · MITK (v2022.10)
a178n added a comment to T29187: Add GUI elements to parse and show available models.

Deleted branch from rMITK MITK: feature/T29187-nnunet-show-download-models.

Jul 19 2022, 9:41 AM · MITK (v2022.10)
a178n added a comment to T29202: Update doku for pretrained model download.

Deleted branch from rMITK MITK: feature/T29202-nnunet-download-model-doku.

Jul 19 2022, 9:39 AM · MITK (v2022.10)
a178n added a comment to T29224: nnUNet Bug: Confirm Segmentation button alway active.

Deleted branch from rMITK MITK: bugfix/T29224-confirmbutton-disable.

Jul 19 2022, 9:35 AM · MITK (v2022.10)

Jul 18 2022

kalali added a comment to T25043: Remove pixel informations from the statusbar and put it into views.

I connected this task with D686: Not all discussed points are handled here but I removed the UpdateStatusBar-functions completely and added a simple function to update the status bar info with the mouse pointer / world position and the global time dynamically.
More code changes will be uploaded to provide ideas on how to show image pixel information.

Jul 18 2022, 4:46 PM · Cleared, MITK
kalali added a revision to T25043: Remove pixel informations from the statusbar and put it into views: Unknown Object (Differential Revision).
Jul 18 2022, 4:45 PM · Cleared, MITK
kalali added a comment to T25105: UpdateStatusBar duplicates business logic.

In combination with the child task I added a first part of the tasks in D686.
The UpdateStatusBar-functions (and HandleCrosshairPositionEventDelayed-function) are completely removed and a simple function has been added to dynamically write the pointer position / world position and the global time to the status bar.

Jul 18 2022, 4:44 PM · MITK (v2022.10)
l597s added a member for Kaapana (internal): j870n.
Jul 18 2022, 3:42 PM
kalali updated the task description for T25105: UpdateStatusBar duplicates business logic.
Jul 18 2022, 3:25 PM · MITK (v2022.10)
kalali closed T29222: SlicesCoordinator is not implemented / used and can be removed as Resolved.
Jul 18 2022, 2:01 PM · Request for Discussion, MITK
kalali committed rMITK5df0f86e24f8: Remove unused SlicesCoordinator (authored by kalali).
Remove unused SlicesCoordinator
Jul 18 2022, 2:01 PM
kalali committed rMITKbc4507e0298c: Remove SlicesCoordinator-class from MITK (authored by kalali).
Remove SlicesCoordinator-class from MITK
Jul 18 2022, 2:00 PM
kalali added a comment to T26496: [mxn multi widget] Re-initializations reset all render windows.

I edited the task description since most of the issues do not occur anymore, due to the changed introduced by D523.
However, the general problem remains: It is not possible to re-initialize / reset the view and camera of individual render windows which is important for the MxNMultiWidget in order to fully unleash its potential.

Jul 18 2022, 11:43 AM · MITK (v2022.10), Restricted Project
floca added a comment to T29193: [SEG] Add a superpixel tool.

Do you see some (dis-)advantages in one option or the other?

Per se, no. Was only 2 thoughts:

  • I think it depends on the performance of the SLIC filter. If 3D has a good performance for the proposed interaction (see task description) I am fine.
  • I was not sure if people will realy use it in 3D, as the would have to constantly scroll through slices to ensure that the 3D superpixels are everywhere correct enough.
Jul 18 2022, 11:01 AM · MITK (v2024.06)
s349i added a comment to T29193: [SEG] Add a superpixel tool.

One thing to consider might be, is SLIC even useful? If neural networks are going to be taking care of segmentation anyway, what is it's likely sell-by date? This depends on how quickly NN based segmentation algorithms are incorporated into MITK.

Jul 18 2022, 11:01 AM · MITK (v2024.06)
kalali added a comment to T29193: [SEG] Add a superpixel tool.

So it should work for 2D and 3D.

Thanks for the input! My text was missleading. I meant, if we want only have a tool that works on 2D (e.g. in conjunction with interpolation) or also an tool where you can paint superpixels in 3D.

Jul 18 2022, 10:46 AM · MITK (v2024.06)
floca added a comment to T25043: Remove pixel informations from the statusbar and put it into views.
  1. Do we agree that there will be no position / pixel value information shown in the status bar?
    1. or are we only talking about the (maybe case-specific) pixel value information; meaning the position / index should still be shown in the status bar?
    2. if everything should be removed from the status bar, we wouldn't put any new functions in the "StatusBar"-class, right?

I would say A. So coordinate information is still visible.

Jul 18 2022, 10:26 AM · Cleared, MITK
kislinsk closed T29237: Typos in Wrapping as Resolved.
Jul 18 2022, 8:45 AM · Pull Request, MITK
kislinsk added a comment to T29237: Typos in Wrapping.

Deleted branch from rMITK MITK: bugfix/T29237-TyposInWrapping.

Jul 18 2022, 8:44 AM · Pull Request, MITK
kislinsk committed rMITK0eeedfcdf798: Merge remote-tracking branch 'luzpaz/typos' into bugfix/T29237-TyposInWrapping (authored by kislinsk).
Merge remote-tracking branch 'luzpaz/typos' into bugfix/T29237-TyposInWrapping
Jul 18 2022, 8:44 AM
luz paz <luzpaz@pm.me> committed rMITK32b1dfb0755e: Fixed additional typo (authored by luz paz <luzpaz@pm.me>).
Fixed additional typo
Jul 18 2022, 8:44 AM
luz paz <luzpaz@pm.me> committed rMITKd5ffc51159f6: Fix various typos in Wrapping/ (authored by luz paz <luzpaz@github.com>).
Fix various typos in Wrapping/
Jul 18 2022, 8:44 AM
kislinsk committed rMITK930010490781: Merge branch 'bugfix/T29237-TyposInWrapping' into develop (authored by kislinsk).
Merge branch 'bugfix/T29237-TyposInWrapping' into develop
Jul 18 2022, 8:44 AM
kislinsk added a comment to T29237: Typos in Wrapping.

Pushed new branch to rMITK MITK: bugfix/T29237-TyposInWrapping.

Jul 18 2022, 8:43 AM · Pull Request, MITK
kislinsk triaged T29237: Typos in Wrapping as Low priority.
Jul 18 2022, 8:41 AM · Pull Request, MITK

Jul 16 2022

floca added a comment to T27923: Integrate possibility to execute Python Code in MITK .

@kahl What is the status here? What is the differences between the two pushed branches? are they redundant or do they cover different aspects. I cannot find a documentation of there purpose.
What where the problems that hindered you to get green builds?

Jul 16 2022, 10:34 AM · MITK
floca added a revision to T27923: Integrate possibility to execute Python Code in MITK : Restricted Differential Revision.
Jul 16 2022, 10:31 AM · MITK
floca moved T29159: [Segmentation] Flow bench worklist feature from Segmentation to Cycle on the MITK (v2022.10) board.
Jul 16 2022, 10:21 AM · MITK (v2022.10)

Jul 15 2022

kislinsk added a comment to T29236: Check for prerequisites and give meaningful hints for missing packages.
NOTE: https://packages.ubuntu.com/ started to spit out a lot of Internal Server Errors. Will continue later with the table below...
Jul 15 2022, 8:23 AM · MITK (v2024.06)
kislinsk triaged T29236: Check for prerequisites and give meaningful hints for missing packages as Wishlist priority.
Jul 15 2022, 8:04 AM · MITK (v2024.06)
kislinsk closed T29235: Plugin manuals appear at top-level in documentation as Resolved.
Jul 15 2022, 7:49 AM · MITK
kislinsk added a comment to T29235: Plugin manuals appear at top-level in documentation.

Deleted branch from rMITK MITK: bugfix/T29235-PluginManualsOnTopLevel.

Jul 15 2022, 7:48 AM · MITK
kislinsk committed rMITKe123c0dc2a0a: Remove plugin manuals from top-level in documentation (authored by kislinsk).
Remove plugin manuals from top-level in documentation
Jul 15 2022, 7:48 AM
kislinsk committed rMITK1f15c4f718c3: Merge branch 'bugfix/T29235-PluginManualsOnTopLevel' into develop (authored by kislinsk).
Merge branch 'bugfix/T29235-PluginManualsOnTopLevel' into develop
Jul 15 2022, 7:48 AM
kislinsk added a comment to T29235: Plugin manuals appear at top-level in documentation.

Pushed new branch to rMITK MITK: bugfix/T29235-PluginManualsOnTopLevel.

Jul 15 2022, 7:47 AM · MITK
kislinsk triaged T29235: Plugin manuals appear at top-level in documentation as Normal priority.
Jul 15 2022, 7:45 AM · MITK

Jul 14 2022

kalali added a parent task for T29234: Remove DisplayInteractor: T19470: Cleanup DisplayInteractor.
Jul 14 2022, 7:19 PM · Breaking Change, MITK
kalali added a subtask for T19470: Cleanup DisplayInteractor: T29234: Remove DisplayInteractor.
Jul 14 2022, 7:19 PM · MITK (v2022.10), Bugzilla
kalali triaged T29234: Remove DisplayInteractor as Normal priority.
Jul 14 2022, 7:18 PM · Breaking Change, MITK
s349i added a comment to T29193: [SEG] Add a superpixel tool.

Ah OK. Thats a decision above my pay grade.

Jul 14 2022, 6:01 PM · MITK (v2024.06)
floca updated the task description for T29193: [SEG] Add a superpixel tool.
Jul 14 2022, 5:00 PM · MITK (v2024.06)
floca added a comment to T29193: [SEG] Add a superpixel tool.

So it should work for 2D and 3D.

Jul 14 2022, 4:58 PM · MITK (v2024.06)
s349i added a comment to T29193: [SEG] Add a superpixel tool.

only 2D are also 3D?

Jul 14 2022, 4:22 PM · MITK (v2024.06)
kalali attached a referenced file: F2552038: pic3d_indices.png.
Jul 14 2022, 3:58 PM · Request for Discussion, MITK
kalali attached a referenced file: F2552039: brain_indices.png.
Jul 14 2022, 3:57 PM · Request for Discussion, MITK
s349i added a revision to T29106: [Segmentation Options] "show only selected nodes" is not immediately applied: Unknown Object (Differential Revision).
Jul 14 2022, 3:18 PM · MITK (v2022.10), Checklist
holzwart added a member for IMSY: e278u.
Jul 14 2022, 12:06 PM
holzwart moved T29166: GSP: EndoCV detection challenge from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jul 14 2022, 10:30 AM · Restricted Project
a178n added a comment to T29227: Remove vestigial UI element "No. of extra Modalities" spinbox.

Pushed new branch to rMITK MITK: feature/T29227-modify-modal-label.

Jul 14 2022, 8:42 AM · MITK (v2022.10)

Jul 13 2022

kalali added a comment to T29220: StatusBar info is dependent on the pointer position, not on the crosshair / mouse click.

Additionally I found out that the order of the pixel-position and the index do not match, see screenshot (taken with MITK 2022.04 Release, using Pic3D and brain):

Jul 13 2022, 3:07 PM · Request for Discussion, MITK
a178n moved T29227: Remove vestigial UI element "No. of extra Modalities" spinbox from Backlog to Cycle on the MITK (v2022.10) board.
Jul 13 2022, 10:54 AM · MITK (v2022.10)
floca moved T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns from Backlog to Cycle on the MITK (v2022.10) board.
Jul 13 2022, 10:52 AM · MITK (v2023.04), Checklist
floca moved T29077: [Segmentation] Showing / hiding labels using the labelsetwidget selects them from Segmentation to Cycle on the MITK (v2022.10) board.
Jul 13 2022, 10:52 AM · MITK (v2023.04), Checklist
floca moved T28464: [Segmentation] New Add/Remove tool from Segmentation to Cycle on the MITK (v2022.10) board.
Jul 13 2022, 10:51 AM · MITK (v2022.10)
jack.sleuters created T29229: SetDataNode on SinglePointDataInteractor clears data in node.
Jul 13 2022, 10:28 AM · MITK
a178n closed T29224: nnUNet Bug: Confirm Segmentation button alway active as Resolved.
Jul 13 2022, 9:04 AM · MITK (v2022.10)

Jul 12 2022

a178n committed rMITKca199fb3c4ef: Bugfix: Confirm button will be deactived before Preview is pressed (authored by a178n).
Bugfix: Confirm button will be deactived before Preview is pressed
Jul 12 2022, 4:39 PM
a178n committed rMITK9fcceb3d8782: Update nnUnet intro text on tool UI (authored by a178n).
Update nnUnet intro text on tool UI
Jul 12 2022, 4:39 PM
a178n committed rMITK4959e656dc16: nnUNet tool Confirm button should be deactived before Preview is pressed… (authored by a178n).
nnUNet tool Confirm button should be deactived before Preview is pressed…
Jul 12 2022, 4:38 PM
a178n committed rMITKc014e532d34c: Minor code refactoring changes (authored by a178n).
Minor code refactoring changes
Jul 12 2022, 4:38 PM
s349i claimed T29106: [Segmentation Options] "show only selected nodes" is not immediately applied.
Jul 12 2022, 3:48 PM · MITK (v2022.10), Checklist
floca claimed T29206: [SEG] Implement a Qt model for LabelSets for MVC patterns.
Jul 12 2022, 3:35 PM · MITK (v2023.04), Checklist
floca claimed T29077: [Segmentation] Showing / hiding labels using the labelsetwidget selects them.
Jul 12 2022, 3:35 PM · MITK (v2023.04), Checklist