Page MenuHomePhabricator

MITK (v2022.10)Milestone
ArchivedPublic

Recent Activity

Mon, Apr 22

floca closed T28798: [Segmentation][MultiLabel][Utilities] UI is inconsistent / unstable, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Mon, Apr 22, 5:40 PM · MITK (v2022.10), Breaking Change

Fri, Apr 19

floca closed T28797: [Segmentation[MultiLabel][Utilities] Using 4D data with dynamic segmentations results in 3D data, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Fri, Apr 19, 9:29 AM · MITK (v2022.10), Breaking Change
floca closed T28264: [Segmentation Utilities] Various issues, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Fri, Apr 19, 9:01 AM · MITK (v2022.10), Breaking Change

Thu, Apr 18

floca closed T28525: Design refactoring of LabelSetImage and associated classes, a subtask of T28145: SetRegionTool does not work as expected (flood fill like) with concentric structures., as Resolved.
Thu, Apr 18, 4:37 PM · MITK (v2022.10)
floca closed T28500: Multilabel Segmentation Utilities do not work for multilabel segmentations, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Thu, Apr 18, 4:35 PM · MITK (v2022.10), Breaking Change

Mon, Apr 15

floca closed T28796: [Segmentation][Utilities] Morphological Operations behave unexpectedly, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Mon, Apr 15, 6:40 PM · MITK (v2022.10), Breaking Change

Tue, Apr 2

floca closed T27913: [Segmentation] Warnings in utilities view are inconsistent, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Tue, Apr 2, 7:04 PM · MITK (v2022.10), Breaking Change
floca added a comment to T27810: [Multilabel Segmentation] Inconsistencies and unclear functionality in operations of Utilities view.

Will be resolved/obsolete with current utilitie rework-

Tue, Apr 2, 7:04 PM · MITK (v2022.10), Cleared, Restricted Project
floca claimed T28134: [Multilabel Segmentation] No warning triggered when using different mask geometries / dimensions in Utilities View.
Tue, Apr 2, 7:01 PM · MITK (v2022.10), Cleared

Jul 14 2023

s434n closed T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Invalid.
Jul 14 2023, 3:43 PM · MITK (v2022.10), Breaking Change

Apr 11 2023

fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

@floca I think the issue is that it will probably be better to separately communicate server endpoint and refer to the Study/Series items in the DICOM model hierarchy via UIDs. I think adding support for DICOM should be done as part of the initial design, rather than and afterthought and replacement of file paths by URIs. But that only makes sense if DICOM is important and primary for the use case driving the development. That is why I suggest you guys proceed with your original plan, and we will try to experiment with the DICOM-centric design. But of course I may be wrong. I just think it is more expedient to experiment rather than coordinate the design at the same time as the use cases and requirements are evolving.

Apr 11 2023, 4:58 PM · MITK (v2022.10)
floca added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

I think at this point it probably makes sense for us to explore some dynamic JSON representation for defining the task that is geared towards using DICOM, and if/when it makes sense, we can sync up to exchange thoughts and consider harmonization. The statement of the problem is very dynamic, and it is probably too early to do such coordination now.

Apr 11 2023, 11:47 AM · MITK (v2022.10)

Apr 10 2023

fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

@kislinsk @floca thank you for the feedback!

Apr 10 2023, 11:53 PM · MITK (v2022.10)

Apr 4 2023

floca added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.
  • l think it will be important to make it possible to work with the inputs defined by DICOM UIDs and available through DICOM endpoints, instead of relying purely on file system. Would this be acceptable for your use cases?

We focused on local file paths so far indeed, driven by our requirements and Kaapana’s way of providing general resource access through local files. URIs are not off the table, though, as long as complexity lies within in the intentional KISS spirit of the file format.

I agree (to both ;). If we extend it (which makes mid term also sense for Kaapana) I would go for URIs and avoid any custom specification for different datasources and protocols. I think it is the minimal invasive and well standardized. DICOM could be covered the via DICOMWeb requests.

Apr 4 2023, 9:15 AM · MITK (v2022.10)
kislinsk updated subscribers of T29160: [Segmentation] Worklist specification, data structure and io functions.
  • l think it will be important to make it possible to work with the inputs defined by DICOM UIDs and available through DICOM endpoints, instead of relying purely on file system. Would this be acceptable for your use cases?
Apr 4 2023, 8:10 AM · MITK (v2022.10)

Apr 3 2023

fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

Thanks. Here are some more comments to start the discussion:

  • l think it will be important to make it possible to work with the inputs defined by DICOM UIDs and available through DICOM endpoints, instead of relying purely on file system. Would this be acceptable for your use cases?
  • In addition to segmentations, it would be helpful to include an option to perform the review of existing segmentations (e.g., those generated by AI that need to be QA'd by an expert, and where some kind of segmentation may or may not be generated as part of the QA process)
  • I think there is potentially common needs between this task and the "MetaDashboard" initiative in kaapana (see https://projectweek.na-mic.org/PW38_2023_GranCanaria/Projects/MetaDashboard/) - should these two efforts be coordinated? In that regard, the definition of the worklist does not need to be limited to support of the segmentation task (e.g., there are other tasks already considered in the context of the MetaDashboard, such as series type classification, presence of the artifacts.
Apr 3 2023, 6:23 PM · MITK (v2022.10)

Mar 30 2023

kislinsk updated the task description for T29160: [Segmentation] Worklist specification, data structure and io functions.
Mar 30 2023, 12:02 PM · MITK (v2022.10)
kislinsk added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

Did you consider using JSON Schema to formalize the definition? It is a bit hard to grasp it right now, but admittedly I probably didn't spend enough time looking over the various resources provided.

Mar 30 2023, 8:56 AM · MITK (v2022.10)
fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

Did you consider using JSON Schema to formalize the definition? It is a bit hard to grasp it right now, but admittedly I probably didn't spend enough time looking over the various resources provided.

Mar 30 2023, 4:29 AM · MITK (v2022.10)

Feb 7 2023

kislinsk added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

Hi spectators! 👋

Feb 7 2023, 1:27 PM · MITK (v2022.10)
kislinsk updated the task description for T29160: [Segmentation] Worklist specification, data structure and io functions.
Feb 7 2023, 1:17 PM · MITK (v2022.10)

Jan 17 2023

kislinsk archived MITK (v2022.10).
Jan 17 2023, 7:25 AM

Jan 10 2023

kalali closed T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Jan 10 2023, 2:57 PM · MITK (v2022.10), Breaking Change

Nov 24 2022

floca closed T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Nov 24 2022, 2:37 PM · MITK (v2022.10), Breaking Change

Nov 22 2022

kalali closed T29316: Rename QmitkSliderNavigatorWidget and clean variable names as Resolved.
Nov 22 2022, 3:41 PM · MITK (v2022.10)

Nov 9 2022

kalali closed T19284: Display Update with crosshair interaction (Scrolling/..) is inefficient as Resolved.

I looked into this and although I understand the problem, the issue does not really exist, as far as I can see:

  • changing the slice via scrolling will call SliceNavigationController::SelectSliceByPoint
  • calling SliceNavigationController::SelectSliceByPoint will call SliceNavigationController::SendCreatedWorldGeometryUpdate
  • calling SliceNavigationController::SendCreatedWorldGeometryUpdate will InvokeEvent(GeometryUpdateEvent(m_CreatedWorldGeometry, m_Slice->GetPos()))
  • invoking the event will lead to a call to BaseRenderer::UpdateGeometry

-> until here I agree with the task description

Nov 9 2022, 6:48 PM · MITK (v2022.10), Bugzilla

Nov 8 2022

s434n removed a project from T29098: [3D Segmentation] UL Threshold Tool - 0 intensity value not include in slider range?: Missing Info.

I just had another look at this. I was able to reproduce the bug this time. It seems that this problem only arises if the image holds floating point values, not when all values are integers.

Nov 8 2022, 6:05 PM · MITK (v2024.06), Restricted Project, Checklist
kalali updated the task description for T28989: [Segmentation] CanHandle functions seem to be inconsistent.
Nov 8 2022, 5:11 PM · MITK, Request for Discussion

Nov 7 2022

s434n added a revision to T29354: Double-clicking a label jumps to the label but not its centroid: Restricted Differential Revision.
Nov 7 2022, 3:44 PM · MITK (v2023.04)
kalali added a revision to T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module: Restricted Differential Revision.
Nov 7 2022, 2:01 PM · MITK (v2023.04)

Nov 3 2022

a178n added a comment to T29239: Download models to new Results_Folder.

Deleted branch from rMITK MITK: feature/T29239-nnunet-download-without-resultsfolder.

Nov 3 2022, 5:39 PM · MITK (v2022.10)
a178n added a comment to T29238: Improve validation for Results_Folder structure.

Deleted branch from rMITK MITK: feature/T29238-nnunet-improve-validation.

Nov 3 2022, 5:38 PM · MITK (v2022.10)
a178n added a comment to T29227: Remove vestigial UI element "No. of extra Modalities" spinbox.

Deleted branch from rMITK MITK: feature/T29227-modify-modal-label.

Nov 3 2022, 5:36 PM · MITK (v2022.10)
s434n claimed T29354: Double-clicking a label jumps to the label but not its centroid.
Nov 3 2022, 4:41 PM · MITK (v2023.04)
s434n closed T29286: Rework segmentation checklist for new live wire and lasso tool as Resolved.
Nov 3 2022, 12:13 PM · MITK (v2022.10)

Nov 2 2022

kalali closed T29367: [Segmentation] New render window specific reinit warning is confusing as Resolved.

The warning was reverted for the StdMultiWidget. More changes (problems were already mentioned here in this task) will be further implemented using T29335: [Segmentation] Show interactive warning for uninitialized render window geometry.

Nov 2 2022, 12:08 PM · MITK (v2022.10)
s434n closed T29344: Image Rendering - No difference between "Jet" and "Jet Transparent" as Resolved.
Nov 2 2022, 10:32 AM · Cleared, Checklist, MITK (v2022.10)

Oct 29 2022

kislinsk closed T29378: MITK v2022.10 as Resolved.
Oct 29 2022, 10:20 AM · MITK-ProjectTemplate, MITK (v2022.10)
kislinsk added a comment to T29378: MITK v2022.10.

Deleted branch from rMITK MITK: release/T29378-v2022.10.

Oct 29 2022, 10:19 AM · MITK-ProjectTemplate, MITK (v2022.10)
kislinsk added a comment to T29378: MITK v2022.10.

Pushed new branch to rMITK MITK: release/T29378-v2022.10.

Oct 29 2022, 12:45 AM · MITK-ProjectTemplate, MITK (v2022.10)
kislinsk triaged T29378: MITK v2022.10 as Normal priority.
Oct 29 2022, 12:23 AM · MITK-ProjectTemplate, MITK (v2022.10)

Oct 28 2022

kislinsk closed T29348: Improve Welcome page with basic navigation hints as Resolved.
Oct 28 2022, 10:08 AM · Cleared, Checklist, MITK (v2022.10)
kislinsk closed T29376: Make Welcome page tips optional as Resolved.
Oct 28 2022, 7:10 AM · MITK (v2022.10)
kislinsk added a comment to T29376: Make Welcome page tips optional.

Deleted branch from rMITK MITK: feature/T29376-MakeTipsOptional.

Oct 28 2022, 7:10 AM · MITK (v2022.10)
kislinsk added a comment to T29376: Make Welcome page tips optional.

Pushed new branch to rMITK MITK: feature/T29376-MakeTipsOptional.

Oct 28 2022, 7:09 AM · MITK (v2022.10)
kislinsk triaged T29376: Make Welcome page tips optional as Wishlist priority.
Oct 28 2022, 7:06 AM · MITK (v2022.10)

Oct 27 2022

kislinsk added a comment to T29348: Improve Welcome page with basic navigation hints.

Deleted branch from rMITK MITK: bugfix/T29348-ImproveWelcomePage.

Oct 27 2022, 5:02 PM · Cleared, Checklist, MITK (v2022.10)
kislinsk added a comment to T29348: Improve Welcome page with basic navigation hints.

Pushed new branch to rMITK MITK: bugfix/T29348-ImproveWelcomePage.

Oct 27 2022, 12:43 AM · Cleared, Checklist, MITK (v2022.10)

Oct 26 2022

kislinsk triaged T29375: Cursor offset in 2D tools with Qt 5.15 on macOS as Normal priority.

This bug is originating in Qt 5.15. It is reproducible but not really related to something in segmentation. It's just an obvious part of MITK to encounter the offset.

Oct 26 2022, 6:27 PM · MITK (v2023.04)
kislinsk renamed T29375: Cursor offset in 2D tools with Qt 5.15 on macOS from [Segmentation] Cursor offset in 2D tools to [Segmentation] Cursor offset in 2D tools with Qt 5.12 on macOS.
Oct 26 2022, 6:26 PM · MITK (v2023.04)