Page MenuHomePhabricator

MITK (v2022.10)Milestone
ArchivedPublic

Recent Activity

Thu, Mar 30

kislinsk updated the task description for T29160: [Segmentation] Worklist specification, data structure and io functions.
Thu, Mar 30, 12:02 PMMITK (v2022.10)
kislinsk added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

Did you consider using JSON Schema to formalize the definition? It is a bit hard to grasp it right now, but admittedly I probably didn't spend enough time looking over the various resources provided.

Thu, Mar 30, 8:56 AMMITK (v2022.10)
fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

Did you consider using JSON Schema to formalize the definition? It is a bit hard to grasp it right now, but admittedly I probably didn't spend enough time looking over the various resources provided.

Thu, Mar 30, 4:29 AMMITK (v2022.10)

Feb 7 2023

kislinsk added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

Hi spectators! 馃憢

Feb 7 2023, 1:27 PMMITK (v2022.10)
kislinsk updated the task description for T29160: [Segmentation] Worklist specification, data structure and io functions.
Feb 7 2023, 1:17 PMMITK (v2022.10)

Jan 17 2023

kislinsk archived MITK (v2022.10).
Jan 17 2023, 7:25 AM

Jan 10 2023

kalali closed T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Jan 10 2023, 2:57 PMMITK (v2022.10), Breaking Change

Nov 24 2022

floca closed T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations, a subtask of T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, as Resolved.
Nov 24 2022, 2:37 PMMITK (v2022.10), Breaking Change

Nov 22 2022

kalali closed T29316: Rename QmitkSliderNavigatorWidget and clean variable names as Resolved.
Nov 22 2022, 3:41 PMMITK (v2022.10)

Nov 9 2022

kalali closed T19284: Display Update with crosshair interaction (Scrolling/..) is inefficient as Resolved.

I looked into this and although I understand the problem, the issue does not really exist, as far as I can see:

  • changing the slice via scrolling will call SliceNavigationController::SelectSliceByPoint
  • calling SliceNavigationController::SelectSliceByPoint will call SliceNavigationController::SendCreatedWorldGeometryUpdate
  • calling SliceNavigationController::SendCreatedWorldGeometryUpdate will InvokeEvent(GeometryUpdateEvent(m_CreatedWorldGeometry, m_Slice->GetPos()))
  • invoking the event will lead to a call to BaseRenderer::UpdateGeometry

-> until here I agree with the task description

Nov 9 2022, 6:48 PMMITK (v2022.10), Bugzilla

Nov 8 2022

s434n removed a project from T29098: [3D Segmentation] UL Threshold Tool - 0 intensity value not include in slider range?: Missing Info.

I just had another look at this. I was able to reproduce the bug this time. It seems that this problem only arises if the image holds floating point values, not when all values are integers.

Nov 8 2022, 6:05 PMMITK (v2023.04), Checklist
kalali updated the task description for T28989: [Segmentation] CanHandle functions seem to be inconsistent.
Nov 8 2022, 5:11 PMMITK, Request for Discussion

Nov 7 2022

s434n added a revision to T29354: Double-clicking a label jumps to the label but not its centroid: Restricted Differential Revision.
Nov 7 2022, 3:44 PMMITK (v2023.04)
kalali added a revision to T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module: Restricted Differential Revision.
Nov 7 2022, 2:01 PMMITK (v2023.04)

Nov 3 2022

a178n added a comment to T29239: Download models to new Results_Folder.

Deleted branch from rMITK MITK: feature/T29239-nnunet-download-without-resultsfolder.

Nov 3 2022, 5:39 PMMITK (v2022.10)
a178n added a comment to T29238: Improve validation for Results_Folder structure.

Deleted branch from rMITK MITK: feature/T29238-nnunet-improve-validation.

Nov 3 2022, 5:38 PMMITK (v2022.10)
a178n added a comment to T29227: Remove vestigial UI element "No. of extra Modalities" spinbox.

Deleted branch from rMITK MITK: feature/T29227-modify-modal-label.

Nov 3 2022, 5:36 PMMITK (v2022.10)
s434n claimed T29354: Double-clicking a label jumps to the label but not its centroid.
Nov 3 2022, 4:41 PMMITK (v2023.04)
s434n closed T29286: Rework segmentation checklist for new live wire and lasso tool as Resolved.
Nov 3 2022, 12:13 PMMITK (v2022.10)

Nov 2 2022

kalali closed T29367: [Segmentation] New render window specific reinit warning is confusing as Resolved.

The warning was reverted for the StdMultiWidget. More changes (problems were already mentioned here in this task) will be further implemented using T29335: [Segmentation] Show interactive warning for uninitialized render window geometry.

Nov 2 2022, 12:08 PMMITK (v2022.10)
s434n closed T29344: Image Rendering - No difference between "Jet" and "Jet Transparent" as Resolved.
Nov 2 2022, 10:32 AMCleared, Checklist, MITK (v2022.10)

Oct 29 2022

kislinsk closed T29378: MITK v2022.10 as Resolved.
Oct 29 2022, 10:20 AMMITK-ProjectTemplate, MITK (v2022.10)
kislinsk added a comment to T29378: MITK v2022.10.

Deleted branch from rMITK MITK: release/T29378-v2022.10.

Oct 29 2022, 10:19 AMMITK-ProjectTemplate, MITK (v2022.10)
kislinsk added a comment to T29378: MITK v2022.10.

Pushed new branch to rMITK MITK: release/T29378-v2022.10.

Oct 29 2022, 12:45 AMMITK-ProjectTemplate, MITK (v2022.10)
kislinsk triaged T29378: MITK v2022.10 as Normal priority.
Oct 29 2022, 12:23 AMMITK-ProjectTemplate, MITK (v2022.10)

Oct 28 2022

kislinsk closed T29348: Improve Welcome page with basic navigation hints as Resolved.
Oct 28 2022, 10:08 AMCleared, Checklist, MITK (v2022.10)
kislinsk closed T29376: Make Welcome page tips optional as Resolved.
Oct 28 2022, 7:10 AMMITK (v2022.10)
kislinsk added a comment to T29376: Make Welcome page tips optional.

Deleted branch from rMITK MITK: feature/T29376-MakeTipsOptional.

Oct 28 2022, 7:10 AMMITK (v2022.10)
kislinsk added a comment to T29376: Make Welcome page tips optional.

Pushed new branch to rMITK MITK: feature/T29376-MakeTipsOptional.

Oct 28 2022, 7:09 AMMITK (v2022.10)
kislinsk triaged T29376: Make Welcome page tips optional as Wishlist priority.
Oct 28 2022, 7:06 AMMITK (v2022.10)

Oct 27 2022

kislinsk added a comment to T29348: Improve Welcome page with basic navigation hints.

Deleted branch from rMITK MITK: bugfix/T29348-ImproveWelcomePage.

Oct 27 2022, 5:02 PMCleared, Checklist, MITK (v2022.10)
kislinsk added a comment to T29348: Improve Welcome page with basic navigation hints.

Pushed new branch to rMITK MITK: bugfix/T29348-ImproveWelcomePage.

Oct 27 2022, 12:43 AMCleared, Checklist, MITK (v2022.10)

Oct 26 2022

kislinsk triaged T29375: Cursor offset in 2D tools with Qt 5.15 on macOS as Normal priority.

This bug is originating in Qt 5.15. It is reproducible but not really related to something in segmentation. It's just an obvious part of MITK to encounter the offset.

Oct 26 2022, 6:27 PMMITK
kislinsk renamed T29375: Cursor offset in 2D tools with Qt 5.15 on macOS from [Segmentation] Cursor offset in 2D tools to [Segmentation] Cursor offset in 2D tools with Qt 5.12 on macOS.
Oct 26 2022, 6:26 PMMITK
a178n added a comment to T29375: Cursor offset in 2D tools with Qt 5.15 on macOS.

Ya, I tried. Both before and after annotation. Changes nothing. Bug exists.

Oct 26 2022, 3:02 PMMITK
kalali added a comment to T29375: Cursor offset in 2D tools with Qt 5.15 on macOS.

Could you explicitly "reinit" the reference node and see if that changes anything?

Oct 26 2022, 2:58 PMMITK
a178n updated the task description for T29375: Cursor offset in 2D tools with Qt 5.15 on macOS.
Oct 26 2022, 2:56 PMMITK
a178n added a comment to T29375: Cursor offset in 2D tools with Qt 5.15 on macOS.

Bug likely to be caused by Qt 5.15 in my local.
This may not affect this release build since official release builds use Qt 5.12.

Oct 26 2022, 2:55 PMMITK
a178n created T29375: Cursor offset in 2D tools with Qt 5.15 on macOS.
Oct 26 2022, 2:52 PMMITK
floca moved T29204: [SEG] Rework properties of Label class + add instance information from Backlog to MITK Meeting on the Request for Discussion board.
Oct 26 2022, 2:45 PMMITK (v2023.04), Breaking Change
floca added a project to T29204: [SEG] Rework properties of Label class + add instance information: Request for Discussion.
Oct 26 2022, 2:45 PMMITK (v2023.04), Breaking Change
floca closed T28767: 2D (multi-label) segmentation tools -> paint/wipe unusable for larger images as Resolved.

Reworked the tools to make them faster.
Close ticket for now. If It is not fast enough we need to make more rework and need to make a in depth profiling where we loose the time.

Oct 26 2022, 2:42 PMRequest for Discussion, MITK (v2022.10), Checklist
floca closed T28767: 2D (multi-label) segmentation tools -> paint/wipe unusable for larger images, a subtask of T28479: [Segmentation] Rethink / reevaluate our existing segmentation tools / algorithms, as Resolved.
Oct 26 2022, 2:42 PMMITK (v2023.04)
floca closed T29359: Segmentation Free Testing Checklist - Paint and Wipe Tool are buggy when Cntrl is pressed. as Resolved by committing rMITKa7abbf5b15a0: Fixed inversion feature. Visual representation is correctly showing the mode鈥.
Oct 26 2022, 2:19 PMChecklist, MITK (v2022.10)
kislinsk assigned T29367: [Segmentation] New render window specific reinit warning is confusing to kalali.
Oct 26 2022, 10:29 AMMITK (v2022.10)

Oct 25 2022

kislinsk closed T29372: Optionally skip finished segmentation tasks as Resolved.

I implemented the feature based on the shift key:

  • Press Shift while clicking on the Previous/Next Task buttons to skip finished tasks
  • Use Control + Shift + P/N shortcuts instead of Control + Alt + P/N shortcuts for the same behavior
Oct 25 2022, 10:09 PMMITK (v2022.10)
kislinsk closed T29372: Optionally skip finished segmentation tasks, a subtask of T29157: NCT ISSO Annotation Support with MITK Segmentation Flow, as Resolved.
Oct 25 2022, 10:09 PMMITK (v2023.04)
kislinsk added a comment to T29372: Optionally skip finished segmentation tasks.

Deleted branch from rMITK MITK: feature/T29372-OptionallySkipDoneTasks.

Oct 25 2022, 10:06 PMMITK (v2022.10)
kislinsk added a comment to T29372: Optionally skip finished segmentation tasks.

Pushed new branch to rMITK MITK: feature/T29372-OptionallySkipDoneTasks.

Oct 25 2022, 10:05 PMMITK (v2022.10)
floca added a comment to T29367: [Segmentation] New render window specific reinit warning is confusing.

There are valid points. We should not confuse the user.
Correctly done, I think the new overlay style is the way to go. Besides optimized/userfriendly text (+making the overlay blocky), we could also directly add icon and btns at the overlay to allow reinit of the render window or all render windows. I think from a UX perspective it would be a huge improvment compared to all other versions.

Oct 25 2022, 6:43 PMMITK (v2022.10)