Page MenuHomePhabricator

MITKProject
ActivePublic

Recent Activity

Today

s434n claimed T28492: Renderer interaction hangs in PACS mode when using keyboard modifiers.

The cause for this problem lies in missing state-transitions of the interaction state-machine. DisplayConfigPACS.xml defines the events based on which the state-machine in DisplayInteraction.xml acts. For modifier-based interactions, a MousePressEvent / MouseReleaseEvent in combination with a modifier-key are responsible to transition into / out of the corresponding state ("move", "zoom", ...). When the modifier-key is released BEFORE releasing the mouse button, the second event is never triggered, causing the state machine to get stuck in that specific state, which blocks most other interactions.

Mon, Aug 2, 1:46 PM · MITK

Fri, Jul 30

monishsinthala created T28652: Dedicated Full Stack PHP Programmers in India.
Fri, Jul 30, 1:41 PM · MITK

Tue, Jul 27

floca closed T27571: Multilabel segmentation does not work with US DICOM images, a subtask of T27554: Handling of 2D and 2D+t sonographic (US) images, as Invalid.
Tue, Jul 27, 9:59 AM · Restricted Project, MITK

Tue, Jul 20

kalali closed T23751: Introduction of new selection concept, a subtask of T23721: Project "Astonishing Angelfish", as Resolved.
Tue, Jul 20, 2:12 PM · MITK
kalali closed T23751: Introduction of new selection concept as Resolved.
Tue, Jul 20, 2:12 PM · Noteworthy, MITK
kalali removed a subtask for T23751: Introduction of new selection concept: T24738: [Selection concept] Thumbnail preview of images for datastorage inspectors.
Tue, Jul 20, 2:10 PM · Noteworthy, MITK
kalali updated the task description for T23751: Introduction of new selection concept.
Tue, Jul 20, 2:10 PM · Noteworthy, MITK
kalali renamed T23837: [Selection concept] Add "context"/scope to data node selection for selection service from Add "context"/scope to data node selection for selection service to [Selection concept] Add "context"/scope to data node selection for selection service.
Tue, Jul 20, 2:10 PM · MITK
kalali removed a subtask for T23751: Introduction of new selection concept: T23837: [Selection concept] Add "context"/scope to data node selection for selection service.
Tue, Jul 20, 2:10 PM · Noteworthy, MITK
kalali removed a parent task for T23837: [Selection concept] Add "context"/scope to data node selection for selection service: T23751: Introduction of new selection concept.
Tue, Jul 20, 2:10 PM · MITK
kalali removed a subtask for T23751: Introduction of new selection concept: T25804: [Selection concept] Set 'selected' property when using the new selection concept.
Tue, Jul 20, 2:09 PM · Noteworthy, MITK

Thu, Jul 15

s434n triaged T28630: [Segmentation] Deactivating tool resets interactions to earlier state as Low priority.
Thu, Jul 15, 4:59 PM · MITK

Fri, Jul 9

Lafebre edited projects for T28616: Allow fixed-size point set markers in VTK mapper, added: MITK; removed MITK (v2021.10).

Thanks for your reply!

Fri, Jul 9, 10:20 AM · Pull Request, MITK (v2021.10)

Thu, Jul 8

Lafebre added a project to T28616: Allow fixed-size point set markers in VTK mapper: MITK.
Thu, Jul 8, 11:04 PM · Pull Request, MITK (v2021.10)

Wed, Jul 7

kalali claimed T26496: [mxn multi widget] Re-initializations reset all render windows.
Wed, Jul 7, 10:53 AM · Restricted Project, MITK
kalali raised the priority of T27613: Improve reinit behavior from Wishlist to Normal.
Wed, Jul 7, 10:29 AM · MITK (v2021.10)
kalali reopened Restricted Maniphest Task, a subtask of T25056: Refactor data manager context menu, as Open.
Wed, Jul 7, 9:53 AM · Noteworthy, MITK

Tue, Jul 6

kalali added a comment to T27613: Improve reinit behavior.

My conclusion / suggestion so far:

  1. RenderingManager::RequestUpdate*-functions add render windows to a list of render windows to be re-rendered, where re-rendering means updating the graphics / pixel (OpenGL)
  2. RendereringManager::InitializeView*-functions (changed to RenderWindowManager::InitializeView* in D517) update the Time- / Slice-Navigation controller and the camera controller to a specific view ("field of view").
Tue, Jul 6, 5:32 PM · MITK (v2021.10)
kleina added a comment to T28406: [Segmentation] Examine Live-wire tool for different costfunctions/behavior.

This is related to T28464.

Tue, Jul 6, 1:16 PM · MITK
kalali updated the task description for T26496: [mxn multi widget] Re-initializations reset all render windows.
Tue, Jul 6, 11:44 AM · Restricted Project, MITK

Mon, Jul 5

kalali added a revision to T27613: Improve reinit behavior: Restricted Differential Revision.
Mon, Jul 5, 6:05 PM · MITK (v2021.10)
kalali added a revision to T26496: [mxn multi widget] Re-initializations reset all render windows: Restricted Differential Revision.
Mon, Jul 5, 6:05 PM · Restricted Project, MITK

Jul 2 2021

kalali added a comment to T28603: Cannot start MITK on a Windows remote desktop.

I know that there is a problem with Windows / OpenGL using MITK remotely. I just had never seen this particular error-message given in the description. I will ask about the latest release and an updated driver, thanks!

Jul 2 2021, 3:55 PM · Missing Info, MITK
floca added a project to T28603: Cannot start MITK on a Windows remote desktop: Missing Info.
  • Does the problem also occure with the current release?
  • It is a known problem that Windows (OpenGL problem) does not work (well) remote with MITK. The best way is installing the right drivers (see https://phabricator.mitk.org/T26427#224676)
Jul 2 2021, 3:48 PM · Missing Info, MITK
kalali added a comment to T26496: [mxn multi widget] Re-initializations reset all render windows.

The point is: I'm removing the InitializeView*-functions from the RenderingManager to separate the repsonsibilities. For these functions to work I now want to pass the RenderingManager as an argument - but this is not working with an IRenderingManager, which I get returned by the mentioned classes.

Jul 2 2021, 3:20 PM · Restricted Project, MITK
floca updated subscribers of T26496: [mxn multi widget] Re-initializations reset all render windows.

I cannot answer that question directly. As I do not know the history of this class and documentation does not help. Maybe @nolden does.

Jul 2 2021, 3:02 PM · Restricted Project, MITK
kalali updated subscribers of T26496: [mxn multi widget] Re-initializations reset all render windows.

I changed all occurrences of the InitializeView*-functions and built different MITK configurations to be sure not to miss anything.

Jul 2 2021, 1:20 PM · Restricted Project, MITK
kalali triaged T28603: Cannot start MITK on a Windows remote desktop as Normal priority.
Jul 2 2021, 12:10 PM · Missing Info, MITK
kislinsk closed T28602: 2021 Week 26 (Very Early July) as Resolved.
Jul 2 2021, 10:50 AM · MITK
kislinsk edited the content of Changelog.
Jul 2 2021, 10:49 AM · MITK
kislinsk added a comment to T28602: 2021 Week 26 (Very Early July).

Deleted branch from rMITK MITK: release/T28602-2021-Week-26.

Jul 2 2021, 10:45 AM · MITK
kislinsk added a comment to T28602: 2021 Week 26 (Very Early July).

Pushed new branch to rMITK MITK: release/T28602-2021-Week-26.

Jul 2 2021, 9:42 AM · MITK
kislinsk triaged T28602: 2021 Week 26 (Very Early July) as Normal priority.
Jul 2 2021, 9:40 AM · MITK
kislinsk created T28602: 2021 Week 26 (Very Early July).
Jul 2 2021, 9:40 AM · MITK

Jun 29 2021

kalali added a comment to T26496: [mxn multi widget] Re-initializations reset all render windows.

All InitializeView*-functions do not need anything from the RenderingManager except for the list / vector of render windows and the time navigation controller - both can be retrieved via public functions. I started separating the rendering functions from the view resetting functions to have two distinct classes with clearer responsibilities.

Jun 29 2021, 5:20 PM · Restricted Project, MITK

Jun 28 2021

kalali added a comment to T26496: [mxn multi widget] Re-initializations reset all render windows.

It is important to understand the differences between the following functions:

  • RenderingManager::RequestUpdateAll
    • basically goes through all the registered render windows and calls RenderingManager::RequestUpdate on each one
  • RenderingManager::RequestUpdate
    • sets the status of the given render window to "RENDERING_REQUESTED" and generates a rendering request event
    • QmitkRenderingManager::GenerateRenderingRequestEvent
      • this is an implementation of the abstract function which simply adds a QmitkRenderingRequestEvent to Qt's post event queue. If the event queue is processed and a QmitkRenderingRequestEvent::RenderingRequest is detected, RenderingManager::ExecutePendingRequests is called
    • RenderingManager::ExecutePendingRequests
      • goes through all the registered render windows and calls RenderingManager::ForceImmediateUpdate on each one that has the status "RENDERING_REQUESTED" set
    • RenderingManager::ForceImmediateUpdate
      • here the actual rendering is initiated by calling vtkWindow::Render on a given render window
Jun 28 2021, 1:45 PM · Restricted Project, MITK
kalali updated the task description for T26496: [mxn multi widget] Re-initializations reset all render windows.
Jun 28 2021, 1:41 PM · Restricted Project, MITK
kalali added a comment to T27613: Improve reinit behavior.

For a more thorough investigation of possible side-effects I will list the occurrences of similar code and see if the mentioned solution could be applied there.
I already started doing that some time ago in T26496: [mxn multi widget] Re-initializations reset all render windows and will continue there:

In T26496, @kalali wrote:

I propose to first gather different actions which lead to an update request.

Jun 28 2021, 10:23 AM · MITK (v2021.10)

Jun 25 2021

kalali updated subscribers of T27613: Improve reinit behavior.

Just for testing purposes: I created an additional Enum value to mitk::RenderingManager::RequestType, called NO_UPDATE. I'm using this new value inside QmitkSegmentationView::CreateNewSegmentation, for the call mitk::RenderingManager::GetInstance()->InitializeViews(referenceImage->GetTimeGeometry(), mitk::RenderingManager::NO_UPDATE, true);.

Jun 25 2021, 4:18 PM · MITK (v2021.10)
kalali added a comment to T26496: [mxn multi widget] Re-initializations reset all render windows.

Task for a long-term solution: T27613: Improve reinit behavior

Jun 25 2021, 9:09 AM · Restricted Project, MITK

Jun 23 2021

kalali added a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T26492: [mxn multi widget] Send active render window.
Jun 23 2021, 11:47 AM · MITK
kalali added a parent task for T26492: [mxn multi widget] Send active render window: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Jun 23 2021, 11:47 AM · MITK
kalali removed a project from T26492: [mxn multi widget] Send active render window: Restricted Project.
Jun 23 2021, 11:47 AM · MITK
kalali reopened T26492: [mxn multi widget] Send active render window as "Open".

The active render window can be selected using the render window manager but it is not possible to do it the other way around - clicking inside a render window does not activate this render window.

Jun 23 2021, 11:47 AM · MITK
kalali added a comment to T24672: Create decoration manager for render windows widgets.

I just tested the latest mxn multi widget on develop and now the render window menu icons have a thick border around them - which does not look nice. Need to find out how this happened.

Jun 23 2021, 11:42 AM · Restricted Project, MITK
kalali added a comment to T26394: [Render window manager] Provide tree view / model.

If I remember correctly I created a new renderwindowtreemodel, based on QmitkAbstractDataStorageModel because I could not reuse the classic tree inspector. Reason for this was probably mainly the different handling of data nodes for specific render windows. I will re-recheck this within the next weeks and probably come back to you for consultation ;)

Jun 23 2021, 9:19 AM · Restricted Project, Restricted Project, MITK

Jun 22 2021

floca added a comment to T26394: [Render window manager] Provide tree view / model.

This is then based on the QmitkDataStorageTreeInspector? Would make sense, wouldn't it?

Jun 22 2021, 2:03 PM · Restricted Project, Restricted Project, MITK
kalali updated the task description for T28578: [mxn multi widget] Optimization of the mxn multi widget.
Jun 22 2021, 1:16 PM · MITK
kalali updated the task description for T28578: [mxn multi widget] Optimization of the mxn multi widget.
Jun 22 2021, 1:15 PM · MITK
kalali added a parent task for T26555: [mxn multi widget] Provide different default layouts: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Jun 22 2021, 1:05 PM · MITK