Page MenuHomePhabricator

MITK (2020)Milestone
ActivePublic

Recent Activity

Yesterday

floca added a revision to T27553: Crash in DICOMReaderServiceActivator due to uninitialized module "DICOMReader": Restricted Differential Revision.
Mon, Jul 13, 5:51 PM · MITK (2020)
kalali triaged T27556: Refactor VolumeVisualization plugin to use the new node selection widgets as High priority.
Mon, Jul 13, 2:44 PM · MITK (2020)
floca edited projects for T27553: Crash in DICOMReaderServiceActivator due to uninitialized module "DICOMReader", added: MITK (2020); removed MITK.
Mon, Jul 13, 9:54 AM · MITK (2020)

Sat, Jul 11

thomass added a comment to T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data .

I totally forgot to claim the task but I also worked on it *sigh*. Your fix in D346 solves the problem, but I wondered if function initialize() should really be called if the activated() has not been called yet. An alternative would be to have an additional flag "m_activated" or likewise.

Sat, Jul 11, 10:10 AM · MITK (2020)

Fri, Jul 10

floca closed T27493: Rework QmitkContourModelToImageWidget to be time point aware as Resolved.
Fri, Jul 10, 7:46 PM · MITK (2020)
floca claimed T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data .
Fri, Jul 10, 7:38 PM · MITK (2020)
floca closed T27462: Workbench crashes when loading multiple 3D+t datasets as Resolved by committing rMITKec3d838b1ed3: Fix for the crash caused by invalid prop assembly state due to early out..
Fri, Jul 10, 7:29 PM · MITK (2020)
floca added a comment to T27546: [Segmentation] Crash in Add Tool when using 4D images and static segmentations.

Is also fixed by D345

Fri, Jul 10, 5:53 PM · MITK (2020)
floca merged task T27546: [Segmentation] Crash in Add Tool when using 4D images and static segmentations into T27462: Workbench crashes when loading multiple 3D+t datasets.
Fri, Jul 10, 5:53 PM · MITK (2020)
floca merged T27546: [Segmentation] Crash in Add Tool when using 4D images and static segmentations into T27462: Workbench crashes when loading multiple 3D+t datasets.
Fri, Jul 10, 5:53 PM · MITK (2020)
floca claimed T27462: Workbench crashes when loading multiple 3D+t datasets.
Fri, Jul 10, 5:52 PM · MITK (2020)
floca closed T24767: Workbench crashes when loading two 3D+t images with different number of time steps as Resolved.

Although the task was closed I can still reproduce the error:

  1. Load 3d+t Heart
  2. Change timestep
  3. Load US4DCyl
  4. ----> CRASH from vtkOpenGLPolyDataMapper
Fri, Jul 10, 5:43 PM · MITK (2020)
floca added a comment to T25098: Mapper (partially?) do not handle images correctly if they are out of time bound.

T27462 covers this task alreadey for ImageVtkMapper2D and PlaneGeometryDataVtkMapper3D.
Other mappers have still to be checked.

Fri, Jul 10, 4:56 PM · MITK (2020)
floca added a revision to T27462: Workbench crashes when loading multiple 3D+t datasets: Restricted Differential Revision.
Fri, Jul 10, 4:54 PM · MITK (2020)
kalali added a comment to T27100: [MITKDoc] Revise DataManager Plugin Documentation.

Pushed new branch T27100-Develop-integration.

Fri, Jul 10, 9:50 AM · Cleared, MITK (2020)
floca added a revision to T27549: Workbench IntroPart is hidden behind editor: Restricted Differential Revision.
Fri, Jul 10, 8:59 AM · MITK (2020)
floca added a comment to T27549: Workbench IntroPart is hidden behind editor.

I am not sure if I find the reason/solution. But at least it seems to be a sensible work arround.

Fri, Jul 10, 8:55 AM · MITK (2020)
floca triaged T27549: Workbench IntroPart is hidden behind editor as Normal priority.
Fri, Jul 10, 8:48 AM · MITK (2020)

Thu, Jul 9

thomass added a comment to T27546: [Segmentation] Crash in Add Tool when using 4D images and static segmentations.

Substract Tool also crashes, Paint, Wipe and Correction works

Thu, Jul 9, 4:51 PM · MITK (2020)
thomass moved T27546: [Segmentation] Crash in Add Tool when using 4D images and static segmentations from Backlog to Segmentation on the MITK (2020) board.
Thu, Jul 9, 4:39 PM · MITK (2020)
thomass triaged T27546: [Segmentation] Crash in Add Tool when using 4D images and static segmentations as High priority.
Thu, Jul 9, 4:39 PM · MITK (2020)
thomass added a comment to T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data .

If timestep != 0, the m_CurrentTimeStep is changed with SetCurrentTimeStep(t). In this function Initalize() is called without the m_SmoothFilter initialized before. m_SmoothFilter equals nullptr.

Thu, Jul 9, 3:28 PM · MITK (2020)
thomass moved T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data from Backlog to Segmentation on the MITK (2020) board.
Thu, Jul 9, 3:10 PM · MITK (2020)
thomass triaged T27543: [Segmentation] Crash on FastMarching3D tool when loading 4D data as High priority.
Thu, Jul 9, 3:10 PM · MITK (2020)
thomass added a comment to T27462: Workbench crashes when loading multiple 3D+t datasets.

Probably a similar to T24767 (sorry for re-opening but maybe the infromation from that one helps to narrow it down).
I acutally produced the crash even if the timesteps where valid in both images (contrary to the description).

Thu, Jul 9, 2:24 PM · MITK (2020)
thomass edited projects for T24767: Workbench crashes when loading two 3D+t images with different number of time steps, added: MITK (2020); removed MITK.
Thu, Jul 9, 2:19 PM · MITK (2020)
kalali moved T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images from Backlog to MITK Meeting on the Request for Discussion board.
Thu, Jul 9, 11:22 AM · Request for Discussion, Missing Info, MITK (2020)
kalali updated subscribers of T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images.

The problem of different class types / image types is also the source for the bug mentioned in T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image.
@floca mentioned to completely remove the autocrop-action from the context menu (at least for the multilabel segmentation) because it is not clear what to expect. Multilabel segmentations offer different possibilities for cropping and this could be handled inside the multilabel segmentation view.
That's also an option I see for the issue mentioned in 2.

Thu, Jul 9, 11:21 AM · Request for Discussion, Missing Info, MITK (2020)
kalali added a project to T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images: Request for Discussion.

@kahl I can confirm your workflow for the ITK NrrdImageIO reader.
@kislinsk I can also confirm that autocrop does not alter the name if used on a binary segmentation.

Thu, Jul 9, 11:14 AM · Request for Discussion, Missing Info, MITK (2020)

Wed, Jul 8

floca added a revision to T27442: PlanarFigure uses unmanged/uncontrolled pointer for PlaneGeometry: Restricted Differential Revision.
Wed, Jul 8, 1:07 PM · Cleared, MITK (2020)
floca claimed T27442: PlanarFigure uses unmanged/uncontrolled pointer for PlaneGeometry.
Wed, Jul 8, 12:37 PM · Cleared, MITK (2020)
kalali added a comment to T26973: [Segmentation] RegionGrowing3D preview only in 3D Widget.

Best bug!

Wed, Jul 8, 12:30 PM · MITK (2020)
kalali added a comment to T15551: Tutorial Step 6: region growing does not display results.

I tested Tutorial Step 6 with Windows (presumably what the OP used) and Pic3D (see task description: C:\ws\MITK\bin\CMakeExternals\Source\MITK-Data\Pic3D.nrrd).
Depending on the threshold values I used I was either able to get a segmentation mask or the UI froze for a short time and nothing happened.
However, I did not receive any log output related to GPU, OpenGL or the like.

Wed, Jul 8, 12:23 PM · MITK (2020), Missing Info, Bugzilla
thomass added a comment to T26973: [Segmentation] RegionGrowing3D preview only in 3D Widget.

On the develop (neither debug nor release) I also cannot reproduce the bug, so I think we can close it for now.

Wed, Jul 8, 11:48 AM · MITK (2020)
kalali removed a project from T26973: [Segmentation] RegionGrowing3D preview only in 3D Widget: Missing Info.
Wed, Jul 8, 11:46 AM · MITK (2020)
kahl added a comment to T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images.

@kalali I can confirm that there is no option to use autocrop when using the ITK NrrdImageIO reader. However, when you load an image with the ITK reader (I used MultiLabel/Pic3DAsMultilabelImage.nrrd as well) and you convert it to a segmentation
(Right click ->Convert to segmentation) and then autocrop the new segmentation node, the name also changes to "No Name". So it might be a general problem when autocropping.

Wed, Jul 8, 11:45 AM · Request for Discussion, Missing Info, MITK (2020)
kahl closed T26973: [Segmentation] RegionGrowing3D preview only in 3D Widget as Resolved.

As the bug couldn't be reproduced, it can be closed.

Wed, Jul 8, 11:39 AM · MITK (2020)
nolden added a comment to T27085: 2D region growing tool fails for low intensity regions.

soon'ish == 2 weeks ;)

Wed, Jul 8, 11:04 AM · Cleared, MITK (2020)
nolden added a comment to T27085: 2D region growing tool fails for low intensity regions.

@norajitr We discussed this today in the MITK 2020 meeting and it stays on the high priority list, no promises regarding a date for a fix but at least some investigation of the underlying cause should happen soon'ish

Wed, Jul 8, 11:02 AM · Cleared, MITK (2020)
floca moved T27379: Set up Ubuntu 20.04 CI clients from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Jul 8, 10:55 AM · Cleared, Restricted Project, MITK (2020)
floca moved T27483: DICOM import of multi-channel data not working from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Jul 8, 10:55 AM · MITK (2020), Restricted Project, DICOM
thomass closed T26974: [Segmentation] Region Growing 3D with 4D dataset not working as Resolved.
Wed, Jul 8, 10:29 AM · MITK (2020)
kislinsk raised the priority of T27534: Generate batch file for PluginGenerator from Low to Normal.
Wed, Jul 8, 9:56 AM · MITK (2020)

Mon, Jul 6

kleina added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

It was a clean build with MITK_BUILD_CONFIGURATION = WorkbenchRelease. I also enabled XNAT and only build "release". But I think that's all.

Mon, Jul 6, 5:15 PM · Missing Info, MITK (2020)
floca added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

Which configuration did you used to build it? Was it a clean build?

Mon, Jul 6, 4:45 PM · Missing Info, MITK (2020)
floca closed T27483: DICOM import of multi-channel data not working as Resolved.
Mon, Jul 6, 2:44 PM · MITK (2020), Restricted Project, DICOM
kleina added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

With the installer you send me it worked :-(
I fetched and pulled develop this morning. What else should I try to narrow it down?

Mon, Jul 6, 12:54 PM · Missing Info, MITK (2020)
floca added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

What about the Segmentations? I was wrong, I tried with the current develop as well (sorry, was used to having the master branch on clone :-D).
I had Hanno also try it and the segmentations are missing for him as well.
I put an installer into the same folder, you can just start it from the bin folder to reproduce.

Mon, Jul 6, 12:02 PM · Missing Info, MITK (2020)
kleina added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

This is the error message, that was not there with the old installer:

Mon, Jul 6, 10:17 AM · Missing Info, MITK (2020)
kleina added a comment to T27525: Problems while opening MITK scenes created with 2018.04 release with the current master.

What about the Segmentations? I was wrong, I tried with the current develop as well (sorry, was used to having the master branch on clone :-D).
I had Hanno also try it and the segmentations are missing for him as well.
I put an installer into the same folder, you can just start it from the bin folder to reproduce.

Mon, Jul 6, 10:11 AM · Missing Info, MITK (2020)