• mitk_create_module() passes PACKAGE_DEPENDS to _mitk_parse_package_args()
  • The PACKAGE[|COMPONENT1[+COMPONENT2]...] syntax is processed and the following variables are set in parent scope:
    • <PUBLIC|PRIVATE|INTERFACE>_PACKAGE_NAMES: Lists of package names for different visibilities
    • PACKAGE_NAMES: Joined lists from above (may contain duplicates!)
    • <PUBLIC|PRIVATE|INTERFACE>_<PACKAGE>_REQUIRED_COMPONENTS: Lists of components for different visibilities and packages
• mitk_create_module() passes PACKAGE_NAMES to mitk_check_module_dependencies()
  • mitk_check_module_dependencies() passes PACKAGE_NAMES to _mitk_parse_package_args()
    • Notice that PACKAGE_NAMES does not contain visibilities anymore, so everything is put into PRIVATE_PACKAGE_NAMES by default
  • Nevertheless, all visibility lists are joined into package_names and duplicates are removed (why not just use PACKAGE_NAMES in the first place and remove duplicates?)
  • For each package, check if MITK_USE_<package> is not set and add package to _MISSING_DEP in parent scope together with missing modules
• Also: Duplicates in PACKAGE_NAMES were removed by mitk_check_module_dependencies()
• The module is disabled if there are any missing dependencies
• PACKAGE_DEPENDS is passed to mitk_use_modules() as PACKAGES parameter

@jsolislemus There's a workaround if you can't wait for the next release which would also verify if your issue is fixed:

Mixed feelings here: On one hand I'm happy that we, with a single trivial line of CMake code, finally fixed a decade old severe issue we had in MITK without really noticing it causing quite some inconvenience for our users and we were not able to reproduce it over the years. Maybe we even lost some users right before they actually used MITK because "it cannot open my DICOM files". On the other hand, we fixed a decade old severe issue with a single line of CMake code.

I think the only reason that they are not part of the release installers is simply that they are not enabled in the WorkbenchRelease build configuration. The actual todo is to specify what CLI apps we want to include I guess.

Changes in header files: git diff -U0 ff0027ee 8e328dab *.h > output.txt

Let's see if the Nightly installers tomorrow morning are able to load Sarah's DICOM files. 🤞

Deleted branch bugfix/T26164-AlwaysUseDCMTKBuiltInDICOMDictionaries.

Pushed new branch bugfix/T26164-AlwaysUseDCMTKBuiltInDICOMDictionaries.

Everything you need to know about the DICOM dictionaries and how DCMTK is handling them is described here: https://github.com/InsightSoftwareConsortium/DCMTK/blob/master/dcmdata/docs/datadict.txt

Verified on macOS. I downloaded the dictionary and exported DCMDICTPATH. The MITK Workbench was able to load the DICOM files correctly afterwards. 🎉

I made the variable thread-safe by making it an atomic.

Deleted branch bugfix/T28001-FixRESTClientTest.

Pushed new branch bugfix/T28001-FixRESTClientTest.

Deleted branch bugfix/T27999-RemovePhotoacoustics.

Pushed new branch bugfix/T27999-RemovePhotoacoustics.

Removed modules:

• mitkBiophotonics
• MitkBiophotonicsHardware
  • MitkSpectroCam
• MitkPhotoacousticsAlgorithms
• MitkPhotoacousticsHardware
• MitkPhotoacousticsLib
• MitkUSHardwareDiPhAS

Deleted branch feature/T27985-TinyXML-2.

It was released a few days before we put our new server in production mode and I already tested it back then but unfortunately already the installation went everything but smooth. So we should give it at least a few more months to mature before we try to upgrade. :-)

Feature branch. :)

The missing DCMTK dictionary in Linux and macOS installers seems to be the actual issue for some other tickets as well. We recently experienced this again with DICOM files from @s429r. Loading works on Windows in both build and installer versions, but only in build versions on Linux and macOS.

Possibly related to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Maybe this is related to T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Possibly as duplicate of T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers. There's a workaround in the task that you could use to verify if it is the same issue.

Added T26164 as subtask for now, as it is probably the same issue (missing DCMTK dictionary).

Pushed new branch feature/T27985-TinyXML-2.

Deleted branch feature/T27985-TinyXML-2.

I created experimental CI jobs for the branch above: https://cdash.mitk.org/index.php?project=MITK&date=2020-11-22

Pushed new branch feature/T27985-TinyXML-2.

Deleted branch release/T27977-2020-Week-47.

Pushed new branch release/T27977-2020-Week-47.