Page MenuHomePhabricator
Feed Advanced Search

Oct 5 2022

kalali committed rMITK10d3b3205edb: Remove status-bar update from the ImageNavigatorView (authored by kalali).
Remove status-bar update from the ImageNavigatorView
Oct 5 2022, 10:05 PM
kalali committed rMITK722a5b4dc96b: Remove unnecessary includes and comments (authored by kalali).
Remove unnecessary includes and comments
Oct 5 2022, 10:05 PM
kalali committed rMITKdd5b3d989db1: Remove unused CrosshairPositionEvent (authored by kalali).
Remove unused CrosshairPositionEvent
Oct 5 2022, 10:05 PM
kalali committed rMITK7e92f5e3dd09: Remove status-bar update from the StdMultiWidget (authored by kalali).
Remove status-bar update from the StdMultiWidget
Oct 5 2022, 10:05 PM
kalali closed T19470: Cleanup DisplayInteractor as Resolved by committing rMITKe8d06e901d49: Remove update-function from the DisplayActionEventBroadcast.
Oct 5 2022, 10:05 PM · MITK (v2022.10), Bugzilla
kalali committed rMITKe8d06e901d49: Remove update-function from the DisplayActionEventBroadcast (authored by kalali).
Remove update-function from the DisplayActionEventBroadcast
Oct 5 2022, 10:04 PM
kalali triaged T29324: Create view for pixel information as Normal priority.
Oct 5 2022, 9:18 PM · MITK
kalali added a comment to T25043: Remove pixel informations from the statusbar and put it into views.

Pixel information has been removed with {D686}. We discussed that we will open a new task to add a simple pixel value information view as a separate task.

Oct 5 2022, 9:16 PM · Cleared, MITK
kalali edited projects for T19470: Cleanup DisplayInteractor, added: MITK (v2022.10); removed Next Milestone, MITK.
Oct 5 2022, 9:13 PM · MITK (v2022.10), Bugzilla
kalali added a revision to T28578: [mxn multi widget] Optimization of the mxn multi widget: Restricted Differential Revision.
Oct 5 2022, 8:15 PM · MITK
kalali added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

{D722} also belongs to this task but might not be finished this week.

Oct 5 2022, 8:08 PM · MITK
kalali added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

I added another fix to have a simple datanode context menu with a reinit and reset-geometry action for render-window specific initialization.

Oct 5 2022, 8:07 PM · MITK

Oct 4 2022

kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

The effect using the MxNMultiWidget

Oct 4 2022, 5:36 PM · MITK (v2022.10)
kalali added a comment to T26376: Segmentation plugin does not work correctly with the new mxn multi widget.

{D722} is a proposed change for checking the render window geometry and give the user a warning if the geometry is not aligned with the selected reference geometry.
The effect can be seen here:

Oct 4 2022, 4:08 PM · MITK (v2022.10)
kalali added a revision to T26376: Segmentation plugin does not work correctly with the new mxn multi widget: Unknown Object (Differential Revision).
Oct 4 2022, 3:59 PM · MITK (v2022.10)
kalali closed Restricted Maniphest Task, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 4 2022, 2:51 PM · MITK
kalali committed rMITKe4d0b1591a17: Use plane geometries as render window crosshair (authored by kalali).
Use plane geometries as render window crosshair
Oct 4 2022, 2:50 PM
kalali committed rMITKc04b1e53dd9a: Add option to change the crosshair gap size (authored by kalali).
Add option to change the crosshair gap size
Oct 4 2022, 2:50 PM
kalali committed rMITKb70655ebcbaf: Clean base renderer class (authored by kalali).
Clean base renderer class
Oct 4 2022, 2:50 PM
kalali committed rMITK02d6beef74fc: Add handling of plane nodes to mxnmultiwidget (authored by kalali).
Add handling of plane nodes to mxnmultiwidget
Oct 4 2022, 2:50 PM
kalali committed rMITK37d682b8b594: Use crosshair manager in RenderWindowWidget (authored by kalali).
Use crosshair manager in RenderWindowWidget
Oct 4 2022, 2:50 PM
kalali committed rMITK3af0e6c2bd75: Add helper class for slice navigation (authored by kalali).
Add helper class for slice navigation
Oct 4 2022, 2:49 PM
kalali committed rMITK528b8517192b: Add CrosshairManager for render window widgets (authored by kalali).
Add CrosshairManager for render window widgets
Oct 4 2022, 2:49 PM
kalali added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

I created a first working version, based on @s434n's branch (see above). I created an integration branch, made some changes and rebased everything to the latest develop.
Now the following changes, which are already merged into develop, are included, since the integration branch is based on e4d0b1591a17054b4c6792c235aa41345b842cb7:

Oct 4 2022, 2:45 PM · MITK

Sep 30 2022

kalali placed T29269: Check geometries in SliceNavigationController and BaseRenderer up for grabs.
Sep 30 2022, 10:12 AM · MITK (v2024.06)
kalali added a revision to T29289: Compare responsibilities of QmitkSliceNavigationController related classes: Unknown Object (Differential Revision).
Sep 30 2022, 10:12 AM · MITK
kalali added a revision to T29316: Rename QmitkSliderNavigatorWidget and clean variable names: Unknown Object (Differential Revision).
Sep 30 2022, 10:07 AM · MITK (v2022.10)

Sep 29 2022

kalali closed Restricted Maniphest Task, a subtask of T26496: [mxn multi widget] Re-initializations reset all render windows, as Resolved.
Sep 29 2022, 6:03 PM · MITK (v2022.10), Restricted Project

Sep 27 2022

kalali added a parent task for T29316: Rename QmitkSliderNavigatorWidget and clean variable names: T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
Sep 27 2022, 12:43 PM · MITK (v2022.10)
kalali added a subtask for T29289: Compare responsibilities of QmitkSliceNavigationController related classes: T29316: Rename QmitkSliderNavigatorWidget and clean variable names.
Sep 27 2022, 12:43 PM · MITK
kalali updated the task description for T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
Sep 27 2022, 12:42 PM · MITK
kalali updated the task description for T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
Sep 27 2022, 12:17 PM · MITK
kalali triaged T29316: Rename QmitkSliderNavigatorWidget and clean variable names as Normal priority.
Sep 27 2022, 9:52 AM · MITK (v2022.10)

Sep 22 2022

kalali added a comment to T29313: Add a Test to check if the GrowCut algorithm produces a different output.

The idea was to provide an additional differential here for this task that adds the test so yes, the code is there and will be visible in the differential.

Sep 22 2022, 8:03 PM · MITK (v2024.06)
kalali closed T29219: StatusBar / mouse scrolling is broken as Resolved.
Sep 22 2022, 11:26 AM · MITK (v2022.10)
kalali committed rMITKe36380da1e5f: Update the status bar correctly (authored by kalali).
Update the status bar correctly
Sep 22 2022, 11:25 AM
kalali committed rMITK2eee153e5804: Merge remote-tracking branch 'maleike/fix-status-bar-updates' into develop (authored by kalali).
Merge remote-tracking branch 'maleike/fix-status-bar-updates' into develop
Sep 22 2022, 11:25 AM
kalali closed T29265: QmitkSelectableGLWidget is not used anymore and can be removed as Resolved.
Sep 22 2022, 11:22 AM · MITK (v2022.10)
kalali committed rMITK0c57d7ad6218: Remove unused QmitkSelectableGLWidget (authored by kalali).
Remove unused QmitkSelectableGLWidget
Sep 22 2022, 11:22 AM
kalali committed rMITK3edfcc488dc7: Remove QmitkSelectableGLWidget and unnecessary includes (authored by kalali).
Remove QmitkSelectableGLWidget and unnecessary includes
Sep 22 2022, 11:22 AM

Sep 21 2022

kalali added a revision to T29265: QmitkSelectableGLWidget is not used anymore and can be removed: Unknown Object (Differential Revision).
Sep 21 2022, 7:35 PM · MITK (v2022.10)
kalali claimed T29265: QmitkSelectableGLWidget is not used anymore and can be removed.
Sep 21 2022, 5:34 PM · MITK (v2022.10)

Sep 20 2022

kalali added a revision to T28851: [SEG] Add ITK GrowCut as segmentation tool: Restricted Differential Revision.
Sep 20 2022, 2:14 PM · MITK (v2022.10)

Sep 19 2022

kalali claimed T29219: StatusBar / mouse scrolling is broken.
Sep 19 2022, 4:42 PM · MITK (v2022.10)
kalali added a comment to T29219: StatusBar / mouse scrolling is broken.

I added the PR (https://github.com/MITK/MITK/pull/262/) as a differential.

Sep 19 2022, 4:42 PM · MITK (v2022.10)
kalali added a revision to T29219: StatusBar / mouse scrolling is broken: Unknown Object (Differential Revision).
Sep 19 2022, 4:41 PM · MITK (v2022.10)

Sep 16 2022

kalali closed T28762: [Interaction] Remove deprecated / unused interaction files as Resolved.
Sep 16 2022, 11:00 PM · MITK
kalali committed rMITKcc1edae351e2: Remove unused interaction files (authored by kalali).
Remove unused interaction files
Sep 16 2022, 10:59 PM
kalali committed rMITKdd6756610999: Remove unused segmentation interaction files (authored by kalali).
Remove unused segmentation interaction files
Sep 16 2022, 10:59 PM
kalali committed rMITKb18f5343112e: Remove legacy state machine / display configuration (authored by kalali).
Remove legacy state machine / display configuration
Sep 16 2022, 10:59 PM
kalali committed rMITKd80fdb784ffe: Remove unused DisplayConfig.xml-file (authored by kalali).
Remove unused DisplayConfig.xml-file
Sep 16 2022, 10:59 PM

Sep 15 2022

kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Sep 15 2022, 4:52 PM · MITK (v2022.10)
kalali triaged T29303: IGT classes do not work correctly with the new mxn multi widget as Low priority.
Sep 15 2022, 4:43 PM · MITK (v2024.06)
kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Sep 15 2022, 3:00 PM · MITK (v2022.10)
kalali updated the task description for T29302: Movie maker plugin does not work correctly with the new mxn multi widget.
Sep 15 2022, 3:00 PM · MITK (v2024.06)
kalali triaged T29302: Movie maker plugin does not work correctly with the new mxn multi widget as Low priority.
Sep 15 2022, 2:59 PM · MITK (v2024.06)
kalali updated the task description for T29203: [Multi widget] Make classes work with the new render window names.
Sep 15 2022, 9:33 AM · MITK (v2022.10)

Sep 14 2022

kalali added a comment to T27320: No LocalStorage for PlaneGeometryDataVtkMapper3D.

I quickly looked into this using the experimental state of the mxnMultiWidget but I get a Workbench crash. This might be unrelated so I tested something else:
I used the StdMultiWidget, loaded Pic3D but then I used the Render Window Manager to change the Mapper of the axial render window from 2D Mapper to 3D Mapper.
I get the following crash:

Sep 14 2022, 6:20 PM · MITK, Pull Request
kalali closed T26496: [mxn multi widget] Re-initializations reset all render windows, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Sep 14 2022, 9:05 AM · MITK
kalali closed T26496: [mxn multi widget] Re-initializations reset all render windows as Resolved.
Sep 14 2022, 9:05 AM · MITK (v2022.10), Restricted Project
kalali committed rMITK46bc8f473d61: Initialize render windows individually (authored by kalali).
Initialize render windows individually
Sep 14 2022, 9:03 AM
kalali committed rMITK6f11b3331cfb: Initialize the render window part correctly to null (authored by kalali).
Initialize the render window part correctly to null
Sep 14 2022, 9:03 AM
kalali committed rMITK6d128ebb0011: Allow initializing a render window with bounding objects (authored by kalali).
Allow initializing a render window with bounding objects
Sep 14 2022, 9:03 AM
kalali committed rMITKc44600cabb0f: Only initialize the newly created render window (authored by kalali).
Only initialize the newly created render window
Sep 14 2022, 9:03 AM

Sep 8 2022

kalali added a comment to T29219: StatusBar / mouse scrolling is broken.
Sep 8 2022, 7:52 PM · MITK (v2022.10)
kalali updated the task description for T29290: SliceNavigationController and its Stepper fire too many events.
Sep 8 2022, 5:27 PM · MITK
kalali updated the task description for T29290: SliceNavigationController and its Stepper fire too many events.
Sep 8 2022, 5:27 PM · MITK
kalali added a parent task for T29290: SliceNavigationController and its Stepper fire too many events: T29269: Check geometries in SliceNavigationController and BaseRenderer.
Sep 8 2022, 5:21 PM · MITK
kalali added a subtask for T29269: Check geometries in SliceNavigationController and BaseRenderer: T29290: SliceNavigationController and its Stepper fire too many events.
Sep 8 2022, 5:21 PM · MITK (v2024.06)
kalali triaged T29290: SliceNavigationController and its Stepper fire too many events as Normal priority.
Sep 8 2022, 5:21 PM · MITK
kalali added a subtask for T29264: Overhaul of the SliceNavigationController and the BaseRenderer: T29289: Compare responsibilities of QmitkSliceNavigationController related classes.
Sep 8 2022, 5:18 PM · MITK
kalali added a parent task for T29289: Compare responsibilities of QmitkSliceNavigationController related classes: T29264: Overhaul of the SliceNavigationController and the BaseRenderer.
Sep 8 2022, 5:18 PM · MITK
kalali triaged T29289: Compare responsibilities of QmitkSliceNavigationController related classes as Normal priority.
Sep 8 2022, 5:18 PM · MITK
kalali added a comment to T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation.

@floca @s349i I removed the large T28524: Refactor LabelSetImage and associated classes. task as a subtask so this tree of subgraphs looks cleaner.
@s349i We can clean up / go through the subtasks once your changes are under review / are reviewed.

Sep 8 2022, 7:55 AM · MITK (v2022.10), Breaking Change
kalali removed a subtask for T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation: T28524: Refactor LabelSetImage and associated classes..
Sep 8 2022, 7:54 AM · MITK (v2022.10), Breaking Change
kalali removed a parent task for T28524: Refactor LabelSetImage and associated classes.: T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation.
Sep 8 2022, 7:54 AM · Next Milestone

Sep 7 2022

kalali closed T29268: Refactor BaseRenderer's update functions as Resolved.
Sep 7 2022, 8:09 PM · MITK
kalali closed T29268: Refactor BaseRenderer's update functions, a subtask of T29264: Overhaul of the SliceNavigationController and the BaseRenderer, as Resolved.
Sep 7 2022, 8:09 PM · MITK
kalali committed rMITK8fbb1850270f: Refactor BaseRenderer's update functions (authored by kalali).
Refactor BaseRenderer's update functions
Sep 7 2022, 8:09 PM
kalali committed rMITKfd132fc808a1: Clean base renderer (authored by kalali).
Clean base renderer
Sep 7 2022, 8:08 PM
kalali committed rMITK2b5f23efc554: Update comments / documentation (authored by kalali).
Update comments / documentation
Sep 7 2022, 8:08 PM
kalali committed rMITK8994aea00e37: Clean and simplify functions to update geometries (authored by kalali).
Clean and simplify functions to update geometries
Sep 7 2022, 8:08 PM
kalali closed T29267: Refactor SliceNavigationController's Update-function, a subtask of T29264: Overhaul of the SliceNavigationController and the BaseRenderer, as Resolved.
Sep 7 2022, 7:48 PM · MITK
kalali closed T29267: Refactor SliceNavigationController's Update-function as Resolved.
Sep 7 2022, 7:48 PM · MITK
kalali committed rMITK93bc0c914da3: Refactor SliceNavigationController's Update-function (authored by kalali).
Refactor SliceNavigationController's Update-function
Sep 7 2022, 7:48 PM
kalali committed rMITK573842afc450: Clean up due to local rebasing with latest develop (authored by kalali).
Clean up due to local rebasing with latest develop
Sep 7 2022, 7:48 PM
kalali committed rMITK1b76259fb266: Clean and simplify update-function (authored by kalali).
Clean and simplify update-function
Sep 7 2022, 7:48 PM
kalali closed T29200: Completely remove QmitkFunctionality, a subtask of T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor), as Resolved.
Sep 7 2022, 7:03 PM · MITK (v2022.10)
kalali closed T29200: Completely remove QmitkFunctionality as Resolved.
Sep 7 2022, 7:03 PM · MITK (v2022.10), Breaking Change
kalali edited projects for T29200: Completely remove QmitkFunctionality, added: MITK, Next Milestone; removed MITK (v2022.10).
Sep 7 2022, 5:17 PM · MITK (v2022.10), Breaking Change
kalali closed T28669: [Segmentation] QmitkSlicesInterpolator and QmitkSliceBasedInterpolatorWidget seem to be redundant as Resolved.
Sep 7 2022, 4:07 PM · Breaking Change, MITK (v2022.10)
kalali committed rMITKe2c468412e5b: Remove redundant / unused QmitkSliceBasedInterpolatorWidget (authored by kalali).
Remove redundant / unused QmitkSliceBasedInterpolatorWidget
Sep 7 2022, 4:06 PM
kalali committed rMITK8739cc6b81c5: Remove unused class (authored by kalali).
Remove unused class
Sep 7 2022, 4:06 PM
kalali added a project to T28669: [Segmentation] QmitkSlicesInterpolator and QmitkSliceBasedInterpolatorWidget seem to be redundant: Breaking Change.
Sep 7 2022, 4:03 PM · Breaking Change, MITK (v2022.10)
kalali added a project to T29145: [Segmentation] Unused classes can be removed: Breaking Change.
Sep 7 2022, 4:02 PM · Breaking Change, MITK (v2022.10)
kalali closed T29145: [Segmentation] Unused classes can be removed as Resolved.
Sep 7 2022, 4:02 PM · Breaking Change, MITK (v2022.10)
kalali updated the task description for T29145: [Segmentation] Unused classes can be removed.
Sep 7 2022, 4:01 PM · Breaking Change, MITK (v2022.10)
kalali committed rMITKe8245705324e: Remove unused segmentation tool classes (authored by kalali).
Remove unused segmentation tool classes
Sep 7 2022, 3:56 PM
kalali committed rMITK7c3ad27567ea: Remove unused surface creation tool (authored by kalali).
Remove unused surface creation tool
Sep 7 2022, 3:56 PM
kalali committed rMITK863c0555b02e: Remove unused volumetry calculation tool (authored by kalali).
Remove unused volumetry calculation tool
Sep 7 2022, 3:56 PM