Page MenuHomePhabricator
Feed All Stories

Feb 14 2020

floca merged T27131: Should we refactor or deprecate QmitkDataSelectionWidget? into T27133: [Segmentation] Is QmitkDataSelectionWidget needed anymore?.
Feb 14 2020, 8:30 PM · MITK (v2024.06)
floca merged task T27131: Should we refactor or deprecate QmitkDataSelectionWidget? into T27133: [Segmentation] Is QmitkDataSelectionWidget needed anymore?.
Feb 14 2020, 8:30 PM · Request for Discussion, MITK
kalali triaged T27134: [Image statistics] Refactor Calculation Job and Calculation Runnable as Normal priority.
Feb 14 2020, 7:38 PM · Auto-closed, MITK
kalali triaged T27133: [Segmentation] Is QmitkDataSelectionWidget needed anymore? as Normal priority.
Feb 14 2020, 7:35 PM · MITK (v2024.06)
floca added a comment to T27083: Workarround for the OpenGL context menu crash.

Closed task and merged changes that optimized the thumbnail update of the selection widgets due to changes in the data.

Feb 14 2020, 6:02 PM · Request for Discussion, MITK
floca committed rMITK1ea959aa2755: Fixed T27083 (authored by floca).
Fixed T27083
Feb 14 2020, 6:01 PM
floca committed rMITK4f79c1d3cfa7: Merge branch 'master' into T27083-Workarround_for_OpenGL_context_menu_crash (authored by floca).
Merge branch 'master' into T27083-Workarround_for_OpenGL_context_menu_crash
Feb 14 2020, 6:01 PM
floca committed rMITKd8fb6bc69668: Removed workarround save guard for T27069 as problem is fixed. (authored by floca).
Removed workarround save guard for T27069 as problem is fixed.
Feb 14 2020, 6:01 PM
floca committed rMITK05e2384bd15e: Fixed gcc compiler errors (authored by floca).
Fixed gcc compiler errors
Feb 14 2020, 6:01 PM
floca committed rMITKd34515785a4d: Fixed T27083 (authored by floca).
Fixed T27083
Feb 14 2020, 6:01 PM
floca closed T27083: Workarround for the OpenGL context menu crash, a subtask of T23751: Introduction of new selection concept, as Resolved.
Feb 14 2020, 6:00 PM · Noteworthy, MITK
floca closed T27083: Workarround for the OpenGL context menu crash as Resolved by committing rMITKd34515785a4d: Fixed T27083.
Feb 14 2020, 6:00 PM · Request for Discussion, MITK
floca closed T27083: Workarround for the OpenGL context menu crash, a subtask of T27069: OpenGL error / crash when opening context menu, as Resolved.
Feb 14 2020, 6:00 PM · MITK
kalali awarded T27069: OpenGL error / crash when opening context menu a Like token.
Feb 14 2020, 5:59 PM · MITK
floca closed T27034: Refactor Segmentation plugin to use new selection concept, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Feb 14 2020, 5:51 PM · MITK, Restricted Project, Cleared
floca closed T27034: Refactor Segmentation plugin to use new selection concept as Resolved.
Feb 14 2020, 5:51 PM · MITK
floca closed T27035: Refactor Multi Label Segmentation plugin to use new selection concept as Resolved.
Feb 14 2020, 5:51 PM · MITK
floca closed T27035: Refactor Multi Label Segmentation plugin to use new selection concept, a subtask of T24775: Refactor plugins to use the new node selection widgets, as Resolved.
Feb 14 2020, 5:51 PM · MITK, Restricted Project, Cleared
floca committed rMITK3a76ab2d0b4e: First draft of the refactoring (authored by floca).
First draft of the refactoring
Feb 14 2020, 5:48 PM
floca added a comment to T27069: OpenGL error / crash when opening context menu.

Yes. This solved the problem. Still do not understand why only LabelSetImages where that problematic, but thanks for having a look. The second pair of eyes really helped.

Feb 14 2020, 5:46 PM · MITK
floca committed rMITK84994df59675: Fixed T27096 (authored by floca).
Fixed T27096
Feb 14 2020, 5:45 PM
floca committed rMITK54ccbb31af77: Merge remote-tracking branch 'origin/master' into T27034… (authored by floca).
Merge remote-tracking branch 'origin/master' into T27034…
Feb 14 2020, 5:45 PM
floca closed T27096: [MITKDoc] Revise MultiLabel Segmentation Utilities Plugin Documentation as Resolved by committing rMITK84994df59675: Fixed T27096.
Feb 14 2020, 5:45 PM · MITK (v2021.02)
kislinsk added a comment to T27069: OpenGL error / crash when opening context menu.

The fix is to replace the calls of repaint() with update() in QmitkNodeSelectionButton.cpp. More info: https://doc.qt.io/qt-5/qwidget.html#repaint

Feb 14 2020, 5:35 PM · MITK
floca committed rMITK3d5e49433c92: Fixed gcc compile errors (authored by floca).
Fixed gcc compile errors
Feb 14 2020, 4:55 PM
floca added a comment to T22085: Perfusion Conversion to Concentration: Average Baseline signal.

Pushed new branch T22085-gcc_fix.

Feb 14 2020, 4:55 PM · Restricted Project, MITK
floca claimed T27093: [MITKDoc] Revise Segmentation Plugin.
Feb 14 2020, 3:45 PM · MITK (v2021.02)
floca claimed T27095: [MITKDoc] Revise MultiLabel Segmentation Plugin Documentation.
Feb 14 2020, 3:45 PM · MITK (v2021.02)
kahl committed rMITK9c67bc4b21be: Update logging documentation (authored by kahl).
Update logging documentation
Feb 14 2020, 3:26 PM
kahl claimed T27107: [MITKDoc] Revise Screenshot Maker Plugin Documentation.
Feb 14 2020, 3:07 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27069: OpenGL error / crash when opening context menu.

I deactivated FXAA in the RenderingManager and BaseRenderer and while the error output is still the same, the crash doesn't happen anymore. Instead, one of the four render windows is black until it is redrawn for example by clicking in it.

Feb 14 2020, 2:16 PM · MITK
thomass updated the task description for T27109: [MITKDoc] Revise Properties Plugin Documentation.
Feb 14 2020, 2:15 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27105: [MITKDoc] Revise Measurement Plugin Documentation.
Feb 14 2020, 2:14 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27104: [MITKDoc] Revise Modelfit Plugin Documentation.
Feb 14 2020, 2:14 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27103: [MITKDoc] Revise Point Set Interaction Plugin Documentation.
Feb 14 2020, 2:14 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27102: [MITKDoc] Revise Movie Maker Plugin Documentation.
Feb 14 2020, 2:13 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27101: [MITKDoc] Revise Logging Plugin Documentation.
Feb 14 2020, 2:12 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27099: [MITKDoc] Revise Clipping Plane Plugin Documentation.
Feb 14 2020, 2:11 PM · MITK (v2024.06), Cleared
thomass updated the task description for T27098: [MITKDoc] Revise Image Cropper Plugin Documentation.
Feb 14 2020, 2:11 PM · Cleared, MITK (v2021.02)
thomass updated the task description for T27097: [MITKDoc] Revise Statistics Plugin Documentation.
Feb 14 2020, 2:11 PM · Cleared, MITK (v2021.02)
nolden added a revision to T25745: Integrate new DICOM browser widget from CTK: Unknown Object (Differential Revision).
Feb 14 2020, 2:08 PM · MITK
kahl claimed T27101: [MITKDoc] Revise Logging Plugin Documentation.
Feb 14 2020, 2:08 PM · Cleared, MITK (v2021.02)
kalali updated the task description for T27100: [MITKDoc] Revise DataManager Plugin Documentation.
Feb 14 2020, 2:06 PM · Cleared, MITK (v2021.02)
kislinsk added a comment to T27069: OpenGL error / crash when opening context menu.

Did a first test on my PC and the exception is thrown from the Nvidia OpenGL driver (nvoglv64.dll) because of a null pointer access. So whatever causes it to happen, there is at least also a bug in the driver.

Feb 14 2020, 2:03 PM · MITK
kalali claimed T27100: [MITKDoc] Revise DataManager Plugin Documentation.
Feb 14 2020, 2:01 PM · Cleared, MITK (v2021.02)
kompan added a revision to T22085: Perfusion Conversion to Concentration: Average Baseline signal: Unknown Object (Differential Revision).
Feb 14 2020, 1:02 PM · Restricted Project, MITK
kislinsk renamed T27131: Should we refactor or deprecate QmitkDataSelectionWidget? from Should we refactor or depricate QmitkDataSelectionWidget? to Should we refactor or deprecate QmitkDataSelectionWidget?.
Feb 14 2020, 12:52 PM · Request for Discussion, MITK
floca triaged T27131: Should we refactor or deprecate QmitkDataSelectionWidget? as Normal priority.
Feb 14 2020, 12:46 PM · Request for Discussion, MITK
kislinsk closed T27130: Remove Qt variables from Dashboard scripts as Resolved.
Feb 14 2020, 12:36 PM · Noteworthy, CI, MITK
kislinsk committed rMITKa8f8c174c509: Merge branch 'T27130-RemoveQtVariablesFromDashboardScripts' (authored by kislinsk).
Merge branch 'T27130-RemoveQtVariablesFromDashboardScripts'
Feb 14 2020, 12:19 PM
floca removed a project from T27122: PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic: Request for Discussion.

discussion result: Use a larger epsilon in the generator. Document the reason why mitk::eps was not used and refere to this task.

Feb 14 2020, 11:54 AM · MITK
kompan claimed T27104: [MITKDoc] Revise Modelfit Plugin Documentation.
Feb 14 2020, 11:48 AM · Cleared, MITK (v2021.02)
floca removed a project from T27046: Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsistency): Request for Discussion.

We discussed it:

Feb 14 2020, 11:36 AM · Cleared, MITK (v2021.02)
kompan committed rMITK33231a7e90a6: Remove white spaces and tabs at end of each line. (authored by kompan).
Remove white spaces and tabs at end of each line.
Feb 14 2020, 11:21 AM
kompan committed rMITK223881977a1d: Merge branch 'master' into T26840-MitkHomepageReorganization-TopLevel (authored by kompan).
Merge branch 'master' into T26840-MitkHomepageReorganization-TopLevel
Feb 14 2020, 10:59 AM
thomass placed T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation up for grabs.
Feb 14 2020, 10:43 AM · Cleared, MITK (v2021.02)
kislinsk committed rMITK4e1a1ebf6b32: Remove Qt variables from dashboard scripts (authored by kislinsk).
Remove Qt variables from dashboard scripts
Feb 14 2020, 10:39 AM
kislinsk added a comment to T27130: Remove Qt variables from Dashboard scripts.

Pushed new branch T27130-RemoveQtVariablesFromDashboardScripts.

Feb 14 2020, 10:39 AM · Noteworthy, CI, MITK
holzwart added a member for IMSY: t.tran.
Feb 14 2020, 10:33 AM
kislinsk triaged T27130: Remove Qt variables from Dashboard scripts as High priority.
Feb 14 2020, 10:32 AM · Noteworthy, CI, MITK
kislinsk closed T27076: [CTK] QT designer plugins are not built anymore and cause problems in command line module as Resolved.
Feb 14 2020, 9:58 AM · MITK
kislinsk committed rMITK80dbfaa2f89b: Merge remote-tracking branch 'origin/T27076-ChangeDesignerBuildFlagToDefault' (authored by kislinsk).
Merge remote-tracking branch 'origin/T27076-ChangeDesignerBuildFlagToDefault'
Feb 14 2020, 9:57 AM
kompan committed rMITKf08e6d4e9847: Add timepoint selection for baseline averaging in UI (authored by kompan).
Add timepoint selection for baseline averaging in UI
Feb 14 2020, 8:54 AM
kompan committed rMITKcc75e7683511: Improve formula readability. Shorter version of CheckBaselineSelectionSetting. (authored by kompan).
Improve formula readability. Shorter version of CheckBaselineSelectionSetting.
Feb 14 2020, 8:54 AM
kompan committed rMITKe81db0eab7e3: Set max value of baseline selection spin boxes according to size of selected… (authored by kompan).
Set max value of baseline selection spin boxes according to size of selected…
Feb 14 2020, 8:54 AM
kompan committed rMITK50b9bf46f746: BaselineCheck method instead of individual condition checking. (authored by kompan).
BaselineCheck method instead of individual condition checking.
Feb 14 2020, 8:54 AM
kompan committed rMITK3ca9b19f21a7: Intead of double, use PixelType of the image types of the filter input. (authored by kompan).
Intead of double, use PixelType of the image types of the filter input.
Feb 14 2020, 8:54 AM
kompan committed rMITKb9e792fcbb2f: Add brackets for better readability. (authored by kompan).
Add brackets for better readability.
Feb 14 2020, 8:54 AM
kompan committed rMITK3b7a2d336fc7: Fix comparison of of integers of different signs for for start/end time step. (authored by kompan).
Fix comparison of of integers of different signs for for start/end time step.
Feb 14 2020, 8:54 AM
kompan committed rMITK23191a9b0c85: Enable time step value selection in UpdateGUIControls(). (authored by kompan).
Enable time step value selection in UpdateGUIControls().
Feb 14 2020, 8:54 AM
kompan committed rMITK59a0196aa538: Use ExtractImageFilter and MeanProjectionImage Filter in… (authored by kompan).
Use ExtractImageFilter and MeanProjectionImage Filter in…
Feb 14 2020, 8:54 AM
kompan committed rMITKb5f4aa5786d3: Start time step counting with 0 instead of 1. (authored by kompan).
Start time step counting with 0 instead of 1.
Feb 14 2020, 8:54 AM
kompan committed rMITK382ccdcc10bb: Specification of m_BaselineStartTimeStep and m_BaselineStopTimeStep in code. (authored by kompan).
Specification of m_BaselineStartTimeStep and m_BaselineStopTimeStep in code.
Feb 14 2020, 8:54 AM
kompan committed rMITKdab41d671711: Rename Start/StopTimePoint label in UI to Start/StopTimeFrame. (authored by kompan).
Rename Start/StopTimePoint label in UI to Start/StopTimeFrame.
Feb 14 2020, 8:54 AM
kompan committed rMITK99b4f94a49df: Rename BaselineStartTimePoint to BaselineStartTimeStep. Rename… (authored by kompan).
Rename BaselineStartTimePoint to BaselineStartTimeStep. Rename…
Feb 14 2020, 8:54 AM
kompan committed rMITK1dd5d43ae9ad: Update help file text and screenshots with baseline image averaging. (authored by kompan).
Update help file text and screenshots with baseline image averaging.
Feb 14 2020, 8:54 AM
kompan committed rMITKc332cc653314: Clea up: remove commented code. (authored by kompan).
Clea up: remove commented code.
Feb 14 2020, 8:54 AM
kompan committed rMITK89bb787478d6: Handle UI contraints for baseline start and end time points. (authored by kompan).
Handle UI contraints for baseline start and end time points.
Feb 14 2020, 8:54 AM
kompan committed rMITKb10562e946fe: In PrepareBaselineImage(), add baseline image averaging functionality. (authored by kompan).
In PrepareBaselineImage(), add baseline image averaging functionality.
Feb 14 2020, 8:54 AM
kompan committed rMITKb8f7753da951: First attempt to average two baseline images. (authored by kompan).
First attempt to average two baseline images.
Feb 14 2020, 8:54 AM
kompan committed rMITK9b9081f93052: Add timepoint selection for baseline averaging in UI (authored by kompan).
Add timepoint selection for baseline averaging in UI
Feb 14 2020, 8:54 AM
kompan added a comment to T22085: Perfusion Conversion to Concentration: Average Baseline signal.

Pushed new branch T22085-PerfusionConversionToConcentration-AverageBaselineSignal.

Feb 14 2020, 8:53 AM · Restricted Project, MITK
kislinsk moved T27016: Use OpenStack for our CI system from Restricted Project Column to Restricted Project Column on the Restricted Project board.

Then let's wait until we talked to the Openstack admins regarding Windows instances. If we can have them in the same Openstack project, resource requirements change anyway. If we cannot have them in the same project, we may just want to increase RAM to 160 GB to have 10 Linux build clients.

Feb 14 2020, 6:41 AM · Restricted Project, CI
kislinsk updated the task description for T27033: Clean up stale remote branches.
Feb 14 2020, 6:29 AM · Auto-closed, MITK

Feb 13 2020

floca moved T27046: Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsistency) from Backlog to MITK Meeting on the Request for Discussion board.
Feb 13 2020, 9:45 PM · Cleared, MITK (v2021.02)
floca moved T27069: OpenGL error / crash when opening context menu from Backlog to MITK Meeting on the Request for Discussion board.
Feb 13 2020, 9:44 PM · MITK
floca moved T27083: Workarround for the OpenGL context menu crash from Backlog to MITK Meeting on the Request for Discussion board.
Feb 13 2020, 9:44 PM · Request for Discussion, MITK
floca moved T27090: Provide standard NodePredicates from Backlog to MITK Meeting on the Request for Discussion board.
Feb 13 2020, 9:44 PM · MITK (v2024.06), Request for Discussion
floca moved T27122: PlanarFigureMaskGenerator::GetPrincipalAxis() is too pedantic from Backlog to MITK Meeting on the Request for Discussion board.
Feb 13 2020, 9:44 PM · MITK
floca closed T27006: [Perfusion] - Problems selecting T1 map as Resolved.

I close this task for now. Reason:

  • The problem of selecting a T1 map was identified. There is a workarround (see above) and it will be finally covered by T27043.
  • The fact that the current T1 conversion can be missunderstood is covered by T27047.
  • Adding an additional conversion option will be discussed by @Sara and @kompan and may spawn new tasks.
Feb 13 2020, 9:38 PM · MITK
floca changed the visibility for T27047: Perfusion- Conversion from signal to concentration: Rename Using T1-map.
Feb 13 2020, 9:36 PM · Cleared, MITK (v2021.02)
floca added a project to T27047: Perfusion- Conversion from signal to concentration: Rename Using T1-map: MITK.
Feb 13 2020, 9:36 PM · Cleared, MITK (v2021.02)
floca added a comment to T27016: Use OpenStack for our CI system.

P.S. :Great :)

Feb 13 2020, 9:27 PM · Restricted Project, CI
floca added a comment to T27016: Use OpenStack for our CI system.

Regarding ressources: Say what you prefer. I'll take care. If 7 would mean, we give back CPU resources. It is no problem. CPUs can be overbooked an if we have no machine configured using the CPU it does not cost money.

Feb 13 2020, 9:27 PM · Restricted Project, CI
kislinsk added a comment to T27016: Use OpenStack for our CI system.

Was able to (probably) completely provision Ubuntu 18.04 instances for MITK builds with a cloud-config file.

Feb 13 2020, 6:50 PM · Restricted Project, CI
eisenman added a comment to T27003: Extend representation object handling in NavigationDataObjectVisualizationFilter.

Can this be contributed to the master as is?

Feb 13 2020, 5:35 PM · IGT, MITK, Restricted Project
eisenman updated subscribers of T27003: Extend representation object handling in NavigationDataObjectVisualizationFilter.
Feb 13 2020, 5:34 PM · IGT, MITK, Restricted Project
floca committed rMITK27f345713145: fixed gcc compile error (authored by floca).
fixed gcc compile error
Feb 13 2020, 4:48 PM
floca committed rMITK84cd40490b1e: Optimized layout of the utilities view. (authored by floca).
Optimized layout of the utilities view.
Feb 13 2020, 4:48 PM
floca committed rMITK4b0ec85ee9b4: Removed binary property observer (authored by floca).
Removed binary property observer
Feb 13 2020, 4:48 PM