Page MenuHomePhabricator
Feed All Stories

Apr 17 2023

kislinsk committed rMITKcd2fbb8830e7: Allow external links in task descriptions (authored by kislinsk).
Allow external links in task descriptions
Apr 17 2023, 8:02 AM
kislinsk committed rMITK9744b9024b9b: Format long strings (authored by kislinsk).
Format long strings
Apr 17 2023, 8:02 AM
kislinsk committed rMITKe3b6eb980742: Add data storage checks to FlowBench (authored by kislinsk).
Add data storage checks to FlowBench
Apr 17 2023, 8:02 AM
kislinsk committed rMITKba98c16d1343: Remove unused predicates (authored by kislinsk).
Remove unused predicates
Apr 17 2023, 8:02 AM
kislinsk committed rMITKa9b5bc6aea3b: Reorder initialization of selection widget (authored by kislinsk).
Reorder initialization of selection widget
Apr 17 2023, 8:02 AM
kislinsk committed rMITKba8780e8091a: Merge branch 'develop' into feature/T29445-SegmentationTaskListView (authored by kislinsk).
Merge branch 'develop' into feature/T29445-SegmentationTaskListView
Apr 17 2023, 8:02 AM
kislinsk committed rMITK9ef172b5bbaf: Merge branch 'feature/T29445-SegmentationTaskListView' into develop (authored by kislinsk).
Merge branch 'feature/T29445-SegmentationTaskListView' into develop
Apr 17 2023, 8:02 AM
kislinsk committed rMITKcde324092e31: Rename parameter (authored by kislinsk).
Rename parameter
Apr 17 2023, 8:02 AM
kislinsk added a comment to T29521: Should all MITK.IO infos be stored in serialzed file?.

Input location is used by the SegmentationTaskList and SegmentationTaskListIO.

Apr 17 2023, 7:59 AM · Request for Discussion, MITK

Apr 16 2023

floca created T29521: Should all MITK.IO infos be stored in serialzed file?.
Apr 16 2023, 6:08 PM · Request for Discussion, MITK

Apr 14 2023

s434n added a revision to T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly: Unknown Object (Differential Revision).
Apr 14 2023, 11:51 AM · Request for Discussion, MITK (v2023.04)
s434n edited projects for T29347: Measurement Checklist - Possible inconsistent recentering behavior when clicking on geometry node in Data Manager., added: Request for Discussion; removed MITK (v2023.04), Cleared.

After looking at the checklist again, I don't think there is a need to change anything. The checklist specifically only speaks of selecting the line-node once. When following the checklist instructions, everything should work as described.

Apr 14 2023, 11:23 AM · Request for Discussion, Checklist
kislinsk placed T29518: Initial auto-selection does not work in QmitkSingleNodeSelectionWidget up for grabs.
Apr 14 2023, 5:22 AM · MITK (v2024.06)

Apr 13 2023

s434n added a comment to T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.
Apr 13 2023, 5:18 PM · MITK (v2023.04)
s434n updated the task description for T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label.
Apr 13 2023, 5:15 PM · MITK (v2023.04)
s434n triaged T29520: [Segmentation] [Interpolation] "Confirm for single slice" always uses first label as High priority.
Apr 13 2023, 5:15 PM · MITK (v2023.04)
kislinsk moved T29519: Reduce vertical space occupied by Segmentation view from Backlog to Cycle on the MITK (v2023.04) board.
Apr 13 2023, 10:02 AM · MITK (v2023.04)
kislinsk added a revision to T29519: Reduce vertical space occupied by Segmentation view : Unknown Object (Differential Revision).
Apr 13 2023, 9:56 AM · MITK (v2023.04)
kislinsk added a comment to T29519: Reduce vertical space occupied by Segmentation view .

Pushed new branch to rMITK MITK: feature/T29519-ReduceVerticalSpaceOccupied.

Apr 13 2023, 9:51 AM · MITK (v2023.04)
kislinsk triaged T29519: Reduce vertical space occupied by Segmentation view as Normal priority.
Apr 13 2023, 9:45 AM · MITK (v2023.04)
kislinsk lowered the priority of T29518: Initial auto-selection does not work in QmitkSingleNodeSelectionWidget from High to Normal.
Apr 13 2023, 9:36 AM · MITK (v2024.06)

Apr 12 2023

floca added a comment to T29518: Initial auto-selection does not work in QmitkSingleNodeSelectionWidget.

It is indeed two conflicting mechanisms.

Apr 12 2023, 2:33 PM · MITK (v2024.06)

Apr 11 2023

nafi updated nafi.
Apr 11 2023, 9:16 PM
fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

@floca I think the issue is that it will probably be better to separately communicate server endpoint and refer to the Study/Series items in the DICOM model hierarchy via UIDs. I think adding support for DICOM should be done as part of the initial design, rather than and afterthought and replacement of file paths by URIs. But that only makes sense if DICOM is important and primary for the use case driving the development. That is why I suggest you guys proceed with your original plan, and we will try to experiment with the DICOM-centric design. But of course I may be wrong. I just think it is more expedient to experiment rather than coordinate the design at the same time as the use cases and requirements are evolving.

Apr 11 2023, 4:58 PM · MITK (v2022.10)
floca added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

I think at this point it probably makes sense for us to explore some dynamic JSON representation for defining the task that is geared towards using DICOM, and if/when it makes sense, we can sync up to exchange thoughts and consider harmonization. The statement of the problem is very dynamic, and it is probably too early to do such coordination now.

Apr 11 2023, 11:47 AM · MITK (v2022.10)

Apr 10 2023

fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

@kislinsk @floca thank you for the feedback!

Apr 10 2023, 11:53 PM · MITK (v2022.10)

Apr 6 2023

a178n added a comment to T29130: [WorkBench] Segmentation fault when "Close Project" is invoked and QmitkDataStorageComboBox widget is in UI.

Hi Ralf,
I tried explicitly deleting widget objects but no difference. The destructor of QmitkSingleNodeSelectionWidget ie. QmitkAbstractNodeSelectionWidget::~QmitkAbstractNodeSelectionWidget finishes without issues for every widget present.
It has something to do the MessageDelegates and listeners. I don't know how to explain but I have found a way to "fix" the issue.
When I try to explicitly prevent adding Node Events namely, AddListener & RemoveListener for QmitkSingleNodeSelectionWidget object in the nnUNet tool GUI, the problem of crashing goes away! It works.
That probably means, the DataStorage object is having hanging ghost listeners which causes the crash. (But it doesn't make sense because ~QmitkAbstractNodeSelectionWidget is suppose to remove them explicitly).
My "fix" is in D793 - maybe it rings a bell.

Apr 6 2023, 3:38 PM · MITK
a178n added a comment to T29130: [WorkBench] Segmentation fault when "Close Project" is invoked and QmitkDataStorageComboBox widget is in UI.

Pushed new branch to rMITK MITK: feature/T29130-nnunet-nodeselector-bugfix.

Apr 6 2023, 1:44 PM · MITK
kislinsk claimed T29518: Initial auto-selection does not work in QmitkSingleNodeSelectionWidget.
Apr 6 2023, 1:27 PM · MITK (v2024.06)
kislinsk created T29518: Initial auto-selection does not work in QmitkSingleNodeSelectionWidget.
Apr 6 2023, 1:27 PM · MITK (v2024.06)
a178n claimed T29497: Full support for all subtasks.
Apr 6 2023, 1:22 PM · MITK
kislinsk added a comment to T29487: Tool Icon for TotalSegmentator.

But it can be used as inspiration indeed. For example, a vectorized, simplified version of the colored organs maybe. See also my idea in the #proj-mitk channel. This could have impact on the grade of simplification/reduction.

Apr 6 2023, 9:31 AM · MITK (v2024.06)
floca added a comment to T29487: Tool Icon for TotalSegmentator.

No way that this works as an icon.

Apr 6 2023, 9:24 AM · MITK (v2024.06)
kislinsk updated subscribers of T29487: Tool Icon for TotalSegmentator.

@wasserth suggested the following image as a starting point:

Apr 6 2023, 9:11 AM · MITK (v2024.06)
kislinsk closed T29517: The compiled MITK has no source file as Invalid.

Please see the build instructions. Long story short: MITK uses a superbuild, meaning it has two build levels. What you see is the outer level, called superbuild. The superbuild downloads, configures, and builds all required third-party libraries (except Qt) automatically. One of the projects of the superbuild is the MITK build itself, the inner level. As soon as the MITK-Configure project was successfully built on superbuild level, you find a populated MITK-build folder in your superbuild folder. From then on you can set it as build directory in CMake to change the configuration of MITK itself, for example, enable plugins and so on...

Apr 6 2023, 9:08 AM · MITK
fly-beep created T29517: The compiled MITK has no source file.
Apr 6 2023, 8:00 AM · MITK

Apr 5 2023

floca added a comment to T29130: [WorkBench] Segmentation fault when "Close Project" is invoked and QmitkDataStorageComboBox widget is in UI.

Which class try to acces an invalid pointer?

Apr 5 2023, 9:19 PM · MITK
kislinsk removed a project from T29487: Tool Icon for TotalSegmentator: Request for Discussion.

I opened an issue regarding an official logo and/or icon: https://github.com/wasserth/TotalSegmentator/issues/98

Apr 5 2023, 9:05 PM · MITK (v2024.06)
a178n added a revision to T29497: Full support for all subtasks: Unknown Object (Differential Revision).
Apr 5 2023, 5:16 PM · MITK
a178n updated the task description for T29497: Full support for all subtasks.
Apr 5 2023, 5:15 PM · MITK
kalali closed T29515: [mxn multi widget] Crosshair not centered initially as Resolved.
Apr 5 2023, 2:48 PM · MITK (v2023.04)
kalali committed rMITKec1cfd81eac9: Center crosshair initially (authored by kalali).
Center crosshair initially
Apr 5 2023, 2:48 PM
kalali committed rMITK24869cd46ad2: Use current plane geomety to center crosshair (authored by kalali).
Use current plane geomety to center crosshair
Apr 5 2023, 2:47 PM
kislinsk assigned T29347: Measurement Checklist - Possible inconsistent recentering behavior when clicking on geometry node in Data Manager. to s434n.
Apr 5 2023, 12:20 PM · Request for Discussion, Checklist
kislinsk claimed T29105: [3D Surface Interpolation] 3D+t Interpolation Preview Crashes When Going Through Different Time Steps.
Apr 5 2023, 12:17 PM · Breaking Change, MITK (v2024.06), Checklist
kislinsk triaged T29516: Develop a general/global concept for key sequences and shortcuts in the MitkWorkbench as Low priority.
Apr 5 2023, 11:18 AM · MITK (v2024.06)
kislinsk removed a project from T29502: [SEG] Optimizing MultiLabelImage widgets (context menue) action names + new actions?: Request for Discussion.

yes

Apr 5 2023, 11:05 AM · MITK (v2024.06)
kislinsk updated the task description for T29502: [SEG] Optimizing MultiLabelImage widgets (context menue) action names + new actions?.
Apr 5 2023, 11:04 AM · MITK (v2024.06)
kislinsk updated the task description for T29502: [SEG] Optimizing MultiLabelImage widgets (context menue) action names + new actions?.
Apr 5 2023, 11:04 AM · MITK (v2024.06)
kislinsk removed a project from T29453: Unreachable catch block in OTSU?: Request for Discussion.

Not necessary for the upcoming release but we should look into it nevertheless and take care of it.

Apr 5 2023, 11:03 AM · MITK
kislinsk edited projects for T29451: [SEG] Response labels all not displayed on Workbench, added: Cleared; removed Request for Discussion.
Apr 5 2023, 11:00 AM · Cleared, MITK (v2023.04)
kislinsk updated the task description for T29451: [SEG] Response labels all not displayed on Workbench.
Apr 5 2023, 10:57 AM · Cleared, MITK (v2023.04)
kislinsk updated the task description for T29451: [SEG] Response labels all not displayed on Workbench.
Apr 5 2023, 10:57 AM · Cleared, MITK (v2023.04)
kislinsk moved T29487: Tool Icon for TotalSegmentator from MITK Meeting to Backlog on the Request for Discussion board.
Apr 5 2023, 10:56 AM · MITK (v2024.06)
kislinsk claimed T29487: Tool Icon for TotalSegmentator.
Apr 5 2023, 10:53 AM · MITK (v2024.06)
floca moved T29076: [Segmentation] Pressing DEL should delete a label from Backlog to MITK Meeting on the Request for Discussion board.
Apr 5 2023, 10:43 AM · MITK (v2024.06), Checklist
floca moved T29502: [SEG] Optimizing MultiLabelImage widgets (context menue) action names + new actions? from Backlog to MITK Meeting on the Request for Discussion board.
Apr 5 2023, 10:43 AM · MITK (v2024.06)
a178n added a project to T28675: Boolean Operations in Segmentation utilities are slow: Request for Discussion.
Apr 5 2023, 10:41 AM · MITK (v2024.06), Request for Discussion
kalali moved T29509: [mxn multi widget] Clicking a render window utility toolbar does not change focus from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Apr 5 2023, 9:59 AM · MITK (v2024.06)
kalali moved T26988: [Checklist] LevelWindow checklist does not provide explicit expected results for sufficient verification from Backlog to Tests/Checklists on the MITK (v2023.04) board.
Apr 5 2023, 9:58 AM · MITK (v2024.06)
kalali placed T29163: [XNAT] Opening XNAT session fails up for grabs.
Apr 5 2023, 9:56 AM · MITK (v2024.06)
kalali moved T29498: [mxn multi widget] Restructure QmitkSynchronizedNodeSelectionWidget and QmitkAbstractNodeSelectionWidget from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Apr 5 2023, 9:56 AM · MITK (v2024.06)
kalali moved T29499: [mxn multi widget] Test inverted slice navgation widget for 4D data from Backlog to mxn MultiWidget on the MITK (v2023.04) board.
Apr 5 2023, 9:55 AM · MITK (v2024.06)
kalali moved T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers from Backlog to Cycle on the MITK (v2023.04) board.
Apr 5 2023, 9:55 AM · MITK (v2024.06)
kalali moved T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly from mxn MultiWidget to Cycle on the MITK (v2023.04) board.
Apr 5 2023, 9:50 AM · Request for Discussion, MITK (v2023.04)

Apr 4 2023

kalali added a revision to T29515: [mxn multi widget] Crosshair not centered initially: Unknown Object (Differential Revision).
Apr 4 2023, 6:09 PM · MITK (v2023.04)
kalali renamed T29515: [mxn multi widget] Crosshair not centered initially from [mxn multi widget] Center crosshair initially to [mxn multi widget] Crosshair not centered initially.
Apr 4 2023, 5:48 PM · MITK (v2023.04)
kalali moved T29515: [mxn multi widget] Crosshair not centered initially from Backlog to Cycle on the MITK (v2023.04) board.
Apr 4 2023, 5:48 PM · MITK (v2023.04)
kalali triaged T29515: [mxn multi widget] Crosshair not centered initially as Normal priority.
Apr 4 2023, 5:48 PM · MITK (v2023.04)
kalali committed rMITK86f8109e2783: Fix crosshair visibility (authored by kalali).
Fix crosshair visibility
Apr 4 2023, 5:37 PM
kalali committed rMITK39291f3d1052: Keep renderer-specific property of helper nodes (authored by kalali).
Keep renderer-specific property of helper nodes
Apr 4 2023, 5:37 PM
kalali closed T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized as Resolved.
Apr 4 2023, 5:36 PM · MITK (v2023.04)
kalali committed rMITK47958f163436: Allow layer change in synch render window mode (authored by kalali).
Allow layer change in synch render window mode
Apr 4 2023, 5:36 PM
kalali committed rMITKe327c70e2404: Allow data dropping if the base renderer is null (authored by kalali).
Allow data dropping if the base renderer is null
Apr 4 2023, 5:36 PM
s434n claimed T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly.
Apr 4 2023, 3:33 PM · Request for Discussion, MITK (v2023.04)
s434n claimed T29504: Initialize QmitkSlicesInterpolator with render windows instead of slice navigation controllers.
Apr 4 2023, 3:29 PM · MITK (v2024.06)
a178n added a comment to T28691: AutoSegmentationWithPreviewTool tool manager won't support multithreading.

This context and code artifacts referred in this issue seems obsolete or changes. The issue needs to be rephrased if not closed.

Apr 4 2023, 12:18 PM · MITK
a178n added a project to T28691: AutoSegmentationWithPreviewTool tool manager won't support multithreading: Request for Discussion.
Apr 4 2023, 12:16 PM · MITK
kalali triaged T29514: [mxn multi widget] Render windows are not correctly initialized as Normal priority.
Apr 4 2023, 10:04 AM · MITK (v2024.06)
floca added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.
  • l think it will be important to make it possible to work with the inputs defined by DICOM UIDs and available through DICOM endpoints, instead of relying purely on file system. Would this be acceptable for your use cases?

We focused on local file paths so far indeed, driven by our requirements and Kaapana’s way of providing general resource access through local files. URIs are not off the table, though, as long as complexity lies within in the intentional KISS spirit of the file format.

I agree (to both ;). If we extend it (which makes mid term also sense for Kaapana) I would go for URIs and avoid any custom specification for different datasources and protocols. I think it is the minimal invasive and well standardized. DICOM could be covered the via DICOMWeb requests.

Apr 4 2023, 9:15 AM · MITK (v2022.10)
kislinsk updated subscribers of T29160: [Segmentation] Worklist specification, data structure and io functions.
  • l think it will be important to make it possible to work with the inputs defined by DICOM UIDs and available through DICOM endpoints, instead of relying purely on file system. Would this be acceptable for your use cases?
Apr 4 2023, 8:10 AM · MITK (v2022.10)

Apr 3 2023

fedorov added a comment to T29160: [Segmentation] Worklist specification, data structure and io functions.

Thanks. Here are some more comments to start the discussion:

  • l think it will be important to make it possible to work with the inputs defined by DICOM UIDs and available through DICOM endpoints, instead of relying purely on file system. Would this be acceptable for your use cases?
  • In addition to segmentations, it would be helpful to include an option to perform the review of existing segmentations (e.g., those generated by AI that need to be QA'd by an expert, and where some kind of segmentation may or may not be generated as part of the QA process)
  • I think there is potentially common needs between this task and the "MetaDashboard" initiative in kaapana (see https://projectweek.na-mic.org/PW38_2023_GranCanaria/Projects/MetaDashboard/) - should these two efforts be coordinated? In that regard, the definition of the worklist does not need to be limited to support of the segmentation task (e.g., there are other tasks already considered in the context of the MetaDashboard, such as series type classification, presence of the artifacts.
Apr 3 2023, 6:23 PM · MITK (v2022.10)
a178n added a comment to T29497: Full support for all subtasks.

Pushed new branch to rMITK MITK: feature/T29497-totalseg-subtasks-support.

Apr 3 2023, 5:08 PM · MITK
kalali added a revision to T29403: [mxn multi widget] Concept for crosshair data type: Unknown Object (Differential Revision).
Apr 3 2023, 12:40 PM · MITK (v2023.04)
kalali added a revision to T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized: Unknown Object (Differential Revision).
Apr 3 2023, 11:33 AM · MITK (v2023.04)
s434n committed rMITKfc6a61b982a3: Fix some bugs in MxN crosshairscorrectly enable/disable crosshairs and fix… (authored by s434n).
Fix some bugs in MxN crosshairscorrectly enable/disable crosshairs and fix…
Apr 3 2023, 10:30 AM
s434n committed rMITK382c8cfb7894: correctly enable/disable crosshairs and fix crosshair rendering on inverted… (authored by s434n).
correctly enable/disable crosshairs and fix crosshair rendering on inverted…
Apr 3 2023, 10:30 AM

Apr 2 2023

a178n added a revision to T29508: Replace QmitkDataStorageComboBox widget SingleNodeSelectionWidget.: Unknown Object (Differential Revision).
Apr 2 2023, 7:59 PM · MITK (v2023.04)

Mar 31 2023

wiesenfa added a comment to T29361: [external] Seed does not have an effect on bootstrap samples.

Or we just forbid parallelization with windows... Parallelization of R in Windows is such a series of workarounds....

Mar 31 2023, 3:38 PM · challengeR
eisenman added a comment to T29361: [external] Seed does not have an effect on bootstrap samples.

Great @wiesenfa! The test with doRNG passed on Windows and Ubuntu!

Mar 31 2023, 3:29 PM · challengeR
wiesenfa added a comment to T29361: [external] Seed does not have an effect on bootstrap samples.

using doRNG might be the best version should work on any OS

Mar 31 2023, 3:10 PM · challengeR
wiesenfa added a comment to T29361: [external] Seed does not have an effect on bootstrap samples.

Oh I HATE it!
Could you please try (first installing package "doRNG" https://cran.r-project.org/web/packages/doRNG/index.html ):

Mar 31 2023, 3:05 PM · challengeR
aekavur attached a referenced file: F2634972: BS_win2.png.
Mar 31 2023, 2:25 PM · challengeR
aekavur attached a referenced file: F2634971: BS_win1.png.
Mar 31 2023, 2:25 PM · challengeR
s434n closed T29297: [mxn multi widget] Optimize data accessibility inside render windows as Resolved.
Mar 31 2023, 11:47 AM · MITK (v2023.04)
s434n removed a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29298: [mxn multi widget] Add context menu to render window specific data inspector.
Mar 31 2023, 11:45 AM · MITK (v2023.04)
s434n removed a parent task for T29298: [mxn multi widget] Add context menu to render window specific data inspector: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Mar 31 2023, 11:45 AM · MITK
s434n removed a parent task for T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized: T29297: [mxn multi widget] Optimize data accessibility inside render windows.
Mar 31 2023, 11:45 AM · MITK (v2023.04)
s434n removed a subtask for T29297: [mxn multi widget] Optimize data accessibility inside render windows: T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized.
Mar 31 2023, 11:45 AM · MITK (v2023.04)
s434n renamed T29299: [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized from [mxn multi widget] Allow drag 'n drop in render window specific data inspector to [mxn multi widget] drag 'n drop in render window specific data inspector does not work when synchronized.
Mar 31 2023, 11:44 AM · MITK (v2023.04)