Page MenuHomePhabricator
Feed Advanced Search

Nov 15 2022

floca added a comment to T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash.

Is this reason for a patch release?

Nov 15 2022, 8:27 PM · MITK
floca updated the task description for T29390: How to ease the handling of external generated segmentations.
Nov 15 2022, 8:26 PM · MITK (v2024.06)
floca created T29390: How to ease the handling of external generated segmentations.
Nov 15 2022, 8:12 PM · MITK (v2024.06)
floca added a comment to T29389: Python utility module.

That would also help to avoid problems like T29388

Nov 15 2022, 8:01 PM · MITK (v2024.06)
floca created T29389: Python utility module.
Nov 15 2022, 8:00 PM · MITK (v2024.06)
floca added a comment to T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash.

The seg predicate of the view is wrong. Should not be able to select the nifti at all.

Nov 15 2022, 7:55 PM · MITK
kalali added a comment to T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash.

I added a first fix to avoid crashes. More changes are required:
Inside QmitkSegmentationView::UpdateGUI() the two functions m_Controls->layersWidget->UpdateGUI() and m_Controls->labelsWidget->UpdateGUI() are called. They both require the working image to be a LabelSetImage, otherwise the GUI elements will stay deactivated. Also, since no layer is available the toolselectionboxes stay deactivated.

Nov 15 2022, 6:31 PM · MITK
kalali added a revision to T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash: Restricted Differential Revision.
Nov 15 2022, 6:27 PM · MITK
kalali added a project to T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash: Request for Discussion.
Nov 15 2022, 5:53 PM · MITK
kalali updated subscribers of T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash.
Nov 15 2022, 5:53 PM · MITK
kalali triaged T29388: [Segmentation] Loading a nifti segmentation (nii) leads to a crash as Unbreak Now! priority.
Nov 15 2022, 5:52 PM · MITK

Nov 11 2022

kalali added a revision to T29385: [mxn multi widget] Pixel value view does not change on crosshair selection: Restricted Differential Revision.
Nov 11 2022, 6:58 PM · MITK (v2023.04)
kalali triaged T29386: [mxn multi widget] StdDisplay unnecessarily uses the crosshair manager as Normal priority.
Nov 11 2022, 5:23 PM · MITK (v2024.06)
kalali updated the task description for T29385: [mxn multi widget] Pixel value view does not change on crosshair selection.
Nov 11 2022, 11:06 AM · MITK (v2023.04)

Nov 10 2022

kalali renamed T29385: [mxn multi widget] Pixel value view does not change on crosshair selection from [mxn to [mxn multi widget] Pixel value view does not change on crosshair selection.
Nov 10 2022, 6:10 PM · MITK (v2023.04)
kalali created T29385: [mxn multi widget] Pixel value view does not change on crosshair selection.
Nov 10 2022, 6:09 PM · MITK (v2023.04)
kalali added a revision to T29383: [mxn multi widget] Crosshair does not show a gap: Restricted Differential Revision.
Nov 10 2022, 6:09 PM · MITK

Nov 9 2022

kalali triaged T29383: [mxn multi widget] Crosshair does not show a gap as Normal priority.
Nov 9 2022, 7:57 PM · MITK
neher placed T26413: Nifti2 support up for grabs.
Nov 9 2022, 11:38 AM · Auto-closed, Missing Info, MITK
neher added a comment to T26413: Nifti2 support.

Unfortunately not solved. Same error.

Nov 9 2022, 11:37 AM · Auto-closed, Missing Info, MITK
kalali updated the task description for T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations.
Nov 9 2022, 9:36 AM · Breaking Change, Noteworthy, MITK

Nov 8 2022

kalali claimed T28989: [Segmentation] CanHandle functions seem to be inconsistent.
Nov 8 2022, 5:56 PM · MITK, Request for Discussion
kalali added a comment to T28989: [Segmentation] CanHandle functions seem to be inconsistent.

mitk::Tool::CanHandle:

In T28989, @kalali wrote:

The basic mitk::Tool restricts the data that can be handled to reference-data - working-data pairs, where

  • the reference-data is valid

Why is it not required for the working-data to be valid? This is a requirement for all following CanHandle-functions (working data needs to be an mitk::LabelSetImage or an mitk::Image) that override the basic function, so why not put it in the basic class function?

Nov 8 2022, 5:56 PM · MITK, Request for Discussion
kalali added a revision to T28989: [Segmentation] CanHandle functions seem to be inconsistent: Restricted Differential Revision.
Nov 8 2022, 5:56 PM · MITK, Request for Discussion
kalali updated the task description for T28989: [Segmentation] CanHandle functions seem to be inconsistent.
Nov 8 2022, 5:25 PM · MITK, Request for Discussion
kalali updated the task description for T28989: [Segmentation] CanHandle functions seem to be inconsistent.
Nov 8 2022, 5:21 PM · MITK, Request for Discussion
kalali updated the task description for T28989: [Segmentation] CanHandle functions seem to be inconsistent.
Nov 8 2022, 5:21 PM · MITK, Request for Discussion
kalali edited projects for T28989: [Segmentation] CanHandle functions seem to be inconsistent, added: MITK; removed MITK (v2022.10).
Nov 8 2022, 5:11 PM · MITK, Request for Discussion
kislinsk closed T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash as Resolved by committing rMITKb2928e2b2dc5: Uninitialize slices interpolator when render window part is deactivated.
Nov 8 2022, 5:04 PM · MITK
kalali updated subscribers of T27413: MITK Workflow Q&A.

@kompan and I created this guide some time ago. We can reuse it, extend it and put the content into the Phabricator wiki: https://hub.dkfz.de/f/7173768

Nov 8 2022, 4:42 PM · MITK, Request for Discussion
kalali updated the task description for T27413: MITK Workflow Q&A.
Nov 8 2022, 4:42 PM · MITK, Request for Discussion
kalali edited projects for T29140: [Selection widget] Optional selection can not be removed if a fitting node is always found, added: MITK, Next Milestone, Request for Discussion; removed MITK (v2022.10).
Nov 8 2022, 4:27 PM · MITK (v2024.06), Request for Discussion
kalali renamed T27413: MITK Workflow Q&A from MITK 2020 Workflow Q&A to MITK Workflow Q&A.
Nov 8 2022, 4:27 PM · MITK, Request for Discussion
kalali edited projects for T29313: Add a Test to check if the GrowCut algorithm produces a different output, added: MITK; removed MITK (v2022.10).
Nov 8 2022, 4:12 PM · MITK (v2024.06)
kalali added a revision to T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations: Restricted Differential Revision.
Nov 8 2022, 12:48 PM · Breaking Change, Noteworthy, MITK
kalali claimed T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations.
Nov 8 2022, 12:48 PM · Breaking Change, Noteworthy, MITK
kalali added a comment to T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations.

It seems as if there is a mapping between the SliceNavigationController::ViewDirection and PlaneGeometry::PlaneOrientation, which makes it unnecessary to keep the direction / orientation in both classes.

Nov 8 2022, 12:47 PM · Breaking Change, Noteworthy, MITK
kislinsk added a revision to T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash: Restricted Differential Revision.
Nov 8 2022, 5:27 AM · MITK
kislinsk added a comment to T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash.

Shortcut to reproduce the crash:

  • Start the Workbench
  • If not already opened, open the Segmentation View
  • Close the project or close the Standard Display
  • Load any segmentation
Nov 8 2022, 5:15 AM · MITK

Nov 7 2022

kalali edited projects for T26959: [Segmentation] Newly created LabelSet segmentation is not displayed as "outline binary", added: MITK, Next Milestone; removed MITK (v2022.10).
Nov 7 2022, 7:12 PM · MITK (v2024.06), Checklist, Request for Discussion
kalali edited projects for T29163: [XNAT] Opening XNAT session fails, added: MITK; removed MITK (v2022.10).
Nov 7 2022, 7:10 PM · MITK (v2024.06)
kalali edited projects for T25057: Check IContextMenuActions and extension points, added: MITK; removed MITK (v2022.10).
Nov 7 2022, 7:10 PM · MITK (v2024.06)
kalali closed T29220: StatusBar info is dependent on the pointer position, not on the crosshair / mouse click as Resolved.

All related tasks have been resolved so we can close this task as well. The "issue" still remains but we are exploiting it on purpose now using the changes made in {D686}, to show pixel information dynamically (position under the mouse cursor) in the status bar.
With the changes made in {D749} we now have the possibility to explicitly show image pixel information for the crosshair position in the newly introduced pixel value view.

Nov 7 2022, 3:06 PM · Request for Discussion, MITK
kalali created T29381: Move Multilabel classes to Core module.
Nov 7 2022, 1:36 PM · MITK, Request for Discussion
kislinsk added a comment to T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash.

The interesting part here is that m_Time of mitk::BaseController is not supposed to be nullptr in particular as m_Slice is a valid stepper. My first guess is that a partly deconstructed controller is triggered here.

Nov 7 2022, 12:32 PM · MITK
kislinsk added a comment to T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash.

The crash happens in mitk::SliceNavigationController::GetSelectedTimeStep() as m_Time (mitk::Stepper::Pointer) is accessed while it is a nullptr. The events that lead to this situation are that the mitk::ToolManager notifies QmitkSlicesInterpolator via OnToolManagerWorkingDataModified(). This method calls SetCurrentContourListID() in turn, which executes the crashing line of code:

Nov 7 2022, 12:29 PM · MITK
kislinsk triaged T29380: [Segmentation] Loading a segmentation while the Segmentation View is open may lead to a crash as High priority.
Nov 7 2022, 12:08 PM · MITK
kalali added a comment to T29025: Preference service (access) based on cpp microservices.

I stumbled upon this while working on T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module. I would like to tackle this issue and already started looking into this. Do you already have an idea how to approach it or do we want to discuss it next week?

I already implemented most of it as core service a while ago but then was interrupted by something else. As far as I remember it is nearly complete except for the equivalent of BlueBerry's preference storage. I will look for the branch the upcoming week and push it. Never assigned the task, sorry.

Nov 7 2022, 11:38 AM · MITK (v2023.04), Breaking Change

Nov 6 2022

kislinsk claimed T29025: Preference service (access) based on cpp microservices.

I stumbled upon this while working on T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module. I would like to tackle this issue and already started looking into this. Do you already have an idea how to approach it or do we want to discuss it next week?

Nov 6 2022, 2:25 PM · MITK (v2023.04), Breaking Change

Nov 4 2022

kalali added a project to T29027: Move NodeSelectionWidgets to QtWidgets module: Next Milestone.
Nov 4 2022, 6:07 PM · MITK (v2023.04)
kalali added a comment to T29027: Move NodeSelectionWidgets to QtWidgets module.

Required for T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module / T27133: [Segmentation] Is QmitkDataSelectionWidget needed anymore?.

Nov 4 2022, 6:07 PM · MITK (v2023.04)
kalali added a comment to T29025: Preference service (access) based on cpp microservices.

I stumbled upon this while working on T28752: [Segmentation] Move Segmentation utilities widgets to SegmentationUI module. I would like to tackle this issue and already started looking into this. Do you already have an idea how to approach it or do we want to discuss it next week?

Nov 4 2022, 6:06 PM · MITK (v2023.04), Breaking Change

Nov 2 2022

s434n added a comment to T28578: [mxn multi widget] Optimization of the mxn multi widget.

Deleted branch from rMITK MITK: feature/T28578-MxN-development.

Nov 2 2022, 10:56 AM · MITK

Oct 31 2022

a178n added a comment to T29379: MONAI Label REST Response JSON issues, allegedly.
  1. The relevance of the labels list outside models? Perhaps, this entry can be used to describe all labels and their label ids used in the host app. And, models can then refer to label ids in their respective labels entries.
Oct 31 2022, 9:38 AM · MITK
a178n added a comment to T29379: MONAI Label REST Response JSON issues, allegedly.
  1. Lack of consistency in models->labels entries. For some models eg. deepedit there are label ids along with names, effectively assuming a Map datatype and for others, eg. deepgrow_2d it's a list. of label names. This creates unnecessary corner cases while parsing using strongly typed languages, like C++.
Oct 31 2022, 9:31 AM · MITK
a178n added a comment to T29379: MONAI Label REST Response JSON issues, allegedly.
  1. There is no indication in the JSON on which models are interactive click guided, scribble guided or automatic. Eg. Deepedit can be interactive click-guided or automatic, GMM+GraphCut is scribble guided, Segmentation Spleen is purely automatic. Hence, the JSON parameter type can be made more consistent for easy grouping.
Oct 31 2022, 9:26 AM · MITK
a178n updated the task description for T29379: MONAI Label REST Response JSON issues, allegedly.
Oct 31 2022, 9:25 AM · MITK
a178n triaged T29379: MONAI Label REST Response JSON issues, allegedly as Normal priority.
Oct 31 2022, 9:21 AM · MITK

Oct 29 2022

kislinsk edited the content of Changelog.
Oct 29 2022, 10:14 AM · MITK
kislinsk renamed T29375: Cursor offset in 2D tools with Qt 5.15 on macOS from Cursor offset in 2D tools with Qt 5.12 on macOS to Cursor offset in 2D tools with Qt 5.15 on macOS.
Oct 29 2022, 12:21 AM · MITK (v2023.04)

Oct 28 2022

kislinsk closed T29377: 2022 Week 43 (Late October) as Resolved.
Oct 28 2022, 5:23 PM · MITK
kislinsk added a comment to T29377: 2022 Week 43 (Late October).

Deleted branch from rMITK MITK: release/T29377-2022-Week-43.

Oct 28 2022, 5:22 PM · MITK
kislinsk edited the content of Changelog.
Oct 28 2022, 5:17 PM · MITK
kislinsk closed T29324: Create view for pixel information as Resolved.
Oct 28 2022, 5:14 PM · MITK
kislinsk closed T29324: Create view for pixel information, a subtask of T25042: How to handle update informations in heterogeneous time geometries and out of bound situations , as Resolved.
Oct 28 2022, 5:14 PM · MITK
kislinsk added a revision to T29324: Create view for pixel information: Restricted Differential Revision.
Oct 28 2022, 5:14 PM · MITK
kislinsk added a comment to T29377: 2022 Week 43 (Late October).

Pushed new branch to rMITK MITK: release/T29377-2022-Week-43.

Oct 28 2022, 10:07 AM · MITK
kislinsk triaged T29377: 2022 Week 43 (Late October) as Normal priority.
Oct 28 2022, 10:05 AM · MITK

Oct 26 2022

kislinsk renamed T29375: Cursor offset in 2D tools with Qt 5.15 on macOS from [Segmentation] Cursor offset in 2D tools with Qt 5.12 on macOS to Cursor offset in 2D tools with Qt 5.12 on macOS.
Oct 26 2022, 6:28 PM · MITK (v2023.04)
floca updated the task description for T29374: [SEG] Instant visual response to inverted state of tools (add, substract, paint, wipe).
Oct 26 2022, 10:37 AM · MITK (v2024.06)
floca triaged T29374: [SEG] Instant visual response to inverted state of tools (add, substract, paint, wipe) as Normal priority.
Oct 26 2022, 9:22 AM · MITK (v2024.06)

Oct 25 2022

kislinsk added a comment to T29371: [Registration] Improve view icons.

Hm, I disagree. :-)

Oct 25 2022, 5:24 PM · MITK
kislinsk edited projects for T29371: [Registration] Improve view icons, added: MITK; removed MITK (v2022.10).
Oct 25 2022, 2:47 PM · MITK

Oct 24 2022

kislinsk added a comment to T29370: How to use external packages for dependencies?.

These variables need to point to the location where CMake's find_package() will find the packages. For example, for ITK it would need to point to the equivalent of the MITK-superbuild/ep/lib/cmake/ITK-5.2 folder, where the ITKConfig.cmake and ITKConfigVersion.cmake files are located.

Oct 24 2022, 12:04 PM · MITK
yurivict added a comment to T29370: How to use external packages for dependencies?.

With -DEXTERNAL_ITK_DIR=/usr/local it still downloads and builds ITK.

Oct 24 2022, 5:14 AM · MITK
kislinsk closed T29370: How to use external packages for dependencies? as Resolved.

The superbuild has advanced variables for that:

  • EXTERNAL_ITK_DIR
  • EXTERNAL_HDF5_DIR
  • EXTERNAL_BOOST_ROOT
Oct 24 2022, 4:58 AM · MITK

Oct 23 2022

yurivict created T29370: How to use external packages for dependencies?.
Oct 23 2022, 11:14 PM · MITK

Oct 21 2022

kislinsk closed T28936: [Segmentation] Remove utilities redundancy with MultiLabelSegmentation, a subtask of T28176: [Segmentation] Inspection of module and plugin, as Resolved.
Oct 21 2022, 6:00 AM · MITK (v2024.06)

Oct 20 2022

kalali added a revision to T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty: Restricted Differential Revision.
Oct 20 2022, 6:40 PM · MITK (v2023.12), Request for Discussion
kalali added a comment to T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty.

If D744 is landed, we can close this task. The issue will be addressed here: T29369: [Segmentation Utilities] Handle / select different labels independently.

Oct 20 2022, 6:40 PM · MITK (v2023.12), Request for Discussion
kalali triaged T29369: [Segmentation Utilities] Handle / select different labels independently as Normal priority.
Oct 20 2022, 6:38 PM · MITK (v2024.06)
kalali added a comment to T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty.

With {D744} we only have a single Segmentation Utilities view. Labels operation should be added to this and then the issue of this task needs to be considered.

Oct 20 2022, 12:37 PM · MITK (v2023.12), Request for Discussion
kalali renamed T27809: [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty from [Multilabel Segmentation] "Labels" tabs in operations of Utilities view is empty to [Segmentation Utilities] "Labels" tabs in operations of Utilities view is empty.
Oct 20 2022, 12:36 PM · MITK (v2023.12), Request for Discussion

Oct 17 2022

kalali renamed T29333: [mxn multi widget] Measurements / planar figure not working from [mxn multi widet] Measurements / planar figure not working to [mxn multi widget] Measurements / planar figure not working.
Oct 17 2022, 4:44 PM · MITK (v2024.06)
kalali renamed T29365: [mxn multi widget] Pointset interaction not working from [mxn multi widet] Pointset interaction not working to [mxn multi widget] Pointset interaction not working.
Oct 17 2022, 4:44 PM · MITK (v2024.06)
kalali edited projects for T29333: [mxn multi widget] Measurements / planar figure not working, added: MITK, Next Milestone; removed MITK (v2022.10).
Oct 17 2022, 4:39 PM · MITK (v2024.06)
kalali triaged T29365: [mxn multi widget] Pointset interaction not working as Normal priority.
Oct 17 2022, 4:39 PM · MITK (v2024.06)
kalali added a subtask for T28578: [mxn multi widget] Optimization of the mxn multi widget: T29364: [mxn multi widget] Image navigator cannot be used.
Oct 17 2022, 4:37 PM · MITK
kalali added a parent task for T29364: [mxn multi widget] Image navigator cannot be used: T28578: [mxn multi widget] Optimization of the mxn multi widget.
Oct 17 2022, 4:37 PM · MITK (v2024.06)
kalali triaged T29364: [mxn multi widget] Image navigator cannot be used as Normal priority.
Oct 17 2022, 4:29 PM · MITK (v2024.06)
kalali updated the task description for T29303: IGT classes do not work correctly with the new mxn multi widget.
Oct 17 2022, 3:17 PM · MITK (v2024.06)
kalali closed T26545: [Multi widget] Make classes work with QmitkAbstractMultiWidget(Editor), a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 17 2022, 3:16 PM · MITK
kalali closed T26376: Segmentation plugin does not work correctly with the new mxn multi widget, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 17 2022, 2:42 PM · MITK
kalali added a project to T29335: [Segmentation] Show interactive warning for uninitialized render window geometry: Next Milestone.
Oct 17 2022, 2:42 PM · MITK (v2023.04)
kalali edited projects for T29240: [mxn multi widget] Allow different time navigation controller for each individual render window, added: MITK, Next Milestone; removed MITK (v2022.10).
Oct 17 2022, 2:40 PM · MITK (v2024.06)
kalali closed T29328: Fix different issues with re-initialization, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 17 2022, 2:19 PM · MITK

Oct 14 2022

kalali removed a parent task for T26543: Enum for AXIAL, SAGITTAL, CORONAL 3D/ORIGINAL/NONE is provided at many different locations: T25595: [Multi widget] Make classes work with the new render window access.
Oct 14 2022, 1:10 PM · Breaking Change, Noteworthy, MITK
kalali closed T29203: [Multi widget] Make classes work with the new render window names, a subtask of T28578: [mxn multi widget] Optimization of the mxn multi widget, as Resolved.
Oct 14 2022, 10:48 AM · MITK

Oct 13 2022

kalali triaged T29362: [mxn multi widget] Plane suggestion of QmitkSlicesInterpolator does not work correctly as Normal priority.
Oct 13 2022, 3:58 PM · Request for Discussion, MITK (v2023.04)
kalali closed T29331: Use NodePredicates for the render window data node selector, a subtask of T29297: [mxn multi widget] Optimize data accessibility inside render windows, as Resolved.
Oct 13 2022, 2:02 PM · MITK (v2023.04)