Reordered palette from above to see similar colors next to each other to simulate the worst case:
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Mar 31 2022
Mar 30 2022
Mar 29 2022
Since all colors in the widget are tuned to be in front of a white background I explicitly set the help search results background to be white.
I already started to implement a new plugin generator (T27701) but it still is delayed because of priority reasons. When the plugin generator is back, step 9 should be revised/fixed.
A fix for this bug is available here: https://github.com/Alfred-Franz/MITK/tree/T28585-Included_inheritence (thanks to @kannberg!). However, I did not create a pull request yet because the plugin generator as used in tutorial step 9 should be completely replaced by the project template (see discussion in T27701). This means that tutorial step 9 will have to be completely revised, which would probably be quite a bit of work. But I think especially the example code for using a region grower in this tutorial step is worth to keep it.
I used the opportunity to get rid of some unused legacy classes and properties regarding volume visualization. According to our minimum requirements of the rendering backend, I removed the rendering mode combobox (GPU vs CPU) as we can assume capable GPUs. The blend mode combobox is now labeled and its items are fully spelled.
Current to dos to provide an MITK perfusion/modelFit installer:
- Unit tests
- Determine test coverage (T30195)
- Unit tests for debug parameter images (T30196)
Was mentioned again in the current testing cycle by other testers.
Regarding the comment of closing the contour with a double click: I also realized this during my work on the new add tool and I think the way I fixed it was to modify the OnFinish() function in the mitkLiveWireTool2D to check whether the click was performed on the first point which was also how it was done before the closure contour was added to the LiveWire tool.
Here is the code of my new add tool branch where I changed it:
https://phabricator.mitk.org/source/mitk/browse/feature%252FT28464-new-add-tool-2/Modules/Segmentation/Interactions/mitkLiveWireTool2D.cpp$344
Mar 28 2022
This is my shot at it mainly based on the palettes above with extra effort regarding neighboring color contrasts (top-left to bottom-right). But it is impossible to get 25 perfectly distinguishable colors. Also I took into account that the human eye has the highest sensitivity in the green spectrum.
Kelly is nice because it is not overly saturated as most other palettes, but I think the most useful is indeed glasbey, when the two black-ish and one grey-ish colors are removed for our context. Red and magenta both appears pretty similar twice. Also, the colors should be a reordered a little bit and for the sake of compatibility/expectations start with red. More or less the same for polychrome but there we would also need to get rid of more grey colors.
I procrastinated on the colors tonight for quite some time and finally found something that really stood out - the standard distinguishable color palettes of R:
Same for F2 regarding renaming of labels. I would also say double-click, but as it turned out, double-click is already used to jump to the center of the label.
The first two comments should be targeted for this release. The last comment is something that also happens sometimes with the new implementation of the polygon tool that uses the same base class. But fixing is too complex to be worth spending time before the release, so whoever grabs this task, focus on the first two comments.
All checklists have been refactored and used again for testing MITK 2022.04.
Some issues with the checklists still exist, so I will use this task to fix these for the upcoming release:
It is not worth currently to spend much time on this so I fixed it as fast as possible by syncing the default colors instead of creating a single source of truth. This code location was barely touched in the past decade and I don't see why this would receive suddenly much more attention than that.
Deleted branch from rMITK MITK: bugfix/T28777-DefaultDecorationColors.
Pushed new branch to rMITK MITK: bugfix/T28777-DefaultDecorationColors.
MultiLabel Checklists have been removed and the content has been merged into the basic segmentation checklists (because of T28142: [Segmentation] Remove plugin redundancy with MultiLabelSegmentation).
Only the ML Utilities checklist exists so I will close this task.
Also, as reported by @s434n , the decoration colors in the Image Navigator only update after there was a render window update / click in one of the render windows.
Pushed new branch to rMITK MITK: feature/T29066-after-hackathon-changes.
Deleted branch from rMITK MITK: bugfix/T29072-VariousSegmentationViewFixes.
Deleted branch from rMITK MITK: feature/T29059-nnUnet-monomodal-bugfix.
Pushed new branch to rMITK MITK: bugfix/T29072-VariousSegmentationViewFixes.
Deleted branch from rMITK MITK: bugfix/T29070-CreatePolygonModelCrashes.
Pushed new branch to rMITK MITK: bugfix/T29070-CreatePolygonModelCrashes.
Mar 25 2022
Pushed new branch to rMITK MITK: feature/T29059-nnUnet-monomodal-bugfix.
This is due to the change in the plugin ID . MultiLabel Segmentation View does not exist any more.