thank you for your contribution. Before merging your pull request we need you to sign off you commits: http://mitk.org/wiki/Sign_off_contribution

@neher
https://github.com/MITK/MITK/pull/205

I'm closing this one. The segmentation plugin was fixed by @kalali & friends. Other plugins that rely on IZombieViewPart should have the same error (QmitkFunctionality's activated/deactivated was mapped directly which does now different things), but we will open separate tasks for them.

I sent a new PR and closed the previous one.

I have to allow an epsilon difference for rounding error, but it is not enough, it still crashes when the volume is rotated around two world axes by 45 degrees. I get a matrix that I thought is invalid but it is not.

Our tests failed. :-(

Thanks! 👍

Pushed new branch T22971-MissingRenderWindowUpdate.

Pushed new branch T19825-PullRequestIntegration.

What's the result? :)

All the geometry tests of MITK pass on Linux, although probably there is not a test for this special case.

https://github.com/MITK/MITK/pull/201

Pushed new branch T22970-RetrieveCTKLocationsViaBerryPlatform.

Pushed new branch T19559-PullRequestMasterIntegration.

Pushed new branch T19559-PullRequestIntegration.

Can someone just explain how to use this patch. I am fairly new to MITK and would be very thankful for an explanation!

A new PR: https://github.com/MITK/MITK/pull/199

+1

You are totally right, this PR can't change anything because there's already a Modified() called just before. Furthermore, I can't even reproduce my own bug! My callbacks are now called as they should. I'm not sure what happened :| I'll convince myself that something related changed in MITK 2016.11 but I doubt it ^^

In T19683#100896, @goyette wrote:

• Never modify node without BaseData.

I can't say I have the solution to that problem, but here's anyway what I would do:

• Never modify node without BaseData.
• If "Show helper objects" is checked: hide them too
• otherwise, don't.

Pushed new branch T22829-Qml.

Thanks for the contribution.

Thanks for the contribution.

I am hesitant to integrate this pull request. I can understand the concern regarding invisible planes and agree that that should be solved. However just making all helper objects visible by default overshoots that target in my opinion.

Haha, oups, as you can see, I didn't actually remember what I did :)

Erm, I was mostly looking at the pull request you linked and that one just adds an unneeded line in

void mitk::LookupTableProperty::SetValue(const ValueType &value)

I agree that there's a Modified() in LookupTableProperty but the bug is related to ColorProperty. You know your code base much more than me so maybe these properties are super related and I'm not aware of it but... why is LookupTableProperty relevant?

Hum, looking at it right now, I agree that it looks random :) I know that I tried doing the simple way (like goch's snippet) in the "logical" places but it wasn't working. I don't remember why though so I'll try again and keep you updated.

Seems to build and test fine. Thanks for the contribution.

Seems to build and test fine. Thanks for the contribution.

I'm with Caspar here. This is a typical floating point precision issue which would preferably be resolved by using something like std::min() and std::max() when assigning lower/upper values.

Pushed new branch T22843-external-context-menu-icons.

The fix seems very random to me. Instead of just dividing the lower threshold by two , would it not be better to catch and correct the error at the place mentioned above?

Pushed new branch T22810-Add-tolerance-to-surfacetoimagefilter.

This should not be necessary, as there already is a Modified that is called:

Pushed new branch T22820-const-getters-for-fiber-bundles.

PR: https://github.com/MITK/MITK/pull/198

Thanks for the hint. It turned out in the end that the default cubic interpolation simply messed with labels on the rotated view planes...

Maybe the rotation matrix is not set for the clipping plane? Just guessing...

Thanks for the clarification, that explains the rotation of course. We are having problems with some other tools (e.g. with the clipping plane plugin) that came up just in these cases with (permuted) non-unity matrices. Apparently, that is then unrelated with these fixes.

What do you think is wrong? It looks correct to me.

In some cases, the fix leads to unexpected results (see attached). That is, re-init / global re-inits cause image rotations.@Miklos, maybe you have an idea where to start fixing this issue?

Finally, a new, improved and shinny PR: https://github.com/MITK/MITK/pull/196

It took me a while but I tested a little more and:

• Forget my PR, it's not good enough. It was a wonderful fix for OS X (the menus are unusable without my fix) but it doesn't fix the next point
• There are visual glitches on Windows too. (Probably linux too), let me explain.

Quickfixed Segmentation plugin. Need to investigate further.

Pushed new branch T22572-Fixes.

I updated the PR because the limit was applied only in one of the undo models. (The verbose undo model overrode the function in which the superclass applied the limit.)

Thank you! 👍

Something for the Bug Squashing Party tomorrow, thank you! 👍

For reference the pull request:
https://github.com/MITK/MITK/pull/187

Pushed new branch T22603-EigenIncludeDirFix.

Okay, thank you! We keep that in mind.

Pushed new branch T22602-UmlautsInDataManager.

In T22602#96071, @maleike wrote:

I think my pull request does not worsen the current state but slightly improves on name editing in Data Manager. So it could be integrated regardless of further encoding cleanups.

Thank you @aurelien! 👍

@maleike What's the status. Should we merge the PR for now or wait for more fixes?

👍

Pushed new branch T22610-DitinguishBetweenMissingHelpPagesAndMissingHelpContext.

@neher

T22572-no-common-legacy

👍

In T22607#96129, @kislinsk wrote:

@maleike Did you add your Email address associated with the commit to your Email addresses here on Phabricator?

@maleike Did you add your Email address associated with the commit to your Email addresses here on Phabricator?

In T19825#70270, @wegner wrote:

added and signed off pull request iwegner:bug-19825-SegFault_in_IGTTrackingToolbox_pluigin

https://github.com/MITK/MITK/pull/135