Pushed new branch T11113-TinySliceGeometries.

Pushed new branch T22774-UndoLimit.

T23990: Changing render window layout mess up Qt layout

Cool. The menus were impossible to use on OS X. However, I suggest that you reopen this issue. I tested master to check if the other problem that was explained in my 3-05-2017 post was solved. It affects all OSes. From my tests, it's still a problem. It might be considered minor but:

Hahaha, dammit, yes, I meant T22065. Not sure what happened :) I copied my post in the right issue. Thank you.

@goyette I assume you meant to add this comment to T23248, T22929, T23985 or most likely T22065? I do not see a connection to this task?

Cool. The menus were impossible to use on OS X. However, I suggest that you reopen this issue. I tested master to check if the other problem that was explained in my 3-05-2017 post was solved. It affects all OSes. From my tests, it's still a problem. It might be considered minor but:

• it's still a bug
• I already posted a solution 4 months ago, it might be useful to use it

Most probably resolved by the overall fixing of the MITK rendering on macOS.

Sure thing!

I think you are right, that they are too specifically tailored to your use case to reasonably include in the as-is very general purpose segmentation plug-in. We might reconsider if we encounter those specfic use cases ourselves in the future and want an adapted segmentation for that. However we are grateful for you sharing your tool and making it available for others who might indeed have the same requirements.

1. The main advantages of Threshold Components is to allow placing multiple seed points, and adjusting the locations of the seed points during the process. The underlying algorithm is otherwise similar to Region Growing. I created a new tool because I didn't want to interfere with existing tools, but it is certainly feasible to add these features into the existing tool (if you think they would be useful).
2. Pruning removes protuberances only of width 1 pixel. The rationale for pruning is that Morphological Opening, even at the smallest radius, ends up deleting much of my segmentations. Pruning cleans up the noise slightly without affecting the wanted regions. (I agree that the effect of Pruning is small - it is meant to be coupled with Thinning to skeletonize the object first, but that would be even more destructive.) There is much room for a middle-ground that is gentler than Opening and more forceful than Pruning.

I had a look at the new tools today. There was a compile error that I resolved and some issues:

Pushed new branch T22654-threshold-components-tool.

Thanks for the contribution

Pushed new branch T22699-multilabelsegmentation-preferences-crash.

Thanks for the contribution.

Pushed new branch T22870-fix-threshold-crash.

Seems reasonable. I am not too hot on the highlight color, but it is a definite improvement over no color at all.

Pushed new branch T23295-gizmo-track-and-highlight.

Merged.
@maleike are my changes working for you?

Pushed new branch T23317-color-on-multi-selection.

Just a quick note:

QList<QAction *> QmitkNodeDescriptorManager::GetActions(const mitk::DataNode *_Node) const

will return all actions for all applicable descriptors, whereas

QList<QAction *> QmitkNodeDescriptorManager::GetActions(const QList<mitk::DataNode::Pointer> &_Nodes) const

will only return all actions for the last applicable descriptor.

Ok, the reason seems to be that

QmitkNodeDescriptor *QmitkNodeDescriptorManager::GetDescriptor(const mitk::DataNode *_Node) const

returns a "NoneBinaryImage" nodes descriptor instead of an "Image" node descriptor. When I add that descriptor to

void QmitkDataManagerView::CreateQtPartControl(QWidget* parent)

The color button appears.

The changes seem reasonable for me, but the button does not appear if multiple Pic3Ds are loaded and selected, I am going to check out why.

In T23292#109426, @goch wrote:

There are still a couple of entries that will not be sorted, as they are specifically added by the datamanager itself.

But the suggested solution is better than the current way.

Pushed new branch T23292-enable-context-menu-sorting.

There are still a couple of entries that will not be sorted, as they are specifically added by the datamanager itself.

This seems reasonable to me, although it might result in separating thematically similar actions, which might have been closer together when registered the previous way. In general that should probably not be a problem.

I pushed 2 new commits because I received a bug report from one of my user who told me he sometimes had strange result in fullscreen. Since then, no problem on any OS so I think it's safe to look at this PR.

@maleike
I did not and it does. Gouraud and Phong result in a black object for me, Flat has the proper color.

In T11113#108062, @goch wrote:

However the displayed surface remains solid black for me despite changes in the rendering properties

I can confirm that Daniels fix will work on the current master and will show something in 3D. Also it will no longer crash when doing a reinit on the surface.

Code/Pull request available here: https://github.com/MITK/MITK/pull/209

@jernejf is suggest you to use WinMerge to apply the patch on your Mitk source tree.

Thank you! 👍

Pushed new branch T23086-BoostWarningC4172.

I wanted to open new tasks for the individual plugins that need a similar fix as the segmentation plugin, so that we can track the progress.

Pushed new branch T23055-StdVectorInSetMacro.

Ok, I have created a new pull request:

Hi, please create a new pull request and open a new branch for it in your repo instead of working on your master branch. This is the most easy way for us to merge your contribution. Thank you!

Hello Peter,

thank you for your contribution. Before merging your pull request we need you to sign off you commits: http://mitk.org/wiki/Sign_off_contribution

@neher
https://github.com/MITK/MITK/pull/205

I'm closing this one. The segmentation plugin was fixed by @kalali & friends. Other plugins that rely on IZombieViewPart should have the same error (QmitkFunctionality's activated/deactivated was mapped directly which does now different things), but we will open separate tasks for them.

I sent a new PR and closed the previous one.

I have to allow an epsilon difference for rounding error, but it is not enough, it still crashes when the volume is rotated around two world axes by 45 degrees. I get a matrix that I thought is invalid but it is not.

Our tests failed. :-(

Thanks! 👍

Pushed new branch T22971-MissingRenderWindowUpdate.

Pushed new branch T19825-PullRequestIntegration.

What's the result? :)

All the geometry tests of MITK pass on Linux, although probably there is not a test for this special case.

https://github.com/MITK/MITK/pull/201

Pushed new branch T22970-RetrieveCTKLocationsViaBerryPlatform.

Pushed new branch T19559-PullRequestMasterIntegration.

Pushed new branch T19559-PullRequestIntegration.

Can someone just explain how to use this patch. I am fairly new to MITK and would be very thankful for an explanation!

A new PR: https://github.com/MITK/MITK/pull/199

+1

You are totally right, this PR can't change anything because there's already a Modified() called just before. Furthermore, I can't even reproduce my own bug! My callbacks are now called as they should. I'm not sure what happened :| I'll convince myself that something related changed in MITK 2016.11 but I doubt it ^^

In T19683#100896, @goyette wrote:

• Never modify node without BaseData.

I can't say I have the solution to that problem, but here's anyway what I would do:

• Never modify node without BaseData.
• If "Show helper objects" is checked: hide them too
• otherwise, don't.

Pushed new branch T22829-Qml.