Page MenuHomePhabricator
Feed All Stories

May 8 2020

kalali added a comment to T27259: Render windows are not updated when last time step is selected.

Hm, yeah I guess that was our original problem, mentioned in the referenced task. So it might be that we never did it right because we could never really inspect the behavior sadface

May 8 2020, 11:01 AM · Cleared, MITK (v2021.02)
floca added a project to T27201: [Registration] Executor layout in mask box is broken: Cleared.
May 8 2020, 11:01 AM · Restricted Project, Cleared, MITK (v2021.02)
floca added a project to T27209: [Registration] Mapper does not allow to select ML segmentation as input: Cleared.
May 8 2020, 11:00 AM · Cleared, MITK (v2021.02)
floca added a project to T27176: MITK - DICOM Seg - load created files: Missing Info.

Has to be checked if the problem still exists in the master. It could be already solved due to T27322: [DICOM reader] DICOM image reader should only read dicom files from a directory that are in the same image block like the selected file.. Please verify.

May 8 2020, 10:58 AM · Missing Info, MITK (v2021.02)
floca closed T27152: DICOM editor not fully migrated to new CTK version as Resolved.

Fixed in 009c43134f77 when I did T27322: [DICOM reader] DICOM image reader should only read dicom files from a directory that are in the same image block like the selected file..

May 8 2020, 10:53 AM · MITK (v2021.02)
eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

I can do that. I already checked with 2018.4.0. In this version it's possible to select a third time step only by moving the time slider (not the spin box buttons), but for the third time steps it's showing the volume of the first.

May 8 2020, 10:51 AM · Cleared, MITK (v2021.02)
floca added a project to T25702: DICOM sort fails for RWV modality: Missing Info.
May 8 2020, 10:48 AM · MITK (v2021.02), Restricted Project
floca added a project to T27043: Refactor ModelFit and Pharmacokinetics plugins to use new selection concept: Cleared.
May 8 2020, 10:47 AM · Cleared, MITK (v2021.02)
floca added a project to T27046: Segmentation View and Multilabel Segmentation must not be active together (toolmanager inconsistency): Cleared.
May 8 2020, 10:47 AM · Cleared, MITK (v2021.02)
floca added a project to T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View: Cleared.
May 8 2020, 10:46 AM · MITK (v2023.04), Restricted Project
floca lowered the priority of T27269: PlanarCircle shrinks in size when moved towards image boundaries from High to Low.

Curently you can workarround by moving the control point (e,g, for size) to the other side, so that it does not hit the boundary.

May 8 2020, 10:45 AM · MITK (v2024.06)
kalali added a comment to T27259: Render windows are not updated when last time step is selected.

Ok thanks, then I would like to test the data with an old installer (e.g. 2016) to see if we ever did it correctly.

May 8 2020, 10:43 AM · Cleared, MITK (v2021.02)
floca added a project to T27308: [statistics] Statistics with segmentations are not automatically updated if segmentation is changed.: Cleared.
May 8 2020, 10:41 AM · Cleared, MITK (v2021.02)
eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

I checked with the MultiVolumeExplorer module of 3D Slicer: A third volume is shown which is different from the other two volumes.

May 8 2020, 10:40 AM · Cleared, MITK (v2021.02)
kalali added a project to T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected: Cleared.
May 8 2020, 10:40 AM · MITK (v2021.10), Cleared
nolden edited projects for T25702: DICOM sort fails for RWV modality, added: MITK (v2021.02); removed MITK.

I'm currently trying to get access to the relevant data again.

May 8 2020, 10:39 AM · MITK (v2021.02), Restricted Project
kalali added a project to T27067: ImageCropper cannot crop some images (4d?): Cleared.
May 8 2020, 10:36 AM · MITK
kalali added a project to T26979: Error when loading a measurement or pointset and then an image: Cleared.
May 8 2020, 10:36 AM · Request for Discussion, Cleared, MITK (v2021.02)
kalali added a project to T27259: Render windows are not updated when last time step is selected: Missing Info.
May 8 2020, 10:35 AM · Cleared, MITK (v2021.02)
kalali added a project to T27266: [Image Statistics] Planar figures cannot be read or written until one of the quantification views is open: Cleared.
May 8 2020, 10:35 AM · Cleared, MITK (v2021.02)
kalali added a project to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed: Cleared.
May 8 2020, 10:35 AM · Cleared, MITK (v2021.02)
kislinsk added a project to T27196: Rewrite packaging of MITK: Cleared.
May 8 2020, 10:35 AM · MITK (v2024.06), Cleared
kislinsk created Cleared.
May 8 2020, 10:20 AM
eisenman created T27385: Variables holding the aggregated value are named differently for single- and multi-task challenges.
May 8 2020, 9:42 AM · challengeR (v1.0)
kalali lowered the priority of T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected from Normal to Low.
May 8 2020, 9:31 AM · MITK (v2021.10), Cleared
kalali added a comment to T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected.

I tested this and I can confirm that the segmentation-node will be deselected but the parent node stays selected in my case!

May 8 2020, 9:31 AM · MITK (v2021.10), Cleared
kalali updated the task description for T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected.
May 8 2020, 9:29 AM · MITK (v2021.10), Cleared
eisenman moved T27281: Implement tests for ranking method "rank-then-aggregate" from In Progress to Done on the challengeR (v1.0) board.
May 8 2020, 9:27 AM · challengeR (v1.0)
eisenman committed rCHALLENGERb5bc0bd63d1e: Merge branch 'feature/T27281-AddTestsForRankThenAggregate' into develop (authored by eisenman).
Merge branch 'feature/T27281-AddTestsForRankThenAggregate' into develop
May 8 2020, 9:25 AM
eisenman updated the task description for T27281: Implement tests for ranking method "rank-then-aggregate".
May 8 2020, 8:58 AM · challengeR (v1.0)
kalali added a comment to T26979: Error when loading a measurement or pointset and then an image.

I just ran into this error (on Windows) unexpectedly by doing the following:

  1. load ImageStatistics/testimage.dcm
  2. remove the image node
  3. load Pic3D
  4. -> Error in PlaneGeometry::CheckBounds(const BoundingBox::BoundsArrayType &bounds)
May 8 2020, 8:54 AM · Request for Discussion, Cleared, MITK (v2021.02)
eisenman committed rCHALLENGER504369bbe47d: Test that rank-then-aggregate raises error for unused NA treatment argument in… (authored by eisenman).
Test that rank-then-aggregate raises error for unused NA treatment argument in…
May 8 2020, 8:53 AM
eisenman committed rCHALLENGER1adb7afe1fbe: Test that rank-then-aggregate assigns worst rank for NA in multi-task challenge (authored by eisenman).
Test that rank-then-aggregate assigns worst rank for NA in multi-task challenge
May 8 2020, 8:53 AM
eisenman committed rCHALLENGER1d3b1e3263bb: Test that rank-then-aggregate by mean works for multi-task challenge with no… (authored by eisenman).
Test that rank-then-aggregate by mean works for multi-task challenge with no…
May 8 2020, 8:53 AM

May 7 2020

nolden committed rMITK1780784feb8e: Fixed Qt test invocation (authored by nolden).
Fixed Qt test invocation
May 7 2020, 8:52 PM
nolden committed rMITKf06596f70f8d: Fixed Qt test invocation (authored by nolden).
Fixed Qt test invocation
May 7 2020, 8:52 PM
nolden triaged T27383: Update external toolkits as High priority.
May 7 2020, 4:12 PM · Noteworthy, MITK (v2021.02)
norajitr added a comment to T27085: 2D region growing tool fails for low intensity regions.

Done (pm)

May 7 2020, 2:41 PM · Cleared, MITK (v2021.02)
floca added projects to T24710: Check failing dicom data in MITK-Data: Restricted Project, Missing Info.

@kalali: As nobody has claimed the task and no new comment emerged, I would say "no".
As the next step is fairly simple:

May 7 2020, 1:58 PM · DICOM, Restricted Project, MITK
nolden added a comment to T27085: 2D region growing tool fails for low intensity regions.

Does the MITK team have access rights on the NAKO dataset? Then I would suggest an example from there.

May 7 2020, 1:58 PM · Cleared, MITK (v2021.02)
eisenman updated subscribers of T27281: Implement tests for ranking method "rank-then-aggregate".
May 7 2020, 1:56 PM · challengeR (v1.0)
eisenman committed rCHALLENGER9a54ff52841b: Test that rank-then-aggregate raises error for unused NA treatment argument (authored by eisenman).
Test that rank-then-aggregate raises error for unused NA treatment argument
May 7 2020, 1:40 PM
norajitr added a comment to T27085: 2D region growing tool fails for low intensity regions.

do you know when this stopped working?

The error was first noticed recently while working with clinical partners on MRI lung data from the NAKO. I checked the old installer from 2015, where it also did not work.

or someone else: is there an example image in MITK Data to show this behavior?

I could not find a suitable lung example in MITK Data. I checked on two old lung MRI datasets in the department, where the problem did not occur.

May 7 2020, 1:33 PM · Cleared, MITK (v2021.02)
nolden added a revision to T27367: Graphical unit tests fail on some linux setups: Unknown Object (Differential Revision).
May 7 2020, 1:26 PM · MITK (v2021.02)
neher closed T27318: Make IVIM first D&f and then D* fit default as Resolved.
May 7 2020, 1:14 PM · MITK Diffusion
neher committed rMITKDIFF32e83db18f77: Merge branch 'T27318-IvimFit' (authored by neher).
Merge branch 'T27318-IvimFit'
May 7 2020, 12:20 PM
neher committed rMITKDIFFdb7fceebbfb0: Fix IVIM b-zero threshold crash (authored by neher).
Fix IVIM b-zero threshold crash
May 7 2020, 12:20 PM
neher added a comment to T27318: Make IVIM first D&f and then D* fit default.

Pushed new branch T27318-IvimFit.

May 7 2020, 12:20 PM · MITK Diffusion
kalali updated subscribers of T26979: Error when loading a measurement or pointset and then an image.

mitk::ExtractSliceFilter::GenerateOutputInformation() generates the bounds of the itk object. There are some values that need to be inspected:

xMin = 0
xMax = 512
yMin = 0
yMax = 0

So subsequently

// currently the unit rectangle must be starting at the origin [0,0]
assert(bounds[0] == 0);
assert(bounds[2] == 0);
// the unit rectangle must be two-dimensional
assert(bounds[1] > 0);
assert(bounds[3] > 0);

in PlaneGeometry::CheckBounds(const BoundingBox::BoundsArrayType &bounds) fails.

May 7 2020, 10:56 AM · Request for Discussion, Cleared, MITK (v2021.02)
nolden committed rMITKa93a881e0170: Make linux headless UI testing more configurable (authored by nolden).
Make linux headless UI testing more configurable
May 7 2020, 10:42 AM
nolden committed rMITKeaa893583df1: Moved XVFB testing configuration to superbuild (authored by nolden).
Moved XVFB testing configuration to superbuild
May 7 2020, 10:42 AM
nolden committed rMITKe95eb8546215: Make linux headless UI testing more configurable (authored by nolden).
Make linux headless UI testing more configurable
May 7 2020, 10:42 AM
kislinsk added a comment to T24710: Check failing dicom data in MITK-Data.

+1

May 7 2020, 10:21 AM · DICOM, Restricted Project, MITK
kalali added a comment to T26981: [Segmentation] Multiple Segmentations under one parent node aren't displayed.

I just found out the following:

  • perform both steps as written in the description
  • change the layer of one of the two segmentations such that one segmentation is on the same layer as the parent node (the other segmentation should still have a layer above the parent node),

e.g. from

ParentNode: Layer 4
 Segmentation1: Layer 5
 Segmentation2: Layer 7

to

ParentNode: Layer 4
 Segmentation1: Layer 5
 Segmentation2: Layer 4
  • see how both segmentations are visible with overlapping area
May 7 2020, 10:13 AM · Cleared, MITK (v2021.02)
kalali added a comment to T24710: Check failing dicom data in MITK-Data.

@floca Any progress here? This also happened often with real data from partners and is really annoying because the error message is somewhat unspecific.
I would also like to see this fixed for MITK 2020.

May 7 2020, 10:00 AM · DICOM, Restricted Project, MITK
kalali merged T23561: Upload simulated dicom data as one time series using dicom Reader v2 into T24710: Check failing dicom data in MITK-Data.
May 7 2020, 9:59 AM · DICOM, Restricted Project, MITK
kalali merged task T23561: Upload simulated dicom data as one time series using dicom Reader v2 into T24710: Check failing dicom data in MITK-Data.
May 7 2020, 9:59 AM

May 6 2020

kislinsk updated the image for Missing Info from F1576941: profile to F1577278: fa-tags-red.png.
May 6 2020, 11:31 PM
neher triaged T27381: Add fiber weighting to coloring in processing view as Wishlist priority.
May 6 2020, 8:55 PM · MITK Diffusion
nolden triaged T27379: Set up Ubuntu 20.04 CI clients as High priority.
May 6 2020, 4:59 PM · Cleared, Restricted Project, MITK (v2021.02)
nolden closed T25497: Auto-loading of module MitkDICOMQIIO fails in tests as Resolved.

Tests don't fail anymore

May 6 2020, 3:19 PM · MITK
nolden set the image for Missing Info to F1576941: profile.
May 6 2020, 3:14 PM
kislinsk added a project to T27085: 2D region growing tool fails for low intensity regions: Missing Info.
May 6 2020, 3:12 PM · Cleared, MITK (v2021.02)
kislinsk changed hashtags for Missing Info, added #needs_info; removed #needs-info.
May 6 2020, 3:11 PM
kislinsk created Missing Info.
May 6 2020, 3:11 PM
nolden added a comment to T27085: 2D region growing tool fails for low intensity regions.

@norajitr or someone else: is there an example image in MITK Data to show this behavior?
@norajitr do you know when this stopped working?

May 6 2020, 2:43 PM · Cleared, MITK (v2021.02)
kalali lowered the priority of T27258: [Image statistics] Deprecate QmitkImageStatisticsCalculationJob from Normal to Low.
May 6 2020, 2:29 PM · MITK (v2024.06)
kalali lowered the priority of T27134: [Image statistics] Refactor Calculation Job and Calculation Runnable from Normal to Low.
May 6 2020, 2:29 PM · Auto-closed, MITK
kalali renamed T26970: [Segmentation] Picking tool: When no region is picked, selected node just gets unselected from [Segmentation] Picking tool: When no region is picked, selected not just gets unselected to [Segmentation] Picking tool: When no region is picked, selected node just gets unselected.
May 6 2020, 2:26 PM · MITK (v2021.10), Cleared
kislinsk renamed T27152: DICOM editor not fully migrated to new CTK version from BlueBerry CustomViewer (Spartan Viewer) not migrated to new CTK version to DICOM editor not fully migrated to new CTK version.
May 6 2020, 2:23 PM · MITK (v2021.02)
kislinsk raised the priority of T27152: DICOM editor not fully migrated to new CTK version from Normal to High.
May 6 2020, 2:22 PM · MITK (v2021.02)
kislinsk raised the priority of T27067: ImageCropper cannot crop some images (4d?) from Normal to High.
May 6 2020, 2:20 PM · MITK
nolden created T27377: Suppress or fix all build warnings .
May 6 2020, 1:55 PM · MITK (v2024.06), Restricted Project
eisenman committed rCHALLENGER198bad540faa: Test that rank-then-aggregate assigns worst rank for NA (authored by eisenman).
Test that rank-then-aggregate assigns worst rank for NA
May 6 2020, 2:51 AM

May 5 2020

floca added a revision to T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule: Unknown Object (Differential Revision).
May 5 2020, 9:46 PM · MITK (v2021.02), Restricted Project
eisenman committed rCHALLENGERf60d0985d851: Fix typos (authored by eisenman).
Fix typos
May 5 2020, 6:11 PM
eisenman committed rCHALLENGER18de4e5695fc: Test that rank-then-aggregate by mean works with one algorithm for one case (authored by eisenman).
Test that rank-then-aggregate by mean works with one algorithm for one case
May 5 2020, 6:11 PM
eisenman committed rCHALLENGER78d58ceca193: Test that rank-then-aggregate by median works with two algorithms for two cases (authored by eisenman).
Test that rank-then-aggregate by median works with two algorithms for two cases
May 5 2020, 6:11 PM
eisenman committed rCHALLENGERe9405ec64ed9: Test that rank-then-aggregate by mean works with two algorithms for two cases (authored by eisenman).
Test that rank-then-aggregate by mean works with two algorithms for two cases
May 5 2020, 6:11 PM
eisenman committed rCHALLENGER47d56c0d3611: Test that rank-then-aggregate handles ties for two algorithms and one case (authored by eisenman).
Test that rank-then-aggregate handles ties for two algorithms and one case
May 5 2020, 4:54 PM
eisenman committed rCHALLENGER7125d260a662: Test that rank-then-aggregate raises error for invalid aggregation function (authored by eisenman).
Test that rank-then-aggregate raises error for invalid aggregation function
May 5 2020, 4:48 PM
eisenman committed rCHALLENGER79075d89859b: Test that rank-then-aggregate by mean works with two algorithms for one case (authored by eisenman).
Test that rank-then-aggregate by mean works with two algorithms for one case
May 5 2020, 4:42 PM
eisenman claimed T27281: Implement tests for ranking method "rank-then-aggregate".
May 5 2020, 4:10 PM · challengeR (v1.0)
nolden added a revision to T27367: Graphical unit tests fail on some linux setups: Restricted Differential Revision.
May 5 2020, 4:10 PM · MITK (v2021.02)
gaoh removed a member for wDB: hentsch.
May 5 2020, 3:54 PM
kislinsk removed a member for wDB: kislinsk.
May 5 2020, 3:54 PM
gaoh added a member for wDB: kislinsk.
May 5 2020, 3:52 PM
kalali added a comment to T27319: [Segmentation] Correctly implement interpolation features for Multilabel Segmentation View.

For MITK 2020 I would remove them since it doesn't seem feasible with time constraints (so change task to wishlist and change title to implement interpolation).

May 5 2020, 11:31 AM · MITK (v2023.04), Restricted Project
kalali added a comment to T27085: 2D region growing tool fails for low intensity regions.

Is there some rough estimate when this bug was introduced?

May 5 2020, 11:30 AM · Cleared, MITK (v2021.02)
floca closed T27368: Improve const correctness support of FastSinglePixelAccess as Resolved.
May 5 2020, 10:59 AM · MITK (v2021.02)
floca moved T27043: Refactor ModelFit and Pharmacokinetics plugins to use new selection concept from Backlog to Perfusion on the MITK (v2021.02) board.
May 5 2020, 10:56 AM · Cleared, MITK (v2021.02)
floca moved T27339: Provide public MITK ModelFit installer on a regular basis from Backlog to Perfusion on the MITK (v2021.02) board.
May 5 2020, 10:56 AM · MITK (v2024.06)
floca committed rMITKc328328b7a5b: Improved const correctness of PixelAccess methods (authored by floca).
Improved const correctness of PixelAccess methods
May 5 2020, 10:54 AM
floca committed rMITKe85918df1ace: fixed review remarks (authored by floca).
fixed review remarks
May 5 2020, 10:54 AM
kompan added a revision to T27373: ModelFit: Generate absolute curve data: Unknown Object (Differential Revision).
May 5 2020, 9:43 AM · Restricted Project, MITK
kompan triaged T27373: ModelFit: Generate absolute curve data as Normal priority.
May 5 2020, 9:14 AM · Restricted Project, MITK

May 4 2020

floca moved T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule from Segmentation to DICOM SEG on the MITK (v2021.02) board.
May 4 2020, 11:27 PM · MITK (v2021.02), Restricted Project
floca moved T27369: [Dcipher] Possibility to save Dicom segmentation objects instead of .nrrd and send those ideally directly to the platform from Backlog to DICOM SEG on the MITK (v2021.02) board.
May 4 2020, 11:26 PM · MITK (v2021.02)
floca created T27372: DataNode uses itkCloneMacro(Self) but does not implement a clone method.
May 4 2020, 8:25 PM · Cleared, Noteworthy, MITK (v2021.02)
nolden edited projects for T27367: Graphical unit tests fail on some linux setups, added: MITK (v2021.02); removed MITK.

Ok, on fedora there is a newer xvfb version which includes a new option for a more robust choice of a suitable display number which seems to fix the issue for me.

May 4 2020, 2:46 PM · MITK (v2021.02)