Page MenuHomePhabricator
Feed All Stories

Sep 24 2021

patmjen added a comment to T28706: Cannot build module DataTypesExt becasue lz4 is not linked by CMake.

Thank you very much for your quick response.

Sep 24 2021, 3:14 PM · MITK (v2021.10)
kislinsk updated subscribers of T28706: Cannot build module DataTypesExt becasue lz4 is not linked by CMake.
Sep 24 2021, 9:31 AM · MITK (v2021.10)
kislinsk added a comment to T28706: Cannot build module DataTypesExt becasue lz4 is not linked by CMake.

Oh, I think I might have found the issue. Ignore the comment above and in CMake/Findlz4.cmake please add lib64 to the PATH_SUFFIXES of the two calls to find_library() in lines 11 and 18 like PATH_SUFFIXES lib lib64. Does it work?

Sep 24 2021, 9:30 AM · MITK (v2021.10)
kislinsk claimed T28706: Cannot build module DataTypesExt becasue lz4 is not linked by CMake.
Sep 24 2021, 9:25 AM · MITK (v2021.10)
kislinsk triaged T28706: Cannot build module DataTypesExt becasue lz4 is not linked by CMake as High priority.

Thanks for the comprehensive report. Can you do me a favor and add message(FATAL_ERROR "include dirs: ${lz4_INCLUDE_DIR} libraries: ${lz4_LIBRARIES}") as last line to CMake/PackageDepends/MITK_lz4_Config.cmake and configure MITK (not superbuild) to get the output?

Sep 24 2021, 9:25 AM · MITK (v2021.10)

Sep 23 2021

kalali closed T24358: Rework QmitkMouseModeSwitcher, a subtask of T24356: Rework mouse mode switcher, as Resolved.
Sep 23 2021, 10:01 PM · MITK
kalali closed T24358: Rework QmitkMouseModeSwitcher as Resolved.
Sep 23 2021, 10:01 PM · MITK
kalali committed rMITK9fc6d9258f4e: Clean usage of QmitkInteractionSchemeToolBar and InteractionSchemeSwitcher (authored by kalali).
Clean usage of QmitkInteractionSchemeToolBar and InteractionSchemeSwitcher
Sep 23 2021, 9:58 PM
kalali committed rMITK99775c5afe86: Remove member variable and create new variable on demand (authored by kalali).
Remove member variable and create new variable on demand
Sep 23 2021, 9:58 PM
kalali committed rMITKa4b63edd857b: Do not set the interaction scheme (authored by kalali).
Do not set the interaction scheme
Sep 23 2021, 9:58 PM
kalali committed rMITK556fc11aef9c: Do not explicitly set the visibility of the tool bar (authored by kalali).
Do not explicitly set the visibility of the tool bar
Sep 23 2021, 9:58 PM
kalali committed rMITK8e756e71766c: Remove unnecessary function, member and header (authored by kalali).
Remove unnecessary function, member and header
Sep 23 2021, 9:58 PM
patmjen created T28706: Cannot build module DataTypesExt becasue lz4 is not linked by CMake.
Sep 23 2021, 3:45 PM · MITK (v2021.10)
kalali awarded T26485: [Segmentation] PACS mode is active while segmentation is drawn a Party Time token.
Sep 23 2021, 2:39 PM · MITK (v2021.10)
s434n closed T26485: [Segmentation] PACS mode is active while segmentation is drawn as Resolved.

With both subtasks done, we have successfully implemented the main goal of this task. The remaining bug that deactivating a segmentation tool resets the interaction to an earlier state (the one at which the tool was activated) has been split off into T28630 because it is not critical and can be easily handled with the new feature of deactivating PACS tools.

Sep 23 2021, 11:51 AM · MITK (v2021.10)
s434n committed rMITKe7f6648cd685: Correct handling of PACS mode when using ImageCropper (authored by s434n).
Correct handling of PACS mode when using ImageCropper
Sep 23 2021, 10:56 AM
s434n closed T28629: [ImageCropper] PACS mode is active while bounding box is drawn as Resolved by committing rMITKe7f6648cd685: Correct handling of PACS mode when using ImageCropper.
Sep 23 2021, 10:56 AM · MITK (v2021.10)
s434n committed rMITK6974be056a90: remove unused print statements (authored by s434n).
remove unused print statements
Sep 23 2021, 10:56 AM
s434n committed rMITK216b2b1041da: generalize disabling/enabling crosshair to PACS scheme (authored by s434n).
generalize disabling/enabling crosshair to PACS scheme
Sep 23 2021, 10:56 AM
s434n committed rMITK090557c6d3d6: handle DisplayActionEventBroadcasts in disabling/enabling of crosshair (authored by s434n).
handle DisplayActionEventBroadcasts in disabling/enabling of crosshair
Sep 23 2021, 10:56 AM

Sep 19 2021

kalali added a revision to T24358: Rework QmitkMouseModeSwitcher: Unknown Object (Differential Revision).
Sep 19 2021, 6:29 PM · MITK
kalali reassigned T24368: Interaction scheme has different level of interaction from kalali to s434n.
Sep 19 2021, 6:26 PM · MITK
kalali added a comment to T24368: Interaction scheme has different level of interaction.

We discussed this and came to the conclusion to abandon D535.
@s434n will take over and create split MITK config files to be consistent with the PACS config file style.
Generally, as mentioned in the previous comment, splitting the config files "into smaller chunks" [...] "allows to change only the aspects of interaction that are necessary".

Sep 19 2021, 6:26 PM · MITK

Sep 17 2021

kalali committed rMITK895486021524: Cherry-picked old changes: Remove-QmitkMouseModeSwitcher (authored by kalali).
Cherry-picked old changes: Remove-QmitkMouseModeSwitcher
Sep 17 2021, 4:03 PM
kalali committed rMITK181d3c4e3fab: Fix wrong slot definition; use new connect-syntax (authored by kalali).
Fix wrong slot definition; use new connect-syntax
Sep 17 2021, 4:03 PM
kalali committed rMITK4b84f9c383c9: Remove files (authored by kalali).
Remove files
Sep 17 2021, 4:03 PM
kalali committed rMITK0e9839351823: Modify replacing QmitkInteractionSchemeToolBar (authored by kalali).
Modify replacing QmitkInteractionSchemeToolBar
Sep 17 2021, 4:03 PM
kislinsk merged T28489: int64 not supported into T28557: Cannot load segmentations from KITS challenge due to unknown pixel type.
Sep 17 2021, 11:13 AM · MITK, Request for Discussion
kislinsk merged task T28489: int64 not supported into T28557: Cannot load segmentations from KITS challenge due to unknown pixel type.
Sep 17 2021, 11:13 AM · MITK

Sep 15 2021

kalali committed rMITK00f000b33f60: Do not request a rendering update twice (authored by kalali).
Do not request a rendering update twice
Sep 15 2021, 5:49 PM
kalali committed rMITK55d690677914: Do not request a rendering update twice (authored by kalali).
Do not request a rendering update twice
Sep 15 2021, 5:49 PM
kislinsk added a member for MIC: y033f.
Sep 15 2021, 4:46 PM
s434n added a revision to T28629: [ImageCropper] PACS mode is active while bounding box is drawn: Unknown Object (Differential Revision).
Sep 15 2021, 2:45 PM · MITK (v2021.10)
s434n merged task T28278: Image cropper doesn't work with PACS like mouse interaction into T28629: [ImageCropper] PACS mode is active while bounding box is drawn.
Sep 15 2021, 12:49 PM · Next Milestone, MITK
s434n merged T28278: Image cropper doesn't work with PACS like mouse interaction into T28629: [ImageCropper] PACS mode is active while bounding box is drawn.
Sep 15 2021, 12:49 PM · MITK (v2021.10)
kleina added a comment to T28489: int64 not supported.

True, I tried this. There is even a task for it: T28557

Sep 15 2021, 12:20 PM · MITK
kislinsk triaged T28691: AutoSegmentationWithPreviewTool tool manager won't support multithreading as Normal priority.
Sep 15 2021, 4:55 AM · MITK
kislinsk moved T28675: Boolean Operations in Segmentation utilities are slow from Backlog to Segmentation on the MITK (v2021.10) board.
Sep 15 2021, 4:54 AM · MITK (v2024.06), Request for Discussion
kislinsk triaged T28675: Boolean Operations in Segmentation utilities are slow as Normal priority.

This could be connected to the undo/redo implementation of MITK and the creation of difference images for the undo stack. I do not know your version of MITK but the use of LZ4 compression for difference images in the latest versions could already be the or part of the solution. I agree that the operations should be much faster but they might be already as fast as the python implementation so whoever is working on this task should clock the different parts of the operation first to see what is actually taking so long and as said, if it is still the case in the latest version of MITK.

Sep 15 2021, 4:54 AM · MITK (v2024.06), Request for Discussion
kislinsk added a subtask for T28521: multilabel segmentation add switch to disable contour: T28522: Segmentations are drawn differently depending on whether the segmentation tool is open or not.
Sep 15 2021, 4:49 AM · MITK (v2021.10)
kislinsk added a parent task for T28522: Segmentations are drawn differently depending on whether the segmentation tool is open or not: T28521: multilabel segmentation add switch to disable contour.
Sep 15 2021, 4:49 AM · Auto-closed, MITK
kislinsk triaged T28522: Segmentations are drawn differently depending on whether the segmentation tool is open or not as Low priority.

If it only affects the legacy segmentation type (not displayed as multilabel segmentation), it should be soon resolved with the segmentation refactoring anyway. I think a workaround for now could be to convert the legacy segmentation to a multilabel segmentation in MITK (Data Manager context menu?). This task is also potentially connected to T28521: multilabel segmentation add switch to disable contour.

Sep 15 2021, 4:49 AM · Auto-closed, MITK
kislinsk moved T28521: multilabel segmentation add switch to disable contour from Backlog to Segmentation on the MITK (v2021.10) board.
Sep 15 2021, 4:45 AM · MITK (v2021.10)
kislinsk triaged T28521: multilabel segmentation add switch to disable contour as Normal priority.

This is already possible in the Properties view but I guess it is a good candidate to be more accessible from within the segmentation view or preference page.

Sep 15 2021, 4:45 AM · MITK (v2021.10)
kislinsk triaged T28493: Multilabel color map colors are not very nice as Low priority.

I think I once looked into this specific issue and it turned out that your label values had quite some gaps between there values resulting in similar neighboring colors "by accident". Consecutive label values would be quite distinguishable. I am not sure if at least the first x colors follow a certain standard or not. This should be checked first before changing the colors.

Sep 15 2021, 4:43 AM · Checklist, Request for Discussion, MITK (v2022.04)
kislinsk triaged T28489: int64 not supported as Wishlist priority.

@kleina already tried to add int64 as supported image type but it didn't work out of the box AFAIK. In theory it should be enough to add the type to the MITK_ACCESSBYITK_INTEGRAL_PIXEL_TYPES CMake variable. If we would be able to make this work, compilation time and binary size would increase noticeably, though, because of the templated nature of ITK.

Sep 15 2021, 4:39 AM · MITK

Sep 14 2021

s349i added a comment to T28680: Build fails on Ubuntu 20.04. -Wold-style-cast error while compiling CppMicroServices.

Deleted branch from rMITK MITK: bugfix/T28680-removed-old-style-cast-error.

Sep 14 2021, 2:45 PM · MITK (v2021.10)
s349i committed rMITK8d9a15fef6d3: Remove a -Wold-style-cast flag from CppMicroServices (authored by s349i).
Remove a -Wold-style-cast flag from CppMicroServices
Sep 14 2021, 2:43 PM
s349i committed rMITK509c7939cec4: Remove a -Wold-style-cast flag from CppMicroServices (authored by s349i).
Remove a -Wold-style-cast flag from CppMicroServices
Sep 14 2021, 2:42 PM
s349i closed T28680: Build fails on Ubuntu 20.04. -Wold-style-cast error while compiling CppMicroServices as Resolved by committing rMITK509c7939cec4: Remove a -Wold-style-cast flag from CppMicroServices.
Sep 14 2021, 2:42 PM · MITK (v2021.10)
s349i added a revision to T28680: Build fails on Ubuntu 20.04. -Wold-style-cast error while compiling CppMicroServices: Unknown Object (Differential Revision).
Sep 14 2021, 2:27 PM · MITK (v2021.10)
s349i added a comment to T28680: Build fails on Ubuntu 20.04. -Wold-style-cast error while compiling CppMicroServices.

Pushed new branch to rMITK MITK: bugfix/T28680-removed-old-style-cast-error.

Sep 14 2021, 2:20 PM · MITK (v2021.10)
a178n added a comment to T28691: AutoSegmentationWithPreviewTool tool manager won't support multithreading.
  1. Exception Handling: leading to Segmentation fault and Workbench crash
Sep 14 2021, 11:43 AM · MITK
a178n added a comment to T28691: AutoSegmentationWithPreviewTool tool manager won't support multithreading.

I did some debugging and found some more insights into the situation and workarounds.

Sep 14 2021, 11:30 AM · MITK

Sep 13 2021

aekavur moved T28698: [dash] Finalize contact page strategy. from Backlog to In Progress on the webChallengeR board.
Sep 13 2021, 4:31 PM · webChallengeR
aekavur moved T28699: [dash] Test server configuration from Backlog to In Progress on the webChallengeR board.
Sep 13 2021, 4:31 PM · webChallengeR
aekavur claimed T28698: [dash] Finalize contact page strategy..
Sep 13 2021, 4:31 PM · webChallengeR
aekavur renamed T28699: [dash] Test server configuration from Test server configuration to [dash] Test server configuration.
Sep 13 2021, 4:30 PM · webChallengeR
aekavur created T28699: [dash] Test server configuration.
Sep 13 2021, 4:30 PM · webChallengeR
aekavur triaged T28698: [dash] Finalize contact page strategy. as Normal priority.
Sep 13 2021, 4:18 PM · webChallengeR
aekavur moved T28095: [dash] Develop landing page from In Progress to Done on the webChallengeR board.
Sep 13 2021, 4:12 PM · webChallengeR
aekavur moved T28100: [dash] Decide on a file management strategy from In Progress to Done on the webChallengeR board.
Sep 13 2021, 4:12 PM · webChallengeR
aekavur reopened T28100: [dash] Decide on a file management strategy as "Open".
Sep 13 2021, 4:12 PM · webChallengeR
aekavur closed T28100: [dash] Decide on a file management strategy as Resolved.

Following operations has been done:

Sep 13 2021, 4:09 PM · webChallengeR

Sep 10 2021

s434n added a comment to T24368: Interaction scheme has different level of interaction.

The proposed change goes kind of in the opposite direction of recent changes that were made, specifically in D531 and part of D532. If the approach of D535 is to be continued, it would need to take into account D532, in which an additional PACS scheme was introduced that leaves the left mouse button unused.
I would personally prefer the direction we have been taking now, splitting up the config files into smaller chunks. This reduces code redundancy, instead of having almost identical config files many times.
Also, in my opinion the approach of D531 makes a lot of sense for overlapping interactions. It allows to change only the aspects of interaction that are necessary while staying oblivious to the current interaction (MITK default, with swivel, PACS, ...). If we want to use full configs, one would need any variation of each scheme for each situation where alterations may be necessary. For example 2D segmentation tools require the left mouse button, so any possible interaction scheme needs to have a corresponding version where the left mouse button is unused. If a tool requires something new, like the right mouse button, new config files have to be implemented for every existing interaction scheme instead of just one file that will be appended.

Sep 10 2021, 3:59 PM · MITK
gaoh added a comment to T28600: Kaapana containerd version is 1.2.5 which is 2 years old: Need to update that.

so, this is what we have tried so far:
helm updated to 3.6
microk9s to 1.22
first problem: v1beta1 version cannot be used anymore --> changed to v1 in the repo
next problem: our treafik is not compatible anymore (with 1.22)

Sep 10 2021, 12:18 PM · Request for Discussion, Kaapana (internal)
reinkea added a member for BMC: gruber.
Sep 10 2021, 9:36 AM
m139l claimed T28600: Kaapana containerd version is 1.2.5 which is 2 years old: Need to update that.
Sep 10 2021, 9:31 AM · Request for Discussion, Kaapana (internal)
gaoh lowered the priority of T28529: Replace Elasticsearch and Kibana with apache-licensed opensearch from Normal to Low.
Sep 10 2021, 9:20 AM · Request for Discussion, Kaapana (internal)

Sep 9 2021

paul jaeger <p.jaeger@dkfz.de> committed rMDTPUBLIC4bdc81f09855: update readme (authored by paul jaeger <p.jaeger@dkfz.de>).
update readme
Sep 9 2021, 4:14 PM
paul jaeger <p.jaeger@dkfz.de> committed rMDTPUBLIC1373cb591343: update readme (authored by paul jaeger <p.jaeger@dkfz.de>).
update readme
Sep 9 2021, 4:13 PM

Sep 8 2021

kalali added a member for MIC: m907r.
Sep 8 2021, 4:17 PM
kalali lowered the priority of T26486: PACS mouse mode does not allow scrolling with mouse wheel from High to Normal.
Sep 8 2021, 3:42 PM · Breaking Change, MITK (v2021.10)
kalali updated subscribers of T26486: PACS mouse mode does not allow scrolling with mouse wheel.

We decided to talk to @nolden, @metzger or @reicht to learn more about the typical behavior of PACS scrolling. Could you help us here?
Two general questions:

  • in MITK you have to press the wheel and move the mouse to scroll through image slices
    • with this task / differential we change this behavior to simply use the mouse wheel to scroll through image slices
    • what is the typically expected PACS behavior?
Sep 8 2021, 3:42 PM · Breaking Change, MITK (v2021.10)
kalali added a member for MITK: m907r.
Sep 8 2021, 11:00 AM
a178n renamed T28691: AutoSegmentationWithPreviewTool tool manager won't support multithreading from AutoSegmentationWithPreviewTool tool manager calls won't support multi threading to AutoSegmentationWithPreviewTool tool manager won't support multi threading.
Sep 8 2021, 9:15 AM · MITK
a178n created T28691: AutoSegmentationWithPreviewTool tool manager won't support multithreading.
Sep 8 2021, 9:14 AM · MITK
kalali closed T24357: Rework mitkMouseModeSwitcher, a subtask of T24356: Rework mouse mode switcher, as Resolved.
Sep 8 2021, 8:03 AM · MITK
kalali closed T24357: Rework mitkMouseModeSwitcher as Resolved.
Sep 8 2021, 8:03 AM · MITK

Query Overheated

This query took too long, so only some results are shown. Learn More