Page MenuHomePhabricator

MITK (v2021.10)Milestone
ArchivedPublic

Recent Activity

Wed, May 11

kalali added a comment to T27711: Rename segmentation image selection label.

Deleted branch from rMITK MITK: bugfix/T27711-rename-image-selection-label.

Wed, May 11, 4:06 PM · MITK (v2021.10)

Nov 17 2021

kalali removed a project from T26989: [Checklist] GUI test data originates from different sources: Restricted Project.
Nov 17 2021, 5:38 PM · MITK (v2021.10)

Nov 10 2021

kislinsk archived MITK (v2021.10).
Nov 10 2021, 4:33 PM
kislinsk added a project to T28801: [MultiLabel Segmentation][Utilities] Exception thrown when converting to MultiLabel: Checklist.
Nov 10 2021, 4:29 PM · MITK (v2022.10), Checklist

Nov 9 2021

kislinsk added a comment to T28802: 2021 Week 45 (Early November).

Deleted branch from rMITK MITK: release/T28802-MITK-v2021.10.

Nov 9 2021, 5:47 AM · MITK (v2021.10)
kislinsk closed T28802: 2021 Week 45 (Early November) as Resolved.
Nov 9 2021, 5:46 AM · MITK (v2021.10)
kislinsk added a comment to T28802: 2021 Week 45 (Early November).

Deleted branch from rMITK MITK: release/T28802-2021-Week-45.

Nov 9 2021, 5:37 AM · MITK (v2021.10)
kislinsk closed T28799: [Segmentation] Multilable 3D tools crash when multiple layers/labels are generated. as Resolved by committing rMITK8562c6636ed4: T28799 Multilable 3D tools crash when multiple layers/labels are generated..
Nov 9 2021, 5:36 AM · MITK (v2021.10)
kislinsk updated the task description for T28802: 2021 Week 45 (Early November).
Nov 9 2021, 4:59 AM · MITK (v2021.10)
kislinsk renamed T28802: 2021 Week 45 (Early November) from MITK v2021.10 to 2021 Week 45 (Early November).
Nov 9 2021, 4:59 AM · MITK (v2021.10)
kislinsk added a comment to T28802: 2021 Week 45 (Early November).

Pushed new branch to rMITK MITK: release/T28802-2021-Week-45.

Nov 9 2021, 4:55 AM · MITK (v2021.10)
kislinsk added a comment to T28802: 2021 Week 45 (Early November).
Nov 9 2021, 4:52 AM · MITK (v2021.10)

Nov 3 2021

kislinsk lowered the priority of T28801: [MultiLabel Segmentation][Utilities] Exception thrown when converting to MultiLabel from High to Normal.

I lower the priority since the exception is caught and it results in an error message instead of a crash. It's also an academic edge case, since it hardly makes any sense in a real world scenario to convert an actual image with more than 65000 different pixel values into a segmentation. Converting binary images or segmentation-like images works as expected.

Nov 3 2021, 8:11 PM · MITK (v2022.10), Checklist
floca closed T28794: [Image Statistics] Crash when dynamic segmentation does not have a segmentation in the current time step as Resolved.
Nov 3 2021, 6:05 PM · MITK (v2021.10)
kalali updated the task description for T28650: [Selection concept] (Re)setting a data storage does not automatically check for matching nodes.
Nov 3 2021, 2:24 PM · MITK (v2021.10)

Nov 2 2021

kislinsk merged task T18866: Highlighting in View Navigator is not updated into T28819: [View Navigator] View Names don't become bold when opened.
Nov 2 2021, 8:33 PM · MITK (v2021.10), Restricted Project, Bugzilla
floca added a comment to T28794: [Image Statistics] Crash when dynamic segmentation does not have a segmentation in the current time step.

The problem is fixed by the diff. One can argue that the current solution for the histogramm widget (hide if timestep has no statistic) is not ideal from the UX perspective (very flickery).
But I think that is another problem. The question should be, why are no statistics container produced for empty masks? wouldn't make it more sense to produce a also for such time step a statistic, even if it is very trival as no pixel are evaluated.

Nov 2 2021, 5:43 PM · MITK (v2021.10)
floca added a revision to T28794: [Image Statistics] Crash when dynamic segmentation does not have a segmentation in the current time step: Restricted Differential Revision.
Nov 2 2021, 5:38 PM · MITK (v2021.10)
floca claimed T28794: [Image Statistics] Crash when dynamic segmentation does not have a segmentation in the current time step.
Nov 2 2021, 4:29 PM · MITK (v2021.10)
kalali renamed T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations from [MultiLabel Segmentation] Utilities view can not handle non-binary multilabel segmentations to [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations.
Nov 2 2021, 2:54 PM · MITK (v2022.10)
floca edited projects for T28794: [Image Statistics] Crash when dynamic segmentation does not have a segmentation in the current time step, added: MITK (v2021.10); removed MITK.
Nov 2 2021, 10:34 AM · MITK (v2021.10)

Oct 30 2021

kislinsk added a comment to T28801: [MultiLabel Segmentation][Utilities] Exception thrown when converting to MultiLabel.

The description of the actual but swallowed exception is "Prohibited image access: the requested image part is already in use and cannot be requested recursively!" thrown indirectly from line 315 in mitkLabelSetImage.cpp: AccessFixedDimensionByItk_n(), which eventually calls ImageToItkImage() in mitkImageToItk.h:132. There, the Update() call of the ImageToItk class throws the exception mentioned above,

Oct 30 2021, 12:32 AM · MITK (v2022.10), Checklist

Oct 29 2021

floca added a comment to T28799: [Segmentation] Multilable 3D tools crash when multiple layers/labels are generated..

Is this related / the same (because the second label is automatically selected and then the second layer has no second label)? T28131: [MultiLabel Segmentation] 3D Threshold tool does not work with multiple labels / layers

Oct 29 2021, 4:34 PM · MITK (v2021.10)
floca added a revision to T28799: [Segmentation] Multilable 3D tools crash when multiple layers/labels are generated.: Restricted Differential Revision.
Oct 29 2021, 4:30 PM · MITK (v2021.10)
floca renamed T28799: [Segmentation] Multilable 3D tools crash when multiple layers/labels are generated. from [Segmentation] Multilable 3D tools crashes when multiple layers/labels are generated. to [Segmentation] Multilable 3D tools crash when multiple layers/labels are generated..
Oct 29 2021, 4:29 PM · MITK (v2021.10)
floca added a comment to T28131: [MultiLabel Segmentation] 3D Threshold tool does not work with multiple labels / layers.

Was also meantioned several times be testers this week.

Oct 29 2021, 4:18 PM · Request for Discussion, MITK (v2022.04)
kislinsk added a comment to T28802: 2021 Week 45 (Early November).
Oct 29 2021, 4:15 PM · MITK (v2021.10)
kislinsk added a project to T28802: 2021 Week 45 (Early November): MITK-ProjectTemplate.
Oct 29 2021, 4:12 PM · MITK (v2021.10)
kislinsk added a comment to T28802: 2021 Week 45 (Early November).
Oct 29 2021, 4:11 PM · MITK (v2021.10)
kalali added a comment to T28799: [Segmentation] Multilable 3D tools crash when multiple layers/labels are generated..

Is this related / the same (because the second label is automatically selected and then the second layer has no second label)? T28131: [MultiLabel Segmentation] 3D Threshold tool does not work with multiple labels / layers

Oct 29 2021, 4:11 PM · MITK (v2021.10)
kislinsk triaged T28802: 2021 Week 45 (Early November) as Normal priority.
Oct 29 2021, 4:10 PM · MITK (v2021.10)
kalali triaged T28801: [MultiLabel Segmentation][Utilities] Exception thrown when converting to MultiLabel as High priority.
Oct 29 2021, 4:09 PM · MITK (v2022.10), Checklist
floca triaged T28799: [Segmentation] Multilable 3D tools crash when multiple layers/labels are generated. as Unbreak Now! priority.
Oct 29 2021, 3:54 PM · MITK (v2021.10)
floca added a project to T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem: Request for Discussion.
Oct 29 2021, 12:57 PM · MITK (v2022.04), Cleared
floca added a comment to T27637: [Segmentation] Multilabel label name dialog on label creation is a UX problem.

In the same line of reasoning (see discussion above). We could also remove the label name dialoge, when you add a new layer, couldn't we. In the current tests there was a remark, that when adding a new layer, you first are queried if you realy want to make a new layer and then you are asked for the label name...

Oct 29 2021, 12:57 PM · MITK (v2022.04), Cleared
kislinsk added a comment to T28207: MITK DicomBrowser q/r Retrieve part crash.

Just a ping because it was triggered by a checklist for the upcoming release.

Oct 29 2021, 11:50 AM · MITK (v2022.10), Checklist

Oct 28 2021

kalali added a comment to T28500: Multilabel Segmentation Utilities do not work for multilabel segmentations.

@isensee What exactly does not work?

  • Are you not able to load the data / ML nodes in the utilities selection widgets? That is a known bug and is addressed here: T28135
  • Are you not able to work with multiple labels at all? This is also a known problem, since the MultiLabel Utilities View was never correctly implemented for working with multiple labels.
Oct 28 2021, 11:46 AM · MITK (v2022.10), Missing Info
kalali renamed T28134: [Multilabel Segmentation] No warning triggered when using different mask geometries / dimensions in Utilities View from [Multilabel Segmentation] No warning triggered when using different mask geometries in Utilities View to [Multilabel Segmentation] No warning triggered when using different mask geometries / dimensions in Utilities View.
Oct 28 2021, 11:37 AM · MITK (v2022.10), Cleared
s349i added a comment to T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations.

Maybe @s349i can also say something to this: Did you test the Utilities with segmentation masks created by the "MultiLabel Segmentation View"?

Oct 28 2021, 9:24 AM · MITK (v2022.10)

Oct 27 2021

kislinsk closed T28771: Serialized 3-d interpolation surfaces of static images are invisible after reloading of project file as Resolved.
Oct 27 2021, 12:24 PM · MITK (v2021.10)
kislinsk added a comment to T28771: Serialized 3-d interpolation surfaces of static images are invisible after reloading of project file.

Deleted branch from rMITK MITK: bugfix/T28771-FixNegInfInSerializedGeometryProps.

Oct 27 2021, 12:23 PM · MITK (v2021.10)
kislinsk added a comment to T28771: Serialized 3-d interpolation surfaces of static images are invisible after reloading of project file.

Pushed new branch to rMITK MITK: bugfix/T28771-FixNegInfInSerializedGeometryProps.

Oct 27 2021, 12:23 PM · MITK (v2021.10)
kislinsk triaged T28771: Serialized 3-d interpolation surfaces of static images are invisible after reloading of project file as Normal priority.
Oct 27 2021, 12:20 PM · MITK (v2021.10)
kalali updated subscribers of T28135: [MultiLabel Segmentation] Utilities view cannot handle non-binary multilabel segmentations.
In T28135, @kalali wrote:

MultiLabel Segmentation View creates segmentation masks that are non-binary, rendering most of the operations useless.

Oct 27 2021, 12:05 PM · MITK (v2022.10)

Oct 25 2021

kalali added a subtask for T28479: [Segmentation] Rethink / reevaluate our existing segmentation tools / algorithms: T28247: [Segmentation] Watershed tool freezes when slider and threshold are set to a low value.
Oct 25 2021, 1:32 PM · MITK (v2022.10)
kalali added a parent task for T28247: [Segmentation] Watershed tool freezes when slider and threshold are set to a low value: T28479: [Segmentation] Rethink / reevaluate our existing segmentation tools / algorithms.
Oct 25 2021, 1:32 PM · MITK, Next Milestone, Missing Info, Request for Discussion

Oct 22 2021

kalali added a comment to T28763: [Multilabel Segmentation] Fill / Erase tool does not fully respect multiple labels.

May be I do not understand the problem right. But the described behavior sounds correct to me. Flood fill should stop on another (not the label you clicked on (including background) label boundary. The only thing you could discuss is wether it is important if another label is locked or not.

Oct 22 2021, 8:34 AM · MITK (v2022.10), Request for Discussion

Oct 21 2021

kannberg claimed T28585: The MITK-Tutorial Step 9 missing inheritence.
Oct 21 2021, 7:53 PM · Next Milestone, MITK
floca added a project to T28763: [Multilabel Segmentation] Fill / Erase tool does not fully respect multiple labels: Request for Discussion.

May be I do not understand the problem right. But the described behavior sounds correct to me. Flood fill should stop on another (not the label you clicked on (including background) label boundary. The only thing you could discuss is wether it is important if another label is locked or not.

Oct 21 2021, 6:29 PM · MITK (v2022.10), Request for Discussion
floca closed T28756: [Segmentation] 3-d picking tool crashes with dynamic segmentations as Resolved.
Oct 21 2021, 6:19 PM · MITK (v2021.10)