The last thing that happens is a crash.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Jan 29 2021
In T28230#218892, @neher wrote:These parameter descriptions don't really make sense, no?
parser.addArgument("fix", "f", mitkCommandLineParser::Image, "Input Image", "Path to the input VTK polydata", us::Any(), false, false, false, mitkCommandLineParser::Input); parser.addArgument("moving", "m", mitkCommandLineParser::File, "Output text file", "Target file. The output statistic is appended to this file.", us::Any(), false, false, false, mitkCommandLineParser::Output); parser.addArgument("output", "o", mitkCommandLineParser::File, "Extension", "File extension. Default is .nii.gz", us::Any(), false, false, false, mitkCommandLineParser::Output);
Yes the easiest way would be arc diff and arc land.
Just a side note: As MITK also uses gitflow now, a compliant branch name would be feature/* or bugfix/*.
It is a safety measure. As soon as more then to rows are in the table (so either >1 image or >1 roi) the histogram is deactivated at the moment, because you would not be able to discreminate them accordingly. See also Tasks mentioned above. Needs substential overhaul in the internals.
I added the functionality to choose the interpolator. I forgot how to merge it :) Arcanist? And land on develop?
Still valid - although it was not clearly defined what happened. Sorry, too many things going on at the same time. I will add a video to show some strange behavior.
Pushed new branch to rMITK MITK: T28230-ResampleImageToReference.
Since you are already working on the histogram anyways, can you check the following:
These parameter descriptions don't really make sense, no?
Thank you very much for the super fast response!
For me this is only coupled to the training support within Kaapana.
For RACOON we need it in the next weeks. Sooner is better of course :)
We could simply adapt CLResampleImageToReference to optionally use NN. Should be easy enough. I will take a look today.
That's exactly what I wrote and defined in the checklist. The checklist is correct as it perfectly reflects what's happening in the workbench. This is - as described in the title of the corresponding section - valid for 4D test data.
The other options "Show as volume rendering" and "Enable auto-selection mode" are not working as described. Or I didn't get the description..
Ah it seems I was mistaking, at least the transparent overlay works, the color mismatch remains.
Ah, when changing the Preference of Segmenation, the mask is changed... How can I create a "Multilabel Mask"?
Yes, it is exactly as you described: static -> all timesteps, dynamic -> toolbox to apply to all timesteps or not.
I think it is the checklist. When creating a new segmentation based on a dynamic image you now can decide between a static segmentation that has a single timestep spanning over all reference image timesteps and a dynamic segmentation to have matching timesteps. In the latter case only the current timestep should be affected except the tool is explicitly giving the option to be applied to all timesteps at once. Can you confirm?
Jan 28 2021
I opened a review for my modifications / suggestions for a LevelWindowManagerTest. Please have a look at it: D461
I have explicitly two problems with the current test:
- I need to load the three images / datasets for each tests since it is not possible to keep those images in memory for every new tests. Does anyone know how to solve this problem?
- I randomly get a failed test in line 287 / 288
m_DataNode2->SetSelected(true); CPPUNIT_ASSERT_MESSAGE("\"imageForLevelWindow\" property not correctly set", AssertImageForLevelWindowProperty(false, true, false));
For all cases the result now keeps the original level window. In case of Heart3D+t the level window property is lost otherwise. That's why it appeared in strange contrast and "lost" the level window widget.
no it is not fixed. Happened today also in the QmitkHistogramWidget.
Discussion already decided... *grrr*
The only way i was abel to find to quick fix T28221 and T28223, without rewritting the whole QmitChart and QmitkHistogramWidget (wich is currently out of question due to a lack of time), is by only using one fixed label name.
So at least this implicitly fixes T28206 somehow and decides the solution of this task.
The context menu actions are either not implemented or dysfunctional. Disable the context menu for now.
Closing as "invalid". The secret is to use the mouse wheel to navigate between time steps in the point set widget. It is not in sync with the Image Navigator. The whole plugin and widgets need a complete rewrite to actually work reliably with dynamic images, though, but this is out of scope for this task and the upcoming release.
I found several reasons to do a pseudo-UI test so I will come up with a draft for a test of the relevant classes.
Looked into it. So for quick fix we hace only the following options:
OK. Following options/state:
As discussed I would solve it by using a tool to resample/pad the segmentation to the same size like the image.
I will have a look on the most pragmatic way to provide the CLI.
As far as I know, this is crucial for the RACOON project. So for the Kaapana side, this has a high priority.
Jan 27 2021
Thanks for the hint.
Since we removed the correction tool, this task is not valid anymore. The Add or Subtract tool can be used as a replacement. Remember that pressing CTRL inverts the logic of these tools.
Ok, but then we can at least close T22391.
In T28203#218558, @kalali wrote:Is this obsolete know with the discussion results stated in D459?