In T28127#217604, @gaoh wrote:@floca I might have found a dataset, where even the new number is not enough:
P:\Gao\mitk-testdata\
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Jan 21 2021
Jan 21 2021
s669m renamed T28169: TFDA MVP v1 powered by Kaapana from TFDA MVP v1 to TFDA MVP v1 powered by Kaapana.
Jan 20 2021
Jan 20 2021
@floca I might have found a dataset, where even the new number is not enough:
edit:
E130-Personal:\Gao\mitk-testdata\
floca added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.
Hm, interesting... I say we but it under the category experience and close that chapter. If it reoccures we see how to handle it. Thanks for investigating it.
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.
Something strange happened:
I wanted to test some GUI functionality for your open diff but somehow I was not able to load data anymore: Clicking on Open File did not open a window.
Then I removed the DKFZ AppData folder to have a fresh MITK workbench. Now clicking on Open File opened a window but while I was scrolling inside this window to find the desired data, the window stopped working (did not scroll anymore - whole application was frozen).
So I did a Windows restart and opened MITK again. Now I am able to load data again and Voila: The segmentation view now automatically selects the newly added data node (patient image selector).
...
...
Tbh, I have no clue what's going on.
floca committed rMITK52adb58300dd: T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading (authored by floca).
T27689 RTDose_image_cannot_be_serialized_and_workbench_crashes_upon_loading
Fixed T27689
floca closed T27689: RTDose image can not be serialized and workbench crashes upon loading as Resolved by committing rMITKadb6d06ec088: Fixed T27689.
floca committed rMITKbac2bebfaee6: Prevent that serialization errors of single properties lead to a failed write… (authored by floca).
Prevent that serialization errors of single properties lead to a failed write…
Code clean up (dead code)
floca committed rMITK9919ca949962: Changed to Point3dProperty to use existing serializer. (authored by floca).
Changed to Point3dProperty to use existing serializer.
floca committed rMITKbb5f99527044: Changed to DoubleProperty to support existing serializers (authored by floca).
Changed to DoubleProperty to support existing serializers
gaoh moved T28127: Reopen segmentation in MITK from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Jan 19 2021
Jan 19 2021
@floca thanks for the report! I added a comment to the dcmqi issue you created.
kalali triaged T28181: [Segmentation] Should warning messages be passed on to the UI? as Normal priority.
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.
I'm currently on the latest develop (rMITK15ecdf8d92aa). Only a small set of plugins enabled (datastorageviewertest, (ML)segmentation, imagenavigator).
I'm doing this in Debug mode.
Update DCMQI to v1.2.3
Update DCMQI to v1.2.3
floca added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.
In T27498#217438, @kalali wrote:I just came across this again:
For me the following happens:
- I open the MITK workbench
- open the Segementation View
- below the image selectors a warning Please select an image is shown
- both image selectors show a red warning
- I open an image e.g. US4DCyl.nrrd
- the warning below the image selectors changes to Select or create a segmentation
- both image selectors still show a red warning
- the image is not automatically selected
floca closed T27703: [Segmentation] Watershed segmentation crashes on images when high threshold is chosen as Resolved.
In T27703#217487, @kalali wrote:Is this solved?
As far as I have described above, yes.
- The new selection concept automatically removes non-matching segmentation nodes if the reference image was changed. A warning is shown Select or create a segmentation (Tools disabled)
- The new selection concept does not allow to select a non-matching segmentation node
- Selecting a matching segmentation node that is invisible results in the warning: The selected segmentation is currently not visible! (Tools disabled)
- Showing the invisible segmentation node results in the warning: Please perform a reinit on the segmentation image! (Tools disabled)
- Performing a reinit on the matching segmentation node enables the tools (no warning shown)
kalali triaged T28180: [Segmentation] Showing a previously hidden reference image requires a reinit as Normal priority.
s669m renamed T28169: TFDA MVP v1 powered by Kaapana from TFDA (Kaapana) Multi-Provider site version (a.k.a) Central Instance to TFDA MVP v2.
We are now using a different approach but this should be verified with the new widgets.
kislinsk added a revision to T28174: Fix minor C++ style issues: Unknown Object (Differential Revision).
kalali added a comment to T27703: [Segmentation] Watershed segmentation crashes on images when high threshold is chosen.
Is this solved?
kalali added a comment to T27883: [Segmentation] Crash and interpolation issues in static segmentation on reference image with strange arbitrary time geometry (3d+t heart).
Need to recheck after T28118: Refactoring of SegTool2D is done.
kalali added a parent task for T27711: Rename segmentation image selection label: T28176: [Segmentation] Inspection of module and plugin.
Jan 19 2021, 12:07 PM · Restricted Project
Jan 19 2021, 12:07 PM · Restricted Project
Jan 19 2021, 12:06 PM · Restricted Project
Jan 19 2021, 12:06 PM · Restricted Project
s669m added a parent task for T28167: System set up: Multi Provider Site Version: T28175: TFDA MVP v1.
Jan 19 2021, 12:06 PM · Restricted Project
Jan 19 2021, 12:06 PM · Restricted Project
Jan 19 2021, 12:05 PM · Restricted Project
Jan 19 2021, 12:05 PM · Restricted Project
kalali added a comment to T27498: [Selection widgets] Define default for auto selection / listening mechanism.
In T27498#209136, @floca wrote:Just double checked it. As I said the segmentation and ML segmentation view already use auto select and work as they should.
floca moved T28118: Refactoring of SegTool2D from Backlog to Segmentation on the MITK (v2021.02) board.
kislinsk renamed T27701: Overhaul or remove PluginGenerator from Plugin Generator tests fail to Overhaul or remove PluginGenerator.
kislinsk edited projects for T27701: Overhaul or remove PluginGenerator, added: Next Milestone, MITK; removed MITK (v2021.02).
Deleted branch from rMITK MITK: bugfix/T28173-CMakeWarnings.
Use CMake's FindDCMTK module
Search for DCMTK only if necessary
Reduce CMake config noise
Get rid of CMake deprecation warning
kislinsk committed rMITK020d23f2ed29: Merge branch 'bugfix/T28173-CMakeWarnings' into develop (authored by kislinsk).
Merge branch 'bugfix/T28173-CMakeWarnings' into develop
Pushed new branch to rMITK MITK: bugfix/T28173-CMakeWarnings.
Jan 18 2021
Jan 18 2021
T28127 Reopen_segmentation_in_MITK
floca closed T28127: Reopen segmentation in MITK as Resolved by committing rMITK5f64c29977dd: Made NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION less strict.
floca committed rMITK5f64c29977dd: Made NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION less strict (authored by floca).
Made NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION less strict
floca added a revision to T28127: Reopen segmentation in MITK: Unknown Object (Differential Revision).
In T28127#217365, @kislinsk wrote:It depends. NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION is only for checking in predicates;
As long as nobody has missused it so far, it is just used for that. ;) At least I have introduced it with this purpose and only used it there.
Merge branch 'T28017-VTK9-CodeIssues2'
neher committed rMITKDIFFa1bbe1077655: Final changes for dependency upgrade compatibility (authored by neher).
Final changes for dependency upgrade compatibility
Pushed new branch T28017-VTK9-CodeIssues2.
kislinsk triaged T28172: Include MITK-ProjectTemplate in MITK Differential builds as Normal priority.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28171-MigrateToCurrentMITKDevelopBranch.
kislinsk committed rMPT9551835199a1: Merge branch 'bugfix/T28171-MigrateToCurrentMITKDevelopBranch' into develop (authored by kislinsk).
Merge branch 'bugfix/T28171-MigrateToCurrentMITKDevelopBranch' into develop
Fix enum value names
Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28171-MigrateToCurrentMITKDevelopBranch.
kislinsk triaged T28171: Migrate MITK-ProjectTemplate to current MITK develop branch as Normal priority.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Pushed new branch to rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
Deleted branch from rMPT MITK-ProjectTemplate: bugfix/T28170-TestHooks.
kislinsk committed rMPTa3cdbda12c8c: Adapt branching model to MITK repository (authored by kislinsk).
Adapt branching model to MITK repository
It depends. NODE_PREDICATE_GEOMETRY_DEFAULT_CHECK_PRECISION is only for checking in predicates; not for constant use throughout MITK while are there calculations after calculations after calculations and so the values would drift away further from the actual truth, right? So for a temporary fix, I'm okay. But we should definitely check what is going on in DCMQI and fix on that side preferably.