Page MenuHomePhabricator
Feed All Stories

May 12 2020

floca added a parent task for T27406: Add TemporoSpatialStringProperty::IsUniform() method: T27341: Extend Classification classes and software stack to produce more structured results.
May 12 2020, 2:33 PM · MITK
floca added a subtask for T27341: Extend Classification classes and software stack to produce more structured results: T27406: Add TemporoSpatialStringProperty::IsUniform() method.
May 12 2020, 2:33 PM · Breaking Change, Noteworthy, HiGHmed, MITK
floca triaged T27406: Add TemporoSpatialStringProperty::IsUniform() method as Normal priority.
May 12 2020, 2:32 PM · MITK
floca committed rMITK8db266821df1: Fixed T26843 (authored by floca).
Fixed T26843
May 12 2020, 2:04 PM
floca committed rMITK658afab17c3d: Fixed review remarks (authored by floca).
Fixed review remarks
May 12 2020, 2:04 PM
floca committed rMITK2b572c146445: Fixed review remarks (authored by floca).
Fixed review remarks
May 12 2020, 2:04 PM
floca committed rMITK87e29b2b6847: Fixed T26843 (authored by floca).
Fixed T26843
May 12 2020, 2:04 PM
floca closed T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule, a subtask of T23754: DataStorage/Relationship clean up/refactoring, as Resolved.
May 12 2020, 2:04 PM · MITK
floca closed T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule as Resolved by committing rMITK87e29b2b6847: Fixed T26843.
May 12 2020, 2:04 PM · MITK (v2021.02), Restricted Project
floca closed T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule, a subtask of T26950: Add rule class for DICOM Seg relations to source image, as Resolved.
May 12 2020, 2:04 PM · MITK (v2024.06), Cleared
aguilera renamed T27325: Plot titles in rankingHeatmap missing in multi task report from plot titles in rankingHeatmap missing in multi task report to Plot titles in rankingHeatmap missing in multi task report.
May 12 2020, 12:56 PM · challengeR (v1.0)
aguilera renamed T27404: Fix the 2.1 section title format of the report from Fix the reports 2.1 section title format to Fix the 2.1 section title format of the report.
May 12 2020, 12:39 PM · challengeR (v1.0)
aguilera claimed T27325: Plot titles in rankingHeatmap missing in multi task report.
May 12 2020, 12:38 PM · challengeR (v1.0)
aguilera moved T27325: Plot titles in rankingHeatmap missing in multi task report from Backlog to In Progress on the challengeR (v1.0) board.
May 12 2020, 12:37 PM · challengeR (v1.0)
aguilera created T27404: Fix the 2.1 section title format of the report.
May 12 2020, 12:35 PM · challengeR (v1.0)
eisenman claimed T27396: Represent single-task challenge as multi-task challenge with one task.
May 12 2020, 11:18 AM · challengeR (v1.0)
eisenman moved T27396: Represent single-task challenge as multi-task challenge with one task from Backlog to In Progress on the challengeR (v1.0) board.
May 12 2020, 11:17 AM · challengeR (v1.0)
eisenman added a comment to T27396: Represent single-task challenge as multi-task challenge with one task.

Thank you for your feedback!

May 12 2020, 10:27 AM · challengeR (v1.0)
zimmerer committed rMOODbb9a8d9ce2d2: Make data set dir path cmd args (authored by zimmerer).
Make data set dir path cmd args
May 12 2020, 9:48 AM

May 11 2020

floca closed T22616: Store exact software version in properties when reading DICOM, a subtask of T27341: Extend Classification classes and software stack to produce more structured results, as Resolved.
May 11 2020, 8:48 PM · Breaking Change, Noteworthy, HiGHmed, MITK
floca closed T22616: Store exact software version in properties when reading DICOM as Resolved.
May 11 2020, 8:48 PM · HiGHmed, MITK (v2021.02), Noteworthy, Restricted Project, Restricted Project
floca committed rMITKc0f8d115e52c: T22616 Store_version_and_reader_informationAdded std::initializer_list support… (authored by floca).
T22616 Store_version_and_reader_informationAdded std::initializer_list support…
May 11 2020, 8:46 PM
floca committed rMITK5c9ea78fafc0: Fixed review remarks (authored by floca).
Fixed review remarks
May 11 2020, 8:46 PM
floca committed rMITK97eafb78f971: Added checking of DICOM IO meta information to DICOM tests (authored by floca).
Added checking of DICOM IO meta information to DICOM tests
May 11 2020, 8:46 PM
floca committed rMITKa52172072d1d: Fixed error in DICOMPReloadedValumeTest (authored by floca).
Fixed error in DICOMPReloadedValumeTest
May 11 2020, 8:46 PM
floca committed rMITK03ea6c630a71: Fixed bug in operator= and CopyConstructor (authored by floca).
Fixed bug in operator= and CopyConstructor
May 11 2020, 8:46 PM
floca committed rMITK3ee02b1eb447: Fixed review remarks (authored by floca).
Fixed review remarks
May 11 2020, 8:46 PM
floca committed rMITKa41ccd4d7c3d: Added test to verify general IO meta information is set and persistet (authored by floca).
Added test to verify general IO meta information is set and persistet
May 11 2020, 8:46 PM
floca committed rMITK0250499d44d5: Refactored missed reader (authored by floca).
Refactored missed reader
May 11 2020, 8:46 PM
floca committed rMDb185c6218c63: T22616 Actualized dicom refdumps with meta information (authored by floca).
T22616 Actualized dicom refdumps with meta information
May 11 2020, 8:43 PM
Oshio edited projects for T27389: Running tutorial's Step8 gives Segmentation Fault!, added: MITK (2018-04); removed MITK.
May 11 2020, 7:53 PM · MITK (2018-04)
mindrocf added a comment to T27402: qPAI Cox algorithm reproduction.

Pushed new branch T27402-qpai_CoxAlgorithmReproduction.

May 11 2020, 5:12 PM · IMSY, Photoacoustics
mindrocf triaged T27402: qPAI Cox algorithm reproduction as Normal priority.
May 11 2020, 4:59 PM · IMSY, Photoacoustics
kislinsk removed a member for Deep Learning: ramien.
May 11 2020, 2:48 PM
kislinsk removed a member for MIC: ramien.
May 11 2020, 2:47 PM
wiesenfa added a comment to T27338: Report contains misleading information on missing values.

I agree, it would be nice if the actual number of NAs would be reported (together with the na.treat method) and not the number after na.treat which is then obviously 0.

May 11 2020, 2:05 PM · challengeR (v1.0)
wiesenfa added a comment to T27326: autolayout networks in multi task report ugly.

layouting (circle sizes, distances, font sizes, size of plot) needs to be automatically optimized which I failed so far

May 11 2020, 2:04 PM · challengeR
wiesenfa added a comment to T27385: Variables holding the aggregated value are named differently for single- and multi-task challenges.

Did you take care that FUN="mean" and FUN=mean is handled differently (in the former case it is a name, in the latter case it is a function)?

May 11 2020, 2:02 PM · challengeR (v1.0)
wiesenfa added a comment to T27396: Represent single-task challenge as multi-task challenge with one task.

might indeed reduce complexity, however,

  • many functions need to be adapted requiring some care
  • behavior is sometimes by purpose different, e.g. there are plot titles with the task name in multi-task challenges while there is none in single task challenges
  • many visualizations apply only to multi-task challenges and trying to use them in single task challenges throws an error, this would be needed to be handled
  • also reports for multi task challenges contain more visualizations which would be uninformative for single task challenges (could however be handled by checking the number of tasks internally)
  • a workaround would be necessary adding a task column to single class challenges (with the same label in every row)
May 11 2020, 1:59 PM · challengeR (v1.0)
floca triaged T27397: Add VerifyDICOMDump tests for all reader configurations as High priority.
May 11 2020, 1:57 PM · Auto-closed, DICOM, MITK
kislinsk added a comment to T27181: MITK - DICOM Seg - not saved when started without terminal.

I guess we have several of these subtle problems with our installers but to be sure we would need to check by building an installer from the current master and try it again.

May 11 2020, 1:34 PM · Cleared, MITK (v2021.02)
eisenman triaged T27396: Represent single-task challenge as multi-task challenge with one task as High priority.
May 11 2020, 1:09 PM · challengeR (v1.0)
gaoh added a project to T26953: DICOM SEG - Cannot rewrite segmentations as DICOM SEG: Cleared.
May 11 2020, 12:44 PM · MITK (v2024.06), Cleared
reinkea added a comment to T27338: Report contains misleading information on missing values.

I think it is interesting to state the number of NAs in the report but this should be the actual number of NAs (not 0).

May 11 2020, 12:41 PM · challengeR (v1.0)
gaoh closed T27369: [Dcipher] Possibility to save Dicom segmentation objects instead of .nrrd and send those ideally directly to the platform as Resolved.

If the "base", the image, is in dcm, and not a nrrd file (which is the case in dcipher, when pulling the images from the PAC), the Segmentation can be saved as DICOM. The created file can be saved in a mounted folder and can then be directly imported via airflow into the pacs.
Directly sending data from MITK to the PACs is not recommended, because otherwise the metadata is not extracted and the segemtation cannot be triggered via kibana!

May 11 2020, 12:37 PM · MITK (v2021.02)
zimmerer committed rMOOD2fc21cab681e: Basic version of example AE for OoD (authored by zimmerer).
Basic version of example AE for OoD
May 11 2020, 12:33 PM
gaoh updated subscribers of T27181: MITK - DICOM Seg - not saved when started without terminal.

I reproduced it with the "Installer".

[63.469] Writing image: /home/hanno/mitk/seg.dcm
Input image size: [512, 512, 7]
CodeSequence Exception: missing value in code sequence
#63.470# ERROR: An error occurred during writing the DICOM Seg: JSON Exception: file could not be read.

May 11 2020, 12:29 PM · Cleared, MITK (v2021.02)
eisenman added a comment to T27326: autolayout networks in multi task report ugly.

What is the tricky part?

May 11 2020, 11:57 AM · challengeR
eisenman added a comment to T27338: Report contains misleading information on missing values.

What do the others think? Which number of NAs should be stated in the report?

May 11 2020, 11:55 AM · challengeR (v1.0)
eisenman added a comment to T27385: Variables holding the aggregated value are named differently for single- and multi-task challenges.

@wiesenfa: Do you have any preference regarding the naming scheme?

May 11 2020, 11:33 AM · challengeR (v1.0)
eisenman claimed T27360: compatibility with R4.0.0.
May 11 2020, 10:51 AM · challengeR (v1.0)
eisenman moved T27360: compatibility with R4.0.0 from Backlog to In Progress on the challengeR (v1.0) board.
May 11 2020, 10:51 AM · challengeR (v1.0)
Oshio created T27389: Running tutorial's Step8 gives Segmentation Fault!.
May 11 2020, 10:38 AM · MITK (2018-04)

May 10 2020

floca edited projects for T25805: Standardize/Rework DICOM module naming, added: MITK (v2021.02); removed MITK.
May 10 2020, 3:14 PM · Noteworthy, Breaking Change, MITK (v2021.02), DICOM
floca edited projects for T26294: Should we move DICOMPropertyPath helper to Core, added: MITK (v2021.02); removed MITK.
May 10 2020, 3:12 PM · MITK (v2024.06), DICOM
floca added a project to T26294: Should we move DICOMPropertyPath helper to Core: DICOM.
May 10 2020, 3:11 PM · MITK (v2024.06), DICOM
floca moved T26142: Property persistence for property relation instance identifing (RII) properties from Backlog to DICOM SEG on the MITK (v2021.02) board.
May 10 2020, 3:07 PM · Cleared, MITK (v2021.02)
floca added a project to T23751: Introduction of new selection concept: Noteworthy.
May 10 2020, 2:57 PM · Noteworthy, MITK
floca added a project to T25804: [Selection concept] Set 'selected' property when using the new selection concept: Request for Discussion.
May 10 2020, 2:55 PM · MITK (v2024.06), Request for Discussion
floca added a comment to T25753: Some refactoring of the selection classes.

@kalali Is this still relevant? If so, it would be greate if this branch becomes merged into the master or relvant changes will be cherry-picked. If not, we just close the branch. But it makes no sense to have this task/branch dangeling arround for ever.

May 10 2020, 2:51 PM · MITK
floca moved T22616: Store exact software version in properties when reading DICOM from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 10 2020, 2:44 PM · HiGHmed, MITK (v2021.02), Noteworthy, Restricted Project, Restricted Project
floca moved T26843: Rethink/CleanUp PropertyRelation connection levels and RII properties used in SourceImageRelationRule from Restricted Project Column to Restricted Project Column on the Restricted Project board.
May 10 2020, 2:44 PM · MITK (v2021.02), Restricted Project

May 9 2020

floca raised the priority of T27209: [Registration] Mapper does not allow to select ML segmentation as input from Normal to High.
May 9 2020, 12:37 PM · Cleared, MITK (v2021.02)
floca raised the priority of T27346: [Registration] Mapper does not work with no registration selected from Normal to High.
May 9 2020, 12:37 PM · Cleared, MITK (v2021.02)
floca raised the priority of T27143: Matchpoint Registration Evaluator- Colorblend Bug from Normal to High.
May 9 2020, 12:37 PM · Cleared, MITK (v2021.02), Restricted Project
floca raised the priority of T27200: [Registration] Crash in frame corrector from Normal to High.
May 9 2020, 12:37 PM · Cleared, MITK (v2021.02)
floca triaged T27347: [Registration] Evaluator/Mainpulator new autoselect behavior wanted? as Normal priority.
May 9 2020, 12:36 PM · Cleared, MITK (v2021.02)
floca placed T27093: [MITKDoc] Revise Segmentation Plugin up for grabs.
May 9 2020, 12:30 PM · MITK (v2021.02)
floca placed T27094: [MITKDoc] Revise Segmentation Utilities Plugin Documentation up for grabs.
May 9 2020, 12:29 PM · Cleared, MITK (v2021.02)
floca placed T27095: [MITKDoc] Revise MultiLabel Segmentation Plugin Documentation up for grabs.
May 9 2020, 12:29 PM · MITK (v2021.02)
floca placed T27096: [MITKDoc] Revise MultiLabel Segmentation Utilities Plugin Documentation up for grabs.
May 9 2020, 12:29 PM · MITK (v2021.02)
floca closed T27050: Crash with planar figures and stastics/measurement as Resolved.

Reporter hasn't got any crashes any more with the new version. Guess my last assumption was right. So we close the issue for good.

May 9 2020, 12:27 PM · Restricted Project, MITK

May 8 2020

floca added a project to T27202: Support Planarfigures with fixed size: Noteworthy.
May 8 2020, 8:56 PM · Noteworthy, MITK, Restricted Project
floca added a project to T27229: [ImageStatistic] Copy to clipboard from statistic table should be directly usabel in Excel: Noteworthy.
May 8 2020, 8:53 PM · Noteworthy, MITK (v2021.02), Restricted Project
floca added a project to T26142: Property persistence for property relation instance identifing (RII) properties: Cleared.
May 8 2020, 6:13 PM · Cleared, MITK (v2021.02)
neher committed rMITKDIFF3f114661db68: Merge branch 'T27318-IvimFit' (authored by neher).
Merge branch 'T27318-IvimFit'
May 8 2020, 5:22 PM
neher committed rMITKDIFF00761448d368: Fixed nanas (authored by neher).
Fixed nanas
May 8 2020, 5:22 PM
eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

The null pointer is returned because mitk::ArbitraryTimeGeometry::IsValidTimePoint(...) evaluates time point 160 ms to false.

May 8 2020, 3:38 PM · Cleared, MITK (v2021.02)
nolden closed T25702: DICOM sort fails for RWV modality as Resolved.

I got some data now which shows a problem with MITK 2018.4 but works with the current master. I don't see though the RWV thing. Can't remember exactly how I investigated this back then. Let's hope the more robust handling of DICOM fixed this as @floca noted , I informed the reporting users that they should comment if this should be investigated again.

May 8 2020, 3:24 PM · MITK (v2021.02), Restricted Project
eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

The status is set as mentioned above because in QmitkImageNavigatorView::UpdateStatusBar() the call of mitk::FindTopmostVisibleNode(...) for time point 160 ms returns a null pointer.

May 8 2020, 3:07 PM · Cleared, MITK (v2021.02)
kleina triaged T27387: Link in Documentation wrong as Normal priority.
May 8 2020, 3:05 PM · MITK
eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

Another observation in the current version: "No image information at this position!" is shown in the status bar when switching from second to third time step.

May 8 2020, 2:30 PM · Cleared, MITK (v2021.02)
kalali triaged T27386: [MultiLabel] Workbench crashes if autocrop is used with opened plugin view without patient image as Normal priority.
May 8 2020, 1:38 PM · Cleared, MITK (v2021.02)
floca renamed T27339: Provide public MITK ModelFit installer on a regular basis from Should modelfit plugins be part of the normal release? to Provide public MITK ModelFit installer on a regular basis.
May 8 2020, 1:09 PM · MITK (v2024.06)
kalali added a project to T26978: [Segmentation] Autocrop with MITK Multilabel Image Reader does not work with multilabel images: Missing Info.

I tried to reproduce it. I can verify Step 1 with the MITK Multilabel Image reader but if I use the ITK NrrdImageIO reader there is no option to use autocrop.

May 8 2020, 1:08 PM · Request for Discussion, Missing Info, MITK (v2021.02)
floca added a comment to T27339: Provide public MITK ModelFit installer on a regular basis.

Dicusssion result:
We make own installers like MITK Perfusion for it. So no part of the normal Workbench installer.
We change this task to a meta task for everything needed to have such own installers and CI checking...

May 8 2020, 1:06 PM · MITK (v2024.06)
floca added a project to T27347: [Registration] Evaluator/Mainpulator new autoselect behavior wanted? : Cleared.
May 8 2020, 12:40 PM · Cleared, MITK (v2021.02)
floca added a project to T27346: [Registration] Mapper does not work with no registration selected: Cleared.
May 8 2020, 12:39 PM · Cleared, MITK (v2021.02)
floca added a project to T27143: Matchpoint Registration Evaluator- Colorblend Bug: Cleared.
May 8 2020, 12:39 PM · Cleared, MITK (v2021.02), Restricted Project
floca added a project to T27200: [Registration] Crash in frame corrector : Cleared.
May 8 2020, 12:39 PM · Cleared, MITK (v2021.02)
kalali updated subscribers of T26840: Mission Homepage Reorganization .

Could it be that there is something wrong with T26840-MitkHomepageReorganization-TopLevel? I created a branch based on it and a review a while ago and the CI system detected compile errors (can't see the error message). But now @kleina has some errors building the diff-branch because of the Pharmacokinetics-Module and the mitkConcentrationCurveGenerator using Ubuntu (probably gcc, which is why did not experience this error). I think 3d5e49433c92 is missing in the TopLevel-branch which @floca added but it was never included in the mentioned branch.

May 8 2020, 12:30 PM · MITK
floca removed a project from T27347: [Registration] Evaluator/Mainpulator new autoselect behavior wanted? : Request for Discussion.

Discussion result: check for option to select it.

May 8 2020, 11:49 AM · Cleared, MITK (v2021.02)
floca triaged T27372: DataNode uses itkCloneMacro(Self) but does not implement a clone method as High priority.

Discussion results: check in our code base of someone uses the method. If not: Just remove it. If Yes: Look how they used/need it.

May 8 2020, 11:48 AM · Cleared, Noteworthy, MITK (v2021.02)
gaoh closed T27176: MITK - DICOM Seg - load created files as Resolved.

I just tested it, it works!

May 8 2020, 11:46 AM · Missing Info, MITK (v2021.02)
kalali edited projects for T27259: Render windows are not updated when last time step is selected, added: Cleared; removed Missing Info.
May 8 2020, 11:12 AM · Cleared, MITK (v2021.02)
kalali added a comment to T27259: Render windows are not updated when last time step is selected.

I don't know if that's a good thing 😈

May 8 2020, 11:08 AM · Cleared, MITK (v2021.02)
eisenman added a comment to T27259: Render windows are not updated when last time step is selected.

In 2016.11.0 it's showing different volumes for all of the three time steps.

May 8 2020, 11:06 AM · Cleared, MITK (v2021.02)
kislinsk removed a project from T27339: Provide public MITK ModelFit installer on a regular basis: Request for Discussion.
May 8 2020, 11:03 AM · MITK (v2024.06)
floca moved T27372: DataNode uses itkCloneMacro(Self) but does not implement a clone method from Backlog to MITK Meeting on the Request for Discussion board.
May 8 2020, 11:02 AM · Cleared, Noteworthy, MITK (v2021.02)
kislinsk added a project to T27379: Set up Ubuntu 20.04 CI clients: Cleared.
May 8 2020, 11:01 AM · Cleared, Restricted Project, MITK (v2021.02)