Page MenuHomePhabricator
Feed All Stories

Dec 3 2020

wiesenfa moved T27963: Task names printed as R output in Sec. 3.1 of multi-task report from In Progress to Done on the challengeR (v1.0) board.
Dec 3 2020, 10:21 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER1df7fcff2ba7: hide unnecessary text (authored by wiesenfa).
hide unnecessary text
Dec 3 2020, 10:21 PM
wiesenfa moved T27963: Task names printed as R output in Sec. 3.1 of multi-task report from Backlog to In Progress on the challengeR (v1.0) board.
Dec 3 2020, 10:14 PM · challengeR (v1.0)
wiesenfa moved T28033: +scale_* seems to not work in combination with ggList objects from In Progress to Done on the challengeR (v1.0) board.
Dec 3 2020, 10:11 PM · challengeR (v1.0)
wiesenfa added a comment to T28033: +scale_* seems to not work in combination with ggList objects.

works again for single task visualizations. in case multiple plots (a list of plots) is created %++% instead of + must be used for scale_*_() etc
mention in vignette

Dec 3 2020, 10:09 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER2c873612bef5: return gg object if single task (authored by wiesenfa).
return gg object if single task
Dec 3 2020, 10:06 PM
wiesenfa moved T28033: +scale_* seems to not work in combination with ggList objects from Backlog to In Progress on the challengeR (v1.0) board.
Dec 3 2020, 9:52 PM · challengeR (v1.0)
floca added a comment to T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15.

thanks for taking care. ❤

Dec 3 2020, 9:32 PM · MITK
kalali added a project to T27969: Toggling "Show cross hair" in a render window menu does not update the check state in other render window menus: Noteworthy.
NOTE: API change: LayoutDesignListChanged was renamed to UpdateLayoutDesignList for consistency with the newly added functions and for not to be confused with the Qt signals.
Dec 3 2020, 9:03 PM · Noteworthy, MITK (v2021.02)
wiesenfa added a comment to T28016: embed web app in package.

ok. just an idea, thought this might help issues with the server because people can run stuff by themselves and still seize the user interface.
can be closed or considered later

Dec 3 2020, 8:48 PM · challengeR (v1.0)
kislinsk added a comment to T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15.

Deleted branch bugfix/T28060-CMP0091.

Dec 3 2020, 7:28 PM · MITK
kislinsk committed rMITK2ce6115f1a86: Set policy CMP0091 to OLD for all projects (authored by kislinsk).
Set policy CMP0091 to OLD for all projects
Dec 3 2020, 7:28 PM
kislinsk committed rMITKc32297641777: Merge branch 'bugfix/T28060-CMP0091' into develop (authored by kislinsk).
Merge branch 'bugfix/T28060-CMP0091' into develop
Dec 3 2020, 7:28 PM
kislinsk added a comment to T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15.

Pushed new branch bugfix/T28060-CMP0091.

Dec 3 2020, 7:27 PM · MITK
kislinsk triaged T28060: CMake Policy CMP0091 does not work well with dependencies that are based on CMake version < 3.15 as High priority.
Dec 3 2020, 7:24 PM · MITK
wiesenfa committed rCHALLENGEReaba380339a2: podium: allow linetype and symbol depend on algo (authored by wiesenfa).
podium: allow linetype and symbol depend on algo
Dec 3 2020, 3:38 PM
wiesenfa moved T28055: respect color scheme also for box plots from In Progress to Done on the challengeR (v1.0) board.
Dec 3 2020, 1:57 PM · challengeR (v1.0)
wiesenfa moved T28055: respect color scheme also for box plots from Backlog to In Progress on the challengeR (v1.0) board.
Dec 3 2020, 1:57 PM · challengeR (v1.0)
wiesenfa committed rCHALLENGER403c0cc189b4: return gg object for single tasks, respect color scheme (authored by wiesenfa).
return gg object for single tasks, respect color scheme
Dec 3 2020, 1:56 PM
wiesenfa created T28055: respect color scheme also for box plots.
Dec 3 2020, 12:03 PM · challengeR (v1.0)
neher created T28053: DICOM Seg not associated with source DICOM.
Dec 3 2020, 10:24 AM · Kaapana (internal)
k656s added a comment to T28049: DataUpload fails with Firefox.

I just tried it with my firefox and it worked... Can you send me the version of your firefox? For very large files I know that it will fail...

Dec 3 2020, 10:12 AM · Kaapana (internal)
schererj added a project to T28043: TFDA MVP1-Tasks:Tools and Technologies: Restricted Project.
Dec 3 2020, 9:38 AM · Restricted Project, Kaapana (internal)

Dec 2 2020

schererj added a project to T27968: CTP gets stuck on large import: Request for Discussion.
Dec 2 2020, 8:58 PM · Kaapana (internal)
schererj moved T27968: CTP gets stuck on large import from Backlog to Discussion on the Kaapana (internal) board.
Dec 2 2020, 8:58 PM · Kaapana (internal)
kalali added a revision to T28051: [Multilabel Segmentation] Fill / Erase tool does not respect multiple layers: Unknown Object (Differential Revision).
Dec 2 2020, 6:04 PM · MITK (v2021.02)
kalali triaged T28051: [Multilabel Segmentation] Fill / Erase tool does not respect multiple layers as Normal priority.
Dec 2 2020, 6:00 PM · MITK (v2021.02)
kalali added a revision to T27817: [Multilabel] Live Wire tool always assigns first label when being used with multiple labels: Unknown Object (Differential Revision).
Dec 2 2020, 5:46 PM · Cleared, MITK (v2021.02)
kalali claimed T27817: [Multilabel] Live Wire tool always assigns first label when being used with multiple labels.
Dec 2 2020, 4:38 PM · Cleared, MITK (v2021.02)
kalali claimed T27870: [Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks.
Dec 2 2020, 4:38 PM · MITK (v2021.02)
nolden added a comment to T28049: DataUpload fails with Firefox.

PS: Chrome upload works but data doesn't show up in meta

Dec 2 2020, 1:07 PM · Kaapana (internal)
nolden created T28049: DataUpload fails with Firefox.
Dec 2 2020, 1:00 PM · Kaapana (internal)
eisenman moved T27241: Readme improvements from In Progress to Done on the challengeR (v1.0) board.

I don't see that 1. is an issue. Further improvements were done in the scope of T27996 and T27420.

Dec 2 2020, 11:27 AM · challengeR (v1.0)
eisenman moved T27241: Readme improvements from Backlog to In Progress on the challengeR (v1.0) board.
Dec 2 2020, 11:14 AM · challengeR (v1.0)
floca placed T25832: Migrate ModelFit inspector plugin to MitkChart up for grabs.

Unclaime as I currently have no time to work on it. Will take on it again, if I have time or some else;)

Dec 2 2020, 11:00 AM · Restricted Project, Restricted Project, MITK
kalali added a revision to T27870: [Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks: Unknown Object (Differential Revision).
Dec 2 2020, 10:51 AM · MITK (v2021.02)
kislinsk added a member for wDB: kislinsk.
Dec 2 2020, 10:48 AM

Dec 1 2020

weihs updated weihs.
Dec 1 2020, 9:28 PM
kislinsk moved T28047: CDash script does not fetch tags from Backlog to Done on the CI board.
Dec 1 2020, 2:35 PM · CI, MITK
kislinsk closed T28047: CDash script does not fetch tags as Resolved.
Dec 1 2020, 2:31 PM · CI, MITK
kislinsk committed rMITKca8dcec7aa87: Fetch tags on update (authored by kislinsk).
Fetch tags on update
Dec 1 2020, 2:30 PM
kislinsk committed rMITK7cdad74bd60a: Merge branch 'bugfix/T28047-FetchTags' into develop (authored by kislinsk).
Merge branch 'bugfix/T28047-FetchTags' into develop
Dec 1 2020, 2:30 PM
kislinsk triaged T28047: CDash script does not fetch tags as Normal priority.
Dec 1 2020, 2:22 PM · CI, MITK
kalali added a comment to T27870: [Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks.

It basically seems as if some m_FastMarchingFilter->Modified(); or similar is missing, after the seed points have been removed (to trigger the new green preview segmentation, which would be empty without seed points).

Dec 1 2020, 1:07 PM · MITK (v2021.02)
kalali added a project to T27870: [Segmentation] Fast Marching 3D Tool can not clear preview segmentation masks: Request for Discussion.

So I looked into it and the function behind the clear button actually is called OnClearSeeds so I was wondering what the expected result should be

  1. remove the seed point(s) but leave the green preview segmentation
  2. remove the seed point(s) and the green preview segmentation to start all over again
Dec 1 2020, 1:04 PM · MITK (v2021.02)
kislinsk added a comment to T27969: Toggling "Show cross hair" in a render window menu does not update the check state in other render window menus.

As it is a public API change I suggest that you tag this task with Noteworthy and write a line about the breaking change or in case it is not trivial a short migration guide.

Dec 1 2020, 12:35 PM · Noteworthy, MITK (v2021.02)
gaoh removed a project from T24398: Dicom plugin: Retrieve does not work: Missing Info.
Dec 1 2020, 11:03 AM · MITK (v2024.06)
gaoh added a comment to T24398: Dicom plugin: Retrieve does not work.

So I tested it with Orthanc (without CGET only):
With 2018.04.2 retrieve works. With the current develop branch MITK crashes with the same exception:

Dec 1 2020, 11:02 AM · MITK (v2024.06)
gaoh renamed T24398: Dicom plugin: Retrieve does not work from Dicom plugin: wdb Retrieve does not work to Dicom plugin: Retrieve does not work.
Dec 1 2020, 10:59 AM · MITK (v2024.06)
s669m added a comment to T28043: TFDA MVP1-Tasks:Tools and Technologies.

Also to discuss with Jonas and Klaus that Anything can be reused from JIP?

Dec 1 2020, 10:04 AM · Restricted Project, Kaapana (internal)
s669m triaged T28043: TFDA MVP1-Tasks:Tools and Technologies as High priority.
Dec 1 2020, 9:49 AM · Restricted Project, Kaapana (internal)
schererj added a comment to T27968: CTP gets stuck on large import.

You mean more explicit control? I would guess that we also have control about which version of CTP and its configuration we use.

We just use the default CTP stages for DIMSE-send etc. - currently we don't have any influence on the binaries / parameters used. (And have no idea if things go wrong)

Dec 1 2020, 2:27 AM · Kaapana (internal)

Nov 30 2020

floca added a comment to T27968: CTP gets stuck on large import.

Thanks for the answers!

Nov 30 2020, 9:00 PM · Kaapana (internal)
kalali closed T27969: Toggling "Show cross hair" in a render window menu does not update the check state in other render window menus as Resolved.
Nov 30 2020, 8:46 PM · Noteworthy, MITK (v2021.02)
kalali committed rMITKaba3194febeb: Update the check state in other render window menus (authored by kalali).
Update the check state in other render window menus
Nov 30 2020, 8:46 PM
kalali committed rMITK4661bf2a5c6f: Make function names consistent (authored by kalali).
Make function names consistent
Nov 30 2020, 8:46 PM
kalali committed rMITK5da13409b6f3: Notify state change to all render windows (authored by kalali).
Notify state change to all render windows
Nov 30 2020, 8:46 PM
kislinsk closed T26449: XNAT connection failes due to missing OpenSSL connections as Resolved.
Nov 30 2020, 8:08 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T26449: XNAT connection failes due to missing OpenSSL connections.

Deleted branch bugfix/T26449-XNAT-OpenSSL.

Nov 30 2020, 8:08 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITKa2232f1fb214: Fix copying/installing of OpenSSL for XNAT (authored by kislinsk).
Fix copying/installing of OpenSSL for XNAT
Nov 30 2020, 8:07 PM
kislinsk committed rMITK01c1803b4ab9: Merge branch 'bugfix/T26449-XNAT-OpenSSL' into develop (authored by kislinsk).
Merge branch 'bugfix/T26449-XNAT-OpenSSL' into develop
Nov 30 2020, 8:07 PM
kalali claimed T27969: Toggling "Show cross hair" in a render window menu does not update the check state in other render window menus.
Nov 30 2020, 3:51 PM · Noteworthy, MITK (v2021.02)
kalali added a comment to T27969: Toggling "Show cross hair" in a render window menu does not update the check state in other render window menus.

This also happens for the rotation mode. The proposed changes fix both.

Nov 30 2020, 3:51 PM · Noteworthy, MITK (v2021.02)
kalali added a revision to T27969: Toggling "Show cross hair" in a render window menu does not update the check state in other render window menus: Unknown Object (Differential Revision).
Nov 30 2020, 3:50 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T26449: XNAT connection failes due to missing OpenSSL connections.

Pushed new branch bugfix/T26449-XNAT-OpenSSL.

Nov 30 2020, 3:22 PM · Noteworthy, MITK (v2021.02)
kislinsk reopened T26449: XNAT connection failes due to missing OpenSSL connections as "Open".

It is not acceptable that there is a hidden manual process involved. There's legacy code in the XNAT plugin's CMakeLists.txt that tries to do that automatically but fails as it copies/installs the wrong files. To make the whole thing more visible, I will add the following two CMake cache variables to set the two DLLs. Manual copying and installing shouldn't be neccessary anymore then.

Nov 30 2020, 2:51 PM · Noteworthy, MITK (v2021.02)
kislinsk closed T27383: Update external toolkits as Resolved.

All experimental CI clients succeeded. Merged into develop.

Nov 30 2020, 1:13 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27383: Update external toolkits.

Deleted branch feature/T27383-UpdateExternalToolkits.

Nov 30 2020, 1:12 PM · Noteworthy, MITK (v2021.02)
kislinsk committed rMITK9874d31b713b: Update CTK (authored by kislinsk).
Update CTK
Nov 30 2020, 1:12 PM
kislinsk committed rMITK5d038485ea3e: Update cpprestsdk (authored by kislinsk).
Update cpprestsdk
Nov 30 2020, 1:12 PM
kislinsk committed rMITK57974357d5a2: Update GDCM (authored by kislinsk).
Update GDCM
Nov 30 2020, 1:12 PM
kislinsk committed rMITK5510b6fa5197: Update DCMQI (authored by kislinsk).
Update DCMQI
Nov 30 2020, 1:12 PM
kislinsk committed rMITK281619c2322d: Update CppUnit (authored by kislinsk).
Update CppUnit
Nov 30 2020, 1:12 PM
kislinsk committed rMITKdbaabe8ae3d9: Automatically set minimum required version of Qt5 in documentation (authored by kislinsk).
Automatically set minimum required version of Qt5 in documentation
Nov 30 2020, 1:12 PM
kislinsk committed rMITKd023c47ada6a: Update Boost (authored by kislinsk).
Update Boost
Nov 30 2020, 1:12 PM
kislinsk committed rMITKd17a6809c901: Increase minimum required version of CMake to 3.18 (authored by kislinsk).
Increase minimum required version of CMake to 3.18
Nov 30 2020, 1:12 PM
kislinsk committed rMITK4b76000c2bc4: Auto-clean updated external projects by default (authored by kislinsk).
Auto-clean updated external projects by default
Nov 30 2020, 1:12 PM
kislinsk committed rMITK4a46a7bbaf45: Use clang toolset on macOS (authored by kislinsk).
Use clang toolset on macOS
Nov 30 2020, 1:12 PM
kislinsk committed rMITK7efb747b216f: Do not add PCRE as dependency on Windows (authored by kislinsk).
Do not add PCRE as dependency on Windows
Nov 30 2020, 1:12 PM
kislinsk committed rMITK267ccffb09a0: Upgrade Qwt from v6.1.0 to v6.1.5 (authored by kislinsk).
Upgrade Qwt from v6.1.0 to v6.1.5
Nov 30 2020, 1:12 PM
kislinsk committed rMITK9ad33a15dfda: Merge branch 'feature/T27383-UpdateExternalToolkits' into develop (authored by kislinsk).
Merge branch 'feature/T27383-UpdateExternalToolkits' into develop
Nov 30 2020, 1:12 PM
kislinsk added a comment to T27383: Update external toolkits.

Poco 1.10.1 isn't a trivial update. It's known that Poco messes around with all the defines of Windows.h and there's a compiler definition POCO_NO_UNWINDOWS to control it that we use. However, something changed in Poco and all kinds of compiler and linker errors pop up even in unrelated modules and plugins as header declarations and implementations may differ, or method names are suddenly masked by definitions. It's hard to narrow it down as we seem to use a mix of both modes. So I call it a night for this task with all the updates mentioned above. Everything else is probably worth own dedicated tasks if necessary. The next big update we should focus on is ITK, though.

Nov 30 2020, 1:02 PM · Noteworthy, MITK (v2021.02)
schererj added a comment to T27968: CTP gets stuck on large import.

No, the data has not been sent before.
There were only completely different images already stored.
Also OHIF was not showing any of the new sent data at all.

Nov 30 2020, 11:35 AM · Kaapana (internal)
gaoh added a comment to T27968: CTP gets stuck on large import.

Have you checked, if the dataset (or the slices) are already in the PACs. In my case (I got the error, when sending data from airflow to the PACs), the files creating the 409 were already in DCM4CHE.

Nov 30 2020, 11:33 AM · Kaapana (internal)
schererj added a comment to T27968: CTP gets stuck on large import.

Regarding 1: This is done to ensure that you are notfied if a problem arrises in the dcmsend step?

Yes, exactly and we have full control over the binary and parameters used for the data-transfer (eg storescu, dcmsend or DICOMweb-send etc.)

Nov 30 2020, 11:25 AM · Kaapana (internal)
schererj triaged T27968: CTP gets stuck on large import as Unbreak Now! priority.

Got similar issues with a "normal" data import.
So I just sent a couple images and got many of the following errors in CTP:

Nov 30 2020, 11:15 AM · Kaapana (internal)
gaoh added a comment to T24398: Dicom plugin: Retrieve does not work.

Oh sorry, I thought it was clear, because the title is wDB related:
I used the wDB. I did not test it with a different PACs system, but I can try and report back...

Nov 30 2020, 9:17 AM · MITK (v2024.06)

Nov 29 2020

kislinsk added a comment to T27383: Update external toolkits.

Our current version of ITK does not compile with OpenCV 3.4.12.

Nov 29 2020, 7:54 AM · Noteworthy, MITK (v2021.02)

Nov 28 2020

floca added a project to T24398: Dicom plugin: Retrieve does not work: Missing Info.

@gaoh Could you please specify which PACs you used to provoke the error. Or did it have this problem with multiple systems?

Nov 28 2020, 10:00 PM · MITK (v2024.06)
kislinsk added a comment to T27383: Update external toolkits.

Eigen update to v3.3.8 does not work. We have to wait for v3.3.9 which is going to be released in the next few days, according to https://gitlab.com/libeigen/eigen/-/issues/2011.

Nov 28 2020, 9:42 PM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27383: Update external toolkits.
DependencyOld versionNew version
Boost1.701.74
cpprestsdk2.10.102.10.16
CMake3.14.53.18
CppUnit1.12.11.15.1
CTK78341aba (Dec 07, 2019)7210c5bc (Nov 08, 2020)
DCMQIea4f0809 (Jan 23, 2020)99192b76 (Nov 06, 2020)
GDCM3.0.43.0.8
Qwt6.1.06.1.5
Nov 28 2020, 11:28 AM · Noteworthy, MITK (v2021.02)
kislinsk added a comment to T27383: Update external toolkits.

Pushed new branch feature/T27383-UpdateExternalToolkits.

Nov 28 2020, 6:05 AM · Noteworthy, MITK (v2021.02)
kislinsk claimed T27383: Update external toolkits.
Nov 28 2020, 5:22 AM · Noteworthy, MITK (v2021.02)
kislinsk closed T26451: DICOM plugin cannot parse DICOM directories in macOS installer as Resolved.

I close this task as it is very likely fixed in T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers. Please re-open if it is not the case for you by using the workaround or building the latest develop version . :-)

Nov 28 2020, 5:15 AM · MITK
kislinsk closed T26451: DICOM plugin cannot parse DICOM directories in macOS installer, a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Nov 28 2020, 5:15 AM · MITK (v2024.06), Cleared
kislinsk edited projects for T24398: Dicom plugin: Retrieve does not work, added: MITK (v2021.02); removed MITK.
Nov 28 2020, 5:12 AM · MITK (v2024.06)
kislinsk removed a parent task for T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers: T24398: Dicom plugin: Retrieve does not work.
Nov 28 2020, 5:12 AM · Cleared, MITK (v2021.02)
kislinsk removed a subtask for T24398: Dicom plugin: Retrieve does not work: T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.
Nov 28 2020, 5:12 AM · MITK (v2024.06)
kislinsk closed T27669: Dicom import issue with MITK binaries (package) and Ubuntu, a subtask of T27196: Rewrite packaging of MITK, as Resolved.
Nov 28 2020, 5:11 AM · MITK (v2024.06), Cleared
kislinsk closed T27669: Dicom import issue with MITK binaries (package) and Ubuntu as Resolved.

Fixed in T26164: DICOM Query/Retrieve doesn't work at least in Ubuntu release installers.

Nov 28 2020, 5:11 AM · Missing Info, DICOM, MITK